blob: 707ac63f73f8fc37c0c150a8efcbb046ac00df07 [file] [log] [blame]
Jiyong Park9b409bc2019-10-11 14:59:13 +09001// Copyright (C) 2019 The Android Open Source Project
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package sdk
16
17import (
18 "fmt"
Paul Duffinb645ec82019-11-27 17:43:54 +000019 "reflect"
Paul Duffina04c1072020-03-02 10:16:35 +000020 "sort"
Jiyong Park9b409bc2019-10-11 14:59:13 +090021 "strings"
22
Paul Duffin7d74e7b2020-03-06 12:30:13 +000023 "android/soong/apex"
Paul Duffin9b76c0b2020-03-12 10:24:35 +000024 "android/soong/cc"
Colin Cross440e0d02020-06-11 11:32:11 -070025
Paul Duffin375058f2019-11-29 20:17:53 +000026 "github.com/google/blueprint"
Jiyong Park9b409bc2019-10-11 14:59:13 +090027 "github.com/google/blueprint/proptools"
28
29 "android/soong/android"
Jiyong Park9b409bc2019-10-11 14:59:13 +090030)
31
Paul Duffin64fb5262021-05-05 21:36:04 +010032// Environment variables that affect the generated snapshot
33// ========================================================
34//
35// SOONG_SDK_SNAPSHOT_PREFER
36// By default every unversioned module in the generated snapshot has prefer: false. Building it
37// with SOONG_SDK_SNAPSHOT_PREFER=true will force them to use prefer: true.
38//
39
Jiyong Park9b409bc2019-10-11 14:59:13 +090040var pctx = android.NewPackageContext("android/soong/sdk")
41
Paul Duffin375058f2019-11-29 20:17:53 +000042var (
43 repackageZip = pctx.AndroidStaticRule("SnapshotRepackageZip",
44 blueprint.RuleParams{
Paul Duffince482dc2019-12-09 19:58:17 +000045 Command: `${config.Zip2ZipCmd} -i $in -o $out -x META-INF/**/* "**/*:$destdir"`,
Paul Duffin375058f2019-11-29 20:17:53 +000046 CommandDeps: []string{
47 "${config.Zip2ZipCmd}",
48 },
49 },
50 "destdir")
51
52 zipFiles = pctx.AndroidStaticRule("SnapshotZipFiles",
53 blueprint.RuleParams{
Colin Cross053fca12020-08-19 13:51:47 -070054 Command: `${config.SoongZipCmd} -C $basedir -r $out.rsp -o $out`,
Paul Duffin375058f2019-11-29 20:17:53 +000055 CommandDeps: []string{
56 "${config.SoongZipCmd}",
57 },
58 Rspfile: "$out.rsp",
59 RspfileContent: "$in",
60 },
61 "basedir")
62
63 mergeZips = pctx.AndroidStaticRule("SnapshotMergeZips",
64 blueprint.RuleParams{
65 Command: `${config.MergeZipsCmd} $out $in`,
66 CommandDeps: []string{
67 "${config.MergeZipsCmd}",
68 },
69 })
70)
71
Paul Duffinb645ec82019-11-27 17:43:54 +000072type generatedContents struct {
Jiyong Park73c54ee2019-10-22 20:31:18 +090073 content strings.Builder
74 indentLevel int
Jiyong Park9b409bc2019-10-11 14:59:13 +090075}
76
Paul Duffinb645ec82019-11-27 17:43:54 +000077// generatedFile abstracts operations for writing contents into a file and emit a build rule
78// for the file.
79type generatedFile struct {
80 generatedContents
81 path android.OutputPath
82}
83
Jiyong Park232e7852019-11-04 12:23:40 +090084func newGeneratedFile(ctx android.ModuleContext, path ...string) *generatedFile {
Jiyong Park9b409bc2019-10-11 14:59:13 +090085 return &generatedFile{
Paul Duffinb645ec82019-11-27 17:43:54 +000086 path: android.PathForModuleOut(ctx, path...).OutputPath,
Jiyong Park9b409bc2019-10-11 14:59:13 +090087 }
88}
89
Paul Duffinb645ec82019-11-27 17:43:54 +000090func (gc *generatedContents) Indent() {
91 gc.indentLevel++
Jiyong Park73c54ee2019-10-22 20:31:18 +090092}
93
Paul Duffinb645ec82019-11-27 17:43:54 +000094func (gc *generatedContents) Dedent() {
95 gc.indentLevel--
Jiyong Park73c54ee2019-10-22 20:31:18 +090096}
97
Paul Duffinb645ec82019-11-27 17:43:54 +000098func (gc *generatedContents) Printfln(format string, args ...interface{}) {
Paul Duffin11108272020-05-11 22:59:25 +010099 fmt.Fprintf(&(gc.content), strings.Repeat(" ", gc.indentLevel)+format+"\n", args...)
Jiyong Park9b409bc2019-10-11 14:59:13 +0900100}
101
102func (gf *generatedFile) build(pctx android.PackageContext, ctx android.BuilderContext, implicits android.Paths) {
Colin Crossf1a035e2020-11-16 17:32:30 -0800103 rb := android.NewRuleBuilder(pctx, ctx)
Paul Duffin11108272020-05-11 22:59:25 +0100104
105 content := gf.content.String()
106
107 // ninja consumes newline characters in rspfile_content. Prevent it by
108 // escaping the backslash in the newline character. The extra backslash
109 // is removed when the rspfile is written to the actual script file
110 content = strings.ReplaceAll(content, "\n", "\\n")
111
Jiyong Park9b409bc2019-10-11 14:59:13 +0900112 rb.Command().
113 Implicits(implicits).
Martin Stjernholmee9b24e2021-04-20 15:54:21 +0100114 Text("echo -n").Text(proptools.ShellEscape(content)).
Paul Duffin11108272020-05-11 22:59:25 +0100115 // convert \\n to \n
Jiyong Park9b409bc2019-10-11 14:59:13 +0900116 Text("| sed 's/\\\\n/\\n/g' >").Output(gf.path)
117 rb.Command().
118 Text("chmod a+x").Output(gf.path)
Colin Crossf1a035e2020-11-16 17:32:30 -0800119 rb.Build(gf.path.Base(), "Build "+gf.path.Base())
Jiyong Park9b409bc2019-10-11 14:59:13 +0900120}
121
Paul Duffin13879572019-11-28 14:31:38 +0000122// Collect all the members.
123//
Paul Duffincc3132e2021-04-24 01:10:30 +0100124// Updates the sdk module with a list of sdkMemberVariantDeps and details as to which multilibs
125// (32/64/both) are used by this sdk variant.
Paul Duffin6a7e9532020-03-20 17:50:07 +0000126func (s *sdk) collectMembers(ctx android.ModuleContext) {
127 s.multilibUsages = multilibNone
Paul Duffinf4ae4f12020-01-13 20:58:25 +0000128 ctx.WalkDeps(func(child android.Module, parent android.Module) bool {
129 tag := ctx.OtherModuleDependencyTag(child)
Paul Duffinf8539922019-11-19 19:44:10 +0000130 if memberTag, ok := tag.(android.SdkMemberTypeDependencyTag); ok {
Paul Duffineee466e2021-04-27 23:17:56 +0100131 memberType := memberTag.SdkMemberType(child)
Jiyong Park9b409bc2019-10-11 14:59:13 +0900132
Paul Duffin13879572019-11-28 14:31:38 +0000133 // Make sure that the resolved module is allowed in the member list property.
Paul Duffinf4ae4f12020-01-13 20:58:25 +0000134 if !memberType.IsInstance(child) {
135 ctx.ModuleErrorf("module %q is not valid in property %s", ctx.OtherModuleName(child), memberType.SdkPropertyName())
Jiyong Park73c54ee2019-10-22 20:31:18 +0900136 }
Paul Duffin13879572019-11-28 14:31:38 +0000137
Paul Duffin6a7e9532020-03-20 17:50:07 +0000138 // Keep track of which multilib variants are used by the sdk.
139 s.multilibUsages = s.multilibUsages.addArchType(child.Target().Arch.ArchType)
140
Paul Duffina7208112021-04-23 21:20:20 +0100141 export := memberTag.ExportMember()
Paul Duffincd064672021-04-24 00:47:29 +0100142 s.memberVariantDeps = append(s.memberVariantDeps, sdkMemberVariantDep{s, memberType, child.(android.SdkAware), export})
Paul Duffinf4ae4f12020-01-13 20:58:25 +0000143
Paul Duffin2d3da312021-05-06 12:02:27 +0100144 // Recurse down into the member's dependencies as it may have dependencies that need to be
145 // automatically added to the sdk.
146 return true
Jiyong Park73c54ee2019-10-22 20:31:18 +0900147 }
Paul Duffinf4ae4f12020-01-13 20:58:25 +0000148
149 return false
Paul Duffin13879572019-11-28 14:31:38 +0000150 })
Paul Duffin1356d8c2020-02-25 19:26:33 +0000151}
152
Paul Duffincc3132e2021-04-24 01:10:30 +0100153// groupMemberVariantsByMemberThenType groups the member variant dependencies so that all the
154// variants of each member are grouped together within an sdkMember instance.
Paul Duffin1356d8c2020-02-25 19:26:33 +0000155//
Paul Duffincc3132e2021-04-24 01:10:30 +0100156// The sdkMember instances are then grouped into slices by member type. Within each such slice the
157// sdkMember instances appear in the order they were added as dependencies.
Paul Duffin1356d8c2020-02-25 19:26:33 +0000158//
Paul Duffincc3132e2021-04-24 01:10:30 +0100159// Finally, the member type slices are concatenated together to form a single slice. The order in
160// which they are concatenated is the order in which the member types were registered in the
161// android.SdkMemberTypesRegistry.
162func (s *sdk) groupMemberVariantsByMemberThenType(ctx android.ModuleContext, memberVariantDeps []sdkMemberVariantDep) []*sdkMember {
Paul Duffin1356d8c2020-02-25 19:26:33 +0000163 byType := make(map[android.SdkMemberType][]*sdkMember)
164 byName := make(map[string]*sdkMember)
165
Paul Duffin21827262021-04-24 12:16:36 +0100166 for _, memberVariantDep := range memberVariantDeps {
167 memberType := memberVariantDep.memberType
168 variant := memberVariantDep.variant
Paul Duffin1356d8c2020-02-25 19:26:33 +0000169
170 name := ctx.OtherModuleName(variant)
171 member := byName[name]
172 if member == nil {
173 member = &sdkMember{memberType: memberType, name: name}
174 byName[name] = member
175 byType[memberType] = append(byType[memberType], member)
176 }
177
Paul Duffin1356d8c2020-02-25 19:26:33 +0000178 // Only append new variants to the list. This is needed because a member can be both
179 // exported by the sdk and also be a transitive sdk member.
180 member.variants = appendUniqueVariants(member.variants, variant)
181 }
182
Paul Duffin13879572019-11-28 14:31:38 +0000183 var members []*sdkMember
Paul Duffin72910952020-01-20 18:16:30 +0000184 for _, memberListProperty := range s.memberListProperties() {
Paul Duffin13879572019-11-28 14:31:38 +0000185 membersOfType := byType[memberListProperty.memberType]
186 members = append(members, membersOfType...)
Jiyong Park9b409bc2019-10-11 14:59:13 +0900187 }
188
Paul Duffin6a7e9532020-03-20 17:50:07 +0000189 return members
Jiyong Park73c54ee2019-10-22 20:31:18 +0900190}
Jiyong Park9b409bc2019-10-11 14:59:13 +0900191
Paul Duffin72910952020-01-20 18:16:30 +0000192func appendUniqueVariants(variants []android.SdkAware, newVariant android.SdkAware) []android.SdkAware {
193 for _, v := range variants {
194 if v == newVariant {
195 return variants
196 }
197 }
198 return append(variants, newVariant)
199}
200
Jiyong Park73c54ee2019-10-22 20:31:18 +0900201// SDK directory structure
202// <sdk_root>/
203// Android.bp : definition of a 'sdk' module is here. This is a hand-made one.
204// <api_ver>/ : below this directory are all auto-generated
205// Android.bp : definition of 'sdk_snapshot' module is here
206// aidl/
207// frameworks/base/core/..../IFoo.aidl : an exported AIDL file
208// java/
Jiyong Park232e7852019-11-04 12:23:40 +0900209// <module_name>.jar : the stub jar for a java library 'module_name'
Jiyong Park73c54ee2019-10-22 20:31:18 +0900210// include/
211// bionic/libc/include/stdlib.h : an exported header file
212// include_gen/
Jiyong Park232e7852019-11-04 12:23:40 +0900213// <module_name>/com/android/.../IFoo.h : a generated header file
Jiyong Park73c54ee2019-10-22 20:31:18 +0900214// <arch>/include/ : arch-specific exported headers
215// <arch>/include_gen/ : arch-specific generated headers
216// <arch>/lib/
217// libFoo.so : a stub library
218
Jiyong Park232e7852019-11-04 12:23:40 +0900219// A name that uniquely identifies a prebuilt SDK member for a version of SDK snapshot
Jiyong Park73c54ee2019-10-22 20:31:18 +0900220// This isn't visible to users, so could be changed in future.
221func versionedSdkMemberName(ctx android.ModuleContext, memberName string, version string) string {
222 return ctx.ModuleName() + "_" + memberName + string(android.SdkVersionSeparator) + version
223}
224
Jiyong Park232e7852019-11-04 12:23:40 +0900225// buildSnapshot is the main function in this source file. It creates rules to copy
226// the contents (header files, stub libraries, etc) into the zip file.
Paul Duffin1356d8c2020-02-25 19:26:33 +0000227func (s *sdk) buildSnapshot(ctx android.ModuleContext, sdkVariants []*sdk) android.OutputPath {
228
Paul Duffin13f02712020-03-06 12:30:43 +0000229 allMembersByName := make(map[string]struct{})
230 exportedMembersByName := make(map[string]struct{})
Paul Duffin21827262021-04-24 12:16:36 +0100231 var memberVariantDeps []sdkMemberVariantDep
Paul Duffin1356d8c2020-02-25 19:26:33 +0000232 for _, sdkVariant := range sdkVariants {
Paul Duffin21827262021-04-24 12:16:36 +0100233 memberVariantDeps = append(memberVariantDeps, sdkVariant.memberVariantDeps...)
Paul Duffin865171e2020-03-02 18:38:15 +0000234
Paul Duffin13f02712020-03-06 12:30:43 +0000235 // Record the names of all the members, both explicitly specified and implicitly
236 // included.
Paul Duffin21827262021-04-24 12:16:36 +0100237 for _, memberVariantDep := range sdkVariant.memberVariantDeps {
Paul Duffina7208112021-04-23 21:20:20 +0100238 name := memberVariantDep.variant.Name()
239 allMembersByName[name] = struct{}{}
Paul Duffin13f02712020-03-06 12:30:43 +0000240
Paul Duffina7208112021-04-23 21:20:20 +0100241 if memberVariantDep.export {
242 exportedMembersByName[name] = struct{}{}
243 }
Paul Duffin865171e2020-03-02 18:38:15 +0000244 }
Paul Duffin1356d8c2020-02-25 19:26:33 +0000245 }
246
Paul Duffin0e0cf1d2019-11-12 19:39:25 +0000247 snapshotDir := android.PathForModuleOut(ctx, "snapshot")
Jiyong Park9b409bc2019-10-11 14:59:13 +0900248
Paul Duffin0e0cf1d2019-11-12 19:39:25 +0000249 bp := newGeneratedFile(ctx, "snapshot", "Android.bp")
Paul Duffinb645ec82019-11-27 17:43:54 +0000250
251 bpFile := &bpFile{
252 modules: make(map[string]*bpModule),
253 }
Paul Duffin0e0cf1d2019-11-12 19:39:25 +0000254
255 builder := &snapshotBuilder{
Paul Duffin13f02712020-03-06 12:30:43 +0000256 ctx: ctx,
257 sdk: s,
258 version: "current",
259 snapshotDir: snapshotDir.OutputPath,
260 copies: make(map[string]string),
261 filesToZip: []android.Path{bp.path},
262 bpFile: bpFile,
263 prebuiltModules: make(map[string]*bpModule),
264 allMembersByName: allMembersByName,
265 exportedMembersByName: exportedMembersByName,
Jiyong Park73c54ee2019-10-22 20:31:18 +0900266 }
Paul Duffinac37c502019-11-26 18:02:20 +0000267 s.builderForTests = builder
Jiyong Park9b409bc2019-10-11 14:59:13 +0900268
Paul Duffincc3132e2021-04-24 01:10:30 +0100269 // Create the prebuilt modules for each of the member modules.
270 members := s.groupMemberVariantsByMemberThenType(ctx, memberVariantDeps)
Paul Duffin13ad94f2020-02-19 16:19:27 +0000271 for _, member := range members {
Paul Duffin88f2fbe2020-02-27 16:00:53 +0000272 memberType := member.memberType
Paul Duffin3a4eb502020-03-19 16:11:18 +0000273
Paul Duffina551a1c2020-03-17 21:04:24 +0000274 memberCtx := &memberContext{ctx, builder, memberType, member.name}
Paul Duffin3a4eb502020-03-19 16:11:18 +0000275
276 prebuiltModule := memberType.AddPrebuiltModule(memberCtx, member)
Martin Stjernholmcaa47d72020-07-11 04:52:24 +0100277 s.createMemberSnapshot(memberCtx, member, prebuiltModule.(*bpModule))
Jiyong Park73c54ee2019-10-22 20:31:18 +0900278 }
Jiyong Park9b409bc2019-10-11 14:59:13 +0900279
Paul Duffine6c0d842020-01-15 14:08:51 +0000280 // Create a transformer that will transform an unversioned module into a versioned module.
281 unversionedToVersionedTransformer := unversionedToVersionedTransformation{builder: builder}
282
Paul Duffin72910952020-01-20 18:16:30 +0000283 // Create a transformer that will transform an unversioned module by replacing any references
284 // to internal members with a unique module name and setting prefer: false.
Paul Duffin64fb5262021-05-05 21:36:04 +0100285 unversionedTransformer := unversionedTransformation{
286 builder: builder,
Paul Duffin64fb5262021-05-05 21:36:04 +0100287 }
Paul Duffin72910952020-01-20 18:16:30 +0000288
Paul Duffinb645ec82019-11-27 17:43:54 +0000289 for _, unversioned := range builder.prebuiltOrder {
Paul Duffina78f3a72020-02-21 16:29:35 +0000290 // Prune any empty property sets.
291 unversioned = unversioned.transform(pruneEmptySetTransformer{})
292
Paul Duffinb645ec82019-11-27 17:43:54 +0000293 // Copy the unversioned module so it can be modified to make it versioned.
Paul Duffincc72e982020-01-14 15:53:11 +0000294 versioned := unversioned.deepCopy()
Paul Duffine6c0d842020-01-15 14:08:51 +0000295
296 // Transform the unversioned module into a versioned one.
297 versioned.transform(unversionedToVersionedTransformer)
Paul Duffinb645ec82019-11-27 17:43:54 +0000298 bpFile.AddModule(versioned)
Paul Duffin0e0cf1d2019-11-12 19:39:25 +0000299
Paul Duffin72910952020-01-20 18:16:30 +0000300 // Transform the unversioned module to make it suitable for use in the snapshot.
301 unversioned.transform(unversionedTransformer)
Paul Duffinb645ec82019-11-27 17:43:54 +0000302 bpFile.AddModule(unversioned)
303 }
304
Paul Duffin26197a62021-04-24 00:34:10 +0100305 // Add the sdk/module_exports_snapshot module to the bp file.
Paul Duffin21827262021-04-24 12:16:36 +0100306 s.addSnapshotModule(ctx, builder, sdkVariants, memberVariantDeps)
Paul Duffin26197a62021-04-24 00:34:10 +0100307
308 // generate Android.bp
309 bp = newGeneratedFile(ctx, "snapshot", "Android.bp")
310 generateBpContents(&bp.generatedContents, bpFile)
311
312 contents := bp.content.String()
313 syntaxCheckSnapshotBpFile(ctx, contents)
314
315 bp.build(pctx, ctx, nil)
316
317 filesToZip := builder.filesToZip
318
319 // zip them all
320 outputZipFile := android.PathForModuleOut(ctx, ctx.ModuleName()+"-current.zip").OutputPath
321 outputDesc := "Building snapshot for " + ctx.ModuleName()
322
323 // If there are no zips to merge then generate the output zip directly.
324 // Otherwise, generate an intermediate zip file into which other zips can be
325 // merged.
326 var zipFile android.OutputPath
327 var desc string
328 if len(builder.zipsToMerge) == 0 {
329 zipFile = outputZipFile
330 desc = outputDesc
331 } else {
332 zipFile = android.PathForModuleOut(ctx, ctx.ModuleName()+"-current.unmerged.zip").OutputPath
333 desc = "Building intermediate snapshot for " + ctx.ModuleName()
334 }
335
336 ctx.Build(pctx, android.BuildParams{
337 Description: desc,
338 Rule: zipFiles,
339 Inputs: filesToZip,
340 Output: zipFile,
341 Args: map[string]string{
342 "basedir": builder.snapshotDir.String(),
343 },
344 })
345
346 if len(builder.zipsToMerge) != 0 {
347 ctx.Build(pctx, android.BuildParams{
348 Description: outputDesc,
349 Rule: mergeZips,
350 Input: zipFile,
351 Inputs: builder.zipsToMerge,
352 Output: outputZipFile,
353 })
354 }
355
356 return outputZipFile
357}
358
359// addSnapshotModule adds the sdk_snapshot/module_exports_snapshot module to the builder.
Paul Duffin21827262021-04-24 12:16:36 +0100360func (s *sdk) addSnapshotModule(ctx android.ModuleContext, builder *snapshotBuilder, sdkVariants []*sdk, memberVariantDeps []sdkMemberVariantDep) {
Paul Duffin26197a62021-04-24 00:34:10 +0100361 bpFile := builder.bpFile
362
Paul Duffinb645ec82019-11-27 17:43:54 +0000363 snapshotName := ctx.ModuleName() + string(android.SdkVersionSeparator) + builder.version
Paul Duffin8150da62019-12-16 17:21:27 +0000364 var snapshotModuleType string
365 if s.properties.Module_exports {
366 snapshotModuleType = "module_exports_snapshot"
367 } else {
368 snapshotModuleType = "sdk_snapshot"
369 }
370 snapshotModule := bpFile.newModule(snapshotModuleType)
Paul Duffinb645ec82019-11-27 17:43:54 +0000371 snapshotModule.AddProperty("name", snapshotName)
Paul Duffin593b3c92019-12-05 14:31:48 +0000372
373 // Make sure that the snapshot has the same visibility as the sdk.
Paul Duffin157f40f2020-09-29 16:01:08 +0100374 visibility := android.EffectiveVisibilityRules(ctx, s).Strings()
Paul Duffin593b3c92019-12-05 14:31:48 +0000375 if len(visibility) != 0 {
376 snapshotModule.AddProperty("visibility", visibility)
377 }
378
Paul Duffin865171e2020-03-02 18:38:15 +0000379 addHostDeviceSupportedProperties(s.ModuleBase.DeviceSupported(), s.ModuleBase.HostSupported(), snapshotModule)
Paul Duffin13ad94f2020-02-19 16:19:27 +0000380
Paul Duffincd064672021-04-24 00:47:29 +0100381 combinedPropertiesList := s.collateSnapshotModuleInfo(ctx, sdkVariants, memberVariantDeps)
Paul Duffin2d1bb892021-04-24 11:32:59 +0100382 commonCombinedProperties := s.optimizeSnapshotModuleProperties(ctx, combinedPropertiesList)
Paul Duffin865171e2020-03-02 18:38:15 +0000383
Paul Duffin2d1bb892021-04-24 11:32:59 +0100384 s.addSnapshotPropertiesToPropertySet(builder, snapshotModule, commonCombinedProperties)
Martin Stjernholm4cfa2c62020-07-10 19:55:36 +0100385
Paul Duffin6a7e9532020-03-20 17:50:07 +0000386 targetPropertySet := snapshotModule.AddPropertySet("target")
Martin Stjernholmcaa47d72020-07-11 04:52:24 +0100387
Paul Duffin2d1bb892021-04-24 11:32:59 +0100388 // Create a mapping from osType to combined properties.
389 osTypeToCombinedProperties := map[android.OsType]*combinedSnapshotModuleProperties{}
390 for _, combined := range combinedPropertiesList {
391 osTypeToCombinedProperties[combined.sdkVariant.Os()] = combined
392 }
393
Martin Stjernholmcaa47d72020-07-11 04:52:24 +0100394 // Iterate over the os types in a fixed order.
Paul Duffin865171e2020-03-02 18:38:15 +0000395 for _, osType := range s.getPossibleOsTypes() {
Paul Duffin2d1bb892021-04-24 11:32:59 +0100396 if combined, ok := osTypeToCombinedProperties[osType]; ok {
Paul Duffincc3132e2021-04-24 01:10:30 +0100397 osPropertySet := targetPropertySet.AddPropertySet(osType.Name)
Paul Duffin6a7e9532020-03-20 17:50:07 +0000398
Paul Duffin2d1bb892021-04-24 11:32:59 +0100399 s.addSnapshotPropertiesToPropertySet(builder, osPropertySet, combined)
Paul Duffin13879572019-11-28 14:31:38 +0000400 }
Paul Duffin0e0cf1d2019-11-12 19:39:25 +0000401 }
Paul Duffin865171e2020-03-02 18:38:15 +0000402
Jiyong Park8fe14e62020-10-19 22:47:34 +0900403 // If host is supported and any member is host OS dependent then disable host
404 // by default, so that we can enable each host OS variant explicitly. This
405 // avoids problems with implicitly enabled OS variants when the snapshot is
406 // used, which might be different from this run (e.g. different build OS).
407 if s.HostSupported() {
408 var supportedHostTargets []string
Paul Duffin21827262021-04-24 12:16:36 +0100409 for _, memberVariantDep := range memberVariantDeps {
410 if memberVariantDep.memberType.IsHostOsDependent() && memberVariantDep.variant.Target().Os.Class == android.Host {
411 targetString := memberVariantDep.variant.Target().Os.String() + "_" + memberVariantDep.variant.Target().Arch.ArchType.String()
Jiyong Park8fe14e62020-10-19 22:47:34 +0900412 if !android.InList(targetString, supportedHostTargets) {
413 supportedHostTargets = append(supportedHostTargets, targetString)
414 }
415 }
416 }
417 if len(supportedHostTargets) > 0 {
418 hostPropertySet := targetPropertySet.AddPropertySet("host")
419 hostPropertySet.AddProperty("enabled", false)
420 }
421 // Enable the <os>_<arch> variant explicitly when we've disabled it by default on host.
422 for _, hostTarget := range supportedHostTargets {
423 propertySet := targetPropertySet.AddPropertySet(hostTarget)
424 propertySet.AddProperty("enabled", true)
425 }
426 }
427
Paul Duffin865171e2020-03-02 18:38:15 +0000428 // Prune any empty property sets.
429 snapshotModule.transform(pruneEmptySetTransformer{})
430
Paul Duffinb645ec82019-11-27 17:43:54 +0000431 bpFile.AddModule(snapshotModule)
Jiyong Park9b409bc2019-10-11 14:59:13 +0900432}
Paul Duffin0e0cf1d2019-11-12 19:39:25 +0000433
Paul Duffinf88d8e02020-05-07 20:21:34 +0100434// Check the syntax of the generated Android.bp file contents and if they are
435// invalid then log an error with the contents (tagged with line numbers) and the
436// errors that were found so that it is easy to see where the problem lies.
437func syntaxCheckSnapshotBpFile(ctx android.ModuleContext, contents string) {
438 errs := android.CheckBlueprintSyntax(ctx, "Android.bp", contents)
439 if len(errs) != 0 {
440 message := &strings.Builder{}
441 _, _ = fmt.Fprint(message, `errors in generated Android.bp snapshot:
442
443Generated Android.bp contents
444========================================================================
445`)
446 for i, line := range strings.Split(contents, "\n") {
447 _, _ = fmt.Fprintf(message, "%6d: %s\n", i+1, line)
448 }
449
450 _, _ = fmt.Fprint(message, `
451========================================================================
452
453Errors found:
454`)
455
456 for _, err := range errs {
457 _, _ = fmt.Fprintf(message, "%s\n", err.Error())
458 }
459
460 ctx.ModuleErrorf("%s", message.String())
461 }
462}
463
Paul Duffin4b8b7932020-05-06 12:35:38 +0100464func extractCommonProperties(ctx android.ModuleContext, extractor *commonValueExtractor, commonProperties interface{}, inputPropertiesSlice interface{}) {
465 err := extractor.extractCommonProperties(commonProperties, inputPropertiesSlice)
466 if err != nil {
467 ctx.ModuleErrorf("error extracting common properties: %s", err)
468 }
469}
470
Paul Duffinfbe470e2021-04-24 12:37:13 +0100471// snapshotModuleStaticProperties contains snapshot static (i.e. not dynamically generated) properties.
472type snapshotModuleStaticProperties struct {
473 Compile_multilib string `android:"arch_variant"`
474}
475
Paul Duffin2d1bb892021-04-24 11:32:59 +0100476// combinedSnapshotModuleProperties are the properties that are associated with the snapshot module.
477type combinedSnapshotModuleProperties struct {
478 // The sdk variant from which this information was collected.
479 sdkVariant *sdk
480
481 // Static snapshot module properties.
482 staticProperties *snapshotModuleStaticProperties
483
484 // The dynamically generated member list properties.
485 dynamicProperties interface{}
486}
487
488// collateSnapshotModuleInfo collates all the snapshot module info from supplied sdk variants.
Paul Duffincd064672021-04-24 00:47:29 +0100489func (s *sdk) collateSnapshotModuleInfo(ctx android.BaseModuleContext, sdkVariants []*sdk, memberVariantDeps []sdkMemberVariantDep) []*combinedSnapshotModuleProperties {
490 sdkVariantToCombinedProperties := map[*sdk]*combinedSnapshotModuleProperties{}
Paul Duffin2d1bb892021-04-24 11:32:59 +0100491 var list []*combinedSnapshotModuleProperties
492 for _, sdkVariant := range sdkVariants {
493 staticProperties := &snapshotModuleStaticProperties{
494 Compile_multilib: sdkVariant.multilibUsages.String(),
495 }
Paul Duffincd064672021-04-24 00:47:29 +0100496 dynamicProperties := s.dynamicSdkMemberTypes.createMemberListProperties()
Paul Duffin2d1bb892021-04-24 11:32:59 +0100497
Paul Duffincd064672021-04-24 00:47:29 +0100498 combinedProperties := &combinedSnapshotModuleProperties{
Paul Duffin2d1bb892021-04-24 11:32:59 +0100499 sdkVariant: sdkVariant,
500 staticProperties: staticProperties,
501 dynamicProperties: dynamicProperties,
Paul Duffincd064672021-04-24 00:47:29 +0100502 }
503 sdkVariantToCombinedProperties[sdkVariant] = combinedProperties
504
505 list = append(list, combinedProperties)
Paul Duffin2d1bb892021-04-24 11:32:59 +0100506 }
Paul Duffincd064672021-04-24 00:47:29 +0100507
508 for _, memberVariantDep := range memberVariantDeps {
509 // If the member dependency is internal then do not add the dependency to the snapshot member
510 // list properties.
511 if !memberVariantDep.export {
512 continue
513 }
514
515 combined := sdkVariantToCombinedProperties[memberVariantDep.sdkVariant]
516 memberTypeProperty := s.memberListProperty(memberVariantDep.memberType)
517 memberName := ctx.OtherModuleName(memberVariantDep.variant)
518
519 // Append the member to the appropriate list, if it is not already present in the list.
520 memberList := memberTypeProperty.getter(combined.dynamicProperties)
521 if !android.InList(memberName, memberList) {
522 memberList = append(memberList, memberName)
523 }
524 memberTypeProperty.setter(combined.dynamicProperties, memberList)
525 }
526
Paul Duffin2d1bb892021-04-24 11:32:59 +0100527 return list
528}
529
530func (s *sdk) optimizeSnapshotModuleProperties(ctx android.ModuleContext, list []*combinedSnapshotModuleProperties) *combinedSnapshotModuleProperties {
531
532 // Extract the dynamic properties and add them to a list of propertiesContainer.
533 propertyContainers := []propertiesContainer{}
534 for _, i := range list {
535 propertyContainers = append(propertyContainers, sdkVariantPropertiesContainer{
536 sdkVariant: i.sdkVariant,
537 properties: i.dynamicProperties,
538 })
539 }
540
541 // Extract the common members, removing them from the original properties.
542 commonDynamicProperties := s.dynamicSdkMemberTypes.createMemberListProperties()
543 extractor := newCommonValueExtractor(commonDynamicProperties)
544 extractCommonProperties(ctx, extractor, commonDynamicProperties, propertyContainers)
545
546 // Extract the static properties and add them to a list of propertiesContainer.
547 propertyContainers = []propertiesContainer{}
548 for _, i := range list {
549 propertyContainers = append(propertyContainers, sdkVariantPropertiesContainer{
550 sdkVariant: i.sdkVariant,
551 properties: i.staticProperties,
552 })
553 }
554
555 commonStaticProperties := &snapshotModuleStaticProperties{}
556 extractor = newCommonValueExtractor(commonStaticProperties)
557 extractCommonProperties(ctx, extractor, &commonStaticProperties, propertyContainers)
558
559 return &combinedSnapshotModuleProperties{
560 sdkVariant: nil,
561 staticProperties: commonStaticProperties,
562 dynamicProperties: commonDynamicProperties,
563 }
564}
565
566func (s *sdk) addSnapshotPropertiesToPropertySet(builder *snapshotBuilder, propertySet android.BpPropertySet, combined *combinedSnapshotModuleProperties) {
567 staticProperties := combined.staticProperties
Paul Duffinfbe470e2021-04-24 12:37:13 +0100568 multilib := staticProperties.Compile_multilib
569 if multilib != "" && multilib != "both" {
570 // Compile_multilib defaults to both so only needs to be set when it's specified and not both.
571 propertySet.AddProperty("compile_multilib", multilib)
572 }
573
Paul Duffin2d1bb892021-04-24 11:32:59 +0100574 dynamicMemberTypeListProperties := combined.dynamicProperties
Paul Duffin865171e2020-03-02 18:38:15 +0000575 for _, memberListProperty := range s.memberListProperties() {
576 names := memberListProperty.getter(dynamicMemberTypeListProperties)
577 if len(names) > 0 {
Paul Duffin13f02712020-03-06 12:30:43 +0000578 propertySet.AddProperty(memberListProperty.propertyName(), builder.versionedSdkMemberNames(names, false))
Paul Duffin865171e2020-03-02 18:38:15 +0000579 }
580 }
581}
582
Paul Duffin7b81f5e2020-01-13 21:03:22 +0000583type propertyTag struct {
584 name string
585}
586
Paul Duffin0cb37b92020-03-04 14:52:46 +0000587// A BpPropertyTag to add to a property that contains references to other sdk members.
588//
589// This will cause the references to be rewritten to a versioned reference in the version
590// specific instance of a snapshot module.
Paul Duffin13f02712020-03-06 12:30:43 +0000591var requiredSdkMemberReferencePropertyTag = propertyTag{"requiredSdkMemberReferencePropertyTag"}
Paul Duffin13f02712020-03-06 12:30:43 +0000592var optionalSdkMemberReferencePropertyTag = propertyTag{"optionalSdkMemberReferencePropertyTag"}
Paul Duffin7b81f5e2020-01-13 21:03:22 +0000593
Paul Duffin0cb37b92020-03-04 14:52:46 +0000594// A BpPropertyTag that indicates the property should only be present in the versioned
595// module.
596//
597// This will cause the property to be removed from the unversioned instance of a
598// snapshot module.
599var sdkVersionedOnlyPropertyTag = propertyTag{"sdkVersionedOnlyPropertyTag"}
600
Paul Duffine6c0d842020-01-15 14:08:51 +0000601type unversionedToVersionedTransformation struct {
602 identityTransformation
603 builder *snapshotBuilder
604}
605
Paul Duffine6c0d842020-01-15 14:08:51 +0000606func (t unversionedToVersionedTransformation) transformModule(module *bpModule) *bpModule {
607 // Use a versioned name for the module but remember the original name for the
608 // snapshot.
609 name := module.getValue("name").(string)
Paul Duffin13f02712020-03-06 12:30:43 +0000610 module.setProperty("name", t.builder.versionedSdkMemberName(name, true))
Paul Duffine6c0d842020-01-15 14:08:51 +0000611 module.insertAfter("name", "sdk_member_name", name)
Paul Duffin83ad9562021-05-10 23:49:04 +0100612 // Remove the prefer property if present as versioned modules never need marking with prefer.
613 module.removeProperty("prefer")
Paul Duffine6c0d842020-01-15 14:08:51 +0000614 return module
615}
616
Paul Duffin7b81f5e2020-01-13 21:03:22 +0000617func (t unversionedToVersionedTransformation) transformProperty(name string, value interface{}, tag android.BpPropertyTag) (interface{}, android.BpPropertyTag) {
Paul Duffin13f02712020-03-06 12:30:43 +0000618 if tag == requiredSdkMemberReferencePropertyTag || tag == optionalSdkMemberReferencePropertyTag {
619 required := tag == requiredSdkMemberReferencePropertyTag
620 return t.builder.versionedSdkMemberNames(value.([]string), required), tag
Paul Duffin7b81f5e2020-01-13 21:03:22 +0000621 } else {
622 return value, tag
623 }
624}
625
Paul Duffin72910952020-01-20 18:16:30 +0000626type unversionedTransformation struct {
627 identityTransformation
628 builder *snapshotBuilder
629}
630
631func (t unversionedTransformation) transformModule(module *bpModule) *bpModule {
632 // If the module is an internal member then use a unique name for it.
633 name := module.getValue("name").(string)
Paul Duffin13f02712020-03-06 12:30:43 +0000634 module.setProperty("name", t.builder.unversionedSdkMemberName(name, true))
Paul Duffin72910952020-01-20 18:16:30 +0000635 return module
636}
637
638func (t unversionedTransformation) transformProperty(name string, value interface{}, tag android.BpPropertyTag) (interface{}, android.BpPropertyTag) {
Paul Duffin13f02712020-03-06 12:30:43 +0000639 if tag == requiredSdkMemberReferencePropertyTag || tag == optionalSdkMemberReferencePropertyTag {
640 required := tag == requiredSdkMemberReferencePropertyTag
641 return t.builder.unversionedSdkMemberNames(value.([]string), required), tag
Paul Duffin0cb37b92020-03-04 14:52:46 +0000642 } else if tag == sdkVersionedOnlyPropertyTag {
643 // The property is not allowed in the unversioned module so remove it.
644 return nil, nil
Paul Duffin72910952020-01-20 18:16:30 +0000645 } else {
646 return value, tag
647 }
648}
649
Paul Duffina78f3a72020-02-21 16:29:35 +0000650type pruneEmptySetTransformer struct {
651 identityTransformation
652}
653
654var _ bpTransformer = (*pruneEmptySetTransformer)(nil)
655
656func (t pruneEmptySetTransformer) transformPropertySetAfterContents(name string, propertySet *bpPropertySet, tag android.BpPropertyTag) (*bpPropertySet, android.BpPropertyTag) {
657 if len(propertySet.properties) == 0 {
658 return nil, nil
659 } else {
660 return propertySet, tag
661 }
662}
663
Paul Duffinb645ec82019-11-27 17:43:54 +0000664func generateBpContents(contents *generatedContents, bpFile *bpFile) {
Paul Duffind0759072021-02-17 11:23:00 +0000665 generateFilteredBpContents(contents, bpFile, func(*bpModule) bool {
666 return true
667 })
668}
669
670func generateFilteredBpContents(contents *generatedContents, bpFile *bpFile, moduleFilter func(module *bpModule) bool) {
Paul Duffinb645ec82019-11-27 17:43:54 +0000671 contents.Printfln("// This is auto-generated. DO NOT EDIT.")
672 for _, bpModule := range bpFile.order {
Paul Duffind0759072021-02-17 11:23:00 +0000673 if moduleFilter(bpModule) {
674 contents.Printfln("")
675 contents.Printfln("%s {", bpModule.moduleType)
676 outputPropertySet(contents, bpModule.bpPropertySet)
677 contents.Printfln("}")
678 }
Paul Duffinb645ec82019-11-27 17:43:54 +0000679 }
Paul Duffinb645ec82019-11-27 17:43:54 +0000680}
681
682func outputPropertySet(contents *generatedContents, set *bpPropertySet) {
683 contents.Indent()
Paul Duffin07ef3cb2020-03-11 18:17:42 +0000684
685 // Output the properties first, followed by the nested sets. This ensures a
686 // consistent output irrespective of whether property sets are created before
687 // or after the properties. This simplifies the creation of the module.
Paul Duffinb645ec82019-11-27 17:43:54 +0000688 for _, name := range set.order {
Paul Duffin5b511a22020-01-15 14:23:52 +0000689 value := set.getValue(name)
Paul Duffinb645ec82019-11-27 17:43:54 +0000690
Paul Duffin07ef3cb2020-03-11 18:17:42 +0000691 switch v := value.(type) {
692 case []string:
693 length := len(v)
Paul Duffinb645ec82019-11-27 17:43:54 +0000694 if length > 1 {
695 contents.Printfln("%s: [", name)
696 contents.Indent()
697 for i := 0; i < length; i = i + 1 {
Paul Duffin07ef3cb2020-03-11 18:17:42 +0000698 contents.Printfln("%q,", v[i])
Paul Duffinb645ec82019-11-27 17:43:54 +0000699 }
700 contents.Dedent()
701 contents.Printfln("],")
702 } else if length == 0 {
703 contents.Printfln("%s: [],", name)
704 } else {
Paul Duffin07ef3cb2020-03-11 18:17:42 +0000705 contents.Printfln("%s: [%q],", name, v[0])
Paul Duffinb645ec82019-11-27 17:43:54 +0000706 }
Paul Duffinb645ec82019-11-27 17:43:54 +0000707
Paul Duffin07ef3cb2020-03-11 18:17:42 +0000708 case bool:
709 contents.Printfln("%s: %t,", name, v)
710
711 case *bpPropertySet:
712 // Do not write property sets in the properties phase.
Paul Duffinb645ec82019-11-27 17:43:54 +0000713
714 default:
715 contents.Printfln("%s: %q,", name, value)
716 }
717 }
Paul Duffin07ef3cb2020-03-11 18:17:42 +0000718
719 for _, name := range set.order {
720 value := set.getValue(name)
721
722 // Only write property sets in the sets phase.
723 switch v := value.(type) {
724 case *bpPropertySet:
725 contents.Printfln("%s: {", name)
726 outputPropertySet(contents, v)
727 contents.Printfln("},")
728 }
729 }
730
Paul Duffinb645ec82019-11-27 17:43:54 +0000731 contents.Dedent()
732}
733
Paul Duffinac37c502019-11-26 18:02:20 +0000734func (s *sdk) GetAndroidBpContentsForTests() string {
Paul Duffinb645ec82019-11-27 17:43:54 +0000735 contents := &generatedContents{}
736 generateBpContents(contents, s.builderForTests.bpFile)
737 return contents.content.String()
Paul Duffinac37c502019-11-26 18:02:20 +0000738}
739
Paul Duffind0759072021-02-17 11:23:00 +0000740func (s *sdk) GetUnversionedAndroidBpContentsForTests() string {
741 contents := &generatedContents{}
742 generateFilteredBpContents(contents, s.builderForTests.bpFile, func(module *bpModule) bool {
743 return !strings.Contains(module.properties["name"].(string), "@")
744 })
745 return contents.content.String()
746}
747
748func (s *sdk) GetVersionedAndroidBpContentsForTests() string {
749 contents := &generatedContents{}
750 generateFilteredBpContents(contents, s.builderForTests.bpFile, func(module *bpModule) bool {
751 return strings.Contains(module.properties["name"].(string), "@")
752 })
753 return contents.content.String()
754}
755
Paul Duffin0e0cf1d2019-11-12 19:39:25 +0000756type snapshotBuilder struct {
Paul Duffinb645ec82019-11-27 17:43:54 +0000757 ctx android.ModuleContext
Paul Duffine44358f2019-11-26 18:04:12 +0000758 sdk *sdk
Paul Duffinb645ec82019-11-27 17:43:54 +0000759 version string
760 snapshotDir android.OutputPath
761 bpFile *bpFile
Paul Duffinc62a5102019-12-11 18:34:15 +0000762
763 // Map from destination to source of each copy - used to eliminate duplicates and
764 // detect conflicts.
765 copies map[string]string
766
Paul Duffinb645ec82019-11-27 17:43:54 +0000767 filesToZip android.Paths
768 zipsToMerge android.Paths
769
770 prebuiltModules map[string]*bpModule
771 prebuiltOrder []*bpModule
Paul Duffin13f02712020-03-06 12:30:43 +0000772
773 // The set of all members by name.
774 allMembersByName map[string]struct{}
775
776 // The set of exported members by name.
777 exportedMembersByName map[string]struct{}
Paul Duffin0e0cf1d2019-11-12 19:39:25 +0000778}
779
780func (s *snapshotBuilder) CopyToSnapshot(src android.Path, dest string) {
Paul Duffinc62a5102019-12-11 18:34:15 +0000781 if existing, ok := s.copies[dest]; ok {
782 if existing != src.String() {
783 s.ctx.ModuleErrorf("conflicting copy, %s copied from both %s and %s", dest, existing, src)
784 return
785 }
786 } else {
787 path := s.snapshotDir.Join(s.ctx, dest)
788 s.ctx.Build(pctx, android.BuildParams{
789 Rule: android.Cp,
790 Input: src,
791 Output: path,
792 })
793 s.filesToZip = append(s.filesToZip, path)
794
795 s.copies[dest] = src.String()
796 }
Paul Duffin0e0cf1d2019-11-12 19:39:25 +0000797}
798
Paul Duffin91547182019-11-12 19:39:36 +0000799func (s *snapshotBuilder) UnzipToSnapshot(zipPath android.Path, destDir string) {
800 ctx := s.ctx
801
802 // Repackage the zip file so that the entries are in the destDir directory.
803 // This will allow the zip file to be merged into the snapshot.
804 tmpZipPath := android.PathForModuleOut(ctx, "tmp", destDir+".zip").OutputPath
Paul Duffin375058f2019-11-29 20:17:53 +0000805
806 ctx.Build(pctx, android.BuildParams{
807 Description: "Repackaging zip file " + destDir + " for snapshot " + ctx.ModuleName(),
808 Rule: repackageZip,
809 Input: zipPath,
810 Output: tmpZipPath,
811 Args: map[string]string{
812 "destdir": destDir,
813 },
814 })
Paul Duffin91547182019-11-12 19:39:36 +0000815
816 // Add the repackaged zip file to the files to merge.
817 s.zipsToMerge = append(s.zipsToMerge, tmpZipPath)
818}
819
Paul Duffin9d8d6092019-12-05 18:19:29 +0000820func (s *snapshotBuilder) AddPrebuiltModule(member android.SdkMember, moduleType string) android.BpModule {
821 name := member.Name()
Paul Duffinb645ec82019-11-27 17:43:54 +0000822 if s.prebuiltModules[name] != nil {
823 panic(fmt.Sprintf("Duplicate module detected, module %s has already been added", name))
824 }
825
826 m := s.bpFile.newModule(moduleType)
827 m.AddProperty("name", name)
Paul Duffin593b3c92019-12-05 14:31:48 +0000828
Paul Duffinbefa4b92020-03-04 14:22:45 +0000829 variant := member.Variants()[0]
830
Paul Duffin13f02712020-03-06 12:30:43 +0000831 if s.isInternalMember(name) {
Paul Duffin72910952020-01-20 18:16:30 +0000832 // An internal member is only referenced from the sdk snapshot which is in the
833 // same package so can be marked as private.
834 m.AddProperty("visibility", []string{"//visibility:private"})
835 } else {
836 // Extract visibility information from a member variant. All variants have the same
837 // visibility so it doesn't matter which one is used.
Paul Duffin157f40f2020-09-29 16:01:08 +0100838 visibilityRules := android.EffectiveVisibilityRules(s.ctx, variant)
839
840 // Add any additional visibility rules needed for the prebuilts to reference each other.
841 err := visibilityRules.Widen(s.sdk.properties.Prebuilt_visibility)
842 if err != nil {
843 s.ctx.PropertyErrorf("prebuilt_visibility", "%s", err)
844 }
845
846 visibility := visibilityRules.Strings()
Paul Duffin72910952020-01-20 18:16:30 +0000847 if len(visibility) != 0 {
848 m.AddProperty("visibility", visibility)
849 }
Paul Duffin593b3c92019-12-05 14:31:48 +0000850 }
851
Martin Stjernholm1e041092020-11-03 00:11:09 +0000852 // Where available copy apex_available properties from the member.
853 if apexAware, ok := variant.(interface{ ApexAvailable() []string }); ok {
854 apexAvailable := apexAware.ApexAvailable()
855 if len(apexAvailable) == 0 {
856 // //apex_available:platform is the default.
857 apexAvailable = []string{android.AvailableToPlatform}
858 }
859
860 // Add in any baseline apex available settings.
861 apexAvailable = append(apexAvailable, apex.BaselineApexAvailable(member.Name())...)
862
863 // Remove duplicates and sort.
864 apexAvailable = android.FirstUniqueStrings(apexAvailable)
865 sort.Strings(apexAvailable)
866
867 m.AddProperty("apex_available", apexAvailable)
868 }
869
Paul Duffin865171e2020-03-02 18:38:15 +0000870 deviceSupported := false
871 hostSupported := false
872
873 for _, variant := range member.Variants() {
874 osClass := variant.Target().Os.Class
Jiyong Park1613e552020-09-14 19:43:17 +0900875 if osClass == android.Host {
Paul Duffin865171e2020-03-02 18:38:15 +0000876 hostSupported = true
877 } else if osClass == android.Device {
878 deviceSupported = true
879 }
880 }
881
882 addHostDeviceSupportedProperties(deviceSupported, hostSupported, m)
Paul Duffinb645ec82019-11-27 17:43:54 +0000883
Paul Duffin0cb37b92020-03-04 14:52:46 +0000884 // Disable installation in the versioned module of those modules that are ever installable.
885 if installable, ok := variant.(interface{ EverInstallable() bool }); ok {
886 if installable.EverInstallable() {
887 m.AddPropertyWithTag("installable", false, sdkVersionedOnlyPropertyTag)
888 }
889 }
890
Paul Duffinb645ec82019-11-27 17:43:54 +0000891 s.prebuiltModules[name] = m
892 s.prebuiltOrder = append(s.prebuiltOrder, m)
893 return m
Paul Duffin0e0cf1d2019-11-12 19:39:25 +0000894}
895
Paul Duffin865171e2020-03-02 18:38:15 +0000896func addHostDeviceSupportedProperties(deviceSupported bool, hostSupported bool, bpModule *bpModule) {
897 if !deviceSupported {
Paul Duffine44358f2019-11-26 18:04:12 +0000898 bpModule.AddProperty("device_supported", false)
899 }
Paul Duffin865171e2020-03-02 18:38:15 +0000900 if hostSupported {
Paul Duffine44358f2019-11-26 18:04:12 +0000901 bpModule.AddProperty("host_supported", true)
902 }
903}
904
Paul Duffin13f02712020-03-06 12:30:43 +0000905func (s *snapshotBuilder) SdkMemberReferencePropertyTag(required bool) android.BpPropertyTag {
906 if required {
907 return requiredSdkMemberReferencePropertyTag
908 } else {
909 return optionalSdkMemberReferencePropertyTag
910 }
911}
912
913func (s *snapshotBuilder) OptionalSdkMemberReferencePropertyTag() android.BpPropertyTag {
914 return optionalSdkMemberReferencePropertyTag
Paul Duffin7b81f5e2020-01-13 21:03:22 +0000915}
916
Paul Duffinb645ec82019-11-27 17:43:54 +0000917// Get a versioned name appropriate for the SDK snapshot version being taken.
Paul Duffin13f02712020-03-06 12:30:43 +0000918func (s *snapshotBuilder) versionedSdkMemberName(unversionedName string, required bool) string {
919 if _, ok := s.allMembersByName[unversionedName]; !ok {
920 if required {
921 s.ctx.ModuleErrorf("Required member reference %s is not a member of the sdk", unversionedName)
922 }
923 return unversionedName
924 }
Paul Duffin0e0cf1d2019-11-12 19:39:25 +0000925 return versionedSdkMemberName(s.ctx, unversionedName, s.version)
926}
Paul Duffinb645ec82019-11-27 17:43:54 +0000927
Paul Duffin13f02712020-03-06 12:30:43 +0000928func (s *snapshotBuilder) versionedSdkMemberNames(members []string, required bool) []string {
Paul Duffinb645ec82019-11-27 17:43:54 +0000929 var references []string = nil
930 for _, m := range members {
Paul Duffin13f02712020-03-06 12:30:43 +0000931 references = append(references, s.versionedSdkMemberName(m, required))
Paul Duffinb645ec82019-11-27 17:43:54 +0000932 }
933 return references
934}
Paul Duffin13879572019-11-28 14:31:38 +0000935
Paul Duffin72910952020-01-20 18:16:30 +0000936// Get an internal name unique to the sdk.
Paul Duffin13f02712020-03-06 12:30:43 +0000937func (s *snapshotBuilder) unversionedSdkMemberName(unversionedName string, required bool) string {
938 if _, ok := s.allMembersByName[unversionedName]; !ok {
939 if required {
940 s.ctx.ModuleErrorf("Required member reference %s is not a member of the sdk", unversionedName)
941 }
942 return unversionedName
943 }
944
945 if s.isInternalMember(unversionedName) {
Paul Duffin72910952020-01-20 18:16:30 +0000946 return s.ctx.ModuleName() + "_" + unversionedName
947 } else {
948 return unversionedName
949 }
950}
951
Paul Duffin13f02712020-03-06 12:30:43 +0000952func (s *snapshotBuilder) unversionedSdkMemberNames(members []string, required bool) []string {
Paul Duffin72910952020-01-20 18:16:30 +0000953 var references []string = nil
954 for _, m := range members {
Paul Duffin13f02712020-03-06 12:30:43 +0000955 references = append(references, s.unversionedSdkMemberName(m, required))
Paul Duffin72910952020-01-20 18:16:30 +0000956 }
957 return references
958}
959
Paul Duffin13f02712020-03-06 12:30:43 +0000960func (s *snapshotBuilder) isInternalMember(memberName string) bool {
961 _, ok := s.exportedMembersByName[memberName]
962 return !ok
963}
964
Martin Stjernholm89238f42020-07-10 00:14:03 +0100965// Add the properties from the given SdkMemberProperties to the blueprint
966// property set. This handles common properties in SdkMemberPropertiesBase and
967// calls the member-specific AddToPropertySet for the rest.
968func addSdkMemberPropertiesToSet(ctx *memberContext, memberProperties android.SdkMemberProperties, targetPropertySet android.BpPropertySet) {
969 if memberProperties.Base().Compile_multilib != "" {
970 targetPropertySet.AddProperty("compile_multilib", memberProperties.Base().Compile_multilib)
971 }
972
973 memberProperties.AddToPropertySet(ctx, targetPropertySet)
974}
975
Paul Duffin21827262021-04-24 12:16:36 +0100976// sdkMemberVariantDep represents a dependency from an sdk variant onto a member variant.
977type sdkMemberVariantDep struct {
Paul Duffincd064672021-04-24 00:47:29 +0100978 // The sdk variant that depends (possibly indirectly) on the member variant.
979 sdkVariant *sdk
Paul Duffin1356d8c2020-02-25 19:26:33 +0000980 memberType android.SdkMemberType
981 variant android.SdkAware
Paul Duffina7208112021-04-23 21:20:20 +0100982 export bool
Paul Duffin1356d8c2020-02-25 19:26:33 +0000983}
984
Paul Duffin13879572019-11-28 14:31:38 +0000985var _ android.SdkMember = (*sdkMember)(nil)
986
Paul Duffin21827262021-04-24 12:16:36 +0100987// sdkMember groups all the variants of a specific member module together along with the name of the
988// module and the member type. This is used to generate the prebuilt modules for a specific member.
Paul Duffin13879572019-11-28 14:31:38 +0000989type sdkMember struct {
990 memberType android.SdkMemberType
991 name string
992 variants []android.SdkAware
993}
994
995func (m *sdkMember) Name() string {
996 return m.name
997}
998
999func (m *sdkMember) Variants() []android.SdkAware {
1000 return m.variants
1001}
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001002
Paul Duffin9c3760e2020-03-16 19:52:08 +00001003// Track usages of multilib variants.
1004type multilibUsage int
1005
1006const (
1007 multilibNone multilibUsage = 0
1008 multilib32 multilibUsage = 1
1009 multilib64 multilibUsage = 2
1010 multilibBoth = multilib32 | multilib64
1011)
1012
1013// Add the multilib that is used in the arch type.
1014func (m multilibUsage) addArchType(archType android.ArchType) multilibUsage {
1015 multilib := archType.Multilib
1016 switch multilib {
1017 case "":
1018 return m
1019 case "lib32":
1020 return m | multilib32
1021 case "lib64":
1022 return m | multilib64
1023 default:
1024 panic(fmt.Errorf("Unknown Multilib field in ArchType, expected 'lib32' or 'lib64', found %q", multilib))
1025 }
1026}
1027
1028func (m multilibUsage) String() string {
1029 switch m {
1030 case multilibNone:
1031 return ""
1032 case multilib32:
1033 return "32"
1034 case multilib64:
1035 return "64"
1036 case multilibBoth:
1037 return "both"
1038 default:
1039 panic(fmt.Errorf("Unknown multilib value, found %b, expected one of %b, %b, %b or %b",
1040 m, multilibNone, multilib32, multilib64, multilibBoth))
1041 }
1042}
1043
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001044type baseInfo struct {
1045 Properties android.SdkMemberProperties
1046}
1047
Paul Duffinf34f6d82020-04-30 15:48:31 +01001048func (b *baseInfo) optimizableProperties() interface{} {
1049 return b.Properties
1050}
1051
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001052type osTypeSpecificInfo struct {
1053 baseInfo
1054
Paul Duffin00e46802020-03-12 20:40:35 +00001055 osType android.OsType
1056
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001057 // The list of arch type specific info for this os type.
Paul Duffinb44b33a2020-03-17 10:58:23 +00001058 //
1059 // Nil if there is one variant whose arch type is common
1060 archInfos []*archTypeSpecificInfo
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001061}
1062
Paul Duffin4b8b7932020-05-06 12:35:38 +01001063var _ propertiesContainer = (*osTypeSpecificInfo)(nil)
1064
Paul Duffinfc8dd232020-03-17 12:51:37 +00001065type variantPropertiesFactoryFunc func() android.SdkMemberProperties
1066
Paul Duffin00e46802020-03-12 20:40:35 +00001067// Create a new osTypeSpecificInfo for the specified os type and its properties
1068// structures populated with information from the variants.
Paul Duffin3a4eb502020-03-19 16:11:18 +00001069func newOsTypeSpecificInfo(ctx android.SdkMemberContext, osType android.OsType, variantPropertiesFactory variantPropertiesFactoryFunc, osTypeVariants []android.Module) *osTypeSpecificInfo {
Paul Duffin00e46802020-03-12 20:40:35 +00001070 osInfo := &osTypeSpecificInfo{
1071 osType: osType,
1072 }
1073
1074 osSpecificVariantPropertiesFactory := func() android.SdkMemberProperties {
1075 properties := variantPropertiesFactory()
1076 properties.Base().Os = osType
1077 return properties
1078 }
1079
1080 // Create a structure into which properties common across the architectures in
1081 // this os type will be stored.
1082 osInfo.Properties = osSpecificVariantPropertiesFactory()
1083
1084 // Group the variants by arch type.
Paul Duffin3a4eb502020-03-19 16:11:18 +00001085 var variantsByArchName = make(map[string][]android.Module)
Paul Duffin00e46802020-03-12 20:40:35 +00001086 var archTypes []android.ArchType
1087 for _, variant := range osTypeVariants {
1088 archType := variant.Target().Arch.ArchType
1089 archTypeName := archType.Name
1090 if _, ok := variantsByArchName[archTypeName]; !ok {
1091 archTypes = append(archTypes, archType)
1092 }
1093
1094 variantsByArchName[archTypeName] = append(variantsByArchName[archTypeName], variant)
1095 }
1096
1097 if commonVariants, ok := variantsByArchName["common"]; ok {
1098 if len(osTypeVariants) != 1 {
Colin Crossafa6a772020-07-06 17:41:08 -07001099 panic(fmt.Errorf("Expected to only have 1 variant when arch type is common but found %d", len(osTypeVariants)))
Paul Duffin00e46802020-03-12 20:40:35 +00001100 }
1101
1102 // A common arch type only has one variant and its properties should be treated
1103 // as common to the os type.
Paul Duffin3a4eb502020-03-19 16:11:18 +00001104 osInfo.Properties.PopulateFromVariant(ctx, commonVariants[0])
Paul Duffin00e46802020-03-12 20:40:35 +00001105 } else {
1106 // Create an arch specific info for each supported architecture type.
1107 for _, archType := range archTypes {
1108 archTypeName := archType.Name
1109
1110 archVariants := variantsByArchName[archTypeName]
Jiyong Park8fe14e62020-10-19 22:47:34 +09001111 archInfo := newArchSpecificInfo(ctx, archType, osType, osSpecificVariantPropertiesFactory, archVariants)
Paul Duffin00e46802020-03-12 20:40:35 +00001112
1113 osInfo.archInfos = append(osInfo.archInfos, archInfo)
1114 }
1115 }
1116
1117 return osInfo
1118}
1119
1120// Optimize the properties by extracting common properties from arch type specific
1121// properties into os type specific properties.
Paul Duffin4b8b7932020-05-06 12:35:38 +01001122func (osInfo *osTypeSpecificInfo) optimizeProperties(ctx *memberContext, commonValueExtractor *commonValueExtractor) {
Paul Duffin00e46802020-03-12 20:40:35 +00001123 // Nothing to do if there is only a single common architecture.
1124 if len(osInfo.archInfos) == 0 {
1125 return
1126 }
1127
Paul Duffin9c3760e2020-03-16 19:52:08 +00001128 multilib := multilibNone
Paul Duffin00e46802020-03-12 20:40:35 +00001129 for _, archInfo := range osInfo.archInfos {
Paul Duffin9c3760e2020-03-16 19:52:08 +00001130 multilib = multilib.addArchType(archInfo.archType)
1131
Paul Duffin9b76c0b2020-03-12 10:24:35 +00001132 // Optimize the arch properties first.
Paul Duffin4b8b7932020-05-06 12:35:38 +01001133 archInfo.optimizeProperties(ctx, commonValueExtractor)
Paul Duffin00e46802020-03-12 20:40:35 +00001134 }
1135
Paul Duffin4b8b7932020-05-06 12:35:38 +01001136 extractCommonProperties(ctx.sdkMemberContext, commonValueExtractor, osInfo.Properties, osInfo.archInfos)
Paul Duffin00e46802020-03-12 20:40:35 +00001137
1138 // Choose setting for compile_multilib that is appropriate for the arch variants supplied.
Paul Duffin9c3760e2020-03-16 19:52:08 +00001139 osInfo.Properties.Base().Compile_multilib = multilib.String()
Paul Duffin00e46802020-03-12 20:40:35 +00001140}
1141
1142// Add the properties for an os to a property set.
1143//
1144// Maps the properties related to the os variants through to an appropriate
1145// module structure that will produce equivalent set of variants when it is
1146// processed in a build.
Paul Duffin3a4eb502020-03-19 16:11:18 +00001147func (osInfo *osTypeSpecificInfo) addToPropertySet(ctx *memberContext, bpModule android.BpModule, targetPropertySet android.BpPropertySet) {
Paul Duffin00e46802020-03-12 20:40:35 +00001148
1149 var osPropertySet android.BpPropertySet
1150 var archPropertySet android.BpPropertySet
1151 var archOsPrefix string
Martin Stjernholmcaa47d72020-07-11 04:52:24 +01001152 if osInfo.Properties.Base().Os_count == 1 &&
1153 (osInfo.osType.Class == android.Device || !ctx.memberType.IsHostOsDependent()) {
1154 // There is only one OS type present in the variants and it shouldn't have a
1155 // variant-specific target. The latter is the case if it's either for device
1156 // where there is only one OS (android), or for host and the member type
1157 // isn't host OS dependent.
Paul Duffin00e46802020-03-12 20:40:35 +00001158
1159 // Create a structure that looks like:
1160 // module_type {
1161 // name: "...",
1162 // ...
1163 // <common properties>
1164 // ...
1165 // <single os type specific properties>
1166 //
1167 // arch: {
1168 // <arch specific sections>
1169 // }
1170 //
1171 osPropertySet = bpModule
1172 archPropertySet = osPropertySet.AddPropertySet("arch")
1173
1174 // Arch specific properties need to be added to an arch specific section
1175 // within arch.
1176 archOsPrefix = ""
1177 } else {
1178 // Create a structure that looks like:
1179 // module_type {
1180 // name: "...",
1181 // ...
1182 // <common properties>
1183 // ...
1184 // target: {
1185 // <arch independent os specific sections, e.g. android>
1186 // ...
1187 // <arch and os specific sections, e.g. android_x86>
1188 // }
1189 //
1190 osType := osInfo.osType
1191 osPropertySet = targetPropertySet.AddPropertySet(osType.Name)
1192 archPropertySet = targetPropertySet
1193
1194 // Arch specific properties need to be added to an os and arch specific
1195 // section prefixed with <os>_.
1196 archOsPrefix = osType.Name + "_"
1197 }
1198
1199 // Add the os specific but arch independent properties to the module.
Martin Stjernholm89238f42020-07-10 00:14:03 +01001200 addSdkMemberPropertiesToSet(ctx, osInfo.Properties, osPropertySet)
Paul Duffin00e46802020-03-12 20:40:35 +00001201
1202 // Add arch (and possibly os) specific sections for each set of arch (and possibly
1203 // os) specific properties.
1204 //
1205 // The archInfos list will be empty if the os contains variants for the common
1206 // architecture.
1207 for _, archInfo := range osInfo.archInfos {
Paul Duffin3a4eb502020-03-19 16:11:18 +00001208 archInfo.addToPropertySet(ctx, archPropertySet, archOsPrefix)
Paul Duffin00e46802020-03-12 20:40:35 +00001209 }
1210}
1211
Paul Duffin7a1f7f32020-05-04 15:32:08 +01001212func (osInfo *osTypeSpecificInfo) isHostVariant() bool {
1213 osClass := osInfo.osType.Class
Jiyong Park1613e552020-09-14 19:43:17 +09001214 return osClass == android.Host
Paul Duffin7a1f7f32020-05-04 15:32:08 +01001215}
1216
1217var _ isHostVariant = (*osTypeSpecificInfo)(nil)
1218
Paul Duffin4b8b7932020-05-06 12:35:38 +01001219func (osInfo *osTypeSpecificInfo) String() string {
1220 return fmt.Sprintf("OsType{%s}", osInfo.osType)
1221}
1222
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001223type archTypeSpecificInfo struct {
1224 baseInfo
1225
1226 archType android.ArchType
Jiyong Park8fe14e62020-10-19 22:47:34 +09001227 osType android.OsType
Paul Duffin9b76c0b2020-03-12 10:24:35 +00001228
1229 linkInfos []*linkTypeSpecificInfo
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001230}
1231
Paul Duffin4b8b7932020-05-06 12:35:38 +01001232var _ propertiesContainer = (*archTypeSpecificInfo)(nil)
1233
Paul Duffinfc8dd232020-03-17 12:51:37 +00001234// Create a new archTypeSpecificInfo for the specified arch type and its properties
1235// structures populated with information from the variants.
Jiyong Park8fe14e62020-10-19 22:47:34 +09001236func newArchSpecificInfo(ctx android.SdkMemberContext, archType android.ArchType, osType android.OsType, variantPropertiesFactory variantPropertiesFactoryFunc, archVariants []android.Module) *archTypeSpecificInfo {
Paul Duffinfc8dd232020-03-17 12:51:37 +00001237
Paul Duffinfc8dd232020-03-17 12:51:37 +00001238 // Create an arch specific info into which the variant properties can be copied.
Jiyong Park8fe14e62020-10-19 22:47:34 +09001239 archInfo := &archTypeSpecificInfo{archType: archType, osType: osType}
Paul Duffinfc8dd232020-03-17 12:51:37 +00001240
1241 // Create the properties into which the arch type specific properties will be
1242 // added.
1243 archInfo.Properties = variantPropertiesFactory()
Paul Duffin9b76c0b2020-03-12 10:24:35 +00001244
1245 if len(archVariants) == 1 {
Paul Duffin3a4eb502020-03-19 16:11:18 +00001246 archInfo.Properties.PopulateFromVariant(ctx, archVariants[0])
Paul Duffin9b76c0b2020-03-12 10:24:35 +00001247 } else {
1248 // There is more than one variant for this arch type which must be differentiated
1249 // by link type.
1250 for _, linkVariant := range archVariants {
1251 linkType := getLinkType(linkVariant)
1252 if linkType == "" {
1253 panic(fmt.Errorf("expected one arch specific variant as it is not identified by link type but found %d", len(archVariants)))
1254 } else {
Paul Duffin3a4eb502020-03-19 16:11:18 +00001255 linkInfo := newLinkSpecificInfo(ctx, linkType, variantPropertiesFactory, linkVariant)
Paul Duffin9b76c0b2020-03-12 10:24:35 +00001256
1257 archInfo.linkInfos = append(archInfo.linkInfos, linkInfo)
1258 }
1259 }
1260 }
Paul Duffinfc8dd232020-03-17 12:51:37 +00001261
1262 return archInfo
1263}
1264
Paul Duffinf34f6d82020-04-30 15:48:31 +01001265func (archInfo *archTypeSpecificInfo) optimizableProperties() interface{} {
1266 return archInfo.Properties
1267}
1268
Paul Duffin9b76c0b2020-03-12 10:24:35 +00001269// Get the link type of the variant
1270//
1271// If the variant is not differentiated by link type then it returns "",
1272// otherwise it returns one of "static" or "shared".
1273func getLinkType(variant android.Module) string {
1274 linkType := ""
1275 if linkable, ok := variant.(cc.LinkableInterface); ok {
1276 if linkable.Shared() && linkable.Static() {
1277 panic(fmt.Errorf("expected variant %q to be either static or shared but was both", variant.String()))
1278 } else if linkable.Shared() {
1279 linkType = "shared"
1280 } else if linkable.Static() {
1281 linkType = "static"
1282 } else {
1283 panic(fmt.Errorf("expected variant %q to be either static or shared but was neither", variant.String()))
1284 }
1285 }
1286 return linkType
1287}
1288
1289// Optimize the properties by extracting common properties from link type specific
1290// properties into arch type specific properties.
Paul Duffin4b8b7932020-05-06 12:35:38 +01001291func (archInfo *archTypeSpecificInfo) optimizeProperties(ctx *memberContext, commonValueExtractor *commonValueExtractor) {
Paul Duffin9b76c0b2020-03-12 10:24:35 +00001292 if len(archInfo.linkInfos) == 0 {
1293 return
1294 }
1295
Paul Duffin4b8b7932020-05-06 12:35:38 +01001296 extractCommonProperties(ctx.sdkMemberContext, commonValueExtractor, archInfo.Properties, archInfo.linkInfos)
Paul Duffin9b76c0b2020-03-12 10:24:35 +00001297}
1298
Paul Duffinfc8dd232020-03-17 12:51:37 +00001299// Add the properties for an arch type to a property set.
Paul Duffin3a4eb502020-03-19 16:11:18 +00001300func (archInfo *archTypeSpecificInfo) addToPropertySet(ctx *memberContext, archPropertySet android.BpPropertySet, archOsPrefix string) {
Paul Duffinfc8dd232020-03-17 12:51:37 +00001301 archTypeName := archInfo.archType.Name
1302 archTypePropertySet := archPropertySet.AddPropertySet(archOsPrefix + archTypeName)
Jiyong Park8fe14e62020-10-19 22:47:34 +09001303 // Enable the <os>_<arch> variant explicitly when we've disabled it by default on host.
1304 if ctx.memberType.IsHostOsDependent() && archInfo.osType.Class == android.Host {
1305 archTypePropertySet.AddProperty("enabled", true)
1306 }
Martin Stjernholm89238f42020-07-10 00:14:03 +01001307 addSdkMemberPropertiesToSet(ctx, archInfo.Properties, archTypePropertySet)
Paul Duffin9b76c0b2020-03-12 10:24:35 +00001308
1309 for _, linkInfo := range archInfo.linkInfos {
1310 linkPropertySet := archTypePropertySet.AddPropertySet(linkInfo.linkType)
Martin Stjernholm89238f42020-07-10 00:14:03 +01001311 addSdkMemberPropertiesToSet(ctx, linkInfo.Properties, linkPropertySet)
Paul Duffin9b76c0b2020-03-12 10:24:35 +00001312 }
1313}
1314
Paul Duffin4b8b7932020-05-06 12:35:38 +01001315func (archInfo *archTypeSpecificInfo) String() string {
1316 return fmt.Sprintf("ArchType{%s}", archInfo.archType)
1317}
1318
Paul Duffin9b76c0b2020-03-12 10:24:35 +00001319type linkTypeSpecificInfo struct {
1320 baseInfo
1321
1322 linkType string
1323}
1324
Paul Duffin4b8b7932020-05-06 12:35:38 +01001325var _ propertiesContainer = (*linkTypeSpecificInfo)(nil)
1326
Paul Duffin9b76c0b2020-03-12 10:24:35 +00001327// Create a new linkTypeSpecificInfo for the specified link type and its properties
1328// structures populated with information from the variant.
Paul Duffin3a4eb502020-03-19 16:11:18 +00001329func newLinkSpecificInfo(ctx android.SdkMemberContext, linkType string, variantPropertiesFactory variantPropertiesFactoryFunc, linkVariant android.Module) *linkTypeSpecificInfo {
Paul Duffin9b76c0b2020-03-12 10:24:35 +00001330 linkInfo := &linkTypeSpecificInfo{
1331 baseInfo: baseInfo{
1332 // Create the properties into which the link type specific properties will be
1333 // added.
1334 Properties: variantPropertiesFactory(),
1335 },
1336 linkType: linkType,
1337 }
Paul Duffin3a4eb502020-03-19 16:11:18 +00001338 linkInfo.Properties.PopulateFromVariant(ctx, linkVariant)
Paul Duffin9b76c0b2020-03-12 10:24:35 +00001339 return linkInfo
Paul Duffinfc8dd232020-03-17 12:51:37 +00001340}
1341
Paul Duffin4b8b7932020-05-06 12:35:38 +01001342func (l *linkTypeSpecificInfo) String() string {
1343 return fmt.Sprintf("LinkType{%s}", l.linkType)
1344}
1345
Paul Duffin3a4eb502020-03-19 16:11:18 +00001346type memberContext struct {
1347 sdkMemberContext android.ModuleContext
1348 builder *snapshotBuilder
Paul Duffina551a1c2020-03-17 21:04:24 +00001349 memberType android.SdkMemberType
1350 name string
Paul Duffin3a4eb502020-03-19 16:11:18 +00001351}
1352
1353func (m *memberContext) SdkModuleContext() android.ModuleContext {
1354 return m.sdkMemberContext
1355}
1356
1357func (m *memberContext) SnapshotBuilder() android.SnapshotBuilder {
1358 return m.builder
1359}
1360
Paul Duffina551a1c2020-03-17 21:04:24 +00001361func (m *memberContext) MemberType() android.SdkMemberType {
1362 return m.memberType
1363}
1364
1365func (m *memberContext) Name() string {
1366 return m.name
1367}
1368
Martin Stjernholmcaa47d72020-07-11 04:52:24 +01001369func (s *sdk) createMemberSnapshot(ctx *memberContext, member *sdkMember, bpModule *bpModule) {
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001370
1371 memberType := member.memberType
1372
Paul Duffin83ad9562021-05-10 23:49:04 +01001373 // Set the prefer based on the environment variable. This is a temporary work around to allow a
1374 // snapshot to be created that sets prefer: true.
1375 // TODO(b/174997203): Remove once the ability to select the modules to prefer can be done
1376 // dynamically at build time not at snapshot generation time.
1377 prefer := ctx.sdkMemberContext.Config().IsEnvTrue("SOONG_SDK_SNAPSHOT_PREFER")
1378
1379 // Set prefer. Setting this to false is not strictly required as that is the default but it does
1380 // provide a convenient hook to post-process the generated Android.bp file, e.g. in tests to
1381 // check the behavior when a prebuilt is preferred. It also makes it explicit what the default
1382 // behavior is for the module.
1383 bpModule.insertAfter("name", "prefer", prefer)
1384
Paul Duffina04c1072020-03-02 10:16:35 +00001385 // Group the variants by os type.
Paul Duffin3a4eb502020-03-19 16:11:18 +00001386 variantsByOsType := make(map[android.OsType][]android.Module)
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001387 variants := member.Variants()
1388 for _, variant := range variants {
Paul Duffina04c1072020-03-02 10:16:35 +00001389 osType := variant.Target().Os
1390 variantsByOsType[osType] = append(variantsByOsType[osType], variant)
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001391 }
1392
Paul Duffina04c1072020-03-02 10:16:35 +00001393 osCount := len(variantsByOsType)
Paul Duffinb44b33a2020-03-17 10:58:23 +00001394 variantPropertiesFactory := func() android.SdkMemberProperties {
Paul Duffina04c1072020-03-02 10:16:35 +00001395 properties := memberType.CreateVariantPropertiesStruct()
1396 base := properties.Base()
1397 base.Os_count = osCount
Paul Duffina04c1072020-03-02 10:16:35 +00001398 return properties
1399 }
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001400
Paul Duffina04c1072020-03-02 10:16:35 +00001401 osTypeToInfo := make(map[android.OsType]*osTypeSpecificInfo)
Paul Duffin14eb4672020-03-02 11:33:02 +00001402
Paul Duffina04c1072020-03-02 10:16:35 +00001403 // The set of properties that are common across all architectures and os types.
Paul Duffinb44b33a2020-03-17 10:58:23 +00001404 commonProperties := variantPropertiesFactory()
1405 commonProperties.Base().Os = android.CommonOS
Paul Duffina04c1072020-03-02 10:16:35 +00001406
Paul Duffinc097e362020-03-10 22:50:03 +00001407 // Create common value extractor that can be used to optimize the properties.
1408 commonValueExtractor := newCommonValueExtractor(commonProperties)
1409
Paul Duffina04c1072020-03-02 10:16:35 +00001410 // The list of property structures which are os type specific but common across
1411 // architectures within that os type.
Paul Duffinf34f6d82020-04-30 15:48:31 +01001412 var osSpecificPropertiesContainers []*osTypeSpecificInfo
Paul Duffina04c1072020-03-02 10:16:35 +00001413
1414 for osType, osTypeVariants := range variantsByOsType {
Paul Duffin3a4eb502020-03-19 16:11:18 +00001415 osInfo := newOsTypeSpecificInfo(ctx, osType, variantPropertiesFactory, osTypeVariants)
Paul Duffina04c1072020-03-02 10:16:35 +00001416 osTypeToInfo[osType] = osInfo
Paul Duffinb44b33a2020-03-17 10:58:23 +00001417 // Add the os specific properties to a list of os type specific yet architecture
1418 // independent properties structs.
Paul Duffinf34f6d82020-04-30 15:48:31 +01001419 osSpecificPropertiesContainers = append(osSpecificPropertiesContainers, osInfo)
Paul Duffina04c1072020-03-02 10:16:35 +00001420
Paul Duffin00e46802020-03-12 20:40:35 +00001421 // Optimize the properties across all the variants for a specific os type.
Paul Duffin4b8b7932020-05-06 12:35:38 +01001422 osInfo.optimizeProperties(ctx, commonValueExtractor)
Paul Duffin14eb4672020-03-02 11:33:02 +00001423 }
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001424
Paul Duffina04c1072020-03-02 10:16:35 +00001425 // Extract properties which are common across all architectures and os types.
Paul Duffin4b8b7932020-05-06 12:35:38 +01001426 extractCommonProperties(ctx.sdkMemberContext, commonValueExtractor, commonProperties, osSpecificPropertiesContainers)
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001427
Paul Duffina04c1072020-03-02 10:16:35 +00001428 // Add the common properties to the module.
Martin Stjernholm89238f42020-07-10 00:14:03 +01001429 addSdkMemberPropertiesToSet(ctx, commonProperties, bpModule)
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001430
Paul Duffina04c1072020-03-02 10:16:35 +00001431 // Create a target property set into which target specific properties can be
1432 // added.
1433 targetPropertySet := bpModule.AddPropertySet("target")
1434
Martin Stjernholmcaa47d72020-07-11 04:52:24 +01001435 // If the member is host OS dependent and has host_supported then disable by
1436 // default and enable each host OS variant explicitly. This avoids problems
1437 // with implicitly enabled OS variants when the snapshot is used, which might
1438 // be different from this run (e.g. different build OS).
1439 if ctx.memberType.IsHostOsDependent() {
1440 hostSupported := bpModule.getValue("host_supported") == true // Missing means false.
1441 if hostSupported {
1442 hostPropertySet := targetPropertySet.AddPropertySet("host")
1443 hostPropertySet.AddProperty("enabled", false)
1444 }
1445 }
1446
Paul Duffina04c1072020-03-02 10:16:35 +00001447 // Iterate over the os types in a fixed order.
1448 for _, osType := range s.getPossibleOsTypes() {
1449 osInfo := osTypeToInfo[osType]
1450 if osInfo == nil {
1451 continue
1452 }
1453
Paul Duffin3a4eb502020-03-19 16:11:18 +00001454 osInfo.addToPropertySet(ctx, bpModule, targetPropertySet)
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001455 }
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001456}
1457
Paul Duffina04c1072020-03-02 10:16:35 +00001458// Compute the list of possible os types that this sdk could support.
1459func (s *sdk) getPossibleOsTypes() []android.OsType {
1460 var osTypes []android.OsType
Jingwen Chen2f6a21e2021-04-05 07:33:05 +00001461 for _, osType := range android.OsTypeList() {
Paul Duffina04c1072020-03-02 10:16:35 +00001462 if s.DeviceSupported() {
1463 if osType.Class == android.Device && osType != android.Fuchsia {
1464 osTypes = append(osTypes, osType)
1465 }
1466 }
1467 if s.HostSupported() {
Jiyong Park1613e552020-09-14 19:43:17 +09001468 if osType.Class == android.Host {
Paul Duffina04c1072020-03-02 10:16:35 +00001469 osTypes = append(osTypes, osType)
1470 }
1471 }
1472 }
1473 sort.SliceStable(osTypes, func(i, j int) bool { return osTypes[i].Name < osTypes[j].Name })
1474 return osTypes
1475}
1476
Paul Duffinb28369a2020-05-04 15:39:59 +01001477// Given a set of properties (struct value), return the value of the field within that
1478// struct (or one of its embedded structs).
Paul Duffinc097e362020-03-10 22:50:03 +00001479type fieldAccessorFunc func(structValue reflect.Value) reflect.Value
1480
Paul Duffinc459f892020-04-30 18:08:29 +01001481// Checks the metadata to determine whether the property should be ignored for the
1482// purposes of common value extraction or not.
1483type extractorMetadataPredicate func(metadata propertiesContainer) bool
1484
1485// Indicates whether optimizable properties are provided by a host variant or
1486// not.
1487type isHostVariant interface {
1488 isHostVariant() bool
1489}
1490
Paul Duffinb28369a2020-05-04 15:39:59 +01001491// A property that can be optimized by the commonValueExtractor.
1492type extractorProperty struct {
Martin Stjernholmb0249572020-09-15 02:32:35 +01001493 // The name of the field for this property. It is a "."-separated path for
1494 // fields in non-anonymous substructs.
Paul Duffin4b8b7932020-05-06 12:35:38 +01001495 name string
1496
Paul Duffinc459f892020-04-30 18:08:29 +01001497 // Filter that can use metadata associated with the properties being optimized
1498 // to determine whether the field should be ignored during common value
1499 // optimization.
1500 filter extractorMetadataPredicate
1501
Paul Duffinb28369a2020-05-04 15:39:59 +01001502 // Retrieves the value on which common value optimization will be performed.
1503 getter fieldAccessorFunc
1504
1505 // The empty value for the field.
1506 emptyValue reflect.Value
Paul Duffin864e1b42020-05-06 10:23:19 +01001507
1508 // True if the property can support arch variants false otherwise.
1509 archVariant bool
Paul Duffinb28369a2020-05-04 15:39:59 +01001510}
1511
Paul Duffin4b8b7932020-05-06 12:35:38 +01001512func (p extractorProperty) String() string {
1513 return p.name
1514}
1515
Paul Duffinc097e362020-03-10 22:50:03 +00001516// Supports extracting common values from a number of instances of a properties
1517// structure into a separate common set of properties.
1518type commonValueExtractor struct {
Paul Duffinb28369a2020-05-04 15:39:59 +01001519 // The properties that the extractor can optimize.
1520 properties []extractorProperty
Paul Duffinc097e362020-03-10 22:50:03 +00001521}
1522
1523// Create a new common value extractor for the structure type for the supplied
1524// properties struct.
1525//
1526// The returned extractor can be used on any properties structure of the same type
1527// as the supplied set of properties.
1528func newCommonValueExtractor(propertiesStruct interface{}) *commonValueExtractor {
1529 structType := getStructValue(reflect.ValueOf(propertiesStruct)).Type()
1530 extractor := &commonValueExtractor{}
Martin Stjernholmb0249572020-09-15 02:32:35 +01001531 extractor.gatherFields(structType, nil, "")
Paul Duffinc097e362020-03-10 22:50:03 +00001532 return extractor
1533}
1534
1535// Gather the fields from the supplied structure type from which common values will
1536// be extracted.
Paul Duffinb07fa512020-03-10 22:17:04 +00001537//
Martin Stjernholmb0249572020-09-15 02:32:35 +01001538// This is recursive function. If it encounters a struct then it will recurse
1539// into it, passing in the accessor for the field and the struct name as prefix
1540// for the nested fields. That will then be used in the accessors for the fields
1541// in the embedded struct.
1542func (e *commonValueExtractor) gatherFields(structType reflect.Type, containingStructAccessor fieldAccessorFunc, namePrefix string) {
Paul Duffinc097e362020-03-10 22:50:03 +00001543 for f := 0; f < structType.NumField(); f++ {
1544 field := structType.Field(f)
1545 if field.PkgPath != "" {
1546 // Ignore unexported fields.
1547 continue
1548 }
1549
Paul Duffinb07fa512020-03-10 22:17:04 +00001550 // Ignore fields whose value should be kept.
1551 if proptools.HasTag(field, "sdk", "keep") {
Paul Duffinc097e362020-03-10 22:50:03 +00001552 continue
1553 }
1554
Paul Duffinc459f892020-04-30 18:08:29 +01001555 var filter extractorMetadataPredicate
1556
1557 // Add a filter
1558 if proptools.HasTag(field, "sdk", "ignored-on-host") {
1559 filter = func(metadata propertiesContainer) bool {
1560 if m, ok := metadata.(isHostVariant); ok {
1561 if m.isHostVariant() {
1562 return false
1563 }
1564 }
1565 return true
1566 }
1567 }
1568
Paul Duffinc097e362020-03-10 22:50:03 +00001569 // Save a copy of the field index for use in the function.
1570 fieldIndex := f
Paul Duffin4b8b7932020-05-06 12:35:38 +01001571
Martin Stjernholmb0249572020-09-15 02:32:35 +01001572 name := namePrefix + field.Name
Paul Duffin4b8b7932020-05-06 12:35:38 +01001573
Paul Duffinc097e362020-03-10 22:50:03 +00001574 fieldGetter := func(value reflect.Value) reflect.Value {
Paul Duffinb07fa512020-03-10 22:17:04 +00001575 if containingStructAccessor != nil {
1576 // This is an embedded structure so first access the field for the embedded
1577 // structure.
1578 value = containingStructAccessor(value)
1579 }
1580
Paul Duffinc097e362020-03-10 22:50:03 +00001581 // Skip through interface and pointer values to find the structure.
1582 value = getStructValue(value)
1583
Paul Duffin4b8b7932020-05-06 12:35:38 +01001584 defer func() {
1585 if r := recover(); r != nil {
1586 panic(fmt.Errorf("%s for fieldIndex %d of field %s of value %#v", r, fieldIndex, name, value.Interface()))
1587 }
1588 }()
1589
Paul Duffinc097e362020-03-10 22:50:03 +00001590 // Return the field.
1591 return value.Field(fieldIndex)
1592 }
1593
Martin Stjernholmb0249572020-09-15 02:32:35 +01001594 if field.Type.Kind() == reflect.Struct {
1595 // Gather fields from the nested or embedded structure.
1596 var subNamePrefix string
1597 if field.Anonymous {
1598 subNamePrefix = namePrefix
1599 } else {
1600 subNamePrefix = name + "."
1601 }
1602 e.gatherFields(field.Type, fieldGetter, subNamePrefix)
Paul Duffinb07fa512020-03-10 22:17:04 +00001603 } else {
Paul Duffinb28369a2020-05-04 15:39:59 +01001604 property := extractorProperty{
Paul Duffin4b8b7932020-05-06 12:35:38 +01001605 name,
Paul Duffinc459f892020-04-30 18:08:29 +01001606 filter,
Paul Duffinb28369a2020-05-04 15:39:59 +01001607 fieldGetter,
1608 reflect.Zero(field.Type),
Paul Duffin864e1b42020-05-06 10:23:19 +01001609 proptools.HasTag(field, "android", "arch_variant"),
Paul Duffinb28369a2020-05-04 15:39:59 +01001610 }
1611 e.properties = append(e.properties, property)
Paul Duffinb07fa512020-03-10 22:17:04 +00001612 }
Paul Duffinc097e362020-03-10 22:50:03 +00001613 }
1614}
1615
1616func getStructValue(value reflect.Value) reflect.Value {
1617foundStruct:
1618 for {
1619 kind := value.Kind()
1620 switch kind {
1621 case reflect.Interface, reflect.Ptr:
1622 value = value.Elem()
1623 case reflect.Struct:
1624 break foundStruct
1625 default:
1626 panic(fmt.Errorf("expecting struct, interface or pointer, found %v of kind %s", value, kind))
1627 }
1628 }
1629 return value
1630}
1631
Paul Duffinf34f6d82020-04-30 15:48:31 +01001632// A container of properties to be optimized.
1633//
1634// Allows additional information to be associated with the properties, e.g. for
1635// filtering.
1636type propertiesContainer interface {
Paul Duffin4b8b7932020-05-06 12:35:38 +01001637 fmt.Stringer
1638
Paul Duffinf34f6d82020-04-30 15:48:31 +01001639 // Get the properties that need optimizing.
1640 optimizableProperties() interface{}
1641}
1642
Paul Duffin2d1bb892021-04-24 11:32:59 +01001643// A wrapper for sdk variant related properties to allow them to be optimized.
1644type sdkVariantPropertiesContainer struct {
1645 sdkVariant *sdk
1646 properties interface{}
Paul Duffinf34f6d82020-04-30 15:48:31 +01001647}
1648
Paul Duffin2d1bb892021-04-24 11:32:59 +01001649func (c sdkVariantPropertiesContainer) optimizableProperties() interface{} {
1650 return c.properties
Paul Duffinf34f6d82020-04-30 15:48:31 +01001651}
1652
Paul Duffin2d1bb892021-04-24 11:32:59 +01001653func (c sdkVariantPropertiesContainer) String() string {
Paul Duffin4b8b7932020-05-06 12:35:38 +01001654 return c.sdkVariant.String()
1655}
1656
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001657// Extract common properties from a slice of property structures of the same type.
1658//
1659// All the property structures must be of the same type.
1660// commonProperties - must be a pointer to the structure into which common properties will be added.
Paul Duffinf34f6d82020-04-30 15:48:31 +01001661// inputPropertiesSlice - must be a slice of propertiesContainer interfaces.
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001662//
1663// Iterates over each exported field (capitalized name) and checks to see whether they
1664// have the same value (using DeepEquals) across all the input properties. If it does not then no
1665// change is made. Otherwise, the common value is stored in the field in the commonProperties
Martin Stjernholmb0249572020-09-15 02:32:35 +01001666// and the field in each of the input properties structure is set to its default value. Nested
1667// structs are visited recursively and their non-struct fields are compared.
Paul Duffin4b8b7932020-05-06 12:35:38 +01001668func (e *commonValueExtractor) extractCommonProperties(commonProperties interface{}, inputPropertiesSlice interface{}) error {
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001669 commonPropertiesValue := reflect.ValueOf(commonProperties)
1670 commonStructValue := commonPropertiesValue.Elem()
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001671
Paul Duffinf34f6d82020-04-30 15:48:31 +01001672 sliceValue := reflect.ValueOf(inputPropertiesSlice)
1673
Paul Duffinb28369a2020-05-04 15:39:59 +01001674 for _, property := range e.properties {
1675 fieldGetter := property.getter
Paul Duffinc459f892020-04-30 18:08:29 +01001676 filter := property.filter
1677 if filter == nil {
1678 filter = func(metadata propertiesContainer) bool {
1679 return true
1680 }
1681 }
Paul Duffinb28369a2020-05-04 15:39:59 +01001682
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001683 // Check to see if all the structures have the same value for the field. The commonValue
Paul Duffin864e1b42020-05-06 10:23:19 +01001684 // is nil on entry to the loop and if it is nil on exit then there is no common value or
1685 // all the values have been filtered out, otherwise it points to the common value.
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001686 var commonValue *reflect.Value
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001687
Paul Duffin864e1b42020-05-06 10:23:19 +01001688 // Assume that all the values will be the same.
1689 //
1690 // While similar to this is not quite the same as commonValue == nil. If all the values
1691 // have been filtered out then this will be false but commonValue == nil will be true.
1692 valuesDiffer := false
1693
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001694 for i := 0; i < sliceValue.Len(); i++ {
Paul Duffinf34f6d82020-04-30 15:48:31 +01001695 container := sliceValue.Index(i).Interface().(propertiesContainer)
1696 itemValue := reflect.ValueOf(container.optimizableProperties())
Paul Duffinc097e362020-03-10 22:50:03 +00001697 fieldValue := fieldGetter(itemValue)
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001698
Paul Duffinc459f892020-04-30 18:08:29 +01001699 if !filter(container) {
1700 expectedValue := property.emptyValue.Interface()
1701 actualValue := fieldValue.Interface()
1702 if !reflect.DeepEqual(expectedValue, actualValue) {
1703 return fmt.Errorf("field %q is supposed to be ignored for %q but is set to %#v instead of %#v", property, container, actualValue, expectedValue)
1704 }
1705 continue
1706 }
1707
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001708 if commonValue == nil {
1709 // Use the first value as the commonProperties value.
1710 commonValue = &fieldValue
1711 } else {
1712 // If the value does not match the current common value then there is
1713 // no value in common so break out.
1714 if !reflect.DeepEqual(fieldValue.Interface(), commonValue.Interface()) {
1715 commonValue = nil
Paul Duffin864e1b42020-05-06 10:23:19 +01001716 valuesDiffer = true
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001717 break
1718 }
1719 }
1720 }
1721
Paul Duffin864e1b42020-05-06 10:23:19 +01001722 // If the fields all have common value then store it in the common struct field
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001723 // and set the input struct's field to the empty value.
1724 if commonValue != nil {
Paul Duffinb28369a2020-05-04 15:39:59 +01001725 emptyValue := property.emptyValue
Paul Duffinc097e362020-03-10 22:50:03 +00001726 fieldGetter(commonStructValue).Set(*commonValue)
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001727 for i := 0; i < sliceValue.Len(); i++ {
Paul Duffinf34f6d82020-04-30 15:48:31 +01001728 container := sliceValue.Index(i).Interface().(propertiesContainer)
1729 itemValue := reflect.ValueOf(container.optimizableProperties())
Paul Duffinc097e362020-03-10 22:50:03 +00001730 fieldValue := fieldGetter(itemValue)
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001731 fieldValue.Set(emptyValue)
1732 }
1733 }
Paul Duffin864e1b42020-05-06 10:23:19 +01001734
1735 if valuesDiffer && !property.archVariant {
1736 // The values differ but the property does not support arch variants so it
1737 // is an error.
1738 var details strings.Builder
1739 for i := 0; i < sliceValue.Len(); i++ {
1740 container := sliceValue.Index(i).Interface().(propertiesContainer)
1741 itemValue := reflect.ValueOf(container.optimizableProperties())
1742 fieldValue := fieldGetter(itemValue)
1743
1744 _, _ = fmt.Fprintf(&details, "\n %q has value %q", container.String(), fieldValue.Interface())
1745 }
1746
1747 return fmt.Errorf("field %q is not tagged as \"arch_variant\" but has arch specific properties:%s", property.String(), details.String())
1748 }
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001749 }
Paul Duffin4b8b7932020-05-06 12:35:38 +01001750
1751 return nil
Paul Duffin88f2fbe2020-02-27 16:00:53 +00001752}