blob: 266cada35ea8baf43e3cb20c2ad4c17dcc29bbc3 [file] [log] [blame]
Colin Cross72bb3632017-07-13 16:23:21 -07001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
Colin Cross72bb3632017-07-13 16:23:21 -070018 "io/ioutil"
19 "os"
20 "path/filepath"
Colin Crossc0806172019-06-14 18:51:47 -070021 "reflect"
Paul Duffin2e7ed652020-05-26 18:13:57 +010022 "regexp"
Paul Duffin64e61992020-05-15 10:20:31 +010023 "sort"
Nan Zhang61eaedb2017-11-02 13:28:15 -070024 "strconv"
Colin Cross72bb3632017-07-13 16:23:21 -070025 "strings"
26 "testing"
Colin Cross86a60ae2018-05-29 14:44:55 -070027
Jeongik Cha28df2572019-11-11 10:46:36 +090028 "github.com/google/blueprint/proptools"
29
Colin Crossa4f08812018-10-02 22:03:40 -070030 "android/soong/android"
31 "android/soong/cc"
Colin Crossc28bb0b2019-02-25 14:20:47 -080032 "android/soong/dexpreopt"
Colin Crossa4f08812018-10-02 22:03:40 -070033 "android/soong/genrule"
Colin Cross72bb3632017-07-13 16:23:21 -070034)
35
36var buildDir string
37
38func setUp() {
39 var err error
40 buildDir, err = ioutil.TempDir("", "soong_java_test")
41 if err != nil {
42 panic(err)
43 }
44}
45
46func tearDown() {
47 os.RemoveAll(buildDir)
48}
49
50func TestMain(m *testing.M) {
51 run := func() int {
52 setUp()
53 defer tearDown()
54
55 return m.Run()
56 }
57
58 os.Exit(run())
59}
Colin Cross527012a2017-11-30 22:56:16 -080060
Colin Cross98be1bb2019-12-13 20:41:13 -080061func testConfig(env map[string]string, bp string, fs map[string][]byte) android.Config {
Martin Stjernholmd90676f2020-01-11 00:37:30 +000062 bp += dexpreopt.BpToolModulesForTest()
63
Martin Stjernholm75a48d82020-01-10 20:32:59 +000064 config := TestConfig(buildDir, env, bp, fs)
65
66 // Set up the global Once cache used for dexpreopt.GlobalSoongConfig, so that
67 // it doesn't create a real one, which would fail.
68 _ = dexpreopt.GlobalSoongConfigForTests(config)
69
70 return config
Colin Cross1369cdb2017-09-29 17:58:17 -070071}
72
Colin Cross98be1bb2019-12-13 20:41:13 -080073func testContext() *android.TestContext {
Colin Cross72bb3632017-07-13 16:23:21 -070074
Colin Cross4c428df2017-09-15 17:36:05 -070075 ctx := android.NewTestArchContext()
Paul Duffinf9b1da02019-12-18 19:51:55 +000076 RegisterJavaBuildComponents(ctx)
77 RegisterAppBuildComponents(ctx)
78 RegisterAARBuildComponents(ctx)
Paul Duffinb0f85072019-12-19 10:28:56 +000079 RegisterGenRuleBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000080 RegisterSystemModulesBuildComponents(ctx)
Colin Cross4b49b762019-11-22 15:25:03 -080081 ctx.RegisterModuleType("java_plugin", PluginFactory)
Colin Cross4b49b762019-11-22 15:25:03 -080082 ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
83 ctx.RegisterModuleType("genrule", genrule.GenRuleFactory)
Paul Duffin884363e2019-12-19 10:21:09 +000084 RegisterDocsBuildComponents(ctx)
85 RegisterStubsBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000086 RegisterSdkLibraryBuildComponents(ctx)
Colin Cross89536d42017-07-07 14:35:50 -070087 ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
Paul Duffina48f7582019-12-19 11:25:19 +000088
89 RegisterPrebuiltApisBuildComponents(ctx)
90
Jaewoong Jungb639a6a2019-05-10 15:16:29 -070091 ctx.PostDepsMutators(android.RegisterOverridePostDepsMutators)
Colin Cross3bc7ffa2017-11-22 16:19:37 -080092 ctx.RegisterPreSingletonType("overlay", android.SingletonFactoryAdaptor(OverlaySingletonFactory))
Colin Cross3047fa22019-04-18 10:56:44 -070093 ctx.RegisterPreSingletonType("sdk_versions", android.SingletonFactoryAdaptor(sdkPreSingletonFactory))
Colin Crossa4f08812018-10-02 22:03:40 -070094
95 // Register module types and mutators from cc needed for JNI testing
Paul Duffin77980a82019-12-19 16:01:36 +000096 cc.RegisterRequiredBuildComponentsForTest(ctx)
Colin Crossa4f08812018-10-02 22:03:40 -070097
Martin Stjernholmd90676f2020-01-11 00:37:30 +000098 dexpreopt.RegisterToolModulesForTest(ctx)
99
Colin Cross527012a2017-11-30 22:56:16 -0800100 return ctx
101}
102
103func run(t *testing.T, ctx *android.TestContext, config android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800104 t.Helper()
Colin Crossc28bb0b2019-02-25 14:20:47 -0800105
Colin Cross98be1bb2019-12-13 20:41:13 -0800106 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000107 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Colin Crossc28bb0b2019-02-25 14:20:47 -0800108
Colin Cross98be1bb2019-12-13 20:41:13 -0800109 ctx.Register(config)
Paul Duffinbaccf7e2019-06-11 11:58:30 +0100110 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
Logan Chien42039712018-03-12 16:29:17 +0800111 android.FailIfErrored(t, errs)
Colin Cross72bb3632017-07-13 16:23:21 -0700112 _, errs = ctx.PrepareBuildActions(config)
Logan Chien42039712018-03-12 16:29:17 +0800113 android.FailIfErrored(t, errs)
Colin Cross527012a2017-11-30 22:56:16 -0800114}
115
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900116func testJavaError(t *testing.T, pattern string, bp string) (*android.TestContext, android.Config) {
Jeongik Cha538c0d02019-07-11 15:54:27 +0900117 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800118 return testJavaErrorWithConfig(t, pattern, testConfig(nil, bp, nil))
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900119}
120
Colin Cross98be1bb2019-12-13 20:41:13 -0800121func testJavaErrorWithConfig(t *testing.T, pattern string, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900122 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800123 ctx := testContext()
Jeongik Cha538c0d02019-07-11 15:54:27 +0900124
Colin Cross98be1bb2019-12-13 20:41:13 -0800125 pathCtx := android.PathContextForTesting(config)
Martin Stjernholm40f9f3c2020-01-20 18:12:23 +0000126 dexpreopt.SetTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
Jeongik Cha538c0d02019-07-11 15:54:27 +0900127
Colin Cross98be1bb2019-12-13 20:41:13 -0800128 ctx.Register(config)
Jeongik Cha538c0d02019-07-11 15:54:27 +0900129 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
130 if len(errs) > 0 {
131 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900132 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900133 }
134 _, errs = ctx.PrepareBuildActions(config)
135 if len(errs) > 0 {
136 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900137 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900138 }
139
140 t.Fatalf("missing expected error %q (0 errors are returned)", pattern)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900141
142 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900143}
144
Colin Crossf5f663b2020-06-07 16:58:18 -0700145func testJavaWithFS(t *testing.T, bp string, fs map[string][]byte) (*android.TestContext, android.Config) {
146 t.Helper()
147 return testJavaWithConfig(t, testConfig(nil, bp, fs))
148}
149
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700150func testJava(t *testing.T, bp string) (*android.TestContext, android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800151 t.Helper()
Colin Crossf5f663b2020-06-07 16:58:18 -0700152 return testJavaWithFS(t, bp, nil)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900153}
154
Colin Cross98be1bb2019-12-13 20:41:13 -0800155func testJavaWithConfig(t *testing.T, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900156 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800157 ctx := testContext()
Colin Cross527012a2017-11-30 22:56:16 -0800158 run(t, ctx, config)
Colin Cross72bb3632017-07-13 16:23:21 -0700159
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700160 return ctx, config
Colin Cross72bb3632017-07-13 16:23:21 -0700161}
162
Colin Cross2acdae82017-09-15 19:44:24 -0700163func moduleToPath(name string) string {
164 switch {
165 case name == `""`:
166 return name
Colin Crossfc3674a2017-09-18 17:41:52 -0700167 case strings.HasSuffix(name, ".jar"):
168 return name
Nan Zhanged19fc32017-10-19 13:06:22 -0700169 default:
170 return filepath.Join(buildDir, ".intermediates", name, "android_common", "turbine-combined", name+".jar")
Colin Cross2acdae82017-09-15 19:44:24 -0700171 }
172}
173
Jeongik Chae403e9e2019-12-07 00:16:24 +0900174func TestJavaLinkType(t *testing.T) {
175 testJava(t, `
176 java_library {
177 name: "foo",
178 srcs: ["a.java"],
179 libs: ["bar"],
180 static_libs: ["baz"],
181 }
182
183 java_library {
184 name: "bar",
185 sdk_version: "current",
186 srcs: ["b.java"],
187 }
188
189 java_library {
190 name: "baz",
191 sdk_version: "system_current",
192 srcs: ["c.java"],
193 }
194 `)
195
196 testJavaError(t, "Adjust sdk_version: property of the source or target module so that target module is built with the same or smaller API set than the source.", `
197 java_library {
198 name: "foo",
199 srcs: ["a.java"],
200 libs: ["bar"],
201 sdk_version: "current",
202 static_libs: ["baz"],
203 }
204
205 java_library {
206 name: "bar",
207 sdk_version: "current",
208 srcs: ["b.java"],
209 }
210
211 java_library {
212 name: "baz",
213 sdk_version: "system_current",
214 srcs: ["c.java"],
215 }
216 `)
217
218 testJava(t, `
219 java_library {
220 name: "foo",
221 srcs: ["a.java"],
222 libs: ["bar"],
223 sdk_version: "system_current",
224 static_libs: ["baz"],
225 }
226
227 java_library {
228 name: "bar",
229 sdk_version: "current",
230 srcs: ["b.java"],
231 }
232
233 java_library {
234 name: "baz",
235 sdk_version: "system_current",
236 srcs: ["c.java"],
237 }
238 `)
239
240 testJavaError(t, "Adjust sdk_version: property of the source or target module so that target module is built with the same or smaller API set than the source.", `
241 java_library {
242 name: "foo",
243 srcs: ["a.java"],
244 libs: ["bar"],
245 sdk_version: "system_current",
246 static_libs: ["baz"],
247 }
248
249 java_library {
250 name: "bar",
251 sdk_version: "current",
252 srcs: ["b.java"],
253 }
254
255 java_library {
256 name: "baz",
257 srcs: ["c.java"],
258 }
259 `)
260}
261
Colin Cross72bb3632017-07-13 16:23:21 -0700262func TestSimple(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700263 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700264 java_library {
265 name: "foo",
266 srcs: ["a.java"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700267 libs: ["bar"],
268 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700269 }
270
271 java_library {
272 name: "bar",
273 srcs: ["b.java"],
274 }
275
276 java_library {
277 name: "baz",
278 srcs: ["c.java"],
279 }
Colin Crossd5934c82017-10-02 13:55:26 -0700280 `)
Colin Cross72bb3632017-07-13 16:23:21 -0700281
Colin Cross4c428df2017-09-15 17:36:05 -0700282 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700283 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross72bb3632017-07-13 16:23:21 -0700284
285 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
286 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
287 }
288
Colin Cross1ee23172017-10-18 14:44:18 -0700289 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Nan Zhanged19fc32017-10-19 13:06:22 -0700290 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
291 bazTurbine := filepath.Join(buildDir, ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar")
Colin Cross0a6e0072017-08-30 14:24:55 -0700292
Nan Zhanged19fc32017-10-19 13:06:22 -0700293 if !strings.Contains(javac.Args["classpath"], barTurbine) {
294 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross72bb3632017-07-13 16:23:21 -0700295 }
296
Nan Zhanged19fc32017-10-19 13:06:22 -0700297 if !strings.Contains(javac.Args["classpath"], bazTurbine) {
298 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], bazTurbine)
Colin Cross0a6e0072017-08-30 14:24:55 -0700299 }
300
301 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
302 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross72bb3632017-07-13 16:23:21 -0700303 }
304}
305
Artur Satayev9cf46692019-11-26 18:08:34 +0000306func TestExportedPlugins(t *testing.T) {
307 type Result struct {
308 library string
309 processors string
310 }
311 var tests = []struct {
312 name string
313 extra string
314 results []Result
315 }{
316 {
317 name: "Exported plugin is not a direct plugin",
318 extra: `java_library { name: "exports", srcs: ["a.java"], exported_plugins: ["plugin"] }`,
319 results: []Result{{library: "exports", processors: "-proc:none"}},
320 },
321 {
322 name: "Exports plugin to dependee",
323 extra: `
324 java_library{name: "exports", exported_plugins: ["plugin"]}
325 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
326 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
327 `,
328 results: []Result{
329 {library: "foo", processors: "-processor com.android.TestPlugin"},
330 {library: "bar", processors: "-processor com.android.TestPlugin"},
331 },
332 },
333 {
334 name: "Exports plugin to android_library",
335 extra: `
336 java_library{name: "exports", exported_plugins: ["plugin"]}
337 android_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
338 android_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
339 `,
340 results: []Result{
341 {library: "foo", processors: "-processor com.android.TestPlugin"},
342 {library: "bar", processors: "-processor com.android.TestPlugin"},
343 },
344 },
345 {
346 name: "Exports plugin is not propagated via transitive deps",
347 extra: `
348 java_library{name: "exports", exported_plugins: ["plugin"]}
349 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
350 java_library{name: "bar", srcs: ["a.java"], static_libs: ["foo"]}
351 `,
352 results: []Result{
353 {library: "foo", processors: "-processor com.android.TestPlugin"},
354 {library: "bar", processors: "-proc:none"},
355 },
356 },
357 {
358 name: "Exports plugin appends to plugins",
359 extra: `
360 java_plugin{name: "plugin2", processor_class: "com.android.TestPlugin2"}
361 java_library{name: "exports", exported_plugins: ["plugin"]}
362 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"], plugins: ["plugin2"]}
363 `,
364 results: []Result{
365 {library: "foo", processors: "-processor com.android.TestPlugin,com.android.TestPlugin2"},
366 },
367 },
368 }
369
370 for _, test := range tests {
371 t.Run(test.name, func(t *testing.T) {
372 ctx, _ := testJava(t, `
373 java_plugin {
374 name: "plugin",
375 processor_class: "com.android.TestPlugin",
376 }
377 `+test.extra)
378
379 for _, want := range test.results {
380 javac := ctx.ModuleForTests(want.library, "android_common").Rule("javac")
381 if javac.Args["processor"] != want.processors {
382 t.Errorf("For library %v, expected %v, found %v", want.library, want.processors, javac.Args["processor"])
383 }
384 }
385 })
386 }
387}
388
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900389func TestSdkVersionByPartition(t *testing.T) {
390 testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900391 java_library {
392 name: "foo",
393 srcs: ["a.java"],
394 vendor: true,
395 }
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900396 `)
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900397
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900398 testJava(t, `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900399 java_library {
400 name: "bar",
401 srcs: ["b.java"],
402 }
403 `)
404
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900405 for _, enforce := range []bool{true, false} {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900406 bp := `
407 java_library {
408 name: "foo",
409 srcs: ["a.java"],
410 product_specific: true,
411 }
412 `
Colin Cross98be1bb2019-12-13 20:41:13 -0800413
414 config := testConfig(nil, bp, nil)
415 config.TestProductVariables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900416 if enforce {
Colin Cross98be1bb2019-12-13 20:41:13 -0800417 testJavaErrorWithConfig(t, "sdk_version must have a value when the module is located at vendor or product", config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900418 } else {
Colin Cross98be1bb2019-12-13 20:41:13 -0800419 testJavaWithConfig(t, config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900420 }
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900421 }
422}
423
Colin Crossd5934c82017-10-02 13:55:26 -0700424func TestArchSpecific(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700425 ctx, _ := testJava(t, `
Colin Crossd5934c82017-10-02 13:55:26 -0700426 java_library {
427 name: "foo",
428 srcs: ["a.java"],
429 target: {
430 android: {
431 srcs: ["b.java"],
432 },
433 },
434 }
435 `)
436
437 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
438 if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" {
439 t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs)
440 }
441}
442
Colin Cross6b4a32d2017-12-05 13:42:45 -0800443func TestBinary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700444 ctx, _ := testJava(t, `
Colin Cross6b4a32d2017-12-05 13:42:45 -0800445 java_library_host {
446 name: "foo",
447 srcs: ["a.java"],
448 }
449
450 java_binary_host {
451 name: "bar",
452 srcs: ["b.java"],
453 static_libs: ["foo"],
454 }
455 `)
456
457 buildOS := android.BuildOs.String()
458
459 bar := ctx.ModuleForTests("bar", buildOS+"_common")
460 barJar := bar.Output("bar.jar").Output.String()
461 barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64")
462 barWrapperDeps := barWrapper.Output("bar").Implicits.Strings()
463
464 // Test that the install binary wrapper depends on the installed jar file
465 if len(barWrapperDeps) != 1 || barWrapperDeps[0] != barJar {
466 t.Errorf("expected binary wrapper implicits [%q], got %v",
467 barJar, barWrapperDeps)
468 }
469
470}
471
Colin Cross72bb3632017-07-13 16:23:21 -0700472func TestPrebuilts(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700473 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700474 java_library {
475 name: "foo",
Paul Duffin91547182019-11-12 19:39:36 +0000476 srcs: ["a.java", ":stubs-source"],
Paul Duffinfcfd7912020-01-31 17:54:30 +0000477 libs: ["bar", "sdklib"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700478 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700479 }
480
Colin Cross74d73e22017-08-02 11:05:49 -0700481 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700482 name: "bar",
Colin Cross74d73e22017-08-02 11:05:49 -0700483 jars: ["a.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700484 }
485
Colin Cross74d73e22017-08-02 11:05:49 -0700486 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700487 name: "baz",
Colin Cross74d73e22017-08-02 11:05:49 -0700488 jars: ["b.jar"],
Liz Kammer4f68ee72020-08-05 15:40:41 -0700489 sdk_version: "current",
490 compile_dex: true,
Colin Cross72bb3632017-07-13 16:23:21 -0700491 }
Colin Cross42be7612019-02-21 18:12:14 -0800492
493 dex_import {
494 name: "qux",
495 jars: ["b.jar"],
496 }
Colin Cross79c7c262019-04-17 11:11:46 -0700497
498 java_sdk_library_import {
Paul Duffin56d44902020-01-31 13:36:25 +0000499 name: "sdklib",
500 public: {
501 jars: ["c.jar"],
502 },
503 }
504
Paul Duffin91547182019-11-12 19:39:36 +0000505 prebuilt_stubs_sources {
506 name: "stubs-source",
Paul Duffin9b478b02019-12-10 13:41:51 +0000507 srcs: ["stubs/sources"],
Paul Duffin91547182019-11-12 19:39:36 +0000508 }
Paul Duffin1b82e6a2019-12-03 18:06:47 +0000509
510 java_test_import {
511 name: "test",
512 jars: ["a.jar"],
513 test_suites: ["cts"],
514 test_config: "AndroidTest.xml",
515 }
Colin Cross72bb3632017-07-13 16:23:21 -0700516 `)
517
Paul Duffin9b478b02019-12-10 13:41:51 +0000518 fooModule := ctx.ModuleForTests("foo", "android_common")
519 javac := fooModule.Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700520 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Liz Kammer4f68ee72020-08-05 15:40:41 -0700521 barModule := ctx.ModuleForTests("bar", "android_common")
522 barJar := barModule.Rule("combineJar").Output
523 bazModule := ctx.ModuleForTests("baz", "android_common")
524 bazJar := bazModule.Rule("combineJar").Output
Colin Cross79c7c262019-04-17 11:11:46 -0700525 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs", "android_common").Rule("combineJar").Output
Colin Cross72bb3632017-07-13 16:23:21 -0700526
Paul Duffin9b478b02019-12-10 13:41:51 +0000527 fooLibrary := fooModule.Module().(*Library)
528 assertDeepEquals(t, "foo java sources incorrect",
529 []string{"a.java"}, fooLibrary.compiledJavaSrcs.Strings())
Paul Duffin91547182019-11-12 19:39:36 +0000530
Paul Duffin9b478b02019-12-10 13:41:51 +0000531 assertDeepEquals(t, "foo java source jars incorrect",
532 []string{".intermediates/stubs-source/android_common/stubs-source-stubs.srcjar"},
533 android.NormalizePathsForTesting(fooLibrary.compiledSrcJars))
Paul Duffin91547182019-11-12 19:39:36 +0000534
Colin Cross37f6d792018-07-12 12:28:41 -0700535 if !strings.Contains(javac.Args["classpath"], barJar.String()) {
536 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700537 }
538
Liz Kammer4f68ee72020-08-05 15:40:41 -0700539 barDexJar := barModule.Module().(*Import).DexJar()
540 if barDexJar != nil {
541 t.Errorf("bar dex jar build path expected to be nil, got %q", barDexJar)
542 }
543
Colin Cross79c7c262019-04-17 11:11:46 -0700544 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
545 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
546 }
547
Colin Cross37f6d792018-07-12 12:28:41 -0700548 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() {
549 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700550 }
Colin Cross42be7612019-02-21 18:12:14 -0800551
Liz Kammer4f68ee72020-08-05 15:40:41 -0700552 bazDexJar := bazModule.Module().(*Import).DexJar().String()
553 expectedDexJar := buildDir + "/.intermediates/baz/android_common/dex/baz.jar"
554 if bazDexJar != expectedDexJar {
555 t.Errorf("baz dex jar build path expected %q, got %q", expectedDexJar, bazDexJar)
556 }
557
Colin Cross42be7612019-02-21 18:12:14 -0800558 ctx.ModuleForTests("qux", "android_common").Rule("Cp")
Colin Cross72bb3632017-07-13 16:23:21 -0700559}
560
Paul Duffin9b478b02019-12-10 13:41:51 +0000561func assertDeepEquals(t *testing.T, message string, expected interface{}, actual interface{}) {
562 if !reflect.DeepEqual(expected, actual) {
563 t.Errorf("%s: expected %q, found %q", message, expected, actual)
564 }
565}
566
Paul Duffin56d44902020-01-31 13:36:25 +0000567func TestJavaSdkLibraryImport(t *testing.T) {
568 ctx, _ := testJava(t, `
569 java_library {
570 name: "foo",
571 srcs: ["a.java"],
572 libs: ["sdklib"],
573 sdk_version: "current",
574 }
575
576 java_library {
577 name: "foo.system",
578 srcs: ["a.java"],
579 libs: ["sdklib"],
580 sdk_version: "system_current",
581 }
582
583 java_library {
584 name: "foo.test",
585 srcs: ["a.java"],
586 libs: ["sdklib"],
587 sdk_version: "test_current",
588 }
589
590 java_sdk_library_import {
591 name: "sdklib",
592 public: {
593 jars: ["a.jar"],
594 },
595 system: {
596 jars: ["b.jar"],
597 },
598 test: {
599 jars: ["c.jar"],
Paul Duffin533f9c72020-05-20 16:18:00 +0100600 stub_srcs: ["c.java"],
Paul Duffin56d44902020-01-31 13:36:25 +0000601 },
602 }
603 `)
604
605 for _, scope := range []string{"", ".system", ".test"} {
606 fooModule := ctx.ModuleForTests("foo"+scope, "android_common")
607 javac := fooModule.Rule("javac")
608
609 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs"+scope, "android_common").Rule("combineJar").Output
610 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
611 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
612 }
613 }
614}
615
Colin Cross89536d42017-07-07 14:35:50 -0700616func TestDefaults(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700617 ctx, _ := testJava(t, `
Colin Cross89536d42017-07-07 14:35:50 -0700618 java_defaults {
619 name: "defaults",
620 srcs: ["a.java"],
621 libs: ["bar"],
622 static_libs: ["baz"],
Sasha Smundak2057f822019-04-16 17:16:58 -0700623 optimize: {enabled: false},
Colin Cross89536d42017-07-07 14:35:50 -0700624 }
625
626 java_library {
627 name: "foo",
628 defaults: ["defaults"],
629 }
630
631 java_library {
632 name: "bar",
633 srcs: ["b.java"],
634 }
635
636 java_library {
637 name: "baz",
638 srcs: ["c.java"],
639 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700640
641 android_test {
642 name: "atestOptimize",
643 defaults: ["defaults"],
644 optimize: {enabled: true},
645 }
646
647 android_test {
648 name: "atestNoOptimize",
649 defaults: ["defaults"],
650 }
651
652 android_test {
653 name: "atestDefault",
654 srcs: ["a.java"],
655 }
Colin Cross89536d42017-07-07 14:35:50 -0700656 `)
657
Colin Cross4c428df2017-09-15 17:36:05 -0700658 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700659 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross89536d42017-07-07 14:35:50 -0700660
661 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
662 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
663 }
664
Nan Zhanged19fc32017-10-19 13:06:22 -0700665 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
666 if !strings.Contains(javac.Args["classpath"], barTurbine) {
667 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross89536d42017-07-07 14:35:50 -0700668 }
669
Colin Cross1ee23172017-10-18 14:44:18 -0700670 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Colin Cross0a6e0072017-08-30 14:24:55 -0700671 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
672 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross89536d42017-07-07 14:35:50 -0700673 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700674
675 atestOptimize := ctx.ModuleForTests("atestOptimize", "android_common").MaybeRule("r8")
676 if atestOptimize.Output == nil {
677 t.Errorf("atestOptimize should optimize APK")
678 }
679
680 atestNoOptimize := ctx.ModuleForTests("atestNoOptimize", "android_common").MaybeRule("d8")
681 if atestNoOptimize.Output == nil {
682 t.Errorf("atestNoOptimize should not optimize APK")
683 }
684
685 atestDefault := ctx.ModuleForTests("atestDefault", "android_common").MaybeRule("r8")
686 if atestDefault.Output == nil {
687 t.Errorf("atestDefault should optimize APK")
688 }
Colin Cross89536d42017-07-07 14:35:50 -0700689}
690
Colin Cross0f37af02017-09-27 17:42:05 -0700691func TestResources(t *testing.T) {
692 var table = []struct {
693 name string
694 prop string
695 extra string
696 args string
697 }{
698 {
Colin Crossaf9c55b2017-10-03 14:50:08 -0700699 // Test that a module with java_resource_dirs includes the files
Colin Cross0f37af02017-09-27 17:42:05 -0700700 name: "resource dirs",
Colin Cross824bee32017-11-22 17:27:51 -0800701 prop: `java_resource_dirs: ["java-res"]`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700702 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700703 },
704 {
705 // Test that a module with java_resources includes the files
706 name: "resource files",
Colin Cross0ead1d72018-04-10 13:07:42 -0700707 prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`,
708 args: "-C . -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700709 },
710 {
711 // Test that a module with a filegroup in java_resources includes the files with the
712 // path prefix
713 name: "resource filegroup",
714 prop: `java_resources: [":foo-res"]`,
715 extra: `
716 filegroup {
717 name: "foo-res",
Colin Cross824bee32017-11-22 17:27:51 -0800718 path: "java-res",
Colin Cross0ead1d72018-04-10 13:07:42 -0700719 srcs: ["java-res/a/a", "java-res/b/b"],
Colin Cross0f37af02017-09-27 17:42:05 -0700720 }`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700721 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700722 },
723 {
Colin Cross0ead1d72018-04-10 13:07:42 -0700724 // Test that a module with wildcards in java_resource_dirs has the correct path prefixes
725 name: "wildcard dirs",
726 prop: `java_resource_dirs: ["java-res/*"]`,
727 args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b",
728 },
729 {
730 // Test that a module exclude_java_resource_dirs excludes the files
731 name: "wildcard dirs",
732 prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`,
733 args: "-C java-res/a -f java-res/a/a",
734 },
Colin Crosscedd4762018-09-13 11:26:19 -0700735 {
736 // Test wildcards in java_resources
737 name: "wildcard files",
738 prop: `java_resources: ["java-res/**/*"]`,
739 args: "-C . -f java-res/a/a -f java-res/b/b",
740 },
741 {
742 // Test exclude_java_resources with java_resources
743 name: "wildcard files with exclude",
744 prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`,
745 args: "-C . -f java-res/a/a",
746 },
747 {
748 // Test exclude_java_resources with java_resource_dirs
749 name: "resource dirs with exclude files",
750 prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`,
751 args: "-C java-res -f java-res/a/a",
752 },
753 {
754 // Test exclude_java_resource_dirs with java_resource_dirs
755 name: "resource dirs with exclude files",
756 prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`,
757 args: "-C java-res -f java-res/a/a -f java-res/b/b",
758 },
Colin Cross0f37af02017-09-27 17:42:05 -0700759 }
760
761 for _, test := range table {
762 t.Run(test.name, func(t *testing.T) {
Colin Crossf5f663b2020-06-07 16:58:18 -0700763 ctx, _ := testJavaWithFS(t, `
Colin Cross0f37af02017-09-27 17:42:05 -0700764 java_library {
765 name: "foo",
766 srcs: [
767 "a.java",
768 "b.java",
769 "c.java",
770 ],
771 `+test.prop+`,
772 }
Colin Crossf5f663b2020-06-07 16:58:18 -0700773 `+test.extra,
774 map[string][]byte{
775 "java-res/a/a": nil,
776 "java-res/b/b": nil,
777 "java-res2/a": nil,
778 },
779 )
Colin Cross0f37af02017-09-27 17:42:05 -0700780
Colin Cross331a1212018-08-15 20:40:52 -0700781 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
Colin Cross1ee23172017-10-18 14:44:18 -0700782 fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar")
Colin Cross0f37af02017-09-27 17:42:05 -0700783
784 if !inList(fooRes.Output.String(), foo.Inputs.Strings()) {
785 t.Errorf("foo combined jars %v does not contain %q",
786 foo.Inputs.Strings(), fooRes.Output.String())
787 }
788
Colin Crossaf9c55b2017-10-03 14:50:08 -0700789 if fooRes.Args["jarArgs"] != test.args {
790 t.Errorf("foo resource jar args %q is not %q",
Colin Cross0f37af02017-09-27 17:42:05 -0700791 fooRes.Args["jarArgs"], test.args)
792 }
793 })
794 }
795}
796
Colin Cross0c4ce212019-05-03 15:28:19 -0700797func TestIncludeSrcs(t *testing.T) {
Colin Crossf5f663b2020-06-07 16:58:18 -0700798 ctx, _ := testJavaWithFS(t, `
Colin Cross0c4ce212019-05-03 15:28:19 -0700799 java_library {
800 name: "foo",
801 srcs: [
802 "a.java",
803 "b.java",
804 "c.java",
805 ],
806 include_srcs: true,
807 }
808
809 java_library {
810 name: "bar",
811 srcs: [
812 "a.java",
813 "b.java",
814 "c.java",
815 ],
816 java_resource_dirs: ["java-res"],
817 include_srcs: true,
818 }
Colin Crossf5f663b2020-06-07 16:58:18 -0700819 `, map[string][]byte{
820 "java-res/a/a": nil,
821 "java-res/b/b": nil,
822 "java-res2/a": nil,
823 })
Colin Cross0c4ce212019-05-03 15:28:19 -0700824
825 // Test a library with include_srcs: true
826 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
827 fooSrcJar := ctx.ModuleForTests("foo", "android_common").Output("foo.srcjar")
828
829 if g, w := fooSrcJar.Output.String(), foo.Inputs.Strings(); !inList(g, w) {
830 t.Errorf("foo combined jars %v does not contain %q", w, g)
831 }
832
833 if g, w := fooSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
834 t.Errorf("foo source jar args %q is not %q", w, g)
835 }
836
837 // Test a library with include_srcs: true and resources
838 bar := ctx.ModuleForTests("bar", "android_common").Output("withres/bar.jar")
839 barResCombined := ctx.ModuleForTests("bar", "android_common").Output("res-combined/bar.jar")
840 barRes := ctx.ModuleForTests("bar", "android_common").Output("res/bar.jar")
841 barSrcJar := ctx.ModuleForTests("bar", "android_common").Output("bar.srcjar")
842
843 if g, w := barSrcJar.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
844 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
845 }
846
847 if g, w := barRes.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
848 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
849 }
850
851 if g, w := barResCombined.Output.String(), bar.Inputs.Strings(); !inList(g, w) {
852 t.Errorf("bar combined jars %v does not contain %q", w, g)
853 }
854
855 if g, w := barSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
856 t.Errorf("bar source jar args %q is not %q", w, g)
857 }
858
859 if g, w := barRes.Args["jarArgs"], "-C java-res -f java-res/a/a -f java-res/b/b"; g != w {
860 t.Errorf("bar resource jar args %q is not %q", w, g)
861 }
862}
863
Colin Cross54190b32017-10-09 15:34:10 -0700864func TestGeneratedSources(t *testing.T) {
Colin Crossf5f663b2020-06-07 16:58:18 -0700865 ctx, _ := testJavaWithFS(t, `
Colin Cross54190b32017-10-09 15:34:10 -0700866 java_library {
867 name: "foo",
868 srcs: [
869 "a*.java",
870 ":gen",
871 "b*.java",
872 ],
873 }
874
875 genrule {
876 name: "gen",
Colin Cross824bee32017-11-22 17:27:51 -0800877 tool_files: ["java-res/a"],
Colin Cross54190b32017-10-09 15:34:10 -0700878 out: ["gen.java"],
879 }
Colin Crossf5f663b2020-06-07 16:58:18 -0700880 `, map[string][]byte{
881 "a.java": nil,
882 "b.java": nil,
883 })
Colin Cross54190b32017-10-09 15:34:10 -0700884
885 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
886 genrule := ctx.ModuleForTests("gen", "").Rule("generator")
887
Colin Cross15e86d92017-10-20 15:07:08 -0700888 if filepath.Base(genrule.Output.String()) != "gen.java" {
889 t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String())
Colin Cross54190b32017-10-09 15:34:10 -0700890 }
891
892 if len(javac.Inputs) != 3 ||
893 javac.Inputs[0].String() != "a.java" ||
Colin Cross15e86d92017-10-20 15:07:08 -0700894 javac.Inputs[1].String() != genrule.Output.String() ||
Colin Cross54190b32017-10-09 15:34:10 -0700895 javac.Inputs[2].String() != "b.java" {
896 t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs)
897 }
898}
899
Nan Zhang61eaedb2017-11-02 13:28:15 -0700900func TestTurbine(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700901 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -0700902 java_library {
903 name: "foo",
904 srcs: ["a.java"],
Jiyong Park2d492942018-03-05 17:44:10 +0900905 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -0700906 }
907
908 java_library {
909 name: "bar",
Colin Cross9bc43432017-12-15 20:20:39 -0800910 srcs: ["b.java"],
Nan Zhang61eaedb2017-11-02 13:28:15 -0700911 static_libs: ["foo"],
Jiyong Park2d492942018-03-05 17:44:10 +0900912 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -0700913 }
914
915 java_library {
916 name: "baz",
917 srcs: ["c.java"],
918 libs: ["bar"],
919 sdk_version: "14",
920 }
921 `)
922
923 fooTurbine := ctx.ModuleForTests("foo", "android_common").Rule("turbine")
924 barTurbine := ctx.ModuleForTests("bar", "android_common").Rule("turbine")
925 barJavac := ctx.ModuleForTests("bar", "android_common").Rule("javac")
926 barTurbineCombined := ctx.ModuleForTests("bar", "android_common").Description("for turbine")
927 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
928
929 if len(fooTurbine.Inputs) != 1 || fooTurbine.Inputs[0].String() != "a.java" {
930 t.Errorf(`foo inputs %v != ["a.java"]`, fooTurbine.Inputs)
931 }
932
933 fooHeaderJar := filepath.Join(buildDir, ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar")
934 if !strings.Contains(barTurbine.Args["classpath"], fooHeaderJar) {
935 t.Errorf("bar turbine classpath %v does not contain %q", barTurbine.Args["classpath"], fooHeaderJar)
936 }
937 if !strings.Contains(barJavac.Args["classpath"], fooHeaderJar) {
938 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], fooHeaderJar)
939 }
940 if len(barTurbineCombined.Inputs) != 2 || barTurbineCombined.Inputs[1].String() != fooHeaderJar {
941 t.Errorf("bar turbine combineJar inputs %v does not contain %q", barTurbineCombined.Inputs, fooHeaderJar)
942 }
Anton Hanssonf66efeb2018-04-11 13:57:30 +0100943 if !strings.Contains(bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar") {
Nan Zhang61eaedb2017-11-02 13:28:15 -0700944 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
Anton Hanssonf66efeb2018-04-11 13:57:30 +0100945 "prebuilts/sdk/14/public/android.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -0700946 }
947}
948
949func TestSharding(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700950 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -0700951 java_library {
952 name: "bar",
953 srcs: ["a.java","b.java","c.java"],
954 javac_shard_size: 1
955 }
956 `)
957
958 barHeaderJar := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
959 for i := 0; i < 3; i++ {
960 barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i))
961 if !strings.Contains(barJavac.Args["classpath"], barHeaderJar) {
962 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], barHeaderJar)
963 }
964 }
965}
966
Nan Zhang581fd212018-01-10 16:06:12 -0800967func TestDroiddoc(t *testing.T) {
Colin Crossf5f663b2020-06-07 16:58:18 -0700968 ctx, _ := testJavaWithFS(t, `
Paul Duffin884363e2019-12-19 10:21:09 +0000969 droiddoc_exported_dir {
Dan Willemsencc090972018-02-26 14:33:31 -0800970 name: "droiddoc-templates-sdk",
971 path: ".",
972 }
Jiyong Park29074592019-07-07 16:27:47 +0900973 filegroup {
974 name: "bar-doc-aidl-srcs",
975 srcs: ["bar-doc/IBar.aidl"],
976 path: "bar-doc",
977 }
Nan Zhang581fd212018-01-10 16:06:12 -0800978 droiddoc {
979 name: "bar-doc",
980 srcs: [
Colin Crossf5f663b2020-06-07 16:58:18 -0700981 "bar-doc/a.java",
Jiyong Park1e440682018-05-23 18:42:04 +0900982 "bar-doc/IFoo.aidl",
Jiyong Park29074592019-07-07 16:27:47 +0900983 ":bar-doc-aidl-srcs",
Nan Zhang581fd212018-01-10 16:06:12 -0800984 ],
985 exclude_srcs: [
986 "bar-doc/b.java"
987 ],
Dan Willemsencc090972018-02-26 14:33:31 -0800988 custom_template: "droiddoc-templates-sdk",
Nan Zhang581fd212018-01-10 16:06:12 -0800989 hdf: [
990 "android.whichdoc offline",
991 ],
992 knowntags: [
993 "bar-doc/known_oj_tags.txt",
994 ],
995 proofread_file: "libcore-proofread.txt",
996 todo_file: "libcore-docs-todo.html",
997 args: "-offlinemode -title \"libcore\"",
998 }
Colin Crossf5f663b2020-06-07 16:58:18 -0700999 `,
1000 map[string][]byte{
1001 "bar-doc/a.java": nil,
1002 "bar-doc/b.java": nil,
1003 })
Nan Zhang581fd212018-01-10 16:06:12 -08001004
Colin Crossc0806172019-06-14 18:51:47 -07001005 barDoc := ctx.ModuleForTests("bar-doc", "android_common").Rule("javadoc")
Jiyong Park1e440682018-05-23 18:42:04 +09001006 var javaSrcs []string
Colin Crossc0806172019-06-14 18:51:47 -07001007 for _, i := range barDoc.Inputs {
Jiyong Park1e440682018-05-23 18:42:04 +09001008 javaSrcs = append(javaSrcs, i.Base())
1009 }
Colin Crossc0806172019-06-14 18:51:47 -07001010 if len(javaSrcs) != 1 || javaSrcs[0] != "a.java" {
1011 t.Errorf("inputs of bar-doc must be []string{\"a.java\"}, but was %#v.", javaSrcs)
Jiyong Park29074592019-07-07 16:27:47 +09001012 }
1013
Colin Crossc0806172019-06-14 18:51:47 -07001014 aidl := ctx.ModuleForTests("bar-doc", "android_common").Rule("aidl")
1015 if g, w := barDoc.Implicits.Strings(), aidl.Output.String(); !inList(w, g) {
1016 t.Errorf("implicits of bar-doc must contain %q, but was %q.", w, g)
1017 }
1018
1019 if g, w := aidl.Implicits.Strings(), []string{"bar-doc/IBar.aidl", "bar-doc/IFoo.aidl"}; !reflect.DeepEqual(w, g) {
1020 t.Errorf("aidl inputs must be %q, but was %q", w, g)
Jiyong Park1e440682018-05-23 18:42:04 +09001021 }
Nan Zhang581fd212018-01-10 16:06:12 -08001022}
1023
Liz Kammer9ba460f2020-08-04 09:55:13 -07001024func TestDroidstubs(t *testing.T) {
1025 ctx, _ := testJavaWithFS(t, `
1026 droiddoc_exported_dir {
1027 name: "droiddoc-templates-sdk",
1028 path: ".",
1029 }
1030
1031 droidstubs {
1032 name: "bar-stubs",
1033 srcs: [
1034 "bar-doc/a.java",
1035 ],
1036 api_levels_annotations_dirs: [
1037 "droiddoc-templates-sdk",
1038 ],
1039 api_levels_annotations_enabled: true,
1040 }
1041
1042 droidstubs {
1043 name: "bar-stubs-other",
1044 srcs: [
1045 "bar-doc/a.java",
1046 ],
1047 api_levels_annotations_dirs: [
1048 "droiddoc-templates-sdk",
1049 ],
1050 api_levels_annotations_enabled: true,
1051 api_levels_jar_filename: "android.other.jar",
1052 }
1053 `,
1054 map[string][]byte{
1055 "bar-doc/a.java": nil,
1056 })
1057 testcases := []struct {
1058 moduleName string
1059 expectedJarFilename string
1060 }{
1061 {
1062 moduleName: "bar-stubs",
1063 expectedJarFilename: "android.jar",
1064 },
1065 {
1066 moduleName: "bar-stubs-other",
1067 expectedJarFilename: "android.other.jar",
1068 },
1069 }
1070 for _, c := range testcases {
1071 m := ctx.ModuleForTests(c.moduleName, "android_common")
1072 metalava := m.Rule("metalava")
1073 expected := "--android-jar-pattern ./%/public/" + c.expectedJarFilename
1074 if actual := metalava.RuleParams.Command; !strings.Contains(actual, expected) {
1075 t.Errorf("For %q, expected metalava argument %q, but was not found %q", c.moduleName, expected, actual)
1076 }
1077 }
1078}
1079
Paul Duffin83a2d962019-11-19 19:44:10 +00001080func TestDroidstubsWithSystemModules(t *testing.T) {
1081 ctx, _ := testJava(t, `
1082 droidstubs {
1083 name: "stubs-source-system-modules",
1084 srcs: [
Colin Crossf5f663b2020-06-07 16:58:18 -07001085 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001086 ],
1087 sdk_version: "none",
1088 system_modules: "source-system-modules",
1089 }
1090
1091 java_library {
1092 name: "source-jar",
1093 srcs: [
1094 "a.java",
1095 ],
1096 }
1097
1098 java_system_modules {
1099 name: "source-system-modules",
1100 libs: ["source-jar"],
1101 }
1102
1103 droidstubs {
1104 name: "stubs-prebuilt-system-modules",
1105 srcs: [
Colin Crossf5f663b2020-06-07 16:58:18 -07001106 "bar-doc/a.java",
Paul Duffin83a2d962019-11-19 19:44:10 +00001107 ],
1108 sdk_version: "none",
1109 system_modules: "prebuilt-system-modules",
1110 }
1111
1112 java_import {
1113 name: "prebuilt-jar",
1114 jars: ["a.jar"],
1115 }
1116
1117 java_system_modules_import {
1118 name: "prebuilt-system-modules",
1119 libs: ["prebuilt-jar"],
1120 }
1121 `)
1122
1123 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-source-system-modules", "source-jar.jar")
1124
1125 checkSystemModulesUseByDroidstubs(t, ctx, "stubs-prebuilt-system-modules", "prebuilt-jar.jar")
1126}
1127
1128func checkSystemModulesUseByDroidstubs(t *testing.T, ctx *android.TestContext, moduleName string, systemJar string) {
1129 metalavaRule := ctx.ModuleForTests(moduleName, "android_common").Rule("metalava")
1130 var systemJars []string
1131 for _, i := range metalavaRule.Implicits {
1132 systemJars = append(systemJars, i.Base())
1133 }
Ramy Medhat8e9b63b2020-04-30 03:08:37 -04001134 if len(systemJars) < 1 || systemJars[0] != systemJar {
Paul Duffin83a2d962019-11-19 19:44:10 +00001135 t.Errorf("inputs of %q must be []string{%q}, but was %#v.", moduleName, systemJar, systemJars)
1136 }
1137}
1138
Colin Cross54250902017-12-05 09:28:08 -08001139func TestJarGenrules(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001140 ctx, _ := testJava(t, `
Colin Cross54250902017-12-05 09:28:08 -08001141 java_library {
1142 name: "foo",
1143 srcs: ["a.java"],
1144 }
1145
1146 java_genrule {
1147 name: "jargen",
1148 tool_files: ["b.java"],
1149 cmd: "$(location b.java) $(in) $(out)",
1150 out: ["jargen.jar"],
1151 srcs: [":foo"],
1152 }
1153
1154 java_library {
1155 name: "bar",
1156 static_libs: ["jargen"],
1157 srcs: ["c.java"],
1158 }
1159
1160 java_library {
1161 name: "baz",
1162 libs: ["jargen"],
1163 srcs: ["c.java"],
1164 }
1165 `)
1166
1167 foo := ctx.ModuleForTests("foo", "android_common").Output("javac/foo.jar")
1168 jargen := ctx.ModuleForTests("jargen", "android_common").Output("jargen.jar")
1169 bar := ctx.ModuleForTests("bar", "android_common").Output("javac/bar.jar")
1170 baz := ctx.ModuleForTests("baz", "android_common").Output("javac/baz.jar")
1171 barCombined := ctx.ModuleForTests("bar", "android_common").Output("combined/bar.jar")
1172
1173 if len(jargen.Inputs) != 1 || jargen.Inputs[0].String() != foo.Output.String() {
1174 t.Errorf("expected jargen inputs [%q], got %q", foo.Output.String(), jargen.Inputs.Strings())
1175 }
1176
1177 if !strings.Contains(bar.Args["classpath"], jargen.Output.String()) {
1178 t.Errorf("bar classpath %v does not contain %q", bar.Args["classpath"], jargen.Output.String())
1179 }
1180
1181 if !strings.Contains(baz.Args["classpath"], jargen.Output.String()) {
1182 t.Errorf("baz classpath %v does not contain %q", baz.Args["classpath"], jargen.Output.String())
1183 }
1184
1185 if len(barCombined.Inputs) != 2 ||
1186 barCombined.Inputs[0].String() != bar.Output.String() ||
1187 barCombined.Inputs[1].String() != jargen.Output.String() {
1188 t.Errorf("bar combined jar inputs %v is not [%q, %q]",
1189 barCombined.Inputs.Strings(), bar.Output.String(), jargen.Output.String())
1190 }
1191}
1192
Nan Zhang27e284d2018-02-09 21:03:53 +00001193func TestExcludeFileGroupInSrcs(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001194 ctx, _ := testJava(t, `
Nan Zhang27e284d2018-02-09 21:03:53 +00001195 java_library {
1196 name: "foo",
1197 srcs: ["a.java", ":foo-srcs"],
1198 exclude_srcs: ["a.java", ":foo-excludes"],
1199 }
1200
1201 filegroup {
1202 name: "foo-srcs",
1203 srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"],
1204 }
1205
1206 filegroup {
1207 name: "foo-excludes",
1208 srcs: ["java-fg/a.java", "java-fg/b.java"],
1209 }
1210 `)
1211
1212 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1213
1214 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" {
1215 t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs)
1216 }
1217}
Jiyong Parkc678ad32018-04-10 13:07:10 +09001218
Paul Duffin52d398a2019-06-11 12:31:14 +01001219func TestJavaLibrary(t *testing.T) {
Colin Cross98be1bb2019-12-13 20:41:13 -08001220 config := testConfig(nil, "", map[string][]byte{
Paul Duffin52d398a2019-06-11 12:31:14 +01001221 "libcore/Android.bp": []byte(`
1222 java_library {
1223 name: "core",
1224 sdk_version: "none",
1225 system_modules: "none",
1226 }`),
1227 })
Colin Cross98be1bb2019-12-13 20:41:13 -08001228 ctx := testContext()
Paul Duffin52d398a2019-06-11 12:31:14 +01001229 run(t, ctx, config)
1230}
1231
Jiyong Parkc678ad32018-04-10 13:07:10 +09001232func TestJavaSdkLibrary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001233 ctx, _ := testJava(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001234 droiddoc_exported_dir {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001235 name: "droiddoc-templates-sdk",
1236 path: ".",
1237 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001238 java_sdk_library {
1239 name: "foo",
1240 srcs: ["a.java", "b.java"],
1241 api_packages: ["foo"],
1242 }
1243 java_sdk_library {
1244 name: "bar",
1245 srcs: ["a.java", "b.java"],
1246 api_packages: ["bar"],
1247 }
1248 java_library {
1249 name: "baz",
1250 srcs: ["c.java"],
Paul Duffin64e61992020-05-15 10:20:31 +01001251 libs: ["foo", "bar.stubs"],
Jiyong Parkc678ad32018-04-10 13:07:10 +09001252 sdk_version: "system_current",
1253 }
Paul Duffind11e78e2020-05-15 20:37:11 +01001254 java_sdk_library {
1255 name: "barney",
1256 srcs: ["c.java"],
1257 api_only: true,
1258 }
1259 java_sdk_library {
1260 name: "betty",
1261 srcs: ["c.java"],
1262 shared_library: false,
1263 }
Paul Duffin64e61992020-05-15 10:20:31 +01001264 java_sdk_library_import {
1265 name: "quuz",
1266 public: {
1267 jars: ["c.jar"],
1268 },
1269 }
1270 java_sdk_library_import {
1271 name: "fred",
1272 public: {
1273 jars: ["b.jar"],
1274 },
1275 }
Paul Duffind11e78e2020-05-15 20:37:11 +01001276 java_sdk_library_import {
1277 name: "wilma",
1278 public: {
1279 jars: ["b.jar"],
1280 },
1281 shared_library: false,
1282 }
Jiyong Park1be96912018-05-28 18:02:19 +09001283 java_library {
1284 name: "qux",
1285 srcs: ["c.java"],
Paul Duffind11e78e2020-05-15 20:37:11 +01001286 libs: ["baz", "fred", "quuz.stubs", "wilma", "barney", "betty"],
Jiyong Park1be96912018-05-28 18:02:19 +09001287 sdk_version: "system_current",
1288 }
Paul Duffin726d23c2020-01-22 16:30:37 +00001289 java_library {
1290 name: "baz-test",
1291 srcs: ["c.java"],
1292 libs: ["foo"],
1293 sdk_version: "test_current",
1294 }
Paul Duffina2db18f2020-01-22 17:11:15 +00001295 java_library {
1296 name: "baz-29",
1297 srcs: ["c.java"],
1298 libs: ["foo"],
1299 sdk_version: "system_29",
1300 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001301 `)
1302
1303 // check the existence of the internal modules
1304 ctx.ModuleForTests("foo", "android_common")
Paul Duffin1c094a02020-05-08 15:52:37 +01001305 ctx.ModuleForTests(apiScopePublic.stubsLibraryModuleName("foo"), "android_common")
1306 ctx.ModuleForTests(apiScopeSystem.stubsLibraryModuleName("foo"), "android_common")
1307 ctx.ModuleForTests(apiScopeTest.stubsLibraryModuleName("foo"), "android_common")
1308 ctx.ModuleForTests(apiScopePublic.stubsSourceModuleName("foo"), "android_common")
1309 ctx.ModuleForTests(apiScopeSystem.stubsSourceModuleName("foo"), "android_common")
1310 ctx.ModuleForTests(apiScopeTest.stubsSourceModuleName("foo"), "android_common")
Jiyong Parke3833882020-02-17 17:28:10 +09001311 ctx.ModuleForTests("foo"+sdkXmlFileSuffix, "android_common")
Jiyong Park58c518b2018-05-12 22:29:12 +09001312 ctx.ModuleForTests("foo.api.public.28", "")
1313 ctx.ModuleForTests("foo.api.system.28", "")
1314 ctx.ModuleForTests("foo.api.test.28", "")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001315
1316 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1317 // tests if baz is actually linked to the stubs lib
1318 if !strings.Contains(bazJavac.Args["classpath"], "foo.stubs.system.jar") {
1319 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
1320 "foo.stubs.system.jar")
1321 }
1322 // ... and not to the impl lib
Sundong Ahn054b19a2018-10-19 13:46:09 +09001323 if strings.Contains(bazJavac.Args["classpath"], "foo.jar") {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001324 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
Sundong Ahn054b19a2018-10-19 13:46:09 +09001325 "foo.jar")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001326 }
1327 // test if baz is not linked to the system variant of foo
1328 if strings.Contains(bazJavac.Args["classpath"], "foo.stubs.jar") {
1329 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
1330 "foo.stubs.jar")
1331 }
Jiyong Park1be96912018-05-28 18:02:19 +09001332
Paul Duffin726d23c2020-01-22 16:30:37 +00001333 bazTestJavac := ctx.ModuleForTests("baz-test", "android_common").Rule("javac")
1334 // tests if baz-test is actually linked to the test stubs lib
1335 if !strings.Contains(bazTestJavac.Args["classpath"], "foo.stubs.test.jar") {
1336 t.Errorf("baz-test javac classpath %v does not contain %q", bazTestJavac.Args["classpath"],
1337 "foo.stubs.test.jar")
1338 }
1339
Paul Duffina2db18f2020-01-22 17:11:15 +00001340 baz29Javac := ctx.ModuleForTests("baz-29", "android_common").Rule("javac")
1341 // tests if baz-29 is actually linked to the system 29 stubs lib
1342 if !strings.Contains(baz29Javac.Args["classpath"], "prebuilts/sdk/29/system/foo.jar") {
1343 t.Errorf("baz-29 javac classpath %v does not contain %q", baz29Javac.Args["classpath"],
1344 "prebuilts/sdk/29/system/foo.jar")
1345 }
1346
Jiyong Park1be96912018-05-28 18:02:19 +09001347 // test if baz has exported SDK lib names foo and bar to qux
1348 qux := ctx.ModuleForTests("qux", "android_common")
1349 if quxLib, ok := qux.Module().(*Library); ok {
1350 sdkLibs := quxLib.ExportedSdkLibs()
Paul Duffin64e61992020-05-15 10:20:31 +01001351 sort.Strings(sdkLibs)
1352 if w := []string{"bar", "foo", "fred", "quuz"}; !reflect.DeepEqual(w, sdkLibs) {
1353 t.Errorf("qux should export %q but exports %q", w, sdkLibs)
Jiyong Park1be96912018-05-28 18:02:19 +09001354 }
1355 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001356}
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001357
Paul Duffin2e7ed652020-05-26 18:13:57 +01001358func TestJavaSdkLibrary_DoNotAccessImplWhenItIsNotBuilt(t *testing.T) {
1359 ctx, _ := testJava(t, `
1360 java_sdk_library {
1361 name: "foo",
1362 srcs: ["a.java"],
1363 api_only: true,
1364 public: {
1365 enabled: true,
1366 },
1367 }
1368
1369 java_library {
1370 name: "bar",
1371 srcs: ["b.java"],
1372 libs: ["foo"],
1373 }
1374 `)
1375
1376 // The bar library should depend on the stubs jar.
1377 barLibrary := ctx.ModuleForTests("bar", "android_common").Rule("javac")
1378 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs\.jar$`, barLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
1379 t.Errorf("expected %q, found %#q", expected, actual)
1380 }
1381}
1382
Paul Duffin46fdda82020-05-14 15:39:10 +01001383func TestJavaSdkLibrary_UseSourcesFromAnotherSdkLibrary(t *testing.T) {
1384 testJava(t, `
1385 java_sdk_library {
1386 name: "foo",
1387 srcs: ["a.java"],
1388 api_packages: ["foo"],
1389 public: {
1390 enabled: true,
1391 },
1392 }
1393
1394 java_library {
1395 name: "bar",
1396 srcs: ["b.java", ":foo{.public.stubs.source}"],
1397 }
1398 `)
1399}
1400
1401func TestJavaSdkLibrary_AccessOutputFiles_MissingScope(t *testing.T) {
1402 testJavaError(t, `"foo" does not provide api scope system`, `
1403 java_sdk_library {
1404 name: "foo",
1405 srcs: ["a.java"],
1406 api_packages: ["foo"],
1407 public: {
1408 enabled: true,
1409 },
1410 }
1411
1412 java_library {
1413 name: "bar",
1414 srcs: ["b.java", ":foo{.system.stubs.source}"],
1415 }
1416 `)
1417}
1418
1419func TestJavaSdkLibraryImport_AccessOutputFiles(t *testing.T) {
1420 testJava(t, `
1421 java_sdk_library_import {
1422 name: "foo",
1423 public: {
1424 jars: ["a.jar"],
1425 stub_srcs: ["a.java"],
1426 current_api: "api/current.txt",
1427 removed_api: "api/removed.txt",
1428 },
1429 }
1430
1431 java_library {
1432 name: "bar",
1433 srcs: [":foo{.public.stubs.source}"],
1434 java_resources: [
1435 ":foo{.public.api.txt}",
1436 ":foo{.public.removed-api.txt}",
1437 ],
1438 }
1439 `)
1440}
1441
1442func TestJavaSdkLibraryImport_AccessOutputFiles_Invalid(t *testing.T) {
1443 bp := `
1444 java_sdk_library_import {
1445 name: "foo",
1446 public: {
1447 jars: ["a.jar"],
1448 },
1449 }
1450 `
1451
1452 t.Run("stubs.source", func(t *testing.T) {
1453 testJavaError(t, `stubs.source not available for api scope public`, bp+`
1454 java_library {
1455 name: "bar",
1456 srcs: [":foo{.public.stubs.source}"],
1457 java_resources: [
1458 ":foo{.public.api.txt}",
1459 ":foo{.public.removed-api.txt}",
1460 ],
1461 }
1462 `)
1463 })
1464
1465 t.Run("api.txt", func(t *testing.T) {
1466 testJavaError(t, `api.txt not available for api scope public`, bp+`
1467 java_library {
1468 name: "bar",
1469 srcs: ["a.java"],
1470 java_resources: [
1471 ":foo{.public.api.txt}",
1472 ],
1473 }
1474 `)
1475 })
1476
1477 t.Run("removed-api.txt", func(t *testing.T) {
1478 testJavaError(t, `removed-api.txt not available for api scope public`, bp+`
1479 java_library {
1480 name: "bar",
1481 srcs: ["a.java"],
1482 java_resources: [
1483 ":foo{.public.removed-api.txt}",
1484 ],
1485 }
1486 `)
1487 })
1488}
1489
Paul Duffin3a254982020-04-28 10:44:03 +01001490func TestJavaSdkLibrary_InvalidScopes(t *testing.T) {
1491 testJavaError(t, `module "foo": enabled api scope "system" depends on disabled scope "public"`, `
1492 java_sdk_library {
1493 name: "foo",
1494 srcs: ["a.java", "b.java"],
1495 api_packages: ["foo"],
1496 // Explicitly disable public to test the check that ensures the set of enabled
1497 // scopes is consistent.
1498 public: {
1499 enabled: false,
1500 },
1501 system: {
1502 enabled: true,
1503 },
1504 }
1505 `)
1506}
1507
Paul Duffin080f5ee2020-05-12 11:50:28 +01001508func TestJavaSdkLibrary_SdkVersion_ForScope(t *testing.T) {
1509 testJava(t, `
1510 java_sdk_library {
1511 name: "foo",
1512 srcs: ["a.java", "b.java"],
1513 api_packages: ["foo"],
1514 system: {
1515 enabled: true,
1516 sdk_version: "module_current",
1517 },
1518 }
1519 `)
1520}
1521
Paul Duffin5a757b12020-06-02 13:00:08 +01001522func TestJavaSdkLibrary_ModuleLib(t *testing.T) {
1523 testJava(t, `
1524 java_sdk_library {
1525 name: "foo",
1526 srcs: ["a.java", "b.java"],
1527 api_packages: ["foo"],
1528 system: {
1529 enabled: true,
1530 },
1531 module_lib: {
1532 enabled: true,
1533 },
1534 }
1535 `)
1536}
1537
1538func TestJavaSdkLibrary_SystemServer(t *testing.T) {
1539 testJava(t, `
1540 java_sdk_library {
1541 name: "foo",
1542 srcs: ["a.java", "b.java"],
1543 api_packages: ["foo"],
1544 system: {
1545 enabled: true,
1546 },
1547 system_server: {
1548 enabled: true,
1549 },
1550 }
1551 `)
1552}
1553
Paul Duffin5ae30792020-05-20 11:52:25 +01001554func TestJavaSdkLibrary_MissingScope(t *testing.T) {
1555 testJavaError(t, `requires api scope module-lib from foo but it only has \[\] available`, `
1556 java_sdk_library {
1557 name: "foo",
1558 srcs: ["a.java"],
1559 public: {
1560 enabled: false,
1561 },
1562 }
1563
1564 java_library {
1565 name: "baz",
1566 srcs: ["a.java"],
1567 libs: ["foo"],
1568 sdk_version: "module_current",
1569 }
1570 `)
1571}
1572
1573func TestJavaSdkLibrary_FallbackScope(t *testing.T) {
1574 testJava(t, `
1575 java_sdk_library {
1576 name: "foo",
1577 srcs: ["a.java"],
1578 system: {
1579 enabled: true,
1580 },
1581 }
1582
1583 java_library {
1584 name: "baz",
1585 srcs: ["a.java"],
1586 libs: ["foo"],
1587 // foo does not have module-lib scope so it should fallback to system
1588 sdk_version: "module_current",
1589 }
1590 `)
1591}
1592
Jiyong Park27fc4142020-05-28 00:19:53 +09001593func TestJavaSdkLibrary_DefaultToStubs(t *testing.T) {
1594 ctx, _ := testJava(t, `
1595 java_sdk_library {
1596 name: "foo",
1597 srcs: ["a.java"],
1598 system: {
1599 enabled: true,
1600 },
1601 default_to_stubs: true,
1602 }
1603
1604 java_library {
1605 name: "baz",
1606 srcs: ["a.java"],
1607 libs: ["foo"],
1608 // does not have sdk_version set, should fallback to module,
1609 // which will then fallback to system because the module scope
1610 // is not enabled.
1611 }
1612 `)
1613 // The baz library should depend on the system stubs jar.
1614 bazLibrary := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1615 if expected, actual := `^-classpath .*:/[^:]*/turbine-combined/foo\.stubs.system\.jar$`, bazLibrary.Args["classpath"]; !regexp.MustCompile(expected).MatchString(actual) {
1616 t.Errorf("expected %q, found %#q", expected, actual)
1617 }
1618}
1619
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001620var compilerFlagsTestCases = []struct {
1621 in string
1622 out bool
1623}{
1624 {
1625 in: "a",
1626 out: false,
1627 },
1628 {
1629 in: "-a",
1630 out: true,
1631 },
1632 {
1633 in: "-no-jdk",
1634 out: false,
1635 },
1636 {
1637 in: "-no-stdlib",
1638 out: false,
1639 },
1640 {
1641 in: "-kotlin-home",
1642 out: false,
1643 },
1644 {
1645 in: "-kotlin-home /some/path",
1646 out: false,
1647 },
1648 {
1649 in: "-include-runtime",
1650 out: false,
1651 },
1652 {
1653 in: "-Xintellij-plugin-root",
1654 out: false,
1655 },
1656}
1657
1658type mockContext struct {
1659 android.ModuleContext
1660 result bool
1661}
1662
1663func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) {
1664 // CheckBadCompilerFlags calls this function when the flag should be rejected
1665 ctx.result = false
1666}
1667
1668func TestCompilerFlags(t *testing.T) {
1669 for _, testCase := range compilerFlagsTestCases {
1670 ctx := &mockContext{result: true}
1671 CheckKotlincFlags(ctx, []string{testCase.in})
1672 if ctx.result != testCase.out {
1673 t.Errorf("incorrect output:")
1674 t.Errorf(" input: %#v", testCase.in)
1675 t.Errorf(" expected: %#v", testCase.out)
1676 t.Errorf(" got: %#v", ctx.result)
1677 }
1678 }
1679}
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001680
1681// TODO(jungjw): Consider making this more robust by ignoring path order.
1682func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) {
1683 variables := ctx.ModuleForTests(moduleName, "android_common").Module().VariablesForTests()
1684 flags := strings.Split(variables["javacFlags"], " ")
1685 got := ""
1686 for _, flag := range flags {
1687 keyEnd := strings.Index(flag, "=")
1688 if keyEnd > -1 && flag[:keyEnd] == "--patch-module" {
1689 got = flag[keyEnd+1:]
1690 break
1691 }
1692 }
1693 if expected != got {
1694 t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got)
1695 }
1696}
1697
1698func TestPatchModule(t *testing.T) {
Pete Gillin0c2143e2019-05-02 15:32:11 +01001699 t.Run("Java language level 8", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01001700 // Test with legacy javac -source 1.8 -target 1.8
Pete Gillinbdf5d712019-10-21 14:29:58 +01001701 bp := `
1702 java_library {
1703 name: "foo",
1704 srcs: ["a.java"],
1705 java_version: "1.8",
1706 }
1707
1708 java_library {
1709 name: "bar",
1710 srcs: ["b.java"],
1711 sdk_version: "none",
1712 system_modules: "none",
1713 patch_module: "java.base",
1714 java_version: "1.8",
1715 }
1716
1717 java_library {
1718 name: "baz",
1719 srcs: ["c.java"],
1720 patch_module: "java.base",
1721 java_version: "1.8",
1722 }
1723 `
1724 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001725
1726 checkPatchModuleFlag(t, ctx, "foo", "")
1727 checkPatchModuleFlag(t, ctx, "bar", "")
1728 checkPatchModuleFlag(t, ctx, "baz", "")
1729 })
1730
Pete Gillin0c2143e2019-05-02 15:32:11 +01001731 t.Run("Java language level 9", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01001732 // Test with default javac -source 9 -target 9
Pete Gillinbdf5d712019-10-21 14:29:58 +01001733 bp := `
1734 java_library {
1735 name: "foo",
1736 srcs: ["a.java"],
1737 }
1738
1739 java_library {
1740 name: "bar",
1741 srcs: ["b.java"],
1742 sdk_version: "none",
1743 system_modules: "none",
1744 patch_module: "java.base",
1745 }
1746
1747 java_library {
1748 name: "baz",
1749 srcs: ["c.java"],
1750 patch_module: "java.base",
1751 }
1752 `
Pete Gillin1b3370f2019-10-01 13:57:31 +01001753 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001754
1755 checkPatchModuleFlag(t, ctx, "foo", "")
1756 expected := "java.base=.:" + buildDir
1757 checkPatchModuleFlag(t, ctx, "bar", expected)
Jiyong Park231d0562019-12-18 17:28:17 +09001758 expected = "java.base=" + strings.Join([]string{".", buildDir, moduleToPath("ext"), moduleToPath("framework")}, ":")
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001759 checkPatchModuleFlag(t, ctx, "baz", expected)
1760 })
1761}
Paul Duffina7b9f422020-01-10 17:12:18 +00001762
1763func TestJavaSystemModules(t *testing.T) {
1764 ctx, _ := testJava(t, `
1765 java_system_modules {
1766 name: "system-modules",
1767 libs: ["system-module1", "system-module2"],
1768 }
1769 java_library {
1770 name: "system-module1",
1771 srcs: ["a.java"],
1772 sdk_version: "none",
1773 system_modules: "none",
1774 }
1775 java_library {
1776 name: "system-module2",
1777 srcs: ["b.java"],
1778 sdk_version: "none",
1779 system_modules: "none",
1780 }
1781 `)
1782
1783 // check the existence of the module
1784 systemModules := ctx.ModuleForTests("system-modules", "android_common")
1785
1786 cmd := systemModules.Rule("jarsTosystemModules")
1787
1788 // make sure the command compiles against the supplied modules.
1789 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
1790 if !strings.Contains(cmd.Args["classpath"], module) {
1791 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
1792 module)
1793 }
1794 }
1795}
Paul Duffin90169ba2020-01-10 17:16:44 +00001796
1797func TestJavaSystemModulesImport(t *testing.T) {
1798 ctx, _ := testJava(t, `
1799 java_system_modules_import {
1800 name: "system-modules",
1801 libs: ["system-module1", "system-module2"],
1802 }
1803 java_import {
1804 name: "system-module1",
1805 jars: ["a.jar"],
1806 }
1807 java_import {
1808 name: "system-module2",
1809 jars: ["b.jar"],
1810 }
1811 `)
1812
1813 // check the existence of the module
1814 systemModules := ctx.ModuleForTests("system-modules", "android_common")
1815
1816 cmd := systemModules.Rule("jarsTosystemModules")
1817
1818 // make sure the command compiles against the supplied modules.
1819 for _, module := range []string{"system-module1.jar", "system-module2.jar"} {
1820 if !strings.Contains(cmd.Args["classpath"], module) {
1821 t.Errorf("system modules classpath %v does not contain %q", cmd.Args["classpath"],
1822 module)
1823 }
1824 }
1825}
Paul Duffin83a2d962019-11-19 19:44:10 +00001826
1827func TestJavaLibraryWithSystemModules(t *testing.T) {
1828 ctx, _ := testJava(t, `
1829 java_library {
1830 name: "lib-with-source-system-modules",
1831 srcs: [
1832 "a.java",
1833 ],
1834 sdk_version: "none",
1835 system_modules: "source-system-modules",
1836 }
1837
1838 java_library {
1839 name: "source-jar",
1840 srcs: [
1841 "a.java",
1842 ],
1843 }
1844
1845 java_system_modules {
1846 name: "source-system-modules",
1847 libs: ["source-jar"],
1848 }
1849
1850 java_library {
1851 name: "lib-with-prebuilt-system-modules",
1852 srcs: [
1853 "a.java",
1854 ],
1855 sdk_version: "none",
1856 system_modules: "prebuilt-system-modules",
1857 }
1858
1859 java_import {
1860 name: "prebuilt-jar",
1861 jars: ["a.jar"],
1862 }
1863
1864 java_system_modules_import {
1865 name: "prebuilt-system-modules",
1866 libs: ["prebuilt-jar"],
1867 }
1868 `)
1869
1870 checkBootClasspathForSystemModule(t, ctx, "lib-with-source-system-modules", "/source-jar.jar")
1871
1872 checkBootClasspathForSystemModule(t, ctx, "lib-with-prebuilt-system-modules", "/prebuilt-jar.jar")
1873}
1874
1875func checkBootClasspathForSystemModule(t *testing.T, ctx *android.TestContext, moduleName string, expectedSuffix string) {
1876 javacRule := ctx.ModuleForTests(moduleName, "android_common").Rule("javac")
1877 bootClasspath := javacRule.Args["bootClasspath"]
1878 if strings.HasPrefix(bootClasspath, "--system ") && strings.HasSuffix(bootClasspath, expectedSuffix) {
1879 t.Errorf("bootclasspath of %q must start with --system and end with %q, but was %#v.", moduleName, expectedSuffix, bootClasspath)
1880 }
1881}