Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 1 | // Copyright (C) 2024 The Android Open Source Project |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
| 15 | package fsgen |
| 16 | |
| 17 | import ( |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 18 | "crypto/sha256" |
Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 19 | "fmt" |
Spandan Das | 312cc41 | 2024-10-29 18:20:11 +0000 | [diff] [blame] | 20 | "path/filepath" |
Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 21 | "strconv" |
mrziwang | 8f86c88 | 2024-10-03 12:34:33 -0700 | [diff] [blame] | 22 | "strings" |
mrziwang | 8f86c88 | 2024-10-03 12:34:33 -0700 | [diff] [blame] | 23 | |
| 24 | "android/soong/android" |
| 25 | "android/soong/filesystem" |
Spandan Das | 5e33642 | 2024-11-01 22:31:20 +0000 | [diff] [blame] | 26 | "android/soong/kernel" |
Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 27 | |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 28 | "github.com/google/blueprint" |
mrziwang | 8f86c88 | 2024-10-03 12:34:33 -0700 | [diff] [blame] | 29 | "github.com/google/blueprint/parser" |
Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 30 | "github.com/google/blueprint/proptools" |
| 31 | ) |
| 32 | |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 33 | var pctx = android.NewPackageContext("android/soong/fsgen") |
| 34 | |
Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 35 | func init() { |
| 36 | registerBuildComponents(android.InitRegistrationContext) |
| 37 | } |
| 38 | |
| 39 | func registerBuildComponents(ctx android.RegistrationContext) { |
| 40 | ctx.RegisterModuleType("soong_filesystem_creator", filesystemCreatorFactory) |
mrziwang | 8f86c88 | 2024-10-03 12:34:33 -0700 | [diff] [blame] | 41 | ctx.PreDepsMutators(RegisterCollectFileSystemDepsMutators) |
| 42 | } |
| 43 | |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 44 | type filesystemCreatorProps struct { |
| 45 | Generated_partition_types []string `blueprint:"mutated"` |
| 46 | Unsupported_partition_types []string `blueprint:"mutated"` |
Cole Faust | 3552eb6 | 2024-11-06 18:07:26 -0800 | [diff] [blame] | 47 | |
| 48 | Vbmeta_module_names []string `blueprint:"mutated"` |
| 49 | Vbmeta_partition_names []string `blueprint:"mutated"` |
Cole Faust | f2a6e8b | 2024-11-14 10:54:48 -0800 | [diff] [blame] | 50 | |
Cole Faust | 24938e2 | 2024-11-18 14:01:58 -0800 | [diff] [blame] | 51 | Boot_image string `blueprint:"mutated" android:"path_device_first"` |
| 52 | Vendor_boot_image string `blueprint:"mutated" android:"path_device_first"` |
Jihoon Kang | 95eb1da | 2024-11-19 20:55:20 +0000 | [diff] [blame] | 53 | Init_boot_image string `blueprint:"mutated" android:"path_device_first"` |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 54 | } |
| 55 | |
Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 56 | type filesystemCreator struct { |
| 57 | android.ModuleBase |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 58 | |
| 59 | properties filesystemCreatorProps |
Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 60 | } |
| 61 | |
| 62 | func filesystemCreatorFactory() android.Module { |
| 63 | module := &filesystemCreator{} |
| 64 | |
Cole Faust | 6978879 | 2024-10-10 11:00:36 -0700 | [diff] [blame] | 65 | android.InitAndroidArchModule(module, android.DeviceSupported, android.MultilibCommon) |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 66 | module.AddProperties(&module.properties) |
Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 67 | android.AddLoadHook(module, func(ctx android.LoadHookContext) { |
Jihoon Kang | 675d468 | 2024-10-24 23:45:11 +0000 | [diff] [blame] | 68 | generatedPrebuiltEtcModuleNames := createPrebuiltEtcModules(ctx) |
Jihoon Kang | 04f12c9 | 2024-11-12 23:03:08 +0000 | [diff] [blame] | 69 | avbpubkeyGenerated := createAvbpubkeyModule(ctx) |
| 70 | createFsGenState(ctx, generatedPrebuiltEtcModuleNames, avbpubkeyGenerated) |
Cole Faust | 953476f | 2024-11-14 14:11:29 -0800 | [diff] [blame] | 71 | module.createAvbKeyFilegroups(ctx) |
Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 72 | module.createInternalModules(ctx) |
| 73 | }) |
| 74 | |
| 75 | return module |
| 76 | } |
| 77 | |
Cole Faust | f2a6e8b | 2024-11-14 10:54:48 -0800 | [diff] [blame] | 78 | func generatedPartitions(ctx android.LoadHookContext) []string { |
Cole Faust | 24938e2 | 2024-11-18 14:01:58 -0800 | [diff] [blame] | 79 | partitionVars := ctx.Config().ProductVariables().PartitionVarsForSoongMigrationOnlyDoNotUse |
Cole Faust | f2a6e8b | 2024-11-14 10:54:48 -0800 | [diff] [blame] | 80 | generatedPartitions := []string{"system"} |
| 81 | if ctx.DeviceConfig().SystemExtPath() == "system_ext" { |
| 82 | generatedPartitions = append(generatedPartitions, "system_ext") |
| 83 | } |
| 84 | if ctx.DeviceConfig().BuildingVendorImage() && ctx.DeviceConfig().VendorPath() == "vendor" { |
| 85 | generatedPartitions = append(generatedPartitions, "vendor") |
| 86 | } |
| 87 | if ctx.DeviceConfig().BuildingProductImage() && ctx.DeviceConfig().ProductPath() == "product" { |
| 88 | generatedPartitions = append(generatedPartitions, "product") |
| 89 | } |
| 90 | if ctx.DeviceConfig().BuildingOdmImage() && ctx.DeviceConfig().OdmPath() == "odm" { |
| 91 | generatedPartitions = append(generatedPartitions, "odm") |
| 92 | } |
| 93 | if ctx.DeviceConfig().BuildingUserdataImage() && ctx.DeviceConfig().UserdataPath() == "data" { |
| 94 | generatedPartitions = append(generatedPartitions, "userdata") |
| 95 | } |
Cole Faust | 24938e2 | 2024-11-18 14:01:58 -0800 | [diff] [blame] | 96 | if partitionVars.BuildingSystemDlkmImage { |
Cole Faust | f2a6e8b | 2024-11-14 10:54:48 -0800 | [diff] [blame] | 97 | generatedPartitions = append(generatedPartitions, "system_dlkm") |
| 98 | } |
Cole Faust | 24938e2 | 2024-11-18 14:01:58 -0800 | [diff] [blame] | 99 | if partitionVars.BuildingVendorDlkmImage { |
Cole Faust | f2a6e8b | 2024-11-14 10:54:48 -0800 | [diff] [blame] | 100 | generatedPartitions = append(generatedPartitions, "vendor_dlkm") |
| 101 | } |
Cole Faust | 24938e2 | 2024-11-18 14:01:58 -0800 | [diff] [blame] | 102 | if partitionVars.BuildingOdmDlkmImage { |
Cole Faust | f2a6e8b | 2024-11-14 10:54:48 -0800 | [diff] [blame] | 103 | generatedPartitions = append(generatedPartitions, "odm_dlkm") |
| 104 | } |
Cole Faust | 24938e2 | 2024-11-18 14:01:58 -0800 | [diff] [blame] | 105 | if partitionVars.BuildingRamdiskImage { |
Cole Faust | f2a6e8b | 2024-11-14 10:54:48 -0800 | [diff] [blame] | 106 | generatedPartitions = append(generatedPartitions, "ramdisk") |
| 107 | } |
Cole Faust | 24938e2 | 2024-11-18 14:01:58 -0800 | [diff] [blame] | 108 | if buildingVendorBootImage(partitionVars) { |
| 109 | generatedPartitions = append(generatedPartitions, "vendor_ramdisk") |
| 110 | } |
Cole Faust | f2a6e8b | 2024-11-14 10:54:48 -0800 | [diff] [blame] | 111 | return generatedPartitions |
| 112 | } |
| 113 | |
Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 114 | func (f *filesystemCreator) createInternalModules(ctx android.LoadHookContext) { |
Cole Faust | 3552eb6 | 2024-11-06 18:07:26 -0800 | [diff] [blame] | 115 | soongGeneratedPartitions := generatedPartitions(ctx) |
| 116 | finalSoongGeneratedPartitions := make([]string, 0, len(soongGeneratedPartitions)) |
| 117 | for _, partitionType := range soongGeneratedPartitions { |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 118 | if f.createPartition(ctx, partitionType) { |
| 119 | f.properties.Generated_partition_types = append(f.properties.Generated_partition_types, partitionType) |
Cole Faust | 3552eb6 | 2024-11-06 18:07:26 -0800 | [diff] [blame] | 120 | finalSoongGeneratedPartitions = append(finalSoongGeneratedPartitions, partitionType) |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 121 | } else { |
| 122 | f.properties.Unsupported_partition_types = append(f.properties.Unsupported_partition_types, partitionType) |
| 123 | } |
| 124 | } |
Cole Faust | 3552eb6 | 2024-11-06 18:07:26 -0800 | [diff] [blame] | 125 | |
Cole Faust | 24938e2 | 2024-11-18 14:01:58 -0800 | [diff] [blame] | 126 | partitionVars := ctx.Config().ProductVariables().PartitionVarsForSoongMigrationOnlyDoNotUse |
Jihoon Kang | 70c1c68 | 2024-11-20 23:58:38 +0000 | [diff] [blame^] | 127 | dtbImg := createDtbImgFilegroup(ctx) |
| 128 | |
Cole Faust | 24938e2 | 2024-11-18 14:01:58 -0800 | [diff] [blame] | 129 | if buildingBootImage(partitionVars) { |
Jihoon Kang | 70c1c68 | 2024-11-20 23:58:38 +0000 | [diff] [blame^] | 130 | if createBootImage(ctx, dtbImg) { |
Cole Faust | f2a6e8b | 2024-11-14 10:54:48 -0800 | [diff] [blame] | 131 | f.properties.Boot_image = ":" + generatedModuleNameForPartition(ctx.Config(), "boot") |
| 132 | } else { |
| 133 | f.properties.Unsupported_partition_types = append(f.properties.Unsupported_partition_types, "boot") |
| 134 | } |
| 135 | } |
Cole Faust | 24938e2 | 2024-11-18 14:01:58 -0800 | [diff] [blame] | 136 | if buildingVendorBootImage(partitionVars) { |
Jihoon Kang | 70c1c68 | 2024-11-20 23:58:38 +0000 | [diff] [blame^] | 137 | if createVendorBootImage(ctx, dtbImg) { |
Cole Faust | 24938e2 | 2024-11-18 14:01:58 -0800 | [diff] [blame] | 138 | f.properties.Vendor_boot_image = ":" + generatedModuleNameForPartition(ctx.Config(), "vendor_boot") |
| 139 | } else { |
| 140 | f.properties.Unsupported_partition_types = append(f.properties.Unsupported_partition_types, "vendor_boot") |
| 141 | } |
| 142 | } |
Jihoon Kang | 95eb1da | 2024-11-19 20:55:20 +0000 | [diff] [blame] | 143 | if buildingInitBootImage(partitionVars) { |
| 144 | if createInitBootImage(ctx) { |
| 145 | f.properties.Init_boot_image = ":" + generatedModuleNameForPartition(ctx.Config(), "init_boot") |
| 146 | } else { |
| 147 | f.properties.Unsupported_partition_types = append(f.properties.Unsupported_partition_types, "init_boot") |
| 148 | } |
| 149 | } |
Cole Faust | f2a6e8b | 2024-11-14 10:54:48 -0800 | [diff] [blame] | 150 | |
Cole Faust | 3552eb6 | 2024-11-06 18:07:26 -0800 | [diff] [blame] | 151 | for _, x := range createVbmetaPartitions(ctx, finalSoongGeneratedPartitions) { |
| 152 | f.properties.Vbmeta_module_names = append(f.properties.Vbmeta_module_names, x.moduleName) |
| 153 | f.properties.Vbmeta_partition_names = append(f.properties.Vbmeta_partition_names, x.partitionName) |
| 154 | } |
| 155 | |
| 156 | ctx.Config().Get(fsGenStateOnceKey).(*FsGenState).soongGeneratedPartitions = finalSoongGeneratedPartitions |
| 157 | f.createDeviceModule(ctx, finalSoongGeneratedPartitions, f.properties.Vbmeta_module_names) |
Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 158 | } |
| 159 | |
Jihoon Kang | 0d545b8 | 2024-10-11 00:21:57 +0000 | [diff] [blame] | 160 | func generatedModuleName(cfg android.Config, suffix string) string { |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 161 | prefix := "soong" |
| 162 | if cfg.HasDeviceProduct() { |
| 163 | prefix = cfg.DeviceProduct() |
| 164 | } |
Jihoon Kang | f1c79ca | 2024-10-09 20:18:38 +0000 | [diff] [blame] | 165 | return fmt.Sprintf("%s_generated_%s", prefix, suffix) |
| 166 | } |
| 167 | |
Jihoon Kang | 0d545b8 | 2024-10-11 00:21:57 +0000 | [diff] [blame] | 168 | func generatedModuleNameForPartition(cfg android.Config, partitionType string) string { |
| 169 | return generatedModuleName(cfg, fmt.Sprintf("%s_image", partitionType)) |
Jihoon Kang | f1c79ca | 2024-10-09 20:18:38 +0000 | [diff] [blame] | 170 | } |
| 171 | |
Cole Faust | 3552eb6 | 2024-11-06 18:07:26 -0800 | [diff] [blame] | 172 | func (f *filesystemCreator) createDeviceModule( |
| 173 | ctx android.LoadHookContext, |
| 174 | generatedPartitionTypes []string, |
| 175 | vbmetaPartitions []string, |
| 176 | ) { |
Jihoon Kang | f1c79ca | 2024-10-09 20:18:38 +0000 | [diff] [blame] | 177 | baseProps := &struct { |
| 178 | Name *string |
| 179 | }{ |
Jihoon Kang | 0d545b8 | 2024-10-11 00:21:57 +0000 | [diff] [blame] | 180 | Name: proptools.StringPtr(generatedModuleName(ctx.Config(), "device")), |
Jihoon Kang | f1c79ca | 2024-10-09 20:18:38 +0000 | [diff] [blame] | 181 | } |
| 182 | |
Priyanka Advani (xWF) | dafaa7f | 2024-10-21 22:55:13 +0000 | [diff] [blame] | 183 | // Currently, only the system and system_ext partition module is created. |
Jihoon Kang | f1c79ca | 2024-10-09 20:18:38 +0000 | [diff] [blame] | 184 | partitionProps := &filesystem.PartitionNameProperties{} |
Cole Faust | 3552eb6 | 2024-11-06 18:07:26 -0800 | [diff] [blame] | 185 | if android.InList("system", generatedPartitionTypes) { |
Jihoon Kang | 0d545b8 | 2024-10-11 00:21:57 +0000 | [diff] [blame] | 186 | partitionProps.System_partition_name = proptools.StringPtr(generatedModuleNameForPartition(ctx.Config(), "system")) |
Jihoon Kang | f1c79ca | 2024-10-09 20:18:38 +0000 | [diff] [blame] | 187 | } |
Cole Faust | 3552eb6 | 2024-11-06 18:07:26 -0800 | [diff] [blame] | 188 | if android.InList("system_ext", generatedPartitionTypes) { |
Jihoon Kang | 0d545b8 | 2024-10-11 00:21:57 +0000 | [diff] [blame] | 189 | partitionProps.System_ext_partition_name = proptools.StringPtr(generatedModuleNameForPartition(ctx.Config(), "system_ext")) |
Spandan Das | 7a46f6c | 2024-10-14 18:41:18 +0000 | [diff] [blame] | 190 | } |
Cole Faust | 3552eb6 | 2024-11-06 18:07:26 -0800 | [diff] [blame] | 191 | if android.InList("vendor", generatedPartitionTypes) { |
Spandan Das | e3b6531 | 2024-10-22 00:27:27 +0000 | [diff] [blame] | 192 | partitionProps.Vendor_partition_name = proptools.StringPtr(generatedModuleNameForPartition(ctx.Config(), "vendor")) |
| 193 | } |
Cole Faust | 3552eb6 | 2024-11-06 18:07:26 -0800 | [diff] [blame] | 194 | if android.InList("product", generatedPartitionTypes) { |
Jihoon Kang | 6dd13b6 | 2024-10-22 23:21:02 +0000 | [diff] [blame] | 195 | partitionProps.Product_partition_name = proptools.StringPtr(generatedModuleNameForPartition(ctx.Config(), "product")) |
| 196 | } |
Cole Faust | 3552eb6 | 2024-11-06 18:07:26 -0800 | [diff] [blame] | 197 | if android.InList("odm", generatedPartitionTypes) { |
Spandan Das | c571716 | 2024-11-01 18:33:57 +0000 | [diff] [blame] | 198 | partitionProps.Odm_partition_name = proptools.StringPtr(generatedModuleNameForPartition(ctx.Config(), "odm")) |
| 199 | } |
mrziwang | 23ba876 | 2024-11-07 16:21:53 -0800 | [diff] [blame] | 200 | if android.InList("userdata", f.properties.Generated_partition_types) { |
| 201 | partitionProps.Userdata_partition_name = proptools.StringPtr(generatedModuleNameForPartition(ctx.Config(), "userdata")) |
| 202 | } |
Cole Faust | 3552eb6 | 2024-11-06 18:07:26 -0800 | [diff] [blame] | 203 | partitionProps.Vbmeta_partitions = vbmetaPartitions |
Jihoon Kang | f1c79ca | 2024-10-09 20:18:38 +0000 | [diff] [blame] | 204 | |
| 205 | ctx.CreateModule(filesystem.AndroidDeviceFactory, baseProps, partitionProps) |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 206 | } |
| 207 | |
Jihoon Kang | d098d44 | 2024-11-19 00:03:22 +0000 | [diff] [blame] | 208 | func partitionSpecificFsProps(fsProps *filesystem.FilesystemProperties, partitionVars android.PartitionVariables, partitionType string) { |
Jihoon Kang | 6850d8f | 2024-10-17 20:45:58 +0000 | [diff] [blame] | 209 | switch partitionType { |
| 210 | case "system": |
| 211 | fsProps.Build_logtags = proptools.BoolPtr(true) |
| 212 | // https://source.corp.google.com/h/googleplex-android/platform/build//639d79f5012a6542ab1f733b0697db45761ab0f3:core/packaging/flags.mk;l=21;drc=5ba8a8b77507f93aa48cc61c5ba3f31a4d0cbf37;bpv=1;bpt=0 |
| 213 | fsProps.Gen_aconfig_flags_pb = proptools.BoolPtr(true) |
Justin Yun | ed3dbce | 2024-11-15 11:57:24 +0900 | [diff] [blame] | 214 | // Identical to that of the aosp_shared_system_image |
Spandan Das | a8fa6b4 | 2024-10-23 00:45:29 +0000 | [diff] [blame] | 215 | fsProps.Fsverity.Inputs = []string{ |
| 216 | "etc/boot-image.prof", |
| 217 | "etc/dirty-image-objects", |
| 218 | "etc/preloaded-classes", |
| 219 | "etc/classpaths/*.pb", |
| 220 | "framework/*", |
| 221 | "framework/*/*", // framework/{arch} |
| 222 | "framework/oat/*/*", // framework/oat/{arch} |
| 223 | } |
| 224 | fsProps.Fsverity.Libs = []string{":framework-res{.export-package.apk}"} |
mrziwang | 9afc298 | 2024-11-05 14:29:48 -0800 | [diff] [blame] | 225 | // TODO(b/377734331): only generate the symlinks if the relevant partitions exist |
| 226 | fsProps.Symlinks = []filesystem.SymlinkDefinition{ |
| 227 | filesystem.SymlinkDefinition{ |
| 228 | Target: proptools.StringPtr("/product"), |
| 229 | Name: proptools.StringPtr("system/product"), |
| 230 | }, |
| 231 | filesystem.SymlinkDefinition{ |
| 232 | Target: proptools.StringPtr("/system_ext"), |
| 233 | Name: proptools.StringPtr("system/system_ext"), |
| 234 | }, |
| 235 | filesystem.SymlinkDefinition{ |
| 236 | Target: proptools.StringPtr("/vendor"), |
| 237 | Name: proptools.StringPtr("system/vendor"), |
| 238 | }, |
| 239 | filesystem.SymlinkDefinition{ |
| 240 | Target: proptools.StringPtr("/system_dlkm/lib/modules"), |
| 241 | Name: proptools.StringPtr("system/lib/modules"), |
| 242 | }, |
| 243 | } |
Spandan Das | a8fa6b4 | 2024-10-23 00:45:29 +0000 | [diff] [blame] | 244 | case "system_ext": |
| 245 | fsProps.Fsverity.Inputs = []string{ |
| 246 | "framework/*", |
| 247 | "framework/*/*", // framework/{arch} |
| 248 | "framework/oat/*/*", // framework/oat/{arch} |
| 249 | } |
| 250 | fsProps.Fsverity.Libs = []string{":framework-res{.export-package.apk}"} |
Jihoon Kang | 6850d8f | 2024-10-17 20:45:58 +0000 | [diff] [blame] | 251 | case "product": |
| 252 | fsProps.Gen_aconfig_flags_pb = proptools.BoolPtr(true) |
| 253 | case "vendor": |
| 254 | fsProps.Gen_aconfig_flags_pb = proptools.BoolPtr(true) |
Spandan Das | 69464c3 | 2024-10-25 20:08:06 +0000 | [diff] [blame] | 255 | fsProps.Symlinks = []filesystem.SymlinkDefinition{ |
| 256 | filesystem.SymlinkDefinition{ |
| 257 | Target: proptools.StringPtr("/odm"), |
| 258 | Name: proptools.StringPtr("vendor/odm"), |
| 259 | }, |
| 260 | filesystem.SymlinkDefinition{ |
| 261 | Target: proptools.StringPtr("/vendor_dlkm/lib/modules"), |
| 262 | Name: proptools.StringPtr("vendor/lib/modules"), |
| 263 | }, |
| 264 | } |
Spandan Das | c571716 | 2024-11-01 18:33:57 +0000 | [diff] [blame] | 265 | case "odm": |
| 266 | fsProps.Symlinks = []filesystem.SymlinkDefinition{ |
| 267 | filesystem.SymlinkDefinition{ |
| 268 | Target: proptools.StringPtr("/odm_dlkm/lib/modules"), |
| 269 | Name: proptools.StringPtr("odm/lib/modules"), |
| 270 | }, |
| 271 | } |
mrziwang | 23ba876 | 2024-11-07 16:21:53 -0800 | [diff] [blame] | 272 | case "userdata": |
| 273 | fsProps.Base_dir = proptools.StringPtr("data") |
Jihoon Kang | d098d44 | 2024-11-19 00:03:22 +0000 | [diff] [blame] | 274 | case "ramdisk": |
| 275 | // Following the logic in https://cs.android.com/android/platform/superproject/main/+/c3c5063df32748a8806ce5da5dd0db158eab9ad9:build/make/core/Makefile;l=1307 |
| 276 | fsProps.Dirs = android.NewSimpleConfigurable([]string{ |
| 277 | "debug_ramdisk", |
| 278 | "dev", |
| 279 | "metadata", |
| 280 | "mnt", |
| 281 | "proc", |
| 282 | "second_stage_resources", |
| 283 | "sys", |
| 284 | }) |
| 285 | if partitionVars.BoardUsesGenericKernelImage { |
| 286 | fsProps.Dirs.AppendSimpleValue([]string{ |
| 287 | "first_stage_ramdisk/debug_ramdisk", |
| 288 | "first_stage_ramdisk/dev", |
| 289 | "first_stage_ramdisk/metadata", |
| 290 | "first_stage_ramdisk/mnt", |
| 291 | "first_stage_ramdisk/proc", |
| 292 | "first_stage_ramdisk/second_stage_resources", |
| 293 | "first_stage_ramdisk/sys", |
| 294 | }) |
| 295 | } |
Jihoon Kang | 6850d8f | 2024-10-17 20:45:58 +0000 | [diff] [blame] | 296 | } |
| 297 | } |
Spandan Das | cbe641a | 2024-10-14 21:07:34 +0000 | [diff] [blame] | 298 | |
Spandan Das | 5b493cd | 2024-11-07 20:55:56 +0000 | [diff] [blame] | 299 | var ( |
| 300 | dlkmPartitions = []string{ |
| 301 | "system_dlkm", |
| 302 | "vendor_dlkm", |
| 303 | "odm_dlkm", |
| 304 | } |
| 305 | ) |
| 306 | |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 307 | // Creates a soong module to build the given partition. Returns false if we can't support building |
| 308 | // it. |
| 309 | func (f *filesystemCreator) createPartition(ctx android.LoadHookContext, partitionType string) bool { |
mrziwang | 4b0ca97 | 2024-10-17 14:56:19 -0700 | [diff] [blame] | 310 | baseProps := generateBaseProps(proptools.StringPtr(generatedModuleNameForPartition(ctx.Config(), partitionType))) |
| 311 | |
| 312 | fsProps, supported := generateFsProps(ctx, partitionType) |
| 313 | if !supported { |
| 314 | return false |
mrziwang | a077b94 | 2024-10-16 16:00:06 -0700 | [diff] [blame] | 315 | } |
mrziwang | a077b94 | 2024-10-16 16:00:06 -0700 | [diff] [blame] | 316 | |
Spandan Das | 8fe68dc | 2024-10-29 18:20:11 +0000 | [diff] [blame] | 317 | if partitionType == "vendor" || partitionType == "product" { |
Spandan Das | 2047a4c | 2024-11-11 21:24:58 +0000 | [diff] [blame] | 318 | fsProps.Linker_config.Gen_linker_config = proptools.BoolPtr(true) |
| 319 | fsProps.Linker_config.Linker_config_srcs = f.createLinkerConfigSourceFilegroups(ctx, partitionType) |
Spandan Das | 312cc41 | 2024-10-29 18:20:11 +0000 | [diff] [blame] | 320 | } |
| 321 | |
Spandan Das | 5b493cd | 2024-11-07 20:55:56 +0000 | [diff] [blame] | 322 | if android.InList(partitionType, dlkmPartitions) { |
| 323 | f.createPrebuiltKernelModules(ctx, partitionType) |
Spandan Das | 5e33642 | 2024-11-01 22:31:20 +0000 | [diff] [blame] | 324 | } |
| 325 | |
mrziwang | 4b0ca97 | 2024-10-17 14:56:19 -0700 | [diff] [blame] | 326 | var module android.Module |
| 327 | if partitionType == "system" { |
| 328 | module = ctx.CreateModule(filesystem.SystemImageFactory, baseProps, fsProps) |
| 329 | } else { |
| 330 | // Explicitly set the partition. |
| 331 | fsProps.Partition_type = proptools.StringPtr(partitionType) |
| 332 | module = ctx.CreateModule(filesystem.FilesystemFactory, baseProps, fsProps) |
| 333 | } |
| 334 | module.HideFromMake() |
Spandan Das | 168098c | 2024-10-28 19:44:34 +0000 | [diff] [blame] | 335 | if partitionType == "vendor" { |
Spandan Das | 4cd93b5 | 2024-11-05 23:27:03 +0000 | [diff] [blame] | 336 | f.createVendorBuildProp(ctx) |
Spandan Das | 168098c | 2024-10-28 19:44:34 +0000 | [diff] [blame] | 337 | } |
mrziwang | 4b0ca97 | 2024-10-17 14:56:19 -0700 | [diff] [blame] | 338 | return true |
| 339 | } |
| 340 | |
Cole Faust | 953476f | 2024-11-14 14:11:29 -0800 | [diff] [blame] | 341 | // Creates filegroups for the files specified in BOARD_(partition_)AVB_KEY_PATH |
| 342 | func (f *filesystemCreator) createAvbKeyFilegroups(ctx android.LoadHookContext) { |
| 343 | partitionVars := ctx.Config().ProductVariables().PartitionVarsForSoongMigrationOnlyDoNotUse |
| 344 | var files []string |
| 345 | |
| 346 | if len(partitionVars.BoardAvbKeyPath) > 0 { |
| 347 | files = append(files, partitionVars.BoardAvbKeyPath) |
| 348 | } |
| 349 | for _, partition := range android.SortedKeys(partitionVars.PartitionQualifiedVariables) { |
| 350 | specificPartitionVars := partitionVars.PartitionQualifiedVariables[partition] |
| 351 | if len(specificPartitionVars.BoardAvbKeyPath) > 0 { |
| 352 | files = append(files, specificPartitionVars.BoardAvbKeyPath) |
| 353 | } |
| 354 | } |
| 355 | |
| 356 | fsGenState := ctx.Config().Get(fsGenStateOnceKey).(*FsGenState) |
| 357 | for _, file := range files { |
| 358 | if _, ok := fsGenState.avbKeyFilegroups[file]; ok { |
| 359 | continue |
| 360 | } |
| 361 | if file == "external/avb/test/data/testkey_rsa4096.pem" { |
| 362 | // There already exists a checked-in filegroup for this commonly-used key, just use that |
| 363 | fsGenState.avbKeyFilegroups[file] = "avb_testkey_rsa4096" |
| 364 | continue |
| 365 | } |
| 366 | dir := filepath.Dir(file) |
| 367 | base := filepath.Base(file) |
| 368 | name := fmt.Sprintf("avb_key_%x", strings.ReplaceAll(file, "/", "_")) |
| 369 | ctx.CreateModuleInDirectory( |
| 370 | android.FileGroupFactory, |
| 371 | dir, |
| 372 | &struct { |
| 373 | Name *string |
| 374 | Srcs []string |
| 375 | Visibility []string |
| 376 | }{ |
| 377 | Name: proptools.StringPtr(name), |
| 378 | Srcs: []string{base}, |
| 379 | Visibility: []string{"//visibility:public"}, |
| 380 | }, |
| 381 | ) |
| 382 | fsGenState.avbKeyFilegroups[file] = name |
| 383 | } |
| 384 | } |
| 385 | |
Spandan Das | 5e33642 | 2024-11-01 22:31:20 +0000 | [diff] [blame] | 386 | // createPrebuiltKernelModules creates `prebuilt_kernel_modules`. These modules will be added to deps of the |
Spandan Das | 7b25a51 | 2024-11-06 20:41:26 +0000 | [diff] [blame] | 387 | // autogenerated *_dlkm filsystem modules. Each _dlkm partition should have a single prebuilt_kernel_modules dependency. |
| 388 | // This ensures that the depmod artifacts (modules.* installed in /lib/modules/) are generated with a complete view. |
Spandan Das | 5b493cd | 2024-11-07 20:55:56 +0000 | [diff] [blame] | 389 | func (f *filesystemCreator) createPrebuiltKernelModules(ctx android.LoadHookContext, partitionType string) { |
Spandan Das | 5e33642 | 2024-11-01 22:31:20 +0000 | [diff] [blame] | 390 | fsGenState := ctx.Config().Get(fsGenStateOnceKey).(*FsGenState) |
Spandan Das | 7b25a51 | 2024-11-06 20:41:26 +0000 | [diff] [blame] | 391 | name := generatedModuleName(ctx.Config(), fmt.Sprintf("%s-kernel-modules", partitionType)) |
| 392 | props := &struct { |
Spandan Das | 912d26b | 2024-11-06 19:35:17 +0000 | [diff] [blame] | 393 | Name *string |
| 394 | Srcs []string |
Spandan Das | 5b493cd | 2024-11-07 20:55:56 +0000 | [diff] [blame] | 395 | System_deps []string |
Spandan Das | 912d26b | 2024-11-06 19:35:17 +0000 | [diff] [blame] | 396 | System_dlkm_specific *bool |
Spandan Das | 5b493cd | 2024-11-07 20:55:56 +0000 | [diff] [blame] | 397 | Vendor_dlkm_specific *bool |
| 398 | Odm_dlkm_specific *bool |
| 399 | Load_by_default *bool |
Spandan Das | 6dfcbdf | 2024-11-11 18:43:07 +0000 | [diff] [blame] | 400 | Blocklist_file *string |
Spandan Das | 7b25a51 | 2024-11-06 20:41:26 +0000 | [diff] [blame] | 401 | }{ |
| 402 | Name: proptools.StringPtr(name), |
Spandan Das | 5e33642 | 2024-11-01 22:31:20 +0000 | [diff] [blame] | 403 | } |
Spandan Das | 5b493cd | 2024-11-07 20:55:56 +0000 | [diff] [blame] | 404 | switch partitionType { |
| 405 | case "system_dlkm": |
Spandan Das | 59ee5d7 | 2024-11-18 19:36:32 +0000 | [diff] [blame] | 406 | props.Srcs = android.ExistentPathsForSources(ctx, ctx.Config().ProductVariables().PartitionVarsForSoongMigrationOnlyDoNotUse.SystemKernelModules).Strings() |
Spandan Das | 912d26b | 2024-11-06 19:35:17 +0000 | [diff] [blame] | 407 | props.System_dlkm_specific = proptools.BoolPtr(true) |
Spandan Das | 5b493cd | 2024-11-07 20:55:56 +0000 | [diff] [blame] | 408 | if len(ctx.Config().ProductVariables().PartitionVarsForSoongMigrationOnlyDoNotUse.SystemKernelLoadModules) == 0 { |
| 409 | // Create empty modules.load file for system |
| 410 | // https://source.corp.google.com/h/googleplex-android/platform/build/+/ef55daac9954896161b26db4f3ef1781b5a5694c:core/Makefile;l=695-700;drc=549fe2a5162548bd8b47867d35f907eb22332023;bpv=1;bpt=0 |
| 411 | props.Load_by_default = proptools.BoolPtr(false) |
| 412 | } |
Spandan Das | 6dfcbdf | 2024-11-11 18:43:07 +0000 | [diff] [blame] | 413 | if blocklistFile := ctx.Config().ProductVariables().PartitionVarsForSoongMigrationOnlyDoNotUse.SystemKernelBlocklistFile; blocklistFile != "" { |
| 414 | props.Blocklist_file = proptools.StringPtr(blocklistFile) |
| 415 | } |
Spandan Das | 5b493cd | 2024-11-07 20:55:56 +0000 | [diff] [blame] | 416 | case "vendor_dlkm": |
Spandan Das | 59ee5d7 | 2024-11-18 19:36:32 +0000 | [diff] [blame] | 417 | props.Srcs = android.ExistentPathsForSources(ctx, ctx.Config().ProductVariables().PartitionVarsForSoongMigrationOnlyDoNotUse.VendorKernelModules).Strings() |
Spandan Das | 5b493cd | 2024-11-07 20:55:56 +0000 | [diff] [blame] | 418 | if len(ctx.Config().ProductVariables().PartitionVarsForSoongMigrationOnlyDoNotUse.SystemKernelModules) > 0 { |
| 419 | props.System_deps = []string{":" + generatedModuleName(ctx.Config(), "system_dlkm-kernel-modules") + "{.modules}"} |
| 420 | } |
| 421 | props.Vendor_dlkm_specific = proptools.BoolPtr(true) |
Spandan Das | 6dfcbdf | 2024-11-11 18:43:07 +0000 | [diff] [blame] | 422 | if blocklistFile := ctx.Config().ProductVariables().PartitionVarsForSoongMigrationOnlyDoNotUse.VendorKernelBlocklistFile; blocklistFile != "" { |
| 423 | props.Blocklist_file = proptools.StringPtr(blocklistFile) |
| 424 | } |
Spandan Das | 5b493cd | 2024-11-07 20:55:56 +0000 | [diff] [blame] | 425 | case "odm_dlkm": |
Spandan Das | 59ee5d7 | 2024-11-18 19:36:32 +0000 | [diff] [blame] | 426 | props.Srcs = android.ExistentPathsForSources(ctx, ctx.Config().ProductVariables().PartitionVarsForSoongMigrationOnlyDoNotUse.OdmKernelModules).Strings() |
Spandan Das | 5b493cd | 2024-11-07 20:55:56 +0000 | [diff] [blame] | 427 | props.Odm_dlkm_specific = proptools.BoolPtr(true) |
Spandan Das | 6dfcbdf | 2024-11-11 18:43:07 +0000 | [diff] [blame] | 428 | if blocklistFile := ctx.Config().ProductVariables().PartitionVarsForSoongMigrationOnlyDoNotUse.OdmKernelBlocklistFile; blocklistFile != "" { |
| 429 | props.Blocklist_file = proptools.StringPtr(blocklistFile) |
| 430 | } |
Spandan Das | 5b493cd | 2024-11-07 20:55:56 +0000 | [diff] [blame] | 431 | default: |
| 432 | ctx.ModuleErrorf("DLKM is not supported for %s\n", partitionType) |
Spandan Das | 912d26b | 2024-11-06 19:35:17 +0000 | [diff] [blame] | 433 | } |
Spandan Das | 5b493cd | 2024-11-07 20:55:56 +0000 | [diff] [blame] | 434 | |
| 435 | if len(props.Srcs) == 0 { |
| 436 | return // do not generate `prebuilt_kernel_modules` if there are no sources |
| 437 | } |
| 438 | |
Spandan Das | 7b25a51 | 2024-11-06 20:41:26 +0000 | [diff] [blame] | 439 | kernelModule := ctx.CreateModuleInDirectory( |
| 440 | kernel.PrebuiltKernelModulesFactory, |
| 441 | ".", // create in root directory for now |
| 442 | props, |
| 443 | ) |
| 444 | kernelModule.HideFromMake() |
| 445 | // Add to deps |
| 446 | (*fsGenState.fsDeps[partitionType])[name] = defaultDepCandidateProps(ctx.Config()) |
Spandan Das | 5e33642 | 2024-11-01 22:31:20 +0000 | [diff] [blame] | 447 | } |
| 448 | |
Spandan Das | 4cd93b5 | 2024-11-05 23:27:03 +0000 | [diff] [blame] | 449 | // Create a build_prop and android_info module. This will be used to create /vendor/build.prop |
| 450 | func (f *filesystemCreator) createVendorBuildProp(ctx android.LoadHookContext) { |
| 451 | // Create a android_info for vendor |
| 452 | // The board info files might be in a directory outside the root soong namespace, so create |
| 453 | // the module in "." |
| 454 | partitionVars := ctx.Config().ProductVariables().PartitionVarsForSoongMigrationOnlyDoNotUse |
| 455 | androidInfoProps := &struct { |
| 456 | Name *string |
| 457 | Board_info_files []string |
| 458 | Bootloader_board_name *string |
| 459 | }{ |
| 460 | Name: proptools.StringPtr(generatedModuleName(ctx.Config(), "android-info.prop")), |
| 461 | Board_info_files: partitionVars.BoardInfoFiles, |
| 462 | } |
| 463 | if len(androidInfoProps.Board_info_files) == 0 { |
| 464 | androidInfoProps.Bootloader_board_name = proptools.StringPtr(partitionVars.BootLoaderBoardName) |
| 465 | } |
| 466 | androidInfoProp := ctx.CreateModuleInDirectory( |
| 467 | android.AndroidInfoFactory, |
| 468 | ".", |
| 469 | androidInfoProps, |
| 470 | ) |
| 471 | androidInfoProp.HideFromMake() |
| 472 | // Create a build prop for vendor |
| 473 | vendorBuildProps := &struct { |
| 474 | Name *string |
| 475 | Vendor *bool |
| 476 | Stem *string |
| 477 | Product_config *string |
| 478 | Android_info *string |
| 479 | }{ |
| 480 | Name: proptools.StringPtr(generatedModuleName(ctx.Config(), "vendor-build.prop")), |
| 481 | Vendor: proptools.BoolPtr(true), |
| 482 | Stem: proptools.StringPtr("build.prop"), |
| 483 | Product_config: proptools.StringPtr(":product_config"), |
| 484 | Android_info: proptools.StringPtr(":" + androidInfoProp.Name()), |
| 485 | } |
| 486 | vendorBuildProp := ctx.CreateModule( |
| 487 | android.BuildPropFactory, |
| 488 | vendorBuildProps, |
| 489 | ) |
| 490 | vendorBuildProp.HideFromMake() |
| 491 | } |
| 492 | |
Spandan Das | 8fe68dc | 2024-10-29 18:20:11 +0000 | [diff] [blame] | 493 | // createLinkerConfigSourceFilegroups creates filegroup modules to generate linker.config.pb for the following partitions |
| 494 | // 1. vendor: Using PRODUCT_VENDOR_LINKER_CONFIG_FRAGMENTS (space separated file list) |
| 495 | // 1. product: Using PRODUCT_PRODUCT_LINKER_CONFIG_FRAGMENTS (space separated file list) |
| 496 | // It creates a filegroup for each file in the fragment list |
Spandan Das | 312cc41 | 2024-10-29 18:20:11 +0000 | [diff] [blame] | 497 | // The filegroup modules are then added to `linker_config_srcs` of the autogenerated vendor `android_filesystem`. |
Spandan Das | 8fe68dc | 2024-10-29 18:20:11 +0000 | [diff] [blame] | 498 | func (f *filesystemCreator) createLinkerConfigSourceFilegroups(ctx android.LoadHookContext, partitionType string) []string { |
Spandan Das | 312cc41 | 2024-10-29 18:20:11 +0000 | [diff] [blame] | 499 | ret := []string{} |
| 500 | partitionVars := ctx.Config().ProductVariables().PartitionVarsForSoongMigrationOnlyDoNotUse |
Spandan Das | 8fe68dc | 2024-10-29 18:20:11 +0000 | [diff] [blame] | 501 | var linkerConfigSrcs []string |
| 502 | if partitionType == "vendor" { |
| 503 | linkerConfigSrcs = android.FirstUniqueStrings(partitionVars.VendorLinkerConfigSrcs) |
| 504 | } else if partitionType == "product" { |
| 505 | linkerConfigSrcs = android.FirstUniqueStrings(partitionVars.ProductLinkerConfigSrcs) |
| 506 | } else { |
| 507 | ctx.ModuleErrorf("linker.config.pb is only supported for vendor and product partitions. For system partition, use `android_system_image`") |
| 508 | } |
| 509 | |
| 510 | if len(linkerConfigSrcs) > 0 { |
Spandan Das | 312cc41 | 2024-10-29 18:20:11 +0000 | [diff] [blame] | 511 | // Create a filegroup, and add `:<filegroup_name>` to ret. |
| 512 | for index, linkerConfigSrc := range linkerConfigSrcs { |
| 513 | dir := filepath.Dir(linkerConfigSrc) |
| 514 | base := filepath.Base(linkerConfigSrc) |
Spandan Das | 8fe68dc | 2024-10-29 18:20:11 +0000 | [diff] [blame] | 515 | fgName := generatedModuleName(ctx.Config(), fmt.Sprintf("%s-linker-config-src%s", partitionType, strconv.Itoa(index))) |
Spandan Das | 312cc41 | 2024-10-29 18:20:11 +0000 | [diff] [blame] | 516 | srcs := []string{base} |
| 517 | fgProps := &struct { |
| 518 | Name *string |
| 519 | Srcs proptools.Configurable[[]string] |
| 520 | }{ |
| 521 | Name: proptools.StringPtr(fgName), |
| 522 | Srcs: proptools.NewSimpleConfigurable(srcs), |
| 523 | } |
| 524 | ctx.CreateModuleInDirectory( |
| 525 | android.FileGroupFactory, |
| 526 | dir, |
| 527 | fgProps, |
| 528 | ) |
| 529 | ret = append(ret, ":"+fgName) |
| 530 | } |
| 531 | } |
| 532 | return ret |
| 533 | } |
| 534 | |
mrziwang | 4b0ca97 | 2024-10-17 14:56:19 -0700 | [diff] [blame] | 535 | type filesystemBaseProperty struct { |
| 536 | Name *string |
| 537 | Compile_multilib *string |
Cole Faust | 3552eb6 | 2024-11-06 18:07:26 -0800 | [diff] [blame] | 538 | Visibility []string |
mrziwang | 4b0ca97 | 2024-10-17 14:56:19 -0700 | [diff] [blame] | 539 | } |
| 540 | |
| 541 | func generateBaseProps(namePtr *string) *filesystemBaseProperty { |
| 542 | return &filesystemBaseProperty{ |
| 543 | Name: namePtr, |
| 544 | Compile_multilib: proptools.StringPtr("both"), |
Cole Faust | 3552eb6 | 2024-11-06 18:07:26 -0800 | [diff] [blame] | 545 | // The vbmeta modules are currently in the root directory and depend on the partitions |
| 546 | Visibility: []string{"//.", "//build/soong:__subpackages__"}, |
mrziwang | 4b0ca97 | 2024-10-17 14:56:19 -0700 | [diff] [blame] | 547 | } |
| 548 | } |
| 549 | |
| 550 | func generateFsProps(ctx android.EarlyModuleContext, partitionType string) (*filesystem.FilesystemProperties, bool) { |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 551 | fsProps := &filesystem.FilesystemProperties{} |
| 552 | |
mrziwang | 4b0ca97 | 2024-10-17 14:56:19 -0700 | [diff] [blame] | 553 | partitionVars := ctx.Config().ProductVariables().PartitionVarsForSoongMigrationOnlyDoNotUse |
Cole Faust | 0c4b415 | 2024-11-20 16:42:53 -0800 | [diff] [blame] | 554 | var avbInfo avbInfo |
Cole Faust | 76a6e95 | 2024-11-07 16:56:45 -0800 | [diff] [blame] | 555 | var fsType string |
| 556 | if strings.Contains(partitionType, "ramdisk") { |
| 557 | fsType = "compressed_cpio" |
| 558 | } else { |
Cole Faust | 953476f | 2024-11-14 14:11:29 -0800 | [diff] [blame] | 559 | specificPartitionVars := partitionVars.PartitionQualifiedVariables[partitionType] |
Cole Faust | 76a6e95 | 2024-11-07 16:56:45 -0800 | [diff] [blame] | 560 | fsType = specificPartitionVars.BoardFileSystemType |
Cole Faust | 0c4b415 | 2024-11-20 16:42:53 -0800 | [diff] [blame] | 561 | avbInfo = getAvbInfo(ctx.Config(), partitionType) |
Cole Faust | 953476f | 2024-11-14 14:11:29 -0800 | [diff] [blame] | 562 | if fsType == "" { |
| 563 | fsType = "ext4" //default |
| 564 | } |
Cole Faust | 76a6e95 | 2024-11-07 16:56:45 -0800 | [diff] [blame] | 565 | } |
Cole Faust | 76a6e95 | 2024-11-07 16:56:45 -0800 | [diff] [blame] | 566 | |
mrziwang | 4b0ca97 | 2024-10-17 14:56:19 -0700 | [diff] [blame] | 567 | fsProps.Type = proptools.StringPtr(fsType) |
| 568 | if filesystem.GetFsTypeFromString(ctx, *fsProps.Type).IsUnknown() { |
| 569 | // Currently the android_filesystem module type only supports a handful of FS types like ext4, erofs |
| 570 | return nil, false |
| 571 | } |
| 572 | |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 573 | // Don't build this module on checkbuilds, the soong-built partitions are still in-progress |
| 574 | // and sometimes don't build. |
| 575 | fsProps.Unchecked_module = proptools.BoolPtr(true) |
| 576 | |
Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 577 | // BOARD_AVB_ENABLE |
Cole Faust | 0c4b415 | 2024-11-20 16:42:53 -0800 | [diff] [blame] | 578 | fsProps.Use_avb = avbInfo.avbEnable |
Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 579 | // BOARD_AVB_KEY_PATH |
Cole Faust | 0c4b415 | 2024-11-20 16:42:53 -0800 | [diff] [blame] | 580 | fsProps.Avb_private_key = avbInfo.avbkeyFilegroup |
Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 581 | // BOARD_AVB_ALGORITHM |
Cole Faust | 0c4b415 | 2024-11-20 16:42:53 -0800 | [diff] [blame] | 582 | fsProps.Avb_algorithm = avbInfo.avbAlgorithm |
Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 583 | // BOARD_AVB_SYSTEM_ROLLBACK_INDEX |
Cole Faust | 0c4b415 | 2024-11-20 16:42:53 -0800 | [diff] [blame] | 584 | fsProps.Rollback_index = avbInfo.avbRollbackIndex |
Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 585 | |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 586 | fsProps.Partition_name = proptools.StringPtr(partitionType) |
Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 587 | |
Cole Faust | 6838219 | 2024-11-19 10:36:03 -0800 | [diff] [blame] | 588 | if !strings.Contains(partitionType, "ramdisk") { |
| 589 | fsProps.Base_dir = proptools.StringPtr(partitionType) |
| 590 | } |
Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 591 | |
Jihoon Kang | 0d545b8 | 2024-10-11 00:21:57 +0000 | [diff] [blame] | 592 | fsProps.Is_auto_generated = proptools.BoolPtr(true) |
| 593 | |
Jihoon Kang | d098d44 | 2024-11-19 00:03:22 +0000 | [diff] [blame] | 594 | partitionSpecificFsProps(fsProps, partitionVars, partitionType) |
Jihoon Kang | 6850d8f | 2024-10-17 20:45:58 +0000 | [diff] [blame] | 595 | |
Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 596 | // system_image properties that are not set: |
| 597 | // - filesystemProperties.Avb_hash_algorithm |
| 598 | // - filesystemProperties.File_contexts |
| 599 | // - filesystemProperties.Dirs |
| 600 | // - filesystemProperties.Symlinks |
| 601 | // - filesystemProperties.Fake_timestamp |
| 602 | // - filesystemProperties.Uuid |
| 603 | // - filesystemProperties.Mount_point |
| 604 | // - filesystemProperties.Include_make_built_files |
| 605 | // - filesystemProperties.Build_logtags |
Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 606 | // - systemImageProperties.Linker_config_src |
mrziwang | 4b0ca97 | 2024-10-17 14:56:19 -0700 | [diff] [blame] | 607 | |
| 608 | return fsProps, true |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 609 | } |
| 610 | |
Cole Faust | 0c4b415 | 2024-11-20 16:42:53 -0800 | [diff] [blame] | 611 | type avbInfo struct { |
| 612 | avbEnable *bool |
| 613 | avbKeyPath *string |
| 614 | avbkeyFilegroup *string |
| 615 | avbAlgorithm *string |
| 616 | avbRollbackIndex *int64 |
| 617 | avbMode *string |
| 618 | } |
| 619 | |
| 620 | func getAvbInfo(config android.Config, partitionType string) avbInfo { |
| 621 | partitionVars := config.ProductVariables().PartitionVarsForSoongMigrationOnlyDoNotUse |
| 622 | specificPartitionVars := partitionVars.PartitionQualifiedVariables[partitionType] |
| 623 | var result avbInfo |
| 624 | boardAvbEnable := partitionVars.BoardAvbEnable |
| 625 | if boardAvbEnable { |
| 626 | result.avbEnable = proptools.BoolPtr(true) |
| 627 | if specificPartitionVars.BoardAvbKeyPath != "" { |
| 628 | result.avbKeyPath = proptools.StringPtr(specificPartitionVars.BoardAvbKeyPath) |
| 629 | } else if partitionVars.BoardAvbKeyPath != "" { |
| 630 | result.avbKeyPath = proptools.StringPtr(partitionVars.BoardAvbKeyPath) |
| 631 | } |
| 632 | if specificPartitionVars.BoardAvbAlgorithm != "" { |
| 633 | result.avbAlgorithm = proptools.StringPtr(specificPartitionVars.BoardAvbAlgorithm) |
| 634 | } else if partitionVars.BoardAvbAlgorithm != "" { |
| 635 | result.avbAlgorithm = proptools.StringPtr(partitionVars.BoardAvbAlgorithm) |
| 636 | } |
| 637 | if specificPartitionVars.BoardAvbRollbackIndex != "" { |
| 638 | parsed, err := strconv.ParseInt(specificPartitionVars.BoardAvbRollbackIndex, 10, 64) |
| 639 | if err != nil { |
| 640 | panic(fmt.Sprintf("Rollback index must be an int, got %s", specificPartitionVars.BoardAvbRollbackIndex)) |
| 641 | } |
| 642 | result.avbRollbackIndex = &parsed |
| 643 | } else if partitionVars.BoardAvbRollbackIndex != "" { |
| 644 | parsed, err := strconv.ParseInt(partitionVars.BoardAvbRollbackIndex, 10, 64) |
| 645 | if err != nil { |
| 646 | panic(fmt.Sprintf("Rollback index must be an int, got %s", partitionVars.BoardAvbRollbackIndex)) |
| 647 | } |
| 648 | result.avbRollbackIndex = &parsed |
| 649 | } |
| 650 | result.avbMode = proptools.StringPtr("make_legacy") |
| 651 | } |
| 652 | if result.avbKeyPath != nil { |
| 653 | fsGenState := config.Get(fsGenStateOnceKey).(*FsGenState) |
| 654 | filegroup := fsGenState.avbKeyFilegroups[*result.avbKeyPath] |
| 655 | result.avbkeyFilegroup = proptools.StringPtr(":" + filegroup) |
| 656 | } |
| 657 | return result |
| 658 | } |
| 659 | |
Cole Faust | f2a6e8b | 2024-11-14 10:54:48 -0800 | [diff] [blame] | 660 | func (f *filesystemCreator) createFileListDiffTest(ctx android.ModuleContext, partitionType string) android.Path { |
Jihoon Kang | 0d545b8 | 2024-10-11 00:21:57 +0000 | [diff] [blame] | 661 | partitionModuleName := generatedModuleNameForPartition(ctx.Config(), partitionType) |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 662 | systemImage := ctx.GetDirectDepWithTag(partitionModuleName, generatedFilesystemDepTag) |
| 663 | filesystemInfo, ok := android.OtherModuleProvider(ctx, systemImage, filesystem.FilesystemProvider) |
| 664 | if !ok { |
| 665 | ctx.ModuleErrorf("Expected module %s to provide FileysystemInfo", partitionModuleName) |
| 666 | } |
| 667 | makeFileList := android.PathForArbitraryOutput(ctx, fmt.Sprintf("target/product/%s/obj/PACKAGING/%s_intermediates/file_list.txt", ctx.Config().DeviceName(), partitionType)) |
Jihoon Kang | 9e866c8 | 2024-10-07 22:39:18 +0000 | [diff] [blame] | 668 | diffTestResultFile := android.PathForModuleOut(ctx, fmt.Sprintf("diff_test_%s.txt", partitionModuleName)) |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 669 | |
| 670 | builder := android.NewRuleBuilder(pctx, ctx) |
| 671 | builder.Command().BuiltTool("file_list_diff"). |
| 672 | Input(makeFileList). |
| 673 | Input(filesystemInfo.FileListFile). |
Cole Faust | 5630157 | 2024-11-07 15:22:42 -0800 | [diff] [blame] | 674 | Text(partitionModuleName) |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 675 | builder.Command().Text("touch").Output(diffTestResultFile) |
| 676 | builder.Build(partitionModuleName+" diff test", partitionModuleName+" diff test") |
| 677 | return diffTestResultFile |
| 678 | } |
| 679 | |
| 680 | func createFailingCommand(ctx android.ModuleContext, message string) android.Path { |
| 681 | hasher := sha256.New() |
| 682 | hasher.Write([]byte(message)) |
| 683 | filename := fmt.Sprintf("failing_command_%x.txt", hasher.Sum(nil)) |
| 684 | file := android.PathForModuleOut(ctx, filename) |
| 685 | builder := android.NewRuleBuilder(pctx, ctx) |
| 686 | builder.Command().Textf("echo %s", proptools.NinjaAndShellEscape(message)) |
| 687 | builder.Command().Text("exit 1 #").Output(file) |
| 688 | builder.Build("failing command "+filename, "failing command "+filename) |
| 689 | return file |
| 690 | } |
| 691 | |
Cole Faust | 3552eb6 | 2024-11-06 18:07:26 -0800 | [diff] [blame] | 692 | func createVbmetaDiff(ctx android.ModuleContext, vbmetaModuleName string, vbmetaPartitionName string) android.Path { |
| 693 | vbmetaModule := ctx.GetDirectDepWithTag(vbmetaModuleName, generatedVbmetaPartitionDepTag) |
| 694 | outputFilesProvider, ok := android.OtherModuleProvider(ctx, vbmetaModule, android.OutputFilesProvider) |
| 695 | if !ok { |
| 696 | ctx.ModuleErrorf("Expected module %s to provide OutputFiles", vbmetaModule) |
| 697 | } |
| 698 | if len(outputFilesProvider.DefaultOutputFiles) != 1 { |
| 699 | ctx.ModuleErrorf("Expected 1 output file from module %s", vbmetaModule) |
| 700 | } |
| 701 | soongVbMetaFile := outputFilesProvider.DefaultOutputFiles[0] |
| 702 | makeVbmetaFile := android.PathForArbitraryOutput(ctx, fmt.Sprintf("target/product/%s/%s.img", ctx.Config().DeviceName(), vbmetaPartitionName)) |
| 703 | |
| 704 | diffTestResultFile := android.PathForModuleOut(ctx, fmt.Sprintf("diff_test_%s.txt", vbmetaModuleName)) |
Cole Faust | f2a6e8b | 2024-11-14 10:54:48 -0800 | [diff] [blame] | 705 | createDiffTest(ctx, diffTestResultFile, soongVbMetaFile, makeVbmetaFile) |
| 706 | return diffTestResultFile |
| 707 | } |
| 708 | |
| 709 | func createDiffTest(ctx android.ModuleContext, diffTestResultFile android.WritablePath, file1 android.Path, file2 android.Path) { |
Cole Faust | 3552eb6 | 2024-11-06 18:07:26 -0800 | [diff] [blame] | 710 | builder := android.NewRuleBuilder(pctx, ctx) |
| 711 | builder.Command().Text("diff"). |
Cole Faust | f2a6e8b | 2024-11-14 10:54:48 -0800 | [diff] [blame] | 712 | Input(file1). |
| 713 | Input(file2) |
Cole Faust | 3552eb6 | 2024-11-06 18:07:26 -0800 | [diff] [blame] | 714 | builder.Command().Text("touch").Output(diffTestResultFile) |
Cole Faust | f2a6e8b | 2024-11-14 10:54:48 -0800 | [diff] [blame] | 715 | builder.Build("diff test "+diffTestResultFile.String(), "diff test") |
Cole Faust | 3552eb6 | 2024-11-06 18:07:26 -0800 | [diff] [blame] | 716 | } |
| 717 | |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 718 | type systemImageDepTagType struct { |
| 719 | blueprint.BaseDependencyTag |
| 720 | } |
| 721 | |
| 722 | var generatedFilesystemDepTag systemImageDepTagType |
Cole Faust | 3552eb6 | 2024-11-06 18:07:26 -0800 | [diff] [blame] | 723 | var generatedVbmetaPartitionDepTag systemImageDepTagType |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 724 | |
| 725 | func (f *filesystemCreator) DepsMutator(ctx android.BottomUpMutatorContext) { |
| 726 | for _, partitionType := range f.properties.Generated_partition_types { |
Jihoon Kang | 0d545b8 | 2024-10-11 00:21:57 +0000 | [diff] [blame] | 727 | ctx.AddDependency(ctx.Module(), generatedFilesystemDepTag, generatedModuleNameForPartition(ctx.Config(), partitionType)) |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 728 | } |
Cole Faust | 3552eb6 | 2024-11-06 18:07:26 -0800 | [diff] [blame] | 729 | for _, vbmetaModule := range f.properties.Vbmeta_module_names { |
| 730 | ctx.AddDependency(ctx.Module(), generatedVbmetaPartitionDepTag, vbmetaModule) |
| 731 | } |
Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 732 | } |
| 733 | |
| 734 | func (f *filesystemCreator) GenerateAndroidBuildActions(ctx android.ModuleContext) { |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 735 | if ctx.ModuleDir() != "build/soong/fsgen" { |
| 736 | ctx.ModuleErrorf("There can only be one soong_filesystem_creator in build/soong/fsgen") |
| 737 | } |
| 738 | f.HideFromMake() |
Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 739 | |
Jihoon Kang | 4e5d8de | 2024-10-19 01:59:58 +0000 | [diff] [blame] | 740 | var content strings.Builder |
| 741 | generatedBp := android.PathForModuleOut(ctx, "soong_generated_product_config.bp") |
| 742 | for _, partition := range ctx.Config().Get(fsGenStateOnceKey).(*FsGenState).soongGeneratedPartitions { |
| 743 | content.WriteString(generateBpContent(ctx, partition)) |
| 744 | content.WriteString("\n") |
| 745 | } |
| 746 | android.WriteFileRule(ctx, generatedBp, content.String()) |
| 747 | |
mrziwang | 8f86c88 | 2024-10-03 12:34:33 -0700 | [diff] [blame] | 748 | ctx.Phony("product_config_to_bp", generatedBp) |
| 749 | |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 750 | var diffTestFiles []android.Path |
| 751 | for _, partitionType := range f.properties.Generated_partition_types { |
Cole Faust | f2a6e8b | 2024-11-14 10:54:48 -0800 | [diff] [blame] | 752 | diffTestFile := f.createFileListDiffTest(ctx, partitionType) |
Jihoon Kang | 72f812f | 2024-10-17 18:46:24 +0000 | [diff] [blame] | 753 | diffTestFiles = append(diffTestFiles, diffTestFile) |
| 754 | ctx.Phony(fmt.Sprintf("soong_generated_%s_filesystem_test", partitionType), diffTestFile) |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 755 | } |
| 756 | for _, partitionType := range f.properties.Unsupported_partition_types { |
Jihoon Kang | 72f812f | 2024-10-17 18:46:24 +0000 | [diff] [blame] | 757 | diffTestFile := createFailingCommand(ctx, fmt.Sprintf("Couldn't build %s partition", partitionType)) |
| 758 | diffTestFiles = append(diffTestFiles, diffTestFile) |
| 759 | ctx.Phony(fmt.Sprintf("soong_generated_%s_filesystem_test", partitionType), diffTestFile) |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 760 | } |
Cole Faust | 3552eb6 | 2024-11-06 18:07:26 -0800 | [diff] [blame] | 761 | for i, vbmetaModule := range f.properties.Vbmeta_module_names { |
| 762 | diffTestFile := createVbmetaDiff(ctx, vbmetaModule, f.properties.Vbmeta_partition_names[i]) |
| 763 | diffTestFiles = append(diffTestFiles, diffTestFile) |
| 764 | ctx.Phony(fmt.Sprintf("soong_generated_%s_filesystem_test", f.properties.Vbmeta_partition_names[i]), diffTestFile) |
| 765 | } |
Cole Faust | f2a6e8b | 2024-11-14 10:54:48 -0800 | [diff] [blame] | 766 | if f.properties.Boot_image != "" { |
| 767 | diffTestFile := android.PathForModuleOut(ctx, "boot_diff_test.txt") |
| 768 | soongBootImg := android.PathForModuleSrc(ctx, f.properties.Boot_image) |
| 769 | makeBootImage := android.PathForArbitraryOutput(ctx, fmt.Sprintf("target/product/%s/boot.img", ctx.Config().DeviceName())) |
| 770 | createDiffTest(ctx, diffTestFile, soongBootImg, makeBootImage) |
| 771 | diffTestFiles = append(diffTestFiles, diffTestFile) |
| 772 | ctx.Phony("soong_generated_boot_filesystem_test", diffTestFile) |
| 773 | } |
Cole Faust | 24938e2 | 2024-11-18 14:01:58 -0800 | [diff] [blame] | 774 | if f.properties.Vendor_boot_image != "" { |
| 775 | diffTestFile := android.PathForModuleOut(ctx, "vendor_boot_diff_test.txt") |
Jihoon Kang | 95eb1da | 2024-11-19 20:55:20 +0000 | [diff] [blame] | 776 | soongBootImg := android.PathForModuleSrc(ctx, f.properties.Vendor_boot_image) |
Cole Faust | 24938e2 | 2024-11-18 14:01:58 -0800 | [diff] [blame] | 777 | makeBootImage := android.PathForArbitraryOutput(ctx, fmt.Sprintf("target/product/%s/vendor_boot.img", ctx.Config().DeviceName())) |
| 778 | createDiffTest(ctx, diffTestFile, soongBootImg, makeBootImage) |
| 779 | diffTestFiles = append(diffTestFiles, diffTestFile) |
| 780 | ctx.Phony("soong_generated_vendor_boot_filesystem_test", diffTestFile) |
| 781 | } |
Jihoon Kang | 95eb1da | 2024-11-19 20:55:20 +0000 | [diff] [blame] | 782 | if f.properties.Init_boot_image != "" { |
| 783 | diffTestFile := android.PathForModuleOut(ctx, "init_boot_diff_test.txt") |
| 784 | soongBootImg := android.PathForModuleSrc(ctx, f.properties.Init_boot_image) |
| 785 | makeBootImage := android.PathForArbitraryOutput(ctx, fmt.Sprintf("target/product/%s/init_boot.img", ctx.Config().DeviceName())) |
| 786 | createDiffTest(ctx, diffTestFile, soongBootImg, makeBootImage) |
| 787 | diffTestFiles = append(diffTestFiles, diffTestFile) |
| 788 | ctx.Phony("soong_generated_init_boot_filesystem_test", diffTestFile) |
| 789 | } |
Cole Faust | 92ccbe2 | 2024-10-03 14:38:37 -0700 | [diff] [blame] | 790 | ctx.Phony("soong_generated_filesystem_tests", diffTestFiles...) |
Jihoon Kang | 98047cf | 2024-10-02 17:13:54 +0000 | [diff] [blame] | 791 | } |
mrziwang | 8f86c88 | 2024-10-03 12:34:33 -0700 | [diff] [blame] | 792 | |
mrziwang | 8f86c88 | 2024-10-03 12:34:33 -0700 | [diff] [blame] | 793 | func generateBpContent(ctx android.EarlyModuleContext, partitionType string) string { |
mrziwang | 4b0ca97 | 2024-10-17 14:56:19 -0700 | [diff] [blame] | 794 | fsProps, fsTypeSupported := generateFsProps(ctx, partitionType) |
| 795 | if !fsTypeSupported { |
| 796 | return "" |
mrziwang | 8f86c88 | 2024-10-03 12:34:33 -0700 | [diff] [blame] | 797 | } |
| 798 | |
mrziwang | 4b0ca97 | 2024-10-17 14:56:19 -0700 | [diff] [blame] | 799 | baseProps := generateBaseProps(proptools.StringPtr(generatedModuleNameForPartition(ctx.Config(), partitionType))) |
Jihoon Kang | 0d7b011 | 2024-11-13 20:44:05 +0000 | [diff] [blame] | 800 | fsGenState := ctx.Config().Get(fsGenStateOnceKey).(*FsGenState) |
| 801 | deps := fsGenState.fsDeps[partitionType] |
| 802 | highPriorityDeps := fsGenState.generatedPrebuiltEtcModuleNames |
| 803 | depProps := generateDepStruct(*deps, highPriorityDeps) |
mrziwang | 8f86c88 | 2024-10-03 12:34:33 -0700 | [diff] [blame] | 804 | |
mrziwang | 4b0ca97 | 2024-10-17 14:56:19 -0700 | [diff] [blame] | 805 | result, err := proptools.RepackProperties([]interface{}{baseProps, fsProps, depProps}) |
mrziwang | 8f86c88 | 2024-10-03 12:34:33 -0700 | [diff] [blame] | 806 | if err != nil { |
Cole Faust | ae3e1d3 | 2024-11-05 13:22:50 -0800 | [diff] [blame] | 807 | ctx.ModuleErrorf("%s", err.Error()) |
| 808 | return "" |
mrziwang | 8f86c88 | 2024-10-03 12:34:33 -0700 | [diff] [blame] | 809 | } |
| 810 | |
Jihoon Kang | 4e5d8de | 2024-10-19 01:59:58 +0000 | [diff] [blame] | 811 | moduleType := "android_filesystem" |
| 812 | if partitionType == "system" { |
| 813 | moduleType = "android_system_image" |
| 814 | } |
| 815 | |
mrziwang | 8f86c88 | 2024-10-03 12:34:33 -0700 | [diff] [blame] | 816 | file := &parser.File{ |
| 817 | Defs: []parser.Definition{ |
| 818 | &parser.Module{ |
Jihoon Kang | 4e5d8de | 2024-10-19 01:59:58 +0000 | [diff] [blame] | 819 | Type: moduleType, |
mrziwang | 8f86c88 | 2024-10-03 12:34:33 -0700 | [diff] [blame] | 820 | Map: *result, |
| 821 | }, |
| 822 | }, |
| 823 | } |
| 824 | bytes, err := parser.Print(file) |
| 825 | if err != nil { |
| 826 | ctx.ModuleErrorf(err.Error()) |
| 827 | } |
| 828 | return strings.TrimSpace(string(bytes)) |
| 829 | } |