Liz Kammer | ea6666f | 2021-02-17 10:17:28 -0500 | [diff] [blame] | 1 | // Copyright 2021 Google Inc. All rights reserved. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
| 15 | package android |
| 16 | |
Liz Kammer | ba3ea16 | 2021-02-17 13:22:03 -0500 | [diff] [blame] | 17 | import ( |
Wei Li | bafb6d6 | 2021-12-10 03:14:59 -0800 | [diff] [blame] | 18 | "bufio" |
| 19 | "errors" |
Chris Parsons | 39a1697 | 2023-06-08 14:28:51 +0000 | [diff] [blame] | 20 | "fmt" |
Liz Kammer | ba3ea16 | 2021-02-17 13:22:03 -0500 | [diff] [blame] | 21 | "strings" |
| 22 | |
Chris Parsons | 39a1697 | 2023-06-08 14:28:51 +0000 | [diff] [blame] | 23 | "android/soong/ui/metrics/bp2build_metrics_proto" |
Liz Kammer | c86e094 | 2023-08-11 16:15:12 -0400 | [diff] [blame] | 24 | |
Liz Kammer | bdc6099 | 2021-02-24 16:55:11 -0500 | [diff] [blame] | 25 | "github.com/google/blueprint" |
Spandan Das | 6485242 | 2023-08-02 21:58:41 +0000 | [diff] [blame] | 26 | "github.com/google/blueprint/bootstrap" |
Liz Kammer | ba3ea16 | 2021-02-17 13:22:03 -0500 | [diff] [blame] | 27 | "github.com/google/blueprint/proptools" |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 28 | |
| 29 | "android/soong/android/allowlists" |
| 30 | ) |
| 31 | |
| 32 | const ( |
| 33 | // A sentinel value to be used as a key in Bp2BuildConfig for modules with |
| 34 | // no package path. This is also the module dir for top level Android.bp |
| 35 | // modules. |
| 36 | Bp2BuildTopLevel = "." |
Liz Kammer | ba3ea16 | 2021-02-17 13:22:03 -0500 | [diff] [blame] | 37 | ) |
| 38 | |
MarkDacek | f47e142 | 2023-04-19 16:47:36 +0000 | [diff] [blame] | 39 | type MixedBuildEnabledStatus int |
| 40 | |
| 41 | const ( |
| 42 | // This module can be mixed_built. |
| 43 | MixedBuildEnabled = iota |
| 44 | |
| 45 | // There is a technical incompatibility preventing this module from being |
| 46 | // bazel-analyzed. Note: the module might also be incompatible. |
| 47 | TechnicalIncompatibility |
| 48 | |
| 49 | // This module cannot be mixed_built due to some incompatibility with it |
| 50 | // that is not a platform incompatibility. Example: the module-type is not |
| 51 | // enabled, or is not bp2build-converted. |
| 52 | ModuleIncompatibility |
Liz Kammer | c13f785 | 2023-05-17 13:01:48 -0400 | [diff] [blame] | 53 | |
| 54 | // Missing dependencies. We can't query Bazel for modules if it has missing dependencies, there |
| 55 | // will be failures. |
| 56 | ModuleMissingDeps |
MarkDacek | f47e142 | 2023-04-19 16:47:36 +0000 | [diff] [blame] | 57 | ) |
| 58 | |
Yu Liu | 2aa806b | 2022-09-01 11:54:47 -0700 | [diff] [blame] | 59 | // FileGroupAsLibrary describes a filegroup module that is converted to some library |
| 60 | // such as aidl_library or proto_library. |
| 61 | type FileGroupAsLibrary interface { |
Vinh Tran | 444154d | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 62 | ShouldConvertToAidlLibrary(ctx BazelConversionPathContext) bool |
Yu Liu | 2aa806b | 2022-09-01 11:54:47 -0700 | [diff] [blame] | 63 | ShouldConvertToProtoLibrary(ctx BazelConversionPathContext) bool |
Vinh Tran | 444154d | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 64 | GetAidlLibraryLabel(ctx BazelConversionPathContext) string |
Yu Liu | 2aa806b | 2022-09-01 11:54:47 -0700 | [diff] [blame] | 65 | GetProtoLibraryLabel(ctx BazelConversionPathContext) string |
Vinh Tran | 444154d | 2022-08-16 13:10:31 -0400 | [diff] [blame] | 66 | } |
| 67 | |
Sasha Smundak | a095406 | 2022-08-02 18:23:58 -0700 | [diff] [blame] | 68 | type BazelConversionStatus struct { |
| 69 | // Information about _all_ bp2build targets generated by this module. Multiple targets are |
| 70 | // supported as Soong handles some things within a single target that we may choose to split into |
| 71 | // multiple targets, e.g. renderscript, protos, yacc within a cc module. |
| 72 | Bp2buildInfo []bp2buildInfo `blueprint:"mutated"` |
| 73 | |
| 74 | // UnconvertedBp2buildDep stores the module names of direct dependency that were not converted to |
| 75 | // Bazel |
| 76 | UnconvertedDeps []string `blueprint:"mutated"` |
| 77 | |
| 78 | // MissingBp2buildDep stores the module names of direct dependency that were not found |
| 79 | MissingDeps []string `blueprint:"mutated"` |
Chris Parsons | 39a1697 | 2023-06-08 14:28:51 +0000 | [diff] [blame] | 80 | |
| 81 | // If non-nil, indicates that the module could not be converted successfully |
| 82 | // with bp2build. This will describe the reason the module could not be converted. |
| 83 | UnconvertedReason *UnconvertedReason |
| 84 | } |
| 85 | |
| 86 | // The reason a module could not be converted to a BUILD target via bp2build. |
| 87 | // This should match bp2build_metrics_proto.UnconvertedReason, but omits private |
| 88 | // proto-related fields that prevent copying this struct. |
| 89 | type UnconvertedReason struct { |
| 90 | // Should correspond to a valid value in bp2build_metrics_proto.UnconvertedReasonType. |
| 91 | // A raw int is used here instead, because blueprint logic requires that all transitive |
| 92 | // fields of module definitions be primitives. |
| 93 | ReasonType int |
| 94 | Detail string |
Sasha Smundak | a095406 | 2022-08-02 18:23:58 -0700 | [diff] [blame] | 95 | } |
| 96 | |
Romain Jobredeaux | 8242b43 | 2023-05-04 10:16:26 -0400 | [diff] [blame] | 97 | type BazelModuleProperties struct { |
Jingwen Chen | 0181202 | 2021-11-19 14:29:43 +0000 | [diff] [blame] | 98 | // The label of the Bazel target replacing this Soong module. When run in conversion mode, this |
| 99 | // will import the handcrafted build target into the autogenerated file. Note: this may result in |
| 100 | // a conflict due to duplicate targets if bp2build_available is also set. |
| 101 | Label *string |
| 102 | |
| 103 | // If true, bp2build will generate the converted Bazel target for this module. Note: this may |
| 104 | // cause a conflict due to the duplicate targets if label is also set. |
| 105 | // |
| 106 | // This is a bool pointer to support tristates: true, false, not set. |
| 107 | // |
Sasha Smundak | 39a301c | 2022-12-29 17:11:49 -0800 | [diff] [blame] | 108 | // To opt in a module, set bazel_module: { bp2build_available: true } |
| 109 | // To opt out a module, set bazel_module: { bp2build_available: false } |
Jingwen Chen | 0181202 | 2021-11-19 14:29:43 +0000 | [diff] [blame] | 110 | // To defer the default setting for the directory, do not set the value. |
| 111 | Bp2build_available *bool |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 112 | |
| 113 | // CanConvertToBazel is set via InitBazelModule to indicate that a module type can be converted to |
| 114 | // Bazel with Bp2build. |
| 115 | CanConvertToBazel bool `blueprint:"mutated"` |
Jingwen Chen | 0181202 | 2021-11-19 14:29:43 +0000 | [diff] [blame] | 116 | } |
| 117 | |
Liz Kammer | ba3ea16 | 2021-02-17 13:22:03 -0500 | [diff] [blame] | 118 | // Properties contains common module properties for Bazel migration purposes. |
| 119 | type properties struct { |
Chris Parsons | 1bb58da | 2022-08-30 13:37:57 -0400 | [diff] [blame] | 120 | // In "Bazel mixed build" mode, this represents the Bazel target replacing |
Liz Kammer | ba3ea16 | 2021-02-17 13:22:03 -0500 | [diff] [blame] | 121 | // this Soong module. |
Romain Jobredeaux | 8242b43 | 2023-05-04 10:16:26 -0400 | [diff] [blame] | 122 | Bazel_module BazelModuleProperties |
Liz Kammer | ba3ea16 | 2021-02-17 13:22:03 -0500 | [diff] [blame] | 123 | } |
Liz Kammer | ea6666f | 2021-02-17 10:17:28 -0500 | [diff] [blame] | 124 | |
Jingwen Chen | 25825ca | 2021-11-15 12:28:43 +0000 | [diff] [blame] | 125 | // namespacedVariableProperties is a map from a string representing a Soong |
Jingwen Chen | 84817de | 2021-11-17 10:57:35 +0000 | [diff] [blame] | 126 | // config variable namespace, like "android" or "vendor_name" to a slice of |
| 127 | // pointer to a struct containing a single field called Soong_config_variables |
| 128 | // whose value mirrors the structure in the Blueprint file. |
| 129 | type namespacedVariableProperties map[string][]interface{} |
Jingwen Chen | a47f28d | 2021-11-02 16:43:57 +0000 | [diff] [blame] | 130 | |
Liz Kammer | ea6666f | 2021-02-17 10:17:28 -0500 | [diff] [blame] | 131 | // BazelModuleBase contains the property structs with metadata for modules which can be converted to |
| 132 | // Bazel. |
| 133 | type BazelModuleBase struct { |
Liz Kammer | ba3ea16 | 2021-02-17 13:22:03 -0500 | [diff] [blame] | 134 | bazelProperties properties |
Jingwen Chen | a47f28d | 2021-11-02 16:43:57 +0000 | [diff] [blame] | 135 | |
| 136 | // namespacedVariableProperties is used for soong_config_module_type support |
| 137 | // in bp2build. Soong config modules allow users to set module properties |
| 138 | // based on custom product variables defined in Android.bp files. These |
| 139 | // variables are namespaced to prevent clobbering, especially when set from |
| 140 | // Makefiles. |
| 141 | namespacedVariableProperties namespacedVariableProperties |
| 142 | |
| 143 | // baseModuleType is set when this module was created from a module type |
| 144 | // defined by a soong_config_module_type. Every soong_config_module_type |
| 145 | // "wraps" another module type, e.g. a soong_config_module_type can wrap a |
| 146 | // cc_defaults to a custom_cc_defaults, or cc_binary to a custom_cc_binary. |
| 147 | // This baseModuleType is set to the wrapped module type. |
| 148 | baseModuleType string |
Liz Kammer | ea6666f | 2021-02-17 10:17:28 -0500 | [diff] [blame] | 149 | } |
| 150 | |
| 151 | // Bazelable is specifies the interface for modules that can be converted to Bazel. |
| 152 | type Bazelable interface { |
Liz Kammer | ba3ea16 | 2021-02-17 13:22:03 -0500 | [diff] [blame] | 153 | bazelProps() *properties |
| 154 | HasHandcraftedLabel() bool |
Liz Kammer | bdc6099 | 2021-02-24 16:55:11 -0500 | [diff] [blame] | 155 | HandcraftedLabel() string |
| 156 | GetBazelLabel(ctx BazelConversionPathContext, module blueprint.Module) string |
Liz Kammer | c86e094 | 2023-08-11 16:15:12 -0400 | [diff] [blame] | 157 | ShouldConvertWithBp2build(ctx ShouldConvertWithBazelContext) bool |
| 158 | shouldConvertWithBp2build(shouldConvertModuleContext, shouldConvertParams) bool |
Chris Parsons | 39a1697 | 2023-06-08 14:28:51 +0000 | [diff] [blame] | 159 | |
| 160 | // ConvertWithBp2build either converts the module to a Bazel build target or |
| 161 | // declares the module as unconvertible (for logging and metrics). |
| 162 | // Modules must implement this function to be bp2build convertible. The function |
| 163 | // must either create at least one Bazel target module (using ctx.CreateBazelTargetModule or |
| 164 | // its related functions), or declare itself unconvertible using ctx.MarkBp2buildUnconvertible. |
Chris Parsons | 637458d | 2023-09-19 20:09:00 +0000 | [diff] [blame] | 165 | ConvertWithBp2build(ctx Bp2buildMutatorContext) |
Jingwen Chen | a47f28d | 2021-11-02 16:43:57 +0000 | [diff] [blame] | 166 | |
Jingwen Chen | 84817de | 2021-11-17 10:57:35 +0000 | [diff] [blame] | 167 | // namespacedVariableProps is a map from a soong config variable namespace |
| 168 | // (e.g. acme, android) to a map of interfaces{}, which are really |
| 169 | // reflect.Struct pointers, representing the value of the |
| 170 | // soong_config_variables property of a module. The struct pointer is the |
| 171 | // one with the single member called Soong_config_variables, which itself is |
| 172 | // a struct containing fields for each supported feature in that namespace. |
| 173 | // |
Sasha Smundak | 39a301c | 2022-12-29 17:11:49 -0800 | [diff] [blame] | 174 | // The reason for using a slice of interface{} is to support defaults |
Jingwen Chen | 84817de | 2021-11-17 10:57:35 +0000 | [diff] [blame] | 175 | // propagation of the struct pointers. |
Jingwen Chen | a47f28d | 2021-11-02 16:43:57 +0000 | [diff] [blame] | 176 | namespacedVariableProps() namespacedVariableProperties |
| 177 | setNamespacedVariableProps(props namespacedVariableProperties) |
| 178 | BaseModuleType() string |
Jingwen Chen | 84817de | 2021-11-17 10:57:35 +0000 | [diff] [blame] | 179 | SetBaseModuleType(baseModuleType string) |
Liz Kammer | ea6666f | 2021-02-17 10:17:28 -0500 | [diff] [blame] | 180 | } |
| 181 | |
Spandan Das | 5af0bd3 | 2022-09-28 20:43:08 +0000 | [diff] [blame] | 182 | // ApiProvider is implemented by modules that contribute to an API surface |
| 183 | type ApiProvider interface { |
| 184 | ConvertWithApiBp2build(ctx TopDownMutatorContext) |
| 185 | } |
| 186 | |
Chris Parsons | f874e46 | 2022-05-10 13:50:12 -0400 | [diff] [blame] | 187 | // MixedBuildBuildable is an interface that module types should implement in order |
| 188 | // to be "handled by Bazel" in a mixed build. |
| 189 | type MixedBuildBuildable interface { |
| 190 | // IsMixedBuildSupported returns true if and only if this module should be |
| 191 | // "handled by Bazel" in a mixed build. |
| 192 | // This "escape hatch" allows modules with corner-case scenarios to opt out |
| 193 | // of being built with Bazel. |
| 194 | IsMixedBuildSupported(ctx BaseModuleContext) bool |
| 195 | |
| 196 | // QueueBazelCall invokes request-queueing functions on the BazelContext |
| 197 | // so that these requests are handled when Bazel's cquery is invoked. |
| 198 | QueueBazelCall(ctx BaseModuleContext) |
| 199 | |
| 200 | // ProcessBazelQueryResponse uses Bazel information (obtained from the BazelContext) |
| 201 | // to set module fields and providers to propagate this module's metadata upstream. |
| 202 | // This effectively "bridges the gap" between Bazel and Soong in a mixed build. |
| 203 | // Soong modules depending on this module should be oblivious to the fact that |
| 204 | // this module was handled by Bazel. |
| 205 | ProcessBazelQueryResponse(ctx ModuleContext) |
| 206 | } |
| 207 | |
Liz Kammer | ea6666f | 2021-02-17 10:17:28 -0500 | [diff] [blame] | 208 | // BazelModule is a lightweight wrapper interface around Module for Bazel-convertible modules. |
| 209 | type BazelModule interface { |
| 210 | Module |
| 211 | Bazelable |
| 212 | } |
| 213 | |
| 214 | // InitBazelModule is a wrapper function that decorates a BazelModule with Bazel-conversion |
| 215 | // properties. |
| 216 | func InitBazelModule(module BazelModule) { |
| 217 | module.AddProperties(module.bazelProps()) |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 218 | module.bazelProps().Bazel_module.CanConvertToBazel = true |
Liz Kammer | ea6666f | 2021-02-17 10:17:28 -0500 | [diff] [blame] | 219 | } |
| 220 | |
Chris Parsons | 2173b5f | 2023-09-25 19:01:40 +0000 | [diff] [blame] | 221 | // BazelHandcraftedHook is a load hook to possibly register the current module as |
| 222 | // a "handcrafted" Bazel target of a given name. If the current module should be |
| 223 | // registered in this way, the hook function should return the target name. If |
| 224 | // it should not be registered in this way, this function should return the empty string. |
| 225 | type BazelHandcraftedHook func(ctx LoadHookContext) string |
| 226 | |
| 227 | // AddBazelHandcraftedHook adds a load hook to (maybe) mark the given module so that |
| 228 | // it is treated by bp2build as if it has a handcrafted Bazel target. |
| 229 | func AddBazelHandcraftedHook(module BazelModule, hook BazelHandcraftedHook) { |
| 230 | AddLoadHook(module, func(ctx LoadHookContext) { |
| 231 | var targetName string = hook(ctx) |
| 232 | if len(targetName) > 0 { |
| 233 | moduleDir := ctx.ModuleDir() |
| 234 | if moduleDir == Bp2BuildTopLevel { |
| 235 | moduleDir = "" |
| 236 | } |
| 237 | label := fmt.Sprintf("//%s:%s", moduleDir, targetName) |
| 238 | module.bazelProps().Bazel_module.Label = &label |
| 239 | } |
| 240 | }) |
| 241 | } |
| 242 | |
Liz Kammer | ea6666f | 2021-02-17 10:17:28 -0500 | [diff] [blame] | 243 | // bazelProps returns the Bazel properties for the given BazelModuleBase. |
Liz Kammer | ba3ea16 | 2021-02-17 13:22:03 -0500 | [diff] [blame] | 244 | func (b *BazelModuleBase) bazelProps() *properties { |
Liz Kammer | ea6666f | 2021-02-17 10:17:28 -0500 | [diff] [blame] | 245 | return &b.bazelProperties |
| 246 | } |
| 247 | |
Jingwen Chen | a47f28d | 2021-11-02 16:43:57 +0000 | [diff] [blame] | 248 | func (b *BazelModuleBase) namespacedVariableProps() namespacedVariableProperties { |
| 249 | return b.namespacedVariableProperties |
| 250 | } |
| 251 | |
| 252 | func (b *BazelModuleBase) setNamespacedVariableProps(props namespacedVariableProperties) { |
| 253 | b.namespacedVariableProperties = props |
| 254 | } |
| 255 | |
| 256 | func (b *BazelModuleBase) BaseModuleType() string { |
| 257 | return b.baseModuleType |
| 258 | } |
| 259 | |
| 260 | func (b *BazelModuleBase) SetBaseModuleType(baseModuleType string) { |
| 261 | b.baseModuleType = baseModuleType |
| 262 | } |
| 263 | |
Liz Kammer | ba3ea16 | 2021-02-17 13:22:03 -0500 | [diff] [blame] | 264 | // HasHandcraftedLabel returns whether this module has a handcrafted Bazel label. |
| 265 | func (b *BazelModuleBase) HasHandcraftedLabel() bool { |
| 266 | return b.bazelProperties.Bazel_module.Label != nil |
| 267 | } |
| 268 | |
| 269 | // HandcraftedLabel returns the handcrafted label for this module, or empty string if there is none |
| 270 | func (b *BazelModuleBase) HandcraftedLabel() string { |
| 271 | return proptools.String(b.bazelProperties.Bazel_module.Label) |
| 272 | } |
| 273 | |
Liz Kammer | ea6666f | 2021-02-17 10:17:28 -0500 | [diff] [blame] | 274 | // GetBazelLabel returns the Bazel label for the given BazelModuleBase. |
Liz Kammer | bdc6099 | 2021-02-24 16:55:11 -0500 | [diff] [blame] | 275 | func (b *BazelModuleBase) GetBazelLabel(ctx BazelConversionPathContext, module blueprint.Module) string { |
| 276 | if b.HasHandcraftedLabel() { |
| 277 | return b.HandcraftedLabel() |
| 278 | } |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 279 | if b.ShouldConvertWithBp2build(ctx) { |
Liz Kammer | bdc6099 | 2021-02-24 16:55:11 -0500 | [diff] [blame] | 280 | return bp2buildModuleLabel(ctx, module) |
| 281 | } |
Spandan Das | 5b18c0c | 2023-07-14 00:23:29 +0000 | [diff] [blame] | 282 | panic(fmt.Errorf("requested non-existent label for module %s", module.Name())) |
Liz Kammer | ea6666f | 2021-02-17 10:17:28 -0500 | [diff] [blame] | 283 | } |
| 284 | |
Cole Faust | 324a92e | 2022-08-23 15:29:05 -0700 | [diff] [blame] | 285 | type Bp2BuildConversionAllowlist struct { |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 286 | // Configure modules in these directories to enable bp2build_available: true or false by default. |
| 287 | defaultConfig allowlists.Bp2BuildConfig |
Jingwen Chen | 12b4c27 | 2021-03-10 02:05:59 -0500 | [diff] [blame] | 288 | |
Rupert Shuttleworth | 0096079 | 2021-05-12 21:20:13 -0400 | [diff] [blame] | 289 | // Keep any existing BUILD files (and do not generate new BUILD files) for these directories |
Jingwen Chen | b643c7a | 2021-07-26 04:45:48 +0000 | [diff] [blame] | 290 | // in the synthetic Bazel workspace. |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 291 | keepExistingBuildFile map[string]bool |
Jingwen Chen | 5d72cba | 2021-03-25 09:28:38 +0000 | [diff] [blame] | 292 | |
Chris Parsons | ef615e5 | 2022-08-18 22:04:11 -0400 | [diff] [blame] | 293 | // Per-module allowlist to always opt modules into both bp2build and Bazel Dev Mode mixed |
| 294 | // builds. These modules are usually in directories with many other modules that are not ready |
| 295 | // for conversion. |
Jingwen Chen | 7edadab | 2022-03-04 07:01:29 +0000 | [diff] [blame] | 296 | // |
| 297 | // A module can either be in this list or its directory allowlisted entirely |
| 298 | // in bp2buildDefaultConfig, but not both at the same time. |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 299 | moduleAlwaysConvert map[string]bool |
Sam Delmerico | fa1831c | 2022-02-22 18:07:55 +0000 | [diff] [blame] | 300 | |
Chris Parsons | ef615e5 | 2022-08-18 22:04:11 -0400 | [diff] [blame] | 301 | // Per-module-type allowlist to always opt modules in to both bp2build and |
| 302 | // Bazel Dev Mode mixed builds when they have the same type as one listed. |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 303 | moduleTypeAlwaysConvert map[string]bool |
Sam Delmerico | 85d831a | 2022-03-07 19:12:42 +0000 | [diff] [blame] | 304 | |
Chris Parsons | ad87601 | 2022-08-20 14:48:32 -0400 | [diff] [blame] | 305 | // Per-module denylist to always opt modules out of bp2build conversion. |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 306 | moduleDoNotConvert map[string]bool |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 307 | } |
Liz Kammer | 5c31358 | 2021-12-03 15:23:26 -0500 | [diff] [blame] | 308 | |
Cole Faust | 324a92e | 2022-08-23 15:29:05 -0700 | [diff] [blame] | 309 | // NewBp2BuildAllowlist creates a new, empty Bp2BuildConversionAllowlist |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 310 | // which can be populated using builder pattern Set* methods |
Cole Faust | 324a92e | 2022-08-23 15:29:05 -0700 | [diff] [blame] | 311 | func NewBp2BuildAllowlist() Bp2BuildConversionAllowlist { |
| 312 | return Bp2BuildConversionAllowlist{ |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 313 | allowlists.Bp2BuildConfig{}, |
| 314 | map[string]bool{}, |
| 315 | map[string]bool{}, |
| 316 | map[string]bool{}, |
| 317 | map[string]bool{}, |
Chris Parsons | bab4d7e | 2021-04-15 17:27:08 -0400 | [diff] [blame] | 318 | } |
| 319 | } |
| 320 | |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 321 | // SetDefaultConfig copies the entries from defaultConfig into the allowlist |
Cole Faust | 324a92e | 2022-08-23 15:29:05 -0700 | [diff] [blame] | 322 | func (a Bp2BuildConversionAllowlist) SetDefaultConfig(defaultConfig allowlists.Bp2BuildConfig) Bp2BuildConversionAllowlist { |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 323 | if a.defaultConfig == nil { |
| 324 | a.defaultConfig = allowlists.Bp2BuildConfig{} |
| 325 | } |
| 326 | for k, v := range defaultConfig { |
| 327 | a.defaultConfig[k] = v |
| 328 | } |
| 329 | |
| 330 | return a |
| 331 | } |
| 332 | |
| 333 | // SetKeepExistingBuildFile copies the entries from keepExistingBuildFile into the allowlist |
Cole Faust | 324a92e | 2022-08-23 15:29:05 -0700 | [diff] [blame] | 334 | func (a Bp2BuildConversionAllowlist) SetKeepExistingBuildFile(keepExistingBuildFile map[string]bool) Bp2BuildConversionAllowlist { |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 335 | if a.keepExistingBuildFile == nil { |
| 336 | a.keepExistingBuildFile = map[string]bool{} |
| 337 | } |
| 338 | for k, v := range keepExistingBuildFile { |
| 339 | a.keepExistingBuildFile[k] = v |
| 340 | } |
| 341 | |
| 342 | return a |
| 343 | } |
| 344 | |
| 345 | // SetModuleAlwaysConvertList copies the entries from moduleAlwaysConvert into the allowlist |
Cole Faust | 324a92e | 2022-08-23 15:29:05 -0700 | [diff] [blame] | 346 | func (a Bp2BuildConversionAllowlist) SetModuleAlwaysConvertList(moduleAlwaysConvert []string) Bp2BuildConversionAllowlist { |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 347 | if a.moduleAlwaysConvert == nil { |
| 348 | a.moduleAlwaysConvert = map[string]bool{} |
| 349 | } |
| 350 | for _, m := range moduleAlwaysConvert { |
| 351 | a.moduleAlwaysConvert[m] = true |
| 352 | } |
| 353 | |
| 354 | return a |
| 355 | } |
| 356 | |
| 357 | // SetModuleTypeAlwaysConvertList copies the entries from moduleTypeAlwaysConvert into the allowlist |
Cole Faust | 324a92e | 2022-08-23 15:29:05 -0700 | [diff] [blame] | 358 | func (a Bp2BuildConversionAllowlist) SetModuleTypeAlwaysConvertList(moduleTypeAlwaysConvert []string) Bp2BuildConversionAllowlist { |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 359 | if a.moduleTypeAlwaysConvert == nil { |
| 360 | a.moduleTypeAlwaysConvert = map[string]bool{} |
| 361 | } |
| 362 | for _, m := range moduleTypeAlwaysConvert { |
| 363 | a.moduleTypeAlwaysConvert[m] = true |
| 364 | } |
| 365 | |
| 366 | return a |
| 367 | } |
| 368 | |
| 369 | // SetModuleDoNotConvertList copies the entries from moduleDoNotConvert into the allowlist |
Cole Faust | 324a92e | 2022-08-23 15:29:05 -0700 | [diff] [blame] | 370 | func (a Bp2BuildConversionAllowlist) SetModuleDoNotConvertList(moduleDoNotConvert []string) Bp2BuildConversionAllowlist { |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 371 | if a.moduleDoNotConvert == nil { |
| 372 | a.moduleDoNotConvert = map[string]bool{} |
| 373 | } |
| 374 | for _, m := range moduleDoNotConvert { |
| 375 | a.moduleDoNotConvert[m] = true |
| 376 | } |
| 377 | |
| 378 | return a |
| 379 | } |
| 380 | |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 381 | // ShouldKeepExistingBuildFileForDir returns whether an existing BUILD file should be |
| 382 | // added to the build symlink forest based on the current global configuration. |
Cole Faust | 324a92e | 2022-08-23 15:29:05 -0700 | [diff] [blame] | 383 | func (a Bp2BuildConversionAllowlist) ShouldKeepExistingBuildFileForDir(dir string) bool { |
| 384 | if _, ok := a.keepExistingBuildFile[dir]; ok { |
Rupert Shuttleworth | 0096079 | 2021-05-12 21:20:13 -0400 | [diff] [blame] | 385 | // Exact dir match |
Rupert Shuttleworth | 2a4fc3e | 2021-04-21 07:10:09 -0400 | [diff] [blame] | 386 | return true |
| 387 | } |
Usta Shrestha | ea99964 | 2022-11-02 01:03:07 -0400 | [diff] [blame] | 388 | var i int |
Rupert Shuttleworth | 0096079 | 2021-05-12 21:20:13 -0400 | [diff] [blame] | 389 | // Check if subtree match |
Usta Shrestha | ea99964 | 2022-11-02 01:03:07 -0400 | [diff] [blame] | 390 | for { |
| 391 | j := strings.Index(dir[i:], "/") |
| 392 | if j == -1 { |
| 393 | return false //default |
| 394 | } |
| 395 | prefix := dir[0 : i+j] |
| 396 | i = i + j + 1 // skip the "/" |
| 397 | if recursive, ok := a.keepExistingBuildFile[prefix]; ok && recursive { |
| 398 | return true |
Rupert Shuttleworth | 0096079 | 2021-05-12 21:20:13 -0400 | [diff] [blame] | 399 | } |
| 400 | } |
Rupert Shuttleworth | 2a4fc3e | 2021-04-21 07:10:09 -0400 | [diff] [blame] | 401 | } |
| 402 | |
Cole Faust | 324a92e | 2022-08-23 15:29:05 -0700 | [diff] [blame] | 403 | var bp2BuildAllowListKey = NewOnceKey("Bp2BuildAllowlist") |
| 404 | var bp2buildAllowlist OncePer |
| 405 | |
| 406 | func GetBp2BuildAllowList() Bp2BuildConversionAllowlist { |
| 407 | return bp2buildAllowlist.Once(bp2BuildAllowListKey, func() interface{} { |
| 408 | return NewBp2BuildAllowlist().SetDefaultConfig(allowlists.Bp2buildDefaultConfig). |
| 409 | SetKeepExistingBuildFile(allowlists.Bp2buildKeepExistingBuildFile). |
| 410 | SetModuleAlwaysConvertList(allowlists.Bp2buildModuleAlwaysConvertList). |
| 411 | SetModuleTypeAlwaysConvertList(allowlists.Bp2buildModuleTypeAlwaysConvertList). |
Sasha Smundak | 39a301c | 2022-12-29 17:11:49 -0800 | [diff] [blame] | 412 | SetModuleDoNotConvertList(allowlists.Bp2buildModuleDoNotConvertList) |
Cole Faust | 324a92e | 2022-08-23 15:29:05 -0700 | [diff] [blame] | 413 | }).(Bp2BuildConversionAllowlist) |
| 414 | } |
| 415 | |
MarkDacek | f47e142 | 2023-04-19 16:47:36 +0000 | [diff] [blame] | 416 | // MixedBuildsEnabled returns a MixedBuildEnabledStatus regarding whether |
| 417 | // a module is ready to be replaced by a converted or handcrafted Bazel target. |
| 418 | // As a side effect, calling this method will also log whether this module is |
| 419 | // mixed build enabled for metrics reporting. |
| 420 | func MixedBuildsEnabled(ctx BaseModuleContext) MixedBuildEnabledStatus { |
MarkDacek | f47e142 | 2023-04-19 16:47:36 +0000 | [diff] [blame] | 421 | platformIncompatible := isPlatformIncompatible(ctx.Os(), ctx.Arch().ArchType) |
| 422 | if platformIncompatible { |
| 423 | ctx.Config().LogMixedBuild(ctx, false) |
| 424 | return TechnicalIncompatibility |
| 425 | } |
| 426 | |
Liz Kammer | c13f785 | 2023-05-17 13:01:48 -0400 | [diff] [blame] | 427 | if ctx.Config().AllowMissingDependencies() { |
| 428 | missingDeps := ctx.getMissingDependencies() |
| 429 | // If there are missing dependencies, querying Bazel will fail. Soong instead fails at execution |
| 430 | // time, not loading/analysis. disable mixed builds and fall back to Soong to maintain that |
| 431 | // behavior. |
| 432 | if len(missingDeps) > 0 { |
| 433 | ctx.Config().LogMixedBuild(ctx, false) |
| 434 | return ModuleMissingDeps |
| 435 | } |
| 436 | } |
| 437 | |
| 438 | module := ctx.Module() |
| 439 | apexInfo := ctx.Provider(ApexInfoProvider).(ApexInfo) |
| 440 | withinApex := !apexInfo.IsForPlatform() |
Sasha Smundak | 39a301c | 2022-12-29 17:11:49 -0800 | [diff] [blame] | 441 | mixedBuildEnabled := ctx.Config().IsMixedBuildsEnabled() && |
Sasha Smundak | 39a301c | 2022-12-29 17:11:49 -0800 | [diff] [blame] | 442 | module.Enabled() && |
| 443 | convertedToBazel(ctx, module) && |
Yu Liu | e431240 | 2023-01-18 09:15:31 -0800 | [diff] [blame] | 444 | ctx.Config().BazelContext.IsModuleNameAllowed(module.Name(), withinApex) |
MarkDacek | ff851b8 | 2022-04-21 18:33:17 +0000 | [diff] [blame] | 445 | ctx.Config().LogMixedBuild(ctx, mixedBuildEnabled) |
MarkDacek | f47e142 | 2023-04-19 16:47:36 +0000 | [diff] [blame] | 446 | |
| 447 | if mixedBuildEnabled { |
| 448 | return MixedBuildEnabled |
| 449 | } |
| 450 | return ModuleIncompatibility |
MarkDacek | ff851b8 | 2022-04-21 18:33:17 +0000 | [diff] [blame] | 451 | } |
| 452 | |
Spandan Das | 6485242 | 2023-08-02 21:58:41 +0000 | [diff] [blame] | 453 | func isGoModule(module blueprint.Module) bool { |
| 454 | if _, ok := module.(*bootstrap.GoPackage); ok { |
| 455 | return true |
| 456 | } |
| 457 | if _, ok := module.(*bootstrap.GoBinary); ok { |
| 458 | return true |
| 459 | } |
| 460 | return false |
| 461 | } |
| 462 | |
Liz Kammer | 6eff323 | 2021-08-26 08:37:59 -0400 | [diff] [blame] | 463 | // ConvertedToBazel returns whether this module has been converted (with bp2build or manually) to Bazel. |
Jingwen Chen | 55bc820 | 2021-11-02 06:40:51 +0000 | [diff] [blame] | 464 | func convertedToBazel(ctx BazelConversionContext, module blueprint.Module) bool { |
Spandan Das | 6485242 | 2023-08-02 21:58:41 +0000 | [diff] [blame] | 465 | // Special-case bootstrap_go_package and bootstrap_go_binary |
| 466 | // These do not implement Bazelable, but have been converted |
| 467 | if isGoModule(module) { |
| 468 | return true |
| 469 | } |
Liz Kammer | 6eff323 | 2021-08-26 08:37:59 -0400 | [diff] [blame] | 470 | b, ok := module.(Bazelable) |
| 471 | if !ok { |
| 472 | return false |
| 473 | } |
Liz Kammer | c86e094 | 2023-08-11 16:15:12 -0400 | [diff] [blame] | 474 | |
| 475 | return b.HasHandcraftedLabel() || b.shouldConvertWithBp2build(ctx, shouldConvertParams{ |
| 476 | module: module, |
| 477 | moduleDir: ctx.OtherModuleDir(module), |
| 478 | moduleName: ctx.OtherModuleName(module), |
| 479 | moduleType: ctx.OtherModuleType(module), |
| 480 | }) |
| 481 | } |
| 482 | |
| 483 | type ShouldConvertWithBazelContext interface { |
| 484 | ModuleErrorf(format string, args ...interface{}) |
| 485 | Module() Module |
| 486 | Config() Config |
| 487 | ModuleType() string |
| 488 | ModuleName() string |
| 489 | ModuleDir() string |
Liz Kammer | 6eff323 | 2021-08-26 08:37:59 -0400 | [diff] [blame] | 490 | } |
| 491 | |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 492 | // ShouldConvertWithBp2build returns whether the given BazelModuleBase should be converted with bp2build |
Liz Kammer | c86e094 | 2023-08-11 16:15:12 -0400 | [diff] [blame] | 493 | func (b *BazelModuleBase) ShouldConvertWithBp2build(ctx ShouldConvertWithBazelContext) bool { |
| 494 | return b.shouldConvertWithBp2build(ctx, shouldConvertParams{ |
| 495 | module: ctx.Module(), |
| 496 | moduleDir: ctx.ModuleDir(), |
| 497 | moduleName: ctx.ModuleName(), |
| 498 | moduleType: ctx.ModuleType(), |
| 499 | }) |
Liz Kammer | 6eff323 | 2021-08-26 08:37:59 -0400 | [diff] [blame] | 500 | } |
| 501 | |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 502 | type bazelOtherModuleContext interface { |
| 503 | ModuleErrorf(format string, args ...interface{}) |
| 504 | Config() Config |
| 505 | OtherModuleType(m blueprint.Module) string |
| 506 | OtherModuleName(m blueprint.Module) string |
| 507 | OtherModuleDir(m blueprint.Module) string |
| 508 | } |
Sam Delmerico | fa1831c | 2022-02-22 18:07:55 +0000 | [diff] [blame] | 509 | |
MarkDacek | f47e142 | 2023-04-19 16:47:36 +0000 | [diff] [blame] | 510 | func isPlatformIncompatible(osType OsType, arch ArchType) bool { |
| 511 | return osType == Windows || // Windows toolchains are not currently supported. |
| 512 | osType == LinuxBionic || // Linux Bionic toolchains are not currently supported. |
| 513 | osType == LinuxMusl || // Linux musl toolchains are not currently supported (b/259266326). |
| 514 | arch == Riscv64 // TODO(b/262192655) Riscv64 toolchains are not currently supported. |
| 515 | } |
| 516 | |
Liz Kammer | c86e094 | 2023-08-11 16:15:12 -0400 | [diff] [blame] | 517 | type shouldConvertModuleContext interface { |
| 518 | ModuleErrorf(format string, args ...interface{}) |
| 519 | Config() Config |
| 520 | } |
| 521 | |
| 522 | type shouldConvertParams struct { |
| 523 | module blueprint.Module |
| 524 | moduleType string |
| 525 | moduleDir string |
| 526 | moduleName string |
| 527 | } |
| 528 | |
| 529 | func (b *BazelModuleBase) shouldConvertWithBp2build(ctx shouldConvertModuleContext, p shouldConvertParams) bool { |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 530 | if !b.bazelProps().Bazel_module.CanConvertToBazel { |
| 531 | return false |
Jingwen Chen | 12b4c27 | 2021-03-10 02:05:59 -0500 | [diff] [blame] | 532 | } |
| 533 | |
Liz Kammer | c86e094 | 2023-08-11 16:15:12 -0400 | [diff] [blame] | 534 | module := p.module |
Spandan Das | 5af0bd3 | 2022-09-28 20:43:08 +0000 | [diff] [blame] | 535 | |
Sam Delmerico | 85d831a | 2022-03-07 19:12:42 +0000 | [diff] [blame] | 536 | propValue := b.bazelProperties.Bazel_module.Bp2build_available |
Liz Kammer | c86e094 | 2023-08-11 16:15:12 -0400 | [diff] [blame] | 537 | packagePath := moduleDirWithPossibleOverride(ctx, module, p.moduleDir) |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 538 | |
Sam Delmerico | 85d831a | 2022-03-07 19:12:42 +0000 | [diff] [blame] | 539 | // Modules in unit tests which are enabled in the allowlist by type or name |
| 540 | // trigger this conditional because unit tests run under the "." package path |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 541 | isTestModule := packagePath == Bp2BuildTopLevel && proptools.BoolDefault(propValue, false) |
| 542 | if isTestModule { |
| 543 | return true |
| 544 | } |
| 545 | |
Liz Kammer | c86e094 | 2023-08-11 16:15:12 -0400 | [diff] [blame] | 546 | moduleName := moduleNameWithPossibleOverride(ctx, module, p.moduleName) |
Cole Faust | 324a92e | 2022-08-23 15:29:05 -0700 | [diff] [blame] | 547 | allowlist := ctx.Config().Bp2buildPackageConfig |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 548 | moduleNameAllowed := allowlist.moduleAlwaysConvert[moduleName] |
Liz Kammer | c86e094 | 2023-08-11 16:15:12 -0400 | [diff] [blame] | 549 | moduleTypeAllowed := allowlist.moduleTypeAlwaysConvert[p.moduleType] |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 550 | allowlistConvert := moduleNameAllowed || moduleTypeAllowed |
| 551 | if moduleNameAllowed && moduleTypeAllowed { |
Sam Delmerico | e42edc3 | 2023-09-05 19:00:38 +0000 | [diff] [blame] | 552 | ctx.ModuleErrorf("A module %q of type %q cannot be in moduleAlwaysConvert and also be in moduleTypeAlwaysConvert", moduleName, p.moduleType) |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 553 | return false |
| 554 | } |
| 555 | |
| 556 | if allowlist.moduleDoNotConvert[moduleName] { |
Sam Delmerico | 85d831a | 2022-03-07 19:12:42 +0000 | [diff] [blame] | 557 | if moduleNameAllowed { |
Sam Delmerico | e42edc3 | 2023-09-05 19:00:38 +0000 | [diff] [blame] | 558 | ctx.ModuleErrorf("a module %q cannot be in moduleDoNotConvert and also be in moduleAlwaysConvert", moduleName) |
Sam Delmerico | 85d831a | 2022-03-07 19:12:42 +0000 | [diff] [blame] | 559 | } |
Sam Delmerico | 94d26c2 | 2022-02-25 21:34:51 +0000 | [diff] [blame] | 560 | return false |
| 561 | } |
| 562 | |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 563 | // This is a tristate value: true, false, or unset. |
| 564 | if ok, directoryPath := bp2buildDefaultTrueRecursively(packagePath, allowlist.defaultConfig); ok { |
| 565 | if moduleNameAllowed { |
| 566 | ctx.ModuleErrorf("A module cannot be in a directory marked Bp2BuildDefaultTrue"+ |
Yu Liu | 10853f9 | 2022-09-14 16:05:22 -0700 | [diff] [blame] | 567 | " or Bp2BuildDefaultTrueRecursively and also be in moduleAlwaysConvert. Directory: '%s'"+ |
| 568 | " Module: '%s'", directoryPath, moduleName) |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 569 | return false |
Sam Delmerico | fa1831c | 2022-02-22 18:07:55 +0000 | [diff] [blame] | 570 | } |
| 571 | |
Jingwen Chen | 12b4c27 | 2021-03-10 02:05:59 -0500 | [diff] [blame] | 572 | // Allow modules to explicitly opt-out. |
| 573 | return proptools.BoolDefault(propValue, true) |
| 574 | } |
| 575 | |
| 576 | // Allow modules to explicitly opt-in. |
Sam Delmerico | 85d831a | 2022-03-07 19:12:42 +0000 | [diff] [blame] | 577 | return proptools.BoolDefault(propValue, allowlistConvert) |
Jingwen Chen | 12b4c27 | 2021-03-10 02:05:59 -0500 | [diff] [blame] | 578 | } |
| 579 | |
| 580 | // bp2buildDefaultTrueRecursively checks that the package contains a prefix from the |
| 581 | // set of package prefixes where all modules must be converted. That is, if the |
| 582 | // package is x/y/z, and the list contains either x, x/y, or x/y/z, this function will |
| 583 | // return true. |
| 584 | // |
| 585 | // However, if the package is x/y, and it matches a Bp2BuildDefaultFalse "x/y" entry |
| 586 | // exactly, this module will return false early. |
| 587 | // |
| 588 | // This function will also return false if the package doesn't match anything in |
| 589 | // the config. |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 590 | // |
| 591 | // This function will also return the allowlist entry which caused a particular |
| 592 | // package to be enabled. Since packages can be enabled via a recursive declaration, |
| 593 | // the path returned will not always be the same as the one provided. |
| 594 | func bp2buildDefaultTrueRecursively(packagePath string, config allowlists.Bp2BuildConfig) (bool, string) { |
Jingwen Chen | 294e774 | 2021-08-31 05:58:01 +0000 | [diff] [blame] | 595 | // Check if the package path has an exact match in the config. |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 596 | if config[packagePath] == allowlists.Bp2BuildDefaultTrue || config[packagePath] == allowlists.Bp2BuildDefaultTrueRecursively { |
| 597 | return true, packagePath |
MarkDacek | 756b296 | 2022-10-13 17:50:17 +0000 | [diff] [blame] | 598 | } else if config[packagePath] == allowlists.Bp2BuildDefaultFalse || config[packagePath] == allowlists.Bp2BuildDefaultFalseRecursively { |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 599 | return false, packagePath |
Jingwen Chen | 12b4c27 | 2021-03-10 02:05:59 -0500 | [diff] [blame] | 600 | } |
| 601 | |
Jingwen Chen | 91220d7 | 2021-03-24 02:18:33 -0400 | [diff] [blame] | 602 | // If not, check for the config recursively. |
MarkDacek | 756b296 | 2022-10-13 17:50:17 +0000 | [diff] [blame] | 603 | packagePrefix := packagePath |
| 604 | |
| 605 | // e.g. for x/y/z, iterate over x/y, then x, taking the most-specific value from the allowlist. |
| 606 | for strings.Contains(packagePrefix, "/") { |
| 607 | dirIndex := strings.LastIndex(packagePrefix, "/") |
| 608 | packagePrefix = packagePrefix[:dirIndex] |
| 609 | switch value := config[packagePrefix]; value { |
| 610 | case allowlists.Bp2BuildDefaultTrueRecursively: |
Jingwen Chen | 12b4c27 | 2021-03-10 02:05:59 -0500 | [diff] [blame] | 611 | // package contains this prefix and this prefix should convert all modules |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 612 | return true, packagePrefix |
MarkDacek | 756b296 | 2022-10-13 17:50:17 +0000 | [diff] [blame] | 613 | case allowlists.Bp2BuildDefaultFalseRecursively: |
| 614 | //package contains this prefix and this prefix should NOT convert any modules |
| 615 | return false, packagePrefix |
Jingwen Chen | 12b4c27 | 2021-03-10 02:05:59 -0500 | [diff] [blame] | 616 | } |
| 617 | // Continue to the next part of the package dir. |
MarkDacek | 756b296 | 2022-10-13 17:50:17 +0000 | [diff] [blame] | 618 | |
Jingwen Chen | 12b4c27 | 2021-03-10 02:05:59 -0500 | [diff] [blame] | 619 | } |
| 620 | |
Sam Delmerico | 24c5603 | 2022-03-28 19:53:03 +0000 | [diff] [blame] | 621 | return false, packagePath |
Liz Kammer | ea6666f | 2021-02-17 10:17:28 -0500 | [diff] [blame] | 622 | } |
Liz Kammer | ba3ea16 | 2021-02-17 13:22:03 -0500 | [diff] [blame] | 623 | |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 624 | func registerBp2buildConversionMutator(ctx RegisterMutatorsContext) { |
Chris Parsons | 6666d0f | 2023-09-22 16:21:53 +0000 | [diff] [blame] | 625 | ctx.BottomUp("bp2build_conversion", bp2buildConversionMutator).Parallel() |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 626 | } |
| 627 | |
Chris Parsons | 5f1b3c7 | 2023-09-28 20:41:03 +0000 | [diff] [blame] | 628 | func registerBp2buildDepsMutator(ctx RegisterMutatorsContext) { |
| 629 | ctx.BottomUp("bp2build_deps", bp2buildDepsMutator).Parallel() |
| 630 | } |
| 631 | |
Chris Parsons | 6666d0f | 2023-09-22 16:21:53 +0000 | [diff] [blame] | 632 | func bp2buildConversionMutator(ctx BottomUpMutatorContext) { |
Chris Parsons | 5f1b3c7 | 2023-09-28 20:41:03 +0000 | [diff] [blame] | 633 | // If an existing BUILD file in the module directory has a target defined |
| 634 | // with this same name as this module, assume that this is an existing |
| 635 | // definition for this target. |
| 636 | if ctx.Config().HasBazelBuildTargetInSource(ctx.ModuleDir(), ctx.ModuleName()) { |
| 637 | ctx.MarkBp2buildUnconvertible(bp2build_metrics_proto.UnconvertedReasonType_DEFINED_IN_BUILD_FILE, ctx.ModuleName()) |
| 638 | return |
| 639 | } |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 640 | bModule, ok := ctx.Module().(Bazelable) |
Chris Parsons | 39a1697 | 2023-06-08 14:28:51 +0000 | [diff] [blame] | 641 | if !ok { |
| 642 | ctx.MarkBp2buildUnconvertible(bp2build_metrics_proto.UnconvertedReasonType_TYPE_UNSUPPORTED, "") |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 643 | return |
| 644 | } |
Liz Kammer | c86e094 | 2023-08-11 16:15:12 -0400 | [diff] [blame] | 645 | // There may be cases where the target is created by a macro rather than in a BUILD file, those |
| 646 | // should be captured as well. |
| 647 | if bModule.HasHandcraftedLabel() { |
| 648 | // Defer to the BUILD target. Generating an additional target would |
| 649 | // cause a BUILD file conflict. |
| 650 | ctx.MarkBp2buildUnconvertible(bp2build_metrics_proto.UnconvertedReasonType_DEFINED_IN_BUILD_FILE, "") |
| 651 | return |
| 652 | } |
Chris Parsons | 39a1697 | 2023-06-08 14:28:51 +0000 | [diff] [blame] | 653 | // TODO: b/285631638 - Differentiate between denylisted modules and missing bp2build capabilities. |
Liz Kammer | c86e094 | 2023-08-11 16:15:12 -0400 | [diff] [blame] | 654 | if !bModule.shouldConvertWithBp2build(ctx, shouldConvertParams{ |
| 655 | module: ctx.Module(), |
| 656 | moduleDir: ctx.ModuleDir(), |
| 657 | moduleName: ctx.ModuleName(), |
| 658 | moduleType: ctx.ModuleType(), |
| 659 | }) { |
Chris Parsons | 39a1697 | 2023-06-08 14:28:51 +0000 | [diff] [blame] | 660 | ctx.MarkBp2buildUnconvertible(bp2build_metrics_proto.UnconvertedReasonType_UNSUPPORTED, "") |
| 661 | return |
| 662 | } |
Chris Parsons | 0c4de1f | 2023-09-21 20:36:35 +0000 | [diff] [blame] | 663 | if ctx.Module().base().GetUnconvertedReason() != nil { |
| 664 | return |
| 665 | } |
| 666 | |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 667 | bModule.ConvertWithBp2build(ctx) |
Chris Parsons | 39a1697 | 2023-06-08 14:28:51 +0000 | [diff] [blame] | 668 | |
Chris Parsons | 0c4de1f | 2023-09-21 20:36:35 +0000 | [diff] [blame] | 669 | if len(ctx.Module().base().Bp2buildTargets()) == 0 && ctx.Module().base().GetUnconvertedReason() == nil { |
Chris Parsons | 39a1697 | 2023-06-08 14:28:51 +0000 | [diff] [blame] | 670 | panic(fmt.Errorf("illegal bp2build invariant: module '%s' was neither converted nor marked unconvertible", ctx.ModuleName())) |
| 671 | } |
Chris Parsons | 0c4de1f | 2023-09-21 20:36:35 +0000 | [diff] [blame] | 672 | |
Chris Parsons | 5f1b3c7 | 2023-09-28 20:41:03 +0000 | [diff] [blame] | 673 | // If an existing BUILD file in the module directory has a target defined |
| 674 | // with the same name as any target generated by this module, assume that this |
| 675 | // is an existing definition for this target. (These generated target names |
| 676 | // may be different than the module name, as checked at the beginning of this function!) |
Chris Parsons | 0c4de1f | 2023-09-21 20:36:35 +0000 | [diff] [blame] | 677 | for _, targetInfo := range ctx.Module().base().Bp2buildTargets() { |
| 678 | if ctx.Config().HasBazelBuildTargetInSource(targetInfo.TargetPackage(), targetInfo.TargetName()) { |
| 679 | // Defer to the BUILD target. Generating an additional target would |
| 680 | // cause a BUILD file conflict. |
| 681 | ctx.MarkBp2buildUnconvertible(bp2build_metrics_proto.UnconvertedReasonType_DEFINED_IN_BUILD_FILE, targetInfo.TargetName()) |
| 682 | return |
| 683 | } |
| 684 | } |
Liz Kammer | be46fcc | 2021-11-01 15:32:43 -0400 | [diff] [blame] | 685 | } |
Wei Li | bafb6d6 | 2021-12-10 03:14:59 -0800 | [diff] [blame] | 686 | |
Chris Parsons | 5f1b3c7 | 2023-09-28 20:41:03 +0000 | [diff] [blame] | 687 | // TODO: b/285631638 - Add this as a new mutator to the bp2build conversion mutators. |
| 688 | // Currently, this only exists to prepare test coverage for the launch of this feature. |
| 689 | func bp2buildDepsMutator(ctx BottomUpMutatorContext) { |
| 690 | if ctx.Module().base().GetUnconvertedReason() != nil { |
| 691 | return |
| 692 | } |
| 693 | |
| 694 | if len(ctx.Module().GetMissingBp2buildDeps()) > 0 { |
| 695 | exampleDep := ctx.Module().GetMissingBp2buildDeps()[0] |
Jingwen Chen | 464e6a0 | 2023-10-05 09:58:00 +0000 | [diff] [blame] | 696 | ctx.MarkBp2buildUnconvertible( |
| 697 | bp2build_metrics_proto.UnconvertedReasonType_UNCONVERTED_DEP, exampleDep) |
Chris Parsons | 5f1b3c7 | 2023-09-28 20:41:03 +0000 | [diff] [blame] | 698 | } |
| 699 | |
Jingwen Chen | 464e6a0 | 2023-10-05 09:58:00 +0000 | [diff] [blame] | 700 | // Transitively mark modules unconvertible with the following set of conditions. |
Chris Parsons | 5f1b3c7 | 2023-09-28 20:41:03 +0000 | [diff] [blame] | 701 | ctx.VisitDirectDeps(func(dep Module) { |
Jingwen Chen | 464e6a0 | 2023-10-05 09:58:00 +0000 | [diff] [blame] | 702 | if dep.base().GetUnconvertedReason() == nil { |
| 703 | return |
Chris Parsons | 5f1b3c7 | 2023-09-28 20:41:03 +0000 | [diff] [blame] | 704 | } |
Jingwen Chen | 464e6a0 | 2023-10-05 09:58:00 +0000 | [diff] [blame] | 705 | |
| 706 | if dep.base().GetUnconvertedReason().ReasonType == |
| 707 | int(bp2build_metrics_proto.UnconvertedReasonType_DEFINED_IN_BUILD_FILE) { |
| 708 | return |
| 709 | } |
| 710 | |
| 711 | if ctx.OtherModuleDependencyTag(dep) != Bp2buildDepTag { |
| 712 | return |
| 713 | } |
| 714 | |
| 715 | ctx.MarkBp2buildUnconvertible( |
| 716 | bp2build_metrics_proto.UnconvertedReasonType_UNCONVERTED_DEP, dep.Name()) |
Chris Parsons | 5f1b3c7 | 2023-09-28 20:41:03 +0000 | [diff] [blame] | 717 | }) |
| 718 | } |
| 719 | |
Wei Li | bafb6d6 | 2021-12-10 03:14:59 -0800 | [diff] [blame] | 720 | // GetMainClassInManifest scans the manifest file specified in filepath and returns |
| 721 | // the value of attribute Main-Class in the manifest file if it exists, or returns error. |
| 722 | // WARNING: this is for bp2build converters of java_* modules only. |
| 723 | func GetMainClassInManifest(c Config, filepath string) (string, error) { |
| 724 | file, err := c.fs.Open(filepath) |
| 725 | if err != nil { |
| 726 | return "", err |
| 727 | } |
Liz Kammer | 0fe123d | 2022-02-07 10:17:35 -0500 | [diff] [blame] | 728 | defer file.Close() |
Wei Li | bafb6d6 | 2021-12-10 03:14:59 -0800 | [diff] [blame] | 729 | scanner := bufio.NewScanner(file) |
| 730 | for scanner.Scan() { |
| 731 | line := scanner.Text() |
| 732 | if strings.HasPrefix(line, "Main-Class:") { |
| 733 | return strings.TrimSpace(line[len("Main-Class:"):]), nil |
| 734 | } |
| 735 | } |
| 736 | |
| 737 | return "", errors.New("Main-Class is not found.") |
| 738 | } |
Sam Delmerico | 4ed95e2 | 2023-02-03 18:12:15 -0500 | [diff] [blame] | 739 | |
| 740 | func AttachValidationActions(ctx ModuleContext, outputFilePath Path, validations Paths) ModuleOutPath { |
| 741 | validatedOutputFilePath := PathForModuleOut(ctx, "validated", outputFilePath.Base()) |
| 742 | ctx.Build(pctx, BuildParams{ |
| 743 | Rule: CpNoPreserveSymlink, |
| 744 | Description: "run validations " + outputFilePath.Base(), |
| 745 | Output: validatedOutputFilePath, |
| 746 | Input: outputFilePath, |
| 747 | Validations: validations, |
| 748 | }) |
| 749 | return validatedOutputFilePath |
| 750 | } |
yike | fdca7fe | 2023-08-17 01:03:37 +0000 | [diff] [blame] | 751 | |
| 752 | func RunsOn(hostSupported bool, deviceSupported bool, unitTest bool) []string { |
| 753 | var runsOn []string |
| 754 | |
| 755 | if hostSupported && deviceSupported { |
| 756 | runsOn = []string{"host_without_device", "device"} |
| 757 | } else if hostSupported { |
| 758 | if unitTest { |
| 759 | runsOn = []string{"host_without_device"} |
| 760 | } else { |
| 761 | runsOn = []string{"host_with_device"} |
| 762 | } |
| 763 | } else if deviceSupported { |
| 764 | runsOn = []string{"device"} |
| 765 | } |
| 766 | |
| 767 | return runsOn |
| 768 | } |