blob: bf9975784cfed4d33b1bcc53f11c8907d6a3f0b9 [file] [log] [blame]
Paul Duffinc6bb7cf2021-04-08 17:49:27 +01001// Copyright (C) 2021 The Android Open Source Project
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
Paul Duffin7487a7a2021-05-19 09:36:09 +010018 "fmt"
Paul Duffindfa10832021-05-13 17:31:51 +010019 "strings"
20
Paul Duffinc6bb7cf2021-04-08 17:49:27 +010021 "android/soong/android"
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +010022
Paul Duffin9b381ef2021-04-08 23:01:37 +010023 "github.com/google/blueprint"
Paul Duffinc6bb7cf2021-04-08 17:49:27 +010024)
25
26// Contains support for processing hiddenAPI in a modular fashion.
27
Paul Duffin31fad802021-06-18 18:14:25 +010028// HiddenAPIScope encapsulates all the information that the hidden API processing needs about API
29// scopes, i.e. what is called android.SdkKind and apiScope. It does not just use those as they do
30// not provide the information needed by hidden API processing.
31type HiddenAPIScope struct {
32 // The name of the scope, used for debug purposes.
33 name string
34
35 // The corresponding android.SdkKind, used for retrieving paths from java_sdk_library* modules.
36 sdkKind android.SdkKind
37
38 // The option needed to passed to "hiddenapi list".
39 hiddenAPIListOption string
Paul Duffin5cca7c42021-05-26 10:16:01 +010040
Jihoon Kang244d42a2023-10-06 16:54:58 +000041 // The names of the source stub library modules that contain the API provided by the platform,
Paul Duffin5cca7c42021-05-26 10:16:01 +010042 // i.e. by modules that are not in an APEX.
43 nonUpdatableSourceModule string
44
Jihoon Kang244d42a2023-10-06 16:54:58 +000045 // The names of from-text stub library modules that contain the API provided by the platform,
46 // i.e. by modules that are not in an APEX.
47 nonUpdatableFromTextModule string
48
Paul Duffin5cca7c42021-05-26 10:16:01 +010049 // The names of the prebuilt stub library modules that contain the API provided by the platform,
50 // i.e. by modules that are not in an APEX.
51 nonUpdatablePrebuiltModule string
Paul Duffin31fad802021-06-18 18:14:25 +010052}
53
54// initHiddenAPIScope initializes the scope.
55func initHiddenAPIScope(apiScope *HiddenAPIScope) *HiddenAPIScope {
Paul Duffin5cca7c42021-05-26 10:16:01 +010056 sdkKind := apiScope.sdkKind
57 // The platform does not provide a core platform API.
58 if sdkKind != android.SdkCorePlatform {
59 kindAsString := sdkKind.String()
60 var insert string
61 if sdkKind == android.SdkPublic {
62 insert = ""
63 } else {
64 insert = "." + strings.ReplaceAll(kindAsString, "-", "_")
65 }
66
67 nonUpdatableModule := "android-non-updatable"
68
69 // Construct the name of the android-non-updatable source module for this scope.
70 apiScope.nonUpdatableSourceModule = fmt.Sprintf("%s.stubs%s", nonUpdatableModule, insert)
71
72 prebuiltModuleName := func(name string, kind string) string {
73 return fmt.Sprintf("sdk_%s_current_%s", kind, name)
74 }
75
76 // Construct the name of the android-non-updatable prebuilt module for this scope.
77 apiScope.nonUpdatablePrebuiltModule = prebuiltModuleName(nonUpdatableModule, kindAsString)
78 }
79
Paul Duffin31fad802021-06-18 18:14:25 +010080 return apiScope
81}
82
Paul Duffin5cca7c42021-05-26 10:16:01 +010083// android-non-updatable takes the name of a module and returns a possibly scope specific name of
84// the module.
85func (l *HiddenAPIScope) scopeSpecificStubModule(ctx android.BaseModuleContext, name string) string {
86 // The android-non-updatable is not a java_sdk_library but there are separate stub libraries for
87 // each scope.
88 // TODO(b/192067200): Remove special handling of android-non-updatable.
89 if name == "android-non-updatable" {
90 if ctx.Config().AlwaysUsePrebuiltSdks() {
91 return l.nonUpdatablePrebuiltModule
92 } else {
Jihoon Kang244d42a2023-10-06 16:54:58 +000093 if l.nonUpdatableFromTextModule != "" && ctx.Config().BuildFromTextStub() {
94 return l.nonUpdatableFromTextModule
95 }
Paul Duffin5cca7c42021-05-26 10:16:01 +010096 return l.nonUpdatableSourceModule
97 }
98 } else {
99 // Assume that the module is either a java_sdk_library (or equivalent) and so will provide
100 // separate stub jars for each scope or is a java_library (or equivalent) in which case it will
101 // have the same stub jar for each scope.
102 return name
103 }
104}
105
Paul Duffin31fad802021-06-18 18:14:25 +0100106func (l *HiddenAPIScope) String() string {
107 return fmt.Sprintf("HiddenAPIScope{%s}", l.name)
108}
109
110var (
111 PublicHiddenAPIScope = initHiddenAPIScope(&HiddenAPIScope{
112 name: "public",
113 sdkKind: android.SdkPublic,
114 hiddenAPIListOption: "--public-stub-classpath",
115 })
116 SystemHiddenAPIScope = initHiddenAPIScope(&HiddenAPIScope{
117 name: "system",
118 sdkKind: android.SdkSystem,
119 hiddenAPIListOption: "--system-stub-classpath",
120 })
121 TestHiddenAPIScope = initHiddenAPIScope(&HiddenAPIScope{
122 name: "test",
123 sdkKind: android.SdkTest,
124 hiddenAPIListOption: "--test-stub-classpath",
125 })
Paul Duffinb51db2e2021-06-21 14:08:08 +0100126 ModuleLibHiddenAPIScope = initHiddenAPIScope(&HiddenAPIScope{
Jihoon Kang244d42a2023-10-06 16:54:58 +0000127 name: "module-lib",
128 sdkKind: android.SdkModule,
129 nonUpdatableFromTextModule: "android-non-updatable.stubs.test_module_lib",
Paul Duffinb51db2e2021-06-21 14:08:08 +0100130 })
Paul Duffin31fad802021-06-18 18:14:25 +0100131 CorePlatformHiddenAPIScope = initHiddenAPIScope(&HiddenAPIScope{
132 name: "core-platform",
133 sdkKind: android.SdkCorePlatform,
134 hiddenAPIListOption: "--core-platform-stub-classpath",
135 })
136
137 // hiddenAPIRelevantSdkKinds lists all the android.SdkKind instances that are needed by the hidden
138 // API processing.
139 //
140 // These are roughly in order from narrowest API surface to widest. Widest means the API stubs
141 // with the biggest API surface, e.g. test is wider than system is wider than public.
142 //
Paul Duffinb51db2e2021-06-21 14:08:08 +0100143 // Core platform is considered wider than system/module-lib because those modules that provide
144 // core platform APIs either do not have any system/module-lib APIs at all, or if they do it is
145 // because the core platform API is being converted to system/module-lib APIs. In either case the
146 // system/module-lib APIs are subsets of the core platform API.
Paul Duffin31fad802021-06-18 18:14:25 +0100147 //
148 // This is not strictly in order from narrowest to widest as the Test API is wider than system but
Paul Duffinb51db2e2021-06-21 14:08:08 +0100149 // is neither wider or narrower than the module-lib or core platform APIs. However, this works
150 // well enough at the moment.
Paul Duffin31fad802021-06-18 18:14:25 +0100151 // TODO(b/191644675): Correctly reflect the sub/superset relationships between APIs.
152 hiddenAPIScopes = []*HiddenAPIScope{
153 PublicHiddenAPIScope,
154 SystemHiddenAPIScope,
155 TestHiddenAPIScope,
Paul Duffinb51db2e2021-06-21 14:08:08 +0100156 ModuleLibHiddenAPIScope,
Paul Duffin31fad802021-06-18 18:14:25 +0100157 CorePlatformHiddenAPIScope,
158 }
159
160 // The HiddenAPIScope instances that are supported by a java_sdk_library.
161 //
162 // CorePlatformHiddenAPIScope is not used as the java_sdk_library does not have special support
163 // for core_platform API, instead it is implemented as a customized form of PublicHiddenAPIScope.
164 hiddenAPISdkLibrarySupportedScopes = []*HiddenAPIScope{
165 PublicHiddenAPIScope,
166 SystemHiddenAPIScope,
167 TestHiddenAPIScope,
Paul Duffinb51db2e2021-06-21 14:08:08 +0100168 ModuleLibHiddenAPIScope,
Paul Duffin31fad802021-06-18 18:14:25 +0100169 }
170
171 // The HiddenAPIScope instances that are supported by the `hiddenapi list`.
172 hiddenAPIFlagScopes = []*HiddenAPIScope{
173 PublicHiddenAPIScope,
174 SystemHiddenAPIScope,
175 TestHiddenAPIScope,
176 CorePlatformHiddenAPIScope,
177 }
178)
179
Paul Duffin74431d52021-04-21 14:10:42 +0100180type hiddenAPIStubsDependencyTag struct {
181 blueprint.BaseDependencyTag
Paul Duffin31fad802021-06-18 18:14:25 +0100182
183 // The api scope for which this dependency was added.
184 apiScope *HiddenAPIScope
Paul Duffin5cca7c42021-05-26 10:16:01 +0100185
186 // Indicates that the dependency is not for an API provided by the current bootclasspath fragment
187 // but is an additional API provided by a module that is not part of the current bootclasspath
188 // fragment.
189 fromAdditionalDependency bool
Paul Duffin74431d52021-04-21 14:10:42 +0100190}
191
192func (b hiddenAPIStubsDependencyTag) ExcludeFromApexContents() {
193}
194
195func (b hiddenAPIStubsDependencyTag) ReplaceSourceWithPrebuilt() bool {
196 return false
197}
198
Paul Duffin976b0e52021-04-27 23:20:26 +0100199func (b hiddenAPIStubsDependencyTag) SdkMemberType(child android.Module) android.SdkMemberType {
Paul Duffin5cca7c42021-05-26 10:16:01 +0100200 // Do not add additional dependencies to the sdk.
201 if b.fromAdditionalDependency {
202 return nil
203 }
204
Paul Duffin976b0e52021-04-27 23:20:26 +0100205 // If the module is a java_sdk_library then treat it as if it was specific in the java_sdk_libs
206 // property, otherwise treat if it was specified in the java_header_libs property.
207 if javaSdkLibrarySdkMemberType.IsInstance(child) {
208 return javaSdkLibrarySdkMemberType
209 }
210
211 return javaHeaderLibsSdkMemberType
212}
213
214func (b hiddenAPIStubsDependencyTag) ExportMember() bool {
215 // Export the module added via this dependency tag from the sdk.
216 return true
217}
218
Paul Duffin74431d52021-04-21 14:10:42 +0100219// Avoid having to make stubs content explicitly visible to dependent modules.
220//
221// This is a temporary workaround to make it easier to migrate to bootclasspath_fragment modules
222// with proper dependencies.
223// TODO(b/177892522): Remove this and add needed visibility.
224func (b hiddenAPIStubsDependencyTag) ExcludeFromVisibilityEnforcement() {
225}
226
227var _ android.ExcludeFromVisibilityEnforcementTag = hiddenAPIStubsDependencyTag{}
228var _ android.ReplaceSourceWithPrebuilt = hiddenAPIStubsDependencyTag{}
229var _ android.ExcludeFromApexContentsTag = hiddenAPIStubsDependencyTag{}
Paul Duffinf7b3d0d2021-09-02 14:29:21 +0100230var _ android.SdkMemberDependencyTag = hiddenAPIStubsDependencyTag{}
Paul Duffin74431d52021-04-21 14:10:42 +0100231
Paul Duffin74431d52021-04-21 14:10:42 +0100232// hiddenAPIComputeMonolithicStubLibModules computes the set of module names that provide stubs
233// needed to produce the hidden API monolithic stub flags file.
Paul Duffin31fad802021-06-18 18:14:25 +0100234func hiddenAPIComputeMonolithicStubLibModules(config android.Config) map[*HiddenAPIScope][]string {
Paul Duffin74431d52021-04-21 14:10:42 +0100235 var publicStubModules []string
236 var systemStubModules []string
237 var testStubModules []string
238 var corePlatformStubModules []string
239
240 if config.AlwaysUsePrebuiltSdks() {
241 // Build configuration mandates using prebuilt stub modules
242 publicStubModules = append(publicStubModules, "sdk_public_current_android")
243 systemStubModules = append(systemStubModules, "sdk_system_current_android")
244 testStubModules = append(testStubModules, "sdk_test_current_android")
245 } else {
246 // Use stub modules built from source
Jihoon Kang91c83952023-05-30 19:12:28 +0000247 publicStubModules = append(publicStubModules, android.SdkPublic.DefaultJavaLibraryName())
248 systemStubModules = append(systemStubModules, android.SdkSystem.DefaultJavaLibraryName())
249 testStubModules = append(testStubModules, android.SdkTest.DefaultJavaLibraryName())
Paul Duffin74431d52021-04-21 14:10:42 +0100250 }
251 // We do not have prebuilts of the core platform api yet
Jihoon Kang91c83952023-05-30 19:12:28 +0000252 corePlatformStubModules = append(corePlatformStubModules, "legacy.core.platform.api.stubs")
Paul Duffin74431d52021-04-21 14:10:42 +0100253
254 // Allow products to define their own stubs for custom product jars that apps can use.
255 publicStubModules = append(publicStubModules, config.ProductHiddenAPIStubs()...)
256 systemStubModules = append(systemStubModules, config.ProductHiddenAPIStubsSystem()...)
257 testStubModules = append(testStubModules, config.ProductHiddenAPIStubsTest()...)
258 if config.IsEnvTrue("EMMA_INSTRUMENT") {
Paul Duffin098c8782021-05-14 10:45:25 +0100259 // Add jacoco-stubs to public, system and test. It doesn't make any real difference as public
260 // allows everyone access but it is needed to ensure consistent flags between the
261 // bootclasspath fragment generated flags and the platform_bootclasspath generated flags.
Paul Duffin74431d52021-04-21 14:10:42 +0100262 publicStubModules = append(publicStubModules, "jacoco-stubs")
Paul Duffin098c8782021-05-14 10:45:25 +0100263 systemStubModules = append(systemStubModules, "jacoco-stubs")
264 testStubModules = append(testStubModules, "jacoco-stubs")
Paul Duffin74431d52021-04-21 14:10:42 +0100265 }
266
Paul Duffin31fad802021-06-18 18:14:25 +0100267 m := map[*HiddenAPIScope][]string{}
268 m[PublicHiddenAPIScope] = publicStubModules
269 m[SystemHiddenAPIScope] = systemStubModules
270 m[TestHiddenAPIScope] = testStubModules
271 m[CorePlatformHiddenAPIScope] = corePlatformStubModules
Paul Duffin74431d52021-04-21 14:10:42 +0100272 return m
273}
274
275// hiddenAPIAddStubLibDependencies adds dependencies onto the modules specified in
Paul Duffin31fad802021-06-18 18:14:25 +0100276// apiScopeToStubLibModules. It adds them in a well known order and uses a HiddenAPIScope specific
277// tag to identify the source of the dependency.
278func hiddenAPIAddStubLibDependencies(ctx android.BottomUpMutatorContext, apiScopeToStubLibModules map[*HiddenAPIScope][]string) {
Paul Duffin74431d52021-04-21 14:10:42 +0100279 module := ctx.Module()
Paul Duffin31fad802021-06-18 18:14:25 +0100280 for _, apiScope := range hiddenAPIScopes {
281 modules := apiScopeToStubLibModules[apiScope]
282 ctx.AddDependency(module, hiddenAPIStubsDependencyTag{apiScope: apiScope}, modules...)
Paul Duffin74431d52021-04-21 14:10:42 +0100283 }
284}
285
Paul Duffin74431d52021-04-21 14:10:42 +0100286// hiddenAPIRetrieveDexJarBuildPath retrieves the DexJarBuildPath from the specified module, if
287// available, or reports an error.
Paul Duffin10931582021-04-25 10:13:54 +0100288func hiddenAPIRetrieveDexJarBuildPath(ctx android.ModuleContext, module android.Module, kind android.SdkKind) android.Path {
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +0100289 var dexJar OptionalDexJarPath
Paul Duffin10931582021-04-25 10:13:54 +0100290 if sdkLibrary, ok := module.(SdkLibraryDependency); ok {
291 dexJar = sdkLibrary.SdkApiStubDexJar(ctx, kind)
292 } else if j, ok := module.(UsesLibraryDependency); ok {
293 dexJar = j.DexJarBuildPath()
Paul Duffin74431d52021-04-21 14:10:42 +0100294 } else {
295 ctx.ModuleErrorf("dependency %s of module type %s does not support providing a dex jar", module, ctx.OtherModuleType(module))
Paul Duffin10931582021-04-25 10:13:54 +0100296 return nil
Paul Duffin74431d52021-04-21 14:10:42 +0100297 }
Paul Duffin10931582021-04-25 10:13:54 +0100298
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +0100299 if !dexJar.Valid() {
300 ctx.ModuleErrorf("dependency %s does not provide a dex jar: %s", module, dexJar.InvalidReason())
301 return nil
Paul Duffin10931582021-04-25 10:13:54 +0100302 }
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +0100303 return dexJar.Path()
Paul Duffin74431d52021-04-21 14:10:42 +0100304}
305
Paul Duffinbd88c882022-04-07 23:32:19 +0100306// HIDDENAPI_STUB_FLAGS_IMPL_FLAGS is the set of flags that identify implementation only signatures,
307// i.e. those signatures that are not part of any API (including the hidden API).
308var HIDDENAPI_STUB_FLAGS_IMPL_FLAGS = []string{}
309
310var HIDDENAPI_FLAGS_CSV_IMPL_FLAGS = []string{"blocked"}
311
Paul Duffin4539a372021-06-23 23:20:43 +0100312// buildRuleToGenerateHiddenAPIStubFlagsFile creates a rule to create a hidden API stub flags file.
Paul Duffin74431d52021-04-21 14:10:42 +0100313//
314// The rule is initialized but not built so that the caller can modify it and select an appropriate
315// name.
Paul Duffin67b9d612021-07-21 17:38:47 +0100316func buildRuleToGenerateHiddenAPIStubFlagsFile(ctx android.BuilderContext, name, desc string, outputPath android.WritablePath, bootDexJars android.Paths, input HiddenAPIFlagInput, stubFlagSubsets SignatureCsvSubsets) {
Paul Duffin74431d52021-04-21 14:10:42 +0100317 // Singleton rule which applies hiddenapi on all boot class path dex files.
318 rule := android.NewRuleBuilder(pctx, ctx)
319
320 tempPath := tempPathForRestat(ctx, outputPath)
321
Paul Duffinf1b358c2021-05-17 07:38:47 +0100322 // Find the widest API stubs provided by the fragments on which this depends, if any.
Paul Duffind2b1e0c2021-06-27 20:53:39 +0100323 dependencyStubDexJars := input.DependencyStubDexJarsByScope.StubDexJarsForWidestAPIScope()
Paul Duffin5cca7c42021-05-26 10:16:01 +0100324
325 // Add widest API stubs from the additional dependencies of this, if any.
Paul Duffind2b1e0c2021-06-27 20:53:39 +0100326 dependencyStubDexJars = append(dependencyStubDexJars, input.AdditionalStubDexJarsByScope.StubDexJarsForWidestAPIScope()...)
Paul Duffinf1b358c2021-05-17 07:38:47 +0100327
Paul Duffin74431d52021-04-21 14:10:42 +0100328 command := rule.Command().
329 Tool(ctx.Config().HostToolPath(ctx, "hiddenapi")).
330 Text("list").
Paul Duffinf1b358c2021-05-17 07:38:47 +0100331 FlagForEachInput("--dependency-stub-dex=", dependencyStubDexJars).
Paul Duffin74431d52021-04-21 14:10:42 +0100332 FlagForEachInput("--boot-dex=", bootDexJars)
333
Paul Duffin156b5d32021-06-24 23:06:52 +0100334 // If no module stub flags paths are provided then this must be being called for a
335 // bootclasspath_fragment and not the whole platform_bootclasspath.
Paul Duffin67b9d612021-07-21 17:38:47 +0100336 if stubFlagSubsets == nil {
Paul Duffin156b5d32021-06-24 23:06:52 +0100337 // This is being run on a fragment of the bootclasspath.
338 command.Flag("--fragment")
339 }
340
Paul Duffin31fad802021-06-18 18:14:25 +0100341 // Iterate over the api scopes in a fixed order.
342 for _, apiScope := range hiddenAPIFlagScopes {
343 // Merge in the stub dex jar paths for this api scope from the fragments on which it depends.
344 // They will be needed to resolve dependencies from this fragment's stubs to classes in the
345 // other fragment's APIs.
346 var paths android.Paths
Paul Duffin280a31a2021-06-27 20:28:29 +0100347 paths = append(paths, input.DependencyStubDexJarsByScope.StubDexJarsForScope(apiScope)...)
348 paths = append(paths, input.AdditionalStubDexJarsByScope.StubDexJarsForScope(apiScope)...)
349 paths = append(paths, input.StubDexJarsByScope.StubDexJarsForScope(apiScope)...)
Paul Duffin74431d52021-04-21 14:10:42 +0100350 if len(paths) > 0 {
Paul Duffin31fad802021-06-18 18:14:25 +0100351 option := apiScope.hiddenAPIListOption
352 command.FlagWithInputList(option+"=", paths, ":")
Paul Duffin74431d52021-04-21 14:10:42 +0100353 }
354 }
355
356 // Add the output path.
357 command.FlagWithOutput("--out-api-flags=", tempPath)
358
Paul Duffin2e880972021-06-23 23:29:09 +0100359 // If there are stub flag files that have been generated by fragments on which this depends then
360 // use them to validate the stub flag file generated by the rules created by this method.
Alyssa Ketpreechasawat7daf2782023-11-01 13:58:39 +0000361 if !ctx.Config().DisableVerifyOverlaps() && len(stubFlagSubsets) > 0 {
Paul Duffinbd88c882022-04-07 23:32:19 +0100362 validFile := buildRuleValidateOverlappingCsvFiles(ctx, name, desc, outputPath, stubFlagSubsets,
363 HIDDENAPI_STUB_FLAGS_IMPL_FLAGS)
Paul Duffin2e880972021-06-23 23:29:09 +0100364
365 // Add the file that indicates that the file generated by this is valid.
366 //
367 // This will cause the validation rule above to be run any time that the output of this rule
368 // changes but the validation will run in parallel with other rules that depend on this file.
369 command.Validation(validFile)
370 }
371
Paul Duffin74431d52021-04-21 14:10:42 +0100372 commitChangeForRestat(rule, tempPath, outputPath)
Paul Duffin4539a372021-06-23 23:20:43 +0100373
374 rule.Build(name, desc)
Paul Duffin74431d52021-04-21 14:10:42 +0100375}
376
Paul Duffin46169772021-04-14 15:01:56 +0100377// HiddenAPIFlagFileProperties contains paths to the flag files that can be used to augment the
378// information obtained from annotations within the source code in order to create the complete set
379// of flags that should be applied to the dex implementation jars on the bootclasspath.
Paul Duffinc6bb7cf2021-04-08 17:49:27 +0100380//
381// Each property contains a list of paths. With the exception of the Unsupported_packages the paths
382// of each property reference a plain text file that contains a java signature per line. The flags
383// for each of those signatures will be updated in a property specific way.
384//
385// The Unsupported_packages property contains a list of paths, each of which is a plain text file
386// with one Java package per line. All members of all classes within that package (but not nested
387// packages) will be updated in a property specific way.
Paul Duffin46169772021-04-14 15:01:56 +0100388type HiddenAPIFlagFileProperties struct {
Paul Duffin9b61abb2022-07-27 16:16:54 +0000389 Hidden_api struct {
390 // Marks each signature in the referenced files as being unsupported.
391 Unsupported []string `android:"path"`
Paul Duffinc6bb7cf2021-04-08 17:49:27 +0100392
Paul Duffin9b61abb2022-07-27 16:16:54 +0000393 // Marks each signature in the referenced files as being unsupported because it has been
394 // removed. Any conflicts with other flags are ignored.
395 Removed []string `android:"path"`
Paul Duffinc6bb7cf2021-04-08 17:49:27 +0100396
Paul Duffin9b61abb2022-07-27 16:16:54 +0000397 // Marks each signature in the referenced files as being supported only for
398 // targetSdkVersion <= R and low priority.
399 Max_target_r_low_priority []string `android:"path"`
Paul Duffinc6bb7cf2021-04-08 17:49:27 +0100400
Paul Duffin9b61abb2022-07-27 16:16:54 +0000401 // Marks each signature in the referenced files as being supported only for
402 // targetSdkVersion <= Q.
403 Max_target_q []string `android:"path"`
Paul Duffinc6bb7cf2021-04-08 17:49:27 +0100404
Paul Duffin9b61abb2022-07-27 16:16:54 +0000405 // Marks each signature in the referenced files as being supported only for
406 // targetSdkVersion <= P.
407 Max_target_p []string `android:"path"`
Paul Duffinc6bb7cf2021-04-08 17:49:27 +0100408
Paul Duffin9b61abb2022-07-27 16:16:54 +0000409 // Marks each signature in the referenced files as being supported only for
410 // targetSdkVersion <= O
411 // and low priority. Any conflicts with other flags are ignored.
412 Max_target_o_low_priority []string `android:"path"`
Paul Duffinc6bb7cf2021-04-08 17:49:27 +0100413
Paul Duffin9b61abb2022-07-27 16:16:54 +0000414 // Marks each signature in the referenced files as being blocked.
415 Blocked []string `android:"path"`
Paul Duffinc6bb7cf2021-04-08 17:49:27 +0100416
Paul Duffin9b61abb2022-07-27 16:16:54 +0000417 // Marks each signature in every package in the referenced files as being unsupported.
418 Unsupported_packages []string `android:"path"`
419 }
Paul Duffin702210b2021-04-08 20:12:41 +0100420}
421
Paul Duffine3dc6602021-04-14 09:50:43 +0100422type hiddenAPIFlagFileCategory struct {
Paul Duffin524c82c2021-06-09 14:39:28 +0100423 // PropertyName is the name of the property for this category.
424 PropertyName string
Paul Duffine3dc6602021-04-14 09:50:43 +0100425
Paul Duffincc17bfe2021-04-19 13:21:20 +0100426 // propertyValueReader retrieves the value of the property for this category from the set of
Paul Duffine3dc6602021-04-14 09:50:43 +0100427 // properties.
Paul Duffincc17bfe2021-04-19 13:21:20 +0100428 propertyValueReader func(properties *HiddenAPIFlagFileProperties) []string
Paul Duffine3dc6602021-04-14 09:50:43 +0100429
430 // commandMutator adds the appropriate command line options for this category to the supplied
431 // command
432 commandMutator func(command *android.RuleBuilderCommand, path android.Path)
433}
434
Paul Duffin32cf58a2021-05-18 16:32:50 +0100435// The flag file category for removed members of the API.
436//
Paul Duffin524c82c2021-06-09 14:39:28 +0100437// This is extracted from HiddenAPIFlagFileCategories as it is needed to add the dex signatures
Paul Duffin32cf58a2021-05-18 16:32:50 +0100438// list of removed API members that are generated automatically from the removed.txt files provided
439// by API stubs.
440var hiddenAPIRemovedFlagFileCategory = &hiddenAPIFlagFileCategory{
441 // See HiddenAPIFlagFileProperties.Removed
Paul Duffin524c82c2021-06-09 14:39:28 +0100442 PropertyName: "removed",
Paul Duffin32cf58a2021-05-18 16:32:50 +0100443 propertyValueReader: func(properties *HiddenAPIFlagFileProperties) []string {
Paul Duffin9b61abb2022-07-27 16:16:54 +0000444 return properties.Hidden_api.Removed
Paul Duffin32cf58a2021-05-18 16:32:50 +0100445 },
446 commandMutator: func(command *android.RuleBuilderCommand, path android.Path) {
447 command.FlagWithInput("--unsupported ", path).Flag("--ignore-conflicts ").FlagWithArg("--tag ", "removed")
448 },
449}
450
Paul Duffin3f1ae0b2022-07-27 16:27:42 +0000451type hiddenAPIFlagFileCategories []*hiddenAPIFlagFileCategory
452
453func (c hiddenAPIFlagFileCategories) byProperty(name string) *hiddenAPIFlagFileCategory {
454 for _, category := range c {
455 if category.PropertyName == name {
456 return category
457 }
458 }
459 panic(fmt.Errorf("no category exists with property name %q in %v", name, c))
460}
461
462var HiddenAPIFlagFileCategories = hiddenAPIFlagFileCategories{
Paul Duffin46169772021-04-14 15:01:56 +0100463 // See HiddenAPIFlagFileProperties.Unsupported
Paul Duffine3dc6602021-04-14 09:50:43 +0100464 {
Paul Duffin524c82c2021-06-09 14:39:28 +0100465 PropertyName: "unsupported",
Paul Duffincc17bfe2021-04-19 13:21:20 +0100466 propertyValueReader: func(properties *HiddenAPIFlagFileProperties) []string {
Paul Duffin9b61abb2022-07-27 16:16:54 +0000467 return properties.Hidden_api.Unsupported
Paul Duffine3dc6602021-04-14 09:50:43 +0100468 },
469 commandMutator: func(command *android.RuleBuilderCommand, path android.Path) {
470 command.FlagWithInput("--unsupported ", path)
471 },
472 },
Paul Duffin32cf58a2021-05-18 16:32:50 +0100473 hiddenAPIRemovedFlagFileCategory,
Paul Duffin46169772021-04-14 15:01:56 +0100474 // See HiddenAPIFlagFileProperties.Max_target_r_low_priority
Paul Duffine3dc6602021-04-14 09:50:43 +0100475 {
Paul Duffin524c82c2021-06-09 14:39:28 +0100476 PropertyName: "max_target_r_low_priority",
Paul Duffincc17bfe2021-04-19 13:21:20 +0100477 propertyValueReader: func(properties *HiddenAPIFlagFileProperties) []string {
Paul Duffin9b61abb2022-07-27 16:16:54 +0000478 return properties.Hidden_api.Max_target_r_low_priority
Paul Duffine3dc6602021-04-14 09:50:43 +0100479 },
480 commandMutator: func(command *android.RuleBuilderCommand, path android.Path) {
481 command.FlagWithInput("--max-target-r ", path).FlagWithArg("--tag ", "lo-prio")
482 },
483 },
Paul Duffin46169772021-04-14 15:01:56 +0100484 // See HiddenAPIFlagFileProperties.Max_target_q
Paul Duffine3dc6602021-04-14 09:50:43 +0100485 {
Paul Duffin524c82c2021-06-09 14:39:28 +0100486 PropertyName: "max_target_q",
Paul Duffincc17bfe2021-04-19 13:21:20 +0100487 propertyValueReader: func(properties *HiddenAPIFlagFileProperties) []string {
Paul Duffin9b61abb2022-07-27 16:16:54 +0000488 return properties.Hidden_api.Max_target_q
Paul Duffine3dc6602021-04-14 09:50:43 +0100489 },
490 commandMutator: func(command *android.RuleBuilderCommand, path android.Path) {
491 command.FlagWithInput("--max-target-q ", path)
492 },
493 },
Paul Duffin46169772021-04-14 15:01:56 +0100494 // See HiddenAPIFlagFileProperties.Max_target_p
Paul Duffine3dc6602021-04-14 09:50:43 +0100495 {
Paul Duffin524c82c2021-06-09 14:39:28 +0100496 PropertyName: "max_target_p",
Paul Duffincc17bfe2021-04-19 13:21:20 +0100497 propertyValueReader: func(properties *HiddenAPIFlagFileProperties) []string {
Paul Duffin9b61abb2022-07-27 16:16:54 +0000498 return properties.Hidden_api.Max_target_p
Paul Duffine3dc6602021-04-14 09:50:43 +0100499 },
500 commandMutator: func(command *android.RuleBuilderCommand, path android.Path) {
501 command.FlagWithInput("--max-target-p ", path)
502 },
503 },
Paul Duffin46169772021-04-14 15:01:56 +0100504 // See HiddenAPIFlagFileProperties.Max_target_o_low_priority
Paul Duffine3dc6602021-04-14 09:50:43 +0100505 {
Paul Duffin524c82c2021-06-09 14:39:28 +0100506 PropertyName: "max_target_o_low_priority",
Paul Duffincc17bfe2021-04-19 13:21:20 +0100507 propertyValueReader: func(properties *HiddenAPIFlagFileProperties) []string {
Paul Duffin9b61abb2022-07-27 16:16:54 +0000508 return properties.Hidden_api.Max_target_o_low_priority
Paul Duffine3dc6602021-04-14 09:50:43 +0100509 },
510 commandMutator: func(command *android.RuleBuilderCommand, path android.Path) {
511 command.FlagWithInput("--max-target-o ", path).Flag("--ignore-conflicts ").FlagWithArg("--tag ", "lo-prio")
512 },
513 },
Paul Duffin46169772021-04-14 15:01:56 +0100514 // See HiddenAPIFlagFileProperties.Blocked
Paul Duffine3dc6602021-04-14 09:50:43 +0100515 {
Paul Duffin524c82c2021-06-09 14:39:28 +0100516 PropertyName: "blocked",
Paul Duffincc17bfe2021-04-19 13:21:20 +0100517 propertyValueReader: func(properties *HiddenAPIFlagFileProperties) []string {
Paul Duffin9b61abb2022-07-27 16:16:54 +0000518 return properties.Hidden_api.Blocked
Paul Duffine3dc6602021-04-14 09:50:43 +0100519 },
520 commandMutator: func(command *android.RuleBuilderCommand, path android.Path) {
521 command.FlagWithInput("--blocked ", path)
522 },
523 },
Paul Duffin46169772021-04-14 15:01:56 +0100524 // See HiddenAPIFlagFileProperties.Unsupported_packages
Paul Duffine3dc6602021-04-14 09:50:43 +0100525 {
Paul Duffin524c82c2021-06-09 14:39:28 +0100526 PropertyName: "unsupported_packages",
Paul Duffincc17bfe2021-04-19 13:21:20 +0100527 propertyValueReader: func(properties *HiddenAPIFlagFileProperties) []string {
Paul Duffin9b61abb2022-07-27 16:16:54 +0000528 return properties.Hidden_api.Unsupported_packages
Paul Duffine3dc6602021-04-14 09:50:43 +0100529 },
530 commandMutator: func(command *android.RuleBuilderCommand, path android.Path) {
531 command.FlagWithInput("--unsupported ", path).Flag("--packages ")
532 },
533 },
Paul Duffin702210b2021-04-08 20:12:41 +0100534}
535
Paul Duffin438eb572021-05-21 16:58:23 +0100536// FlagFilesByCategory maps a hiddenAPIFlagFileCategory to the paths to the files in that category.
537type FlagFilesByCategory map[*hiddenAPIFlagFileCategory]android.Paths
538
Paul Duffin3f1ae0b2022-07-27 16:27:42 +0000539// append the supplied flags files to the corresponding category in this map.
Paul Duffin438eb572021-05-21 16:58:23 +0100540func (s FlagFilesByCategory) append(other FlagFilesByCategory) {
Paul Duffin524c82c2021-06-09 14:39:28 +0100541 for _, category := range HiddenAPIFlagFileCategories {
Paul Duffin438eb572021-05-21 16:58:23 +0100542 s[category] = append(s[category], other[category]...)
543 }
544}
545
Paul Duffin3f1ae0b2022-07-27 16:27:42 +0000546// sort the paths for each category in this map.
547func (s FlagFilesByCategory) sort() {
548 for category, value := range s {
549 s[category] = android.SortedUniquePaths(value)
550 }
551}
552
Paul Duffinaf99afa2021-05-21 22:18:56 +0100553// HiddenAPIInfo contains information provided by the hidden API processing.
Paul Duffin2fef1362021-04-15 13:32:00 +0100554//
Paul Duffinaf99afa2021-05-21 22:18:56 +0100555// That includes paths resolved from HiddenAPIFlagFileProperties and also generated by hidden API
556// processing.
557type HiddenAPIInfo struct {
Paul Duffin438eb572021-05-21 16:58:23 +0100558 // FlagFilesByCategory maps from the flag file category to the paths containing information for
559 // that category.
560 FlagFilesByCategory FlagFilesByCategory
Paul Duffin2fef1362021-04-15 13:32:00 +0100561
Paul Duffin280a31a2021-06-27 20:28:29 +0100562 // The paths to the stub dex jars for each of the *HiddenAPIScope in hiddenAPIScopes provided by
563 // this fragment and the fragments on which this depends.
564 TransitiveStubDexJarsByScope StubDexJarsByModule
Paul Duffin18cf1972021-05-21 22:46:59 +0100565
Paul Duffin1e6f5c42021-05-21 16:15:31 +0100566 // The output from the hidden API processing needs to be made available to other modules.
567 HiddenAPIFlagOutput
Paul Duffinc6bb7cf2021-04-08 17:49:27 +0100568}
Paul Duffin702210b2021-04-08 20:12:41 +0100569
Paul Duffinf1b358c2021-05-17 07:38:47 +0100570func newHiddenAPIInfo() *HiddenAPIInfo {
571 info := HiddenAPIInfo{
Paul Duffin31fad802021-06-18 18:14:25 +0100572 FlagFilesByCategory: FlagFilesByCategory{},
Paul Duffin280a31a2021-06-27 20:28:29 +0100573 TransitiveStubDexJarsByScope: StubDexJarsByModule{},
Paul Duffinf1b358c2021-05-17 07:38:47 +0100574 }
575 return &info
576}
577
578func (i *HiddenAPIInfo) mergeFromFragmentDeps(ctx android.ModuleContext, fragments []android.Module) {
579 // Merge all the information from the fragments. The fragments form a DAG so it is possible that
580 // this will introduce duplicates so they will be resolved after processing all the fragments.
581 for _, fragment := range fragments {
Colin Cross313aa542023-12-13 13:47:44 -0800582 if info, ok := android.OtherModuleProvider(ctx, fragment, HiddenAPIInfoProvider); ok {
Paul Duffin280a31a2021-06-27 20:28:29 +0100583 i.TransitiveStubDexJarsByScope.addStubDexJarsByModule(info.TransitiveStubDexJarsByScope)
Paul Duffinf1b358c2021-05-17 07:38:47 +0100584 }
585 }
Paul Duffinf1b358c2021-05-17 07:38:47 +0100586}
587
Paul Duffin191be3a2021-08-10 16:14:16 +0100588// StubFlagSubset returns a SignatureCsvSubset that contains a path to a filtered-stub-flags.csv
589// file and a path to a signature-patterns.csv file that defines a subset of the monolithic stub
590// flags file, i.e. out/soong/hiddenapi/hiddenapi-stub-flags.txt, against which it will be compared.
Paul Duffin67b9d612021-07-21 17:38:47 +0100591func (i *HiddenAPIInfo) StubFlagSubset() SignatureCsvSubset {
Paul Duffin191be3a2021-08-10 16:14:16 +0100592 return SignatureCsvSubset{i.FilteredStubFlagsPath, i.SignaturePatternsPath}
Paul Duffin67b9d612021-07-21 17:38:47 +0100593}
594
Paul Duffin191be3a2021-08-10 16:14:16 +0100595// FlagSubset returns a SignatureCsvSubset that contains a path to a filtered-flags.csv file and a
Paul Duffin67b9d612021-07-21 17:38:47 +0100596// path to a signature-patterns.csv file that defines a subset of the monolithic flags file, i.e.
597// out/soong/hiddenapi/hiddenapi-flags.csv, against which it will be compared.
598func (i *HiddenAPIInfo) FlagSubset() SignatureCsvSubset {
Paul Duffin191be3a2021-08-10 16:14:16 +0100599 return SignatureCsvSubset{i.FilteredFlagsPath, i.SignaturePatternsPath}
Paul Duffin67b9d612021-07-21 17:38:47 +0100600}
601
Colin Crossbc7d76c2023-12-12 16:39:03 -0800602var HiddenAPIInfoProvider = blueprint.NewProvider[HiddenAPIInfo]()
Paul Duffin9b381ef2021-04-08 23:01:37 +0100603
Paul Duffin887efdd2022-09-14 16:37:12 +0100604// HiddenAPIInfoForSdk contains information provided by the hidden API processing for use
605// by the sdk snapshot.
606//
607// That includes paths resolved from HiddenAPIFlagFileProperties and also generated by hidden API
608// processing.
609type HiddenAPIInfoForSdk struct {
610 // FlagFilesByCategory maps from the flag file category to the paths containing information for
611 // that category.
612 FlagFilesByCategory FlagFilesByCategory
613
614 // The output from the hidden API processing needs to be made available to other modules.
615 HiddenAPIFlagOutput
616}
617
618// Provides hidden API info for the sdk snapshot.
Colin Crossbc7d76c2023-12-12 16:39:03 -0800619var HiddenAPIInfoForSdkProvider = blueprint.NewProvider[HiddenAPIInfoForSdk]()
Paul Duffin887efdd2022-09-14 16:37:12 +0100620
Paul Duffin280a31a2021-06-27 20:28:29 +0100621// ModuleStubDexJars contains the stub dex jars provided by a single module.
622//
623// It maps a *HiddenAPIScope to the path to stub dex jars appropriate for that scope. See
624// hiddenAPIScopes for a list of the acceptable *HiddenAPIScope values.
625type ModuleStubDexJars map[*HiddenAPIScope]android.Path
Paul Duffin1352f7c2021-05-21 22:18:49 +0100626
Paul Duffin280a31a2021-06-27 20:28:29 +0100627// stubDexJarForWidestAPIScope returns the stub dex jars for the widest API scope provided by this
Paul Duffin1352f7c2021-05-21 22:18:49 +0100628// map.
Paul Duffin280a31a2021-06-27 20:28:29 +0100629//
630// The relative width of APIs is determined by their order in hiddenAPIScopes.
631func (s ModuleStubDexJars) stubDexJarForWidestAPIScope() android.Path {
Paul Duffin5cca7c42021-05-26 10:16:01 +0100632 for i := len(hiddenAPIScopes) - 1; i >= 0; i-- {
633 apiScope := hiddenAPIScopes[i]
Paul Duffin280a31a2021-06-27 20:28:29 +0100634 if stubsForAPIScope, ok := s[apiScope]; ok {
Paul Duffin5cca7c42021-05-26 10:16:01 +0100635 return stubsForAPIScope
636 }
637 }
638
639 return nil
640}
641
Paul Duffin280a31a2021-06-27 20:28:29 +0100642// StubDexJarsByModule contains the stub dex jars provided by a set of modules.
643//
644// It maps a module name to the path to the stub dex jars provided by that module.
645type StubDexJarsByModule map[string]ModuleStubDexJars
646
647// addStubDexJar adds a stub dex jar path provided by the specified module for the specified scope.
648func (s StubDexJarsByModule) addStubDexJar(ctx android.ModuleContext, module android.Module, scope *HiddenAPIScope, stubDexJar android.Path) {
649 name := android.RemoveOptionalPrebuiltPrefix(module.Name())
Paul Duffin3f0290e2021-06-30 18:25:36 +0100650
651 // Each named module provides one dex jar for each scope. However, in some cases different API
652 // versions of a single classes are provided by separate modules. e.g. the core platform
653 // version of java.lang.Object is provided by the legacy.art.module.platform.api module but the
654 // public version is provided by the art.module.public.api module. In those cases it is necessary
655 // to treat all those modules as they were the same name, otherwise it will result in multiple
656 // definitions of a single class being passed to hidden API processing which will cause an error.
Jihoon Kang244d42a2023-10-06 16:54:58 +0000657 if name == scope.nonUpdatablePrebuiltModule || name == scope.nonUpdatableSourceModule || name == scope.nonUpdatableFromTextModule {
Paul Duffin280a31a2021-06-27 20:28:29 +0100658 // Treat all *android-non-updatable* modules as if they were part of an android-non-updatable
659 // java_sdk_library.
660 // TODO(b/192067200): Remove once android-non-updatable is a java_sdk_library or equivalent.
661 name = "android-non-updatable"
662 } else if name == "legacy.art.module.platform.api" {
663 // Treat legacy.art.module.platform.api as if it was an API scope provided by the
664 // art.module.public.api java_sdk_library which will be the case once the former has been
665 // migrated to a module_lib API.
666 name = "art.module.public.api"
667 } else if name == "legacy.i18n.module.platform.api" {
668 // Treat legacy.i18n.module.platform.api as if it was an API scope provided by the
669 // i18n.module.public.api java_sdk_library which will be the case once the former has been
670 // migrated to a module_lib API.
671 name = "i18n.module.public.api"
672 } else if name == "conscrypt.module.platform.api" {
673 // Treat conscrypt.module.platform.api as if it was an API scope provided by the
674 // conscrypt.module.public.api java_sdk_library which will be the case once the former has been
675 // migrated to a module_lib API.
676 name = "conscrypt.module.public.api"
Paul Duffin3f0290e2021-06-30 18:25:36 +0100677 } else if d, ok := module.(SdkLibraryComponentDependency); ok {
678 sdkLibraryName := d.SdkLibraryName()
679 if sdkLibraryName != nil {
680 // The module is a component of a java_sdk_library so use the name of the java_sdk_library.
681 // e.g. if this module is `foo.system.stubs` and is part of the `foo` java_sdk_library then
682 // use `foo` as the name.
683 name = *sdkLibraryName
684 }
Paul Duffin280a31a2021-06-27 20:28:29 +0100685 }
686 stubDexJarsByScope := s[name]
687 if stubDexJarsByScope == nil {
688 stubDexJarsByScope = ModuleStubDexJars{}
689 s[name] = stubDexJarsByScope
690 }
691 stubDexJarsByScope[scope] = stubDexJar
692}
693
694// addStubDexJarsByModule adds the stub dex jars in the supplied StubDexJarsByModule to this map.
695func (s StubDexJarsByModule) addStubDexJarsByModule(other StubDexJarsByModule) {
696 for module, stubDexJarsByScope := range other {
697 s[module] = stubDexJarsByScope
698 }
699}
700
701// StubDexJarsForWidestAPIScope returns a list of stub dex jars containing the widest API scope
702// provided by each module.
703//
704// The relative width of APIs is determined by their order in hiddenAPIScopes.
705func (s StubDexJarsByModule) StubDexJarsForWidestAPIScope() android.Paths {
706 stubDexJars := android.Paths{}
Cole Faust18994c72023-02-28 16:02:16 -0800707 modules := android.SortedKeys(s)
Paul Duffin280a31a2021-06-27 20:28:29 +0100708 for _, module := range modules {
709 stubDexJarsByScope := s[module]
710
711 stubDexJars = append(stubDexJars, stubDexJarsByScope.stubDexJarForWidestAPIScope())
712 }
713
714 return stubDexJars
715}
716
717// StubDexJarsForScope returns a list of stub dex jars containing the stub dex jars provided by each
718// module for the specified scope.
719//
720// If a module does not provide a stub dex jar for the supplied scope then it does not contribute to
721// the returned list.
722func (s StubDexJarsByModule) StubDexJarsForScope(scope *HiddenAPIScope) android.Paths {
723 stubDexJars := android.Paths{}
Cole Faust18994c72023-02-28 16:02:16 -0800724 modules := android.SortedKeys(s)
Paul Duffin280a31a2021-06-27 20:28:29 +0100725 for _, module := range modules {
726 stubDexJarsByScope := s[module]
727 // Not every module will have the same set of
728 if jars, ok := stubDexJarsByScope[scope]; ok {
729 stubDexJars = append(stubDexJars, jars)
730 }
731 }
732
733 return stubDexJars
734}
735
Paul Duffin1e9e9382022-07-27 15:55:06 +0000736type HiddenAPIPropertyInfo struct {
Paul Duffin1352f7c2021-05-21 22:18:49 +0100737 // FlagFilesByCategory contains the flag files that override the initial flags that are derived
738 // from the stub dex files.
739 FlagFilesByCategory FlagFilesByCategory
740
Paul Duffin1e9e9382022-07-27 15:55:06 +0000741 // See HiddenAPIFlagFileProperties.Package_prefixes
742 PackagePrefixes []string
743
744 // See HiddenAPIFlagFileProperties.Single_packages
745 SinglePackages []string
746
747 // See HiddenAPIFlagFileProperties.Split_packages
748 SplitPackages []string
749}
750
Colin Crossbc7d76c2023-12-12 16:39:03 -0800751var hiddenAPIPropertyInfoProvider = blueprint.NewProvider[HiddenAPIPropertyInfo]()
Paul Duffin3f1ae0b2022-07-27 16:27:42 +0000752
Paul Duffin1e9e9382022-07-27 15:55:06 +0000753// newHiddenAPIPropertyInfo creates a new initialized HiddenAPIPropertyInfo struct.
754func newHiddenAPIPropertyInfo() HiddenAPIPropertyInfo {
755 return HiddenAPIPropertyInfo{
756 FlagFilesByCategory: FlagFilesByCategory{},
757 }
758}
759
760// extractFlagFilesFromProperties extracts the paths to flag files that are specified in the
761// supplied properties and stores them in this struct.
762func (i *HiddenAPIPropertyInfo) extractFlagFilesFromProperties(ctx android.ModuleContext, p *HiddenAPIFlagFileProperties) {
763 for _, category := range HiddenAPIFlagFileCategories {
764 paths := android.PathsForModuleSrc(ctx, category.propertyValueReader(p))
765 i.FlagFilesByCategory[category] = paths
766 }
767}
768
769// extractPackageRulesFromProperties extracts the package rules that are specified in the supplied
770// properties and stores them in this struct.
771func (i *HiddenAPIPropertyInfo) extractPackageRulesFromProperties(p *HiddenAPIPackageProperties) {
772 i.PackagePrefixes = p.Hidden_api.Package_prefixes
773 i.SinglePackages = p.Hidden_api.Single_packages
774 i.SplitPackages = p.Hidden_api.Split_packages
775}
776
Paul Duffin3f1ae0b2022-07-27 16:27:42 +0000777func (i *HiddenAPIPropertyInfo) gatherPropertyInfo(ctx android.ModuleContext, contents []android.Module) {
778 for _, module := range contents {
Colin Cross313aa542023-12-13 13:47:44 -0800779 if info, ok := android.OtherModuleProvider(ctx, module, hiddenAPIPropertyInfoProvider); ok {
Paul Duffin3f1ae0b2022-07-27 16:27:42 +0000780 i.FlagFilesByCategory.append(info.FlagFilesByCategory)
781 i.PackagePrefixes = append(i.PackagePrefixes, info.PackagePrefixes...)
782 i.SinglePackages = append(i.SinglePackages, info.SinglePackages...)
783 i.SplitPackages = append(i.SplitPackages, info.SplitPackages...)
784 }
785 }
786
787 // Dedup and sort the information to ensure consistent builds.
788 i.FlagFilesByCategory.sort()
789 i.PackagePrefixes = android.SortedUniqueStrings(i.PackagePrefixes)
790 i.SinglePackages = android.SortedUniqueStrings(i.SinglePackages)
791 i.SplitPackages = android.SortedUniqueStrings(i.SplitPackages)
792}
793
Paul Duffin1e9e9382022-07-27 15:55:06 +0000794// HiddenAPIFlagInput encapsulates information obtained from a module and its dependencies that are
795// needed for hidden API flag generation.
796type HiddenAPIFlagInput struct {
797 HiddenAPIPropertyInfo
798
Paul Duffin31fad802021-06-18 18:14:25 +0100799 // StubDexJarsByScope contains the stub dex jars for different *HiddenAPIScope and which determine
Paul Duffin1352f7c2021-05-21 22:18:49 +0100800 // the initial flags for each dex member.
Paul Duffin280a31a2021-06-27 20:28:29 +0100801 StubDexJarsByScope StubDexJarsByModule
Paul Duffinf1b358c2021-05-17 07:38:47 +0100802
Paul Duffin31fad802021-06-18 18:14:25 +0100803 // DependencyStubDexJarsByScope contains the stub dex jars provided by the fragments on which this
804 // depends. It is the result of merging HiddenAPIInfo.TransitiveStubDexJarsByScope from each
Paul Duffinf1b358c2021-05-17 07:38:47 +0100805 // fragment on which this depends.
Paul Duffin280a31a2021-06-27 20:28:29 +0100806 DependencyStubDexJarsByScope StubDexJarsByModule
Paul Duffin32cf58a2021-05-18 16:32:50 +0100807
Paul Duffin5cca7c42021-05-26 10:16:01 +0100808 // AdditionalStubDexJarsByScope contains stub dex jars provided by other modules in addition to
809 // the ones that are obtained from fragments on which this depends.
810 //
811 // These are kept separate from stub dex jars in HiddenAPIFlagInput.DependencyStubDexJarsByScope
812 // as there are not propagated transitively to other fragments that depend on this.
Paul Duffin280a31a2021-06-27 20:28:29 +0100813 AdditionalStubDexJarsByScope StubDexJarsByModule
Paul Duffin5cca7c42021-05-26 10:16:01 +0100814
Paul Duffin32cf58a2021-05-18 16:32:50 +0100815 // RemovedTxtFiles is the list of removed.txt files provided by java_sdk_library modules that are
816 // specified in the bootclasspath_fragment's stub_libs and contents properties.
817 RemovedTxtFiles android.Paths
Paul Duffin1352f7c2021-05-21 22:18:49 +0100818}
819
Paul Duffin1e9e9382022-07-27 15:55:06 +0000820// newHiddenAPIFlagInput creates a new initialized HiddenAPIFlagInput struct.
Paul Duffin1352f7c2021-05-21 22:18:49 +0100821func newHiddenAPIFlagInput() HiddenAPIFlagInput {
822 input := HiddenAPIFlagInput{
Paul Duffin1e9e9382022-07-27 15:55:06 +0000823 HiddenAPIPropertyInfo: newHiddenAPIPropertyInfo(),
Paul Duffin280a31a2021-06-27 20:28:29 +0100824 StubDexJarsByScope: StubDexJarsByModule{},
825 DependencyStubDexJarsByScope: StubDexJarsByModule{},
826 AdditionalStubDexJarsByScope: StubDexJarsByModule{},
Paul Duffin1352f7c2021-05-21 22:18:49 +0100827 }
828
829 return input
830}
831
832// gatherStubLibInfo gathers information from the stub libs needed by hidden API processing from the
833// dependencies added in hiddenAPIAddStubLibDependencies.
834//
835// That includes paths to the stub dex jars as well as paths to the *removed.txt files.
836func (i *HiddenAPIFlagInput) gatherStubLibInfo(ctx android.ModuleContext, contents []android.Module) {
Paul Duffin31fad802021-06-18 18:14:25 +0100837 addFromModule := func(ctx android.ModuleContext, module android.Module, apiScope *HiddenAPIScope) {
838 sdkKind := apiScope.sdkKind
839 dexJar := hiddenAPIRetrieveDexJarBuildPath(ctx, module, sdkKind)
Paul Duffin1352f7c2021-05-21 22:18:49 +0100840 if dexJar != nil {
Paul Duffin280a31a2021-06-27 20:28:29 +0100841 i.StubDexJarsByScope.addStubDexJar(ctx, module, apiScope, dexJar)
Paul Duffin1352f7c2021-05-21 22:18:49 +0100842 }
Paul Duffin32cf58a2021-05-18 16:32:50 +0100843
844 if sdkLibrary, ok := module.(SdkLibraryDependency); ok {
Paul Duffin31fad802021-06-18 18:14:25 +0100845 removedTxtFile := sdkLibrary.SdkRemovedTxtFile(ctx, sdkKind)
Paul Duffin32cf58a2021-05-18 16:32:50 +0100846 i.RemovedTxtFiles = append(i.RemovedTxtFiles, removedTxtFile.AsPaths()...)
847 }
Paul Duffin1352f7c2021-05-21 22:18:49 +0100848 }
849
850 // If the contents includes any java_sdk_library modules then add them to the stubs.
851 for _, module := range contents {
852 if _, ok := module.(SdkLibraryDependency); ok {
Paul Duffin31fad802021-06-18 18:14:25 +0100853 // Add information for every possible API scope needed by hidden API.
854 for _, apiScope := range hiddenAPISdkLibrarySupportedScopes {
855 addFromModule(ctx, module, apiScope)
Paul Duffin1352f7c2021-05-21 22:18:49 +0100856 }
857 }
858 }
859
Paul Duffind061d402021-06-07 21:36:01 +0100860 ctx.VisitDirectDeps(func(module android.Module) {
Paul Duffin1352f7c2021-05-21 22:18:49 +0100861 tag := ctx.OtherModuleDependencyTag(module)
862 if hiddenAPIStubsTag, ok := tag.(hiddenAPIStubsDependencyTag); ok {
Paul Duffin31fad802021-06-18 18:14:25 +0100863 apiScope := hiddenAPIStubsTag.apiScope
Paul Duffin5cca7c42021-05-26 10:16:01 +0100864 if hiddenAPIStubsTag.fromAdditionalDependency {
865 dexJar := hiddenAPIRetrieveDexJarBuildPath(ctx, module, apiScope.sdkKind)
866 if dexJar != nil {
Paul Duffin280a31a2021-06-27 20:28:29 +0100867 i.AdditionalStubDexJarsByScope.addStubDexJar(ctx, module, apiScope, dexJar)
Paul Duffin5cca7c42021-05-26 10:16:01 +0100868 }
869 } else {
870 addFromModule(ctx, module, apiScope)
871 }
Paul Duffin1352f7c2021-05-21 22:18:49 +0100872 }
873 })
874
875 // Normalize the paths, i.e. remove duplicates and sort.
Paul Duffin32cf58a2021-05-18 16:32:50 +0100876 i.RemovedTxtFiles = android.SortedUniquePaths(i.RemovedTxtFiles)
Paul Duffin1352f7c2021-05-21 22:18:49 +0100877}
878
Paul Duffin280a31a2021-06-27 20:28:29 +0100879func (i *HiddenAPIFlagInput) transitiveStubDexJarsByScope() StubDexJarsByModule {
Paul Duffin31fad802021-06-18 18:14:25 +0100880 transitive := i.DependencyStubDexJarsByScope
Paul Duffin280a31a2021-06-27 20:28:29 +0100881 transitive.addStubDexJarsByModule(i.StubDexJarsByScope)
Paul Duffinf1b358c2021-05-17 07:38:47 +0100882 return transitive
883}
884
Paul Duffin1e6f5c42021-05-21 16:15:31 +0100885// HiddenAPIFlagOutput contains paths to output files from the hidden API flag generation for a
886// bootclasspath_fragment module.
887type HiddenAPIFlagOutput struct {
Paul Duffin1e6f5c42021-05-21 16:15:31 +0100888 // The path to the generated annotation-flags.csv file.
889 AnnotationFlagsPath android.Path
890
891 // The path to the generated metadata.csv file.
892 MetadataPath android.Path
893
894 // The path to the generated index.csv file.
895 IndexPath android.Path
896
Paul Duffin191be3a2021-08-10 16:14:16 +0100897 // The path to the generated stub-flags.csv file.
898 StubFlagsPath android.Path
899
Paul Duffin1e6f5c42021-05-21 16:15:31 +0100900 // The path to the generated all-flags.csv file.
901 AllFlagsPath android.Path
Paul Duffin67b9d612021-07-21 17:38:47 +0100902
903 // The path to the generated signature-patterns.txt file which defines the subset of the
904 // monolithic hidden API files provided in this.
905 SignaturePatternsPath android.Path
Paul Duffin191be3a2021-08-10 16:14:16 +0100906
907 // The path to the generated filtered-stub-flags.csv file.
908 FilteredStubFlagsPath android.Path
909
910 // The path to the generated filtered-flags.csv file.
911 FilteredFlagsPath android.Path
Paul Duffin1e6f5c42021-05-21 16:15:31 +0100912}
913
Paul Duffin5f148ca2021-06-02 17:24:22 +0100914// bootDexJarByModule is a map from base module name (without prebuilt_ prefix) to the boot dex
915// path.
916type bootDexJarByModule map[string]android.Path
917
918// addPath adds the path for a module to the map.
919func (b bootDexJarByModule) addPath(module android.Module, path android.Path) {
920 b[android.RemoveOptionalPrebuiltPrefix(module.Name())] = path
921}
922
Paul Duffine5218812021-06-07 13:28:19 +0100923// bootDexJars returns the boot dex jar paths sorted by their keys.
924func (b bootDexJarByModule) bootDexJars() android.Paths {
925 paths := android.Paths{}
Cole Faust18994c72023-02-28 16:02:16 -0800926 for _, k := range android.SortedKeys(b) {
Paul Duffine5218812021-06-07 13:28:19 +0100927 paths = append(paths, b[k])
928 }
929 return paths
930}
931
Paul Duffin7f872162021-06-17 19:33:24 +0100932// bootDexJarsWithoutCoverage returns the boot dex jar paths sorted by their keys without coverage
933// libraries if present.
934func (b bootDexJarByModule) bootDexJarsWithoutCoverage() android.Paths {
935 paths := android.Paths{}
Cole Faust18994c72023-02-28 16:02:16 -0800936 for _, k := range android.SortedKeys(b) {
Paul Duffin7f872162021-06-17 19:33:24 +0100937 if k == "jacocoagent" {
938 continue
939 }
940 paths = append(paths, b[k])
941 }
942 return paths
943}
944
Paul Duffine5218812021-06-07 13:28:19 +0100945// HiddenAPIOutput encapsulates the output from the hidden API processing.
946type HiddenAPIOutput struct {
947 HiddenAPIFlagOutput
948
949 // The map from base module name to the path to the encoded boot dex file.
Spandan Das5be63332023-12-13 00:06:32 +0000950 // This field is not available in prebuilt apexes
Paul Duffine5218812021-06-07 13:28:19 +0100951 EncodedBootDexFilesByModule bootDexJarByModule
952}
953
Paul Duffindfa10832021-05-13 17:31:51 +0100954// pathForValidation creates a path of the same type as the supplied type but with a name of
955// <path>.valid.
956//
957// e.g. If path is an OutputPath for out/soong/hiddenapi/hiddenapi-flags.csv then this will return
958// an OutputPath for out/soong/hiddenapi/hiddenapi-flags.csv.valid
959func pathForValidation(ctx android.PathContext, path android.WritablePath) android.WritablePath {
960 extWithoutLeadingDot := strings.TrimPrefix(path.Ext(), ".")
961 return path.ReplaceExtension(ctx, extWithoutLeadingDot+".valid")
962}
963
Paul Duffin2fef1362021-04-15 13:32:00 +0100964// buildRuleToGenerateHiddenApiFlags creates a rule to create the monolithic hidden API flags from
965// the flags from all the modules, the stub flags, augmented with some additional configuration
966// files.
Paul Duffin702210b2021-04-08 20:12:41 +0100967//
968// baseFlagsPath is the path to the flags file containing all the information from the stubs plus
969// an entry for every single member in the dex implementation jars of the individual modules. Every
970// signature in any of the other files MUST be included in this file.
971//
Paul Duffin537ea3d2021-05-14 10:38:00 +0100972// annotationFlags is the path to the annotation flags file generated from annotation information
973// in each module.
Paul Duffin702210b2021-04-08 20:12:41 +0100974//
Paul Duffinaf99afa2021-05-21 22:18:56 +0100975// hiddenAPIInfo is a struct containing paths to files that augment the information provided by
Paul Duffin537ea3d2021-05-14 10:38:00 +0100976// the annotationFlags.
Paul Duffin32cf58a2021-05-18 16:32:50 +0100977func buildRuleToGenerateHiddenApiFlags(ctx android.BuilderContext, name, desc string,
Paul Duffind061d402021-06-07 21:36:01 +0100978 outputPath android.WritablePath, baseFlagsPath android.Path, annotationFlagPaths android.Paths,
Paul Duffin67b9d612021-07-21 17:38:47 +0100979 flagFilesByCategory FlagFilesByCategory, flagSubsets SignatureCsvSubsets, generatedRemovedDexSignatures android.OptionalPath) {
Paul Duffindfa10832021-05-13 17:31:51 +0100980
Paul Duffindfa10832021-05-13 17:31:51 +0100981 // Create the rule that will generate the flag files.
Paul Duffind3c15132021-04-21 22:12:35 +0100982 tempPath := tempPathForRestat(ctx, outputPath)
Paul Duffin702210b2021-04-08 20:12:41 +0100983 rule := android.NewRuleBuilder(pctx, ctx)
984 command := rule.Command().
985 BuiltTool("generate_hiddenapi_lists").
986 FlagWithInput("--csv ", baseFlagsPath).
Paul Duffind061d402021-06-07 21:36:01 +0100987 Inputs(annotationFlagPaths).
Paul Duffin702210b2021-04-08 20:12:41 +0100988 FlagWithOutput("--output ", tempPath)
989
Paul Duffine3dc6602021-04-14 09:50:43 +0100990 // Add the options for the different categories of flag files.
Paul Duffin524c82c2021-06-09 14:39:28 +0100991 for _, category := range HiddenAPIFlagFileCategories {
Paul Duffin438eb572021-05-21 16:58:23 +0100992 paths := flagFilesByCategory[category]
Paul Duffine3dc6602021-04-14 09:50:43 +0100993 for _, path := range paths {
994 category.commandMutator(command, path)
995 }
Paul Duffin702210b2021-04-08 20:12:41 +0100996 }
997
Paul Duffin32cf58a2021-05-18 16:32:50 +0100998 // If available then pass the automatically generated file containing dex signatures of removed
999 // API members to the rule so they can be marked as removed.
1000 if generatedRemovedDexSignatures.Valid() {
1001 hiddenAPIRemovedFlagFileCategory.commandMutator(command, generatedRemovedDexSignatures.Path())
1002 }
1003
Paul Duffin702210b2021-04-08 20:12:41 +01001004 commitChangeForRestat(rule, tempPath, outputPath)
1005
Paul Duffin2e880972021-06-23 23:29:09 +01001006 // If there are flag files that have been generated by fragments on which this depends then use
1007 // them to validate the flag file generated by the rules created by this method.
Alyssa Ketpreechasawat7daf2782023-11-01 13:58:39 +00001008 if !ctx.Config().DisableVerifyOverlaps() && len(flagSubsets) > 0 {
Paul Duffinbd88c882022-04-07 23:32:19 +01001009 validFile := buildRuleValidateOverlappingCsvFiles(ctx, name, desc, outputPath, flagSubsets,
1010 HIDDENAPI_FLAGS_CSV_IMPL_FLAGS)
Paul Duffin2e880972021-06-23 23:29:09 +01001011
Paul Duffindfa10832021-05-13 17:31:51 +01001012 // Add the file that indicates that the file generated by this is valid.
1013 //
1014 // This will cause the validation rule above to be run any time that the output of this rule
1015 // changes but the validation will run in parallel with other rules that depend on this file.
1016 command.Validation(validFile)
1017 }
1018
Paul Duffin2fef1362021-04-15 13:32:00 +01001019 rule.Build(name, desc)
1020}
1021
Paul Duffin67b9d612021-07-21 17:38:47 +01001022// SignatureCsvSubset describes a subset of a monolithic flags file, i.e. either
1023// out/soong/hiddenapi/hiddenapi-stub-flags.txt or out/soong/hiddenapi/hiddenapi-flags.csv
1024type SignatureCsvSubset struct {
1025 // The path to the CSV file containing hidden API flags.
1026 //
1027 // It has the dex member signature as the first column, with flags, one per column, in the
1028 // subsequent columns.
1029 CsvFile android.Path
1030
1031 // The path to the CSV file containing the signature patterns.
1032 //
1033 // It is a single column CSV file with the column containing a signature pattern.
1034 SignaturePatternsFile android.Path
1035}
1036
1037type SignatureCsvSubsets []SignatureCsvSubset
1038
1039func (s SignatureCsvSubsets) RelativeToTop() []string {
1040 result := []string{}
1041 for _, subset := range s {
1042 result = append(result, fmt.Sprintf("%s:%s", subset.CsvFile.RelativeToTop(), subset.SignaturePatternsFile.RelativeToTop()))
1043 }
1044 return result
1045}
1046
1047// buildRuleSignaturePatternsFile creates a rule to generate a file containing the set of signature
1048// patterns that will select a subset of the monolithic flags.
Paul Duffin846beb72022-03-15 17:45:57 +00001049func buildRuleSignaturePatternsFile(
1050 ctx android.ModuleContext, flagsPath android.Path,
Paul Duffin1938dba2022-07-26 23:53:00 +00001051 splitPackages []string, packagePrefixes []string, singlePackages []string,
1052 suffix string) android.Path {
1053 hiddenApiSubDir := "modular-hiddenapi" + suffix
1054
1055 patternsFile := android.PathForModuleOut(ctx, hiddenApiSubDir, "signature-patterns.csv")
Paul Duffin67b9d612021-07-21 17:38:47 +01001056 // Create a rule to validate the output from the following rule.
1057 rule := android.NewRuleBuilder(pctx, ctx)
Paul Duffin1e18e982021-08-03 15:42:27 +01001058
1059 // Quote any * in the packages to avoid them being expanded by the shell.
1060 quotedSplitPackages := []string{}
1061 for _, pkg := range splitPackages {
1062 quotedSplitPackages = append(quotedSplitPackages, strings.ReplaceAll(pkg, "*", "\\*"))
1063 }
1064
Paul Duffin67b9d612021-07-21 17:38:47 +01001065 rule.Command().
1066 BuiltTool("signature_patterns").
1067 FlagWithInput("--flags ", flagsPath).
Paul Duffin1e18e982021-08-03 15:42:27 +01001068 FlagForEachArg("--split-package ", quotedSplitPackages).
1069 FlagForEachArg("--package-prefix ", packagePrefixes).
Paul Duffin846beb72022-03-15 17:45:57 +00001070 FlagForEachArg("--single-package ", singlePackages).
Paul Duffin67b9d612021-07-21 17:38:47 +01001071 FlagWithOutput("--output ", patternsFile)
Paul Duffin1938dba2022-07-26 23:53:00 +00001072 rule.Build("hiddenAPISignaturePatterns"+suffix, "hidden API signature patterns"+suffix)
Paul Duffin67b9d612021-07-21 17:38:47 +01001073
1074 return patternsFile
1075}
1076
Paul Duffinbd88c882022-04-07 23:32:19 +01001077// buildRuleRemoveSignaturesWithImplementationFlags creates a rule that will remove signatures from
1078// the input flags file which have only the implementation flags, i.e. are not part of an API.
1079//
1080// The implementationFlags specifies the set of default flags that identifies the signature of a
1081// private, implementation only, member. Signatures that match those flags are removed from the
1082// flags as they are implementation only.
1083//
1084// This is used to remove implementation only signatures from the signature files that are persisted
1085// in the sdk snapshot as the sdk snapshots should not include implementation details. The
1086// signatures generated by this method will be compared by the buildRuleValidateOverlappingCsvFiles
1087// method which treats any missing signatures as if they were implementation only signatures.
1088func buildRuleRemoveSignaturesWithImplementationFlags(ctx android.BuilderContext,
1089 name string, desc string, inputPath android.Path, filteredPath android.WritablePath,
1090 implementationFlags []string) {
1091
Paul Duffin280bae62021-07-20 18:03:53 +01001092 rule := android.NewRuleBuilder(pctx, ctx)
Paul Duffinbd88c882022-04-07 23:32:19 +01001093 implementationFlagPattern := ""
1094 for _, implementationFlag := range implementationFlags {
1095 implementationFlagPattern = implementationFlagPattern + "," + implementationFlag
1096 }
Paul Duffin280bae62021-07-20 18:03:53 +01001097 rule.Command().
Paul Duffinbd88c882022-04-07 23:32:19 +01001098 Text(`grep -vE "^[^,]+` + implementationFlagPattern + `$"`).Input(inputPath).
1099 Text(">").Output(filteredPath).
Paul Duffin280bae62021-07-20 18:03:53 +01001100 // Grep's exit code depends on whether it finds anything. It is 0 (build success) when it finds
1101 // something and 1 (build failure) when it does not and 2 (when it encounters an error).
1102 // However, while it is unlikely it is not an error if this does not find any matches. The
1103 // following will only run if the grep does not find something and in that case it will treat
1104 // an exit code of 1 as success and anything else as failure.
1105 Text("|| test $? -eq 1")
1106 rule.Build(name, desc)
1107}
1108
Paul Duffin2e880972021-06-23 23:29:09 +01001109// buildRuleValidateOverlappingCsvFiles checks that the modular CSV files, i.e. the files generated
1110// by the individual bootclasspath_fragment modules are subsets of the monolithic CSV file.
Paul Duffinbd88c882022-04-07 23:32:19 +01001111//
1112// The implementationFlags specifies the set of default flags that identifies the signature of a
1113// private, implementation only, member. A signature which is present in a monolithic flags subset
1114// defined by SignatureCsvSubset but which is not present in the flags file from the corresponding
1115// module is assumed to be an implementation only member and so must have these flags.
1116func buildRuleValidateOverlappingCsvFiles(ctx android.BuilderContext, name string, desc string,
1117 monolithicFilePath android.WritablePath, csvSubsets SignatureCsvSubsets,
1118 implementationFlags []string) android.WritablePath {
Paul Duffin2e880972021-06-23 23:29:09 +01001119 // The file which is used to record that the flags file is valid.
1120 validFile := pathForValidation(ctx, monolithicFilePath)
1121
1122 // Create a rule to validate the output from the following rule.
1123 rule := android.NewRuleBuilder(pctx, ctx)
Paul Duffin67b9d612021-07-21 17:38:47 +01001124 command := rule.Command().
Paul Duffin2e880972021-06-23 23:29:09 +01001125 BuiltTool("verify_overlaps").
Paul Duffin0c12b782022-04-08 00:28:11 +01001126 FlagWithInput("--monolithic-flags ", monolithicFilePath)
Paul Duffin67b9d612021-07-21 17:38:47 +01001127
1128 for _, subset := range csvSubsets {
1129 command.
Paul Duffin0c12b782022-04-08 00:28:11 +01001130 Flag("--module-flags ").
Paul Duffin67b9d612021-07-21 17:38:47 +01001131 Textf("%s:%s", subset.CsvFile, subset.SignaturePatternsFile).
1132 Implicit(subset.CsvFile).Implicit(subset.SignaturePatternsFile)
1133 }
1134
Paul Duffinbd88c882022-04-07 23:32:19 +01001135 for _, implementationFlag := range implementationFlags {
1136 command.FlagWithArg("--implementation-flag ", implementationFlag)
1137 }
1138
Paul Duffin67b9d612021-07-21 17:38:47 +01001139 // If validation passes then update the file that records that.
1140 command.Text("&& touch").Output(validFile)
Paul Duffin2e880972021-06-23 23:29:09 +01001141 rule.Build(name+"Validation", desc+" validation")
1142
1143 return validFile
1144}
1145
Paul Duffinaf705182022-09-14 11:47:34 +01001146// hiddenAPIFlagRulesForBootclasspathFragment will generate all the flags for a fragment of the
1147// bootclasspath.
Paul Duffin2fef1362021-04-15 13:32:00 +01001148//
1149// It takes:
1150// * Map from android.SdkKind to stub dex jar paths defining the API for that sdk kind.
1151// * The list of modules that are the contents of the fragment.
1152// * The additional manually curated flag files to use.
1153//
1154// It generates:
1155// * stub-flags.csv
1156// * annotation-flags.csv
1157// * metadata.csv
1158// * index.csv
1159// * all-flags.csv
Paul Duffin1938dba2022-07-26 23:53:00 +00001160func hiddenAPIFlagRulesForBootclasspathFragment(ctx android.ModuleContext, bootDexInfoByModule bootDexInfoByModule, contents []android.Module, input HiddenAPIFlagInput, suffix string) HiddenAPIFlagOutput {
1161 hiddenApiSubDir := "modular-hiddenapi" + suffix
Paul Duffin2fef1362021-04-15 13:32:00 +01001162
Paul Duffin1352f7c2021-05-21 22:18:49 +01001163 // Generate the stub-flags.csv.
Paul Duffin2fef1362021-04-15 13:32:00 +01001164 stubFlagsCSV := android.PathForModuleOut(ctx, hiddenApiSubDir, "stub-flags.csv")
Paul Duffin1938dba2022-07-26 23:53:00 +00001165 buildRuleToGenerateHiddenAPIStubFlagsFile(ctx, "modularHiddenAPIStubFlagsFile"+suffix, "modular hiddenapi stub flags", stubFlagsCSV, bootDexInfoByModule.bootDexJars(), input, nil)
Paul Duffin2fef1362021-04-15 13:32:00 +01001166
Paul Duffin537ea3d2021-05-14 10:38:00 +01001167 // Extract the classes jars from the contents.
Paul Duffindd5993f2021-06-10 10:18:22 +01001168 classesJars := extractClassesJarsFromModules(contents)
Paul Duffin537ea3d2021-05-14 10:38:00 +01001169
Paul Duffin2fef1362021-04-15 13:32:00 +01001170 // Generate the set of flags from the annotations in the source code.
1171 annotationFlagsCSV := android.PathForModuleOut(ctx, hiddenApiSubDir, "annotation-flags.csv")
Paul Duffin1938dba2022-07-26 23:53:00 +00001172 buildRuleToGenerateAnnotationFlags(ctx, "modular hiddenapi annotation flags"+suffix, classesJars, stubFlagsCSV, annotationFlagsCSV)
Paul Duffin2fef1362021-04-15 13:32:00 +01001173
1174 // Generate the metadata from the annotations in the source code.
1175 metadataCSV := android.PathForModuleOut(ctx, hiddenApiSubDir, "metadata.csv")
Paul Duffin1938dba2022-07-26 23:53:00 +00001176 buildRuleToGenerateMetadata(ctx, "modular hiddenapi metadata"+suffix, classesJars, stubFlagsCSV, metadataCSV)
Paul Duffin2fef1362021-04-15 13:32:00 +01001177
Paul Duffin537ea3d2021-05-14 10:38:00 +01001178 // Generate the index file from the CSV files in the classes jars.
Paul Duffin2fef1362021-04-15 13:32:00 +01001179 indexCSV := android.PathForModuleOut(ctx, hiddenApiSubDir, "index.csv")
Paul Duffin1938dba2022-07-26 23:53:00 +00001180 buildRuleToGenerateIndex(ctx, "modular hiddenapi index"+suffix, classesJars, indexCSV)
Paul Duffin2fef1362021-04-15 13:32:00 +01001181
Paul Duffinaf99afa2021-05-21 22:18:56 +01001182 // Removed APIs need to be marked and in order to do that the hiddenAPIInfo needs to specify files
Paul Duffin2fef1362021-04-15 13:32:00 +01001183 // containing dex signatures of all the removed APIs. In the monolithic files that is done by
1184 // manually combining all the removed.txt files for each API and then converting them to dex
Paul Duffin32cf58a2021-05-18 16:32:50 +01001185 // signatures, see the combined-removed-dex module. This does that automatically by using the
1186 // *removed.txt files retrieved from the java_sdk_library modules that are specified in the
1187 // stub_libs and contents properties of a bootclasspath_fragment.
Paul Duffin1938dba2022-07-26 23:53:00 +00001188 removedDexSignatures := buildRuleToGenerateRemovedDexSignatures(ctx, suffix, input.RemovedTxtFiles)
Paul Duffin2fef1362021-04-15 13:32:00 +01001189
1190 // Generate the all-flags.csv which are the flags that will, in future, be encoded into the dex
1191 // files.
Paul Duffine5218812021-06-07 13:28:19 +01001192 allFlagsCSV := android.PathForModuleOut(ctx, hiddenApiSubDir, "all-flags.csv")
Paul Duffin1938dba2022-07-26 23:53:00 +00001193 buildRuleToGenerateHiddenApiFlags(ctx, "modularHiddenApiAllFlags"+suffix, "modular hiddenapi all flags"+suffix, allFlagsCSV, stubFlagsCSV, android.Paths{annotationFlagsCSV}, input.FlagFilesByCategory, nil, removedDexSignatures)
Paul Duffine5218812021-06-07 13:28:19 +01001194
Paul Duffin280bae62021-07-20 18:03:53 +01001195 // Generate the filtered-stub-flags.csv file which contains the filtered stub flags that will be
1196 // compared against the monolithic stub flags.
1197 filteredStubFlagsCSV := android.PathForModuleOut(ctx, hiddenApiSubDir, "filtered-stub-flags.csv")
Paul Duffin1938dba2022-07-26 23:53:00 +00001198 buildRuleRemoveSignaturesWithImplementationFlags(ctx, "modularHiddenApiFilteredStubFlags"+suffix,
1199 "modular hiddenapi filtered stub flags"+suffix, stubFlagsCSV, filteredStubFlagsCSV,
Paul Duffinbd88c882022-04-07 23:32:19 +01001200 HIDDENAPI_STUB_FLAGS_IMPL_FLAGS)
Paul Duffin280bae62021-07-20 18:03:53 +01001201
1202 // Generate the filtered-flags.csv file which contains the filtered flags that will be compared
1203 // against the monolithic flags.
1204 filteredFlagsCSV := android.PathForModuleOut(ctx, hiddenApiSubDir, "filtered-flags.csv")
Paul Duffin1938dba2022-07-26 23:53:00 +00001205 buildRuleRemoveSignaturesWithImplementationFlags(ctx, "modularHiddenApiFilteredFlags"+suffix,
1206 "modular hiddenapi filtered flags"+suffix, allFlagsCSV, filteredFlagsCSV,
Paul Duffinbd88c882022-04-07 23:32:19 +01001207 HIDDENAPI_FLAGS_CSV_IMPL_FLAGS)
Paul Duffin280bae62021-07-20 18:03:53 +01001208
Paul Duffin2fef1362021-04-15 13:32:00 +01001209 // Store the paths in the info for use by other modules and sdk snapshot generation.
Paul Duffinaf705182022-09-14 11:47:34 +01001210 return HiddenAPIFlagOutput{
1211 AnnotationFlagsPath: annotationFlagsCSV,
1212 MetadataPath: metadataCSV,
1213 IndexPath: indexCSV,
1214 StubFlagsPath: stubFlagsCSV,
1215 AllFlagsPath: allFlagsCSV,
1216 FilteredStubFlagsPath: filteredStubFlagsCSV,
1217 FilteredFlagsPath: filteredFlagsCSV,
Paul Duffin1e6f5c42021-05-21 16:15:31 +01001218 }
Paul Duffinaf705182022-09-14 11:47:34 +01001219}
1220
1221// hiddenAPIEncodeRulesForBootclasspathFragment generates rules to encode hidden API flags into the
1222// dex jars in bootDexInfoByModule.
1223func hiddenAPIEncodeRulesForBootclasspathFragment(ctx android.ModuleContext, bootDexInfoByModule bootDexInfoByModule, allFlagsCSV android.Path) bootDexJarByModule {
1224 // Encode the flags into the boot dex files.
1225 encodedBootDexJarsByModule := bootDexJarByModule{}
1226 outputDir := android.PathForModuleOut(ctx, "hiddenapi-modular/encoded").OutputPath
Cole Faust18994c72023-02-28 16:02:16 -08001227 for _, name := range android.SortedKeys(bootDexInfoByModule) {
Paul Duffinaf705182022-09-14 11:47:34 +01001228 bootDexInfo := bootDexInfoByModule[name]
1229 unencodedDex := bootDexInfo.path
1230 encodedDex := hiddenAPIEncodeDex(ctx, unencodedDex, allFlagsCSV, bootDexInfo.uncompressDex, bootDexInfo.minSdkVersion, outputDir)
1231 encodedBootDexJarsByModule[name] = encodedDex
1232 }
1233 return encodedBootDexJarsByModule
Paul Duffin702210b2021-04-08 20:12:41 +01001234}
Paul Duffin537ea3d2021-05-14 10:38:00 +01001235
Paul Duffin1938dba2022-07-26 23:53:00 +00001236func buildRuleToGenerateRemovedDexSignatures(ctx android.ModuleContext, suffix string, removedTxtFiles android.Paths) android.OptionalPath {
Paul Duffin32cf58a2021-05-18 16:32:50 +01001237 if len(removedTxtFiles) == 0 {
1238 return android.OptionalPath{}
1239 }
1240
Paul Duffin1938dba2022-07-26 23:53:00 +00001241 output := android.PathForModuleOut(ctx, "module-hiddenapi"+suffix, "removed-dex-signatures.txt")
Paul Duffin32cf58a2021-05-18 16:32:50 +01001242
1243 rule := android.NewRuleBuilder(pctx, ctx)
1244 rule.Command().
1245 BuiltTool("metalava").
Paul Duffin32cf58a2021-05-18 16:32:50 +01001246 Inputs(removedTxtFiles).
1247 FlagWithOutput("--dex-api ", output)
Paul Duffin1938dba2022-07-26 23:53:00 +00001248 rule.Build("modular-hiddenapi-removed-dex-signatures"+suffix, "modular hiddenapi removed dex signatures"+suffix)
Paul Duffin32cf58a2021-05-18 16:32:50 +01001249 return android.OptionalPathForPath(output)
1250}
1251
Paul Duffindd5993f2021-06-10 10:18:22 +01001252// extractBootDexJarsFromModules extracts the boot dex jars from the supplied modules.
Paul Duffine5218812021-06-07 13:28:19 +01001253func extractBootDexJarsFromModules(ctx android.ModuleContext, contents []android.Module) bootDexJarByModule {
1254 bootDexJars := bootDexJarByModule{}
Paul Duffin537ea3d2021-05-14 10:38:00 +01001255 for _, module := range contents {
Paul Duffindd5993f2021-06-10 10:18:22 +01001256 hiddenAPIModule := hiddenAPIModuleFromModule(ctx, module)
1257 if hiddenAPIModule == nil {
1258 continue
1259 }
Paul Duffine5218812021-06-07 13:28:19 +01001260 bootDexJar := retrieveBootDexJarFromHiddenAPIModule(ctx, hiddenAPIModule)
1261 bootDexJars.addPath(module, bootDexJar)
Paul Duffin537ea3d2021-05-14 10:38:00 +01001262 }
1263 return bootDexJars
1264}
1265
Paul Duffindd5993f2021-06-10 10:18:22 +01001266func hiddenAPIModuleFromModule(ctx android.BaseModuleContext, module android.Module) hiddenAPIModule {
1267 if hiddenAPIModule, ok := module.(hiddenAPIModule); ok {
1268 return hiddenAPIModule
1269 } else if _, ok := module.(*DexImport); ok {
1270 // Ignore this for the purposes of hidden API processing
1271 } else {
1272 ctx.ModuleErrorf("module %s does not implement hiddenAPIModule", module)
1273 }
1274
1275 return nil
1276}
1277
Paul Duffine5218812021-06-07 13:28:19 +01001278// bootDexInfo encapsulates both the path and uncompressDex status retrieved from a hiddenAPIModule.
1279type bootDexInfo struct {
1280 // The path to the dex jar that has not had hidden API flags encoded into it.
1281 path android.Path
1282
1283 // Indicates whether the dex jar needs uncompressing before encoding.
1284 uncompressDex bool
Paul Duffin09817d62022-04-28 17:45:11 +01001285
1286 // The minimum sdk version that the dex jar will be used on.
Spandan Das8c9ae7e2023-03-03 21:20:36 +00001287 minSdkVersion android.ApiLevel
Paul Duffine5218812021-06-07 13:28:19 +01001288}
1289
1290// bootDexInfoByModule is a map from module name (as returned by module.Name()) to the boot dex
1291// path (as returned by hiddenAPIModule.bootDexJar()) and the uncompressDex flag.
1292type bootDexInfoByModule map[string]bootDexInfo
1293
1294// bootDexJars returns the boot dex jar paths sorted by their keys.
1295func (b bootDexInfoByModule) bootDexJars() android.Paths {
1296 paths := android.Paths{}
Cole Faust18994c72023-02-28 16:02:16 -08001297 for _, m := range android.SortedKeys(b) {
Paul Duffine5218812021-06-07 13:28:19 +01001298 paths = append(paths, b[m].path)
1299 }
1300 return paths
1301}
1302
1303// extractBootDexInfoFromModules extracts the boot dex jar and uncompress dex state from
1304// each of the supplied modules which must implement hiddenAPIModule.
1305func extractBootDexInfoFromModules(ctx android.ModuleContext, contents []android.Module) bootDexInfoByModule {
1306 bootDexJarsByModule := bootDexInfoByModule{}
1307 for _, module := range contents {
1308 hiddenAPIModule := module.(hiddenAPIModule)
1309 bootDexJar := retrieveBootDexJarFromHiddenAPIModule(ctx, hiddenAPIModule)
1310 bootDexJarsByModule[module.Name()] = bootDexInfo{
1311 path: bootDexJar,
1312 uncompressDex: *hiddenAPIModule.uncompressDex(),
Paul Duffin09817d62022-04-28 17:45:11 +01001313 minSdkVersion: hiddenAPIModule.MinSdkVersion(ctx),
Paul Duffine5218812021-06-07 13:28:19 +01001314 }
1315 }
1316
1317 return bootDexJarsByModule
1318}
1319
1320// retrieveBootDexJarFromHiddenAPIModule retrieves the boot dex jar from the hiddenAPIModule.
1321//
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +01001322// If the module does not provide a boot dex jar, i.e. the returned boot dex jar is unset or
1323// invalid, then create a fake path and either report an error immediately or defer reporting of the
1324// error until the path is actually used.
Paul Duffine5218812021-06-07 13:28:19 +01001325func retrieveBootDexJarFromHiddenAPIModule(ctx android.ModuleContext, module hiddenAPIModule) android.Path {
1326 bootDexJar := module.bootDexJar()
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +01001327 if !bootDexJar.Valid() {
Paul Duffine5218812021-06-07 13:28:19 +01001328 fake := android.PathForModuleOut(ctx, fmt.Sprintf("fake/boot-dex/%s.jar", module.Name()))
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +01001329 handleMissingDexBootFile(ctx, module, fake, bootDexJar.InvalidReason())
1330 return fake
Paul Duffine5218812021-06-07 13:28:19 +01001331 }
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +01001332 return bootDexJar.Path()
Paul Duffine5218812021-06-07 13:28:19 +01001333}
1334
Paul Duffindd5993f2021-06-10 10:18:22 +01001335// extractClassesJarsFromModules extracts the class jars from the supplied modules.
1336func extractClassesJarsFromModules(contents []android.Module) android.Paths {
Paul Duffin537ea3d2021-05-14 10:38:00 +01001337 classesJars := android.Paths{}
1338 for _, module := range contents {
Paul Duffindd5993f2021-06-10 10:18:22 +01001339 classesJars = append(classesJars, retrieveClassesJarsFromModule(module)...)
Paul Duffin537ea3d2021-05-14 10:38:00 +01001340 }
1341 return classesJars
1342}
Paul Duffin5f148ca2021-06-02 17:24:22 +01001343
Paul Duffindd5993f2021-06-10 10:18:22 +01001344// retrieveClassesJarsFromModule retrieves the classes jars from the supplied module.
1345func retrieveClassesJarsFromModule(module android.Module) android.Paths {
1346 if hiddenAPIModule, ok := module.(hiddenAPIModule); ok {
1347 return hiddenAPIModule.classesJars()
1348 }
1349
1350 return nil
1351}
1352
Paul Duffin5f148ca2021-06-02 17:24:22 +01001353// deferReportingMissingBootDexJar returns true if a missing boot dex jar should not be reported by
1354// Soong but should instead only be reported in ninja if the file is actually built.
1355func deferReportingMissingBootDexJar(ctx android.ModuleContext, module android.Module) bool {
Paul Duffine5218812021-06-07 13:28:19 +01001356 // Any missing dependency should be allowed.
1357 if ctx.Config().AllowMissingDependencies() {
1358 return true
1359 }
1360
Paul Duffin5f148ca2021-06-02 17:24:22 +01001361 // This is called for both platform_bootclasspath and bootclasspath_fragment modules.
1362 //
1363 // A bootclasspath_fragment module should only use the APEX variant of source or prebuilt modules.
1364 // Ideally, a bootclasspath_fragment module should never have a platform variant created for it
1365 // but unfortunately, due to b/187910671 it does.
1366 //
1367 // That causes issues when obtaining a boot dex jar for a prebuilt module as a prebuilt module
1368 // used by a bootclasspath_fragment can only provide a boot dex jar when it is part of APEX, i.e.
1369 // has an APEX variant not a platform variant.
1370 //
1371 // There are some other situations when a prebuilt module used by a bootclasspath_fragment cannot
1372 // provide a boot dex jar:
1373 // 1. If the bootclasspath_fragment is not exported by the prebuilt_apex/apex_set module then it
1374 // does not have an APEX variant and only has a platform variant and neither do its content
1375 // modules.
1376 // 2. Some build configurations, e.g. setting TARGET_BUILD_USE_PREBUILT_SDKS causes all
1377 // java_sdk_library_import modules to be treated as preferred and as many of them are not part
1378 // of an apex they cannot provide a boot dex jar.
1379 //
1380 // The first case causes problems when the affected prebuilt modules are preferred but that is an
1381 // invalid configuration and it is ok for it to fail as the work to enable that is not yet
1382 // complete. The second case is used for building targets that do not use boot dex jars and so
1383 // deferring error reporting to ninja is fine as the affected ninja targets should never be built.
1384 // That is handled above.
1385 //
1386 // A platform_bootclasspath module can use libraries from both platform and APEX variants. Unlike
1387 // the bootclasspath_fragment it supports dex_import modules which provides the dex file. So, it
1388 // can obtain a boot dex jar from a prebuilt that is not part of an APEX. However, it is assumed
1389 // that if the library can be part of an APEX then it is the APEX variant that is used.
1390 //
1391 // This check handles the slightly different requirements of the bootclasspath_fragment and
1392 // platform_bootclasspath modules by only deferring error reporting for the platform variant of
1393 // a prebuilt modules that has other variants which are part of an APEX.
1394 //
1395 // TODO(b/187910671): Remove this once platform variants are no longer created unnecessarily.
1396 if android.IsModulePrebuilt(module) {
Paul Duffinef083c92021-06-29 13:36:34 +01001397 // An inactive source module can still contribute to the APEX but an inactive prebuilt module
1398 // should not contribute to anything. So, rather than have a missing dex jar cause a Soong
1399 // failure defer the error reporting to Ninja. Unless the prebuilt build target is explicitly
1400 // built Ninja should never use the dex jar file.
1401 if !isActiveModule(module) {
1402 return true
1403 }
1404
Paul Duffin5f148ca2021-06-02 17:24:22 +01001405 if am, ok := module.(android.ApexModule); ok && am.InAnyApex() {
Colin Cross313aa542023-12-13 13:47:44 -08001406 apexInfo, _ := android.OtherModuleProvider(ctx, module, android.ApexInfoProvider)
Paul Duffin5f148ca2021-06-02 17:24:22 +01001407 if apexInfo.IsForPlatform() {
1408 return true
1409 }
1410 }
1411 }
1412
Paul Duffin5f148ca2021-06-02 17:24:22 +01001413 return false
1414}
1415
1416// handleMissingDexBootFile will either log a warning or create an error rule to create the fake
1417// file depending on the value returned from deferReportingMissingBootDexJar.
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +01001418func handleMissingDexBootFile(ctx android.ModuleContext, module android.Module, fake android.WritablePath, reason string) {
Paul Duffin5f148ca2021-06-02 17:24:22 +01001419 if deferReportingMissingBootDexJar(ctx, module) {
1420 // Create an error rule that pretends to create the output file but will actually fail if it
1421 // is run.
1422 ctx.Build(pctx, android.BuildParams{
1423 Rule: android.ErrorRule,
1424 Output: fake,
1425 Args: map[string]string{
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +01001426 "error": fmt.Sprintf("missing boot dex jar dependency for %s: %s", module, reason),
Paul Duffin5f148ca2021-06-02 17:24:22 +01001427 },
1428 })
1429 } else {
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +01001430 ctx.ModuleErrorf("module %s does not provide a dex jar: %s", module, reason)
Paul Duffin5f148ca2021-06-02 17:24:22 +01001431 }
1432}
1433
1434// retrieveEncodedBootDexJarFromModule returns a path to the boot dex jar from the supplied module's
1435// DexJarBuildPath() method.
1436//
1437// The returned path will usually be to a dex jar file that has been encoded with hidden API flags.
1438// However, under certain conditions, e.g. errors, or special build configurations it will return
1439// a path to a fake file.
1440func retrieveEncodedBootDexJarFromModule(ctx android.ModuleContext, module android.Module) android.Path {
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +01001441 bootDexJar := module.(interface{ DexJarBuildPath() OptionalDexJarPath }).DexJarBuildPath()
1442 if !bootDexJar.Valid() {
Paul Duffin5f148ca2021-06-02 17:24:22 +01001443 fake := android.PathForModuleOut(ctx, fmt.Sprintf("fake/encoded-dex/%s.jar", module.Name()))
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +01001444 handleMissingDexBootFile(ctx, module, fake, bootDexJar.InvalidReason())
1445 return fake
Paul Duffin5f148ca2021-06-02 17:24:22 +01001446 }
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +01001447 return bootDexJar.Path()
Paul Duffin5f148ca2021-06-02 17:24:22 +01001448}
1449
1450// extractEncodedDexJarsFromModules extracts the encoded dex jars from the supplied modules.
1451func extractEncodedDexJarsFromModules(ctx android.ModuleContext, contents []android.Module) bootDexJarByModule {
1452 encodedDexJarsByModuleName := bootDexJarByModule{}
1453 for _, module := range contents {
1454 path := retrieveEncodedBootDexJarFromModule(ctx, module)
1455 encodedDexJarsByModuleName.addPath(module, path)
1456 }
1457 return encodedDexJarsByModuleName
1458}