Rupert Shuttleworth | 2a4fc3e | 2021-04-21 07:10:09 -0400 | [diff] [blame] | 1 | #!/bin/bash -eu |
| 2 | |
| 3 | set -o pipefail |
| 4 | |
| 5 | # Test that bp2build and Bazel can play nicely together |
| 6 | |
| 7 | source "$(dirname "$0")/lib.sh" |
| 8 | |
Rupert Shuttleworth | 413a7a9 | 2021-05-18 07:47:15 -0400 | [diff] [blame] | 9 | readonly GENERATED_BUILD_FILE_NAME="BUILD.bazel" |
| 10 | |
Usta Shrestha | 572ecec | 2022-12-08 01:29:21 -0500 | [diff] [blame] | 11 | function test_bp2build_null_build { |
Jingwen Chen | 53dfa40 | 2021-08-12 09:37:14 +0000 | [diff] [blame] | 12 | setup |
Lukacs T. Berki | a1b9372 | 2021-09-02 17:23:06 +0200 | [diff] [blame] | 13 | run_soong bp2build |
Usta Shrestha | 2c9a5e3 | 2022-06-09 12:22:36 -0400 | [diff] [blame] | 14 | local -r output_mtime1=$(stat -c "%y" out/soong/bp2build_workspace_marker) |
Jingwen Chen | 53dfa40 | 2021-08-12 09:37:14 +0000 | [diff] [blame] | 15 | |
Lukacs T. Berki | a1b9372 | 2021-09-02 17:23:06 +0200 | [diff] [blame] | 16 | run_soong bp2build |
Usta Shrestha | 2c9a5e3 | 2022-06-09 12:22:36 -0400 | [diff] [blame] | 17 | local -r output_mtime2=$(stat -c "%y" out/soong/bp2build_workspace_marker) |
Jingwen Chen | 53dfa40 | 2021-08-12 09:37:14 +0000 | [diff] [blame] | 18 | |
| 19 | if [[ "$output_mtime1" != "$output_mtime2" ]]; then |
| 20 | fail "Output bp2build marker file changed on null build" |
| 21 | fi |
| 22 | } |
| 23 | |
Chris Parsons | 520e88b | 2023-02-09 17:54:00 -0500 | [diff] [blame^] | 24 | # Tests that, if bp2build reruns due to a blueprint file changing, that |
| 25 | # BUILD files whose contents are unchanged are not regenerated. |
| 26 | function test_bp2build_unchanged { |
| 27 | setup |
| 28 | |
| 29 | mkdir -p pkg |
| 30 | touch pkg/x.txt |
| 31 | cat > pkg/Android.bp <<'EOF' |
| 32 | filegroup { |
| 33 | name: "x", |
| 34 | srcs: ["x.txt"], |
| 35 | bazel_module: {bp2build_available: true}, |
| 36 | } |
| 37 | EOF |
| 38 | |
| 39 | run_soong bp2build |
| 40 | local -r buildfile_mtime1=$(stat -c "%y" out/soong/bp2build/pkg/BUILD.bazel) |
| 41 | local -r marker_mtime1=$(stat -c "%y" out/soong/bp2build_workspace_marker) |
| 42 | |
| 43 | # Force bp2build to rerun by updating the timestamp of a blueprint file. |
| 44 | touch pkg/Android.bp |
| 45 | |
| 46 | run_soong bp2build |
| 47 | local -r buildfile_mtime2=$(stat -c "%y" out/soong/bp2build/pkg/BUILD.bazel) |
| 48 | local -r marker_mtime2=$(stat -c "%y" out/soong/bp2build_workspace_marker) |
| 49 | |
| 50 | if [[ "$marker_mtime1" == "$marker_mtime2" ]]; then |
| 51 | fail "Expected bp2build marker file to change" |
| 52 | fi |
| 53 | if [[ "$buildfile_mtime1" != "$buildfile_mtime2" ]]; then |
| 54 | fail "BUILD.bazel was updated even though contents are same" |
| 55 | fi |
| 56 | } |
| 57 | |
| 58 | # Tests that blueprint files that are deleted are not present when the |
| 59 | # bp2build tree is regenerated. |
| 60 | function test_bp2build_deleted_blueprint { |
| 61 | setup |
| 62 | |
| 63 | mkdir -p pkg |
| 64 | touch pkg/x.txt |
| 65 | cat > pkg/Android.bp <<'EOF' |
| 66 | filegroup { |
| 67 | name: "x", |
| 68 | srcs: ["x.txt"], |
| 69 | bazel_module: {bp2build_available: true}, |
| 70 | } |
| 71 | EOF |
| 72 | |
| 73 | run_soong bp2build |
| 74 | if [[ ! -e "./out/soong/bp2build/pkg/BUILD.bazel" ]]; then |
| 75 | fail "Expected pkg/BUILD.bazel to be generated" |
| 76 | fi |
| 77 | |
| 78 | rm pkg/Android.bp |
| 79 | |
| 80 | run_soong bp2build |
| 81 | if [[ -e "./out/soong/bp2build/pkg/BUILD.bazel" ]]; then |
| 82 | fail "Expected pkg/BUILD.bazel to be deleted" |
| 83 | fi |
| 84 | } |
| 85 | |
Usta Shrestha | 572ecec | 2022-12-08 01:29:21 -0500 | [diff] [blame] | 86 | function test_bp2build_null_build_with_globs { |
Jingwen Chen | 53dfa40 | 2021-08-12 09:37:14 +0000 | [diff] [blame] | 87 | setup |
| 88 | |
| 89 | mkdir -p foo/bar |
| 90 | cat > foo/bar/Android.bp <<'EOF' |
| 91 | filegroup { |
| 92 | name: "globs", |
| 93 | srcs: ["*.txt"], |
| 94 | } |
| 95 | EOF |
| 96 | touch foo/bar/a.txt foo/bar/b.txt |
| 97 | |
Lukacs T. Berki | a1b9372 | 2021-09-02 17:23:06 +0200 | [diff] [blame] | 98 | run_soong bp2build |
Usta Shrestha | 2c9a5e3 | 2022-06-09 12:22:36 -0400 | [diff] [blame] | 99 | local -r output_mtime1=$(stat -c "%y" out/soong/bp2build_workspace_marker) |
Jingwen Chen | 53dfa40 | 2021-08-12 09:37:14 +0000 | [diff] [blame] | 100 | |
Lukacs T. Berki | a1b9372 | 2021-09-02 17:23:06 +0200 | [diff] [blame] | 101 | run_soong bp2build |
Usta Shrestha | 2c9a5e3 | 2022-06-09 12:22:36 -0400 | [diff] [blame] | 102 | local -r output_mtime2=$(stat -c "%y" out/soong/bp2build_workspace_marker) |
Jingwen Chen | 53dfa40 | 2021-08-12 09:37:14 +0000 | [diff] [blame] | 103 | |
| 104 | if [[ "$output_mtime1" != "$output_mtime2" ]]; then |
| 105 | fail "Output bp2build marker file changed on null build" |
| 106 | fi |
| 107 | } |
| 108 | |
Jingwen Chen | 7e11eb8 | 2022-10-13 09:25:38 +0000 | [diff] [blame] | 109 | function test_different_relative_outdir { |
| 110 | setup |
Jingwen Chen | 7e11eb8 | 2022-10-13 09:25:38 +0000 | [diff] [blame] | 111 | |
| 112 | mkdir -p a |
| 113 | touch a/g.txt |
| 114 | cat > a/Android.bp <<'EOF' |
| 115 | filegroup { |
| 116 | name: "g", |
| 117 | srcs: ["g.txt"], |
| 118 | bazel_module: {bp2build_available: true}, |
| 119 | } |
| 120 | EOF |
| 121 | |
| 122 | # A directory under $MOCK_TOP |
| 123 | outdir=out2 |
| 124 | trap "rm -rf $outdir" EXIT |
| 125 | # Modify OUT_DIR in a subshell so it doesn't affect the top level one. |
Cole Faust | de12be3 | 2022-11-19 15:14:48 -0800 | [diff] [blame] | 126 | (export OUT_DIR=$outdir; run_soong bp2build && run_bazel build --config=bp2build --config=ci //a:g) |
Jingwen Chen | 7e11eb8 | 2022-10-13 09:25:38 +0000 | [diff] [blame] | 127 | } |
| 128 | |
Jingwen Chen | 7e11eb8 | 2022-10-13 09:25:38 +0000 | [diff] [blame] | 129 | function test_different_absolute_outdir { |
| 130 | setup |
Jingwen Chen | 7e11eb8 | 2022-10-13 09:25:38 +0000 | [diff] [blame] | 131 | |
| 132 | mkdir -p a |
| 133 | touch a/g.txt |
| 134 | cat > a/Android.bp <<'EOF' |
| 135 | filegroup { |
| 136 | name: "g", |
| 137 | srcs: ["g.txt"], |
| 138 | bazel_module: {bp2build_available: true}, |
| 139 | } |
| 140 | EOF |
| 141 | |
| 142 | # A directory under /tmp/... |
| 143 | outdir=$(mktemp -t -d st.XXXXX) |
| 144 | trap 'rm -rf $outdir' EXIT |
| 145 | # Modify OUT_DIR in a subshell so it doesn't affect the top level one. |
Cole Faust | de12be3 | 2022-11-19 15:14:48 -0800 | [diff] [blame] | 146 | (export OUT_DIR=$outdir; run_soong bp2build && run_bazel build --config=bp2build --config=ci //a:g) |
Jingwen Chen | 7e11eb8 | 2022-10-13 09:25:38 +0000 | [diff] [blame] | 147 | } |
| 148 | |
Usta Shrestha | 572ecec | 2022-12-08 01:29:21 -0500 | [diff] [blame] | 149 | function _bp2build_generates_all_buildfiles { |
Rupert Shuttleworth | 2a4fc3e | 2021-04-21 07:10:09 -0400 | [diff] [blame] | 150 | setup |
Rupert Shuttleworth | 2a4fc3e | 2021-04-21 07:10:09 -0400 | [diff] [blame] | 151 | |
| 152 | mkdir -p foo/convertible_soong_module |
| 153 | cat > foo/convertible_soong_module/Android.bp <<'EOF' |
| 154 | genrule { |
| 155 | name: "the_answer", |
| 156 | cmd: "echo '42' > $(out)", |
| 157 | out: [ |
| 158 | "the_answer.txt", |
| 159 | ], |
| 160 | bazel_module: { |
| 161 | bp2build_available: true, |
| 162 | }, |
| 163 | } |
| 164 | EOF |
| 165 | |
| 166 | mkdir -p foo/unconvertible_soong_module |
| 167 | cat > foo/unconvertible_soong_module/Android.bp <<'EOF' |
| 168 | genrule { |
| 169 | name: "not_the_answer", |
| 170 | cmd: "echo '43' > $(out)", |
| 171 | out: [ |
| 172 | "not_the_answer.txt", |
| 173 | ], |
| 174 | bazel_module: { |
| 175 | bp2build_available: false, |
| 176 | }, |
| 177 | } |
| 178 | EOF |
| 179 | |
Lukacs T. Berki | a1b9372 | 2021-09-02 17:23:06 +0200 | [diff] [blame] | 180 | run_soong bp2build |
Rupert Shuttleworth | 2a4fc3e | 2021-04-21 07:10:09 -0400 | [diff] [blame] | 181 | |
Rupert Shuttleworth | 413a7a9 | 2021-05-18 07:47:15 -0400 | [diff] [blame] | 182 | if [[ ! -f "./out/soong/workspace/foo/convertible_soong_module/${GENERATED_BUILD_FILE_NAME}" ]]; then |
| 183 | fail "./out/soong/workspace/foo/convertible_soong_module/${GENERATED_BUILD_FILE_NAME} was not generated" |
Rupert Shuttleworth | 2a4fc3e | 2021-04-21 07:10:09 -0400 | [diff] [blame] | 184 | fi |
| 185 | |
Rupert Shuttleworth | 413a7a9 | 2021-05-18 07:47:15 -0400 | [diff] [blame] | 186 | if [[ ! -f "./out/soong/workspace/foo/unconvertible_soong_module/${GENERATED_BUILD_FILE_NAME}" ]]; then |
| 187 | fail "./out/soong/workspace/foo/unconvertible_soong_module/${GENERATED_BUILD_FILE_NAME} was not generated" |
Rupert Shuttleworth | 2a4fc3e | 2021-04-21 07:10:09 -0400 | [diff] [blame] | 188 | fi |
| 189 | |
Rupert Shuttleworth | 413a7a9 | 2021-05-18 07:47:15 -0400 | [diff] [blame] | 190 | if ! grep "the_answer" "./out/soong/workspace/foo/convertible_soong_module/${GENERATED_BUILD_FILE_NAME}"; then |
| 191 | fail "missing BUILD target the_answer in convertible_soong_module/${GENERATED_BUILD_FILE_NAME}" |
Rupert Shuttleworth | 2a4fc3e | 2021-04-21 07:10:09 -0400 | [diff] [blame] | 192 | fi |
| 193 | |
Rupert Shuttleworth | 413a7a9 | 2021-05-18 07:47:15 -0400 | [diff] [blame] | 194 | if grep "not_the_answer" "./out/soong/workspace/foo/unconvertible_soong_module/${GENERATED_BUILD_FILE_NAME}"; then |
| 195 | fail "found unexpected BUILD target not_the_answer in unconvertible_soong_module/${GENERATED_BUILD_FILE_NAME}" |
Rupert Shuttleworth | 2a4fc3e | 2021-04-21 07:10:09 -0400 | [diff] [blame] | 196 | fi |
| 197 | |
Rupert Shuttleworth | 413a7a9 | 2021-05-18 07:47:15 -0400 | [diff] [blame] | 198 | if ! grep "filegroup" "./out/soong/workspace/foo/unconvertible_soong_module/${GENERATED_BUILD_FILE_NAME}"; then |
| 199 | fail "missing filegroup in unconvertible_soong_module/${GENERATED_BUILD_FILE_NAME}" |
Rupert Shuttleworth | 2a4fc3e | 2021-04-21 07:10:09 -0400 | [diff] [blame] | 200 | fi |
| 201 | |
| 202 | # NOTE: We don't actually use the extra BUILD file for anything here |
Cole Faust | de12be3 | 2022-11-19 15:14:48 -0800 | [diff] [blame] | 203 | run_bazel build --config=android --config=bp2build --config=ci //foo/... |
Rupert Shuttleworth | 2a4fc3e | 2021-04-21 07:10:09 -0400 | [diff] [blame] | 204 | |
Usta (Tsering) Shrestha | c4c07b1 | 2022-11-08 18:31:14 -0500 | [diff] [blame] | 205 | local -r the_answer_file="$(find -L bazel-out -name the_answer.txt)" |
Rupert Shuttleworth | 2a4fc3e | 2021-04-21 07:10:09 -0400 | [diff] [blame] | 206 | if [[ ! -f "${the_answer_file}" ]]; then |
Cole Faust | b85d1a1 | 2022-11-08 18:14:01 -0800 | [diff] [blame] | 207 | fail "Expected the_answer.txt to be generated, but was missing" |
Rupert Shuttleworth | 2a4fc3e | 2021-04-21 07:10:09 -0400 | [diff] [blame] | 208 | fi |
| 209 | if ! grep 42 "${the_answer_file}"; then |
| 210 | fail "Expected to find 42 in '${the_answer_file}'" |
| 211 | fi |
| 212 | } |
| 213 | |
Usta Shrestha | 572ecec | 2022-12-08 01:29:21 -0500 | [diff] [blame] | 214 | function test_bp2build_generates_all_buildfiles { |
| 215 | _save_trap=$(trap -p EXIT) |
| 216 | trap '[[ $? -ne 0 ]] && echo Are you running this locally? Try changing --sandbox_tmpfs_path to something other than /tmp/ in build/bazel/linux.bazelrc.' EXIT |
| 217 | _bp2build_generates_all_buildfiles |
| 218 | eval "${_save_trap}" |
| 219 | } |
Lukacs T. Berki | e3487c8 | 2022-05-02 10:13:19 +0200 | [diff] [blame] | 220 | |
Usta (Tsering) Shrestha | c4c07b1 | 2022-11-08 18:31:14 -0500 | [diff] [blame] | 221 | function test_bp2build_symlinks_files { |
| 222 | setup |
| 223 | mkdir -p foo |
| 224 | touch foo/BLANK1 |
| 225 | touch foo/BLANK2 |
| 226 | touch foo/F2D |
| 227 | touch foo/BUILD |
| 228 | |
| 229 | run_soong bp2build |
| 230 | |
| 231 | if [[ -e "./out/soong/workspace/foo/BUILD" ]]; then |
| 232 | fail "./out/soong/workspace/foo/BUILD should be omitted" |
| 233 | fi |
| 234 | for file in BLANK1 BLANK2 F2D |
| 235 | do |
| 236 | if [[ ! -L "./out/soong/workspace/foo/$file" ]]; then |
| 237 | fail "./out/soong/workspace/foo/$file should exist" |
| 238 | fi |
| 239 | done |
| 240 | local -r BLANK1_BEFORE=$(stat -c %y "./out/soong/workspace/foo/BLANK1") |
| 241 | |
| 242 | rm foo/BLANK2 |
| 243 | rm foo/F2D |
| 244 | mkdir foo/F2D |
| 245 | touch foo/F2D/BUILD |
| 246 | |
| 247 | run_soong bp2build |
| 248 | |
| 249 | if [[ -e "./out/soong/workspace/foo/BUILD" ]]; then |
| 250 | fail "./out/soong/workspace/foo/BUILD should be omitted" |
| 251 | fi |
| 252 | local -r BLANK1_AFTER=$(stat -c %y "./out/soong/workspace/foo/BLANK1") |
| 253 | if [[ "$BLANK1_AFTER" != "$BLANK1_BEFORE" ]]; then |
| 254 | fail "./out/soong/workspace/foo/BLANK1 should be untouched" |
| 255 | fi |
| 256 | if [[ -e "./out/soong/workspace/foo/BLANK2" ]]; then |
| 257 | fail "./out/soong/workspace/foo/BLANK2 should be removed" |
| 258 | fi |
| 259 | if [[ -L "./out/soong/workspace/foo/F2D" ]] || [[ ! -d "./out/soong/workspace/foo/F2D" ]]; then |
| 260 | fail "./out/soong/workspace/foo/F2D should be a dir" |
| 261 | fi |
| 262 | } |
| 263 | |
Lukacs T. Berki | e3487c8 | 2022-05-02 10:13:19 +0200 | [diff] [blame] | 264 | function test_cc_correctness { |
| 265 | setup |
Lukacs T. Berki | e3487c8 | 2022-05-02 10:13:19 +0200 | [diff] [blame] | 266 | |
| 267 | mkdir -p a |
| 268 | cat > a/Android.bp <<EOF |
| 269 | cc_object { |
| 270 | name: "qq", |
| 271 | srcs: ["qq.cc"], |
| 272 | bazel_module: { |
| 273 | bp2build_available: true, |
| 274 | }, |
| 275 | stl: "none", |
| 276 | system_shared_libs: [], |
| 277 | } |
| 278 | EOF |
| 279 | |
| 280 | cat > a/qq.cc <<EOF |
| 281 | #include "qq.h" |
| 282 | int qq() { |
| 283 | return QQ; |
| 284 | } |
| 285 | EOF |
| 286 | |
| 287 | cat > a/qq.h <<EOF |
| 288 | #define QQ 1 |
| 289 | EOF |
| 290 | |
| 291 | run_soong bp2build |
| 292 | |
Cole Faust | de12be3 | 2022-11-19 15:14:48 -0800 | [diff] [blame] | 293 | run_bazel build --config=android --config=bp2build --config=ci //a:qq |
Usta Shrestha | 2c9a5e3 | 2022-06-09 12:22:36 -0400 | [diff] [blame] | 294 | local -r output_mtime1=$(stat -c "%y" bazel-bin/a/_objs/qq/qq.o) |
Lukacs T. Berki | e3487c8 | 2022-05-02 10:13:19 +0200 | [diff] [blame] | 295 | |
Cole Faust | de12be3 | 2022-11-19 15:14:48 -0800 | [diff] [blame] | 296 | run_bazel build --config=android --config=bp2build --config=ci //a:qq |
Usta Shrestha | 2c9a5e3 | 2022-06-09 12:22:36 -0400 | [diff] [blame] | 297 | local -r output_mtime2=$(stat -c "%y" bazel-bin/a/_objs/qq/qq.o) |
Lukacs T. Berki | e3487c8 | 2022-05-02 10:13:19 +0200 | [diff] [blame] | 298 | |
| 299 | if [[ "$output_mtime1" != "$output_mtime2" ]]; then |
| 300 | fail "output changed on null build" |
| 301 | fi |
| 302 | |
| 303 | cat > a/qq.h <<EOF |
| 304 | #define QQ 2 |
| 305 | EOF |
| 306 | |
Cole Faust | de12be3 | 2022-11-19 15:14:48 -0800 | [diff] [blame] | 307 | run_bazel build --config=android --config=bp2build --config=ci //a:qq |
Usta Shrestha | 2c9a5e3 | 2022-06-09 12:22:36 -0400 | [diff] [blame] | 308 | local -r output_mtime3=$(stat -c "%y" bazel-bin/a/_objs/qq/qq.o) |
Lukacs T. Berki | e3487c8 | 2022-05-02 10:13:19 +0200 | [diff] [blame] | 309 | |
| 310 | if [[ "$output_mtime1" == "$output_mtime3" ]]; then |
| 311 | fail "output not changed when included header changed" |
| 312 | fi |
| 313 | } |
| 314 | |
Jingwen Chen | d4b1dc8 | 2022-05-12 11:08:03 +0000 | [diff] [blame] | 315 | # Regression test for the following failure during symlink forest creation: |
| 316 | # |
| 317 | # Cannot stat '/tmp/st.rr054/foo/bar/unresolved_symlink': stat /tmp/st.rr054/foo/bar/unresolved_symlink: no such file or directory |
| 318 | # |
| 319 | function test_bp2build_null_build_with_unresolved_symlink_in_source() { |
| 320 | setup |
| 321 | |
| 322 | mkdir -p foo/bar |
| 323 | ln -s /tmp/non-existent foo/bar/unresolved_symlink |
| 324 | cat > foo/bar/Android.bp <<'EOF' |
| 325 | filegroup { |
| 326 | name: "fg", |
| 327 | srcs: ["unresolved_symlink/non-existent-file.txt"], |
| 328 | } |
| 329 | EOF |
| 330 | |
| 331 | run_soong bp2build |
| 332 | |
| 333 | dest=$(readlink -f out/soong/workspace/foo/bar/unresolved_symlink) |
| 334 | if [[ "$dest" != "/tmp/non-existent" ]]; then |
| 335 | fail "expected to plant an unresolved symlink out/soong/workspace/foo/bar/unresolved_symlink that resolves to /tmp/non-existent" |
| 336 | fi |
| 337 | } |
| 338 | |
Spandan Das | 255648c | 2023-01-11 03:05:24 +0000 | [diff] [blame] | 339 | # Smoke test to verify api_bp2build worksapce does not contain any errors |
| 340 | function test_api_bp2build_empty_build() { |
| 341 | setup |
| 342 | run_soong api_bp2build |
| 343 | run_bazel build --config=android --config=api_bp2build //:empty |
| 344 | } |
| 345 | |
Usta Shrestha | 572ecec | 2022-12-08 01:29:21 -0500 | [diff] [blame] | 346 | scan_and_run_tests |