| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 1 | // Copyright 2017 Google Inc. All rights reserved. | 
|  | 2 | // | 
|  | 3 | // Licensed under the Apache License, Version 2.0 (the "License"); | 
|  | 4 | // you may not use this file except in compliance with the License. | 
|  | 5 | // You may obtain a copy of the License at | 
|  | 6 | // | 
|  | 7 | //     http://www.apache.org/licenses/LICENSE-2.0 | 
|  | 8 | // | 
|  | 9 | // Unless required by applicable law or agreed to in writing, software | 
|  | 10 | // distributed under the License is distributed on an "AS IS" BASIS, | 
|  | 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | 
|  | 12 | // See the License for the specific language governing permissions and | 
|  | 13 | // limitations under the License. | 
|  | 14 |  | 
|  | 15 | package java | 
|  | 16 |  | 
|  | 17 | import ( | 
|  | 18 | "android/soong/android" | 
| Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 19 | "android/soong/genrule" | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 20 | "fmt" | 
|  | 21 | "io/ioutil" | 
|  | 22 | "os" | 
|  | 23 | "path/filepath" | 
| Colin Cross | 227d436 | 2017-08-30 14:14:52 -0700 | [diff] [blame] | 24 | "reflect" | 
| Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 25 | "strconv" | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 26 | "strings" | 
|  | 27 | "testing" | 
|  | 28 | ) | 
|  | 29 |  | 
|  | 30 | var buildDir string | 
|  | 31 |  | 
|  | 32 | func setUp() { | 
|  | 33 | var err error | 
|  | 34 | buildDir, err = ioutil.TempDir("", "soong_java_test") | 
|  | 35 | if err != nil { | 
|  | 36 | panic(err) | 
|  | 37 | } | 
|  | 38 | } | 
|  | 39 |  | 
|  | 40 | func tearDown() { | 
|  | 41 | os.RemoveAll(buildDir) | 
|  | 42 | } | 
|  | 43 |  | 
|  | 44 | func TestMain(m *testing.M) { | 
|  | 45 | run := func() int { | 
|  | 46 | setUp() | 
|  | 47 | defer tearDown() | 
|  | 48 |  | 
|  | 49 | return m.Run() | 
|  | 50 | } | 
|  | 51 |  | 
|  | 52 | os.Exit(run()) | 
|  | 53 | } | 
| Colin Cross | 527012a | 2017-11-30 22:56:16 -0800 | [diff] [blame] | 54 |  | 
|  | 55 | func testConfig(env map[string]string) android.Config { | 
| Colin Cross | 7fdd2b7 | 2018-01-02 18:14:25 -0800 | [diff] [blame] | 56 | if env == nil { | 
|  | 57 | env = make(map[string]string) | 
|  | 58 | } | 
|  | 59 | if env["ANDROID_JAVA8_HOME"] == "" { | 
|  | 60 | env["ANDROID_JAVA8_HOME"] = "jdk8" | 
|  | 61 | } | 
| Jiyong Park | 1a5d7b1 | 2018-01-15 15:05:10 +0900 | [diff] [blame] | 62 | config := android.TestArchConfig(buildDir, env) | 
|  | 63 | config.ProductVariables.DeviceSystemSdkVersions = &[]string{"14", "15"} | 
|  | 64 | return config | 
| Colin Cross | 527012a | 2017-11-30 22:56:16 -0800 | [diff] [blame] | 65 |  | 
| Colin Cross | 1369cdb | 2017-09-29 17:58:17 -0700 | [diff] [blame] | 66 | } | 
|  | 67 |  | 
| Colin Cross | 527012a | 2017-11-30 22:56:16 -0800 | [diff] [blame] | 68 | func testContext(config android.Config, bp string, | 
|  | 69 | fs map[string][]byte) *android.TestContext { | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 70 |  | 
| Colin Cross | 4c428df | 2017-09-15 17:36:05 -0700 | [diff] [blame] | 71 | ctx := android.NewTestArchContext() | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 72 | ctx.RegisterModuleType("android_app", android.ModuleFactoryAdaptor(AndroidAppFactory)) | 
| Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 73 | ctx.RegisterModuleType("java_binary_host", android.ModuleFactoryAdaptor(BinaryHostFactory)) | 
| Colin Cross | a60ead8 | 2017-10-02 18:10:21 -0700 | [diff] [blame] | 74 | ctx.RegisterModuleType("java_library", android.ModuleFactoryAdaptor(LibraryFactory(true))) | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 75 | ctx.RegisterModuleType("java_library_host", android.ModuleFactoryAdaptor(LibraryHostFactory)) | 
| Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 76 | ctx.RegisterModuleType("java_import", android.ModuleFactoryAdaptor(ImportFactory)) | 
| Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 77 | ctx.RegisterModuleType("java_defaults", android.ModuleFactoryAdaptor(defaultsFactory)) | 
| Colin Cross | 1369cdb | 2017-09-29 17:58:17 -0700 | [diff] [blame] | 78 | ctx.RegisterModuleType("java_system_modules", android.ModuleFactoryAdaptor(SystemModulesFactory)) | 
| Colin Cross | 5425090 | 2017-12-05 09:28:08 -0800 | [diff] [blame] | 79 | ctx.RegisterModuleType("java_genrule", android.ModuleFactoryAdaptor(genRuleFactory)) | 
| Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 80 | ctx.RegisterModuleType("filegroup", android.ModuleFactoryAdaptor(genrule.FileGroupFactory)) | 
| Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 81 | ctx.RegisterModuleType("genrule", android.ModuleFactoryAdaptor(genrule.GenRuleFactory)) | 
| Colin Cross | 5ea9bcc | 2017-07-27 15:41:32 -0700 | [diff] [blame] | 82 | ctx.PreArchMutators(android.RegisterPrebuiltsPreArchMutators) | 
|  | 83 | ctx.PreArchMutators(android.RegisterPrebuiltsPostDepsMutators) | 
| Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 84 | ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators) | 
| Colin Cross | 3bc7ffa | 2017-11-22 16:19:37 -0800 | [diff] [blame] | 85 | ctx.RegisterPreSingletonType("overlay", android.SingletonFactoryAdaptor(OverlaySingletonFactory)) | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 86 | ctx.Register() | 
|  | 87 |  | 
| Colin Cross | 4c428df | 2017-09-15 17:36:05 -0700 | [diff] [blame] | 88 | extraModules := []string{ | 
|  | 89 | "core-oj", | 
|  | 90 | "core-libart", | 
|  | 91 | "framework", | 
|  | 92 | "ext", | 
|  | 93 | "okhttp", | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 94 | "android_stubs_current", | 
|  | 95 | "android_system_stubs_current", | 
|  | 96 | "android_test_stubs_current", | 
| Colin Cross | 93e8595 | 2017-08-15 13:34:18 -0700 | [diff] [blame] | 97 | "kotlin-stdlib", | 
| Colin Cross | 4c428df | 2017-09-15 17:36:05 -0700 | [diff] [blame] | 98 | } | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 99 |  | 
|  | 100 | for _, extra := range extraModules { | 
|  | 101 | bp += fmt.Sprintf(` | 
|  | 102 | java_library { | 
|  | 103 | name: "%s", | 
| Colin Cross | 0a6e007 | 2017-08-30 14:24:55 -0700 | [diff] [blame] | 104 | srcs: ["a.java"], | 
| Colin Cross | 76b5f0c | 2017-08-29 16:02:06 -0700 | [diff] [blame] | 105 | no_standard_libs: true, | 
| Colin Cross | 1369cdb | 2017-09-29 17:58:17 -0700 | [diff] [blame] | 106 | system_modules: "core-system-modules", | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 107 | } | 
|  | 108 | `, extra) | 
|  | 109 | } | 
|  | 110 |  | 
| Colin Cross | 5ab4e6d | 2017-11-22 16:20:45 -0800 | [diff] [blame] | 111 | bp += ` | 
|  | 112 | android_app { | 
|  | 113 | name: "framework-res", | 
|  | 114 | no_framework_libs: true, | 
|  | 115 | } | 
|  | 116 | ` | 
|  | 117 |  | 
| Colin Cross | 527012a | 2017-11-30 22:56:16 -0800 | [diff] [blame] | 118 | systemModules := []string{ | 
|  | 119 | "core-system-modules", | 
|  | 120 | "android_stubs_current_system_modules", | 
|  | 121 | "android_system_stubs_current_system_modules", | 
|  | 122 | "android_test_stubs_current_system_modules", | 
|  | 123 | } | 
| Colin Cross | 1369cdb | 2017-09-29 17:58:17 -0700 | [diff] [blame] | 124 |  | 
| Colin Cross | 527012a | 2017-11-30 22:56:16 -0800 | [diff] [blame] | 125 | for _, extra := range systemModules { | 
|  | 126 | bp += fmt.Sprintf(` | 
| Colin Cross | 1369cdb | 2017-09-29 17:58:17 -0700 | [diff] [blame] | 127 | java_system_modules { | 
|  | 128 | name: "%s", | 
|  | 129 | } | 
|  | 130 | `, extra) | 
| Colin Cross | 1369cdb | 2017-09-29 17:58:17 -0700 | [diff] [blame] | 131 | } | 
|  | 132 |  | 
| Colin Cross | 824bee3 | 2017-11-22 17:27:51 -0800 | [diff] [blame] | 133 | mockFS := map[string][]byte{ | 
|  | 134 | "Android.bp":  []byte(bp), | 
|  | 135 | "a.java":      nil, | 
|  | 136 | "b.java":      nil, | 
|  | 137 | "c.java":      nil, | 
|  | 138 | "b.kt":        nil, | 
|  | 139 | "a.jar":       nil, | 
|  | 140 | "b.jar":       nil, | 
|  | 141 | "java-res/a":  nil, | 
|  | 142 | "java-res/b":  nil, | 
|  | 143 | "java-res2/a": nil, | 
| Colin Cross | 0532fb0 | 2017-10-02 16:57:40 -0700 | [diff] [blame] | 144 |  | 
| Colin Cross | 2ebc476 | 2017-10-20 14:00:31 -0700 | [diff] [blame] | 145 | "prebuilts/sdk/14/android.jar":                nil, | 
|  | 146 | "prebuilts/sdk/14/framework.aidl":             nil, | 
|  | 147 | "prebuilts/sdk/current/android.jar":           nil, | 
|  | 148 | "prebuilts/sdk/current/framework.aidl":        nil, | 
|  | 149 | "prebuilts/sdk/system_current/android.jar":    nil, | 
|  | 150 | "prebuilts/sdk/system_current/framework.aidl": nil, | 
| Sundong Ahn | 0926fae | 2017-10-17 16:34:51 +0900 | [diff] [blame] | 151 | "prebuilts/sdk/system_14/android.jar":         nil, | 
|  | 152 | "prebuilts/sdk/system_14/framework.aidl":      nil, | 
| Colin Cross | 2ebc476 | 2017-10-20 14:00:31 -0700 | [diff] [blame] | 153 | "prebuilts/sdk/test_current/android.jar":      nil, | 
|  | 154 | "prebuilts/sdk/test_current/framework.aidl":   nil, | 
| Colin Cross | 5ab4e6d | 2017-11-22 16:20:45 -0800 | [diff] [blame] | 155 |  | 
|  | 156 | // For framework-res, which is an implicit dependency for framework | 
|  | 157 | "AndroidManifest.xml":                   nil, | 
|  | 158 | "build/target/product/security/testkey": nil, | 
| Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 159 |  | 
|  | 160 | "build/soong/scripts/jar-wrapper.sh": nil, | 
| Colin Cross | 7fdd2b7 | 2018-01-02 18:14:25 -0800 | [diff] [blame] | 161 |  | 
| Colin Cross | 66dbc0b | 2017-12-28 12:23:20 -0800 | [diff] [blame] | 162 | "build/make/core/proguard.flags":             nil, | 
|  | 163 | "build/make/core/proguard_basic_keeps.flags": nil, | 
|  | 164 |  | 
| Colin Cross | 7fdd2b7 | 2018-01-02 18:14:25 -0800 | [diff] [blame] | 165 | "jdk8/jre/lib/jce.jar": nil, | 
|  | 166 | "jdk8/jre/lib/rt.jar":  nil, | 
| Colin Cross | 824bee3 | 2017-11-22 17:27:51 -0800 | [diff] [blame] | 167 | } | 
|  | 168 |  | 
|  | 169 | for k, v := range fs { | 
|  | 170 | mockFS[k] = v | 
|  | 171 | } | 
|  | 172 |  | 
|  | 173 | ctx.MockFileSystem(mockFS) | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 174 |  | 
| Colin Cross | 527012a | 2017-11-30 22:56:16 -0800 | [diff] [blame] | 175 | return ctx | 
|  | 176 | } | 
|  | 177 |  | 
|  | 178 | func run(t *testing.T, ctx *android.TestContext, config android.Config) { | 
| Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 179 | t.Helper() | 
| Jeff Gaston | d3e141d | 2017-08-08 17:46:01 -0700 | [diff] [blame] | 180 | _, errs := ctx.ParseFileList(".", []string{"Android.bp"}) | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 181 | fail(t, errs) | 
|  | 182 | _, errs = ctx.PrepareBuildActions(config) | 
|  | 183 | fail(t, errs) | 
| Colin Cross | 527012a | 2017-11-30 22:56:16 -0800 | [diff] [blame] | 184 | } | 
|  | 185 |  | 
|  | 186 | func testJava(t *testing.T, bp string) *android.TestContext { | 
| Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 187 | t.Helper() | 
| Colin Cross | 527012a | 2017-11-30 22:56:16 -0800 | [diff] [blame] | 188 | config := testConfig(nil) | 
|  | 189 | ctx := testContext(config, bp, nil) | 
|  | 190 | run(t, ctx, config) | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 191 |  | 
|  | 192 | return ctx | 
|  | 193 | } | 
|  | 194 |  | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 195 | func moduleToPath(name string) string { | 
|  | 196 | switch { | 
|  | 197 | case name == `""`: | 
|  | 198 | return name | 
| Colin Cross | fc3674a | 2017-09-18 17:41:52 -0700 | [diff] [blame] | 199 | case strings.HasSuffix(name, ".jar"): | 
|  | 200 | return name | 
| Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 201 | case name == "android_stubs_current" || name == "android_system_stubs_current" || | 
|  | 202 | name == "android_test_stubs_current": | 
| Colin Cross | 1ee2317 | 2017-10-18 14:44:18 -0700 | [diff] [blame] | 203 | return filepath.Join(buildDir, ".intermediates", name, "android_common", "javac", name+".jar") | 
| Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 204 | default: | 
|  | 205 | return filepath.Join(buildDir, ".intermediates", name, "android_common", "turbine-combined", name+".jar") | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 206 | } | 
|  | 207 | } | 
|  | 208 |  | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 209 | func TestSimple(t *testing.T) { | 
|  | 210 | ctx := testJava(t, ` | 
|  | 211 | java_library { | 
|  | 212 | name: "foo", | 
|  | 213 | srcs: ["a.java"], | 
| Colin Cross | e8dc34a | 2017-07-19 11:22:16 -0700 | [diff] [blame] | 214 | libs: ["bar"], | 
|  | 215 | static_libs: ["baz"], | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 216 | } | 
|  | 217 |  | 
|  | 218 | java_library { | 
|  | 219 | name: "bar", | 
|  | 220 | srcs: ["b.java"], | 
|  | 221 | } | 
|  | 222 |  | 
|  | 223 | java_library { | 
|  | 224 | name: "baz", | 
|  | 225 | srcs: ["c.java"], | 
|  | 226 | } | 
| Colin Cross | d5934c8 | 2017-10-02 13:55:26 -0700 | [diff] [blame] | 227 | `) | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 228 |  | 
| Colin Cross | 4c428df | 2017-09-15 17:36:05 -0700 | [diff] [blame] | 229 | javac := ctx.ModuleForTests("foo", "android_common").Rule("javac") | 
| Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 230 | combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac") | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 231 |  | 
|  | 232 | if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" { | 
|  | 233 | t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs) | 
|  | 234 | } | 
|  | 235 |  | 
| Colin Cross | 1ee2317 | 2017-10-18 14:44:18 -0700 | [diff] [blame] | 236 | baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String() | 
| Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 237 | barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar") | 
|  | 238 | bazTurbine := filepath.Join(buildDir, ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar") | 
| Colin Cross | 0a6e007 | 2017-08-30 14:24:55 -0700 | [diff] [blame] | 239 |  | 
| Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 240 | if !strings.Contains(javac.Args["classpath"], barTurbine) { | 
|  | 241 | t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine) | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 242 | } | 
|  | 243 |  | 
| Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 244 | if !strings.Contains(javac.Args["classpath"], bazTurbine) { | 
|  | 245 | t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], bazTurbine) | 
| Colin Cross | 0a6e007 | 2017-08-30 14:24:55 -0700 | [diff] [blame] | 246 | } | 
|  | 247 |  | 
|  | 248 | if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz { | 
|  | 249 | t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz) | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 250 | } | 
|  | 251 | } | 
|  | 252 |  | 
| Colin Cross | d5934c8 | 2017-10-02 13:55:26 -0700 | [diff] [blame] | 253 | func TestArchSpecific(t *testing.T) { | 
|  | 254 | ctx := testJava(t, ` | 
|  | 255 | java_library { | 
|  | 256 | name: "foo", | 
|  | 257 | srcs: ["a.java"], | 
|  | 258 | target: { | 
|  | 259 | android: { | 
|  | 260 | srcs: ["b.java"], | 
|  | 261 | }, | 
|  | 262 | }, | 
|  | 263 | } | 
|  | 264 | `) | 
|  | 265 |  | 
|  | 266 | javac := ctx.ModuleForTests("foo", "android_common").Rule("javac") | 
|  | 267 | if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" { | 
|  | 268 | t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs) | 
|  | 269 | } | 
|  | 270 | } | 
|  | 271 |  | 
| Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 272 | func TestBinary(t *testing.T) { | 
|  | 273 | ctx := testJava(t, ` | 
|  | 274 | java_library_host { | 
|  | 275 | name: "foo", | 
|  | 276 | srcs: ["a.java"], | 
|  | 277 | } | 
|  | 278 |  | 
|  | 279 | java_binary_host { | 
|  | 280 | name: "bar", | 
|  | 281 | srcs: ["b.java"], | 
|  | 282 | static_libs: ["foo"], | 
|  | 283 | } | 
|  | 284 | `) | 
|  | 285 |  | 
|  | 286 | buildOS := android.BuildOs.String() | 
|  | 287 |  | 
|  | 288 | bar := ctx.ModuleForTests("bar", buildOS+"_common") | 
|  | 289 | barJar := bar.Output("bar.jar").Output.String() | 
|  | 290 | barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64") | 
|  | 291 | barWrapperDeps := barWrapper.Output("bar").Implicits.Strings() | 
|  | 292 |  | 
|  | 293 | // Test that the install binary wrapper depends on the installed jar file | 
|  | 294 | if len(barWrapperDeps) != 1 || barWrapperDeps[0] != barJar { | 
|  | 295 | t.Errorf("expected binary wrapper implicits [%q], got %v", | 
|  | 296 | barJar, barWrapperDeps) | 
|  | 297 | } | 
|  | 298 |  | 
|  | 299 | } | 
|  | 300 |  | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 301 | var classpathTestcases = []struct { | 
|  | 302 | name          string | 
| Colin Cross | 965714f | 2017-10-03 20:57:01 -0700 | [diff] [blame] | 303 | moduleType    string | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 304 | host          android.OsClass | 
|  | 305 | properties    string | 
|  | 306 | bootclasspath []string | 
| Colin Cross | 1369cdb | 2017-09-29 17:58:17 -0700 | [diff] [blame] | 307 | system        string | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 308 | classpath     []string | 
|  | 309 | }{ | 
|  | 310 | { | 
|  | 311 | name:          "default", | 
|  | 312 | bootclasspath: []string{"core-oj", "core-libart"}, | 
| Colin Cross | 1369cdb | 2017-09-29 17:58:17 -0700 | [diff] [blame] | 313 | system:        "core-system-modules", | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 314 | classpath:     []string{"ext", "framework", "okhttp"}, | 
|  | 315 | }, | 
|  | 316 | { | 
|  | 317 | name:          "blank sdk version", | 
|  | 318 | properties:    `sdk_version: "",`, | 
|  | 319 | bootclasspath: []string{"core-oj", "core-libart"}, | 
| Colin Cross | 1369cdb | 2017-09-29 17:58:17 -0700 | [diff] [blame] | 320 | system:        "core-system-modules", | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 321 | classpath:     []string{"ext", "framework", "okhttp"}, | 
|  | 322 | }, | 
|  | 323 | { | 
| Colin Cross | 4c428df | 2017-09-15 17:36:05 -0700 | [diff] [blame] | 324 |  | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 325 | name:          "sdk v14", | 
|  | 326 | properties:    `sdk_version: "14",`, | 
| Colin Cross | fc3674a | 2017-09-18 17:41:52 -0700 | [diff] [blame] | 327 | bootclasspath: []string{`""`}, | 
| Colin Cross | 1369cdb | 2017-09-29 17:58:17 -0700 | [diff] [blame] | 328 | system:        "bootclasspath", // special value to tell 1.9 test to expect bootclasspath | 
| Colin Cross | fc3674a | 2017-09-18 17:41:52 -0700 | [diff] [blame] | 329 | classpath:     []string{"prebuilts/sdk/14/android.jar"}, | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 330 | }, | 
|  | 331 | { | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 332 |  | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 333 | name:          "current", | 
|  | 334 | properties:    `sdk_version: "current",`, | 
| Colin Cross | 2ebc476 | 2017-10-20 14:00:31 -0700 | [diff] [blame] | 335 | bootclasspath: []string{`""`}, | 
|  | 336 | system:        "bootclasspath", // special value to tell 1.9 test to expect bootclasspath | 
|  | 337 | classpath:     []string{"prebuilts/sdk/current/android.jar"}, | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 338 | }, | 
|  | 339 | { | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 340 |  | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 341 | name:          "system_current", | 
|  | 342 | properties:    `sdk_version: "system_current",`, | 
| Colin Cross | 2ebc476 | 2017-10-20 14:00:31 -0700 | [diff] [blame] | 343 | bootclasspath: []string{`""`}, | 
|  | 344 | system:        "bootclasspath", // special value to tell 1.9 test to expect bootclasspath | 
|  | 345 | classpath:     []string{"prebuilts/sdk/system_current/android.jar"}, | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 346 | }, | 
|  | 347 | { | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 348 |  | 
| Sundong Ahn | 0926fae | 2017-10-17 16:34:51 +0900 | [diff] [blame] | 349 | name:          "system_14", | 
|  | 350 | properties:    `sdk_version: "system_14",`, | 
|  | 351 | bootclasspath: []string{`""`}, | 
|  | 352 | system:        "bootclasspath", // special value to tell 1.9 test to expect bootclasspath | 
|  | 353 | classpath:     []string{"prebuilts/sdk/system_14/android.jar"}, | 
|  | 354 | }, | 
|  | 355 | { | 
|  | 356 |  | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 357 | name:          "test_current", | 
|  | 358 | properties:    `sdk_version: "test_current",`, | 
| Colin Cross | 2ebc476 | 2017-10-20 14:00:31 -0700 | [diff] [blame] | 359 | bootclasspath: []string{`""`}, | 
|  | 360 | system:        "bootclasspath", // special value to tell 1.9 test to expect bootclasspath | 
|  | 361 | classpath:     []string{"prebuilts/sdk/test_current/android.jar"}, | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 362 | }, | 
|  | 363 | { | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 364 |  | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 365 | name:          "nostdlib", | 
| Colin Cross | 1369cdb | 2017-09-29 17:58:17 -0700 | [diff] [blame] | 366 | properties:    `no_standard_libs: true, system_modules: "none"`, | 
|  | 367 | system:        "none", | 
|  | 368 | bootclasspath: []string{`""`}, | 
|  | 369 | classpath:     []string{}, | 
|  | 370 | }, | 
|  | 371 | { | 
|  | 372 |  | 
|  | 373 | name:          "nostdlib system_modules", | 
|  | 374 | properties:    `no_standard_libs: true, system_modules: "core-system-modules"`, | 
|  | 375 | system:        "core-system-modules", | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 376 | bootclasspath: []string{`""`}, | 
|  | 377 | classpath:     []string{}, | 
|  | 378 | }, | 
|  | 379 | { | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 380 |  | 
| Colin Cross | 7fdd2b7 | 2018-01-02 18:14:25 -0800 | [diff] [blame] | 381 | name:          "host default", | 
|  | 382 | moduleType:    "java_library_host", | 
|  | 383 | properties:    ``, | 
|  | 384 | host:          android.Host, | 
|  | 385 | bootclasspath: []string{"jdk8/jre/lib/jce.jar", "jdk8/jre/lib/rt.jar"}, | 
|  | 386 | classpath:     []string{}, | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 387 | }, | 
|  | 388 | { | 
|  | 389 | name:       "host nostdlib", | 
| Colin Cross | 965714f | 2017-10-03 20:57:01 -0700 | [diff] [blame] | 390 | moduleType: "java_library_host", | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 391 | host:       android.Host, | 
|  | 392 | properties: `no_standard_libs: true`, | 
|  | 393 | classpath:  []string{}, | 
|  | 394 | }, | 
| Colin Cross | 965714f | 2017-10-03 20:57:01 -0700 | [diff] [blame] | 395 | { | 
|  | 396 |  | 
| Colin Cross | 7fdd2b7 | 2018-01-02 18:14:25 -0800 | [diff] [blame] | 397 | name:          "host supported default", | 
|  | 398 | host:          android.Host, | 
|  | 399 | properties:    `host_supported: true,`, | 
|  | 400 | classpath:     []string{}, | 
|  | 401 | bootclasspath: []string{"jdk8/jre/lib/jce.jar", "jdk8/jre/lib/rt.jar"}, | 
| Colin Cross | 965714f | 2017-10-03 20:57:01 -0700 | [diff] [blame] | 402 | }, | 
|  | 403 | { | 
|  | 404 | name:       "host supported nostdlib", | 
|  | 405 | host:       android.Host, | 
| Colin Cross | 1369cdb | 2017-09-29 17:58:17 -0700 | [diff] [blame] | 406 | properties: `host_supported: true, no_standard_libs: true, system_modules: "none"`, | 
| Colin Cross | 965714f | 2017-10-03 20:57:01 -0700 | [diff] [blame] | 407 | classpath:  []string{}, | 
|  | 408 | }, | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 409 | } | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 410 |  | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 411 | func TestClasspath(t *testing.T) { | 
|  | 412 | for _, testcase := range classpathTestcases { | 
|  | 413 | t.Run(testcase.name, func(t *testing.T) { | 
| Colin Cross | 965714f | 2017-10-03 20:57:01 -0700 | [diff] [blame] | 414 | moduleType := "java_library" | 
|  | 415 | if testcase.moduleType != "" { | 
|  | 416 | moduleType = testcase.moduleType | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 417 | } | 
| Colin Cross | 1369cdb | 2017-09-29 17:58:17 -0700 | [diff] [blame] | 418 |  | 
|  | 419 | bp := moduleType + ` { | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 420 | name: "foo", | 
|  | 421 | srcs: ["a.java"], | 
| Colin Cross | 1369cdb | 2017-09-29 17:58:17 -0700 | [diff] [blame] | 422 | ` + testcase.properties + ` | 
|  | 423 | }` | 
|  | 424 |  | 
|  | 425 | variant := "android_common" | 
|  | 426 | if testcase.host == android.Host { | 
|  | 427 | variant = android.BuildOs.String() + "_common" | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 428 | } | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 429 |  | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 430 | convertModulesToPaths := func(cp []string) []string { | 
|  | 431 | ret := make([]string, len(cp)) | 
|  | 432 | for i, e := range cp { | 
|  | 433 | ret[i] = moduleToPath(e) | 
|  | 434 | } | 
|  | 435 | return ret | 
|  | 436 | } | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 437 |  | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 438 | bootclasspath := convertModulesToPaths(testcase.bootclasspath) | 
|  | 439 | classpath := convertModulesToPaths(testcase.classpath) | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 440 |  | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 441 | bc := strings.Join(bootclasspath, ":") | 
| Colin Cross | 1369cdb | 2017-09-29 17:58:17 -0700 | [diff] [blame] | 442 | if bc != "" { | 
|  | 443 | bc = "-bootclasspath " + bc | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 444 | } | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 445 |  | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 446 | c := strings.Join(classpath, ":") | 
| Colin Cross | 1369cdb | 2017-09-29 17:58:17 -0700 | [diff] [blame] | 447 | if c != "" { | 
|  | 448 | c = "-classpath " + c | 
|  | 449 | } | 
|  | 450 | system := "" | 
|  | 451 | if testcase.system == "none" { | 
|  | 452 | system = "--system=none" | 
|  | 453 | } else if testcase.system != "" { | 
|  | 454 | system = "--system=" + filepath.Join(buildDir, ".intermediates", testcase.system, "android_common", "system") + "/" | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 455 | } | 
|  | 456 |  | 
| Colin Cross | 1369cdb | 2017-09-29 17:58:17 -0700 | [diff] [blame] | 457 | t.Run("1.8", func(t *testing.T) { | 
|  | 458 | // Test default javac 1.8 | 
|  | 459 | ctx := testJava(t, bp) | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 460 |  | 
| Colin Cross | 1369cdb | 2017-09-29 17:58:17 -0700 | [diff] [blame] | 461 | javac := ctx.ModuleForTests("foo", variant).Rule("javac") | 
|  | 462 |  | 
|  | 463 | got := javac.Args["bootClasspath"] | 
|  | 464 | if got != bc { | 
|  | 465 | t.Errorf("bootclasspath expected %q != got %q", bc, got) | 
|  | 466 | } | 
|  | 467 |  | 
|  | 468 | got = javac.Args["classpath"] | 
|  | 469 | if got != c { | 
|  | 470 | t.Errorf("classpath expected %q != got %q", c, got) | 
|  | 471 | } | 
|  | 472 |  | 
|  | 473 | var deps []string | 
|  | 474 | if len(bootclasspath) > 0 && bootclasspath[0] != `""` { | 
|  | 475 | deps = append(deps, bootclasspath...) | 
|  | 476 | } | 
|  | 477 | deps = append(deps, classpath...) | 
|  | 478 |  | 
|  | 479 | if !reflect.DeepEqual(javac.Implicits.Strings(), deps) { | 
|  | 480 | t.Errorf("implicits expected %q != got %q", deps, javac.Implicits.Strings()) | 
|  | 481 | } | 
|  | 482 | }) | 
|  | 483 |  | 
|  | 484 | // Test again with javac 1.9 | 
|  | 485 | t.Run("1.9", func(t *testing.T) { | 
| Colin Cross | 527012a | 2017-11-30 22:56:16 -0800 | [diff] [blame] | 486 | config := testConfig(map[string]string{"EXPERIMENTAL_USE_OPENJDK9": "true"}) | 
|  | 487 | ctx := testContext(config, bp, nil) | 
|  | 488 | run(t, ctx, config) | 
| Colin Cross | 1369cdb | 2017-09-29 17:58:17 -0700 | [diff] [blame] | 489 |  | 
|  | 490 | javac := ctx.ModuleForTests("foo", variant).Rule("javac") | 
|  | 491 | got := javac.Args["bootClasspath"] | 
|  | 492 | expected := system | 
|  | 493 | if testcase.system == "bootclasspath" { | 
|  | 494 | expected = bc | 
|  | 495 | } | 
|  | 496 | if got != expected { | 
|  | 497 | t.Errorf("bootclasspath expected %q != got %q", expected, got) | 
|  | 498 | } | 
|  | 499 | }) | 
| Colin Cross | 2acdae8 | 2017-09-15 19:44:24 -0700 | [diff] [blame] | 500 | }) | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 501 | } | 
|  | 502 |  | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 503 | } | 
|  | 504 |  | 
|  | 505 | func TestPrebuilts(t *testing.T) { | 
|  | 506 | ctx := testJava(t, ` | 
|  | 507 | java_library { | 
|  | 508 | name: "foo", | 
|  | 509 | srcs: ["a.java"], | 
| Colin Cross | e8dc34a | 2017-07-19 11:22:16 -0700 | [diff] [blame] | 510 | libs: ["bar"], | 
|  | 511 | static_libs: ["baz"], | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 512 | } | 
|  | 513 |  | 
| Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 514 | java_import { | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 515 | name: "bar", | 
| Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 516 | jars: ["a.jar"], | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 517 | } | 
|  | 518 |  | 
| Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 519 | java_import { | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 520 | name: "baz", | 
| Colin Cross | 74d73e2 | 2017-08-02 11:05:49 -0700 | [diff] [blame] | 521 | jars: ["b.jar"], | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 522 | } | 
|  | 523 | `) | 
|  | 524 |  | 
| Colin Cross | 4c428df | 2017-09-15 17:36:05 -0700 | [diff] [blame] | 525 | javac := ctx.ModuleForTests("foo", "android_common").Rule("javac") | 
| Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 526 | combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac") | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 527 |  | 
|  | 528 | bar := "a.jar" | 
|  | 529 | if !strings.Contains(javac.Args["classpath"], bar) { | 
|  | 530 | t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], bar) | 
|  | 531 | } | 
|  | 532 |  | 
| Colin Cross | 0a6e007 | 2017-08-30 14:24:55 -0700 | [diff] [blame] | 533 | if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != "b.jar" { | 
|  | 534 | t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, "b.jar") | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 535 | } | 
|  | 536 | } | 
|  | 537 |  | 
| Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 538 | func TestDefaults(t *testing.T) { | 
|  | 539 | ctx := testJava(t, ` | 
|  | 540 | java_defaults { | 
|  | 541 | name: "defaults", | 
|  | 542 | srcs: ["a.java"], | 
|  | 543 | libs: ["bar"], | 
|  | 544 | static_libs: ["baz"], | 
|  | 545 | } | 
|  | 546 |  | 
|  | 547 | java_library { | 
|  | 548 | name: "foo", | 
|  | 549 | defaults: ["defaults"], | 
|  | 550 | } | 
|  | 551 |  | 
|  | 552 | java_library { | 
|  | 553 | name: "bar", | 
|  | 554 | srcs: ["b.java"], | 
|  | 555 | } | 
|  | 556 |  | 
|  | 557 | java_library { | 
|  | 558 | name: "baz", | 
|  | 559 | srcs: ["c.java"], | 
|  | 560 | } | 
|  | 561 | `) | 
|  | 562 |  | 
| Colin Cross | 4c428df | 2017-09-15 17:36:05 -0700 | [diff] [blame] | 563 | javac := ctx.ModuleForTests("foo", "android_common").Rule("javac") | 
| Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 564 | combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac") | 
| Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 565 |  | 
|  | 566 | if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" { | 
|  | 567 | t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs) | 
|  | 568 | } | 
|  | 569 |  | 
| Nan Zhang | ed19fc3 | 2017-10-19 13:06:22 -0700 | [diff] [blame] | 570 | barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar") | 
|  | 571 | if !strings.Contains(javac.Args["classpath"], barTurbine) { | 
|  | 572 | t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine) | 
| Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 573 | } | 
|  | 574 |  | 
| Colin Cross | 1ee2317 | 2017-10-18 14:44:18 -0700 | [diff] [blame] | 575 | baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String() | 
| Colin Cross | 0a6e007 | 2017-08-30 14:24:55 -0700 | [diff] [blame] | 576 | if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz { | 
|  | 577 | t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz) | 
| Colin Cross | 89536d4 | 2017-07-07 14:35:50 -0700 | [diff] [blame] | 578 | } | 
|  | 579 | } | 
|  | 580 |  | 
| Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 581 | func TestResources(t *testing.T) { | 
|  | 582 | var table = []struct { | 
|  | 583 | name  string | 
|  | 584 | prop  string | 
|  | 585 | extra string | 
|  | 586 | args  string | 
|  | 587 | }{ | 
|  | 588 | { | 
| Colin Cross | af9c55b | 2017-10-03 14:50:08 -0700 | [diff] [blame] | 589 | // Test that a module with java_resource_dirs includes the files | 
| Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 590 | name: "resource dirs", | 
| Colin Cross | 824bee3 | 2017-11-22 17:27:51 -0800 | [diff] [blame] | 591 | prop: `java_resource_dirs: ["java-res"]`, | 
|  | 592 | args: "-C java-res -f java-res/a -f java-res/b", | 
| Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 593 | }, | 
|  | 594 | { | 
|  | 595 | // Test that a module with java_resources includes the files | 
|  | 596 | name: "resource files", | 
| Colin Cross | 824bee3 | 2017-11-22 17:27:51 -0800 | [diff] [blame] | 597 | prop: `java_resources: ["java-res/a", "java-res/b"]`, | 
|  | 598 | args: "-C . -f java-res/a -f java-res/b", | 
| Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 599 | }, | 
|  | 600 | { | 
|  | 601 | // Test that a module with a filegroup in java_resources includes the files with the | 
|  | 602 | // path prefix | 
|  | 603 | name: "resource filegroup", | 
|  | 604 | prop: `java_resources: [":foo-res"]`, | 
|  | 605 | extra: ` | 
|  | 606 | filegroup { | 
|  | 607 | name: "foo-res", | 
| Colin Cross | 824bee3 | 2017-11-22 17:27:51 -0800 | [diff] [blame] | 608 | path: "java-res", | 
|  | 609 | srcs: ["java-res/a", "java-res/b"], | 
| Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 610 | }`, | 
| Colin Cross | 824bee3 | 2017-11-22 17:27:51 -0800 | [diff] [blame] | 611 | args: "-C java-res -f java-res/a -f java-res/b", | 
| Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 612 | }, | 
|  | 613 | { | 
|  | 614 | // Test that a module with "include_srcs: true" includes its source files in the resources jar | 
|  | 615 | name: "include sources", | 
|  | 616 | prop: `include_srcs: true`, | 
| Colin Cross | af9c55b | 2017-10-03 14:50:08 -0700 | [diff] [blame] | 617 | args: "-C . -f a.java -f b.java -f c.java", | 
| Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 618 | }, | 
|  | 619 | } | 
|  | 620 |  | 
|  | 621 | for _, test := range table { | 
|  | 622 | t.Run(test.name, func(t *testing.T) { | 
|  | 623 | ctx := testJava(t, ` | 
|  | 624 | java_library { | 
|  | 625 | name: "foo", | 
|  | 626 | srcs: [ | 
|  | 627 | "a.java", | 
|  | 628 | "b.java", | 
|  | 629 | "c.java", | 
|  | 630 | ], | 
|  | 631 | `+test.prop+`, | 
|  | 632 | } | 
|  | 633 | `+test.extra) | 
|  | 634 |  | 
| Colin Cross | 1ee2317 | 2017-10-18 14:44:18 -0700 | [diff] [blame] | 635 | foo := ctx.ModuleForTests("foo", "android_common").Output("combined/foo.jar") | 
|  | 636 | fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar") | 
| Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 637 |  | 
|  | 638 | if !inList(fooRes.Output.String(), foo.Inputs.Strings()) { | 
|  | 639 | t.Errorf("foo combined jars %v does not contain %q", | 
|  | 640 | foo.Inputs.Strings(), fooRes.Output.String()) | 
|  | 641 | } | 
|  | 642 |  | 
| Colin Cross | af9c55b | 2017-10-03 14:50:08 -0700 | [diff] [blame] | 643 | if fooRes.Args["jarArgs"] != test.args { | 
|  | 644 | t.Errorf("foo resource jar args %q is not %q", | 
| Colin Cross | 0f37af0 | 2017-09-27 17:42:05 -0700 | [diff] [blame] | 645 | fooRes.Args["jarArgs"], test.args) | 
|  | 646 | } | 
|  | 647 | }) | 
|  | 648 | } | 
|  | 649 | } | 
|  | 650 |  | 
| Colin Cross | 0532fb0 | 2017-10-02 16:57:40 -0700 | [diff] [blame] | 651 | func TestExcludeResources(t *testing.T) { | 
|  | 652 | ctx := testJava(t, ` | 
|  | 653 | java_library { | 
|  | 654 | name: "foo", | 
|  | 655 | srcs: ["a.java"], | 
| Colin Cross | 824bee3 | 2017-11-22 17:27:51 -0800 | [diff] [blame] | 656 | java_resource_dirs: ["java-res", "java-res2"], | 
|  | 657 | exclude_java_resource_dirs: ["java-res2"], | 
| Colin Cross | 0532fb0 | 2017-10-02 16:57:40 -0700 | [diff] [blame] | 658 | } | 
|  | 659 |  | 
|  | 660 | java_library { | 
|  | 661 | name: "bar", | 
|  | 662 | srcs: ["a.java"], | 
| Colin Cross | 824bee3 | 2017-11-22 17:27:51 -0800 | [diff] [blame] | 663 | java_resources: ["java-res/*"], | 
|  | 664 | exclude_java_resources: ["java-res/b"], | 
| Colin Cross | 0532fb0 | 2017-10-02 16:57:40 -0700 | [diff] [blame] | 665 | } | 
|  | 666 | `) | 
|  | 667 |  | 
| Colin Cross | 1ee2317 | 2017-10-18 14:44:18 -0700 | [diff] [blame] | 668 | fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar") | 
| Colin Cross | 0532fb0 | 2017-10-02 16:57:40 -0700 | [diff] [blame] | 669 |  | 
| Colin Cross | 824bee3 | 2017-11-22 17:27:51 -0800 | [diff] [blame] | 670 | expected := "-C java-res -f java-res/a -f java-res/b" | 
| Colin Cross | 0532fb0 | 2017-10-02 16:57:40 -0700 | [diff] [blame] | 671 | if fooRes.Args["jarArgs"] != expected { | 
|  | 672 | t.Errorf("foo resource jar args %q is not %q", | 
|  | 673 | fooRes.Args["jarArgs"], expected) | 
|  | 674 |  | 
|  | 675 | } | 
|  | 676 |  | 
| Colin Cross | 1ee2317 | 2017-10-18 14:44:18 -0700 | [diff] [blame] | 677 | barRes := ctx.ModuleForTests("bar", "android_common").Output("res/bar.jar") | 
| Colin Cross | 0532fb0 | 2017-10-02 16:57:40 -0700 | [diff] [blame] | 678 |  | 
| Colin Cross | 824bee3 | 2017-11-22 17:27:51 -0800 | [diff] [blame] | 679 | expected = "-C . -f java-res/a" | 
| Colin Cross | 0532fb0 | 2017-10-02 16:57:40 -0700 | [diff] [blame] | 680 | if barRes.Args["jarArgs"] != expected { | 
|  | 681 | t.Errorf("bar resource jar args %q is not %q", | 
|  | 682 | barRes.Args["jarArgs"], expected) | 
|  | 683 |  | 
|  | 684 | } | 
|  | 685 | } | 
|  | 686 |  | 
| Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 687 | func TestGeneratedSources(t *testing.T) { | 
|  | 688 | ctx := testJava(t, ` | 
|  | 689 | java_library { | 
|  | 690 | name: "foo", | 
|  | 691 | srcs: [ | 
|  | 692 | "a*.java", | 
|  | 693 | ":gen", | 
|  | 694 | "b*.java", | 
|  | 695 | ], | 
|  | 696 | } | 
|  | 697 |  | 
|  | 698 | genrule { | 
|  | 699 | name: "gen", | 
| Colin Cross | 824bee3 | 2017-11-22 17:27:51 -0800 | [diff] [blame] | 700 | tool_files: ["java-res/a"], | 
| Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 701 | out: ["gen.java"], | 
|  | 702 | } | 
|  | 703 | `) | 
|  | 704 |  | 
|  | 705 | javac := ctx.ModuleForTests("foo", "android_common").Rule("javac") | 
|  | 706 | genrule := ctx.ModuleForTests("gen", "").Rule("generator") | 
|  | 707 |  | 
| Colin Cross | 15e86d9 | 2017-10-20 15:07:08 -0700 | [diff] [blame] | 708 | if filepath.Base(genrule.Output.String()) != "gen.java" { | 
|  | 709 | t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String()) | 
| Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 710 | } | 
|  | 711 |  | 
|  | 712 | if len(javac.Inputs) != 3 || | 
|  | 713 | javac.Inputs[0].String() != "a.java" || | 
| Colin Cross | 15e86d9 | 2017-10-20 15:07:08 -0700 | [diff] [blame] | 714 | javac.Inputs[1].String() != genrule.Output.String() || | 
| Colin Cross | 54190b3 | 2017-10-09 15:34:10 -0700 | [diff] [blame] | 715 | javac.Inputs[2].String() != "b.java" { | 
|  | 716 | t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs) | 
|  | 717 | } | 
|  | 718 | } | 
|  | 719 |  | 
| Colin Cross | 93e8595 | 2017-08-15 13:34:18 -0700 | [diff] [blame] | 720 | func TestKotlin(t *testing.T) { | 
|  | 721 | ctx := testJava(t, ` | 
|  | 722 | java_library { | 
|  | 723 | name: "foo", | 
| Colin Cross | 9bc4343 | 2017-12-15 20:20:39 -0800 | [diff] [blame] | 724 | srcs: ["a.java", "b.kt"], | 
| Colin Cross | 93e8595 | 2017-08-15 13:34:18 -0700 | [diff] [blame] | 725 | } | 
| Colin Cross | 715d711 | 2017-10-25 20:32:18 -0700 | [diff] [blame] | 726 |  | 
|  | 727 | java_library { | 
|  | 728 | name: "bar", | 
| Colin Cross | 9bc4343 | 2017-12-15 20:20:39 -0800 | [diff] [blame] | 729 | srcs: ["b.kt"], | 
|  | 730 | libs: ["foo"], | 
|  | 731 | static_libs: ["baz"], | 
|  | 732 | } | 
|  | 733 |  | 
|  | 734 | java_library { | 
|  | 735 | name: "baz", | 
|  | 736 | srcs: ["c.java"], | 
| Colin Cross | 715d711 | 2017-10-25 20:32:18 -0700 | [diff] [blame] | 737 | } | 
| Colin Cross | 93e8595 | 2017-08-15 13:34:18 -0700 | [diff] [blame] | 738 | `) | 
|  | 739 |  | 
| Colin Cross | 9bc4343 | 2017-12-15 20:20:39 -0800 | [diff] [blame] | 740 | fooKotlinc := ctx.ModuleForTests("foo", "android_common").Rule("kotlinc") | 
|  | 741 | fooJavac := ctx.ModuleForTests("foo", "android_common").Rule("javac") | 
|  | 742 | fooJar := ctx.ModuleForTests("foo", "android_common").Output("combined/foo.jar") | 
| Colin Cross | 93e8595 | 2017-08-15 13:34:18 -0700 | [diff] [blame] | 743 |  | 
| Colin Cross | 9bc4343 | 2017-12-15 20:20:39 -0800 | [diff] [blame] | 744 | if len(fooKotlinc.Inputs) != 2 || fooKotlinc.Inputs[0].String() != "a.java" || | 
|  | 745 | fooKotlinc.Inputs[1].String() != "b.kt" { | 
|  | 746 | t.Errorf(`foo kotlinc inputs %v != ["a.java", "b.kt"]`, fooKotlinc.Inputs) | 
| Colin Cross | 93e8595 | 2017-08-15 13:34:18 -0700 | [diff] [blame] | 747 | } | 
|  | 748 |  | 
| Colin Cross | 9bc4343 | 2017-12-15 20:20:39 -0800 | [diff] [blame] | 749 | if len(fooJavac.Inputs) != 1 || fooJavac.Inputs[0].String() != "a.java" { | 
|  | 750 | t.Errorf(`foo inputs %v != ["a.java"]`, fooJavac.Inputs) | 
| Colin Cross | 93e8595 | 2017-08-15 13:34:18 -0700 | [diff] [blame] | 751 | } | 
|  | 752 |  | 
| Colin Cross | 9bc4343 | 2017-12-15 20:20:39 -0800 | [diff] [blame] | 753 | if !strings.Contains(fooJavac.Args["classpath"], fooKotlinc.Output.String()) { | 
| Colin Cross | 93e8595 | 2017-08-15 13:34:18 -0700 | [diff] [blame] | 754 | t.Errorf("foo classpath %v does not contain %q", | 
| Colin Cross | 9bc4343 | 2017-12-15 20:20:39 -0800 | [diff] [blame] | 755 | fooJavac.Args["classpath"], fooKotlinc.Output.String()) | 
| Colin Cross | 93e8595 | 2017-08-15 13:34:18 -0700 | [diff] [blame] | 756 | } | 
|  | 757 |  | 
| Colin Cross | 9bc4343 | 2017-12-15 20:20:39 -0800 | [diff] [blame] | 758 | if !inList(fooKotlinc.Output.String(), fooJar.Inputs.Strings()) { | 
| Colin Cross | 93e8595 | 2017-08-15 13:34:18 -0700 | [diff] [blame] | 759 | t.Errorf("foo jar inputs %v does not contain %q", | 
| Colin Cross | 9bc4343 | 2017-12-15 20:20:39 -0800 | [diff] [blame] | 760 | fooJar.Inputs.Strings(), fooKotlinc.Output.String()) | 
| Colin Cross | 93e8595 | 2017-08-15 13:34:18 -0700 | [diff] [blame] | 761 | } | 
| Colin Cross | 715d711 | 2017-10-25 20:32:18 -0700 | [diff] [blame] | 762 |  | 
| Colin Cross | 9bc4343 | 2017-12-15 20:20:39 -0800 | [diff] [blame] | 763 | fooHeaderJar := ctx.ModuleForTests("foo", "android_common").Output("turbine-combined/foo.jar") | 
|  | 764 | bazHeaderJar := ctx.ModuleForTests("baz", "android_common").Output("turbine-combined/baz.jar") | 
|  | 765 | barKotlinc := ctx.ModuleForTests("bar", "android_common").Rule("kotlinc") | 
| Colin Cross | 715d711 | 2017-10-25 20:32:18 -0700 | [diff] [blame] | 766 |  | 
| Colin Cross | 9bc4343 | 2017-12-15 20:20:39 -0800 | [diff] [blame] | 767 | if len(barKotlinc.Inputs) != 1 || barKotlinc.Inputs[0].String() != "b.kt" { | 
|  | 768 | t.Errorf(`bar kotlinc inputs %v != ["b.kt"]`, barKotlinc.Inputs) | 
|  | 769 | } | 
|  | 770 |  | 
|  | 771 | if !inList(fooHeaderJar.Output.String(), barKotlinc.Implicits.Strings()) { | 
|  | 772 | t.Errorf(`expected %q in bar implicits %v`, | 
|  | 773 | fooHeaderJar.Output.String(), barKotlinc.Implicits.Strings()) | 
|  | 774 | } | 
|  | 775 |  | 
|  | 776 | if !inList(bazHeaderJar.Output.String(), barKotlinc.Implicits.Strings()) { | 
|  | 777 | t.Errorf(`expected %q in bar implicits %v`, | 
|  | 778 | bazHeaderJar.Output.String(), barKotlinc.Implicits.Strings()) | 
| Colin Cross | 715d711 | 2017-10-25 20:32:18 -0700 | [diff] [blame] | 779 | } | 
| Colin Cross | 93e8595 | 2017-08-15 13:34:18 -0700 | [diff] [blame] | 780 | } | 
|  | 781 |  | 
| Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 782 | func TestTurbine(t *testing.T) { | 
|  | 783 | ctx := testJava(t, ` | 
|  | 784 | java_library { | 
|  | 785 | name: "foo", | 
|  | 786 | srcs: ["a.java"], | 
|  | 787 | } | 
|  | 788 |  | 
|  | 789 | java_library { | 
|  | 790 | name: "bar", | 
| Colin Cross | 9bc4343 | 2017-12-15 20:20:39 -0800 | [diff] [blame] | 791 | srcs: ["b.java"], | 
| Nan Zhang | 61eaedb | 2017-11-02 13:28:15 -0700 | [diff] [blame] | 792 | static_libs: ["foo"], | 
|  | 793 | } | 
|  | 794 |  | 
|  | 795 | java_library { | 
|  | 796 | name: "baz", | 
|  | 797 | srcs: ["c.java"], | 
|  | 798 | libs: ["bar"], | 
|  | 799 | sdk_version: "14", | 
|  | 800 | } | 
|  | 801 | `) | 
|  | 802 |  | 
|  | 803 | fooTurbine := ctx.ModuleForTests("foo", "android_common").Rule("turbine") | 
|  | 804 | barTurbine := ctx.ModuleForTests("bar", "android_common").Rule("turbine") | 
|  | 805 | barJavac := ctx.ModuleForTests("bar", "android_common").Rule("javac") | 
|  | 806 | barTurbineCombined := ctx.ModuleForTests("bar", "android_common").Description("for turbine") | 
|  | 807 | bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac") | 
|  | 808 |  | 
|  | 809 | if len(fooTurbine.Inputs) != 1 || fooTurbine.Inputs[0].String() != "a.java" { | 
|  | 810 | t.Errorf(`foo inputs %v != ["a.java"]`, fooTurbine.Inputs) | 
|  | 811 | } | 
|  | 812 |  | 
|  | 813 | fooHeaderJar := filepath.Join(buildDir, ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar") | 
|  | 814 | if !strings.Contains(barTurbine.Args["classpath"], fooHeaderJar) { | 
|  | 815 | t.Errorf("bar turbine classpath %v does not contain %q", barTurbine.Args["classpath"], fooHeaderJar) | 
|  | 816 | } | 
|  | 817 | if !strings.Contains(barJavac.Args["classpath"], fooHeaderJar) { | 
|  | 818 | t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], fooHeaderJar) | 
|  | 819 | } | 
|  | 820 | if len(barTurbineCombined.Inputs) != 2 || barTurbineCombined.Inputs[1].String() != fooHeaderJar { | 
|  | 821 | t.Errorf("bar turbine combineJar inputs %v does not contain %q", barTurbineCombined.Inputs, fooHeaderJar) | 
|  | 822 | } | 
|  | 823 | if !strings.Contains(bazJavac.Args["classpath"], "prebuilts/sdk/14/android.jar") { | 
|  | 824 | t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"], | 
|  | 825 | "prebuilts/sdk/14/android.jar") | 
|  | 826 | } | 
|  | 827 | } | 
|  | 828 |  | 
|  | 829 | func TestSharding(t *testing.T) { | 
|  | 830 | ctx := testJava(t, ` | 
|  | 831 | java_library { | 
|  | 832 | name: "bar", | 
|  | 833 | srcs: ["a.java","b.java","c.java"], | 
|  | 834 | javac_shard_size: 1 | 
|  | 835 | } | 
|  | 836 | `) | 
|  | 837 |  | 
|  | 838 | barHeaderJar := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar") | 
|  | 839 | for i := 0; i < 3; i++ { | 
|  | 840 | barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i)) | 
|  | 841 | if !strings.Contains(barJavac.Args["classpath"], barHeaderJar) { | 
|  | 842 | t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], barHeaderJar) | 
|  | 843 | } | 
|  | 844 | } | 
|  | 845 | } | 
|  | 846 |  | 
| Colin Cross | 5425090 | 2017-12-05 09:28:08 -0800 | [diff] [blame] | 847 | func TestJarGenrules(t *testing.T) { | 
|  | 848 | ctx := testJava(t, ` | 
|  | 849 | java_library { | 
|  | 850 | name: "foo", | 
|  | 851 | srcs: ["a.java"], | 
|  | 852 | } | 
|  | 853 |  | 
|  | 854 | java_genrule { | 
|  | 855 | name: "jargen", | 
|  | 856 | tool_files: ["b.java"], | 
|  | 857 | cmd: "$(location b.java) $(in) $(out)", | 
|  | 858 | out: ["jargen.jar"], | 
|  | 859 | srcs: [":foo"], | 
|  | 860 | } | 
|  | 861 |  | 
|  | 862 | java_library { | 
|  | 863 | name: "bar", | 
|  | 864 | static_libs: ["jargen"], | 
|  | 865 | srcs: ["c.java"], | 
|  | 866 | } | 
|  | 867 |  | 
|  | 868 | java_library { | 
|  | 869 | name: "baz", | 
|  | 870 | libs: ["jargen"], | 
|  | 871 | srcs: ["c.java"], | 
|  | 872 | } | 
|  | 873 | `) | 
|  | 874 |  | 
|  | 875 | foo := ctx.ModuleForTests("foo", "android_common").Output("javac/foo.jar") | 
|  | 876 | jargen := ctx.ModuleForTests("jargen", "android_common").Output("jargen.jar") | 
|  | 877 | bar := ctx.ModuleForTests("bar", "android_common").Output("javac/bar.jar") | 
|  | 878 | baz := ctx.ModuleForTests("baz", "android_common").Output("javac/baz.jar") | 
|  | 879 | barCombined := ctx.ModuleForTests("bar", "android_common").Output("combined/bar.jar") | 
|  | 880 |  | 
|  | 881 | if len(jargen.Inputs) != 1 || jargen.Inputs[0].String() != foo.Output.String() { | 
|  | 882 | t.Errorf("expected jargen inputs [%q], got %q", foo.Output.String(), jargen.Inputs.Strings()) | 
|  | 883 | } | 
|  | 884 |  | 
|  | 885 | if !strings.Contains(bar.Args["classpath"], jargen.Output.String()) { | 
|  | 886 | t.Errorf("bar classpath %v does not contain %q", bar.Args["classpath"], jargen.Output.String()) | 
|  | 887 | } | 
|  | 888 |  | 
|  | 889 | if !strings.Contains(baz.Args["classpath"], jargen.Output.String()) { | 
|  | 890 | t.Errorf("baz classpath %v does not contain %q", baz.Args["classpath"], jargen.Output.String()) | 
|  | 891 | } | 
|  | 892 |  | 
|  | 893 | if len(barCombined.Inputs) != 2 || | 
|  | 894 | barCombined.Inputs[0].String() != bar.Output.String() || | 
|  | 895 | barCombined.Inputs[1].String() != jargen.Output.String() { | 
|  | 896 | t.Errorf("bar combined jar inputs %v is not [%q, %q]", | 
|  | 897 | barCombined.Inputs.Strings(), bar.Output.String(), jargen.Output.String()) | 
|  | 898 | } | 
|  | 899 | } | 
|  | 900 |  | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 901 | func fail(t *testing.T, errs []error) { | 
| Colin Cross | 6b4a32d | 2017-12-05 13:42:45 -0800 | [diff] [blame] | 902 | t.Helper() | 
| Colin Cross | 72bb363 | 2017-07-13 16:23:21 -0700 | [diff] [blame] | 903 | if len(errs) > 0 { | 
|  | 904 | for _, err := range errs { | 
|  | 905 | t.Error(err) | 
|  | 906 | } | 
|  | 907 | t.FailNow() | 
|  | 908 | } | 
|  | 909 | } |