blob: bd6c1bae68f34fd8e3851940b925bd57956c630e [file] [log] [blame]
Colin Cross014489c2020-06-02 20:09:13 -07001// Copyright 2020 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
18 "fmt"
19 "sort"
Colin Cross988dfcc2020-07-16 17:32:17 -070020 "strings"
Colin Cross014489c2020-06-02 20:09:13 -070021
Pedro Loureiro5d190cc2021-02-15 15:41:33 +000022 "github.com/google/blueprint/proptools"
23
Colin Cross014489c2020-06-02 20:09:13 -070024 "android/soong/android"
Colin Cross31972dc2021-03-04 10:44:12 -080025 "android/soong/java/config"
26 "android/soong/remoteexec"
Colin Cross014489c2020-06-02 20:09:13 -070027)
28
Jaewoong Jung79e6f6b2021-04-21 14:01:55 -070029// lint checks automatically enforced for modules that have different min_sdk_version than
30// sdk_version
31var updatabilityChecks = []string{"NewApi"}
32
Colin Cross014489c2020-06-02 20:09:13 -070033type LintProperties struct {
34 // Controls for running Android Lint on the module.
35 Lint struct {
36
37 // If true, run Android Lint on the module. Defaults to true.
38 Enabled *bool
39
40 // Flags to pass to the Android Lint tool.
41 Flags []string
42
43 // Checks that should be treated as fatal.
44 Fatal_checks []string
45
46 // Checks that should be treated as errors.
47 Error_checks []string
48
49 // Checks that should be treated as warnings.
50 Warning_checks []string
51
52 // Checks that should be skipped.
53 Disabled_checks []string
Colin Cross92e4b462020-06-18 15:56:48 -070054
55 // Modules that provide extra lint checks
56 Extra_check_modules []string
Pedro Loureiro5d190cc2021-02-15 15:41:33 +000057
Cole Faustb765d6b2024-01-04 10:29:27 -080058 // The lint baseline file to use. If specified, lint warnings listed in this file will be
59 // suppressed during lint checks.
Pedro Loureiro5d190cc2021-02-15 15:41:33 +000060 Baseline_filename *string
Jaewoong Jung48de8832021-04-21 16:17:25 -070061
62 // If true, baselining updatability lint checks (e.g. NewApi) is prohibited. Defaults to false.
63 Strict_updatability_linting *bool
Cole Faustd57e8b22022-08-11 11:59:04 -070064
65 // Treat the code in this module as test code for @VisibleForTesting enforcement.
66 // This will be true by default for test module types, false otherwise.
67 // If soong gets support for testonly, this flag should be replaced with that.
68 Test *bool
ThiƩbaud Weksteen9c0dff92023-09-29 10:21:56 +100069
70 // Whether to ignore the exit code of Android lint. This is the --exit_code
71 // option. Defaults to false.
72 Suppress_exit_code *bool
Colin Cross014489c2020-06-02 20:09:13 -070073 }
74}
75
76type linter struct {
Pedro Loureirof4a88b12021-02-25 16:23:22 +000077 name string
78 manifest android.Path
79 mergedManifest android.Path
80 srcs android.Paths
81 srcJars android.Paths
82 resources android.Paths
83 classpath android.Paths
84 classes android.Path
85 extraLintCheckJars android.Paths
Pedro Loureirof4a88b12021-02-25 16:23:22 +000086 library bool
Zi Wange1166f02023-11-06 11:43:17 -080087 minSdkVersion android.ApiLevel
88 targetSdkVersion android.ApiLevel
89 compileSdkVersion android.ApiLevel
Pedro Loureiro18233a22021-06-08 18:11:21 +000090 compileSdkKind android.SdkKind
Pedro Loureirof4a88b12021-02-25 16:23:22 +000091 javaLanguageLevel string
92 kotlinLanguageLevel string
93 outputs lintOutputs
94 properties LintProperties
95 extraMainlineLintErrors []string
Cole Faustdf1efd72023-12-08 12:27:24 -080096 compile_data android.Paths
Colin Crossc0efd1d2020-07-03 11:56:24 -070097
Colin Cross08dca382020-07-21 20:31:17 -070098 reports android.Paths
99
Colin Crossc0efd1d2020-07-03 11:56:24 -0700100 buildModuleReportZip bool
Colin Cross014489c2020-06-02 20:09:13 -0700101}
102
103type lintOutputs struct {
Cole Faustdf38f7a2023-03-02 16:43:15 -0800104 html android.Path
105 text android.Path
106 xml android.Path
107 referenceBaseline android.Path
Colin Crossc0efd1d2020-07-03 11:56:24 -0700108
Colin Cross08dca382020-07-21 20:31:17 -0700109 depSets LintDepSets
Colin Crossc0efd1d2020-07-03 11:56:24 -0700110}
111
Colin Cross08dca382020-07-21 20:31:17 -0700112type lintOutputsIntf interface {
Colin Crossc0efd1d2020-07-03 11:56:24 -0700113 lintOutputs() *lintOutputs
114}
115
Spandan Das17854f52022-01-14 21:19:14 +0000116type LintDepSetsIntf interface {
Colin Cross08dca382020-07-21 20:31:17 -0700117 LintDepSets() LintDepSets
Jaewoong Jung476b9d62021-05-10 15:30:00 -0700118
119 // Methods used to propagate strict_updatability_linting values.
Spandan Das17854f52022-01-14 21:19:14 +0000120 GetStrictUpdatabilityLinting() bool
121 SetStrictUpdatabilityLinting(bool)
Colin Cross08dca382020-07-21 20:31:17 -0700122}
123
124type LintDepSets struct {
Colin Crossc85750b2022-04-21 12:50:51 -0700125 HTML, Text, XML *android.DepSet[android.Path]
Colin Cross08dca382020-07-21 20:31:17 -0700126}
127
128type LintDepSetsBuilder struct {
Colin Crossc85750b2022-04-21 12:50:51 -0700129 HTML, Text, XML *android.DepSetBuilder[android.Path]
Colin Cross08dca382020-07-21 20:31:17 -0700130}
131
132func NewLintDepSetBuilder() LintDepSetsBuilder {
133 return LintDepSetsBuilder{
Colin Crossc85750b2022-04-21 12:50:51 -0700134 HTML: android.NewDepSetBuilder[android.Path](android.POSTORDER),
135 Text: android.NewDepSetBuilder[android.Path](android.POSTORDER),
136 XML: android.NewDepSetBuilder[android.Path](android.POSTORDER),
Colin Cross08dca382020-07-21 20:31:17 -0700137 }
138}
139
140func (l LintDepSetsBuilder) Direct(html, text, xml android.Path) LintDepSetsBuilder {
141 l.HTML.Direct(html)
142 l.Text.Direct(text)
143 l.XML.Direct(xml)
144 return l
145}
146
147func (l LintDepSetsBuilder) Transitive(depSets LintDepSets) LintDepSetsBuilder {
148 if depSets.HTML != nil {
149 l.HTML.Transitive(depSets.HTML)
150 }
151 if depSets.Text != nil {
152 l.Text.Transitive(depSets.Text)
153 }
154 if depSets.XML != nil {
155 l.XML.Transitive(depSets.XML)
156 }
157 return l
158}
159
160func (l LintDepSetsBuilder) Build() LintDepSets {
161 return LintDepSets{
162 HTML: l.HTML.Build(),
163 Text: l.Text.Build(),
164 XML: l.XML.Build(),
165 }
166}
167
Cole Faust69861aa2023-01-31 15:49:07 -0800168type lintDatabaseFiles struct {
169 apiVersionsModule string
170 apiVersionsCopiedName string
171 apiVersionsPrebuiltPath string
172 annotationsModule string
173 annotationCopiedName string
174 annotationPrebuiltpath string
175}
176
177var allLintDatabasefiles = map[android.SdkKind]lintDatabaseFiles{
178 android.SdkPublic: {
179 apiVersionsModule: "api_versions_public",
180 apiVersionsCopiedName: "api_versions_public.xml",
181 apiVersionsPrebuiltPath: "prebuilts/sdk/current/public/data/api-versions.xml",
182 annotationsModule: "sdk-annotations.zip",
183 annotationCopiedName: "annotations-public.zip",
184 annotationPrebuiltpath: "prebuilts/sdk/current/public/data/annotations.zip",
185 },
186 android.SdkSystem: {
187 apiVersionsModule: "api_versions_system",
188 apiVersionsCopiedName: "api_versions_system.xml",
189 apiVersionsPrebuiltPath: "prebuilts/sdk/current/system/data/api-versions.xml",
190 annotationsModule: "sdk-annotations-system.zip",
191 annotationCopiedName: "annotations-system.zip",
192 annotationPrebuiltpath: "prebuilts/sdk/current/system/data/annotations.zip",
193 },
194 android.SdkModule: {
195 apiVersionsModule: "api_versions_module_lib",
196 apiVersionsCopiedName: "api_versions_module_lib.xml",
197 apiVersionsPrebuiltPath: "prebuilts/sdk/current/module-lib/data/api-versions.xml",
198 annotationsModule: "sdk-annotations-module-lib.zip",
199 annotationCopiedName: "annotations-module-lib.zip",
200 annotationPrebuiltpath: "prebuilts/sdk/current/module-lib/data/annotations.zip",
201 },
202 android.SdkSystemServer: {
203 apiVersionsModule: "api_versions_system_server",
204 apiVersionsCopiedName: "api_versions_system_server.xml",
205 apiVersionsPrebuiltPath: "prebuilts/sdk/current/system-server/data/api-versions.xml",
206 annotationsModule: "sdk-annotations-system-server.zip",
207 annotationCopiedName: "annotations-system-server.zip",
208 annotationPrebuiltpath: "prebuilts/sdk/current/system-server/data/annotations.zip",
209 },
210}
211
Colin Cross08dca382020-07-21 20:31:17 -0700212func (l *linter) LintDepSets() LintDepSets {
213 return l.outputs.depSets
214}
215
Spandan Das17854f52022-01-14 21:19:14 +0000216func (l *linter) GetStrictUpdatabilityLinting() bool {
Jaewoong Jung476b9d62021-05-10 15:30:00 -0700217 return BoolDefault(l.properties.Lint.Strict_updatability_linting, false)
218}
219
Spandan Das17854f52022-01-14 21:19:14 +0000220func (l *linter) SetStrictUpdatabilityLinting(strictLinting bool) {
Jaewoong Jung476b9d62021-05-10 15:30:00 -0700221 l.properties.Lint.Strict_updatability_linting = &strictLinting
222}
223
Spandan Das17854f52022-01-14 21:19:14 +0000224var _ LintDepSetsIntf = (*linter)(nil)
Colin Cross08dca382020-07-21 20:31:17 -0700225
226var _ lintOutputsIntf = (*linter)(nil)
Colin Crossc0efd1d2020-07-03 11:56:24 -0700227
228func (l *linter) lintOutputs() *lintOutputs {
229 return &l.outputs
Colin Cross014489c2020-06-02 20:09:13 -0700230}
231
232func (l *linter) enabled() bool {
233 return BoolDefault(l.properties.Lint.Enabled, true)
234}
235
Colin Cross92e4b462020-06-18 15:56:48 -0700236func (l *linter) deps(ctx android.BottomUpMutatorContext) {
237 if !l.enabled() {
238 return
239 }
240
Colin Cross988dfcc2020-07-16 17:32:17 -0700241 extraCheckModules := l.properties.Lint.Extra_check_modules
242
mattgilbridee17645f2022-11-18 18:20:20 +0000243 if extraCheckModulesEnv := ctx.Config().Getenv("ANDROID_LINT_CHECK_EXTRA_MODULES"); extraCheckModulesEnv != "" {
244 extraCheckModules = append(extraCheckModules, strings.Split(extraCheckModulesEnv, ",")...)
Colin Cross988dfcc2020-07-16 17:32:17 -0700245 }
246
247 ctx.AddFarVariationDependencies(ctx.Config().BuildOSCommonTarget.Variations(),
248 extraLintCheckTag, extraCheckModules...)
Colin Cross92e4b462020-06-18 15:56:48 -0700249}
250
Colin Crossad22bc22021-03-10 09:45:40 -0800251// lintPaths contains the paths to lint's inputs and outputs to make it easier to pass them
252// around.
Colin Cross31972dc2021-03-04 10:44:12 -0800253type lintPaths struct {
254 projectXML android.WritablePath
255 configXML android.WritablePath
256 cacheDir android.WritablePath
257 homeDir android.WritablePath
258 srcjarDir android.WritablePath
Colin Cross31972dc2021-03-04 10:44:12 -0800259}
260
Colin Cross9b93af42021-03-10 10:40:58 -0800261func lintRBEExecStrategy(ctx android.ModuleContext) string {
262 return ctx.Config().GetenvWithDefault("RBE_LINT_EXEC_STRATEGY", remoteexec.LocalExecStrategy)
263}
264
Colin Cross62695b92022-08-12 16:09:24 -0700265func (l *linter) writeLintProjectXML(ctx android.ModuleContext, rule *android.RuleBuilder, srcsList android.Path) lintPaths {
Colin Cross31972dc2021-03-04 10:44:12 -0800266 projectXMLPath := android.PathForModuleOut(ctx, "lint", "project.xml")
Colin Cross014489c2020-06-02 20:09:13 -0700267 // Lint looks for a lint.xml file next to the project.xml file, give it one.
Colin Cross31972dc2021-03-04 10:44:12 -0800268 configXMLPath := android.PathForModuleOut(ctx, "lint", "lint.xml")
269 cacheDir := android.PathForModuleOut(ctx, "lint", "cache")
270 homeDir := android.PathForModuleOut(ctx, "lint", "home")
Colin Cross014489c2020-06-02 20:09:13 -0700271
Colin Cross1661aff2021-03-12 17:56:51 -0800272 srcJarDir := android.PathForModuleOut(ctx, "lint", "srcjars")
Colin Cross014489c2020-06-02 20:09:13 -0700273 srcJarList := zipSyncCmd(ctx, rule, srcJarDir, l.srcJars)
274
275 cmd := rule.Command().
Jaewoong Jung5a420252021-04-19 17:58:22 -0700276 BuiltTool("lint_project_xml").
Colin Cross014489c2020-06-02 20:09:13 -0700277 FlagWithOutput("--project_out ", projectXMLPath).
278 FlagWithOutput("--config_out ", configXMLPath).
279 FlagWithArg("--name ", ctx.ModuleName())
280
281 if l.library {
282 cmd.Flag("--library")
283 }
Cole Faustd57e8b22022-08-11 11:59:04 -0700284 if proptools.BoolDefault(l.properties.Lint.Test, false) {
Colin Cross014489c2020-06-02 20:09:13 -0700285 cmd.Flag("--test")
286 }
287 if l.manifest != nil {
Colin Cross5bedfa22021-03-23 17:07:14 -0700288 cmd.FlagWithInput("--manifest ", l.manifest)
Colin Cross014489c2020-06-02 20:09:13 -0700289 }
290 if l.mergedManifest != nil {
Colin Cross5bedfa22021-03-23 17:07:14 -0700291 cmd.FlagWithInput("--merged_manifest ", l.mergedManifest)
Colin Cross014489c2020-06-02 20:09:13 -0700292 }
293
Colin Cross5bedfa22021-03-23 17:07:14 -0700294 // TODO(ccross): some of the files in l.srcs are generated sources and should be passed to
295 // lint separately.
Colin Cross62695b92022-08-12 16:09:24 -0700296 cmd.FlagWithInput("--srcs ", srcsList)
Colin Cross014489c2020-06-02 20:09:13 -0700297
298 cmd.FlagWithInput("--generated_srcs ", srcJarList)
Colin Cross014489c2020-06-02 20:09:13 -0700299
Colin Cross5bedfa22021-03-23 17:07:14 -0700300 if len(l.resources) > 0 {
301 resourcesList := android.PathForModuleOut(ctx, "lint-resources.list")
302 cmd.FlagWithRspFileInputList("--resources ", resourcesList, l.resources)
Colin Cross014489c2020-06-02 20:09:13 -0700303 }
304
305 if l.classes != nil {
Colin Cross5bedfa22021-03-23 17:07:14 -0700306 cmd.FlagWithInput("--classes ", l.classes)
Colin Cross014489c2020-06-02 20:09:13 -0700307 }
308
Colin Cross5bedfa22021-03-23 17:07:14 -0700309 cmd.FlagForEachInput("--classpath ", l.classpath)
Colin Cross014489c2020-06-02 20:09:13 -0700310
Colin Cross5bedfa22021-03-23 17:07:14 -0700311 cmd.FlagForEachInput("--extra_checks_jar ", l.extraLintCheckJars)
Colin Cross014489c2020-06-02 20:09:13 -0700312
Colin Cross1661aff2021-03-12 17:56:51 -0800313 cmd.FlagWithArg("--root_dir ", "$PWD")
Colin Crossc31efeb2020-06-23 10:25:26 -0700314
315 // The cache tag in project.xml is relative to the root dir, or the project.xml file if
316 // the root dir is not set.
317 cmd.FlagWithArg("--cache_dir ", cacheDir.String())
Colin Cross014489c2020-06-02 20:09:13 -0700318
319 cmd.FlagWithInput("@",
320 android.PathForSource(ctx, "build/soong/java/lint_defaults.txt"))
321
Cole Faust028b94c2024-01-16 17:17:11 -0800322 cmd.FlagForEachArg("--error_check ", l.extraMainlineLintErrors)
Colin Cross014489c2020-06-02 20:09:13 -0700323 cmd.FlagForEachArg("--disable_check ", l.properties.Lint.Disabled_checks)
324 cmd.FlagForEachArg("--warning_check ", l.properties.Lint.Warning_checks)
325 cmd.FlagForEachArg("--error_check ", l.properties.Lint.Error_checks)
326 cmd.FlagForEachArg("--fatal_check ", l.properties.Lint.Fatal_checks)
327
Cole Faust24e25c02024-01-19 14:12:17 -0800328 if l.GetStrictUpdatabilityLinting() {
329 // Verify the module does not baseline issues that endanger safe updatability.
330 if l.properties.Lint.Baseline_filename != nil {
331 cmd.FlagWithInput("--baseline ", android.PathForModuleSrc(ctx, *l.properties.Lint.Baseline_filename))
332 cmd.FlagForEachArg("--disallowed_issues ", updatabilityChecks)
333 }
334 }
Jaewoong Jung48de8832021-04-21 16:17:25 -0700335
Colin Cross31972dc2021-03-04 10:44:12 -0800336 return lintPaths{
337 projectXML: projectXMLPath,
338 configXML: configXMLPath,
339 cacheDir: cacheDir,
340 homeDir: homeDir,
Colin Cross31972dc2021-03-04 10:44:12 -0800341 }
342
Colin Cross014489c2020-06-02 20:09:13 -0700343}
344
Liz Kammer20ebfb42020-07-28 11:32:07 -0700345// generateManifest adds a command to the rule to write a simple manifest that contains the
Colin Cross014489c2020-06-02 20:09:13 -0700346// minSdkVersion and targetSdkVersion for modules (like java_library) that don't have a manifest.
Colin Cross1661aff2021-03-12 17:56:51 -0800347func (l *linter) generateManifest(ctx android.ModuleContext, rule *android.RuleBuilder) android.WritablePath {
Colin Cross014489c2020-06-02 20:09:13 -0700348 manifestPath := android.PathForModuleOut(ctx, "lint", "AndroidManifest.xml")
349
350 rule.Command().Text("(").
351 Text(`echo "<?xml version='1.0' encoding='utf-8'?>" &&`).
352 Text(`echo "<manifest xmlns:android='http://schemas.android.com/apk/res/android'" &&`).
353 Text(`echo " android:versionCode='1' android:versionName='1' >" &&`).
Zi Wange1166f02023-11-06 11:43:17 -0800354 Textf(`echo " <uses-sdk android:minSdkVersion='%s' android:targetSdkVersion='%s'/>" &&`,
355 l.minSdkVersion.String(), l.targetSdkVersion.String()).
Colin Cross014489c2020-06-02 20:09:13 -0700356 Text(`echo "</manifest>"`).
357 Text(") >").Output(manifestPath)
358
359 return manifestPath
360}
361
362func (l *linter) lint(ctx android.ModuleContext) {
363 if !l.enabled() {
364 return
365 }
366
Zi Wange1166f02023-11-06 11:43:17 -0800367 if l.minSdkVersion.CompareTo(l.compileSdkVersion) == -1 {
Jaewoong Jung79e6f6b2021-04-21 14:01:55 -0700368 l.extraMainlineLintErrors = append(l.extraMainlineLintErrors, updatabilityChecks...)
Orion Hodsonb8166522022-08-15 20:23:38 +0100369 // Skip lint warning checks for NewApi warnings for libcore where they come from source
370 // files that reference the API they are adding (b/208656169).
Orion Hodsonb2d3c8c2022-10-25 16:45:14 +0100371 if !strings.HasPrefix(ctx.ModuleDir(), "libcore") {
Orion Hodsonb8166522022-08-15 20:23:38 +0100372 _, filtered := android.FilterList(l.properties.Lint.Warning_checks, updatabilityChecks)
373
374 if len(filtered) != 0 {
375 ctx.PropertyErrorf("lint.warning_checks",
376 "Can't treat %v checks as warnings if min_sdk_version is different from sdk_version.", filtered)
377 }
Jaewoong Jung79e6f6b2021-04-21 14:01:55 -0700378 }
Orion Hodsonb8166522022-08-15 20:23:38 +0100379
380 _, filtered := android.FilterList(l.properties.Lint.Disabled_checks, updatabilityChecks)
Jaewoong Jung79e6f6b2021-04-21 14:01:55 -0700381 if len(filtered) != 0 {
382 ctx.PropertyErrorf("lint.disabled_checks",
383 "Can't disable %v checks if min_sdk_version is different from sdk_version.", filtered)
384 }
Cole Faust3f646262022-06-29 14:58:03 -0700385
386 // TODO(b/238784089): Remove this workaround when the NewApi issues have been addressed in PermissionController
387 if ctx.ModuleName() == "PermissionController" {
388 l.extraMainlineLintErrors = android.FilterListPred(l.extraMainlineLintErrors, func(s string) bool {
389 return s != "NewApi"
390 })
391 l.properties.Lint.Warning_checks = append(l.properties.Lint.Warning_checks, "NewApi")
392 }
Pedro Loureirof4a88b12021-02-25 16:23:22 +0000393 }
394
Colin Cross92e4b462020-06-18 15:56:48 -0700395 extraLintCheckModules := ctx.GetDirectDepsWithTag(extraLintCheckTag)
396 for _, extraLintCheckModule := range extraLintCheckModules {
Colin Cross313aa542023-12-13 13:47:44 -0800397 if dep, ok := android.OtherModuleProvider(ctx, extraLintCheckModule, JavaInfoProvider); ok {
Colin Crossdcf71b22021-02-01 13:59:03 -0800398 l.extraLintCheckJars = append(l.extraLintCheckJars, dep.ImplementationAndResourcesJars...)
Colin Cross92e4b462020-06-18 15:56:48 -0700399 } else {
400 ctx.PropertyErrorf("lint.extra_check_modules",
401 "%s is not a java module", ctx.OtherModuleName(extraLintCheckModule))
402 }
403 }
404
mattgilbride5aecabe2022-11-29 20:16:36 +0000405 l.extraLintCheckJars = append(l.extraLintCheckJars, android.PathForSource(ctx,
406 "prebuilts/cmdline-tools/AndroidGlobalLintChecker.jar"))
407
Colin Cross1661aff2021-03-12 17:56:51 -0800408 rule := android.NewRuleBuilder(pctx, ctx).
409 Sbox(android.PathForModuleOut(ctx, "lint"),
410 android.PathForModuleOut(ctx, "lint.sbox.textproto")).
411 SandboxInputs()
412
413 if ctx.Config().UseRBE() && ctx.Config().IsEnvTrue("RBE_LINT") {
414 pool := ctx.Config().GetenvWithDefault("RBE_LINT_POOL", "java16")
415 rule.Remoteable(android.RemoteRuleSupports{RBE: true})
416 rule.Rewrapper(&remoteexec.REParams{
417 Labels: map[string]string{"type": "tool", "name": "lint"},
418 ExecStrategy: lintRBEExecStrategy(ctx),
419 ToolchainInputs: []string{config.JavaCmd(ctx).String()},
Colin Cross95fad7a2021-06-09 12:48:53 -0700420 Platform: map[string]string{remoteexec.PoolKey: pool},
Colin Cross1661aff2021-03-12 17:56:51 -0800421 })
422 }
Colin Cross014489c2020-06-02 20:09:13 -0700423
424 if l.manifest == nil {
425 manifest := l.generateManifest(ctx, rule)
426 l.manifest = manifest
Colin Cross1661aff2021-03-12 17:56:51 -0800427 rule.Temporary(manifest)
Colin Cross014489c2020-06-02 20:09:13 -0700428 }
429
Colin Cross62695b92022-08-12 16:09:24 -0700430 srcsList := android.PathForModuleOut(ctx, "lint", "lint-srcs.list")
431 srcsListRsp := android.PathForModuleOut(ctx, "lint-srcs.list.rsp")
Cole Faustdf1efd72023-12-08 12:27:24 -0800432 rule.Command().Text("cp").FlagWithRspFileInputList("", srcsListRsp, l.srcs).Output(srcsList).Implicits(l.compile_data)
Colin Cross62695b92022-08-12 16:09:24 -0700433
434 lintPaths := l.writeLintProjectXML(ctx, rule, srcsList)
Colin Cross014489c2020-06-02 20:09:13 -0700435
Colin Cross1661aff2021-03-12 17:56:51 -0800436 html := android.PathForModuleOut(ctx, "lint", "lint-report.html")
437 text := android.PathForModuleOut(ctx, "lint", "lint-report.txt")
438 xml := android.PathForModuleOut(ctx, "lint", "lint-report.xml")
Cole Faustdf38f7a2023-03-02 16:43:15 -0800439 referenceBaseline := android.PathForModuleOut(ctx, "lint", "lint-baseline.xml")
Colin Crossc0efd1d2020-07-03 11:56:24 -0700440
Colin Cross08dca382020-07-21 20:31:17 -0700441 depSetsBuilder := NewLintDepSetBuilder().Direct(html, text, xml)
Colin Crossc0efd1d2020-07-03 11:56:24 -0700442
443 ctx.VisitDirectDepsWithTag(staticLibTag, func(dep android.Module) {
Spandan Das17854f52022-01-14 21:19:14 +0000444 if depLint, ok := dep.(LintDepSetsIntf); ok {
Colin Cross08dca382020-07-21 20:31:17 -0700445 depSetsBuilder.Transitive(depLint.LintDepSets())
Colin Crossc0efd1d2020-07-03 11:56:24 -0700446 }
447 })
Colin Cross014489c2020-06-02 20:09:13 -0700448
Colin Cross31972dc2021-03-04 10:44:12 -0800449 rule.Command().Text("rm -rf").Flag(lintPaths.cacheDir.String()).Flag(lintPaths.homeDir.String())
450 rule.Command().Text("mkdir -p").Flag(lintPaths.cacheDir.String()).Flag(lintPaths.homeDir.String())
Colin Cross5c113d12021-03-04 10:01:34 -0800451 rule.Command().Text("rm -f").Output(html).Output(text).Output(xml)
Colin Cross014489c2020-06-02 20:09:13 -0700452
Cole Faust69861aa2023-01-31 15:49:07 -0800453 files, ok := allLintDatabasefiles[l.compileSdkKind]
454 if !ok {
455 files = allLintDatabasefiles[android.SdkPublic]
Pedro Loureiro18233a22021-06-08 18:11:21 +0000456 }
Colin Cross8a6ed372020-07-06 11:45:51 -0700457 var annotationsZipPath, apiVersionsXMLPath android.Path
Jeongik Cha816a23a2020-07-08 01:09:23 +0900458 if ctx.Config().AlwaysUsePrebuiltSdks() {
Cole Faust69861aa2023-01-31 15:49:07 -0800459 annotationsZipPath = android.PathForSource(ctx, files.annotationPrebuiltpath)
460 apiVersionsXMLPath = android.PathForSource(ctx, files.apiVersionsPrebuiltPath)
Colin Cross8a6ed372020-07-06 11:45:51 -0700461 } else {
Cole Faust69861aa2023-01-31 15:49:07 -0800462 annotationsZipPath = copiedLintDatabaseFilesPath(ctx, files.annotationCopiedName)
463 apiVersionsXMLPath = copiedLintDatabaseFilesPath(ctx, files.apiVersionsCopiedName)
Colin Cross8a6ed372020-07-06 11:45:51 -0700464 }
465
Colin Cross31972dc2021-03-04 10:44:12 -0800466 cmd := rule.Command()
467
Pedro Loureiro70acc3d2021-04-06 17:49:19 +0000468 cmd.Flag(`JAVA_OPTS="-Xmx3072m --add-opens java.base/java.util=ALL-UNNAMED"`).
Colin Cross31972dc2021-03-04 10:44:12 -0800469 FlagWithArg("ANDROID_SDK_HOME=", lintPaths.homeDir.String()).
Colin Cross8a6ed372020-07-06 11:45:51 -0700470 FlagWithInput("SDK_ANNOTATIONS=", annotationsZipPath).
Colin Cross31972dc2021-03-04 10:44:12 -0800471 FlagWithInput("LINT_OPTS=-DLINT_API_DATABASE=", apiVersionsXMLPath)
472
Colin Cross1661aff2021-03-12 17:56:51 -0800473 cmd.BuiltTool("lint").ImplicitTool(ctx.Config().HostJavaToolPath(ctx, "lint.jar")).
Colin Cross014489c2020-06-02 20:09:13 -0700474 Flag("--quiet").
Tor Norbyecabafde2023-12-07 21:57:28 +0000475 Flag("--include-aosp-issues").
Colin Cross31972dc2021-03-04 10:44:12 -0800476 FlagWithInput("--project ", lintPaths.projectXML).
477 FlagWithInput("--config ", lintPaths.configXML).
Colin Crossc0efd1d2020-07-03 11:56:24 -0700478 FlagWithOutput("--html ", html).
479 FlagWithOutput("--text ", text).
480 FlagWithOutput("--xml ", xml).
Zi Wange1166f02023-11-06 11:43:17 -0800481 FlagWithArg("--compile-sdk-version ", l.compileSdkVersion.String()).
Colin Cross014489c2020-06-02 20:09:13 -0700482 FlagWithArg("--java-language-level ", l.javaLanguageLevel).
483 FlagWithArg("--kotlin-language-level ", l.kotlinLanguageLevel).
484 FlagWithArg("--url ", fmt.Sprintf(".=.,%s=out", android.PathForOutput(ctx).String())).
Colin Cross62695b92022-08-12 16:09:24 -0700485 Flag("--apply-suggestions"). // applies suggested fixes to files in the sandbox
Colin Cross014489c2020-06-02 20:09:13 -0700486 Flags(l.properties.Lint.Flags).
Colin Cross31972dc2021-03-04 10:44:12 -0800487 Implicit(annotationsZipPath).
Colin Cross5bedfa22021-03-23 17:07:14 -0700488 Implicit(apiVersionsXMLPath)
Colin Cross988dfcc2020-07-16 17:32:17 -0700489
Colin Cross1661aff2021-03-12 17:56:51 -0800490 rule.Temporary(lintPaths.projectXML)
491 rule.Temporary(lintPaths.configXML)
492
ThiƩbaud Weksteen9c0dff92023-09-29 10:21:56 +1000493 suppressExitCode := BoolDefault(l.properties.Lint.Suppress_exit_code, false)
494 if exitCode := ctx.Config().Getenv("ANDROID_LINT_SUPPRESS_EXIT_CODE"); exitCode == "" && !suppressExitCode {
mattgilbrideb597abd2023-03-22 17:44:18 +0000495 cmd.Flag("--exitcode")
496 }
497
Colin Cross988dfcc2020-07-16 17:32:17 -0700498 if checkOnly := ctx.Config().Getenv("ANDROID_LINT_CHECK"); checkOnly != "" {
499 cmd.FlagWithArg("--check ", checkOnly)
500 }
501
Cole Faustb765d6b2024-01-04 10:29:27 -0800502 if l.properties.Lint.Baseline_filename != nil {
503 cmd.FlagWithInput("--baseline ", android.PathForModuleSrc(ctx, *l.properties.Lint.Baseline_filename))
Pedro Loureiro5d190cc2021-02-15 15:41:33 +0000504 }
505
Cole Faustdf38f7a2023-03-02 16:43:15 -0800506 cmd.FlagWithOutput("--write-reference-baseline ", referenceBaseline)
Colin Cross6b76c152021-09-09 09:36:25 -0700507
Colin Cross1b9e6832022-10-11 11:22:24 -0700508 cmd.Text("; EXITCODE=$?; ")
509
510 // The sources in the sandbox may have been modified by --apply-suggestions, zip them up and
511 // export them out of the sandbox. Do this before exiting so that the suggestions exit even after
512 // a fatal error.
513 cmd.BuiltTool("soong_zip").
514 FlagWithOutput("-o ", android.PathForModuleOut(ctx, "lint", "suggested-fixes.zip")).
515 FlagWithArg("-C ", cmd.PathForInput(android.PathForSource(ctx))).
516 FlagWithInput("-r ", srcsList)
517
518 cmd.Text("; if [ $EXITCODE != 0 ]; then if [ -e").Input(text).Text("]; then cat").Input(text).Text("; fi; exit $EXITCODE; fi")
Colin Cross014489c2020-06-02 20:09:13 -0700519
Colin Cross31972dc2021-03-04 10:44:12 -0800520 rule.Command().Text("rm -rf").Flag(lintPaths.cacheDir.String()).Flag(lintPaths.homeDir.String())
Colin Cross014489c2020-06-02 20:09:13 -0700521
Colin Crossee4a8b72021-04-05 18:38:05 -0700522 // The HTML output contains a date, remove it to make the output deterministic.
523 rule.Command().Text(`sed -i.tmp -e 's|Check performed at .*\(</nav>\)|\1|'`).Output(html)
524
Colin Crossf1a035e2020-11-16 17:32:30 -0800525 rule.Build("lint", "lint")
Colin Cross014489c2020-06-02 20:09:13 -0700526
Colin Crossc0efd1d2020-07-03 11:56:24 -0700527 l.outputs = lintOutputs{
Cole Faustdf38f7a2023-03-02 16:43:15 -0800528 html: html,
529 text: text,
530 xml: xml,
531 referenceBaseline: referenceBaseline,
Colin Cross014489c2020-06-02 20:09:13 -0700532
Colin Cross08dca382020-07-21 20:31:17 -0700533 depSets: depSetsBuilder.Build(),
Colin Crossc0efd1d2020-07-03 11:56:24 -0700534 }
Colin Cross014489c2020-06-02 20:09:13 -0700535
Colin Crossc0efd1d2020-07-03 11:56:24 -0700536 if l.buildModuleReportZip {
Colin Cross08dca382020-07-21 20:31:17 -0700537 l.reports = BuildModuleLintReportZips(ctx, l.LintDepSets())
Colin Crossc0efd1d2020-07-03 11:56:24 -0700538 }
Colin Crossb9176412024-01-05 12:51:25 -0800539
540 // Create a per-module phony target to run the lint check.
541 phonyName := ctx.ModuleName() + "-lint"
542 ctx.Phony(phonyName, xml)
Colin Crossc0efd1d2020-07-03 11:56:24 -0700543}
Colin Cross014489c2020-06-02 20:09:13 -0700544
Colin Cross08dca382020-07-21 20:31:17 -0700545func BuildModuleLintReportZips(ctx android.ModuleContext, depSets LintDepSets) android.Paths {
Colin Crossc85750b2022-04-21 12:50:51 -0700546 htmlList := android.SortedUniquePaths(depSets.HTML.ToList())
547 textList := android.SortedUniquePaths(depSets.Text.ToList())
548 xmlList := android.SortedUniquePaths(depSets.XML.ToList())
Colin Cross08dca382020-07-21 20:31:17 -0700549
550 if len(htmlList) == 0 && len(textList) == 0 && len(xmlList) == 0 {
551 return nil
552 }
553
554 htmlZip := android.PathForModuleOut(ctx, "lint-report-html.zip")
555 lintZip(ctx, htmlList, htmlZip)
556
557 textZip := android.PathForModuleOut(ctx, "lint-report-text.zip")
558 lintZip(ctx, textList, textZip)
559
560 xmlZip := android.PathForModuleOut(ctx, "lint-report-xml.zip")
561 lintZip(ctx, xmlList, xmlZip)
562
563 return android.Paths{htmlZip, textZip, xmlZip}
564}
565
Colin Cross014489c2020-06-02 20:09:13 -0700566type lintSingleton struct {
Cole Faustdf38f7a2023-03-02 16:43:15 -0800567 htmlZip android.WritablePath
568 textZip android.WritablePath
569 xmlZip android.WritablePath
570 referenceBaselineZip android.WritablePath
Colin Cross014489c2020-06-02 20:09:13 -0700571}
572
573func (l *lintSingleton) GenerateBuildActions(ctx android.SingletonContext) {
574 l.generateLintReportZips(ctx)
575 l.copyLintDependencies(ctx)
576}
577
Pedro Loureiro18233a22021-06-08 18:11:21 +0000578func findModuleOrErr(ctx android.SingletonContext, moduleName string) android.Module {
579 var res android.Module
580 ctx.VisitAllModules(func(m android.Module) {
581 if ctx.ModuleName(m) == moduleName {
582 if res == nil {
583 res = m
584 } else {
585 ctx.Errorf("lint: multiple %s modules found: %s and %s", moduleName,
586 ctx.ModuleSubDir(m), ctx.ModuleSubDir(res))
587 }
588 }
589 })
590 return res
591}
592
Colin Cross014489c2020-06-02 20:09:13 -0700593func (l *lintSingleton) copyLintDependencies(ctx android.SingletonContext) {
Jeongik Cha816a23a2020-07-08 01:09:23 +0900594 if ctx.Config().AlwaysUsePrebuiltSdks() {
Colin Cross014489c2020-06-02 20:09:13 -0700595 return
596 }
597
Cole Faust69861aa2023-01-31 15:49:07 -0800598 for _, sdk := range android.SortedKeys(allLintDatabasefiles) {
599 files := allLintDatabasefiles[sdk]
600 apiVersionsDb := findModuleOrErr(ctx, files.apiVersionsModule)
601 if apiVersionsDb == nil {
602 if !ctx.Config().AllowMissingDependencies() {
603 ctx.Errorf("lint: missing module api_versions_public")
604 }
605 return
Colin Cross014489c2020-06-02 20:09:13 -0700606 }
Colin Cross014489c2020-06-02 20:09:13 -0700607
Cole Faust69861aa2023-01-31 15:49:07 -0800608 sdkAnnotations := findModuleOrErr(ctx, files.annotationsModule)
609 if sdkAnnotations == nil {
610 if !ctx.Config().AllowMissingDependencies() {
611 ctx.Errorf("lint: missing module sdk-annotations.zip")
612 }
613 return
Anton Hanssonea17a452022-05-09 09:42:17 +0000614 }
Cole Faust69861aa2023-01-31 15:49:07 -0800615
616 ctx.Build(pctx, android.BuildParams{
617 Rule: android.CpIfChanged,
618 Input: android.OutputFileForModule(ctx, sdkAnnotations, ""),
619 Output: copiedLintDatabaseFilesPath(ctx, files.annotationCopiedName),
620 })
621
622 ctx.Build(pctx, android.BuildParams{
623 Rule: android.CpIfChanged,
624 Input: android.OutputFileForModule(ctx, apiVersionsDb, ".api_versions.xml"),
625 Output: copiedLintDatabaseFilesPath(ctx, files.apiVersionsCopiedName),
626 })
Anton Hanssonea17a452022-05-09 09:42:17 +0000627 }
Colin Cross014489c2020-06-02 20:09:13 -0700628}
629
Cole Faust69861aa2023-01-31 15:49:07 -0800630func copiedLintDatabaseFilesPath(ctx android.PathContext, name string) android.WritablePath {
Pedro Loureiro18233a22021-06-08 18:11:21 +0000631 return android.PathForOutput(ctx, "lint", name)
Colin Cross014489c2020-06-02 20:09:13 -0700632}
633
634func (l *lintSingleton) generateLintReportZips(ctx android.SingletonContext) {
Colin Cross8a6ed372020-07-06 11:45:51 -0700635 if ctx.Config().UnbundledBuild() {
636 return
637 }
638
Colin Cross014489c2020-06-02 20:09:13 -0700639 var outputs []*lintOutputs
640 var dirs []string
641 ctx.VisitAllModules(func(m android.Module) {
Jingwen Chencda22c92020-11-23 00:22:30 -0500642 if ctx.Config().KatiEnabled() && !m.ExportedToMake() {
Colin Cross014489c2020-06-02 20:09:13 -0700643 return
644 }
645
Colin Cross56a83212020-09-15 18:30:11 -0700646 if apex, ok := m.(android.ApexModule); ok && apex.NotAvailableForPlatform() {
Colin Cross5a377182023-12-14 14:46:23 -0800647 apexInfo, _ := android.SingletonModuleProvider(ctx, m, android.ApexInfoProvider)
Colin Cross56a83212020-09-15 18:30:11 -0700648 if apexInfo.IsForPlatform() {
649 // There are stray platform variants of modules in apexes that are not available for
650 // the platform, and they sometimes can't be built. Don't depend on them.
651 return
652 }
Colin Cross014489c2020-06-02 20:09:13 -0700653 }
654
Colin Cross08dca382020-07-21 20:31:17 -0700655 if l, ok := m.(lintOutputsIntf); ok {
Colin Cross014489c2020-06-02 20:09:13 -0700656 outputs = append(outputs, l.lintOutputs())
657 }
658 })
659
660 dirs = android.SortedUniqueStrings(dirs)
661
662 zip := func(outputPath android.WritablePath, get func(*lintOutputs) android.Path) {
663 var paths android.Paths
664
665 for _, output := range outputs {
Colin Cross08dca382020-07-21 20:31:17 -0700666 if p := get(output); p != nil {
667 paths = append(paths, p)
668 }
Colin Cross014489c2020-06-02 20:09:13 -0700669 }
670
Colin Crossc0efd1d2020-07-03 11:56:24 -0700671 lintZip(ctx, paths, outputPath)
Colin Cross014489c2020-06-02 20:09:13 -0700672 }
673
674 l.htmlZip = android.PathForOutput(ctx, "lint-report-html.zip")
675 zip(l.htmlZip, func(l *lintOutputs) android.Path { return l.html })
676
677 l.textZip = android.PathForOutput(ctx, "lint-report-text.zip")
678 zip(l.textZip, func(l *lintOutputs) android.Path { return l.text })
679
680 l.xmlZip = android.PathForOutput(ctx, "lint-report-xml.zip")
681 zip(l.xmlZip, func(l *lintOutputs) android.Path { return l.xml })
682
Cole Faustdf38f7a2023-03-02 16:43:15 -0800683 l.referenceBaselineZip = android.PathForOutput(ctx, "lint-report-reference-baselines.zip")
684 zip(l.referenceBaselineZip, func(l *lintOutputs) android.Path { return l.referenceBaseline })
685
686 ctx.Phony("lint-check", l.htmlZip, l.textZip, l.xmlZip, l.referenceBaselineZip)
Colin Cross014489c2020-06-02 20:09:13 -0700687}
688
689func (l *lintSingleton) MakeVars(ctx android.MakeVarsContext) {
Colin Cross8a6ed372020-07-06 11:45:51 -0700690 if !ctx.Config().UnbundledBuild() {
Cole Faustdf38f7a2023-03-02 16:43:15 -0800691 ctx.DistForGoal("lint-check", l.htmlZip, l.textZip, l.xmlZip, l.referenceBaselineZip)
Colin Cross8a6ed372020-07-06 11:45:51 -0700692 }
Colin Cross014489c2020-06-02 20:09:13 -0700693}
694
695var _ android.SingletonMakeVarsProvider = (*lintSingleton)(nil)
696
697func init() {
LaMont Jones0c10e4d2023-05-16 00:58:37 +0000698 android.RegisterParallelSingletonType("lint",
Colin Cross014489c2020-06-02 20:09:13 -0700699 func() android.Singleton { return &lintSingleton{} })
Jaewoong Jung476b9d62021-05-10 15:30:00 -0700700
701 registerLintBuildComponents(android.InitRegistrationContext)
702}
703
704func registerLintBuildComponents(ctx android.RegistrationContext) {
705 ctx.PostDepsMutators(func(ctx android.RegisterMutatorsContext) {
706 ctx.TopDown("enforce_strict_updatability_linting", enforceStrictUpdatabilityLintingMutator).Parallel()
707 })
Colin Cross014489c2020-06-02 20:09:13 -0700708}
Colin Crossc0efd1d2020-07-03 11:56:24 -0700709
710func lintZip(ctx android.BuilderContext, paths android.Paths, outputPath android.WritablePath) {
711 paths = android.SortedUniquePaths(android.CopyOfPaths(paths))
712
713 sort.Slice(paths, func(i, j int) bool {
714 return paths[i].String() < paths[j].String()
715 })
716
Colin Crossf1a035e2020-11-16 17:32:30 -0800717 rule := android.NewRuleBuilder(pctx, ctx)
Colin Crossc0efd1d2020-07-03 11:56:24 -0700718
Colin Crossf1a035e2020-11-16 17:32:30 -0800719 rule.Command().BuiltTool("soong_zip").
Colin Crossc0efd1d2020-07-03 11:56:24 -0700720 FlagWithOutput("-o ", outputPath).
721 FlagWithArg("-C ", android.PathForIntermediates(ctx).String()).
Colin Cross70c47412021-03-12 17:48:14 -0800722 FlagWithRspFileInputList("-r ", outputPath.ReplaceExtension(ctx, "rsp"), paths)
Colin Crossc0efd1d2020-07-03 11:56:24 -0700723
Colin Crossf1a035e2020-11-16 17:32:30 -0800724 rule.Build(outputPath.Base(), outputPath.Base())
Colin Crossc0efd1d2020-07-03 11:56:24 -0700725}
Jaewoong Jung476b9d62021-05-10 15:30:00 -0700726
727// Enforce the strict updatability linting to all applicable transitive dependencies.
728func enforceStrictUpdatabilityLintingMutator(ctx android.TopDownMutatorContext) {
729 m := ctx.Module()
Spandan Das17854f52022-01-14 21:19:14 +0000730 if d, ok := m.(LintDepSetsIntf); ok && d.GetStrictUpdatabilityLinting() {
Jaewoong Jung476b9d62021-05-10 15:30:00 -0700731 ctx.VisitDirectDepsWithTag(staticLibTag, func(d android.Module) {
Spandan Das17854f52022-01-14 21:19:14 +0000732 if a, ok := d.(LintDepSetsIntf); ok {
733 a.SetStrictUpdatabilityLinting(true)
Jaewoong Jung476b9d62021-05-10 15:30:00 -0700734 }
735 })
736 }
737}