Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 1 | // Copyright 2024 Google Inc. All rights reserved. |
| 2 | // |
| 3 | // Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 | // you may not use this file except in compliance with the License. |
| 5 | // You may obtain a copy of the License at |
| 6 | // |
| 7 | // http://www.apache.org/licenses/LICENSE-2.0 |
| 8 | // |
| 9 | // Unless required by applicable law or agreed to in writing, software |
| 10 | // distributed under the License is distributed on an "AS IS" BASIS, |
| 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 | // See the License for the specific language governing permissions and |
| 13 | // limitations under the License. |
| 14 | |
| 15 | package android |
| 16 | |
| 17 | import ( |
| 18 | "reflect" |
| 19 | "slices" |
| 20 | |
| 21 | "github.com/google/blueprint" |
| 22 | ) |
| 23 | |
Jihoon Kang | 17a61d7 | 2024-08-12 22:26:52 +0000 | [diff] [blame] | 24 | // ---------------------------------------------------------------------------- |
| 25 | // Start of the definitions of exception functions and the lookup table. |
| 26 | // |
| 27 | // Functions cannot be used as a value passed in providers, because functions are not |
| 28 | // hashable. As a workaround, the [exceptionHandleFuncLabel] enum values are passed using providers, |
| 29 | // and the corresponding functions are called from [exceptionHandleFunctionsTable] map. |
| 30 | // ---------------------------------------------------------------------------- |
| 31 | |
| 32 | type exceptionHandleFunc func(ModuleContext, Module, Module) bool |
| 33 | |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 34 | type StubsAvailableModule interface { |
| 35 | IsStubsModule() bool |
| 36 | } |
| 37 | |
| 38 | // Returns true if the dependency module is a stubs module |
Jihoon Kang | 17a61d7 | 2024-08-12 22:26:52 +0000 | [diff] [blame] | 39 | var depIsStubsModule exceptionHandleFunc = func(_ ModuleContext, _, dep Module) bool { |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 40 | if stubsModule, ok := dep.(StubsAvailableModule); ok { |
| 41 | return stubsModule.IsStubsModule() |
| 42 | } |
| 43 | return false |
| 44 | } |
| 45 | |
Jihoon Kang | 224ea08 | 2024-08-12 22:38:16 +0000 | [diff] [blame^] | 46 | // Returns true if the dependency module belongs to any of the apexes. |
| 47 | var depIsApexModule exceptionHandleFunc = func(mctx ModuleContext, _, dep Module) bool { |
| 48 | depContainersInfo, _ := getContainerModuleInfo(mctx, dep) |
| 49 | return InList(ApexContainer, depContainersInfo.belongingContainers) |
| 50 | } |
| 51 | |
| 52 | // Returns true if the module and the dependent module belongs to common apexes. |
| 53 | var belongsToCommonApexes exceptionHandleFunc = func(mctx ModuleContext, m, dep Module) bool { |
| 54 | mContainersInfo, _ := getContainerModuleInfo(mctx, m) |
| 55 | depContainersInfo, _ := getContainerModuleInfo(mctx, dep) |
| 56 | |
| 57 | return HasIntersection(mContainersInfo.ApexNames(), depContainersInfo.ApexNames()) |
| 58 | } |
| 59 | |
| 60 | // Returns true when all apexes that the module belongs to are non updatable. |
| 61 | // For an apex module to be allowed to depend on a non-apex partition module, |
| 62 | // all apexes that the module belong to must be non updatable. |
| 63 | var belongsToNonUpdatableApex exceptionHandleFunc = func(mctx ModuleContext, m, _ Module) bool { |
| 64 | mContainersInfo, _ := getContainerModuleInfo(mctx, m) |
| 65 | |
| 66 | return !mContainersInfo.UpdatableApex() |
| 67 | } |
| 68 | |
| 69 | // Returns true if the dependency is added via dependency tags that are not used to tag dynamic |
| 70 | // dependency tags. |
| 71 | var depIsNotDynamicDepTag exceptionHandleFunc = func(ctx ModuleContext, m, dep Module) bool { |
| 72 | mInstallable, _ := m.(InstallableModule) |
| 73 | depTag := ctx.OtherModuleDependencyTag(dep) |
| 74 | return !InList(depTag, mInstallable.DynamicDependencyTags()) |
| 75 | } |
| 76 | |
| 77 | // Returns true if the dependency is added via dependency tags that are not used to tag static |
| 78 | // or dynamic dependency tags. These dependencies do not affect the module in compile time or in |
| 79 | // runtime, thus are not significant enough to raise an error. |
| 80 | var depIsNotStaticOrDynamicDepTag exceptionHandleFunc = func(ctx ModuleContext, m, dep Module) bool { |
| 81 | mInstallable, _ := m.(InstallableModule) |
| 82 | depTag := ctx.OtherModuleDependencyTag(dep) |
| 83 | return !InList(depTag, append(mInstallable.StaticDependencyTags(), mInstallable.DynamicDependencyTags()...)) |
| 84 | } |
| 85 | |
| 86 | var globallyAllowlistedDependencies = []string{ |
| 87 | // Modules that provide annotations used within the platform and apexes. |
| 88 | "aconfig-annotations-lib", |
| 89 | "framework-annotations-lib", |
| 90 | "unsupportedappusage", |
| 91 | |
| 92 | // framework-res provides core resources essential for building apps and system UI. |
| 93 | // This module is implicitly added as a dependency for java modules even when the |
| 94 | // dependency specifies sdk_version. |
| 95 | "framework-res", |
| 96 | } |
| 97 | |
| 98 | // Returns true when the dependency is globally allowlisted for inter-container dependency |
| 99 | var depIsGloballyAllowlisted exceptionHandleFunc = func(_ ModuleContext, _, dep Module) bool { |
| 100 | return InList(dep.Name(), globallyAllowlistedDependencies) |
| 101 | } |
| 102 | |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 103 | // Labels of exception functions, which are used to determine special dependencies that allow |
| 104 | // otherwise restricted inter-container dependencies |
| 105 | type exceptionHandleFuncLabel int |
| 106 | |
| 107 | const ( |
| 108 | checkStubs exceptionHandleFuncLabel = iota |
Jihoon Kang | 224ea08 | 2024-08-12 22:38:16 +0000 | [diff] [blame^] | 109 | checkApexModule |
| 110 | checkInCommonApexes |
| 111 | checkApexIsNonUpdatable |
| 112 | checkNotDynamicDepTag |
| 113 | checkNotStaticOrDynamicDepTag |
| 114 | checkGlobalAllowlistedDep |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 115 | ) |
| 116 | |
Jihoon Kang | 224ea08 | 2024-08-12 22:38:16 +0000 | [diff] [blame^] | 117 | // Map of [exceptionHandleFuncLabel] to the [exceptionHandleFunc] |
Jihoon Kang | 17a61d7 | 2024-08-12 22:26:52 +0000 | [diff] [blame] | 118 | var exceptionHandleFunctionsTable = map[exceptionHandleFuncLabel]exceptionHandleFunc{ |
Jihoon Kang | 224ea08 | 2024-08-12 22:38:16 +0000 | [diff] [blame^] | 119 | checkStubs: depIsStubsModule, |
| 120 | checkApexModule: depIsApexModule, |
| 121 | checkInCommonApexes: belongsToCommonApexes, |
| 122 | checkApexIsNonUpdatable: belongsToNonUpdatableApex, |
| 123 | checkNotDynamicDepTag: depIsNotDynamicDepTag, |
| 124 | checkNotStaticOrDynamicDepTag: depIsNotStaticOrDynamicDepTag, |
| 125 | checkGlobalAllowlistedDep: depIsGloballyAllowlisted, |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 126 | } |
| 127 | |
Jihoon Kang | 17a61d7 | 2024-08-12 22:26:52 +0000 | [diff] [blame] | 128 | // ---------------------------------------------------------------------------- |
| 129 | // Start of the definitions of container determination functions. |
| 130 | // |
| 131 | // Similar to the above section, below defines the functions used to determine |
| 132 | // the container of each modules. |
| 133 | // ---------------------------------------------------------------------------- |
| 134 | |
| 135 | type containerBoundaryFunc func(mctx ModuleContext) bool |
| 136 | |
| 137 | var vendorContainerBoundaryFunc containerBoundaryFunc = func(mctx ModuleContext) bool { |
| 138 | m, ok := mctx.Module().(ImageInterface) |
| 139 | return mctx.Module().InstallInVendor() || (ok && m.VendorVariantNeeded(mctx)) |
| 140 | } |
| 141 | |
| 142 | var systemContainerBoundaryFunc containerBoundaryFunc = func(mctx ModuleContext) bool { |
| 143 | module := mctx.Module() |
| 144 | |
| 145 | return !module.InstallInTestcases() && |
| 146 | !module.InstallInData() && |
| 147 | !module.InstallInRamdisk() && |
| 148 | !module.InstallInVendorRamdisk() && |
| 149 | !module.InstallInDebugRamdisk() && |
| 150 | !module.InstallInRecovery() && |
| 151 | !module.InstallInVendor() && |
| 152 | !module.InstallInOdm() && |
| 153 | !module.InstallInProduct() && |
| 154 | determineModuleKind(module.base(), mctx.blueprintBaseModuleContext()) == platformModule |
| 155 | } |
| 156 | |
| 157 | var productContainerBoundaryFunc containerBoundaryFunc = func(mctx ModuleContext) bool { |
| 158 | m, ok := mctx.Module().(ImageInterface) |
| 159 | return mctx.Module().InstallInProduct() || (ok && m.ProductVariantNeeded(mctx)) |
| 160 | } |
| 161 | |
| 162 | var apexContainerBoundaryFunc containerBoundaryFunc = func(mctx ModuleContext) bool { |
| 163 | _, ok := ModuleProvider(mctx, AllApexInfoProvider) |
| 164 | return ok |
| 165 | } |
| 166 | |
| 167 | var ctsContainerBoundaryFunc containerBoundaryFunc = func(mctx ModuleContext) bool { |
| 168 | props := mctx.Module().GetProperties() |
| 169 | for _, prop := range props { |
| 170 | val := reflect.ValueOf(prop).Elem() |
| 171 | if val.Kind() == reflect.Struct { |
| 172 | testSuites := val.FieldByName("Test_suites") |
| 173 | if testSuites.IsValid() && testSuites.Kind() == reflect.Slice && slices.Contains(testSuites.Interface().([]string), "cts") { |
| 174 | return true |
| 175 | } |
| 176 | } |
| 177 | } |
| 178 | return false |
| 179 | } |
| 180 | |
| 181 | // Map of [*container] to the [containerBoundaryFunc] |
| 182 | var containerBoundaryFunctionsTable = map[*container]containerBoundaryFunc{ |
| 183 | VendorContainer: vendorContainerBoundaryFunc, |
| 184 | SystemContainer: systemContainerBoundaryFunc, |
| 185 | ProductContainer: productContainerBoundaryFunc, |
| 186 | ApexContainer: apexContainerBoundaryFunc, |
| 187 | CtsContainer: ctsContainerBoundaryFunc, |
| 188 | } |
| 189 | |
| 190 | // ---------------------------------------------------------------------------- |
| 191 | // End of the definitions of container determination functions. |
| 192 | // ---------------------------------------------------------------------------- |
| 193 | |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 194 | type InstallableModule interface { |
Jihoon Kang | 224ea08 | 2024-08-12 22:38:16 +0000 | [diff] [blame^] | 195 | ContainersInfo() ContainersInfo |
| 196 | StaticDependencyTags() []blueprint.DependencyTag |
| 197 | DynamicDependencyTags() []blueprint.DependencyTag |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 198 | } |
| 199 | |
| 200 | type restriction struct { |
| 201 | // container of the dependency |
| 202 | dependency *container |
| 203 | |
| 204 | // Error message to be emitted to the user when the dependency meets this restriction |
| 205 | errorMessage string |
| 206 | |
| 207 | // List of labels of allowed exception functions that allows bypassing this restriction. |
| 208 | // If any of the functions mapped to each labels returns true, this dependency would be |
| 209 | // considered allowed and an error will not be thrown. |
| 210 | allowedExceptions []exceptionHandleFuncLabel |
| 211 | } |
| 212 | type container struct { |
| 213 | // The name of the container i.e. partition, api domain |
| 214 | name string |
| 215 | |
| 216 | // Map of dependency restricted containers. |
| 217 | restricted []restriction |
| 218 | } |
| 219 | |
| 220 | var ( |
| 221 | VendorContainer = &container{ |
| 222 | name: VendorVariation, |
| 223 | restricted: nil, |
| 224 | } |
Jihoon Kang | 17a61d7 | 2024-08-12 22:26:52 +0000 | [diff] [blame] | 225 | |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 226 | SystemContainer = &container{ |
| 227 | name: "system", |
| 228 | restricted: []restriction{ |
| 229 | { |
| 230 | dependency: VendorContainer, |
| 231 | errorMessage: "Module belonging to the system partition other than HALs is " + |
| 232 | "not allowed to depend on the vendor partition module, in order to support " + |
| 233 | "independent development/update cycles and to support the Generic System " + |
| 234 | "Image. Try depending on HALs, VNDK or AIDL instead.", |
Jihoon Kang | 224ea08 | 2024-08-12 22:38:16 +0000 | [diff] [blame^] | 235 | allowedExceptions: []exceptionHandleFuncLabel{ |
| 236 | checkStubs, |
| 237 | checkNotDynamicDepTag, |
| 238 | checkGlobalAllowlistedDep, |
| 239 | }, |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 240 | }, |
| 241 | }, |
| 242 | } |
Jihoon Kang | 17a61d7 | 2024-08-12 22:26:52 +0000 | [diff] [blame] | 243 | |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 244 | ProductContainer = &container{ |
| 245 | name: ProductVariation, |
| 246 | restricted: []restriction{ |
| 247 | { |
| 248 | dependency: VendorContainer, |
| 249 | errorMessage: "Module belonging to the product partition is not allowed to " + |
| 250 | "depend on the vendor partition module, as this may lead to security " + |
| 251 | "vulnerabilities. Try depending on the HALs or utilize AIDL instead.", |
Jihoon Kang | 224ea08 | 2024-08-12 22:38:16 +0000 | [diff] [blame^] | 252 | allowedExceptions: []exceptionHandleFuncLabel{ |
| 253 | checkStubs, |
| 254 | checkNotDynamicDepTag, |
| 255 | checkGlobalAllowlistedDep, |
| 256 | }, |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 257 | }, |
| 258 | }, |
| 259 | } |
Jihoon Kang | 17a61d7 | 2024-08-12 22:26:52 +0000 | [diff] [blame] | 260 | |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 261 | ApexContainer = initializeApexContainer() |
Jihoon Kang | 17a61d7 | 2024-08-12 22:26:52 +0000 | [diff] [blame] | 262 | |
| 263 | CtsContainer = &container{ |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 264 | name: "cts", |
| 265 | restricted: []restriction{ |
| 266 | { |
| 267 | dependency: SystemContainer, |
| 268 | errorMessage: "CTS module should not depend on the modules belonging to the " + |
| 269 | "system partition, including \"framework\". Depending on the system " + |
| 270 | "partition may lead to disclosure of implementation details and regression " + |
| 271 | "due to API changes across platform versions. Try depending on the stubs instead.", |
Jihoon Kang | 224ea08 | 2024-08-12 22:38:16 +0000 | [diff] [blame^] | 272 | allowedExceptions: []exceptionHandleFuncLabel{ |
| 273 | checkStubs, |
| 274 | checkNotStaticOrDynamicDepTag, |
| 275 | checkGlobalAllowlistedDep, |
| 276 | }, |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 277 | }, |
| 278 | }, |
| 279 | } |
Jihoon Kang | 17a61d7 | 2024-08-12 22:26:52 +0000 | [diff] [blame] | 280 | |
| 281 | allContainers = []*container{ |
| 282 | VendorContainer, |
| 283 | SystemContainer, |
| 284 | ProductContainer, |
| 285 | ApexContainer, |
| 286 | CtsContainer, |
| 287 | } |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 288 | ) |
| 289 | |
| 290 | func initializeApexContainer() *container { |
| 291 | apexContainer := &container{ |
| 292 | name: "apex", |
| 293 | restricted: []restriction{ |
| 294 | { |
| 295 | dependency: SystemContainer, |
| 296 | errorMessage: "Module belonging to Apex(es) is not allowed to depend on the " + |
| 297 | "modules belonging to the system partition. Either statically depend on the " + |
| 298 | "module or convert the depending module to java_sdk_library and depend on " + |
| 299 | "the stubs.", |
Jihoon Kang | 224ea08 | 2024-08-12 22:38:16 +0000 | [diff] [blame^] | 300 | allowedExceptions: []exceptionHandleFuncLabel{ |
| 301 | checkStubs, |
| 302 | checkApexModule, |
| 303 | checkInCommonApexes, |
| 304 | checkApexIsNonUpdatable, |
| 305 | checkNotStaticOrDynamicDepTag, |
| 306 | checkGlobalAllowlistedDep, |
| 307 | }, |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 308 | }, |
| 309 | }, |
| 310 | } |
| 311 | |
| 312 | apexContainer.restricted = append(apexContainer.restricted, restriction{ |
| 313 | dependency: apexContainer, |
| 314 | errorMessage: "Module belonging to Apex(es) is not allowed to depend on the " + |
| 315 | "modules belonging to other Apex(es). Either include the depending " + |
| 316 | "module in the Apex or convert the depending module to java_sdk_library " + |
| 317 | "and depend on its stubs.", |
Jihoon Kang | 224ea08 | 2024-08-12 22:38:16 +0000 | [diff] [blame^] | 318 | allowedExceptions: []exceptionHandleFuncLabel{ |
| 319 | checkStubs, |
| 320 | checkInCommonApexes, |
| 321 | checkNotStaticOrDynamicDepTag, |
| 322 | checkGlobalAllowlistedDep, |
| 323 | }, |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 324 | }) |
| 325 | |
| 326 | return apexContainer |
| 327 | } |
| 328 | |
| 329 | type ContainersInfo struct { |
| 330 | belongingContainers []*container |
| 331 | |
| 332 | belongingApexes []ApexInfo |
| 333 | } |
| 334 | |
| 335 | func (c *ContainersInfo) BelongingContainers() []*container { |
| 336 | return c.belongingContainers |
| 337 | } |
| 338 | |
Jihoon Kang | 17a61d7 | 2024-08-12 22:26:52 +0000 | [diff] [blame] | 339 | func (c *ContainersInfo) ApexNames() (ret []string) { |
| 340 | for _, apex := range c.belongingApexes { |
| 341 | ret = append(ret, apex.InApexModules...) |
| 342 | } |
| 343 | slices.Sort(ret) |
| 344 | return ret |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 345 | } |
| 346 | |
Jihoon Kang | 17a61d7 | 2024-08-12 22:26:52 +0000 | [diff] [blame] | 347 | // Returns true if any of the apex the module belongs to is updatable. |
| 348 | func (c *ContainersInfo) UpdatableApex() bool { |
| 349 | for _, apex := range c.belongingApexes { |
| 350 | if apex.Updatable { |
| 351 | return true |
| 352 | } |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 353 | } |
Jihoon Kang | 17a61d7 | 2024-08-12 22:26:52 +0000 | [diff] [blame] | 354 | return false |
| 355 | } |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 356 | |
Jihoon Kang | 17a61d7 | 2024-08-12 22:26:52 +0000 | [diff] [blame] | 357 | var ContainersInfoProvider = blueprint.NewProvider[ContainersInfo]() |
| 358 | |
| 359 | func generateContainerInfo(ctx ModuleContext) ContainersInfo { |
| 360 | var containers []*container |
| 361 | |
| 362 | for _, cnt := range allContainers { |
| 363 | if containerBoundaryFunctionsTable[cnt](ctx) { |
| 364 | containers = append(containers, cnt) |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 365 | } |
| 366 | } |
| 367 | |
| 368 | var belongingApexes []ApexInfo |
| 369 | if apexInfo, ok := ModuleProvider(ctx, AllApexInfoProvider); ok { |
| 370 | belongingApexes = apexInfo.ApexInfos |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 371 | } |
| 372 | |
| 373 | return ContainersInfo{ |
| 374 | belongingContainers: containers, |
| 375 | belongingApexes: belongingApexes, |
| 376 | } |
| 377 | } |
| 378 | |
Jihoon Kang | 224ea08 | 2024-08-12 22:38:16 +0000 | [diff] [blame^] | 379 | func getContainerModuleInfo(ctx ModuleContext, module Module) (ContainersInfo, bool) { |
| 380 | if ctx.Module() == module { |
| 381 | return module.ContainersInfo(), true |
| 382 | } |
| 383 | |
| 384 | return OtherModuleProvider(ctx, module, ContainersInfoProvider) |
| 385 | } |
| 386 | |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 387 | func setContainerInfo(ctx ModuleContext) { |
| 388 | if _, ok := ctx.Module().(InstallableModule); ok { |
| 389 | containersInfo := generateContainerInfo(ctx) |
Jihoon Kang | 224ea08 | 2024-08-12 22:38:16 +0000 | [diff] [blame^] | 390 | ctx.Module().base().containersInfo = containersInfo |
Jihoon Kang | c3d4e11 | 2024-06-24 22:16:27 +0000 | [diff] [blame] | 391 | SetProvider(ctx, ContainersInfoProvider, containersInfo) |
| 392 | } |
| 393 | } |