| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 1 | // Copyright 2016 Google Inc. All rights reserved. | 
|  | 2 | // | 
|  | 3 | // Licensed under the Apache License, Version 2.0 (the "License"); | 
|  | 4 | // you may not use this file except in compliance with the License. | 
|  | 5 | // You may obtain a copy of the License at | 
|  | 6 | // | 
|  | 7 | //     http://www.apache.org/licenses/LICENSE-2.0 | 
|  | 8 | // | 
|  | 9 | // Unless required by applicable law or agreed to in writing, software | 
|  | 10 | // distributed under the License is distributed on an "AS IS" BASIS, | 
|  | 11 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | 
|  | 12 | // See the License for the specific language governing permissions and | 
|  | 13 | // limitations under the License. | 
|  | 14 |  | 
|  | 15 | package cc | 
|  | 16 |  | 
|  | 17 | import ( | 
|  | 18 | "fmt" | 
| Jeff Gaston | 7276539 | 2017-11-28 16:37:53 -0800 | [diff] [blame] | 19 | "sort" | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 20 | "strings" | 
| Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 21 | "sync" | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 22 |  | 
| Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 23 | "github.com/google/blueprint" | 
|  | 24 |  | 
| Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 25 | "android/soong/android" | 
| Evgenii Stepanov | af36db1 | 2016-08-15 14:18:24 -0700 | [diff] [blame] | 26 | "android/soong/cc/config" | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 27 | ) | 
|  | 28 |  | 
| Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 29 | var ( | 
|  | 30 | // Any C flags added by sanitizer which libTooling tools may not | 
|  | 31 | // understand also need to be added to ClangLibToolingUnknownCflags in | 
|  | 32 | // cc/config/clang.go | 
| Vishwath Mohan | f3918d3 | 2017-02-14 07:59:33 -0800 | [diff] [blame] | 33 |  | 
| Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 34 | asanCflags  = []string{"-fno-omit-frame-pointer"} | 
|  | 35 | asanLdflags = []string{"-Wl,-u,__asan_preinit"} | 
| Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 36 |  | 
| Peter Collingbourne | 967511a | 2019-03-19 21:39:54 -0700 | [diff] [blame] | 37 | // TODO(pcc): Stop passing -hwasan-allow-ifunc here once it has been made | 
|  | 38 | // the default. | 
|  | 39 | hwasanCflags = []string{"-fno-omit-frame-pointer", "-Wno-frame-larger-than=", | 
|  | 40 | "-mllvm", "-hwasan-create-frame-descriptions=0", | 
| Peter Collingbourne | e726ba5 | 2019-03-21 16:21:44 -0700 | [diff] [blame] | 41 | "-mllvm", "-hwasan-allow-ifunc", | 
| Evgenii Stepanov | 1c69e83 | 2019-06-14 18:37:33 -0700 | [diff] [blame] | 42 | "-fsanitize-hwaddress-abi=platform", | 
|  | 43 | "-fno-experimental-new-pass-manager"} | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 44 |  | 
| Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 45 | cfiCflags = []string{"-flto", "-fsanitize-cfi-cross-dso", | 
| Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 46 | "-fsanitize-blacklist=external/compiler-rt/lib/cfi/cfi_blacklist.txt"} | 
| Evgenii Stepanov | dbf1d4f | 2018-08-31 12:54:33 -0700 | [diff] [blame] | 47 | // -flto and -fvisibility are required by clang when -fsanitize=cfi is | 
|  | 48 | // used, but have no effect on assembly files | 
|  | 49 | cfiAsflags = []string{"-flto", "-fvisibility=default"} | 
| Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 50 | cfiLdflags = []string{"-flto", "-fsanitize-cfi-cross-dso", "-fsanitize=cfi", | 
| Pirama Arumuga Nainar | bdb17f0 | 2017-08-28 21:50:17 -0700 | [diff] [blame] | 51 | "-Wl,-plugin-opt,O1"} | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 52 | cfiExportsMapPath     = "build/soong/cc/config/cfi_exports.map" | 
|  | 53 | cfiStaticLibsMutex    sync.Mutex | 
|  | 54 | hwasanStaticLibsMutex sync.Mutex | 
| Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 55 |  | 
| Evgenii Stepanov | 98f5b06 | 2018-11-29 15:12:51 -0800 | [diff] [blame] | 56 | intOverflowCflags = []string{"-fsanitize-blacklist=build/soong/cc/config/integer_overflow_blacklist.txt"} | 
| Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 57 |  | 
| Peter Collingbourne | bd19db0 | 2019-03-06 10:38:48 -0800 | [diff] [blame] | 58 | minimalRuntimeFlags = []string{"-fsanitize-minimal-runtime", "-fno-sanitize-trap=integer,undefined", | 
| Ivan Lozano | ae6ae1d | 2018-10-08 09:29:39 -0700 | [diff] [blame] | 59 | "-fno-sanitize-recover=integer,undefined"} | 
| Evgenii Stepanov | 3c5a52a | 2018-12-18 17:02:44 -0800 | [diff] [blame] | 60 | hwasanGlobalOptions = []string{"heap_history_size=1023,stack_history_size=512"} | 
| Dan Willemsen | cbceaab | 2016-10-13 16:44:07 -0700 | [diff] [blame] | 61 | ) | 
|  | 62 |  | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 63 | type sanitizerType int | 
|  | 64 |  | 
| Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 65 | func boolPtr(v bool) *bool { | 
|  | 66 | if v { | 
|  | 67 | return &v | 
|  | 68 | } else { | 
|  | 69 | return nil | 
|  | 70 | } | 
|  | 71 | } | 
|  | 72 |  | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 73 | const ( | 
|  | 74 | asan sanitizerType = iota + 1 | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 75 | hwasan | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 76 | tsan | 
| Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 77 | intOverflow | 
| Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 78 | cfi | 
| Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 79 | scs | 
| Mitch Phillips | bfeade6 | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 80 | fuzzer | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 81 | ) | 
|  | 82 |  | 
| Jiyong Park | 8222663 | 2019-02-01 10:50:50 +0900 | [diff] [blame] | 83 | // Name of the sanitizer variation for this sanitizer type | 
|  | 84 | func (t sanitizerType) variationName() string { | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 85 | switch t { | 
|  | 86 | case asan: | 
|  | 87 | return "asan" | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 88 | case hwasan: | 
|  | 89 | return "hwasan" | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 90 | case tsan: | 
|  | 91 | return "tsan" | 
| Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 92 | case intOverflow: | 
|  | 93 | return "intOverflow" | 
| Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 94 | case cfi: | 
|  | 95 | return "cfi" | 
| Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 96 | case scs: | 
|  | 97 | return "scs" | 
| Mitch Phillips | bfeade6 | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 98 | case fuzzer: | 
|  | 99 | return "fuzzer" | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 100 | default: | 
|  | 101 | panic(fmt.Errorf("unknown sanitizerType %d", t)) | 
|  | 102 | } | 
|  | 103 | } | 
|  | 104 |  | 
| Jiyong Park | 8222663 | 2019-02-01 10:50:50 +0900 | [diff] [blame] | 105 | // This is the sanitizer names in SANITIZE_[TARGET|HOST] | 
|  | 106 | func (t sanitizerType) name() string { | 
|  | 107 | switch t { | 
|  | 108 | case asan: | 
|  | 109 | return "address" | 
|  | 110 | case hwasan: | 
|  | 111 | return "hwaddress" | 
|  | 112 | case tsan: | 
|  | 113 | return "thread" | 
|  | 114 | case intOverflow: | 
|  | 115 | return "integer_overflow" | 
|  | 116 | case cfi: | 
|  | 117 | return "cfi" | 
|  | 118 | case scs: | 
|  | 119 | return "shadow-call-stack" | 
| Mitch Phillips | bfeade6 | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 120 | case fuzzer: | 
|  | 121 | return "fuzzer" | 
| Jiyong Park | 8222663 | 2019-02-01 10:50:50 +0900 | [diff] [blame] | 122 | default: | 
|  | 123 | panic(fmt.Errorf("unknown sanitizerType %d", t)) | 
|  | 124 | } | 
|  | 125 | } | 
|  | 126 |  | 
| Jiyong Park | 1d1119f | 2019-07-29 21:27:18 +0900 | [diff] [blame] | 127 | func (t sanitizerType) incompatibleWithCfi() bool { | 
|  | 128 | return t == asan || t == fuzzer || t == hwasan | 
|  | 129 | } | 
|  | 130 |  | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 131 | type SanitizeProperties struct { | 
|  | 132 | // enable AddressSanitizer, ThreadSanitizer, or UndefinedBehaviorSanitizer | 
|  | 133 | Sanitize struct { | 
| Nan Zhang | 0007d81 | 2017-11-07 10:57:05 -0800 | [diff] [blame] | 134 | Never *bool `android:"arch_variant"` | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 135 |  | 
|  | 136 | // main sanitizers | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 137 | Address   *bool `android:"arch_variant"` | 
|  | 138 | Thread    *bool `android:"arch_variant"` | 
|  | 139 | Hwaddress *bool `android:"arch_variant"` | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 140 |  | 
|  | 141 | // local sanitizers | 
| Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 142 | Undefined        *bool    `android:"arch_variant"` | 
|  | 143 | All_undefined    *bool    `android:"arch_variant"` | 
|  | 144 | Misc_undefined   []string `android:"arch_variant"` | 
| Mitch Phillips | bfeade6 | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 145 | Fuzzer           *bool    `android:"arch_variant"` | 
| Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 146 | Safestack        *bool    `android:"arch_variant"` | 
|  | 147 | Cfi              *bool    `android:"arch_variant"` | 
|  | 148 | Integer_overflow *bool    `android:"arch_variant"` | 
| Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 149 | Scudo            *bool    `android:"arch_variant"` | 
| Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 150 | Scs              *bool    `android:"arch_variant"` | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 151 |  | 
| Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 152 | // Sanitizers to run in the diagnostic mode (as opposed to the release mode). | 
|  | 153 | // Replaces abort() on error with a human-readable error message. | 
|  | 154 | // Address and Thread sanitizers always run in diagnostic mode. | 
|  | 155 | Diag struct { | 
| Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 156 | Undefined        *bool    `android:"arch_variant"` | 
|  | 157 | Cfi              *bool    `android:"arch_variant"` | 
|  | 158 | Integer_overflow *bool    `android:"arch_variant"` | 
|  | 159 | Misc_undefined   []string `android:"arch_variant"` | 
| Ivan Lozano | 7929bba | 2018-12-12 09:36:31 -0800 | [diff] [blame] | 160 | No_recover       []string | 
| Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 161 | } | 
|  | 162 |  | 
|  | 163 | // value to pass to -fsanitize-recover= | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 164 | Recover []string | 
|  | 165 |  | 
|  | 166 | // value to pass to -fsanitize-blacklist | 
|  | 167 | Blacklist *string | 
|  | 168 | } `android:"arch_variant"` | 
|  | 169 |  | 
| Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 170 | SanitizerEnabled  bool     `blueprint:"mutated"` | 
|  | 171 | SanitizeDep       bool     `blueprint:"mutated"` | 
|  | 172 | MinimalRuntimeDep bool     `blueprint:"mutated"` | 
|  | 173 | UbsanRuntimeDep   bool     `blueprint:"mutated"` | 
|  | 174 | InSanitizerDir    bool     `blueprint:"mutated"` | 
|  | 175 | Sanitizers        []string `blueprint:"mutated"` | 
|  | 176 | DiagSanitizers    []string `blueprint:"mutated"` | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 177 | } | 
|  | 178 |  | 
|  | 179 | type sanitize struct { | 
|  | 180 | Properties SanitizeProperties | 
|  | 181 | } | 
|  | 182 |  | 
| Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 183 | func init() { | 
|  | 184 | android.RegisterMakeVarsProvider(pctx, cfiMakeVarsProvider) | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 185 | android.RegisterMakeVarsProvider(pctx, hwasanMakeVarsProvider) | 
| Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 186 | } | 
|  | 187 |  | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 188 | func (sanitize *sanitize) props() []interface{} { | 
|  | 189 | return []interface{}{&sanitize.Properties} | 
|  | 190 | } | 
|  | 191 |  | 
|  | 192 | func (sanitize *sanitize) begin(ctx BaseModuleContext) { | 
| Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 193 | s := &sanitize.Properties.Sanitize | 
|  | 194 |  | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 195 | // Don't apply sanitizers to NDK code. | 
| Jeff Gaston | af3cc2d | 2017-09-27 17:01:44 -0700 | [diff] [blame] | 196 | if ctx.useSdk() { | 
| Nan Zhang | 0007d81 | 2017-11-07 10:57:05 -0800 | [diff] [blame] | 197 | s.Never = BoolPtr(true) | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 198 | } | 
|  | 199 |  | 
| Doug Horn | c32c6b0 | 2019-01-17 14:44:05 -0800 | [diff] [blame] | 200 | // Sanitizers do not work on Fuchsia yet. | 
|  | 201 | if ctx.Fuchsia() { | 
|  | 202 | s.Never = BoolPtr(true) | 
|  | 203 | } | 
|  | 204 |  | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 205 | // Never always wins. | 
| Nan Zhang | 0007d81 | 2017-11-07 10:57:05 -0800 | [diff] [blame] | 206 | if Bool(s.Never) { | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 207 | return | 
|  | 208 | } | 
|  | 209 |  | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 210 | var globalSanitizers []string | 
| Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 211 | var globalSanitizersDiag []string | 
|  | 212 |  | 
| Dan Willemsen | 8536d6b | 2018-10-07 20:54:34 -0700 | [diff] [blame] | 213 | if ctx.Host() { | 
|  | 214 | if !ctx.Windows() { | 
|  | 215 | globalSanitizers = ctx.Config().SanitizeHost() | 
|  | 216 | } | 
|  | 217 | } else { | 
|  | 218 | arches := ctx.Config().SanitizeDeviceArch() | 
|  | 219 | if len(arches) == 0 || inList(ctx.Arch().ArchType.Name, arches) { | 
|  | 220 | globalSanitizers = ctx.Config().SanitizeDevice() | 
|  | 221 | globalSanitizersDiag = ctx.Config().SanitizeDeviceDiag() | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 222 | } | 
|  | 223 | } | 
|  | 224 |  | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 225 | if len(globalSanitizers) > 0 { | 
| Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 226 | var found bool | 
| Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 227 | if found, globalSanitizers = removeFromList("undefined", globalSanitizers); found && s.All_undefined == nil { | 
|  | 228 | s.All_undefined = boolPtr(true) | 
| Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 229 | } | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 230 |  | 
| Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 231 | if found, globalSanitizers = removeFromList("default-ub", globalSanitizers); found && s.Undefined == nil { | 
|  | 232 | s.Undefined = boolPtr(true) | 
| Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 233 | } | 
|  | 234 |  | 
| Mitch Phillips | bfeade6 | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 235 | if found, globalSanitizers = removeFromList("address", globalSanitizers); found && s.Address == nil { | 
|  | 236 | s.Address = boolPtr(true) | 
| Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 237 | } | 
|  | 238 |  | 
| Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 239 | if found, globalSanitizers = removeFromList("thread", globalSanitizers); found && s.Thread == nil { | 
|  | 240 | s.Thread = boolPtr(true) | 
| Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 241 | } | 
|  | 242 |  | 
| Mitch Phillips | bfeade6 | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 243 | if found, globalSanitizers = removeFromList("fuzzer", globalSanitizers); found && s.Fuzzer == nil { | 
|  | 244 | s.Fuzzer = boolPtr(true) | 
| Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 245 | } | 
|  | 246 |  | 
|  | 247 | if found, globalSanitizers = removeFromList("safe-stack", globalSanitizers); found && s.Safestack == nil { | 
|  | 248 | s.Safestack = boolPtr(true) | 
| Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 249 | } | 
|  | 250 |  | 
| Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 251 | if found, globalSanitizers = removeFromList("cfi", globalSanitizers); found && s.Cfi == nil { | 
| Colin Cross | 6510f91 | 2017-11-29 00:27:14 -0800 | [diff] [blame] | 252 | if !ctx.Config().CFIDisabledForPath(ctx.ModuleDir()) { | 
| Vishwath Mohan | 1fa3ac5 | 2017-10-31 02:26:14 -0700 | [diff] [blame] | 253 | s.Cfi = boolPtr(true) | 
|  | 254 | } | 
| Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 255 | } | 
|  | 256 |  | 
| Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 257 | // Global integer_overflow builds do not support static libraries. | 
| Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 258 | if found, globalSanitizers = removeFromList("integer_overflow", globalSanitizers); found && s.Integer_overflow == nil { | 
| Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 259 | if !ctx.Config().IntegerOverflowDisabledForPath(ctx.ModuleDir()) && !ctx.static() { | 
| Ivan Lozano | 5f59553 | 2017-07-13 14:46:05 -0700 | [diff] [blame] | 260 | s.Integer_overflow = boolPtr(true) | 
|  | 261 | } | 
| Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 262 | } | 
|  | 263 |  | 
| Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 264 | if found, globalSanitizers = removeFromList("scudo", globalSanitizers); found && s.Scudo == nil { | 
|  | 265 | s.Scudo = boolPtr(true) | 
|  | 266 | } | 
|  | 267 |  | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 268 | if found, globalSanitizers = removeFromList("hwaddress", globalSanitizers); found && s.Hwaddress == nil { | 
|  | 269 | s.Hwaddress = boolPtr(true) | 
|  | 270 | } | 
|  | 271 |  | 
| Evgenii Stepanov | 05bafd3 | 2016-07-07 17:38:41 +0000 | [diff] [blame] | 272 | if len(globalSanitizers) > 0 { | 
|  | 273 | ctx.ModuleErrorf("unknown global sanitizer option %s", globalSanitizers[0]) | 
|  | 274 | } | 
| Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 275 |  | 
| Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 276 | // Global integer_overflow builds do not support static library diagnostics. | 
| Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 277 | if found, globalSanitizersDiag = removeFromList("integer_overflow", globalSanitizersDiag); found && | 
| Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 278 | s.Diag.Integer_overflow == nil && Bool(s.Integer_overflow) && !ctx.static() { | 
| Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 279 | s.Diag.Integer_overflow = boolPtr(true) | 
|  | 280 | } | 
|  | 281 |  | 
| Vishwath Mohan | 1fa3ac5 | 2017-10-31 02:26:14 -0700 | [diff] [blame] | 282 | if found, globalSanitizersDiag = removeFromList("cfi", globalSanitizersDiag); found && | 
|  | 283 | s.Diag.Cfi == nil && Bool(s.Cfi) { | 
|  | 284 | s.Diag.Cfi = boolPtr(true) | 
|  | 285 | } | 
|  | 286 |  | 
| Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 287 | if len(globalSanitizersDiag) > 0 { | 
|  | 288 | ctx.ModuleErrorf("unknown global sanitizer diagnostics option %s", globalSanitizersDiag[0]) | 
|  | 289 | } | 
| Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 290 | } | 
| Colin Cross | 3c344ef | 2016-07-18 15:44:56 -0700 | [diff] [blame] | 291 |  | 
| Vishwath Mohan | 1c54f66 | 2018-05-24 18:36:18 -0700 | [diff] [blame] | 292 | // Enable CFI for all components in the include paths (for Aarch64 only) | 
|  | 293 | if s.Cfi == nil && ctx.Config().CFIEnabledForPath(ctx.ModuleDir()) && ctx.Arch().ArchType == android.Arm64 { | 
| Vishwath Mohan | 3af8ee0 | 2018-03-30 02:55:23 +0000 | [diff] [blame] | 294 | s.Cfi = boolPtr(true) | 
|  | 295 | if inList("cfi", ctx.Config().SanitizeDeviceDiag()) { | 
|  | 296 | s.Diag.Cfi = boolPtr(true) | 
| Vishwath Mohan | 1fa3ac5 | 2017-10-31 02:26:14 -0700 | [diff] [blame] | 297 | } | 
|  | 298 | } | 
|  | 299 |  | 
| Evgenii Stepanov | a83fdac | 2017-01-31 18:37:30 -0800 | [diff] [blame] | 300 | // CFI needs gold linker, and mips toolchain does not have one. | 
| Colin Cross | 6510f91 | 2017-11-29 00:27:14 -0800 | [diff] [blame] | 301 | if !ctx.Config().EnableCFI() || ctx.Arch().ArchType == android.Mips || ctx.Arch().ArchType == android.Mips64 { | 
| Vishwath Mohan | 1b017a7 | 2017-01-19 13:54:55 -0800 | [diff] [blame] | 302 | s.Cfi = nil | 
|  | 303 | s.Diag.Cfi = nil | 
|  | 304 | } | 
|  | 305 |  | 
| Vishwath Mohan | 6d67e6e | 2017-02-07 20:31:41 -0800 | [diff] [blame] | 306 | // Also disable CFI for arm32 until b/35157333 is fixed. | 
|  | 307 | if ctx.Arch().ArchType == android.Arm { | 
|  | 308 | s.Cfi = nil | 
|  | 309 | s.Diag.Cfi = nil | 
|  | 310 | } | 
|  | 311 |  | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 312 | // HWASan requires AArch64 hardware feature (top-byte-ignore). | 
|  | 313 | if ctx.Arch().ArchType != android.Arm64 { | 
|  | 314 | s.Hwaddress = nil | 
|  | 315 | } | 
|  | 316 |  | 
| Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 317 | // SCS is only implemented on AArch64. | 
| Peter Collingbourne | bd19db0 | 2019-03-06 10:38:48 -0800 | [diff] [blame] | 318 | if ctx.Arch().ArchType != android.Arm64 { | 
| Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 319 | s.Scs = nil | 
|  | 320 | } | 
|  | 321 |  | 
| Vishwath Mohan | 8f4fdd8 | 2017-04-20 07:42:52 -0700 | [diff] [blame] | 322 | // Also disable CFI if ASAN is enabled. | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 323 | if Bool(s.Address) || Bool(s.Hwaddress) { | 
| Vishwath Mohan | 8f4fdd8 | 2017-04-20 07:42:52 -0700 | [diff] [blame] | 324 | s.Cfi = nil | 
|  | 325 | s.Diag.Cfi = nil | 
|  | 326 | } | 
|  | 327 |  | 
| Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 328 | // Disable sanitizers that depend on the UBSan runtime for host builds. | 
| Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 329 | if ctx.Host() { | 
|  | 330 | s.Cfi = nil | 
|  | 331 | s.Diag.Cfi = nil | 
| Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 332 | s.Misc_undefined = nil | 
|  | 333 | s.Undefined = nil | 
|  | 334 | s.All_undefined = nil | 
|  | 335 | s.Integer_overflow = nil | 
| Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 336 | } | 
|  | 337 |  | 
| Vishwath Mohan | 9ccbba0 | 2018-05-28 13:54:48 -0700 | [diff] [blame] | 338 | // Also disable CFI for VNDK variants of components | 
|  | 339 | if ctx.isVndk() && ctx.useVndk() { | 
| Vishwath Mohan | 7589c82 | 2018-05-23 19:29:55 -0700 | [diff] [blame] | 340 | s.Cfi = nil | 
|  | 341 | s.Diag.Cfi = nil | 
|  | 342 | } | 
|  | 343 |  | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 344 | // HWASan ramdisk (which is built from recovery) goes over some bootloader limit. | 
| Evgenii Stepanov | 1e79844 | 2018-11-15 17:34:18 -0800 | [diff] [blame] | 345 | // Keep libc instrumented so that recovery can run hwasan-instrumented code if necessary. | 
|  | 346 | if ctx.inRecovery() && !strings.HasPrefix(ctx.ModuleDir(), "bionic/libc") { | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 347 | s.Hwaddress = nil | 
|  | 348 | } | 
|  | 349 |  | 
| Colin Cross | 3c344ef | 2016-07-18 15:44:56 -0700 | [diff] [blame] | 350 | if ctx.staticBinary() { | 
|  | 351 | s.Address = nil | 
| Mitch Phillips | bfeade6 | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 352 | s.Fuzzer = nil | 
| Colin Cross | 3c344ef | 2016-07-18 15:44:56 -0700 | [diff] [blame] | 353 | s.Thread = nil | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 354 | } | 
|  | 355 |  | 
| Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 356 | if Bool(s.All_undefined) { | 
|  | 357 | s.Undefined = nil | 
|  | 358 | } | 
|  | 359 |  | 
| Evgenii Stepanov | 0a8a0d0 | 2016-05-12 13:54:53 -0700 | [diff] [blame] | 360 | if !ctx.toolchain().Is64Bit() { | 
|  | 361 | // TSAN and SafeStack are not supported on 32-bit architectures | 
| Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 362 | s.Thread = nil | 
|  | 363 | s.Safestack = nil | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 364 | // TODO(ccross): error for compile_multilib = "32"? | 
|  | 365 | } | 
|  | 366 |  | 
| Evgenii Stepanov | 76cee23 | 2017-01-27 15:44:44 -0800 | [diff] [blame] | 367 | if ctx.Os() != android.Windows && (Bool(s.All_undefined) || Bool(s.Undefined) || Bool(s.Address) || Bool(s.Thread) || | 
| Mitch Phillips | bfeade6 | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 368 | Bool(s.Fuzzer) || Bool(s.Safestack) || Bool(s.Cfi) || Bool(s.Integer_overflow) || len(s.Misc_undefined) > 0 || | 
| Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 369 | Bool(s.Scudo) || Bool(s.Hwaddress) || Bool(s.Scs)) { | 
| Colin Cross | 3c344ef | 2016-07-18 15:44:56 -0700 | [diff] [blame] | 370 | sanitize.Properties.SanitizerEnabled = true | 
|  | 371 | } | 
|  | 372 |  | 
| Kostya Kortchinsky | d5275c8 | 2019-02-01 08:42:56 -0800 | [diff] [blame] | 373 | // Disable Scudo if ASan or TSan is enabled, or if it's disabled globally. | 
|  | 374 | if Bool(s.Address) || Bool(s.Thread) || Bool(s.Hwaddress) || ctx.Config().DisableScudo() { | 
| Kostya Kortchinsky | d18ae5c | 2018-06-12 14:46:54 -0700 | [diff] [blame] | 375 | s.Scudo = nil | 
|  | 376 | } | 
|  | 377 |  | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 378 | if Bool(s.Hwaddress) { | 
|  | 379 | s.Address = nil | 
|  | 380 | s.Thread = nil | 
|  | 381 | } | 
|  | 382 |  | 
| Mitch Phillips | bfeade6 | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 383 | // TODO(b/131771163): CFI transiently depends on LTO, and thus Fuzzer is | 
|  | 384 | // mutually incompatible. | 
|  | 385 | if Bool(s.Fuzzer) { | 
|  | 386 | s.Cfi = nil | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 387 | } | 
|  | 388 | } | 
|  | 389 |  | 
|  | 390 | func (sanitize *sanitize) deps(ctx BaseModuleContext, deps Deps) Deps { | 
|  | 391 | if !sanitize.Properties.SanitizerEnabled { // || c.static() { | 
|  | 392 | return deps | 
|  | 393 | } | 
|  | 394 |  | 
|  | 395 | if ctx.Device() { | 
| Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 396 | if Bool(sanitize.Properties.Sanitize.Address) { | 
| Christopher Ferris | 753d4a6 | 2019-05-09 13:27:02 -0700 | [diff] [blame] | 397 | // Compiling asan and having libc_scudo in the same | 
|  | 398 | // executable will cause the executable to crash. | 
|  | 399 | // Remove libc_scudo since it is only used to override | 
|  | 400 | // allocation functions which asan already overrides. | 
|  | 401 | _, deps.SharedLibs = removeFromList("libc_scudo", deps.SharedLibs) | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 402 | } | 
|  | 403 | } | 
|  | 404 |  | 
|  | 405 | return deps | 
|  | 406 | } | 
|  | 407 |  | 
| Chih-Hung Hsieh | 3567e62 | 2018-11-15 14:01:36 -0800 | [diff] [blame] | 408 | func toDisableImplicitIntegerChange(flags []string) bool { | 
|  | 409 | // Returns true if any flag is fsanitize*integer, and there is | 
|  | 410 | // no explicit flag about sanitize=implicit-integer-sign-change. | 
|  | 411 | for _, f := range flags { | 
|  | 412 | if strings.Contains(f, "sanitize=implicit-integer-sign-change") { | 
|  | 413 | return false | 
|  | 414 | } | 
|  | 415 | } | 
|  | 416 | for _, f := range flags { | 
|  | 417 | if strings.HasPrefix(f, "-fsanitize") && strings.Contains(f, "integer") { | 
|  | 418 | return true | 
|  | 419 | } | 
|  | 420 | } | 
|  | 421 | return false | 
|  | 422 | } | 
|  | 423 |  | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 424 | func (sanitize *sanitize) flags(ctx ModuleContext, flags Flags) Flags { | 
| Ivan Lozano | 59fdea2 | 2018-05-10 14:17:22 -0700 | [diff] [blame] | 425 | minimalRuntimeLib := config.UndefinedBehaviorSanitizerMinimalRuntimeLibrary(ctx.toolchain()) + ".a" | 
|  | 426 | minimalRuntimePath := "${config.ClangAsanLibDir}/" + minimalRuntimeLib | 
| Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 427 |  | 
|  | 428 | if ctx.Device() && sanitize.Properties.MinimalRuntimeDep { | 
|  | 429 | flags.LdFlags = append(flags.LdFlags, minimalRuntimePath) | 
| Ivan Lozano | 59fdea2 | 2018-05-10 14:17:22 -0700 | [diff] [blame] | 430 | flags.LdFlags = append(flags.LdFlags, "-Wl,--exclude-libs,"+minimalRuntimeLib) | 
| Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 431 | } | 
| Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 432 | if !sanitize.Properties.SanitizerEnabled && !sanitize.Properties.UbsanRuntimeDep { | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 433 | return flags | 
|  | 434 | } | 
|  | 435 |  | 
| Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 436 | if Bool(sanitize.Properties.Sanitize.Address) { | 
| Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 437 | if ctx.Arch().ArchType == android.Arm { | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 438 | // Frame pointer based unwinder in ASan requires ARM frame setup. | 
|  | 439 | // TODO: put in flags? | 
|  | 440 | flags.RequiredInstructionSet = "arm" | 
|  | 441 | } | 
| Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 442 | flags.CFlags = append(flags.CFlags, asanCflags...) | 
|  | 443 | flags.LdFlags = append(flags.LdFlags, asanLdflags...) | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 444 |  | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 445 | if ctx.Host() { | 
|  | 446 | // -nodefaultlibs (provided with libc++) prevents the driver from linking | 
|  | 447 | // libraries needed with -fsanitize=address. http://b/18650275 (WAI) | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 448 | flags.LdFlags = append(flags.LdFlags, "-Wl,--no-as-needed") | 
|  | 449 | } else { | 
| Jiyong Park | a2aca28 | 2019-02-02 13:13:38 +0900 | [diff] [blame] | 450 | if ctx.bootstrap() { | 
|  | 451 | flags.DynamicLinker = "/system/bin/bootstrap/linker_asan" | 
|  | 452 | } else { | 
|  | 453 | flags.DynamicLinker = "/system/bin/linker_asan" | 
|  | 454 | } | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 455 | if flags.Toolchain.Is64Bit() { | 
|  | 456 | flags.DynamicLinker += "64" | 
|  | 457 | } | 
|  | 458 | } | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 459 | } | 
|  | 460 |  | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 461 | if Bool(sanitize.Properties.Sanitize.Hwaddress) { | 
|  | 462 | flags.CFlags = append(flags.CFlags, hwasanCflags...) | 
| Yabin Cui | 6be405e | 2017-10-19 15:52:11 -0700 | [diff] [blame] | 463 | } | 
|  | 464 |  | 
| Mitch Phillips | bfeade6 | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 465 | if Bool(sanitize.Properties.Sanitize.Fuzzer) { | 
|  | 466 | flags.CFlags = append(flags.CFlags, "-fsanitize=fuzzer-no-link") | 
|  | 467 | flags.LdFlags = append(flags.LdFlags, "-fsanitize=fuzzer-no-link") | 
|  | 468 |  | 
|  | 469 | // TODO(b/131771163): LTO and Fuzzer support is mutually incompatible. | 
|  | 470 | _, flags.LdFlags = removeFromList("-flto", flags.LdFlags) | 
| Mitch Phillips | 34b493f | 2019-08-02 16:57:55 -0700 | [diff] [blame] | 471 | _, flags.CFlags = removeFromList("-flto", flags.CFlags) | 
| Mitch Phillips | bfeade6 | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 472 | flags.LdFlags = append(flags.LdFlags, "-fno-lto") | 
| Mitch Phillips | 34b493f | 2019-08-02 16:57:55 -0700 | [diff] [blame] | 473 | flags.CFlags = append(flags.CFlags, "-fno-lto") | 
| Mitch Phillips | 7438475 | 2019-06-17 10:33:52 -0700 | [diff] [blame] | 474 |  | 
|  | 475 | // TODO(b/133876586): Experimental PM breaks sanitizer coverage. | 
|  | 476 | _, flags.CFlags = removeFromList("-fexperimental-new-pass-manager", flags.CFlags) | 
|  | 477 | flags.CFlags = append(flags.CFlags, "-fno-experimental-new-pass-manager") | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 478 | } | 
|  | 479 |  | 
| Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 480 | if Bool(sanitize.Properties.Sanitize.Cfi) { | 
| Evgenii Stepanov | 7ebf9fa | 2017-01-20 14:13:06 -0800 | [diff] [blame] | 481 | if ctx.Arch().ArchType == android.Arm { | 
|  | 482 | // __cfi_check needs to be built as Thumb (see the code in linker_cfi.cpp). LLVM is not set up | 
|  | 483 | // to do this on a function basis, so force Thumb on the entire module. | 
|  | 484 | flags.RequiredInstructionSet = "thumb" | 
|  | 485 | } | 
| Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 486 |  | 
| Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 487 | flags.CFlags = append(flags.CFlags, cfiCflags...) | 
| Evgenii Stepanov | dbf1d4f | 2018-08-31 12:54:33 -0700 | [diff] [blame] | 488 | flags.AsFlags = append(flags.AsFlags, cfiAsflags...) | 
| Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 489 | // Only append the default visibility flag if -fvisibility has not already been set | 
|  | 490 | // to hidden. | 
|  | 491 | if !inList("-fvisibility=hidden", flags.CFlags) { | 
|  | 492 | flags.CFlags = append(flags.CFlags, "-fvisibility=default") | 
|  | 493 | } | 
| Jayant Chowdhary | 9677e8c | 2017-06-15 14:45:18 -0700 | [diff] [blame] | 494 | flags.LdFlags = append(flags.LdFlags, cfiLdflags...) | 
| Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 495 |  | 
|  | 496 | if ctx.staticBinary() { | 
|  | 497 | _, flags.CFlags = removeFromList("-fsanitize-cfi-cross-dso", flags.CFlags) | 
|  | 498 | _, flags.LdFlags = removeFromList("-fsanitize-cfi-cross-dso", flags.LdFlags) | 
|  | 499 | } | 
| Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 500 | } | 
|  | 501 |  | 
| Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 502 | if Bool(sanitize.Properties.Sanitize.Integer_overflow) { | 
| Ivan Lozano | a9255a8 | 2018-03-13 10:41:07 -0700 | [diff] [blame] | 503 | flags.CFlags = append(flags.CFlags, intOverflowCflags...) | 
| Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 504 | } | 
|  | 505 |  | 
| Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 506 | if len(sanitize.Properties.Sanitizers) > 0 { | 
|  | 507 | sanitizeArg := "-fsanitize=" + strings.Join(sanitize.Properties.Sanitizers, ",") | 
| Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 508 |  | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 509 | flags.CFlags = append(flags.CFlags, sanitizeArg) | 
| Evgenii Stepanov | dbf1d4f | 2018-08-31 12:54:33 -0700 | [diff] [blame] | 510 | flags.AsFlags = append(flags.AsFlags, sanitizeArg) | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 511 | if ctx.Host() { | 
| Evgenii Stepanov | 76cee23 | 2017-01-27 15:44:44 -0800 | [diff] [blame] | 512 | // Host sanitizers only link symbols in the final executable, so | 
|  | 513 | // there will always be undefined symbols in intermediate libraries. | 
|  | 514 | _, flags.LdFlags = removeFromList("-Wl,--no-undefined", flags.LdFlags) | 
| Mitch Phillips | bfeade6 | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 515 | flags.LdFlags = append(flags.LdFlags, sanitizeArg) | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 516 | } else { | 
| Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 517 | if enableMinimalRuntime(sanitize) { | 
|  | 518 | flags.CFlags = append(flags.CFlags, strings.Join(minimalRuntimeFlags, " ")) | 
|  | 519 | flags.libFlags = append([]string{minimalRuntimePath}, flags.libFlags...) | 
| Ivan Lozano | 59fdea2 | 2018-05-10 14:17:22 -0700 | [diff] [blame] | 520 | flags.LdFlags = append(flags.LdFlags, "-Wl,--exclude-libs,"+minimalRuntimeLib) | 
| Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 521 | } | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 522 | } | 
| Mitch Phillips | bfeade6 | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 523 |  | 
|  | 524 | if Bool(sanitize.Properties.Sanitize.Fuzzer) { | 
|  | 525 | // When fuzzing, we wish to crash with diagnostics on any bug. | 
|  | 526 | flags.CFlags = append(flags.CFlags, "-fno-sanitize-trap=all", "-fno-sanitize-recover=all") | 
|  | 527 | } else if ctx.Host() { | 
|  | 528 | flags.CFlags = append(flags.CFlags, "-fno-sanitize-recover=all") | 
|  | 529 | } else { | 
|  | 530 | flags.CFlags = append(flags.CFlags, "-fsanitize-trap=all", "-ftrap-function=abort") | 
|  | 531 | } | 
| Chih-Hung Hsieh | 3567e62 | 2018-11-15 14:01:36 -0800 | [diff] [blame] | 532 | // http://b/119329758, Android core does not boot up with this sanitizer yet. | 
|  | 533 | if toDisableImplicitIntegerChange(flags.CFlags) { | 
|  | 534 | flags.CFlags = append(flags.CFlags, "-fno-sanitize=implicit-integer-sign-change") | 
|  | 535 | } | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 536 | } | 
|  | 537 |  | 
| Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 538 | if len(sanitize.Properties.DiagSanitizers) > 0 { | 
|  | 539 | flags.CFlags = append(flags.CFlags, "-fno-sanitize-trap="+strings.Join(sanitize.Properties.DiagSanitizers, ",")) | 
| Evgenii Stepanov | 1e405e1 | 2016-08-16 15:39:54 -0700 | [diff] [blame] | 540 | } | 
|  | 541 | // FIXME: enable RTTI if diag + (cfi or vptr) | 
|  | 542 |  | 
| Andreas Gampe | 9707116 | 2017-05-08 13:15:23 -0700 | [diff] [blame] | 543 | if sanitize.Properties.Sanitize.Recover != nil { | 
|  | 544 | flags.CFlags = append(flags.CFlags, "-fsanitize-recover="+ | 
|  | 545 | strings.Join(sanitize.Properties.Sanitize.Recover, ",")) | 
|  | 546 | } | 
|  | 547 |  | 
| Ivan Lozano | 7929bba | 2018-12-12 09:36:31 -0800 | [diff] [blame] | 548 | if sanitize.Properties.Sanitize.Diag.No_recover != nil { | 
|  | 549 | flags.CFlags = append(flags.CFlags, "-fno-sanitize-recover="+ | 
|  | 550 | strings.Join(sanitize.Properties.Sanitize.Diag.No_recover, ",")) | 
|  | 551 | } | 
|  | 552 |  | 
| Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 553 | blacklist := android.OptionalPathForModuleSrc(ctx, sanitize.Properties.Sanitize.Blacklist) | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 554 | if blacklist.Valid() { | 
|  | 555 | flags.CFlags = append(flags.CFlags, "-fsanitize-blacklist="+blacklist.String()) | 
|  | 556 | flags.CFlagsDeps = append(flags.CFlagsDeps, blacklist.Path()) | 
|  | 557 | } | 
|  | 558 |  | 
|  | 559 | return flags | 
|  | 560 | } | 
|  | 561 |  | 
| Colin Cross | 8ff9ef4 | 2017-05-08 13:44:11 -0700 | [diff] [blame] | 562 | func (sanitize *sanitize) AndroidMk(ctx AndroidMkContext, ret *android.AndroidMkData) { | 
| Jiyong Park | 1d1119f | 2019-07-29 21:27:18 +0900 | [diff] [blame] | 563 | // Add a suffix for cfi/hwasan/scs-enabled static/header libraries to allow surfacing | 
|  | 564 | // both the sanitized and non-sanitized variants to make without a name conflict. | 
|  | 565 | if ret.Class == "STATIC_LIBRARIES" || ret.Class == "HEADER_LIBRARIES" { | 
|  | 566 | if Bool(sanitize.Properties.Sanitize.Cfi) { | 
|  | 567 | ret.SubName += ".cfi" | 
|  | 568 | } | 
|  | 569 | if Bool(sanitize.Properties.Sanitize.Hwaddress) { | 
|  | 570 | ret.SubName += ".hwasan" | 
|  | 571 | } | 
|  | 572 | if Bool(sanitize.Properties.Sanitize.Scs) { | 
|  | 573 | ret.SubName += ".scs" | 
|  | 574 | } | 
| Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 575 | } | 
| Colin Cross | 8ff9ef4 | 2017-05-08 13:44:11 -0700 | [diff] [blame] | 576 | } | 
|  | 577 |  | 
| Vishwath Mohan | 1dd8839 | 2017-03-29 22:00:18 -0700 | [diff] [blame] | 578 | func (sanitize *sanitize) inSanitizerDir() bool { | 
|  | 579 | return sanitize.Properties.InSanitizerDir | 
| Colin Cross | 30d5f51 | 2016-05-03 18:02:42 -0700 | [diff] [blame] | 580 | } | 
|  | 581 |  | 
| Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 582 | func (sanitize *sanitize) getSanitizerBoolPtr(t sanitizerType) *bool { | 
| Vishwath Mohan | 9522930 | 2017-08-11 00:53:16 +0000 | [diff] [blame] | 583 | switch t { | 
|  | 584 | case asan: | 
| Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 585 | return sanitize.Properties.Sanitize.Address | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 586 | case hwasan: | 
|  | 587 | return sanitize.Properties.Sanitize.Hwaddress | 
| Vishwath Mohan | 9522930 | 2017-08-11 00:53:16 +0000 | [diff] [blame] | 588 | case tsan: | 
| Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 589 | return sanitize.Properties.Sanitize.Thread | 
| Vishwath Mohan | 9522930 | 2017-08-11 00:53:16 +0000 | [diff] [blame] | 590 | case intOverflow: | 
| Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 591 | return sanitize.Properties.Sanitize.Integer_overflow | 
|  | 592 | case cfi: | 
|  | 593 | return sanitize.Properties.Sanitize.Cfi | 
| Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 594 | case scs: | 
|  | 595 | return sanitize.Properties.Sanitize.Scs | 
| Mitch Phillips | bfeade6 | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 596 | case fuzzer: | 
|  | 597 | return sanitize.Properties.Sanitize.Fuzzer | 
| Vishwath Mohan | 9522930 | 2017-08-11 00:53:16 +0000 | [diff] [blame] | 598 | default: | 
|  | 599 | panic(fmt.Errorf("unknown sanitizerType %d", t)) | 
|  | 600 | } | 
|  | 601 | } | 
|  | 602 |  | 
| Dan Albert | 7d1eecf | 2018-01-19 12:30:45 -0800 | [diff] [blame] | 603 | func (sanitize *sanitize) isUnsanitizedVariant() bool { | 
|  | 604 | return !sanitize.isSanitizerEnabled(asan) && | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 605 | !sanitize.isSanitizerEnabled(hwasan) && | 
| Dan Albert | 7d1eecf | 2018-01-19 12:30:45 -0800 | [diff] [blame] | 606 | !sanitize.isSanitizerEnabled(tsan) && | 
| Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 607 | !sanitize.isSanitizerEnabled(cfi) && | 
| Mitch Phillips | bfeade6 | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 608 | !sanitize.isSanitizerEnabled(scs) && | 
|  | 609 | !sanitize.isSanitizerEnabled(fuzzer) | 
| Dan Albert | 7d1eecf | 2018-01-19 12:30:45 -0800 | [diff] [blame] | 610 | } | 
|  | 611 |  | 
| Jayant Chowdhary | b7e08ca | 2018-05-10 15:29:24 -0700 | [diff] [blame] | 612 | func (sanitize *sanitize) isVariantOnProductionDevice() bool { | 
|  | 613 | return !sanitize.isSanitizerEnabled(asan) && | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 614 | !sanitize.isSanitizerEnabled(hwasan) && | 
| Mitch Phillips | bfeade6 | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 615 | !sanitize.isSanitizerEnabled(tsan) && | 
|  | 616 | !sanitize.isSanitizerEnabled(fuzzer) | 
| Jayant Chowdhary | b7e08ca | 2018-05-10 15:29:24 -0700 | [diff] [blame] | 617 | } | 
|  | 618 |  | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 619 | func (sanitize *sanitize) SetSanitizer(t sanitizerType, b bool) { | 
|  | 620 | switch t { | 
|  | 621 | case asan: | 
| Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 622 | sanitize.Properties.Sanitize.Address = boolPtr(b) | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 623 | case hwasan: | 
|  | 624 | sanitize.Properties.Sanitize.Hwaddress = boolPtr(b) | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 625 | case tsan: | 
| Evgenii Stepanov | fcfe56d | 2016-07-07 10:54:07 -0700 | [diff] [blame] | 626 | sanitize.Properties.Sanitize.Thread = boolPtr(b) | 
| Ivan Lozano | 0c3a1ef | 2017-06-28 09:10:48 -0700 | [diff] [blame] | 627 | case intOverflow: | 
|  | 628 | sanitize.Properties.Sanitize.Integer_overflow = boolPtr(b) | 
| Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 629 | case cfi: | 
|  | 630 | sanitize.Properties.Sanitize.Cfi = boolPtr(b) | 
| Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 631 | case scs: | 
|  | 632 | sanitize.Properties.Sanitize.Scs = boolPtr(b) | 
| Mitch Phillips | bfeade6 | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 633 | case fuzzer: | 
|  | 634 | sanitize.Properties.Sanitize.Fuzzer = boolPtr(b) | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 635 | default: | 
|  | 636 | panic(fmt.Errorf("unknown sanitizerType %d", t)) | 
|  | 637 | } | 
|  | 638 | if b { | 
|  | 639 | sanitize.Properties.SanitizerEnabled = true | 
|  | 640 | } | 
|  | 641 | } | 
|  | 642 |  | 
| Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 643 | // Check if the sanitizer is explicitly disabled (as opposed to nil by | 
|  | 644 | // virtue of not being set). | 
|  | 645 | func (sanitize *sanitize) isSanitizerExplicitlyDisabled(t sanitizerType) bool { | 
|  | 646 | if sanitize == nil { | 
|  | 647 | return false | 
|  | 648 | } | 
|  | 649 |  | 
|  | 650 | sanitizerVal := sanitize.getSanitizerBoolPtr(t) | 
|  | 651 | return sanitizerVal != nil && *sanitizerVal == false | 
|  | 652 | } | 
|  | 653 |  | 
|  | 654 | // There isn't an analog of the method above (ie:isSanitizerExplicitlyEnabled) | 
|  | 655 | // because enabling a sanitizer either directly (via the blueprint) or | 
|  | 656 | // indirectly (via a mutator) sets the bool ptr to true, and you can't | 
|  | 657 | // distinguish between the cases. It isn't needed though - both cases can be | 
|  | 658 | // treated identically. | 
|  | 659 | func (sanitize *sanitize) isSanitizerEnabled(t sanitizerType) bool { | 
|  | 660 | if sanitize == nil { | 
|  | 661 | return false | 
|  | 662 | } | 
|  | 663 |  | 
|  | 664 | sanitizerVal := sanitize.getSanitizerBoolPtr(t) | 
|  | 665 | return sanitizerVal != nil && *sanitizerVal == true | 
|  | 666 | } | 
|  | 667 |  | 
| Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 668 | func isSanitizableDependencyTag(tag blueprint.DependencyTag) bool { | 
|  | 669 | t, ok := tag.(dependencyTag) | 
|  | 670 | return ok && t.library || t == reuseObjTag | 
|  | 671 | } | 
|  | 672 |  | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 673 | // Propagate sanitizer requirements down from binaries | 
| Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 674 | func sanitizerDepsMutator(t sanitizerType) func(android.TopDownMutatorContext) { | 
|  | 675 | return func(mctx android.TopDownMutatorContext) { | 
| Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 676 | if c, ok := mctx.Module().(*Module); ok && c.sanitize.isSanitizerEnabled(t) { | 
| Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 677 | mctx.WalkDeps(func(child, parent android.Module) bool { | 
|  | 678 | if !isSanitizableDependencyTag(mctx.OtherModuleDependencyTag(child)) { | 
|  | 679 | return false | 
|  | 680 | } | 
|  | 681 | if d, ok := child.(*Module); ok && d.sanitize != nil && | 
| Nan Zhang | 0007d81 | 2017-11-07 10:57:05 -0800 | [diff] [blame] | 682 | !Bool(d.sanitize.Properties.Sanitize.Never) && | 
| Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 683 | !d.sanitize.isSanitizerExplicitlyDisabled(t) { | 
| Peter Collingbourne | 8c7e6e2 | 2018-11-19 16:03:58 -0800 | [diff] [blame] | 684 | if t == cfi || t == hwasan || t == scs { | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 685 | if d.static() { | 
|  | 686 | d.sanitize.Properties.SanitizeDep = true | 
|  | 687 | } | 
|  | 688 | } else { | 
| Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 689 | d.sanitize.Properties.SanitizeDep = true | 
|  | 690 | } | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 691 | } | 
| Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 692 | return true | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 693 | }) | 
| Jiyong Park | f97782b | 2019-02-13 20:28:58 +0900 | [diff] [blame] | 694 | } else if sanitizeable, ok := mctx.Module().(Sanitizeable); ok { | 
|  | 695 | // If an APEX module includes a lib which is enabled for a sanitizer T, then | 
|  | 696 | // the APEX module is also enabled for the same sanitizer type. | 
|  | 697 | mctx.VisitDirectDeps(func(child android.Module) { | 
|  | 698 | if c, ok := child.(*Module); ok && c.sanitize.isSanitizerEnabled(t) { | 
|  | 699 | sanitizeable.EnableSanitizer(t.name()) | 
|  | 700 | } | 
|  | 701 | }) | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 702 | } | 
|  | 703 | } | 
|  | 704 | } | 
|  | 705 |  | 
| Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 706 | // Propagate the ubsan minimal runtime dependency when there are integer overflow sanitized static dependencies. | 
| Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 707 | func sanitizerRuntimeDepsMutator(mctx android.TopDownMutatorContext) { | 
|  | 708 | if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil { | 
|  | 709 | mctx.WalkDeps(func(child, parent android.Module) bool { | 
|  | 710 | if !isSanitizableDependencyTag(mctx.OtherModuleDependencyTag(child)) { | 
|  | 711 | return false | 
|  | 712 | } | 
| Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 713 |  | 
| Colin Cross | 0b90833 | 2019-06-19 23:00:20 -0700 | [diff] [blame] | 714 | if d, ok := child.(*Module); ok && d.static() && d.sanitize != nil { | 
| Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 715 | if enableMinimalRuntime(d.sanitize) { | 
|  | 716 | // If a static dependency is built with the minimal runtime, | 
|  | 717 | // make sure we include the ubsan minimal runtime. | 
|  | 718 | c.sanitize.Properties.MinimalRuntimeDep = true | 
|  | 719 | } else if Bool(d.sanitize.Properties.Sanitize.Diag.Integer_overflow) || | 
|  | 720 | len(d.sanitize.Properties.Sanitize.Diag.Misc_undefined) > 0 { | 
|  | 721 | // If a static dependency runs with full ubsan diagnostics, | 
|  | 722 | // make sure we include the ubsan runtime. | 
|  | 723 | c.sanitize.Properties.UbsanRuntimeDep = true | 
| Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 724 | } | 
| Colin Cross | 0b90833 | 2019-06-19 23:00:20 -0700 | [diff] [blame] | 725 |  | 
|  | 726 | if c.sanitize.Properties.MinimalRuntimeDep && | 
|  | 727 | c.sanitize.Properties.UbsanRuntimeDep { | 
|  | 728 | // both flags that this mutator might set are true, so don't bother recursing | 
|  | 729 | return false | 
|  | 730 | } | 
|  | 731 |  | 
|  | 732 | return true | 
|  | 733 | } else { | 
|  | 734 | return false | 
| Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 735 | } | 
| Colin Cross | 6b75360 | 2018-06-21 13:03:07 -0700 | [diff] [blame] | 736 | }) | 
| Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 737 | } | 
|  | 738 | } | 
|  | 739 |  | 
| Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 740 | // Add the dependency to the runtime library for each of the sanitizer variants | 
|  | 741 | func sanitizerRuntimeMutator(mctx android.BottomUpMutatorContext) { | 
| Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 742 | if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil { | 
| Pirama Arumuga Nainar | 6aa2102 | 2019-01-25 00:20:35 +0000 | [diff] [blame] | 743 | if !c.Enabled() { | 
|  | 744 | return | 
|  | 745 | } | 
| Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 746 | var sanitizers []string | 
|  | 747 | var diagSanitizers []string | 
|  | 748 |  | 
|  | 749 | if Bool(c.sanitize.Properties.Sanitize.All_undefined) { | 
|  | 750 | sanitizers = append(sanitizers, "undefined") | 
|  | 751 | } else { | 
|  | 752 | if Bool(c.sanitize.Properties.Sanitize.Undefined) { | 
|  | 753 | sanitizers = append(sanitizers, | 
|  | 754 | "bool", | 
|  | 755 | "integer-divide-by-zero", | 
|  | 756 | "return", | 
|  | 757 | "returns-nonnull-attribute", | 
|  | 758 | "shift-exponent", | 
|  | 759 | "unreachable", | 
|  | 760 | "vla-bound", | 
|  | 761 | // TODO(danalbert): The following checks currently have compiler performance issues. | 
|  | 762 | //"alignment", | 
|  | 763 | //"bounds", | 
|  | 764 | //"enum", | 
|  | 765 | //"float-cast-overflow", | 
|  | 766 | //"float-divide-by-zero", | 
|  | 767 | //"nonnull-attribute", | 
|  | 768 | //"null", | 
|  | 769 | //"shift-base", | 
|  | 770 | //"signed-integer-overflow", | 
|  | 771 | // TODO(danalbert): Fix UB in libc++'s __tree so we can turn this on. | 
|  | 772 | // https://llvm.org/PR19302 | 
|  | 773 | // http://reviews.llvm.org/D6974 | 
|  | 774 | // "object-size", | 
|  | 775 | ) | 
|  | 776 | } | 
|  | 777 | sanitizers = append(sanitizers, c.sanitize.Properties.Sanitize.Misc_undefined...) | 
|  | 778 | } | 
|  | 779 |  | 
|  | 780 | if Bool(c.sanitize.Properties.Sanitize.Diag.Undefined) { | 
|  | 781 | diagSanitizers = append(diagSanitizers, "undefined") | 
|  | 782 | } | 
|  | 783 |  | 
|  | 784 | diagSanitizers = append(diagSanitizers, c.sanitize.Properties.Sanitize.Diag.Misc_undefined...) | 
|  | 785 |  | 
|  | 786 | if Bool(c.sanitize.Properties.Sanitize.Address) { | 
|  | 787 | sanitizers = append(sanitizers, "address") | 
|  | 788 | diagSanitizers = append(diagSanitizers, "address") | 
|  | 789 | } | 
|  | 790 |  | 
|  | 791 | if Bool(c.sanitize.Properties.Sanitize.Hwaddress) { | 
|  | 792 | sanitizers = append(sanitizers, "hwaddress") | 
|  | 793 | } | 
|  | 794 |  | 
|  | 795 | if Bool(c.sanitize.Properties.Sanitize.Thread) { | 
|  | 796 | sanitizers = append(sanitizers, "thread") | 
|  | 797 | } | 
|  | 798 |  | 
|  | 799 | if Bool(c.sanitize.Properties.Sanitize.Safestack) { | 
|  | 800 | sanitizers = append(sanitizers, "safe-stack") | 
|  | 801 | } | 
|  | 802 |  | 
|  | 803 | if Bool(c.sanitize.Properties.Sanitize.Cfi) { | 
|  | 804 | sanitizers = append(sanitizers, "cfi") | 
|  | 805 |  | 
|  | 806 | if Bool(c.sanitize.Properties.Sanitize.Diag.Cfi) { | 
|  | 807 | diagSanitizers = append(diagSanitizers, "cfi") | 
|  | 808 | } | 
|  | 809 | } | 
|  | 810 |  | 
|  | 811 | if Bool(c.sanitize.Properties.Sanitize.Integer_overflow) { | 
|  | 812 | sanitizers = append(sanitizers, "unsigned-integer-overflow") | 
|  | 813 | sanitizers = append(sanitizers, "signed-integer-overflow") | 
|  | 814 | if Bool(c.sanitize.Properties.Sanitize.Diag.Integer_overflow) { | 
|  | 815 | diagSanitizers = append(diagSanitizers, "unsigned-integer-overflow") | 
|  | 816 | diagSanitizers = append(diagSanitizers, "signed-integer-overflow") | 
|  | 817 | } | 
|  | 818 | } | 
|  | 819 |  | 
|  | 820 | if Bool(c.sanitize.Properties.Sanitize.Scudo) { | 
|  | 821 | sanitizers = append(sanitizers, "scudo") | 
|  | 822 | } | 
|  | 823 |  | 
|  | 824 | if Bool(c.sanitize.Properties.Sanitize.Scs) { | 
|  | 825 | sanitizers = append(sanitizers, "shadow-call-stack") | 
|  | 826 | } | 
|  | 827 |  | 
| Mitch Phillips | bfeade6 | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 828 | if Bool(c.sanitize.Properties.Sanitize.Fuzzer) { | 
|  | 829 | sanitizers = append(sanitizers, "fuzzer-no-link") | 
|  | 830 | } | 
|  | 831 |  | 
| Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 832 | // Save the list of sanitizers. These will be used again when generating | 
|  | 833 | // the build rules (for Cflags, etc.) | 
|  | 834 | c.sanitize.Properties.Sanitizers = sanitizers | 
|  | 835 | c.sanitize.Properties.DiagSanitizers = diagSanitizers | 
|  | 836 |  | 
|  | 837 | // Determine the runtime library required | 
|  | 838 | runtimeLibrary := "" | 
|  | 839 | toolchain := c.toolchain(mctx) | 
|  | 840 | if Bool(c.sanitize.Properties.Sanitize.Address) { | 
|  | 841 | runtimeLibrary = config.AddressSanitizerRuntimeLibrary(toolchain) | 
|  | 842 | } else if Bool(c.sanitize.Properties.Sanitize.Hwaddress) { | 
|  | 843 | if c.staticBinary() { | 
|  | 844 | runtimeLibrary = config.HWAddressSanitizerStaticLibrary(toolchain) | 
|  | 845 | } else { | 
|  | 846 | runtimeLibrary = config.HWAddressSanitizerRuntimeLibrary(toolchain) | 
|  | 847 | } | 
|  | 848 | } else if Bool(c.sanitize.Properties.Sanitize.Thread) { | 
|  | 849 | runtimeLibrary = config.ThreadSanitizerRuntimeLibrary(toolchain) | 
|  | 850 | } else if Bool(c.sanitize.Properties.Sanitize.Scudo) { | 
|  | 851 | if len(diagSanitizers) == 0 && !c.sanitize.Properties.UbsanRuntimeDep { | 
|  | 852 | runtimeLibrary = config.ScudoMinimalRuntimeLibrary(toolchain) | 
|  | 853 | } else { | 
|  | 854 | runtimeLibrary = config.ScudoRuntimeLibrary(toolchain) | 
|  | 855 | } | 
|  | 856 | } else if len(diagSanitizers) > 0 || c.sanitize.Properties.UbsanRuntimeDep { | 
|  | 857 | runtimeLibrary = config.UndefinedBehaviorSanitizerRuntimeLibrary(toolchain) | 
|  | 858 | } | 
|  | 859 |  | 
|  | 860 | if mctx.Device() && runtimeLibrary != "" { | 
| Inseob Kim | 9516ee9 | 2019-05-09 10:56:13 +0900 | [diff] [blame] | 861 | if inList(runtimeLibrary, *llndkLibraries(mctx.Config())) && !c.static() && c.useVndk() { | 
| Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 862 | runtimeLibrary = runtimeLibrary + llndkLibrarySuffix | 
|  | 863 | } | 
|  | 864 |  | 
|  | 865 | // Adding dependency to the runtime library. We are using *FarVariation* | 
|  | 866 | // because the runtime libraries themselves are not mutated by sanitizer | 
|  | 867 | // mutators and thus don't have sanitizer variants whereas this module | 
|  | 868 | // has been already mutated. | 
|  | 869 | // | 
|  | 870 | // Note that by adding dependency with {static|shared}DepTag, the lib is | 
|  | 871 | // added to libFlags and LOCAL_SHARED_LIBRARIES by cc.Module | 
|  | 872 | if c.staticBinary() { | 
|  | 873 | // static executable gets static runtime libs | 
|  | 874 | mctx.AddFarVariationDependencies([]blueprint.Variation{ | 
|  | 875 | {Mutator: "link", Variation: "static"}, | 
| Jiyong Park | 3b1746a | 2019-01-29 11:15:04 +0900 | [diff] [blame] | 876 | {Mutator: "image", Variation: c.imageVariation()}, | 
| Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 877 | {Mutator: "arch", Variation: mctx.Target().String()}, | 
|  | 878 | }, staticDepTag, runtimeLibrary) | 
| Jiyong Park | 1d1119f | 2019-07-29 21:27:18 +0900 | [diff] [blame] | 879 | } else if !c.static() && !c.header() { | 
| Jiyong Park | 3b1746a | 2019-01-29 11:15:04 +0900 | [diff] [blame] | 880 | // dynamic executable and shared libs get shared runtime libs | 
| Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 881 | mctx.AddFarVariationDependencies([]blueprint.Variation{ | 
|  | 882 | {Mutator: "link", Variation: "shared"}, | 
| Jiyong Park | 3b1746a | 2019-01-29 11:15:04 +0900 | [diff] [blame] | 883 | {Mutator: "image", Variation: c.imageVariation()}, | 
| Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 884 | {Mutator: "arch", Variation: mctx.Target().String()}, | 
| Jiyong Park | 64a44f2 | 2019-01-18 14:37:08 +0900 | [diff] [blame] | 885 | }, earlySharedDepTag, runtimeLibrary) | 
| Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 886 | } | 
|  | 887 | // static lib does not have dependency to the runtime library. The | 
|  | 888 | // dependency will be added to the executables or shared libs using | 
|  | 889 | // the static lib. | 
|  | 890 | } | 
|  | 891 | } | 
|  | 892 | } | 
|  | 893 |  | 
|  | 894 | type Sanitizeable interface { | 
|  | 895 | android.Module | 
| Jiyong Park | 388ef3f | 2019-01-28 19:47:32 +0900 | [diff] [blame] | 896 | IsSanitizerEnabled(ctx android.BaseModuleContext, sanitizerName string) bool | 
| Jiyong Park | f97782b | 2019-02-13 20:28:58 +0900 | [diff] [blame] | 897 | EnableSanitizer(sanitizerName string) | 
| Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 898 | } | 
|  | 899 |  | 
| Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 900 | // Create sanitized variants for modules that need them | 
| Colin Cross | 635c3b0 | 2016-05-18 15:37:25 -0700 | [diff] [blame] | 901 | func sanitizerMutator(t sanitizerType) func(android.BottomUpMutatorContext) { | 
|  | 902 | return func(mctx android.BottomUpMutatorContext) { | 
| Vishwath Mohan | e615345 | 2017-08-11 00:52:44 +0000 | [diff] [blame] | 903 | if c, ok := mctx.Module().(*Module); ok && c.sanitize != nil { | 
| Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 904 | if c.isDependencyRoot() && c.sanitize.isSanitizerEnabled(t) { | 
| Jiyong Park | 8222663 | 2019-02-01 10:50:50 +0900 | [diff] [blame] | 905 | modules := mctx.CreateVariations(t.variationName()) | 
| Colin Cross | 30d5f51 | 2016-05-03 18:02:42 -0700 | [diff] [blame] | 906 | modules[0].(*Module).sanitize.SetSanitizer(t, true) | 
| Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 907 | } else if c.sanitize.isSanitizerEnabled(t) || c.sanitize.Properties.SanitizeDep { | 
| Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 908 | isSanitizerEnabled := c.sanitize.isSanitizerEnabled(t) | 
| Jiyong Park | 1d1119f | 2019-07-29 21:27:18 +0900 | [diff] [blame] | 909 | if mctx.Device() && t.incompatibleWithCfi() { | 
|  | 910 | // TODO: Make sure that cfi mutator runs "after" any of the sanitizers that | 
|  | 911 | // are incompatible with cfi | 
|  | 912 | c.sanitize.SetSanitizer(cfi, false) | 
|  | 913 | } | 
|  | 914 | if c.static() || c.header() || t == asan || t == fuzzer { | 
|  | 915 | // Static and header libs are split into non-sanitized and sanitized variants. | 
|  | 916 | // Shared libs are not split. However, for asan and fuzzer, we split even for shared | 
|  | 917 | // libs because a library sanitized for asan/fuzzer can't be linked from a library | 
|  | 918 | // that isn't sanitized for asan/fuzzer. | 
|  | 919 | // | 
|  | 920 | // Note for defaultVariation: since we don't split for shared libs but for static/header | 
|  | 921 | // libs, it is possible for the sanitized variant of a static/header lib to depend | 
|  | 922 | // on non-sanitized variant of a shared lib. Such unfulfilled variation causes an | 
|  | 923 | // error when the module is split. defaultVariation is the name of the variation that | 
|  | 924 | // will be used when such a dangling dependency occurs during the split of the current | 
|  | 925 | // module. By setting it to the name of the sanitized variation, the dangling dependency | 
|  | 926 | // is redirected to the sanitized variant of the dependent module. | 
|  | 927 | defaultVariation := t.variationName() | 
|  | 928 | mctx.SetDefaultDependencyVariation(&defaultVariation) | 
|  | 929 | modules := mctx.CreateVariations("", t.variationName()) | 
|  | 930 | modules[0].(*Module).sanitize.SetSanitizer(t, false) | 
|  | 931 | modules[1].(*Module).sanitize.SetSanitizer(t, true) | 
|  | 932 | modules[0].(*Module).sanitize.Properties.SanitizeDep = false | 
|  | 933 | modules[1].(*Module).sanitize.Properties.SanitizeDep = false | 
| Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 934 |  | 
| Jiyong Park | 1d1119f | 2019-07-29 21:27:18 +0900 | [diff] [blame] | 935 | // For cfi/scs/hwasan, we can export both sanitized and un-sanitized variants | 
|  | 936 | // to Make, because the sanitized version has a different suffix in name. | 
|  | 937 | // For other types of sanitizers, suppress the variation that is disabled. | 
|  | 938 | if t != cfi && t != scs && t != hwasan { | 
|  | 939 | if isSanitizerEnabled { | 
|  | 940 | modules[0].(*Module).Properties.PreventInstall = true | 
|  | 941 | modules[0].(*Module).Properties.HideFromMake = true | 
|  | 942 | } else { | 
|  | 943 | modules[1].(*Module).Properties.PreventInstall = true | 
|  | 944 | modules[1].(*Module).Properties.HideFromMake = true | 
|  | 945 | } | 
|  | 946 | } | 
| Vishwath Mohan | b743e9c | 2017-11-01 09:20:21 +0000 | [diff] [blame] | 947 |  | 
| Jiyong Park | 1d1119f | 2019-07-29 21:27:18 +0900 | [diff] [blame] | 948 | // Export the static lib name to make | 
| Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 949 | if c.static() { | 
| Jiyong Park | 1d1119f | 2019-07-29 21:27:18 +0900 | [diff] [blame] | 950 | if t == cfi { | 
|  | 951 | appendStringSync(c.Name(), cfiStaticLibs(mctx.Config()), &cfiStaticLibsMutex) | 
|  | 952 | } else if t == hwasan { | 
|  | 953 | if c.useVndk() { | 
|  | 954 | appendStringSync(c.Name(), hwasanVendorStaticLibs(mctx.Config()), | 
|  | 955 | &hwasanStaticLibsMutex) | 
| Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 956 | } else { | 
| Jiyong Park | 1d1119f | 2019-07-29 21:27:18 +0900 | [diff] [blame] | 957 | appendStringSync(c.Name(), hwasanStaticLibs(mctx.Config()), | 
|  | 958 | &hwasanStaticLibsMutex) | 
| Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 959 | } | 
| Jiyong Park | 1d1119f | 2019-07-29 21:27:18 +0900 | [diff] [blame] | 960 | } | 
|  | 961 | } | 
|  | 962 | } else { | 
|  | 963 | // Shared libs are not split. Only the sanitized variant is created. | 
|  | 964 | modules := mctx.CreateVariations(t.variationName()) | 
|  | 965 | modules[0].(*Module).sanitize.SetSanitizer(t, true) | 
|  | 966 | modules[0].(*Module).sanitize.Properties.SanitizeDep = false | 
| Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 967 |  | 
| Jiyong Park | 1d1119f | 2019-07-29 21:27:18 +0900 | [diff] [blame] | 968 | // locate the asan libraries under /data/asan | 
|  | 969 | if mctx.Device() && t == asan && isSanitizerEnabled { | 
|  | 970 | modules[0].(*Module).sanitize.Properties.InSanitizerDir = true | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 971 | } | 
| Vishwath Mohan | e21fe42 | 2017-11-01 19:42:45 -0700 | [diff] [blame] | 972 | } | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 973 | } | 
|  | 974 | c.sanitize.Properties.SanitizeDep = false | 
| Jiyong Park | 8222663 | 2019-02-01 10:50:50 +0900 | [diff] [blame] | 975 | } else if sanitizeable, ok := mctx.Module().(Sanitizeable); ok && sanitizeable.IsSanitizerEnabled(mctx, t.name()) { | 
| Jiyong Park | 379de2f | 2018-12-19 02:47:14 +0900 | [diff] [blame] | 976 | // APEX modules fall here | 
| Jiyong Park | 8222663 | 2019-02-01 10:50:50 +0900 | [diff] [blame] | 977 | mctx.CreateVariations(t.variationName()) | 
| Colin Cross | 16b2349 | 2016-01-06 14:41:07 -0800 | [diff] [blame] | 978 | } | 
|  | 979 | } | 
|  | 980 | } | 
| Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 981 |  | 
| Colin Cross | 571cccf | 2019-02-04 11:22:08 -0800 | [diff] [blame] | 982 | var cfiStaticLibsKey = android.NewOnceKey("cfiStaticLibs") | 
|  | 983 |  | 
| Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 984 | func cfiStaticLibs(config android.Config) *[]string { | 
| Colin Cross | 571cccf | 2019-02-04 11:22:08 -0800 | [diff] [blame] | 985 | return config.Once(cfiStaticLibsKey, func() interface{} { | 
| Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 986 | return &[]string{} | 
|  | 987 | }).(*[]string) | 
|  | 988 | } | 
|  | 989 |  | 
| Colin Cross | 571cccf | 2019-02-04 11:22:08 -0800 | [diff] [blame] | 990 | var hwasanStaticLibsKey = android.NewOnceKey("hwasanStaticLibs") | 
|  | 991 |  | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 992 | func hwasanStaticLibs(config android.Config) *[]string { | 
| Colin Cross | 571cccf | 2019-02-04 11:22:08 -0800 | [diff] [blame] | 993 | return config.Once(hwasanStaticLibsKey, func() interface{} { | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 994 | return &[]string{} | 
|  | 995 | }).(*[]string) | 
|  | 996 | } | 
|  | 997 |  | 
| Colin Cross | 571cccf | 2019-02-04 11:22:08 -0800 | [diff] [blame] | 998 | var hwasanVendorStaticLibsKey = android.NewOnceKey("hwasanVendorStaticLibs") | 
|  | 999 |  | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 1000 | func hwasanVendorStaticLibs(config android.Config) *[]string { | 
| Colin Cross | 571cccf | 2019-02-04 11:22:08 -0800 | [diff] [blame] | 1001 | return config.Once(hwasanVendorStaticLibsKey, func() interface{} { | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 1002 | return &[]string{} | 
|  | 1003 | }).(*[]string) | 
|  | 1004 | } | 
|  | 1005 |  | 
| Jiyong Park | 1d1119f | 2019-07-29 21:27:18 +0900 | [diff] [blame] | 1006 | func appendStringSync(item string, list *[]string, mutex *sync.Mutex) { | 
|  | 1007 | mutex.Lock() | 
|  | 1008 | *list = append(*list, item) | 
|  | 1009 | mutex.Unlock() | 
|  | 1010 | } | 
|  | 1011 |  | 
| Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 1012 | func enableMinimalRuntime(sanitize *sanitize) bool { | 
|  | 1013 | if !Bool(sanitize.Properties.Sanitize.Address) && | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 1014 | !Bool(sanitize.Properties.Sanitize.Hwaddress) && | 
| Mitch Phillips | bfeade6 | 2019-05-01 14:42:05 -0700 | [diff] [blame] | 1015 | !Bool(sanitize.Properties.Sanitize.Fuzzer) && | 
| Ivan Lozano | 30c5db2 | 2018-02-21 15:49:20 -0800 | [diff] [blame] | 1016 | (Bool(sanitize.Properties.Sanitize.Integer_overflow) || | 
|  | 1017 | len(sanitize.Properties.Sanitize.Misc_undefined) > 0) && | 
|  | 1018 | !(Bool(sanitize.Properties.Sanitize.Diag.Integer_overflow) || | 
|  | 1019 | Bool(sanitize.Properties.Sanitize.Diag.Cfi) || | 
|  | 1020 | len(sanitize.Properties.Sanitize.Diag.Misc_undefined) > 0) { | 
|  | 1021 | return true | 
|  | 1022 | } | 
|  | 1023 | return false | 
|  | 1024 | } | 
|  | 1025 |  | 
| Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 1026 | func cfiMakeVarsProvider(ctx android.MakeVarsContext) { | 
|  | 1027 | cfiStaticLibs := cfiStaticLibs(ctx.Config()) | 
| Jeff Gaston | 7276539 | 2017-11-28 16:37:53 -0800 | [diff] [blame] | 1028 | sort.Strings(*cfiStaticLibs) | 
| Vishwath Mohan | e712879 | 2017-11-17 11:08:10 -0800 | [diff] [blame] | 1029 | ctx.Strict("SOONG_CFI_STATIC_LIBRARIES", strings.Join(*cfiStaticLibs, " ")) | 
|  | 1030 | } | 
| Evgenii Stepanov | d97a6e9 | 2018-08-02 16:19:13 -0700 | [diff] [blame] | 1031 |  | 
|  | 1032 | func hwasanMakeVarsProvider(ctx android.MakeVarsContext) { | 
|  | 1033 | hwasanStaticLibs := hwasanStaticLibs(ctx.Config()) | 
|  | 1034 | sort.Strings(*hwasanStaticLibs) | 
|  | 1035 | ctx.Strict("SOONG_HWASAN_STATIC_LIBRARIES", strings.Join(*hwasanStaticLibs, " ")) | 
|  | 1036 |  | 
|  | 1037 | hwasanVendorStaticLibs := hwasanVendorStaticLibs(ctx.Config()) | 
|  | 1038 | sort.Strings(*hwasanVendorStaticLibs) | 
|  | 1039 | ctx.Strict("SOONG_HWASAN_VENDOR_STATIC_LIBRARIES", strings.Join(*hwasanVendorStaticLibs, " ")) | 
|  | 1040 | } |