blob: 134f1710b6fafec13c9fccf81f49eeee89a48071 [file] [log] [blame]
Colin Cross3bc7ffa2017-11-22 16:19:37 -08001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
Colin Crossd09b0b62018-04-18 11:06:47 -070018 "fmt"
Colin Crossa4f08812018-10-02 22:03:40 -070019 "path/filepath"
Colin Cross3bc7ffa2017-11-22 16:19:37 -080020 "reflect"
Jaewoong Junga5e5abc2019-04-26 14:31:50 -070021 "regexp"
Colin Crossb69301e2017-12-01 10:48:26 -080022 "sort"
Colin Crossd09b0b62018-04-18 11:06:47 -070023 "strings"
Colin Cross3bc7ffa2017-11-22 16:19:37 -080024 "testing"
Jaewoong Junga5e5abc2019-04-26 14:31:50 -070025
26 "github.com/google/blueprint/proptools"
27
28 "android/soong/android"
29 "android/soong/cc"
Colin Cross3bc7ffa2017-11-22 16:19:37 -080030)
31
32var (
33 resourceFiles = []string{
34 "res/layout/layout.xml",
35 "res/values/strings.xml",
36 "res/values-en-rUS/strings.xml",
37 }
38
39 compiledResourceFiles = []string{
40 "aapt2/res/layout_layout.xml.flat",
41 "aapt2/res/values_strings.arsc.flat",
42 "aapt2/res/values-en-rUS_strings.arsc.flat",
43 }
44)
45
Colin Cross98be1bb2019-12-13 20:41:13 -080046func testAppConfig(env map[string]string, bp string, fs map[string][]byte) android.Config {
Colin Cross527012a2017-11-30 22:56:16 -080047 appFS := map[string][]byte{}
48 for k, v := range fs {
49 appFS[k] = v
Colin Cross3bc7ffa2017-11-22 16:19:37 -080050 }
51
Colin Cross527012a2017-11-30 22:56:16 -080052 for _, file := range resourceFiles {
53 appFS[file] = nil
54 }
55
Colin Cross98be1bb2019-12-13 20:41:13 -080056 return testConfig(env, bp, appFS)
Colin Cross527012a2017-11-30 22:56:16 -080057}
58
59func testApp(t *testing.T, bp string) *android.TestContext {
Colin Cross98be1bb2019-12-13 20:41:13 -080060 config := testAppConfig(nil, bp, nil)
Colin Cross527012a2017-11-30 22:56:16 -080061
Colin Cross98be1bb2019-12-13 20:41:13 -080062 ctx := testContext()
Colin Cross527012a2017-11-30 22:56:16 -080063
64 run(t, ctx, config)
65
66 return ctx
Colin Cross3bc7ffa2017-11-22 16:19:37 -080067}
68
69func TestApp(t *testing.T) {
Colin Crossa97c5d32018-03-28 14:58:31 -070070 for _, moduleType := range []string{"android_app", "android_library"} {
71 t.Run(moduleType, func(t *testing.T) {
72 ctx := testApp(t, moduleType+` {
73 name: "foo",
74 srcs: ["a.java"],
Jeongik Cha538c0d02019-07-11 15:54:27 +090075 sdk_version: "current"
Colin Crossa97c5d32018-03-28 14:58:31 -070076 }
77 `)
Colin Cross3bc7ffa2017-11-22 16:19:37 -080078
Colin Crossa97c5d32018-03-28 14:58:31 -070079 foo := ctx.ModuleForTests("foo", "android_common")
Colin Cross3bc7ffa2017-11-22 16:19:37 -080080
Colin Cross31656952018-05-24 16:11:20 -070081 var expectedLinkImplicits []string
82
83 manifestFixer := foo.Output("manifest_fixer/AndroidManifest.xml")
84 expectedLinkImplicits = append(expectedLinkImplicits, manifestFixer.Output.String())
Colin Cross3bc7ffa2017-11-22 16:19:37 -080085
Colin Crossa97c5d32018-03-28 14:58:31 -070086 frameworkRes := ctx.ModuleForTests("framework-res", "android_common")
87 expectedLinkImplicits = append(expectedLinkImplicits,
88 frameworkRes.Output("package-res.apk").Output.String())
Colin Cross3bc7ffa2017-11-22 16:19:37 -080089
Colin Crossa97c5d32018-03-28 14:58:31 -070090 // Test the mapping from input files to compiled output file names
91 compile := foo.Output(compiledResourceFiles[0])
92 if !reflect.DeepEqual(resourceFiles, compile.Inputs.Strings()) {
93 t.Errorf("expected aapt2 compile inputs expected:\n %#v\n got:\n %#v",
94 resourceFiles, compile.Inputs.Strings())
95 }
Colin Crossb69301e2017-12-01 10:48:26 -080096
Colin Crossa97c5d32018-03-28 14:58:31 -070097 compiledResourceOutputs := compile.Outputs.Strings()
98 sort.Strings(compiledResourceOutputs)
Colin Crossb69301e2017-12-01 10:48:26 -080099
Colin Crossa97c5d32018-03-28 14:58:31 -0700100 expectedLinkImplicits = append(expectedLinkImplicits, compiledResourceOutputs...)
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800101
Colin Crossa97c5d32018-03-28 14:58:31 -0700102 list := foo.Output("aapt2/res.list")
103 expectedLinkImplicits = append(expectedLinkImplicits, list.Output.String())
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800104
Colin Crossa97c5d32018-03-28 14:58:31 -0700105 // Check that the link rule uses
106 res := ctx.ModuleForTests("foo", "android_common").Output("package-res.apk")
107 if !reflect.DeepEqual(expectedLinkImplicits, res.Implicits.Strings()) {
108 t.Errorf("expected aapt2 link implicits expected:\n %#v\n got:\n %#v",
109 expectedLinkImplicits, res.Implicits.Strings())
110 }
111 })
Colin Cross3bc7ffa2017-11-22 16:19:37 -0800112 }
113}
Colin Cross890ff552017-11-30 20:13:19 -0800114
Colin Crosse560c4a2019-03-19 16:03:11 -0700115func TestAppSplits(t *testing.T) {
116 ctx := testApp(t, `
117 android_app {
118 name: "foo",
119 srcs: ["a.java"],
120 package_splits: ["v4", "v7,hdpi"],
Jeongik Cha538c0d02019-07-11 15:54:27 +0900121 sdk_version: "current"
Colin Crosse560c4a2019-03-19 16:03:11 -0700122 }`)
123
124 foo := ctx.ModuleForTests("foo", "android_common")
125
126 expectedOutputs := []string{
127 filepath.Join(buildDir, ".intermediates/foo/android_common/foo.apk"),
128 filepath.Join(buildDir, ".intermediates/foo/android_common/foo_v4.apk"),
129 filepath.Join(buildDir, ".intermediates/foo/android_common/foo_v7_hdpi.apk"),
130 }
131 for _, expectedOutput := range expectedOutputs {
132 foo.Output(expectedOutput)
133 }
134
Colin Cross41955e82019-05-29 14:40:35 -0700135 outputFiles, err := foo.Module().(*AndroidApp).OutputFiles("")
136 if err != nil {
137 t.Fatal(err)
138 }
139 if g, w := outputFiles.Strings(), expectedOutputs; !reflect.DeepEqual(g, w) {
140 t.Errorf(`want OutputFiles("") = %q, got %q`, w, g)
Colin Crosse560c4a2019-03-19 16:03:11 -0700141 }
142}
143
Jeongik Cha538c0d02019-07-11 15:54:27 +0900144func TestPlatformAPIs(t *testing.T) {
145 testJava(t, `
146 android_app {
147 name: "foo",
148 srcs: ["a.java"],
149 platform_apis: true,
150 }
151 `)
152
153 testJava(t, `
154 android_app {
155 name: "foo",
156 srcs: ["a.java"],
157 sdk_version: "current",
158 }
159 `)
160
161 testJavaError(t, "platform_apis must be true when sdk_version is empty.", `
162 android_app {
163 name: "bar",
164 srcs: ["b.java"],
165 }
166 `)
167
168 testJavaError(t, "platform_apis must be false when sdk_version is not empty.", `
169 android_app {
170 name: "bar",
171 srcs: ["b.java"],
172 sdk_version: "system_current",
173 platform_apis: true,
174 }
175 `)
176}
177
Jeongik Chae403e9e2019-12-07 00:16:24 +0900178func TestAndroidAppLinkType(t *testing.T) {
179 testJava(t, `
180 android_app {
181 name: "foo",
182 srcs: ["a.java"],
183 libs: ["bar"],
184 static_libs: ["baz"],
185 platform_apis: true,
186 }
187
188 java_library {
189 name: "bar",
190 sdk_version: "current",
191 srcs: ["b.java"],
192 }
193
194 android_library {
195 name: "baz",
196 sdk_version: "system_current",
197 srcs: ["c.java"],
198 }
199 `)
200
201 testJavaError(t, "Adjust sdk_version: property of the source or target module so that target module is built with the same or smaller API set than the source.", `
202 android_app {
203 name: "foo",
204 srcs: ["a.java"],
205 libs: ["bar"],
206 sdk_version: "current",
207 static_libs: ["baz"],
208 }
209
210 java_library {
211 name: "bar",
212 sdk_version: "current",
213 srcs: ["b.java"],
214 }
215
216 android_library {
217 name: "baz",
218 sdk_version: "system_current",
219 srcs: ["c.java"],
220 }
221 `)
222
223 testJava(t, `
224 android_app {
225 name: "foo",
226 srcs: ["a.java"],
227 libs: ["bar"],
228 sdk_version: "system_current",
229 static_libs: ["baz"],
230 }
231
232 java_library {
233 name: "bar",
234 sdk_version: "current",
235 srcs: ["b.java"],
236 }
237
238 android_library {
239 name: "baz",
240 sdk_version: "system_current",
241 srcs: ["c.java"],
242 }
243 `)
244
245 testJavaError(t, "Adjust sdk_version: property of the source or target module so that target module is built with the same or smaller API set than the source.", `
246 android_app {
247 name: "foo",
248 srcs: ["a.java"],
249 libs: ["bar"],
250 sdk_version: "system_current",
251 static_libs: ["baz"],
252 }
253
254 java_library {
255 name: "bar",
256 sdk_version: "current",
257 srcs: ["b.java"],
258 }
259
260 android_library {
261 name: "baz",
262 srcs: ["c.java"],
263 }
264 `)
265}
266
Artur Satayeve5ac15a2020-04-08 19:09:30 +0100267func TestUpdatableApps(t *testing.T) {
268 testCases := []struct {
269 name string
270 bp string
271 expectedError string
272 }{
273 {
274 name: "Stable public SDK",
275 bp: `android_app {
276 name: "foo",
277 srcs: ["a.java"],
278 sdk_version: "29",
Artur Satayev11962102020-04-16 13:43:02 +0100279 min_sdk_version: "29",
Artur Satayeve5ac15a2020-04-08 19:09:30 +0100280 updatable: true,
281 }`,
282 },
283 {
284 name: "Stable system SDK",
285 bp: `android_app {
286 name: "foo",
287 srcs: ["a.java"],
288 sdk_version: "system_29",
Artur Satayev11962102020-04-16 13:43:02 +0100289 min_sdk_version: "29",
Artur Satayeve5ac15a2020-04-08 19:09:30 +0100290 updatable: true,
291 }`,
292 },
293 {
294 name: "Current public SDK",
295 bp: `android_app {
296 name: "foo",
297 srcs: ["a.java"],
298 sdk_version: "current",
Artur Satayev11962102020-04-16 13:43:02 +0100299 min_sdk_version: "29",
Artur Satayeve5ac15a2020-04-08 19:09:30 +0100300 updatable: true,
301 }`,
302 },
303 {
304 name: "Current system SDK",
305 bp: `android_app {
306 name: "foo",
307 srcs: ["a.java"],
308 sdk_version: "system_current",
Artur Satayev11962102020-04-16 13:43:02 +0100309 min_sdk_version: "29",
Artur Satayeve5ac15a2020-04-08 19:09:30 +0100310 updatable: true,
311 }`,
312 },
313 {
314 name: "Current module SDK",
315 bp: `android_app {
316 name: "foo",
317 srcs: ["a.java"],
318 sdk_version: "module_current",
Artur Satayev11962102020-04-16 13:43:02 +0100319 min_sdk_version: "29",
Artur Satayeve5ac15a2020-04-08 19:09:30 +0100320 updatable: true,
321 }`,
322 },
323 {
324 name: "Current core SDK",
325 bp: `android_app {
326 name: "foo",
327 srcs: ["a.java"],
328 sdk_version: "core_current",
Artur Satayev11962102020-04-16 13:43:02 +0100329 min_sdk_version: "29",
Artur Satayeve5ac15a2020-04-08 19:09:30 +0100330 updatable: true,
331 }`,
332 },
333 {
334 name: "No Platform APIs",
335 bp: `android_app {
336 name: "foo",
337 srcs: ["a.java"],
338 platform_apis: true,
Artur Satayev11962102020-04-16 13:43:02 +0100339 min_sdk_version: "29",
Artur Satayeve5ac15a2020-04-08 19:09:30 +0100340 updatable: true,
341 }`,
342 expectedError: "Updatable apps must use stable SDKs",
343 },
344 {
345 name: "No Core Platform APIs",
346 bp: `android_app {
347 name: "foo",
348 srcs: ["a.java"],
349 sdk_version: "core_platform",
Artur Satayev11962102020-04-16 13:43:02 +0100350 min_sdk_version: "29",
Artur Satayeve5ac15a2020-04-08 19:09:30 +0100351 updatable: true,
352 }`,
353 expectedError: "Updatable apps must use stable SDKs",
354 },
355 {
356 name: "No unspecified APIs",
357 bp: `android_app {
358 name: "foo",
359 srcs: ["a.java"],
360 updatable: true,
Artur Satayev11962102020-04-16 13:43:02 +0100361 min_sdk_version: "29",
Artur Satayeve5ac15a2020-04-08 19:09:30 +0100362 }`,
363 expectedError: "Updatable apps must use stable SDK",
364 },
Artur Satayev11962102020-04-16 13:43:02 +0100365 {
366 name: "Must specify min_sdk_version",
367 bp: `android_app {
368 name: "app_without_min_sdk_version",
369 srcs: ["a.java"],
370 sdk_version: "29",
371 updatable: true,
372 }`,
373 expectedError: "updatable apps must set min_sdk_version.",
374 },
Artur Satayeve5ac15a2020-04-08 19:09:30 +0100375 }
376
377 for _, test := range testCases {
378 t.Run(test.name, func(t *testing.T) {
379 if test.expectedError == "" {
380 testJava(t, test.bp)
381 } else {
382 testJavaError(t, test.expectedError, test.bp)
383 }
384 })
385 }
386}
387
Colin Cross0ddae7f2019-02-07 15:30:01 -0800388func TestResourceDirs(t *testing.T) {
389 testCases := []struct {
390 name string
391 prop string
392 resources []string
393 }{
394 {
395 name: "no resource_dirs",
396 prop: "",
397 resources: []string{"res/res/values/strings.xml"},
398 },
399 {
400 name: "resource_dirs",
401 prop: `resource_dirs: ["res"]`,
402 resources: []string{"res/res/values/strings.xml"},
403 },
404 {
405 name: "empty resource_dirs",
406 prop: `resource_dirs: []`,
407 resources: nil,
408 },
409 }
410
411 fs := map[string][]byte{
412 "res/res/values/strings.xml": nil,
413 }
414
415 bp := `
416 android_app {
417 name: "foo",
Jeongik Cha538c0d02019-07-11 15:54:27 +0900418 sdk_version: "current",
Colin Cross0ddae7f2019-02-07 15:30:01 -0800419 %s
420 }
421 `
422
423 for _, testCase := range testCases {
424 t.Run(testCase.name, func(t *testing.T) {
Colin Cross98be1bb2019-12-13 20:41:13 -0800425 config := testConfig(nil, fmt.Sprintf(bp, testCase.prop), fs)
426 ctx := testContext()
Colin Cross0ddae7f2019-02-07 15:30:01 -0800427 run(t, ctx, config)
428
429 module := ctx.ModuleForTests("foo", "android_common")
430 resourceList := module.MaybeOutput("aapt2/res.list")
431
432 var resources []string
433 if resourceList.Rule != nil {
434 for _, compiledResource := range resourceList.Inputs.Strings() {
435 resources = append(resources, module.Output(compiledResource).Inputs.Strings()...)
436 }
437 }
438
439 if !reflect.DeepEqual(resources, testCase.resources) {
440 t.Errorf("expected resource files %q, got %q",
441 testCase.resources, resources)
442 }
443 })
444 }
445}
446
Jaewoong Jung6431ca72020-01-15 14:15:10 -0800447func TestLibraryAssets(t *testing.T) {
448 bp := `
449 android_app {
450 name: "foo",
451 sdk_version: "current",
452 static_libs: ["lib1", "lib2", "lib3"],
453 }
454
455 android_library {
456 name: "lib1",
457 sdk_version: "current",
458 asset_dirs: ["assets_a"],
459 }
460
461 android_library {
462 name: "lib2",
463 sdk_version: "current",
464 }
465
466 android_library {
467 name: "lib3",
468 sdk_version: "current",
469 static_libs: ["lib4"],
470 }
471
472 android_library {
473 name: "lib4",
474 sdk_version: "current",
475 asset_dirs: ["assets_b"],
476 }
477 `
478
479 testCases := []struct {
480 name string
481 assetFlag string
482 assetPackages []string
483 }{
484 {
485 name: "foo",
486 // lib1 has its own asset. lib3 doesn't have any, but provides lib4's transitively.
487 assetPackages: []string{
488 buildDir + "/.intermediates/foo/android_common/aapt2/package-res.apk",
489 buildDir + "/.intermediates/lib1/android_common/assets.zip",
490 buildDir + "/.intermediates/lib3/android_common/assets.zip",
491 },
492 },
493 {
494 name: "lib1",
495 assetFlag: "-A assets_a",
496 },
497 {
498 name: "lib2",
499 },
500 {
501 name: "lib3",
502 assetPackages: []string{
503 buildDir + "/.intermediates/lib3/android_common/aapt2/package-res.apk",
504 buildDir + "/.intermediates/lib4/android_common/assets.zip",
505 },
506 },
507 {
508 name: "lib4",
509 assetFlag: "-A assets_b",
510 },
511 }
512 ctx := testApp(t, bp)
513
514 for _, test := range testCases {
515 t.Run(test.name, func(t *testing.T) {
516 m := ctx.ModuleForTests(test.name, "android_common")
517
518 // Check asset flag in aapt2 link flags
519 var aapt2link android.TestingBuildParams
520 if len(test.assetPackages) > 0 {
521 aapt2link = m.Output("aapt2/package-res.apk")
522 } else {
523 aapt2link = m.Output("package-res.apk")
524 }
525 aapt2Flags := aapt2link.Args["flags"]
526 if test.assetFlag != "" {
527 if !strings.Contains(aapt2Flags, test.assetFlag) {
528 t.Errorf("Can't find asset flag %q in aapt2 link flags %q", test.assetFlag, aapt2Flags)
529 }
530 } else {
531 if strings.Contains(aapt2Flags, " -A ") {
532 t.Errorf("aapt2 link flags %q contain unexpected asset flag", aapt2Flags)
533 }
534 }
535
536 // Check asset merge rule.
537 if len(test.assetPackages) > 0 {
538 mergeAssets := m.Output("package-res.apk")
539 if !reflect.DeepEqual(test.assetPackages, mergeAssets.Inputs.Strings()) {
540 t.Errorf("Unexpected mergeAssets inputs: %v, expected: %v",
541 mergeAssets.Inputs.Strings(), test.assetPackages)
542 }
543 }
544 })
545 }
546}
547
Colin Crossbec85302019-02-13 13:15:46 -0800548func TestAndroidResources(t *testing.T) {
Colin Cross5c4791c2019-02-01 11:44:44 -0800549 testCases := []struct {
550 name string
551 enforceRROTargets []string
552 enforceRROExcludedOverlays []string
Colin Crossbec85302019-02-13 13:15:46 -0800553 resourceFiles map[string][]string
Colin Cross5c4791c2019-02-01 11:44:44 -0800554 overlayFiles map[string][]string
555 rroDirs map[string][]string
556 }{
557 {
558 name: "no RRO",
559 enforceRROTargets: nil,
560 enforceRROExcludedOverlays: nil,
Colin Crossbec85302019-02-13 13:15:46 -0800561 resourceFiles: map[string][]string{
562 "foo": nil,
563 "bar": {"bar/res/res/values/strings.xml"},
564 "lib": nil,
565 "lib2": {"lib2/res/res/values/strings.xml"},
566 },
Colin Cross5c4791c2019-02-01 11:44:44 -0800567 overlayFiles: map[string][]string{
Colin Crossbec85302019-02-13 13:15:46 -0800568 "foo": {
569 buildDir + "/.intermediates/lib2/android_common/package-res.apk",
Colin Cross6ed7dea2019-01-31 14:44:30 -0800570 buildDir + "/.intermediates/lib/android_common/package-res.apk",
Anton Hansson53c88442019-03-18 15:53:16 +0000571 buildDir + "/.intermediates/lib3/android_common/package-res.apk",
Colin Cross6ed7dea2019-01-31 14:44:30 -0800572 "foo/res/res/values/strings.xml",
Colin Cross5c4791c2019-02-01 11:44:44 -0800573 "device/vendor/blah/static_overlay/foo/res/values/strings.xml",
574 "device/vendor/blah/overlay/foo/res/values/strings.xml",
Anton Hansson53c88442019-03-18 15:53:16 +0000575 "product/vendor/blah/overlay/foo/res/values/strings.xml",
Colin Cross5c4791c2019-02-01 11:44:44 -0800576 },
Colin Crossbec85302019-02-13 13:15:46 -0800577 "bar": {
Colin Cross5c4791c2019-02-01 11:44:44 -0800578 "device/vendor/blah/static_overlay/bar/res/values/strings.xml",
579 "device/vendor/blah/overlay/bar/res/values/strings.xml",
580 },
Colin Crossbec85302019-02-13 13:15:46 -0800581 "lib": {
582 buildDir + "/.intermediates/lib2/android_common/package-res.apk",
583 "lib/res/res/values/strings.xml",
584 "device/vendor/blah/overlay/lib/res/values/strings.xml",
585 },
Colin Cross5c4791c2019-02-01 11:44:44 -0800586 },
587 rroDirs: map[string][]string{
588 "foo": nil,
589 "bar": nil,
590 },
591 },
592 {
593 name: "enforce RRO on foo",
594 enforceRROTargets: []string{"foo"},
595 enforceRROExcludedOverlays: []string{"device/vendor/blah/static_overlay"},
Colin Crossbec85302019-02-13 13:15:46 -0800596 resourceFiles: map[string][]string{
597 "foo": nil,
598 "bar": {"bar/res/res/values/strings.xml"},
599 "lib": nil,
600 "lib2": {"lib2/res/res/values/strings.xml"},
601 },
Colin Cross5c4791c2019-02-01 11:44:44 -0800602 overlayFiles: map[string][]string{
Colin Crossbec85302019-02-13 13:15:46 -0800603 "foo": {
604 buildDir + "/.intermediates/lib2/android_common/package-res.apk",
Colin Cross6ed7dea2019-01-31 14:44:30 -0800605 buildDir + "/.intermediates/lib/android_common/package-res.apk",
Anton Hansson53c88442019-03-18 15:53:16 +0000606 buildDir + "/.intermediates/lib3/android_common/package-res.apk",
Colin Cross6ed7dea2019-01-31 14:44:30 -0800607 "foo/res/res/values/strings.xml",
608 "device/vendor/blah/static_overlay/foo/res/values/strings.xml",
609 },
Colin Crossbec85302019-02-13 13:15:46 -0800610 "bar": {
Colin Cross5c4791c2019-02-01 11:44:44 -0800611 "device/vendor/blah/static_overlay/bar/res/values/strings.xml",
612 "device/vendor/blah/overlay/bar/res/values/strings.xml",
613 },
Colin Crossbec85302019-02-13 13:15:46 -0800614 "lib": {
615 buildDir + "/.intermediates/lib2/android_common/package-res.apk",
616 "lib/res/res/values/strings.xml",
617 "device/vendor/blah/overlay/lib/res/values/strings.xml",
618 },
Colin Cross5c4791c2019-02-01 11:44:44 -0800619 },
Colin Crossc1c37552019-01-31 11:42:41 -0800620
Colin Cross5c4791c2019-02-01 11:44:44 -0800621 rroDirs: map[string][]string{
Colin Crossbec85302019-02-13 13:15:46 -0800622 "foo": {
Anton Hansson53c88442019-03-18 15:53:16 +0000623 "device:device/vendor/blah/overlay/foo/res",
Colin Crossc1c37552019-01-31 11:42:41 -0800624 // Enforce RRO on "foo" could imply RRO on static dependencies, but for now it doesn't.
625 // "device/vendor/blah/overlay/lib/res",
Anton Hansson53c88442019-03-18 15:53:16 +0000626 "product:product/vendor/blah/overlay/foo/res",
Colin Crossc1c37552019-01-31 11:42:41 -0800627 },
Colin Cross5c4791c2019-02-01 11:44:44 -0800628 "bar": nil,
Colin Crossbec85302019-02-13 13:15:46 -0800629 "lib": nil,
Colin Cross5c4791c2019-02-01 11:44:44 -0800630 },
631 },
632 {
633 name: "enforce RRO on all",
634 enforceRROTargets: []string{"*"},
635 enforceRROExcludedOverlays: []string{
636 // Excluding specific apps/res directories also allowed.
637 "device/vendor/blah/static_overlay/foo",
638 "device/vendor/blah/static_overlay/bar/res",
639 },
Colin Crossbec85302019-02-13 13:15:46 -0800640 resourceFiles: map[string][]string{
641 "foo": nil,
642 "bar": {"bar/res/res/values/strings.xml"},
643 "lib": nil,
644 "lib2": {"lib2/res/res/values/strings.xml"},
645 },
Colin Cross5c4791c2019-02-01 11:44:44 -0800646 overlayFiles: map[string][]string{
Colin Crossbec85302019-02-13 13:15:46 -0800647 "foo": {
648 buildDir + "/.intermediates/lib2/android_common/package-res.apk",
Colin Cross6ed7dea2019-01-31 14:44:30 -0800649 buildDir + "/.intermediates/lib/android_common/package-res.apk",
Anton Hansson53c88442019-03-18 15:53:16 +0000650 buildDir + "/.intermediates/lib3/android_common/package-res.apk",
Colin Cross6ed7dea2019-01-31 14:44:30 -0800651 "foo/res/res/values/strings.xml",
652 "device/vendor/blah/static_overlay/foo/res/values/strings.xml",
653 },
Colin Crossbec85302019-02-13 13:15:46 -0800654 "bar": {"device/vendor/blah/static_overlay/bar/res/values/strings.xml"},
655 "lib": {
656 buildDir + "/.intermediates/lib2/android_common/package-res.apk",
657 "lib/res/res/values/strings.xml",
658 },
Colin Cross5c4791c2019-02-01 11:44:44 -0800659 },
660 rroDirs: map[string][]string{
Colin Crossbec85302019-02-13 13:15:46 -0800661 "foo": {
Anton Hansson53c88442019-03-18 15:53:16 +0000662 "device:device/vendor/blah/overlay/foo/res",
663 "product:product/vendor/blah/overlay/foo/res",
664 // Lib dep comes after the direct deps
665 "device:device/vendor/blah/overlay/lib/res",
Colin Crossc1c37552019-01-31 11:42:41 -0800666 },
Anton Hansson53c88442019-03-18 15:53:16 +0000667 "bar": {"device:device/vendor/blah/overlay/bar/res"},
668 "lib": {"device:device/vendor/blah/overlay/lib/res"},
Colin Cross5c4791c2019-02-01 11:44:44 -0800669 },
670 },
671 }
672
Anton Hansson53c88442019-03-18 15:53:16 +0000673 deviceResourceOverlays := []string{
Colin Cross890ff552017-11-30 20:13:19 -0800674 "device/vendor/blah/overlay",
675 "device/vendor/blah/overlay2",
676 "device/vendor/blah/static_overlay",
677 }
678
Anton Hansson53c88442019-03-18 15:53:16 +0000679 productResourceOverlays := []string{
680 "product/vendor/blah/overlay",
681 }
682
Colin Cross890ff552017-11-30 20:13:19 -0800683 fs := map[string][]byte{
684 "foo/res/res/values/strings.xml": nil,
685 "bar/res/res/values/strings.xml": nil,
Colin Cross6ed7dea2019-01-31 14:44:30 -0800686 "lib/res/res/values/strings.xml": nil,
Colin Crossbec85302019-02-13 13:15:46 -0800687 "lib2/res/res/values/strings.xml": nil,
Colin Cross890ff552017-11-30 20:13:19 -0800688 "device/vendor/blah/overlay/foo/res/values/strings.xml": nil,
689 "device/vendor/blah/overlay/bar/res/values/strings.xml": nil,
Colin Cross6ed7dea2019-01-31 14:44:30 -0800690 "device/vendor/blah/overlay/lib/res/values/strings.xml": nil,
Colin Cross890ff552017-11-30 20:13:19 -0800691 "device/vendor/blah/static_overlay/foo/res/values/strings.xml": nil,
692 "device/vendor/blah/static_overlay/bar/res/values/strings.xml": nil,
693 "device/vendor/blah/overlay2/res/values/strings.xml": nil,
Anton Hansson53c88442019-03-18 15:53:16 +0000694 "product/vendor/blah/overlay/foo/res/values/strings.xml": nil,
Colin Cross890ff552017-11-30 20:13:19 -0800695 }
696
697 bp := `
698 android_app {
699 name: "foo",
Jeongik Cha538c0d02019-07-11 15:54:27 +0900700 sdk_version: "current",
Colin Cross890ff552017-11-30 20:13:19 -0800701 resource_dirs: ["foo/res"],
Anton Hansson53c88442019-03-18 15:53:16 +0000702 static_libs: ["lib", "lib3"],
Colin Cross890ff552017-11-30 20:13:19 -0800703 }
704
705 android_app {
706 name: "bar",
Jeongik Cha538c0d02019-07-11 15:54:27 +0900707 sdk_version: "current",
Colin Cross890ff552017-11-30 20:13:19 -0800708 resource_dirs: ["bar/res"],
709 }
Colin Cross6ed7dea2019-01-31 14:44:30 -0800710
711 android_library {
712 name: "lib",
Jeongik Cha75b83b02019-11-01 15:28:00 +0900713 sdk_version: "current",
Colin Cross6ed7dea2019-01-31 14:44:30 -0800714 resource_dirs: ["lib/res"],
Colin Crossbec85302019-02-13 13:15:46 -0800715 static_libs: ["lib2"],
716 }
717
718 android_library {
719 name: "lib2",
Jeongik Cha75b83b02019-11-01 15:28:00 +0900720 sdk_version: "current",
Colin Crossbec85302019-02-13 13:15:46 -0800721 resource_dirs: ["lib2/res"],
Colin Cross6ed7dea2019-01-31 14:44:30 -0800722 }
Anton Hansson53c88442019-03-18 15:53:16 +0000723
724 // This library has the same resources as lib (should not lead to dupe RROs)
725 android_library {
726 name: "lib3",
Jeongik Cha75b83b02019-11-01 15:28:00 +0900727 sdk_version: "current",
Anton Hansson53c88442019-03-18 15:53:16 +0000728 resource_dirs: ["lib/res"]
729 }
Colin Cross890ff552017-11-30 20:13:19 -0800730 `
731
Colin Cross5c4791c2019-02-01 11:44:44 -0800732 for _, testCase := range testCases {
Colin Cross890ff552017-11-30 20:13:19 -0800733 t.Run(testCase.name, func(t *testing.T) {
Colin Cross98be1bb2019-12-13 20:41:13 -0800734 config := testAppConfig(nil, bp, fs)
Anton Hansson53c88442019-03-18 15:53:16 +0000735 config.TestProductVariables.DeviceResourceOverlays = deviceResourceOverlays
736 config.TestProductVariables.ProductResourceOverlays = productResourceOverlays
Colin Cross890ff552017-11-30 20:13:19 -0800737 if testCase.enforceRROTargets != nil {
Colin Crossa74ca042019-01-31 14:31:51 -0800738 config.TestProductVariables.EnforceRROTargets = testCase.enforceRROTargets
Colin Cross890ff552017-11-30 20:13:19 -0800739 }
740 if testCase.enforceRROExcludedOverlays != nil {
Colin Crossa74ca042019-01-31 14:31:51 -0800741 config.TestProductVariables.EnforceRROExcludedOverlays = testCase.enforceRROExcludedOverlays
Colin Cross890ff552017-11-30 20:13:19 -0800742 }
743
Colin Cross98be1bb2019-12-13 20:41:13 -0800744 ctx := testContext()
Colin Cross890ff552017-11-30 20:13:19 -0800745 run(t, ctx, config)
746
Colin Crossbec85302019-02-13 13:15:46 -0800747 resourceListToFiles := func(module android.TestingModule, list []string) (files []string) {
748 for _, o := range list {
749 res := module.MaybeOutput(o)
750 if res.Rule != nil {
751 // If the overlay is compiled as part of this module (i.e. a .arsc.flat file),
752 // verify the inputs to the .arsc.flat rule.
753 files = append(files, res.Inputs.Strings()...)
754 } else {
755 // Otherwise, verify the full path to the output of the other module
756 files = append(files, o)
Anton Hansson94c93f32019-01-30 16:03:37 +0000757 }
Colin Cross890ff552017-11-30 20:13:19 -0800758 }
Colin Crossbec85302019-02-13 13:15:46 -0800759 return files
Colin Cross890ff552017-11-30 20:13:19 -0800760 }
761
Colin Crossbec85302019-02-13 13:15:46 -0800762 getResources := func(moduleName string) (resourceFiles, overlayFiles, rroDirs []string) {
763 module := ctx.ModuleForTests(moduleName, "android_common")
764 resourceList := module.MaybeOutput("aapt2/res.list")
765 if resourceList.Rule != nil {
766 resourceFiles = resourceListToFiles(module, resourceList.Inputs.Strings())
Anton Hansson0375a4f2019-01-24 14:39:19 +0000767 }
Colin Crossbec85302019-02-13 13:15:46 -0800768 overlayList := module.MaybeOutput("aapt2/overlay.list")
769 if overlayList.Rule != nil {
770 overlayFiles = resourceListToFiles(module, overlayList.Inputs.Strings())
771 }
772
Anton Hansson53c88442019-03-18 15:53:16 +0000773 for _, d := range module.Module().(AndroidLibraryDependency).ExportedRRODirs() {
774 var prefix string
775 if d.overlayType == device {
776 prefix = "device:"
777 } else if d.overlayType == product {
778 prefix = "product:"
779 } else {
780 t.Fatalf("Unexpected overlayType %d", d.overlayType)
781 }
782 rroDirs = append(rroDirs, prefix+d.path.String())
783 }
Colin Crossbec85302019-02-13 13:15:46 -0800784
785 return resourceFiles, overlayFiles, rroDirs
786 }
787
788 modules := []string{"foo", "bar", "lib", "lib2"}
789 for _, module := range modules {
790 resourceFiles, overlayFiles, rroDirs := getResources(module)
791
792 if !reflect.DeepEqual(resourceFiles, testCase.resourceFiles[module]) {
793 t.Errorf("expected %s resource files:\n %#v\n got:\n %#v",
794 module, testCase.resourceFiles[module], resourceFiles)
795 }
796 if !reflect.DeepEqual(overlayFiles, testCase.overlayFiles[module]) {
797 t.Errorf("expected %s overlay files:\n %#v\n got:\n %#v",
798 module, testCase.overlayFiles[module], overlayFiles)
799 }
800 if !reflect.DeepEqual(rroDirs, testCase.rroDirs[module]) {
Anton Hansson0375a4f2019-01-24 14:39:19 +0000801 t.Errorf("expected %s rroDirs: %#v\n got:\n %#v",
Colin Crossbec85302019-02-13 13:15:46 -0800802 module, testCase.rroDirs[module], rroDirs)
Anton Hansson0375a4f2019-01-24 14:39:19 +0000803 }
Colin Cross890ff552017-11-30 20:13:19 -0800804 }
Colin Cross890ff552017-11-30 20:13:19 -0800805 })
806 }
807}
Colin Crossd09b0b62018-04-18 11:06:47 -0700808
809func TestAppSdkVersion(t *testing.T) {
810 testCases := []struct {
811 name string
812 sdkVersion string
813 platformSdkInt int
814 platformSdkCodename string
815 platformSdkFinal bool
816 expectedMinSdkVersion string
Jeongik Cha538c0d02019-07-11 15:54:27 +0900817 platformApis bool
Colin Crossd09b0b62018-04-18 11:06:47 -0700818 }{
819 {
820 name: "current final SDK",
821 sdkVersion: "current",
822 platformSdkInt: 27,
823 platformSdkCodename: "REL",
824 platformSdkFinal: true,
825 expectedMinSdkVersion: "27",
826 },
827 {
828 name: "current non-final SDK",
829 sdkVersion: "current",
830 platformSdkInt: 27,
831 platformSdkCodename: "OMR1",
832 platformSdkFinal: false,
833 expectedMinSdkVersion: "OMR1",
834 },
835 {
836 name: "default final SDK",
837 sdkVersion: "",
Jeongik Cha538c0d02019-07-11 15:54:27 +0900838 platformApis: true,
Colin Crossd09b0b62018-04-18 11:06:47 -0700839 platformSdkInt: 27,
840 platformSdkCodename: "REL",
841 platformSdkFinal: true,
842 expectedMinSdkVersion: "27",
843 },
844 {
845 name: "default non-final SDK",
846 sdkVersion: "",
Jeongik Cha538c0d02019-07-11 15:54:27 +0900847 platformApis: true,
Colin Crossd09b0b62018-04-18 11:06:47 -0700848 platformSdkInt: 27,
849 platformSdkCodename: "OMR1",
850 platformSdkFinal: false,
851 expectedMinSdkVersion: "OMR1",
852 },
853 {
854 name: "14",
855 sdkVersion: "14",
856 expectedMinSdkVersion: "14",
857 },
858 }
859
860 for _, moduleType := range []string{"android_app", "android_library"} {
861 for _, test := range testCases {
862 t.Run(moduleType+" "+test.name, func(t *testing.T) {
Jeongik Cha538c0d02019-07-11 15:54:27 +0900863 platformApiProp := ""
864 if test.platformApis {
865 platformApiProp = "platform_apis: true,"
866 }
Colin Crossd09b0b62018-04-18 11:06:47 -0700867 bp := fmt.Sprintf(`%s {
868 name: "foo",
869 srcs: ["a.java"],
870 sdk_version: "%s",
Jeongik Cha538c0d02019-07-11 15:54:27 +0900871 %s
872 }`, moduleType, test.sdkVersion, platformApiProp)
Colin Crossd09b0b62018-04-18 11:06:47 -0700873
Colin Cross98be1bb2019-12-13 20:41:13 -0800874 config := testAppConfig(nil, bp, nil)
Colin Crossd09b0b62018-04-18 11:06:47 -0700875 config.TestProductVariables.Platform_sdk_version = &test.platformSdkInt
876 config.TestProductVariables.Platform_sdk_codename = &test.platformSdkCodename
877 config.TestProductVariables.Platform_sdk_final = &test.platformSdkFinal
878
Colin Cross98be1bb2019-12-13 20:41:13 -0800879 ctx := testContext()
Colin Crossd09b0b62018-04-18 11:06:47 -0700880
881 run(t, ctx, config)
882
883 foo := ctx.ModuleForTests("foo", "android_common")
884 link := foo.Output("package-res.apk")
885 linkFlags := strings.Split(link.Args["flags"], " ")
886 min := android.IndexList("--min-sdk-version", linkFlags)
887 target := android.IndexList("--target-sdk-version", linkFlags)
888
889 if min == -1 || target == -1 || min == len(linkFlags)-1 || target == len(linkFlags)-1 {
890 t.Fatalf("missing --min-sdk-version or --target-sdk-version in link flags: %q", linkFlags)
891 }
892
893 gotMinSdkVersion := linkFlags[min+1]
894 gotTargetSdkVersion := linkFlags[target+1]
895
896 if gotMinSdkVersion != test.expectedMinSdkVersion {
897 t.Errorf("incorrect --min-sdk-version, expected %q got %q",
898 test.expectedMinSdkVersion, gotMinSdkVersion)
899 }
900
901 if gotTargetSdkVersion != test.expectedMinSdkVersion {
902 t.Errorf("incorrect --target-sdk-version, expected %q got %q",
903 test.expectedMinSdkVersion, gotTargetSdkVersion)
904 }
905 })
906 }
907 }
908}
Colin Crossa4f08812018-10-02 22:03:40 -0700909
Paul Duffin50c217c2019-06-12 13:25:22 +0100910func TestJNIABI(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700911 ctx, _ := testJava(t, cc.GatherRequiredDepsForTest(android.Android)+`
Paul Duffin50c217c2019-06-12 13:25:22 +0100912 cc_library {
913 name: "libjni",
914 system_shared_libs: [],
915 stl: "none",
916 }
917
918 android_test {
919 name: "test",
920 sdk_version: "core_platform",
921 jni_libs: ["libjni"],
922 }
923
924 android_test {
925 name: "test_first",
926 sdk_version: "core_platform",
927 compile_multilib: "first",
928 jni_libs: ["libjni"],
929 }
930
931 android_test {
932 name: "test_both",
933 sdk_version: "core_platform",
934 compile_multilib: "both",
935 jni_libs: ["libjni"],
936 }
937
938 android_test {
939 name: "test_32",
940 sdk_version: "core_platform",
941 compile_multilib: "32",
942 jni_libs: ["libjni"],
943 }
944
945 android_test {
946 name: "test_64",
947 sdk_version: "core_platform",
948 compile_multilib: "64",
949 jni_libs: ["libjni"],
950 }
951 `)
952
953 testCases := []struct {
954 name string
955 abis []string
956 }{
957 {"test", []string{"arm64-v8a"}},
958 {"test_first", []string{"arm64-v8a"}},
959 {"test_both", []string{"arm64-v8a", "armeabi-v7a"}},
960 {"test_32", []string{"armeabi-v7a"}},
961 {"test_64", []string{"arm64-v8a"}},
962 }
963
964 for _, test := range testCases {
965 t.Run(test.name, func(t *testing.T) {
966 app := ctx.ModuleForTests(test.name, "android_common")
967 jniLibZip := app.Output("jnilibs.zip")
968 var abis []string
969 args := strings.Fields(jniLibZip.Args["jarArgs"])
970 for i := 0; i < len(args); i++ {
971 if args[i] == "-P" {
972 abis = append(abis, filepath.Base(args[i+1]))
973 i++
974 }
975 }
976 if !reflect.DeepEqual(abis, test.abis) {
977 t.Errorf("want abis %v, got %v", test.abis, abis)
978 }
979 })
980 }
981}
982
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900983func TestAppSdkVersionByPartition(t *testing.T) {
984 testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", `
985 android_app {
986 name: "foo",
987 srcs: ["a.java"],
988 vendor: true,
989 platform_apis: true,
990 }
991 `)
992
993 testJava(t, `
994 android_app {
995 name: "bar",
996 srcs: ["b.java"],
997 platform_apis: true,
998 }
999 `)
1000
1001 for _, enforce := range []bool{true, false} {
Jeongik Cha2cc570d2019-10-29 15:44:45 +09001002 bp := `
1003 android_app {
1004 name: "foo",
1005 srcs: ["a.java"],
1006 product_specific: true,
1007 platform_apis: true,
1008 }
1009 `
Colin Cross98be1bb2019-12-13 20:41:13 -08001010
1011 config := testAppConfig(nil, bp, nil)
1012 config.TestProductVariables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce)
Jeongik Cha2cc570d2019-10-29 15:44:45 +09001013 if enforce {
Colin Cross98be1bb2019-12-13 20:41:13 -08001014 testJavaErrorWithConfig(t, "sdk_version must have a value when the module is located at vendor or product", config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +09001015 } else {
Colin Cross98be1bb2019-12-13 20:41:13 -08001016 testJavaWithConfig(t, config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +09001017 }
1018 }
1019}
1020
Paul Duffin50c217c2019-06-12 13:25:22 +01001021func TestJNIPackaging(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001022 ctx, _ := testJava(t, cc.GatherRequiredDepsForTest(android.Android)+`
Paul Duffin50c217c2019-06-12 13:25:22 +01001023 cc_library {
1024 name: "libjni",
1025 system_shared_libs: [],
1026 stl: "none",
1027 }
1028
1029 android_app {
1030 name: "app",
1031 jni_libs: ["libjni"],
Jeongik Cha538c0d02019-07-11 15:54:27 +09001032 sdk_version: "current",
Paul Duffin50c217c2019-06-12 13:25:22 +01001033 }
1034
1035 android_app {
1036 name: "app_noembed",
1037 jni_libs: ["libjni"],
1038 use_embedded_native_libs: false,
Jeongik Cha538c0d02019-07-11 15:54:27 +09001039 sdk_version: "current",
Paul Duffin50c217c2019-06-12 13:25:22 +01001040 }
1041
1042 android_app {
1043 name: "app_embed",
1044 jni_libs: ["libjni"],
1045 use_embedded_native_libs: true,
Jeongik Cha538c0d02019-07-11 15:54:27 +09001046 sdk_version: "current",
Paul Duffin50c217c2019-06-12 13:25:22 +01001047 }
1048
1049 android_test {
1050 name: "test",
1051 sdk_version: "core_platform",
1052 jni_libs: ["libjni"],
1053 }
1054
1055 android_test {
1056 name: "test_noembed",
1057 sdk_version: "core_platform",
1058 jni_libs: ["libjni"],
1059 use_embedded_native_libs: false,
1060 }
1061
1062 android_test_helper_app {
1063 name: "test_helper",
1064 sdk_version: "core_platform",
1065 jni_libs: ["libjni"],
1066 }
1067
1068 android_test_helper_app {
1069 name: "test_helper_noembed",
1070 sdk_version: "core_platform",
1071 jni_libs: ["libjni"],
1072 use_embedded_native_libs: false,
1073 }
1074 `)
1075
1076 testCases := []struct {
1077 name string
1078 packaged bool
1079 compressed bool
1080 }{
1081 {"app", false, false},
1082 {"app_noembed", false, false},
1083 {"app_embed", true, false},
1084 {"test", true, false},
1085 {"test_noembed", true, true},
1086 {"test_helper", true, false},
1087 {"test_helper_noembed", true, true},
1088 }
1089
1090 for _, test := range testCases {
1091 t.Run(test.name, func(t *testing.T) {
1092 app := ctx.ModuleForTests(test.name, "android_common")
1093 jniLibZip := app.MaybeOutput("jnilibs.zip")
1094 if g, w := (jniLibZip.Rule != nil), test.packaged; g != w {
1095 t.Errorf("expected jni packaged %v, got %v", w, g)
1096 }
1097
1098 if jniLibZip.Rule != nil {
1099 if g, w := !strings.Contains(jniLibZip.Args["jarArgs"], "-L 0"), test.compressed; g != w {
1100 t.Errorf("expected jni compressed %v, got %v", w, g)
1101 }
1102 }
1103 })
1104 }
Colin Cross47fa9d32019-03-26 10:51:39 -07001105}
1106
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001107func TestCertificates(t *testing.T) {
1108 testCases := []struct {
1109 name string
1110 bp string
1111 certificateOverride string
1112 expected string
1113 }{
1114 {
1115 name: "default",
1116 bp: `
1117 android_app {
1118 name: "foo",
1119 srcs: ["a.java"],
Jeongik Cha538c0d02019-07-11 15:54:27 +09001120 sdk_version: "current",
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001121 }
1122 `,
1123 certificateOverride: "",
Dan Willemsen412160e2019-04-09 21:36:26 -07001124 expected: "build/make/target/product/security/testkey.x509.pem build/make/target/product/security/testkey.pk8",
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001125 },
1126 {
1127 name: "module certificate property",
1128 bp: `
1129 android_app {
1130 name: "foo",
1131 srcs: ["a.java"],
Jeongik Cha538c0d02019-07-11 15:54:27 +09001132 certificate: ":new_certificate",
1133 sdk_version: "current",
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001134 }
1135
1136 android_app_certificate {
1137 name: "new_certificate",
1138 certificate: "cert/new_cert",
1139 }
1140 `,
1141 certificateOverride: "",
1142 expected: "cert/new_cert.x509.pem cert/new_cert.pk8",
1143 },
1144 {
1145 name: "path certificate property",
1146 bp: `
1147 android_app {
1148 name: "foo",
1149 srcs: ["a.java"],
Jeongik Cha538c0d02019-07-11 15:54:27 +09001150 certificate: "expiredkey",
1151 sdk_version: "current",
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001152 }
1153 `,
1154 certificateOverride: "",
Dan Willemsen412160e2019-04-09 21:36:26 -07001155 expected: "build/make/target/product/security/expiredkey.x509.pem build/make/target/product/security/expiredkey.pk8",
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001156 },
1157 {
1158 name: "certificate overrides",
1159 bp: `
1160 android_app {
1161 name: "foo",
1162 srcs: ["a.java"],
Jeongik Cha538c0d02019-07-11 15:54:27 +09001163 certificate: "expiredkey",
1164 sdk_version: "current",
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001165 }
1166
1167 android_app_certificate {
1168 name: "new_certificate",
1169 certificate: "cert/new_cert",
1170 }
1171 `,
1172 certificateOverride: "foo:new_certificate",
1173 expected: "cert/new_cert.x509.pem cert/new_cert.pk8",
1174 },
1175 }
1176
1177 for _, test := range testCases {
1178 t.Run(test.name, func(t *testing.T) {
Colin Cross98be1bb2019-12-13 20:41:13 -08001179 config := testAppConfig(nil, test.bp, nil)
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001180 if test.certificateOverride != "" {
1181 config.TestProductVariables.CertificateOverrides = []string{test.certificateOverride}
1182 }
Colin Cross98be1bb2019-12-13 20:41:13 -08001183 ctx := testContext()
Jaewoong Jung2ad817c2019-01-18 14:27:16 -08001184
1185 run(t, ctx, config)
1186 foo := ctx.ModuleForTests("foo", "android_common")
1187
1188 signapk := foo.Output("foo.apk")
1189 signFlags := signapk.Args["certificates"]
1190 if test.expected != signFlags {
1191 t.Errorf("Incorrect signing flags, expected: %q, got: %q", test.expected, signFlags)
1192 }
1193 })
1194 }
1195}
Jaewoong Jung9d22a912019-01-23 16:27:47 -08001196
Songchun Fan688de9a2020-03-24 20:32:24 -07001197func TestRequestV4SigningFlag(t *testing.T) {
1198 testCases := []struct {
1199 name string
1200 bp string
1201 expected string
1202 }{
1203 {
1204 name: "default",
1205 bp: `
1206 android_app {
1207 name: "foo",
1208 srcs: ["a.java"],
1209 sdk_version: "current",
1210 }
1211 `,
1212 expected: "",
1213 },
1214 {
1215 name: "default",
1216 bp: `
1217 android_app {
1218 name: "foo",
1219 srcs: ["a.java"],
1220 sdk_version: "current",
1221 v4_signature: false,
1222 }
1223 `,
1224 expected: "",
1225 },
1226 {
1227 name: "module certificate property",
1228 bp: `
1229 android_app {
1230 name: "foo",
1231 srcs: ["a.java"],
1232 sdk_version: "current",
1233 v4_signature: true,
1234 }
1235 `,
1236 expected: "--enable-v4",
1237 },
1238 }
1239
1240 for _, test := range testCases {
1241 t.Run(test.name, func(t *testing.T) {
1242 config := testAppConfig(nil, test.bp, nil)
1243 ctx := testContext()
1244
1245 run(t, ctx, config)
1246 foo := ctx.ModuleForTests("foo", "android_common")
1247
1248 signapk := foo.Output("foo.apk")
1249 signFlags := signapk.Args["flags"]
1250 if test.expected != signFlags {
1251 t.Errorf("Incorrect signing flags, expected: %q, got: %q", test.expected, signFlags)
1252 }
1253 })
1254 }
1255}
1256
Jaewoong Jung9d22a912019-01-23 16:27:47 -08001257func TestPackageNameOverride(t *testing.T) {
1258 testCases := []struct {
1259 name string
1260 bp string
1261 packageNameOverride string
1262 expected []string
1263 }{
1264 {
1265 name: "default",
1266 bp: `
1267 android_app {
1268 name: "foo",
1269 srcs: ["a.java"],
Jeongik Cha538c0d02019-07-11 15:54:27 +09001270 sdk_version: "current",
Jaewoong Jung9d22a912019-01-23 16:27:47 -08001271 }
1272 `,
1273 packageNameOverride: "",
1274 expected: []string{
1275 buildDir + "/.intermediates/foo/android_common/foo.apk",
1276 buildDir + "/target/product/test_device/system/app/foo/foo.apk",
1277 },
1278 },
1279 {
1280 name: "overridden",
1281 bp: `
1282 android_app {
1283 name: "foo",
1284 srcs: ["a.java"],
Jeongik Cha538c0d02019-07-11 15:54:27 +09001285 sdk_version: "current",
Jaewoong Jung9d22a912019-01-23 16:27:47 -08001286 }
1287 `,
1288 packageNameOverride: "foo:bar",
1289 expected: []string{
1290 // The package apk should be still be the original name for test dependencies.
Jaewoong Jung5a498812019-11-07 14:14:38 -08001291 buildDir + "/.intermediates/foo/android_common/bar.apk",
Jaewoong Jung9d22a912019-01-23 16:27:47 -08001292 buildDir + "/target/product/test_device/system/app/bar/bar.apk",
1293 },
1294 },
1295 }
1296
1297 for _, test := range testCases {
1298 t.Run(test.name, func(t *testing.T) {
Colin Cross98be1bb2019-12-13 20:41:13 -08001299 config := testAppConfig(nil, test.bp, nil)
Jaewoong Jung9d22a912019-01-23 16:27:47 -08001300 if test.packageNameOverride != "" {
1301 config.TestProductVariables.PackageNameOverrides = []string{test.packageNameOverride}
1302 }
Colin Cross98be1bb2019-12-13 20:41:13 -08001303 ctx := testContext()
Jaewoong Jung9d22a912019-01-23 16:27:47 -08001304
1305 run(t, ctx, config)
1306 foo := ctx.ModuleForTests("foo", "android_common")
1307
1308 outputs := foo.AllOutputs()
1309 outputMap := make(map[string]bool)
1310 for _, o := range outputs {
1311 outputMap[o] = true
1312 }
1313 for _, e := range test.expected {
1314 if _, exist := outputMap[e]; !exist {
1315 t.Errorf("Can't find %q in output files.\nAll outputs:%v", e, outputs)
1316 }
1317 }
1318 })
1319 }
1320}
Jaewoong Jung4102e5d2019-02-27 16:26:28 -08001321
1322func TestInstrumentationTargetOverridden(t *testing.T) {
1323 bp := `
1324 android_app {
1325 name: "foo",
1326 srcs: ["a.java"],
Jeongik Cha538c0d02019-07-11 15:54:27 +09001327 sdk_version: "current",
Jaewoong Jung4102e5d2019-02-27 16:26:28 -08001328 }
1329
1330 android_test {
1331 name: "bar",
1332 instrumentation_for: "foo",
Jeongik Cha538c0d02019-07-11 15:54:27 +09001333 sdk_version: "current",
Jaewoong Jung4102e5d2019-02-27 16:26:28 -08001334 }
1335 `
Colin Cross98be1bb2019-12-13 20:41:13 -08001336 config := testAppConfig(nil, bp, nil)
Jaewoong Jung4102e5d2019-02-27 16:26:28 -08001337 config.TestProductVariables.ManifestPackageNameOverrides = []string{"foo:org.dandroid.bp"}
Colin Cross98be1bb2019-12-13 20:41:13 -08001338 ctx := testContext()
Jaewoong Jung4102e5d2019-02-27 16:26:28 -08001339
1340 run(t, ctx, config)
1341
1342 bar := ctx.ModuleForTests("bar", "android_common")
1343 res := bar.Output("package-res.apk")
1344 aapt2Flags := res.Args["flags"]
1345 e := "--rename-instrumentation-target-package org.dandroid.bp"
1346 if !strings.Contains(aapt2Flags, e) {
1347 t.Errorf("target package renaming flag, %q is missing in aapt2 link flags, %q", e, aapt2Flags)
1348 }
1349}
Jaewoong Jung525443a2019-02-28 15:35:54 -08001350
1351func TestOverrideAndroidApp(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001352 ctx, _ := testJava(t, `
Jaewoong Jung525443a2019-02-28 15:35:54 -08001353 android_app {
1354 name: "foo",
1355 srcs: ["a.java"],
Jaewoong Junga641ee92019-03-27 11:17:14 -07001356 certificate: "expiredkey",
Jaewoong Jungb639a6a2019-05-10 15:16:29 -07001357 overrides: ["qux"],
Jeongik Cha538c0d02019-07-11 15:54:27 +09001358 sdk_version: "current",
Jaewoong Jung525443a2019-02-28 15:35:54 -08001359 }
1360
1361 override_android_app {
1362 name: "bar",
1363 base: "foo",
1364 certificate: ":new_certificate",
Baligh Uddin5b16dfb2020-02-11 17:27:19 -08001365 logging_parent: "bah",
Jaewoong Jung525443a2019-02-28 15:35:54 -08001366 }
1367
1368 android_app_certificate {
1369 name: "new_certificate",
1370 certificate: "cert/new_cert",
1371 }
Jaewoong Jung6f373f62019-03-13 10:13:24 -07001372
1373 override_android_app {
1374 name: "baz",
1375 base: "foo",
1376 package_name: "org.dandroid.bp",
1377 }
Jaewoong Jung525443a2019-02-28 15:35:54 -08001378 `)
1379
1380 expectedVariants := []struct {
Baligh Uddin5b16dfb2020-02-11 17:27:19 -08001381 moduleName string
1382 variantName string
1383 apkName string
1384 apkPath string
1385 signFlag string
1386 overrides []string
1387 aaptFlag string
1388 logging_parent string
Jaewoong Jung525443a2019-02-28 15:35:54 -08001389 }{
1390 {
Baligh Uddin5b16dfb2020-02-11 17:27:19 -08001391 moduleName: "foo",
1392 variantName: "android_common",
1393 apkPath: "/target/product/test_device/system/app/foo/foo.apk",
1394 signFlag: "build/make/target/product/security/expiredkey.x509.pem build/make/target/product/security/expiredkey.pk8",
1395 overrides: []string{"qux"},
1396 aaptFlag: "",
1397 logging_parent: "",
Jaewoong Jung525443a2019-02-28 15:35:54 -08001398 },
1399 {
Baligh Uddin5b16dfb2020-02-11 17:27:19 -08001400 moduleName: "bar",
1401 variantName: "android_common_bar",
1402 apkPath: "/target/product/test_device/system/app/bar/bar.apk",
1403 signFlag: "cert/new_cert.x509.pem cert/new_cert.pk8",
1404 overrides: []string{"qux", "foo"},
1405 aaptFlag: "",
1406 logging_parent: "bah",
Jaewoong Jung6f373f62019-03-13 10:13:24 -07001407 },
1408 {
Baligh Uddin5b16dfb2020-02-11 17:27:19 -08001409 moduleName: "baz",
1410 variantName: "android_common_baz",
1411 apkPath: "/target/product/test_device/system/app/baz/baz.apk",
1412 signFlag: "build/make/target/product/security/expiredkey.x509.pem build/make/target/product/security/expiredkey.pk8",
1413 overrides: []string{"qux", "foo"},
1414 aaptFlag: "--rename-manifest-package org.dandroid.bp",
1415 logging_parent: "",
Jaewoong Jung525443a2019-02-28 15:35:54 -08001416 },
1417 }
1418 for _, expected := range expectedVariants {
1419 variant := ctx.ModuleForTests("foo", expected.variantName)
1420
1421 // Check the final apk name
1422 outputs := variant.AllOutputs()
1423 expectedApkPath := buildDir + expected.apkPath
1424 found := false
1425 for _, o := range outputs {
1426 if o == expectedApkPath {
1427 found = true
1428 break
1429 }
1430 }
1431 if !found {
1432 t.Errorf("Can't find %q in output files.\nAll outputs:%v", expectedApkPath, outputs)
1433 }
1434
1435 // Check the certificate paths
Jaewoong Jung5a498812019-11-07 14:14:38 -08001436 signapk := variant.Output(expected.moduleName + ".apk")
Jaewoong Jung525443a2019-02-28 15:35:54 -08001437 signFlag := signapk.Args["certificates"]
1438 if expected.signFlag != signFlag {
1439 t.Errorf("Incorrect signing flags, expected: %q, got: %q", expected.signFlag, signFlag)
1440 }
1441
Jaewoong Jung6f373f62019-03-13 10:13:24 -07001442 // Check if the overrides field values are correctly aggregated.
Jaewoong Jung525443a2019-02-28 15:35:54 -08001443 mod := variant.Module().(*AndroidApp)
1444 if !reflect.DeepEqual(expected.overrides, mod.appProperties.Overrides) {
1445 t.Errorf("Incorrect overrides property value, expected: %q, got: %q",
1446 expected.overrides, mod.appProperties.Overrides)
1447 }
Jaewoong Jung6f373f62019-03-13 10:13:24 -07001448
Baligh Uddin5b16dfb2020-02-11 17:27:19 -08001449 // Test Overridable property: Logging_parent
1450 logging_parent := mod.aapt.LoggingParent
1451 if expected.logging_parent != logging_parent {
1452 t.Errorf("Incorrect overrides property value for logging parent, expected: %q, got: %q",
1453 expected.logging_parent, logging_parent)
1454 }
1455
Jaewoong Jung6f373f62019-03-13 10:13:24 -07001456 // Check the package renaming flag, if exists.
1457 res := variant.Output("package-res.apk")
1458 aapt2Flags := res.Args["flags"]
1459 if !strings.Contains(aapt2Flags, expected.aaptFlag) {
1460 t.Errorf("package renaming flag, %q is missing in aapt2 link flags, %q", expected.aaptFlag, aapt2Flags)
1461 }
Jaewoong Jung525443a2019-02-28 15:35:54 -08001462 }
1463}
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001464
Jaewoong Jungb639a6a2019-05-10 15:16:29 -07001465func TestOverrideAndroidAppDependency(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001466 ctx, _ := testJava(t, `
Jaewoong Jungb639a6a2019-05-10 15:16:29 -07001467 android_app {
1468 name: "foo",
1469 srcs: ["a.java"],
Jeongik Cha538c0d02019-07-11 15:54:27 +09001470 sdk_version: "current",
Jaewoong Jungb639a6a2019-05-10 15:16:29 -07001471 }
1472
1473 override_android_app {
1474 name: "bar",
1475 base: "foo",
1476 package_name: "org.dandroid.bp",
1477 }
1478
1479 android_test {
1480 name: "baz",
1481 srcs: ["b.java"],
1482 instrumentation_for: "foo",
1483 }
1484
1485 android_test {
1486 name: "qux",
1487 srcs: ["b.java"],
1488 instrumentation_for: "bar",
1489 }
1490 `)
1491
1492 // Verify baz, which depends on the overridden module foo, has the correct classpath javac arg.
1493 javac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1494 fooTurbine := filepath.Join(buildDir, ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar")
1495 if !strings.Contains(javac.Args["classpath"], fooTurbine) {
1496 t.Errorf("baz classpath %v does not contain %q", javac.Args["classpath"], fooTurbine)
1497 }
1498
1499 // Verify qux, which depends on the overriding module bar, has the correct classpath javac arg.
1500 javac = ctx.ModuleForTests("qux", "android_common").Rule("javac")
1501 barTurbine := filepath.Join(buildDir, ".intermediates", "foo", "android_common_bar", "turbine-combined", "foo.jar")
1502 if !strings.Contains(javac.Args["classpath"], barTurbine) {
1503 t.Errorf("qux classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
1504 }
1505}
1506
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001507func TestOverrideAndroidTest(t *testing.T) {
1508 ctx, _ := testJava(t, `
1509 android_app {
1510 name: "foo",
1511 srcs: ["a.java"],
1512 package_name: "com.android.foo",
1513 sdk_version: "current",
1514 }
1515
1516 override_android_app {
1517 name: "bar",
1518 base: "foo",
1519 package_name: "com.android.bar",
1520 }
1521
1522 android_test {
1523 name: "foo_test",
1524 srcs: ["b.java"],
1525 instrumentation_for: "foo",
1526 }
1527
1528 override_android_test {
1529 name: "bar_test",
1530 base: "foo_test",
1531 package_name: "com.android.bar.test",
1532 instrumentation_for: "bar",
1533 instrumentation_target_package: "com.android.bar",
1534 }
1535 `)
1536
1537 expectedVariants := []struct {
1538 moduleName string
1539 variantName string
1540 apkPath string
1541 overrides []string
1542 targetVariant string
1543 packageFlag string
1544 targetPackageFlag string
1545 }{
1546 {
1547 variantName: "android_common",
Jaewoong Jung326a9412019-11-21 10:41:00 -08001548 apkPath: "/target/product/test_device/testcases/foo_test/arm64/foo_test.apk",
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001549 overrides: nil,
1550 targetVariant: "android_common",
1551 packageFlag: "",
1552 targetPackageFlag: "",
1553 },
1554 {
1555 variantName: "android_common_bar_test",
Jaewoong Jung326a9412019-11-21 10:41:00 -08001556 apkPath: "/target/product/test_device/testcases/bar_test/arm64/bar_test.apk",
Jaewoong Jung26dedd32019-06-06 08:45:58 -07001557 overrides: []string{"foo_test"},
1558 targetVariant: "android_common_bar",
1559 packageFlag: "com.android.bar.test",
1560 targetPackageFlag: "com.android.bar",
1561 },
1562 }
1563 for _, expected := range expectedVariants {
1564 variant := ctx.ModuleForTests("foo_test", expected.variantName)
1565
1566 // Check the final apk name
1567 outputs := variant.AllOutputs()
1568 expectedApkPath := buildDir + expected.apkPath
1569 found := false
1570 for _, o := range outputs {
1571 if o == expectedApkPath {
1572 found = true
1573 break
1574 }
1575 }
1576 if !found {
1577 t.Errorf("Can't find %q in output files.\nAll outputs:%v", expectedApkPath, outputs)
1578 }
1579
1580 // Check if the overrides field values are correctly aggregated.
1581 mod := variant.Module().(*AndroidTest)
1582 if !reflect.DeepEqual(expected.overrides, mod.appProperties.Overrides) {
1583 t.Errorf("Incorrect overrides property value, expected: %q, got: %q",
1584 expected.overrides, mod.appProperties.Overrides)
1585 }
1586
1587 // Check if javac classpath has the correct jar file path. This checks instrumentation_for overrides.
1588 javac := variant.Rule("javac")
1589 turbine := filepath.Join(buildDir, ".intermediates", "foo", expected.targetVariant, "turbine-combined", "foo.jar")
1590 if !strings.Contains(javac.Args["classpath"], turbine) {
1591 t.Errorf("classpath %q does not contain %q", javac.Args["classpath"], turbine)
1592 }
1593
1594 // Check aapt2 flags.
1595 res := variant.Output("package-res.apk")
1596 aapt2Flags := res.Args["flags"]
1597 checkAapt2LinkFlag(t, aapt2Flags, "rename-manifest-package", expected.packageFlag)
1598 checkAapt2LinkFlag(t, aapt2Flags, "rename-instrumentation-target-package", expected.targetPackageFlag)
1599 }
1600}
1601
Jaewoong Jung39982342020-01-14 10:27:18 -08001602func TestAndroidTest_FixTestConfig(t *testing.T) {
1603 ctx, _ := testJava(t, `
1604 android_app {
1605 name: "foo",
1606 srcs: ["a.java"],
1607 package_name: "com.android.foo",
1608 sdk_version: "current",
1609 }
1610
1611 android_test {
1612 name: "foo_test",
1613 srcs: ["b.java"],
1614 instrumentation_for: "foo",
1615 }
1616
1617 android_test {
1618 name: "bar_test",
1619 srcs: ["b.java"],
1620 package_name: "com.android.bar.test",
1621 instrumentation_for: "foo",
1622 }
1623
1624 override_android_test {
1625 name: "baz_test",
1626 base: "foo_test",
1627 package_name: "com.android.baz.test",
1628 }
1629 `)
1630
1631 testCases := []struct {
1632 moduleName string
1633 variantName string
1634 expectedFlags []string
1635 }{
1636 {
1637 moduleName: "foo_test",
1638 variantName: "android_common",
1639 },
1640 {
1641 moduleName: "bar_test",
1642 variantName: "android_common",
1643 expectedFlags: []string{
1644 "--manifest " + buildDir + "/.intermediates/bar_test/android_common/manifest_fixer/AndroidManifest.xml",
1645 "--package-name com.android.bar.test",
1646 },
1647 },
1648 {
1649 moduleName: "foo_test",
1650 variantName: "android_common_baz_test",
1651 expectedFlags: []string{
1652 "--manifest " + buildDir +
1653 "/.intermediates/foo_test/android_common_baz_test/manifest_fixer/AndroidManifest.xml",
1654 "--package-name com.android.baz.test",
1655 "--test-file-name baz_test.apk",
1656 },
1657 },
1658 }
1659
1660 for _, test := range testCases {
1661 variant := ctx.ModuleForTests(test.moduleName, test.variantName)
1662 params := variant.MaybeOutput("test_config_fixer/AndroidTest.xml")
1663
1664 if len(test.expectedFlags) > 0 {
1665 if params.Rule == nil {
1666 t.Errorf("test_config_fixer was expected to run, but didn't")
1667 } else {
1668 for _, flag := range test.expectedFlags {
1669 if !strings.Contains(params.RuleParams.Command, flag) {
1670 t.Errorf("Flag %q was not found in command: %q", flag, params.RuleParams.Command)
1671 }
1672 }
1673 }
1674 } else {
1675 if params.Rule != nil {
1676 t.Errorf("test_config_fixer was not expected to run, but did: %q", params.RuleParams.Command)
1677 }
1678 }
1679
1680 }
1681}
1682
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001683func TestAndroidAppImport(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001684 ctx, _ := testJava(t, `
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001685 android_app_import {
1686 name: "foo",
1687 apk: "prebuilts/apk/app.apk",
1688 certificate: "platform",
1689 dex_preopt: {
1690 enabled: true,
1691 },
1692 }
1693 `)
1694
1695 variant := ctx.ModuleForTests("foo", "android_common")
1696
1697 // Check dexpreopt outputs.
1698 if variant.MaybeOutput("dexpreopt/oat/arm64/package.vdex").Rule == nil ||
1699 variant.MaybeOutput("dexpreopt/oat/arm64/package.odex").Rule == nil {
1700 t.Errorf("can't find dexpreopt outputs")
1701 }
1702
1703 // Check cert signing flag.
1704 signedApk := variant.Output("signed/foo.apk")
1705 signingFlag := signedApk.Args["certificates"]
1706 expected := "build/make/target/product/security/platform.x509.pem build/make/target/product/security/platform.pk8"
1707 if expected != signingFlag {
1708 t.Errorf("Incorrect signing flags, expected: %q, got: %q", expected, signingFlag)
1709 }
1710}
1711
1712func TestAndroidAppImport_NoDexPreopt(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001713 ctx, _ := testJava(t, `
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001714 android_app_import {
1715 name: "foo",
1716 apk: "prebuilts/apk/app.apk",
1717 certificate: "platform",
1718 dex_preopt: {
1719 enabled: false,
1720 },
1721 }
1722 `)
1723
1724 variant := ctx.ModuleForTests("foo", "android_common")
1725
1726 // Check dexpreopt outputs. They shouldn't exist.
1727 if variant.MaybeOutput("dexpreopt/oat/arm64/package.vdex").Rule != nil ||
1728 variant.MaybeOutput("dexpreopt/oat/arm64/package.odex").Rule != nil {
1729 t.Errorf("dexpreopt shouldn't have run.")
1730 }
1731}
1732
1733func TestAndroidAppImport_Presigned(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001734 ctx, _ := testJava(t, `
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001735 android_app_import {
1736 name: "foo",
1737 apk: "prebuilts/apk/app.apk",
1738 presigned: true,
1739 dex_preopt: {
1740 enabled: true,
1741 },
1742 }
1743 `)
1744
1745 variant := ctx.ModuleForTests("foo", "android_common")
1746
1747 // Check dexpreopt outputs.
1748 if variant.MaybeOutput("dexpreopt/oat/arm64/package.vdex").Rule == nil ||
1749 variant.MaybeOutput("dexpreopt/oat/arm64/package.odex").Rule == nil {
1750 t.Errorf("can't find dexpreopt outputs")
1751 }
Nicolas Geoffrayc1bf7242019-10-18 14:51:38 +01001752 // Make sure signing was skipped and aligning was done.
Jaewoong Jungccbb3932019-04-15 09:48:31 -07001753 if variant.MaybeOutput("signed/foo.apk").Rule != nil {
1754 t.Errorf("signing rule shouldn't be included.")
1755 }
1756 if variant.MaybeOutput("zip-aligned/foo.apk").Rule == nil {
1757 t.Errorf("can't find aligning rule")
1758 }
1759}
Jaewoong Junga5e5abc2019-04-26 14:31:50 -07001760
Jaewoong Jung961d4fd2019-08-22 14:25:58 -07001761func TestAndroidAppImport_DefaultDevCert(t *testing.T) {
1762 ctx, _ := testJava(t, `
1763 android_app_import {
1764 name: "foo",
1765 apk: "prebuilts/apk/app.apk",
1766 default_dev_cert: true,
1767 dex_preopt: {
1768 enabled: true,
1769 },
1770 }
1771 `)
1772
1773 variant := ctx.ModuleForTests("foo", "android_common")
1774
1775 // Check dexpreopt outputs.
1776 if variant.MaybeOutput("dexpreopt/oat/arm64/package.vdex").Rule == nil ||
1777 variant.MaybeOutput("dexpreopt/oat/arm64/package.odex").Rule == nil {
1778 t.Errorf("can't find dexpreopt outputs")
1779 }
1780
1781 // Check cert signing flag.
1782 signedApk := variant.Output("signed/foo.apk")
1783 signingFlag := signedApk.Args["certificates"]
1784 expected := "build/make/target/product/security/testkey.x509.pem build/make/target/product/security/testkey.pk8"
1785 if expected != signingFlag {
1786 t.Errorf("Incorrect signing flags, expected: %q, got: %q", expected, signingFlag)
1787 }
1788}
1789
Jaewoong Junga5e5abc2019-04-26 14:31:50 -07001790func TestAndroidAppImport_DpiVariants(t *testing.T) {
1791 bp := `
1792 android_app_import {
1793 name: "foo",
1794 apk: "prebuilts/apk/app.apk",
1795 dpi_variants: {
1796 xhdpi: {
1797 apk: "prebuilts/apk/app_xhdpi.apk",
1798 },
1799 xxhdpi: {
1800 apk: "prebuilts/apk/app_xxhdpi.apk",
1801 },
1802 },
Jaewoong Jung961d4fd2019-08-22 14:25:58 -07001803 presigned: true,
Jaewoong Junga5e5abc2019-04-26 14:31:50 -07001804 dex_preopt: {
1805 enabled: true,
1806 },
1807 }
1808 `
1809 testCases := []struct {
1810 name string
1811 aaptPreferredConfig *string
1812 aaptPrebuiltDPI []string
1813 expected string
1814 }{
1815 {
1816 name: "no preferred",
1817 aaptPreferredConfig: nil,
1818 aaptPrebuiltDPI: []string{},
1819 expected: "prebuilts/apk/app.apk",
1820 },
1821 {
1822 name: "AAPTPreferredConfig matches",
1823 aaptPreferredConfig: proptools.StringPtr("xhdpi"),
Jaewoong Jung3e18b192019-06-11 12:25:34 -07001824 aaptPrebuiltDPI: []string{"xxhdpi", "ldpi"},
Jaewoong Junga5e5abc2019-04-26 14:31:50 -07001825 expected: "prebuilts/apk/app_xhdpi.apk",
1826 },
1827 {
1828 name: "AAPTPrebuiltDPI matches",
1829 aaptPreferredConfig: proptools.StringPtr("mdpi"),
1830 aaptPrebuiltDPI: []string{"xxhdpi", "xhdpi"},
1831 expected: "prebuilts/apk/app_xxhdpi.apk",
1832 },
1833 {
1834 name: "non-first AAPTPrebuiltDPI matches",
1835 aaptPreferredConfig: proptools.StringPtr("mdpi"),
1836 aaptPrebuiltDPI: []string{"ldpi", "xhdpi"},
1837 expected: "prebuilts/apk/app_xhdpi.apk",
1838 },
1839 {
1840 name: "no matches",
1841 aaptPreferredConfig: proptools.StringPtr("mdpi"),
1842 aaptPrebuiltDPI: []string{"ldpi", "xxxhdpi"},
1843 expected: "prebuilts/apk/app.apk",
1844 },
1845 }
1846
1847 jniRuleRe := regexp.MustCompile("^if \\(zipinfo (\\S+)")
1848 for _, test := range testCases {
Colin Cross98be1bb2019-12-13 20:41:13 -08001849 config := testAppConfig(nil, bp, nil)
Jaewoong Junga5e5abc2019-04-26 14:31:50 -07001850 config.TestProductVariables.AAPTPreferredConfig = test.aaptPreferredConfig
1851 config.TestProductVariables.AAPTPrebuiltDPI = test.aaptPrebuiltDPI
Colin Cross98be1bb2019-12-13 20:41:13 -08001852 ctx := testContext()
Jaewoong Junga5e5abc2019-04-26 14:31:50 -07001853
1854 run(t, ctx, config)
1855
1856 variant := ctx.ModuleForTests("foo", "android_common")
1857 jniRuleCommand := variant.Output("jnis-uncompressed/foo.apk").RuleParams.Command
1858 matches := jniRuleRe.FindStringSubmatch(jniRuleCommand)
1859 if len(matches) != 2 {
1860 t.Errorf("failed to extract the src apk path from %q", jniRuleCommand)
1861 }
1862 if test.expected != matches[1] {
1863 t.Errorf("wrong src apk, expected: %q got: %q", test.expected, matches[1])
1864 }
1865 }
1866}
Jaewoong Jungbc625cd2019-05-06 15:48:44 -07001867
Jaewoong Jung8aae22e2019-07-17 10:21:49 -07001868func TestAndroidAppImport_Filename(t *testing.T) {
1869 ctx, config := testJava(t, `
1870 android_app_import {
1871 name: "foo",
1872 apk: "prebuilts/apk/app.apk",
1873 presigned: true,
1874 }
1875
1876 android_app_import {
1877 name: "bar",
1878 apk: "prebuilts/apk/app.apk",
1879 presigned: true,
1880 filename: "bar_sample.apk"
1881 }
1882 `)
1883
1884 testCases := []struct {
1885 name string
1886 expected string
1887 }{
1888 {
1889 name: "foo",
1890 expected: "foo.apk",
1891 },
1892 {
1893 name: "bar",
1894 expected: "bar_sample.apk",
1895 },
1896 }
1897
1898 for _, test := range testCases {
1899 variant := ctx.ModuleForTests(test.name, "android_common")
1900 if variant.MaybeOutput(test.expected).Rule == nil {
1901 t.Errorf("can't find output named %q - all outputs: %v", test.expected, variant.AllOutputs())
1902 }
1903
1904 a := variant.Module().(*AndroidAppImport)
1905 expectedValues := []string{test.expected}
1906 actualValues := android.AndroidMkEntriesForTest(
Jiyong Park0b0e1b92019-12-03 13:24:29 +09001907 t, config, "", a)[0].EntryMap["LOCAL_INSTALLED_MODULE_STEM"]
Jaewoong Jung8aae22e2019-07-17 10:21:49 -07001908 if !reflect.DeepEqual(actualValues, expectedValues) {
1909 t.Errorf("Incorrect LOCAL_INSTALLED_MODULE_STEM value '%s', expected '%s'",
1910 actualValues, expectedValues)
1911 }
1912 }
1913}
1914
Jaewoong Jung1ce9ac62019-08-13 14:11:33 -07001915func TestAndroidAppImport_ArchVariants(t *testing.T) {
1916 // The test config's target arch is ARM64.
1917 testCases := []struct {
1918 name string
1919 bp string
1920 expected string
1921 }{
1922 {
1923 name: "matching arch",
1924 bp: `
1925 android_app_import {
1926 name: "foo",
1927 apk: "prebuilts/apk/app.apk",
1928 arch: {
1929 arm64: {
1930 apk: "prebuilts/apk/app_arm64.apk",
1931 },
1932 },
Jaewoong Jung961d4fd2019-08-22 14:25:58 -07001933 presigned: true,
Jaewoong Jung1ce9ac62019-08-13 14:11:33 -07001934 dex_preopt: {
1935 enabled: true,
1936 },
1937 }
1938 `,
1939 expected: "prebuilts/apk/app_arm64.apk",
1940 },
1941 {
1942 name: "no matching arch",
1943 bp: `
1944 android_app_import {
1945 name: "foo",
1946 apk: "prebuilts/apk/app.apk",
1947 arch: {
1948 arm: {
1949 apk: "prebuilts/apk/app_arm.apk",
1950 },
1951 },
Jaewoong Jung961d4fd2019-08-22 14:25:58 -07001952 presigned: true,
Jaewoong Jung1ce9ac62019-08-13 14:11:33 -07001953 dex_preopt: {
1954 enabled: true,
1955 },
1956 }
1957 `,
1958 expected: "prebuilts/apk/app.apk",
1959 },
1960 }
1961
1962 jniRuleRe := regexp.MustCompile("^if \\(zipinfo (\\S+)")
1963 for _, test := range testCases {
1964 ctx, _ := testJava(t, test.bp)
1965
1966 variant := ctx.ModuleForTests("foo", "android_common")
1967 jniRuleCommand := variant.Output("jnis-uncompressed/foo.apk").RuleParams.Command
1968 matches := jniRuleRe.FindStringSubmatch(jniRuleCommand)
1969 if len(matches) != 2 {
1970 t.Errorf("failed to extract the src apk path from %q", jniRuleCommand)
1971 }
1972 if test.expected != matches[1] {
1973 t.Errorf("wrong src apk, expected: %q got: %q", test.expected, matches[1])
1974 }
1975 }
1976}
1977
Jaewoong Jungb28eb5f2019-08-27 15:01:50 -07001978func TestAndroidTestImport(t *testing.T) {
1979 ctx, config := testJava(t, `
1980 android_test_import {
1981 name: "foo",
1982 apk: "prebuilts/apk/app.apk",
1983 presigned: true,
1984 data: [
1985 "testdata/data",
1986 ],
1987 }
1988 `)
1989
1990 test := ctx.ModuleForTests("foo", "android_common").Module().(*AndroidTestImport)
1991
1992 // Check android mks.
Jiyong Park0b0e1b92019-12-03 13:24:29 +09001993 entries := android.AndroidMkEntriesForTest(t, config, "", test)[0]
Jaewoong Jungb28eb5f2019-08-27 15:01:50 -07001994 expected := []string{"tests"}
1995 actual := entries.EntryMap["LOCAL_MODULE_TAGS"]
1996 if !reflect.DeepEqual(expected, actual) {
1997 t.Errorf("Unexpected module tags - expected: %q, actual: %q", expected, actual)
1998 }
1999 expected = []string{"testdata/data:testdata/data"}
2000 actual = entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"]
2001 if !reflect.DeepEqual(expected, actual) {
2002 t.Errorf("Unexpected test data - expected: %q, actual: %q", expected, actual)
2003 }
2004}
2005
Jaewoong Jung7c5bd832020-01-13 09:55:39 -08002006func TestAndroidTestImport_NoJinUncompressForPresigned(t *testing.T) {
2007 ctx, _ := testJava(t, `
2008 android_test_import {
2009 name: "foo",
2010 apk: "prebuilts/apk/app.apk",
2011 certificate: "cert/new_cert",
2012 data: [
2013 "testdata/data",
2014 ],
2015 }
2016
2017 android_test_import {
2018 name: "foo_presigned",
2019 apk: "prebuilts/apk/app.apk",
2020 presigned: true,
2021 data: [
2022 "testdata/data",
2023 ],
2024 }
2025 `)
2026
2027 variant := ctx.ModuleForTests("foo", "android_common")
2028 jniRule := variant.Output("jnis-uncompressed/foo.apk").RuleParams.Command
2029 if !strings.HasPrefix(jniRule, "if (zipinfo") {
2030 t.Errorf("Unexpected JNI uncompress rule command: " + jniRule)
2031 }
2032
2033 variant = ctx.ModuleForTests("foo_presigned", "android_common")
2034 jniRule = variant.Output("jnis-uncompressed/foo_presigned.apk").BuildParams.Rule.String()
2035 if jniRule != android.Cp.String() {
2036 t.Errorf("Unexpected JNI uncompress rule: " + jniRule)
2037 }
2038}
2039
Jaewoong Jungbc625cd2019-05-06 15:48:44 -07002040func TestStl(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07002041 ctx, _ := testJava(t, cc.GatherRequiredDepsForTest(android.Android)+`
Jaewoong Jungbc625cd2019-05-06 15:48:44 -07002042 cc_library {
2043 name: "libjni",
Peter Collingbournead84f972019-12-17 16:46:18 -08002044 sdk_version: "current",
2045 stl: "c++_shared",
Jaewoong Jungbc625cd2019-05-06 15:48:44 -07002046 }
2047
2048 android_test {
2049 name: "stl",
2050 jni_libs: ["libjni"],
2051 compile_multilib: "both",
2052 sdk_version: "current",
2053 stl: "c++_shared",
2054 }
2055
2056 android_test {
2057 name: "system",
2058 jni_libs: ["libjni"],
2059 compile_multilib: "both",
2060 sdk_version: "current",
2061 }
2062 `)
2063
2064 testCases := []struct {
2065 name string
2066 jnis []string
2067 }{
2068 {"stl",
2069 []string{
2070 "libjni.so",
Jaewoong Jung710756a2019-06-04 11:53:47 -07002071 "libc++_shared.so",
Jaewoong Jungbc625cd2019-05-06 15:48:44 -07002072 },
2073 },
2074 {"system",
2075 []string{
2076 "libjni.so",
2077 },
2078 },
2079 }
2080
2081 for _, test := range testCases {
2082 t.Run(test.name, func(t *testing.T) {
2083 app := ctx.ModuleForTests(test.name, "android_common")
2084 jniLibZip := app.Output("jnilibs.zip")
2085 var jnis []string
2086 args := strings.Fields(jniLibZip.Args["jarArgs"])
2087 for i := 0; i < len(args); i++ {
2088 if args[i] == "-f" {
2089 jnis = append(jnis, args[i+1])
2090 i += 1
2091 }
2092 }
2093 jnisJoined := strings.Join(jnis, " ")
2094 for _, jni := range test.jnis {
2095 if !strings.Contains(jnisJoined, jni) {
2096 t.Errorf("missing jni %q in %q", jni, jnis)
2097 }
2098 }
2099 })
2100 }
2101}
Colin Cross50ddcc42019-05-16 12:28:22 -07002102
2103func TestUsesLibraries(t *testing.T) {
2104 bp := `
2105 java_sdk_library {
2106 name: "foo",
2107 srcs: ["a.java"],
2108 api_packages: ["foo"],
Jeongik Cha538c0d02019-07-11 15:54:27 +09002109 sdk_version: "current",
Colin Cross50ddcc42019-05-16 12:28:22 -07002110 }
2111
2112 java_sdk_library {
2113 name: "bar",
2114 srcs: ["a.java"],
2115 api_packages: ["bar"],
Jeongik Cha538c0d02019-07-11 15:54:27 +09002116 sdk_version: "current",
Colin Cross50ddcc42019-05-16 12:28:22 -07002117 }
2118
2119 android_app {
2120 name: "app",
2121 srcs: ["a.java"],
2122 uses_libs: ["foo"],
Jeongik Cha538c0d02019-07-11 15:54:27 +09002123 sdk_version: "current",
Colin Cross50ddcc42019-05-16 12:28:22 -07002124 optional_uses_libs: [
2125 "bar",
2126 "baz",
2127 ],
2128 }
2129
2130 android_app_import {
2131 name: "prebuilt",
2132 apk: "prebuilts/apk/app.apk",
2133 certificate: "platform",
2134 uses_libs: ["foo"],
2135 optional_uses_libs: [
2136 "bar",
2137 "baz",
2138 ],
2139 }
2140 `
2141
Colin Cross98be1bb2019-12-13 20:41:13 -08002142 config := testAppConfig(nil, bp, nil)
Colin Cross50ddcc42019-05-16 12:28:22 -07002143 config.TestProductVariables.MissingUsesLibraries = []string{"baz"}
2144
Colin Cross98be1bb2019-12-13 20:41:13 -08002145 ctx := testContext()
Colin Cross50ddcc42019-05-16 12:28:22 -07002146
2147 run(t, ctx, config)
2148
2149 app := ctx.ModuleForTests("app", "android_common")
2150 prebuilt := ctx.ModuleForTests("prebuilt", "android_common")
2151
2152 // Test that all libraries are verified
2153 cmd := app.Rule("verify_uses_libraries").RuleParams.Command
2154 if w := "--uses-library foo"; !strings.Contains(cmd, w) {
2155 t.Errorf("wanted %q in %q", w, cmd)
2156 }
2157
2158 if w := "--optional-uses-library bar --optional-uses-library baz"; !strings.Contains(cmd, w) {
2159 t.Errorf("wanted %q in %q", w, cmd)
2160 }
2161
2162 cmd = prebuilt.Rule("verify_uses_libraries").RuleParams.Command
2163
2164 if w := `uses_library_names="foo"`; !strings.Contains(cmd, w) {
2165 t.Errorf("wanted %q in %q", w, cmd)
2166 }
2167
2168 if w := `optional_uses_library_names="bar baz"`; !strings.Contains(cmd, w) {
2169 t.Errorf("wanted %q in %q", w, cmd)
2170 }
2171
2172 // Test that only present libraries are preopted
2173 cmd = app.Rule("dexpreopt").RuleParams.Command
2174
2175 if w := `dex_preopt_target_libraries="/system/framework/foo.jar /system/framework/bar.jar"`; !strings.Contains(cmd, w) {
2176 t.Errorf("wanted %q in %q", w, cmd)
2177 }
2178
2179 cmd = prebuilt.Rule("dexpreopt").RuleParams.Command
2180
2181 if w := `dex_preopt_target_libraries="/system/framework/foo.jar /system/framework/bar.jar"`; !strings.Contains(cmd, w) {
2182 t.Errorf("wanted %q in %q", w, cmd)
2183 }
2184}
Jaewoong Jungc27ab662019-05-30 15:51:14 -07002185
2186func TestCodelessApp(t *testing.T) {
2187 testCases := []struct {
2188 name string
2189 bp string
2190 noCode bool
2191 }{
2192 {
2193 name: "normal",
2194 bp: `
2195 android_app {
2196 name: "foo",
2197 srcs: ["a.java"],
Jeongik Cha538c0d02019-07-11 15:54:27 +09002198 sdk_version: "current",
Jaewoong Jungc27ab662019-05-30 15:51:14 -07002199 }
2200 `,
2201 noCode: false,
2202 },
2203 {
2204 name: "app without sources",
2205 bp: `
2206 android_app {
2207 name: "foo",
Jeongik Cha538c0d02019-07-11 15:54:27 +09002208 sdk_version: "current",
Jaewoong Jungc27ab662019-05-30 15:51:14 -07002209 }
2210 `,
2211 noCode: true,
2212 },
2213 {
2214 name: "app with libraries",
2215 bp: `
2216 android_app {
2217 name: "foo",
2218 static_libs: ["lib"],
Jeongik Cha538c0d02019-07-11 15:54:27 +09002219 sdk_version: "current",
Jaewoong Jungc27ab662019-05-30 15:51:14 -07002220 }
2221
2222 java_library {
2223 name: "lib",
2224 srcs: ["a.java"],
Jeongik Cha538c0d02019-07-11 15:54:27 +09002225 sdk_version: "current",
Jaewoong Jungc27ab662019-05-30 15:51:14 -07002226 }
2227 `,
2228 noCode: false,
2229 },
2230 {
2231 name: "app with sourceless libraries",
2232 bp: `
2233 android_app {
2234 name: "foo",
2235 static_libs: ["lib"],
Jeongik Cha538c0d02019-07-11 15:54:27 +09002236 sdk_version: "current",
Jaewoong Jungc27ab662019-05-30 15:51:14 -07002237 }
2238
2239 java_library {
2240 name: "lib",
Jeongik Cha538c0d02019-07-11 15:54:27 +09002241 sdk_version: "current",
Jaewoong Jungc27ab662019-05-30 15:51:14 -07002242 }
2243 `,
2244 // TODO(jungjw): this should probably be true
2245 noCode: false,
2246 },
2247 }
2248
2249 for _, test := range testCases {
2250 t.Run(test.name, func(t *testing.T) {
2251 ctx := testApp(t, test.bp)
2252
2253 foo := ctx.ModuleForTests("foo", "android_common")
2254 manifestFixerArgs := foo.Output("manifest_fixer/AndroidManifest.xml").Args["args"]
2255 if strings.Contains(manifestFixerArgs, "--has-no-code") != test.noCode {
2256 t.Errorf("unexpected manifest_fixer args: %q", manifestFixerArgs)
2257 }
2258 })
2259 }
2260}
Jaewoong Jung5b425e22019-06-17 17:40:56 -07002261
2262func TestEmbedNotice(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07002263 ctx, _ := testJava(t, cc.GatherRequiredDepsForTest(android.Android)+`
Jaewoong Jung5b425e22019-06-17 17:40:56 -07002264 android_app {
2265 name: "foo",
2266 srcs: ["a.java"],
2267 static_libs: ["javalib"],
2268 jni_libs: ["libjni"],
2269 notice: "APP_NOTICE",
2270 embed_notices: true,
Jeongik Cha538c0d02019-07-11 15:54:27 +09002271 sdk_version: "current",
Jaewoong Jung5b425e22019-06-17 17:40:56 -07002272 }
2273
2274 // No embed_notice flag
2275 android_app {
2276 name: "bar",
2277 srcs: ["a.java"],
2278 jni_libs: ["libjni"],
2279 notice: "APP_NOTICE",
Jeongik Cha538c0d02019-07-11 15:54:27 +09002280 sdk_version: "current",
Jaewoong Jung5b425e22019-06-17 17:40:56 -07002281 }
2282
2283 // No NOTICE files
2284 android_app {
2285 name: "baz",
2286 srcs: ["a.java"],
2287 embed_notices: true,
Jeongik Cha538c0d02019-07-11 15:54:27 +09002288 sdk_version: "current",
Jaewoong Jung5b425e22019-06-17 17:40:56 -07002289 }
2290
2291 cc_library {
2292 name: "libjni",
2293 system_shared_libs: [],
2294 stl: "none",
2295 notice: "LIB_NOTICE",
2296 }
2297
2298 java_library {
2299 name: "javalib",
2300 srcs: [
2301 ":gen",
2302 ],
Jeongik Cha538c0d02019-07-11 15:54:27 +09002303 sdk_version: "current",
Jaewoong Jung5b425e22019-06-17 17:40:56 -07002304 }
2305
2306 genrule {
2307 name: "gen",
2308 tools: ["gentool"],
2309 out: ["gen.java"],
2310 notice: "GENRULE_NOTICE",
2311 }
2312
2313 java_binary_host {
2314 name: "gentool",
2315 srcs: ["b.java"],
2316 notice: "TOOL_NOTICE",
2317 }
2318 `)
2319
2320 // foo has NOTICE files to process, and embed_notices is true.
2321 foo := ctx.ModuleForTests("foo", "android_common")
2322 // verify merge notices rule.
2323 mergeNotices := foo.Rule("mergeNoticesRule")
2324 noticeInputs := mergeNotices.Inputs.Strings()
2325 // TOOL_NOTICE should be excluded as it's a host module.
2326 if len(mergeNotices.Inputs) != 3 {
2327 t.Errorf("number of input notice files: expected = 3, actual = %q", noticeInputs)
2328 }
2329 if !inList("APP_NOTICE", noticeInputs) {
2330 t.Errorf("APP_NOTICE is missing from notice files, %q", noticeInputs)
2331 }
2332 if !inList("LIB_NOTICE", noticeInputs) {
2333 t.Errorf("LIB_NOTICE is missing from notice files, %q", noticeInputs)
2334 }
2335 if !inList("GENRULE_NOTICE", noticeInputs) {
2336 t.Errorf("GENRULE_NOTICE is missing from notice files, %q", noticeInputs)
2337 }
2338 // aapt2 flags should include -A <NOTICE dir> so that its contents are put in the APK's /assets.
2339 res := foo.Output("package-res.apk")
2340 aapt2Flags := res.Args["flags"]
2341 e := "-A " + buildDir + "/.intermediates/foo/android_common/NOTICE"
2342 if !strings.Contains(aapt2Flags, e) {
2343 t.Errorf("asset dir flag for NOTICE, %q is missing in aapt2 link flags, %q", e, aapt2Flags)
2344 }
2345
2346 // bar has NOTICE files to process, but embed_notices is not set.
2347 bar := ctx.ModuleForTests("bar", "android_common")
Jaewoong Jung98772792019-07-01 17:15:13 -07002348 res = bar.Output("package-res.apk")
2349 aapt2Flags = res.Args["flags"]
2350 e = "-A " + buildDir + "/.intermediates/bar/android_common/NOTICE"
2351 if strings.Contains(aapt2Flags, e) {
2352 t.Errorf("bar shouldn't have the asset dir flag for NOTICE: %q", e)
Jaewoong Jung5b425e22019-06-17 17:40:56 -07002353 }
2354
2355 // baz's embed_notice is true, but it doesn't have any NOTICE files.
2356 baz := ctx.ModuleForTests("baz", "android_common")
Jaewoong Jung98772792019-07-01 17:15:13 -07002357 res = baz.Output("package-res.apk")
2358 aapt2Flags = res.Args["flags"]
2359 e = "-A " + buildDir + "/.intermediates/baz/android_common/NOTICE"
2360 if strings.Contains(aapt2Flags, e) {
2361 t.Errorf("baz shouldn't have the asset dir flag for NOTICE: %q", e)
Jaewoong Jung5b425e22019-06-17 17:40:56 -07002362 }
2363}
Colin Cross53a87f52019-06-25 13:35:30 -07002364
2365func TestUncompressDex(t *testing.T) {
2366 testCases := []struct {
2367 name string
2368 bp string
2369
2370 uncompressedPlatform bool
2371 uncompressedUnbundled bool
2372 }{
2373 {
2374 name: "normal",
2375 bp: `
2376 android_app {
2377 name: "foo",
2378 srcs: ["a.java"],
Jeongik Cha538c0d02019-07-11 15:54:27 +09002379 sdk_version: "current",
Colin Cross53a87f52019-06-25 13:35:30 -07002380 }
2381 `,
2382 uncompressedPlatform: true,
2383 uncompressedUnbundled: false,
2384 },
2385 {
2386 name: "use_embedded_dex",
2387 bp: `
2388 android_app {
2389 name: "foo",
2390 use_embedded_dex: true,
2391 srcs: ["a.java"],
Jeongik Cha538c0d02019-07-11 15:54:27 +09002392 sdk_version: "current",
Colin Cross53a87f52019-06-25 13:35:30 -07002393 }
2394 `,
2395 uncompressedPlatform: true,
2396 uncompressedUnbundled: true,
2397 },
2398 {
2399 name: "privileged",
2400 bp: `
2401 android_app {
2402 name: "foo",
2403 privileged: true,
2404 srcs: ["a.java"],
Jeongik Cha538c0d02019-07-11 15:54:27 +09002405 sdk_version: "current",
Colin Cross53a87f52019-06-25 13:35:30 -07002406 }
2407 `,
2408 uncompressedPlatform: true,
2409 uncompressedUnbundled: true,
2410 },
2411 }
2412
2413 test := func(t *testing.T, bp string, want bool, unbundled bool) {
2414 t.Helper()
2415
Colin Cross98be1bb2019-12-13 20:41:13 -08002416 config := testAppConfig(nil, bp, nil)
Colin Cross53a87f52019-06-25 13:35:30 -07002417 if unbundled {
2418 config.TestProductVariables.Unbundled_build = proptools.BoolPtr(true)
2419 }
2420
Colin Cross98be1bb2019-12-13 20:41:13 -08002421 ctx := testContext()
Colin Cross53a87f52019-06-25 13:35:30 -07002422
2423 run(t, ctx, config)
2424
2425 foo := ctx.ModuleForTests("foo", "android_common")
2426 dex := foo.Rule("r8")
2427 uncompressedInDexJar := strings.Contains(dex.Args["zipFlags"], "-L 0")
2428 aligned := foo.MaybeRule("zipalign").Rule != nil
2429
2430 if uncompressedInDexJar != want {
2431 t.Errorf("want uncompressed in dex %v, got %v", want, uncompressedInDexJar)
2432 }
2433
2434 if aligned != want {
2435 t.Errorf("want aligned %v, got %v", want, aligned)
2436 }
2437 }
2438
2439 for _, tt := range testCases {
2440 t.Run(tt.name, func(t *testing.T) {
2441 t.Run("platform", func(t *testing.T) {
2442 test(t, tt.bp, tt.uncompressedPlatform, false)
2443 })
2444 t.Run("unbundled", func(t *testing.T) {
2445 test(t, tt.bp, tt.uncompressedUnbundled, true)
2446 })
2447 })
2448 }
2449}
Jaewoong Jung26dedd32019-06-06 08:45:58 -07002450
2451func checkAapt2LinkFlag(t *testing.T, aapt2Flags, flagName, expectedValue string) {
2452 if expectedValue != "" {
2453 expectedFlag := "--" + flagName + " " + expectedValue
2454 if !strings.Contains(aapt2Flags, expectedFlag) {
2455 t.Errorf("%q is missing in aapt2 link flags, %q", expectedFlag, aapt2Flags)
2456 }
2457 } else {
2458 unexpectedFlag := "--" + flagName
2459 if strings.Contains(aapt2Flags, unexpectedFlag) {
2460 t.Errorf("unexpected flag, %q is found in aapt2 link flags, %q", unexpectedFlag, aapt2Flags)
2461 }
2462 }
2463}
Jaewoong Jung9befb0c2020-01-18 10:33:43 -08002464
2465func TestRuntimeResourceOverlay(t *testing.T) {
Jaewoong Jungca095d72020-04-09 16:15:30 -07002466 fs := map[string][]byte{
2467 "baz/res/res/values/strings.xml": nil,
2468 "bar/res/res/values/strings.xml": nil,
2469 }
2470 bp := `
Jaewoong Jung9befb0c2020-01-18 10:33:43 -08002471 runtime_resource_overlay {
2472 name: "foo",
2473 certificate: "platform",
2474 product_specific: true,
Jaewoong Jungca095d72020-04-09 16:15:30 -07002475 static_libs: ["bar"],
2476 resource_libs: ["baz"],
Jaewoong Jungf0f747c2020-01-24 10:30:02 -08002477 aaptflags: ["--keep-raw-values"],
Jaewoong Jung9befb0c2020-01-18 10:33:43 -08002478 }
2479
2480 runtime_resource_overlay {
2481 name: "foo_themed",
2482 certificate: "platform",
2483 product_specific: true,
2484 theme: "faza",
2485 }
Jaewoong Jungca095d72020-04-09 16:15:30 -07002486
2487 android_library {
2488 name: "bar",
2489 resource_dirs: ["bar/res"],
2490 }
2491
2492 android_app {
2493 name: "baz",
2494 sdk_version: "current",
2495 resource_dirs: ["baz/res"],
2496 }
2497 `
2498 config := testAppConfig(nil, bp, fs)
2499 ctx := testContext()
2500 run(t, ctx, config)
Jaewoong Jung9befb0c2020-01-18 10:33:43 -08002501
2502 m := ctx.ModuleForTests("foo", "android_common")
2503
Jaewoong Jungf0f747c2020-01-24 10:30:02 -08002504 // Check AAPT2 link flags.
2505 aapt2Flags := m.Output("package-res.apk").Args["flags"]
2506 expectedFlags := []string{"--keep-raw-values", "--no-resource-deduping", "--no-resource-removal"}
2507 absentFlags := android.RemoveListFromList(expectedFlags, strings.Split(aapt2Flags, " "))
2508 if len(absentFlags) > 0 {
2509 t.Errorf("expected values, %q are missing in aapt2 link flags, %q", absentFlags, aapt2Flags)
2510 }
2511
Jaewoong Jungca095d72020-04-09 16:15:30 -07002512 // Check overlay.list output for static_libs dependency.
2513 overlayList := m.Output("aapt2/overlay.list").Inputs.Strings()
2514 staticLibPackage := buildDir + "/.intermediates/bar/android_common/package-res.apk"
2515 if !inList(staticLibPackage, overlayList) {
2516 t.Errorf("Stactic lib res package %q missing in overlay list: %q", staticLibPackage, overlayList)
2517 }
2518
2519 // Check AAPT2 link flags for resource_libs dependency.
2520 resourceLibFlag := "-I " + buildDir + "/.intermediates/baz/android_common/package-res.apk"
2521 if !strings.Contains(aapt2Flags, resourceLibFlag) {
2522 t.Errorf("Resource lib flag %q missing in aapt2 link flags: %q", resourceLibFlag, aapt2Flags)
2523 }
2524
Jaewoong Jung9befb0c2020-01-18 10:33:43 -08002525 // Check cert signing flag.
2526 signedApk := m.Output("signed/foo.apk")
2527 signingFlag := signedApk.Args["certificates"]
2528 expected := "build/make/target/product/security/platform.x509.pem build/make/target/product/security/platform.pk8"
2529 if expected != signingFlag {
2530 t.Errorf("Incorrect signing flags, expected: %q, got: %q", expected, signingFlag)
2531 }
Jaewoong Jung78ec5d82020-01-31 10:11:47 -08002532 path := android.AndroidMkEntriesForTest(t, config, "", m.Module())[0].EntryMap["LOCAL_CERTIFICATE"]
2533 expectedPath := []string{"build/make/target/product/security/platform.x509.pem"}
2534 if !reflect.DeepEqual(path, expectedPath) {
2535 t.Errorf("Unexpected LOCAL_CERTIFICATE value: %v, expected: %v", path, expectedPath)
2536 }
Jaewoong Jung9befb0c2020-01-18 10:33:43 -08002537
2538 // Check device location.
Jaewoong Jung78ec5d82020-01-31 10:11:47 -08002539 path = android.AndroidMkEntriesForTest(t, config, "", m.Module())[0].EntryMap["LOCAL_MODULE_PATH"]
2540 expectedPath = []string{"/tmp/target/product/test_device/product/overlay"}
Jaewoong Jung9befb0c2020-01-18 10:33:43 -08002541 if !reflect.DeepEqual(path, expectedPath) {
2542 t.Errorf("Unexpected LOCAL_MODULE_PATH value: %v, expected: %v", path, expectedPath)
2543 }
2544
2545 // A themed module has a different device location
2546 m = ctx.ModuleForTests("foo_themed", "android_common")
2547 path = android.AndroidMkEntriesForTest(t, config, "", m.Module())[0].EntryMap["LOCAL_MODULE_PATH"]
2548 expectedPath = []string{"/tmp/target/product/test_device/product/overlay/faza"}
2549 if !reflect.DeepEqual(path, expectedPath) {
2550 t.Errorf("Unexpected LOCAL_MODULE_PATH value: %v, expected: %v", path, expectedPath)
2551 }
2552}