blob: f93d69c8fd6883905c0fccdfa20d6a50159be2e2 [file] [log] [blame]
Colin Cross72bb3632017-07-13 16:23:21 -07001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
Colin Cross72bb3632017-07-13 16:23:21 -070018 "io/ioutil"
19 "os"
20 "path/filepath"
Colin Crossc0806172019-06-14 18:51:47 -070021 "reflect"
Nan Zhang61eaedb2017-11-02 13:28:15 -070022 "strconv"
Colin Cross72bb3632017-07-13 16:23:21 -070023 "strings"
24 "testing"
Colin Cross86a60ae2018-05-29 14:44:55 -070025
Jeongik Cha28df2572019-11-11 10:46:36 +090026 "github.com/google/blueprint/proptools"
27
Colin Crossa4f08812018-10-02 22:03:40 -070028 "android/soong/android"
29 "android/soong/cc"
Colin Crossc28bb0b2019-02-25 14:20:47 -080030 "android/soong/dexpreopt"
Colin Crossa4f08812018-10-02 22:03:40 -070031 "android/soong/genrule"
Colin Cross72bb3632017-07-13 16:23:21 -070032)
33
34var buildDir string
35
36func setUp() {
37 var err error
38 buildDir, err = ioutil.TempDir("", "soong_java_test")
39 if err != nil {
40 panic(err)
41 }
42}
43
44func tearDown() {
45 os.RemoveAll(buildDir)
46}
47
48func TestMain(m *testing.M) {
49 run := func() int {
50 setUp()
51 defer tearDown()
52
53 return m.Run()
54 }
55
56 os.Exit(run())
57}
Colin Cross527012a2017-11-30 22:56:16 -080058
Colin Cross98be1bb2019-12-13 20:41:13 -080059func testConfig(env map[string]string, bp string, fs map[string][]byte) android.Config {
60 return TestConfig(buildDir, env, bp, fs)
Colin Cross1369cdb2017-09-29 17:58:17 -070061}
62
Colin Cross98be1bb2019-12-13 20:41:13 -080063func testContext() *android.TestContext {
Colin Cross72bb3632017-07-13 16:23:21 -070064
Colin Cross4c428df2017-09-15 17:36:05 -070065 ctx := android.NewTestArchContext()
Paul Duffinf9b1da02019-12-18 19:51:55 +000066 RegisterJavaBuildComponents(ctx)
67 RegisterAppBuildComponents(ctx)
68 RegisterAARBuildComponents(ctx)
Paul Duffinb0f85072019-12-19 10:28:56 +000069 RegisterGenRuleBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000070 RegisterSystemModulesBuildComponents(ctx)
Colin Cross4b49b762019-11-22 15:25:03 -080071 ctx.RegisterModuleType("java_plugin", PluginFactory)
Colin Cross4b49b762019-11-22 15:25:03 -080072 ctx.RegisterModuleType("filegroup", android.FileGroupFactory)
73 ctx.RegisterModuleType("genrule", genrule.GenRuleFactory)
Paul Duffin884363e2019-12-19 10:21:09 +000074 RegisterDocsBuildComponents(ctx)
75 RegisterStubsBuildComponents(ctx)
Paul Duffin43dc1cc2019-12-19 11:18:54 +000076 RegisterSdkLibraryBuildComponents(ctx)
Paul Duffin0c4979b2019-12-19 15:11:53 +000077 android.RegisterPrebuiltMutators(ctx)
Colin Cross89536d42017-07-07 14:35:50 -070078 ctx.PreArchMutators(android.RegisterDefaultsPreArchMutators)
Paul Duffina48f7582019-12-19 11:25:19 +000079
80 RegisterPrebuiltApisBuildComponents(ctx)
81
Jaewoong Jungb639a6a2019-05-10 15:16:29 -070082 ctx.PostDepsMutators(android.RegisterOverridePostDepsMutators)
Colin Cross3bc7ffa2017-11-22 16:19:37 -080083 ctx.RegisterPreSingletonType("overlay", android.SingletonFactoryAdaptor(OverlaySingletonFactory))
Colin Cross3047fa22019-04-18 10:56:44 -070084 ctx.RegisterPreSingletonType("sdk_versions", android.SingletonFactoryAdaptor(sdkPreSingletonFactory))
Colin Crossa4f08812018-10-02 22:03:40 -070085
86 // Register module types and mutators from cc needed for JNI testing
Paul Duffin77980a82019-12-19 16:01:36 +000087 cc.RegisterRequiredBuildComponentsForTest(ctx)
Colin Cross4b49b762019-11-22 15:25:03 -080088 ctx.RegisterModuleType("ndk_prebuilt_shared_stl", cc.NdkPrebuiltSharedStlFactory)
Colin Crossa4f08812018-10-02 22:03:40 -070089
Colin Cross527012a2017-11-30 22:56:16 -080090 return ctx
91}
92
93func run(t *testing.T, ctx *android.TestContext, config android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -080094 t.Helper()
Colin Crossc28bb0b2019-02-25 14:20:47 -080095
Colin Cross98be1bb2019-12-13 20:41:13 -080096 pathCtx := android.PathContextForTesting(config)
Colin Crossc28bb0b2019-02-25 14:20:47 -080097 setDexpreoptTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
98
Colin Cross98be1bb2019-12-13 20:41:13 -080099 ctx.Register(config)
Paul Duffinbaccf7e2019-06-11 11:58:30 +0100100 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
Logan Chien42039712018-03-12 16:29:17 +0800101 android.FailIfErrored(t, errs)
Colin Cross72bb3632017-07-13 16:23:21 -0700102 _, errs = ctx.PrepareBuildActions(config)
Logan Chien42039712018-03-12 16:29:17 +0800103 android.FailIfErrored(t, errs)
Colin Cross527012a2017-11-30 22:56:16 -0800104}
105
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900106func testJavaError(t *testing.T, pattern string, bp string) (*android.TestContext, android.Config) {
Jeongik Cha538c0d02019-07-11 15:54:27 +0900107 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800108 return testJavaErrorWithConfig(t, pattern, testConfig(nil, bp, nil))
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900109}
110
Colin Cross98be1bb2019-12-13 20:41:13 -0800111func testJavaErrorWithConfig(t *testing.T, pattern string, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900112 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800113 ctx := testContext()
Jeongik Cha538c0d02019-07-11 15:54:27 +0900114
Colin Cross98be1bb2019-12-13 20:41:13 -0800115 pathCtx := android.PathContextForTesting(config)
Jeongik Cha538c0d02019-07-11 15:54:27 +0900116 setDexpreoptTestGlobalConfig(config, dexpreopt.GlobalConfigForTests(pathCtx))
117
Colin Cross98be1bb2019-12-13 20:41:13 -0800118 ctx.Register(config)
Jeongik Cha538c0d02019-07-11 15:54:27 +0900119 _, errs := ctx.ParseBlueprintsFiles("Android.bp")
120 if len(errs) > 0 {
121 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900122 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900123 }
124 _, errs = ctx.PrepareBuildActions(config)
125 if len(errs) > 0 {
126 android.FailIfNoMatchingErrors(t, pattern, errs)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900127 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900128 }
129
130 t.Fatalf("missing expected error %q (0 errors are returned)", pattern)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900131
132 return ctx, config
Jeongik Cha538c0d02019-07-11 15:54:27 +0900133}
134
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700135func testJava(t *testing.T, bp string) (*android.TestContext, android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -0800136 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800137 return testJavaWithConfig(t, testConfig(nil, bp, nil))
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900138}
139
Colin Cross98be1bb2019-12-13 20:41:13 -0800140func testJavaWithConfig(t *testing.T, config android.Config) (*android.TestContext, android.Config) {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900141 t.Helper()
Colin Cross98be1bb2019-12-13 20:41:13 -0800142 ctx := testContext()
Colin Cross527012a2017-11-30 22:56:16 -0800143 run(t, ctx, config)
Colin Cross72bb3632017-07-13 16:23:21 -0700144
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700145 return ctx, config
Colin Cross72bb3632017-07-13 16:23:21 -0700146}
147
Colin Cross2acdae82017-09-15 19:44:24 -0700148func moduleToPath(name string) string {
149 switch {
150 case name == `""`:
151 return name
Colin Crossfc3674a2017-09-18 17:41:52 -0700152 case strings.HasSuffix(name, ".jar"):
153 return name
Nan Zhanged19fc32017-10-19 13:06:22 -0700154 default:
155 return filepath.Join(buildDir, ".intermediates", name, "android_common", "turbine-combined", name+".jar")
Colin Cross2acdae82017-09-15 19:44:24 -0700156 }
157}
158
Jeongik Chae403e9e2019-12-07 00:16:24 +0900159func TestJavaLinkType(t *testing.T) {
160 testJava(t, `
161 java_library {
162 name: "foo",
163 srcs: ["a.java"],
164 libs: ["bar"],
165 static_libs: ["baz"],
166 }
167
168 java_library {
169 name: "bar",
170 sdk_version: "current",
171 srcs: ["b.java"],
172 }
173
174 java_library {
175 name: "baz",
176 sdk_version: "system_current",
177 srcs: ["c.java"],
178 }
179 `)
180
181 testJavaError(t, "Adjust sdk_version: property of the source or target module so that target module is built with the same or smaller API set than the source.", `
182 java_library {
183 name: "foo",
184 srcs: ["a.java"],
185 libs: ["bar"],
186 sdk_version: "current",
187 static_libs: ["baz"],
188 }
189
190 java_library {
191 name: "bar",
192 sdk_version: "current",
193 srcs: ["b.java"],
194 }
195
196 java_library {
197 name: "baz",
198 sdk_version: "system_current",
199 srcs: ["c.java"],
200 }
201 `)
202
203 testJava(t, `
204 java_library {
205 name: "foo",
206 srcs: ["a.java"],
207 libs: ["bar"],
208 sdk_version: "system_current",
209 static_libs: ["baz"],
210 }
211
212 java_library {
213 name: "bar",
214 sdk_version: "current",
215 srcs: ["b.java"],
216 }
217
218 java_library {
219 name: "baz",
220 sdk_version: "system_current",
221 srcs: ["c.java"],
222 }
223 `)
224
225 testJavaError(t, "Adjust sdk_version: property of the source or target module so that target module is built with the same or smaller API set than the source.", `
226 java_library {
227 name: "foo",
228 srcs: ["a.java"],
229 libs: ["bar"],
230 sdk_version: "system_current",
231 static_libs: ["baz"],
232 }
233
234 java_library {
235 name: "bar",
236 sdk_version: "current",
237 srcs: ["b.java"],
238 }
239
240 java_library {
241 name: "baz",
242 srcs: ["c.java"],
243 }
244 `)
245}
246
Colin Cross72bb3632017-07-13 16:23:21 -0700247func TestSimple(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700248 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700249 java_library {
250 name: "foo",
251 srcs: ["a.java"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700252 libs: ["bar"],
253 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700254 }
255
256 java_library {
257 name: "bar",
258 srcs: ["b.java"],
259 }
260
261 java_library {
262 name: "baz",
263 srcs: ["c.java"],
264 }
Colin Crossd5934c82017-10-02 13:55:26 -0700265 `)
Colin Cross72bb3632017-07-13 16:23:21 -0700266
Colin Cross4c428df2017-09-15 17:36:05 -0700267 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700268 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross72bb3632017-07-13 16:23:21 -0700269
270 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
271 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
272 }
273
Colin Cross1ee23172017-10-18 14:44:18 -0700274 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Nan Zhanged19fc32017-10-19 13:06:22 -0700275 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
276 bazTurbine := filepath.Join(buildDir, ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar")
Colin Cross0a6e0072017-08-30 14:24:55 -0700277
Nan Zhanged19fc32017-10-19 13:06:22 -0700278 if !strings.Contains(javac.Args["classpath"], barTurbine) {
279 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross72bb3632017-07-13 16:23:21 -0700280 }
281
Nan Zhanged19fc32017-10-19 13:06:22 -0700282 if !strings.Contains(javac.Args["classpath"], bazTurbine) {
283 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], bazTurbine)
Colin Cross0a6e0072017-08-30 14:24:55 -0700284 }
285
286 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
287 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross72bb3632017-07-13 16:23:21 -0700288 }
289}
290
Artur Satayev9cf46692019-11-26 18:08:34 +0000291func TestExportedPlugins(t *testing.T) {
292 type Result struct {
293 library string
294 processors string
295 }
296 var tests = []struct {
297 name string
298 extra string
299 results []Result
300 }{
301 {
302 name: "Exported plugin is not a direct plugin",
303 extra: `java_library { name: "exports", srcs: ["a.java"], exported_plugins: ["plugin"] }`,
304 results: []Result{{library: "exports", processors: "-proc:none"}},
305 },
306 {
307 name: "Exports plugin to dependee",
308 extra: `
309 java_library{name: "exports", exported_plugins: ["plugin"]}
310 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
311 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
312 `,
313 results: []Result{
314 {library: "foo", processors: "-processor com.android.TestPlugin"},
315 {library: "bar", processors: "-processor com.android.TestPlugin"},
316 },
317 },
318 {
319 name: "Exports plugin to android_library",
320 extra: `
321 java_library{name: "exports", exported_plugins: ["plugin"]}
322 android_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
323 android_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
324 `,
325 results: []Result{
326 {library: "foo", processors: "-processor com.android.TestPlugin"},
327 {library: "bar", processors: "-processor com.android.TestPlugin"},
328 },
329 },
330 {
331 name: "Exports plugin is not propagated via transitive deps",
332 extra: `
333 java_library{name: "exports", exported_plugins: ["plugin"]}
334 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
335 java_library{name: "bar", srcs: ["a.java"], static_libs: ["foo"]}
336 `,
337 results: []Result{
338 {library: "foo", processors: "-processor com.android.TestPlugin"},
339 {library: "bar", processors: "-proc:none"},
340 },
341 },
342 {
343 name: "Exports plugin appends to plugins",
344 extra: `
345 java_plugin{name: "plugin2", processor_class: "com.android.TestPlugin2"}
346 java_library{name: "exports", exported_plugins: ["plugin"]}
347 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"], plugins: ["plugin2"]}
348 `,
349 results: []Result{
350 {library: "foo", processors: "-processor com.android.TestPlugin,com.android.TestPlugin2"},
351 },
352 },
353 }
354
355 for _, test := range tests {
356 t.Run(test.name, func(t *testing.T) {
357 ctx, _ := testJava(t, `
358 java_plugin {
359 name: "plugin",
360 processor_class: "com.android.TestPlugin",
361 }
362 `+test.extra)
363
364 for _, want := range test.results {
365 javac := ctx.ModuleForTests(want.library, "android_common").Rule("javac")
366 if javac.Args["processor"] != want.processors {
367 t.Errorf("For library %v, expected %v, found %v", want.library, want.processors, javac.Args["processor"])
368 }
369 }
370 })
371 }
372}
373
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900374func TestSdkVersionByPartition(t *testing.T) {
375 testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900376 java_library {
377 name: "foo",
378 srcs: ["a.java"],
379 vendor: true,
380 }
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900381 `)
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900382
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900383 testJava(t, `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900384 java_library {
385 name: "bar",
386 srcs: ["b.java"],
387 }
388 `)
389
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900390 for _, enforce := range []bool{true, false} {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900391 bp := `
392 java_library {
393 name: "foo",
394 srcs: ["a.java"],
395 product_specific: true,
396 }
397 `
Colin Cross98be1bb2019-12-13 20:41:13 -0800398
399 config := testConfig(nil, bp, nil)
400 config.TestProductVariables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900401 if enforce {
Colin Cross98be1bb2019-12-13 20:41:13 -0800402 testJavaErrorWithConfig(t, "sdk_version must have a value when the module is located at vendor or product", config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900403 } else {
Colin Cross98be1bb2019-12-13 20:41:13 -0800404 testJavaWithConfig(t, config)
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900405 }
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900406 }
407}
408
Colin Crossd5934c82017-10-02 13:55:26 -0700409func TestArchSpecific(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700410 ctx, _ := testJava(t, `
Colin Crossd5934c82017-10-02 13:55:26 -0700411 java_library {
412 name: "foo",
413 srcs: ["a.java"],
414 target: {
415 android: {
416 srcs: ["b.java"],
417 },
418 },
419 }
420 `)
421
422 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
423 if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" {
424 t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs)
425 }
426}
427
Colin Cross6b4a32d2017-12-05 13:42:45 -0800428func TestBinary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700429 ctx, _ := testJava(t, `
Colin Cross6b4a32d2017-12-05 13:42:45 -0800430 java_library_host {
431 name: "foo",
432 srcs: ["a.java"],
433 }
434
435 java_binary_host {
436 name: "bar",
437 srcs: ["b.java"],
438 static_libs: ["foo"],
439 }
440 `)
441
442 buildOS := android.BuildOs.String()
443
444 bar := ctx.ModuleForTests("bar", buildOS+"_common")
445 barJar := bar.Output("bar.jar").Output.String()
446 barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64")
447 barWrapperDeps := barWrapper.Output("bar").Implicits.Strings()
448
449 // Test that the install binary wrapper depends on the installed jar file
450 if len(barWrapperDeps) != 1 || barWrapperDeps[0] != barJar {
451 t.Errorf("expected binary wrapper implicits [%q], got %v",
452 barJar, barWrapperDeps)
453 }
454
455}
456
Colin Cross72bb3632017-07-13 16:23:21 -0700457func TestPrebuilts(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700458 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700459 java_library {
460 name: "foo",
Paul Duffin91547182019-11-12 19:39:36 +0000461 srcs: ["a.java", ":stubs-source"],
Colin Cross79c7c262019-04-17 11:11:46 -0700462 libs: ["bar", "sdklib"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700463 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700464 }
465
Colin Cross74d73e22017-08-02 11:05:49 -0700466 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700467 name: "bar",
Colin Cross74d73e22017-08-02 11:05:49 -0700468 jars: ["a.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700469 }
470
Colin Cross74d73e22017-08-02 11:05:49 -0700471 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700472 name: "baz",
Colin Cross74d73e22017-08-02 11:05:49 -0700473 jars: ["b.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700474 }
Colin Cross42be7612019-02-21 18:12:14 -0800475
476 dex_import {
477 name: "qux",
478 jars: ["b.jar"],
479 }
Colin Cross79c7c262019-04-17 11:11:46 -0700480
481 java_sdk_library_import {
482 name: "sdklib",
483 jars: ["b.jar"],
484 }
Paul Duffin91547182019-11-12 19:39:36 +0000485
486 prebuilt_stubs_sources {
487 name: "stubs-source",
488 srcs: ["stubs/sources/**/*.java"],
489 }
Colin Cross72bb3632017-07-13 16:23:21 -0700490 `)
491
Colin Cross4c428df2017-09-15 17:36:05 -0700492 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700493 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross37f6d792018-07-12 12:28:41 -0700494 barJar := ctx.ModuleForTests("bar", "android_common").Rule("combineJar").Output
495 bazJar := ctx.ModuleForTests("baz", "android_common").Rule("combineJar").Output
Colin Cross79c7c262019-04-17 11:11:46 -0700496 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs", "android_common").Rule("combineJar").Output
Colin Cross72bb3632017-07-13 16:23:21 -0700497
Paul Duffin91547182019-11-12 19:39:36 +0000498 inputs := []string{}
499 for _, p := range javac.BuildParams.Inputs {
500 inputs = append(inputs, p.String())
501 }
502
503 expected := []string{
504 "a.java",
505 "stubs/sources/foo/Foo.java",
506 }
507 if !reflect.DeepEqual(expected, inputs) {
508 t.Errorf("foo inputs incorrect: expected %q, found %q", expected, inputs)
509 }
510
Colin Cross37f6d792018-07-12 12:28:41 -0700511 if !strings.Contains(javac.Args["classpath"], barJar.String()) {
512 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700513 }
514
Colin Cross79c7c262019-04-17 11:11:46 -0700515 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
516 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
517 }
518
Colin Cross37f6d792018-07-12 12:28:41 -0700519 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() {
520 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700521 }
Colin Cross42be7612019-02-21 18:12:14 -0800522
523 ctx.ModuleForTests("qux", "android_common").Rule("Cp")
Colin Cross72bb3632017-07-13 16:23:21 -0700524}
525
Colin Cross89536d42017-07-07 14:35:50 -0700526func TestDefaults(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700527 ctx, _ := testJava(t, `
Colin Cross89536d42017-07-07 14:35:50 -0700528 java_defaults {
529 name: "defaults",
530 srcs: ["a.java"],
531 libs: ["bar"],
532 static_libs: ["baz"],
Sasha Smundak2057f822019-04-16 17:16:58 -0700533 optimize: {enabled: false},
Colin Cross89536d42017-07-07 14:35:50 -0700534 }
535
536 java_library {
537 name: "foo",
538 defaults: ["defaults"],
539 }
540
541 java_library {
542 name: "bar",
543 srcs: ["b.java"],
544 }
545
546 java_library {
547 name: "baz",
548 srcs: ["c.java"],
549 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700550
551 android_test {
552 name: "atestOptimize",
553 defaults: ["defaults"],
554 optimize: {enabled: true},
555 }
556
557 android_test {
558 name: "atestNoOptimize",
559 defaults: ["defaults"],
560 }
561
562 android_test {
563 name: "atestDefault",
564 srcs: ["a.java"],
565 }
Colin Cross89536d42017-07-07 14:35:50 -0700566 `)
567
Colin Cross4c428df2017-09-15 17:36:05 -0700568 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700569 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross89536d42017-07-07 14:35:50 -0700570
571 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
572 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
573 }
574
Nan Zhanged19fc32017-10-19 13:06:22 -0700575 barTurbine := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
576 if !strings.Contains(javac.Args["classpath"], barTurbine) {
577 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross89536d42017-07-07 14:35:50 -0700578 }
579
Colin Cross1ee23172017-10-18 14:44:18 -0700580 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Colin Cross0a6e0072017-08-30 14:24:55 -0700581 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
582 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross89536d42017-07-07 14:35:50 -0700583 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700584
585 atestOptimize := ctx.ModuleForTests("atestOptimize", "android_common").MaybeRule("r8")
586 if atestOptimize.Output == nil {
587 t.Errorf("atestOptimize should optimize APK")
588 }
589
590 atestNoOptimize := ctx.ModuleForTests("atestNoOptimize", "android_common").MaybeRule("d8")
591 if atestNoOptimize.Output == nil {
592 t.Errorf("atestNoOptimize should not optimize APK")
593 }
594
595 atestDefault := ctx.ModuleForTests("atestDefault", "android_common").MaybeRule("r8")
596 if atestDefault.Output == nil {
597 t.Errorf("atestDefault should optimize APK")
598 }
Colin Cross89536d42017-07-07 14:35:50 -0700599}
600
Colin Cross0f37af02017-09-27 17:42:05 -0700601func TestResources(t *testing.T) {
602 var table = []struct {
603 name string
604 prop string
605 extra string
606 args string
607 }{
608 {
Colin Crossaf9c55b2017-10-03 14:50:08 -0700609 // Test that a module with java_resource_dirs includes the files
Colin Cross0f37af02017-09-27 17:42:05 -0700610 name: "resource dirs",
Colin Cross824bee32017-11-22 17:27:51 -0800611 prop: `java_resource_dirs: ["java-res"]`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700612 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700613 },
614 {
615 // Test that a module with java_resources includes the files
616 name: "resource files",
Colin Cross0ead1d72018-04-10 13:07:42 -0700617 prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`,
618 args: "-C . -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700619 },
620 {
621 // Test that a module with a filegroup in java_resources includes the files with the
622 // path prefix
623 name: "resource filegroup",
624 prop: `java_resources: [":foo-res"]`,
625 extra: `
626 filegroup {
627 name: "foo-res",
Colin Cross824bee32017-11-22 17:27:51 -0800628 path: "java-res",
Colin Cross0ead1d72018-04-10 13:07:42 -0700629 srcs: ["java-res/a/a", "java-res/b/b"],
Colin Cross0f37af02017-09-27 17:42:05 -0700630 }`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700631 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700632 },
633 {
Colin Cross0ead1d72018-04-10 13:07:42 -0700634 // Test that a module with wildcards in java_resource_dirs has the correct path prefixes
635 name: "wildcard dirs",
636 prop: `java_resource_dirs: ["java-res/*"]`,
637 args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b",
638 },
639 {
640 // Test that a module exclude_java_resource_dirs excludes the files
641 name: "wildcard dirs",
642 prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`,
643 args: "-C java-res/a -f java-res/a/a",
644 },
Colin Crosscedd4762018-09-13 11:26:19 -0700645 {
646 // Test wildcards in java_resources
647 name: "wildcard files",
648 prop: `java_resources: ["java-res/**/*"]`,
649 args: "-C . -f java-res/a/a -f java-res/b/b",
650 },
651 {
652 // Test exclude_java_resources with java_resources
653 name: "wildcard files with exclude",
654 prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`,
655 args: "-C . -f java-res/a/a",
656 },
657 {
658 // Test exclude_java_resources with java_resource_dirs
659 name: "resource dirs with exclude files",
660 prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`,
661 args: "-C java-res -f java-res/a/a",
662 },
663 {
664 // Test exclude_java_resource_dirs with java_resource_dirs
665 name: "resource dirs with exclude files",
666 prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`,
667 args: "-C java-res -f java-res/a/a -f java-res/b/b",
668 },
Colin Cross0f37af02017-09-27 17:42:05 -0700669 }
670
671 for _, test := range table {
672 t.Run(test.name, func(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700673 ctx, _ := testJava(t, `
Colin Cross0f37af02017-09-27 17:42:05 -0700674 java_library {
675 name: "foo",
676 srcs: [
677 "a.java",
678 "b.java",
679 "c.java",
680 ],
681 `+test.prop+`,
682 }
683 `+test.extra)
684
Colin Cross331a1212018-08-15 20:40:52 -0700685 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
Colin Cross1ee23172017-10-18 14:44:18 -0700686 fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar")
Colin Cross0f37af02017-09-27 17:42:05 -0700687
688 if !inList(fooRes.Output.String(), foo.Inputs.Strings()) {
689 t.Errorf("foo combined jars %v does not contain %q",
690 foo.Inputs.Strings(), fooRes.Output.String())
691 }
692
Colin Crossaf9c55b2017-10-03 14:50:08 -0700693 if fooRes.Args["jarArgs"] != test.args {
694 t.Errorf("foo resource jar args %q is not %q",
Colin Cross0f37af02017-09-27 17:42:05 -0700695 fooRes.Args["jarArgs"], test.args)
696 }
697 })
698 }
699}
700
Colin Cross0c4ce212019-05-03 15:28:19 -0700701func TestIncludeSrcs(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700702 ctx, _ := testJava(t, `
Colin Cross0c4ce212019-05-03 15:28:19 -0700703 java_library {
704 name: "foo",
705 srcs: [
706 "a.java",
707 "b.java",
708 "c.java",
709 ],
710 include_srcs: true,
711 }
712
713 java_library {
714 name: "bar",
715 srcs: [
716 "a.java",
717 "b.java",
718 "c.java",
719 ],
720 java_resource_dirs: ["java-res"],
721 include_srcs: true,
722 }
723 `)
724
725 // Test a library with include_srcs: true
726 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
727 fooSrcJar := ctx.ModuleForTests("foo", "android_common").Output("foo.srcjar")
728
729 if g, w := fooSrcJar.Output.String(), foo.Inputs.Strings(); !inList(g, w) {
730 t.Errorf("foo combined jars %v does not contain %q", w, g)
731 }
732
733 if g, w := fooSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
734 t.Errorf("foo source jar args %q is not %q", w, g)
735 }
736
737 // Test a library with include_srcs: true and resources
738 bar := ctx.ModuleForTests("bar", "android_common").Output("withres/bar.jar")
739 barResCombined := ctx.ModuleForTests("bar", "android_common").Output("res-combined/bar.jar")
740 barRes := ctx.ModuleForTests("bar", "android_common").Output("res/bar.jar")
741 barSrcJar := ctx.ModuleForTests("bar", "android_common").Output("bar.srcjar")
742
743 if g, w := barSrcJar.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
744 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
745 }
746
747 if g, w := barRes.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
748 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
749 }
750
751 if g, w := barResCombined.Output.String(), bar.Inputs.Strings(); !inList(g, w) {
752 t.Errorf("bar combined jars %v does not contain %q", w, g)
753 }
754
755 if g, w := barSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
756 t.Errorf("bar source jar args %q is not %q", w, g)
757 }
758
759 if g, w := barRes.Args["jarArgs"], "-C java-res -f java-res/a/a -f java-res/b/b"; g != w {
760 t.Errorf("bar resource jar args %q is not %q", w, g)
761 }
762}
763
Colin Cross54190b32017-10-09 15:34:10 -0700764func TestGeneratedSources(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700765 ctx, _ := testJava(t, `
Colin Cross54190b32017-10-09 15:34:10 -0700766 java_library {
767 name: "foo",
768 srcs: [
769 "a*.java",
770 ":gen",
771 "b*.java",
772 ],
773 }
774
775 genrule {
776 name: "gen",
Colin Cross824bee32017-11-22 17:27:51 -0800777 tool_files: ["java-res/a"],
Colin Cross54190b32017-10-09 15:34:10 -0700778 out: ["gen.java"],
779 }
780 `)
781
782 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
783 genrule := ctx.ModuleForTests("gen", "").Rule("generator")
784
Colin Cross15e86d92017-10-20 15:07:08 -0700785 if filepath.Base(genrule.Output.String()) != "gen.java" {
786 t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String())
Colin Cross54190b32017-10-09 15:34:10 -0700787 }
788
789 if len(javac.Inputs) != 3 ||
790 javac.Inputs[0].String() != "a.java" ||
Colin Cross15e86d92017-10-20 15:07:08 -0700791 javac.Inputs[1].String() != genrule.Output.String() ||
Colin Cross54190b32017-10-09 15:34:10 -0700792 javac.Inputs[2].String() != "b.java" {
793 t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs)
794 }
795}
796
Nan Zhang61eaedb2017-11-02 13:28:15 -0700797func TestTurbine(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700798 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -0700799 java_library {
800 name: "foo",
801 srcs: ["a.java"],
Jiyong Park2d492942018-03-05 17:44:10 +0900802 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -0700803 }
804
805 java_library {
806 name: "bar",
Colin Cross9bc43432017-12-15 20:20:39 -0800807 srcs: ["b.java"],
Nan Zhang61eaedb2017-11-02 13:28:15 -0700808 static_libs: ["foo"],
Jiyong Park2d492942018-03-05 17:44:10 +0900809 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -0700810 }
811
812 java_library {
813 name: "baz",
814 srcs: ["c.java"],
815 libs: ["bar"],
816 sdk_version: "14",
817 }
818 `)
819
820 fooTurbine := ctx.ModuleForTests("foo", "android_common").Rule("turbine")
821 barTurbine := ctx.ModuleForTests("bar", "android_common").Rule("turbine")
822 barJavac := ctx.ModuleForTests("bar", "android_common").Rule("javac")
823 barTurbineCombined := ctx.ModuleForTests("bar", "android_common").Description("for turbine")
824 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
825
826 if len(fooTurbine.Inputs) != 1 || fooTurbine.Inputs[0].String() != "a.java" {
827 t.Errorf(`foo inputs %v != ["a.java"]`, fooTurbine.Inputs)
828 }
829
830 fooHeaderJar := filepath.Join(buildDir, ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar")
831 if !strings.Contains(barTurbine.Args["classpath"], fooHeaderJar) {
832 t.Errorf("bar turbine classpath %v does not contain %q", barTurbine.Args["classpath"], fooHeaderJar)
833 }
834 if !strings.Contains(barJavac.Args["classpath"], fooHeaderJar) {
835 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], fooHeaderJar)
836 }
837 if len(barTurbineCombined.Inputs) != 2 || barTurbineCombined.Inputs[1].String() != fooHeaderJar {
838 t.Errorf("bar turbine combineJar inputs %v does not contain %q", barTurbineCombined.Inputs, fooHeaderJar)
839 }
Anton Hanssonf66efeb2018-04-11 13:57:30 +0100840 if !strings.Contains(bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar") {
Nan Zhang61eaedb2017-11-02 13:28:15 -0700841 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
Anton Hanssonf66efeb2018-04-11 13:57:30 +0100842 "prebuilts/sdk/14/public/android.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -0700843 }
844}
845
846func TestSharding(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700847 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -0700848 java_library {
849 name: "bar",
850 srcs: ["a.java","b.java","c.java"],
851 javac_shard_size: 1
852 }
853 `)
854
855 barHeaderJar := filepath.Join(buildDir, ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
856 for i := 0; i < 3; i++ {
857 barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i))
858 if !strings.Contains(barJavac.Args["classpath"], barHeaderJar) {
859 t.Errorf("bar javac classpath %v does not contain %q", barJavac.Args["classpath"], barHeaderJar)
860 }
861 }
862}
863
Nan Zhang581fd212018-01-10 16:06:12 -0800864func TestDroiddoc(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700865 ctx, _ := testJava(t, `
Paul Duffin884363e2019-12-19 10:21:09 +0000866 droiddoc_exported_dir {
Dan Willemsencc090972018-02-26 14:33:31 -0800867 name: "droiddoc-templates-sdk",
868 path: ".",
869 }
Jiyong Park29074592019-07-07 16:27:47 +0900870 filegroup {
871 name: "bar-doc-aidl-srcs",
872 srcs: ["bar-doc/IBar.aidl"],
873 path: "bar-doc",
874 }
Nan Zhang581fd212018-01-10 16:06:12 -0800875 droiddoc {
876 name: "bar-doc",
877 srcs: [
878 "bar-doc/*.java",
Jiyong Park1e440682018-05-23 18:42:04 +0900879 "bar-doc/IFoo.aidl",
Jiyong Park29074592019-07-07 16:27:47 +0900880 ":bar-doc-aidl-srcs",
Nan Zhang581fd212018-01-10 16:06:12 -0800881 ],
882 exclude_srcs: [
883 "bar-doc/b.java"
884 ],
Dan Willemsencc090972018-02-26 14:33:31 -0800885 custom_template: "droiddoc-templates-sdk",
Nan Zhang581fd212018-01-10 16:06:12 -0800886 hdf: [
887 "android.whichdoc offline",
888 ],
889 knowntags: [
890 "bar-doc/known_oj_tags.txt",
891 ],
892 proofread_file: "libcore-proofread.txt",
893 todo_file: "libcore-docs-todo.html",
894 args: "-offlinemode -title \"libcore\"",
895 }
896 `)
897
Colin Crossc0806172019-06-14 18:51:47 -0700898 barDoc := ctx.ModuleForTests("bar-doc", "android_common").Rule("javadoc")
Jiyong Park1e440682018-05-23 18:42:04 +0900899 var javaSrcs []string
Colin Crossc0806172019-06-14 18:51:47 -0700900 for _, i := range barDoc.Inputs {
Jiyong Park1e440682018-05-23 18:42:04 +0900901 javaSrcs = append(javaSrcs, i.Base())
902 }
Colin Crossc0806172019-06-14 18:51:47 -0700903 if len(javaSrcs) != 1 || javaSrcs[0] != "a.java" {
904 t.Errorf("inputs of bar-doc must be []string{\"a.java\"}, but was %#v.", javaSrcs)
Jiyong Park29074592019-07-07 16:27:47 +0900905 }
906
Colin Crossc0806172019-06-14 18:51:47 -0700907 aidl := ctx.ModuleForTests("bar-doc", "android_common").Rule("aidl")
908 if g, w := barDoc.Implicits.Strings(), aidl.Output.String(); !inList(w, g) {
909 t.Errorf("implicits of bar-doc must contain %q, but was %q.", w, g)
910 }
911
912 if g, w := aidl.Implicits.Strings(), []string{"bar-doc/IBar.aidl", "bar-doc/IFoo.aidl"}; !reflect.DeepEqual(w, g) {
913 t.Errorf("aidl inputs must be %q, but was %q", w, g)
Jiyong Park1e440682018-05-23 18:42:04 +0900914 }
Nan Zhang581fd212018-01-10 16:06:12 -0800915}
916
Colin Cross54250902017-12-05 09:28:08 -0800917func TestJarGenrules(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700918 ctx, _ := testJava(t, `
Colin Cross54250902017-12-05 09:28:08 -0800919 java_library {
920 name: "foo",
921 srcs: ["a.java"],
922 }
923
924 java_genrule {
925 name: "jargen",
926 tool_files: ["b.java"],
927 cmd: "$(location b.java) $(in) $(out)",
928 out: ["jargen.jar"],
929 srcs: [":foo"],
930 }
931
932 java_library {
933 name: "bar",
934 static_libs: ["jargen"],
935 srcs: ["c.java"],
936 }
937
938 java_library {
939 name: "baz",
940 libs: ["jargen"],
941 srcs: ["c.java"],
942 }
943 `)
944
945 foo := ctx.ModuleForTests("foo", "android_common").Output("javac/foo.jar")
946 jargen := ctx.ModuleForTests("jargen", "android_common").Output("jargen.jar")
947 bar := ctx.ModuleForTests("bar", "android_common").Output("javac/bar.jar")
948 baz := ctx.ModuleForTests("baz", "android_common").Output("javac/baz.jar")
949 barCombined := ctx.ModuleForTests("bar", "android_common").Output("combined/bar.jar")
950
951 if len(jargen.Inputs) != 1 || jargen.Inputs[0].String() != foo.Output.String() {
952 t.Errorf("expected jargen inputs [%q], got %q", foo.Output.String(), jargen.Inputs.Strings())
953 }
954
955 if !strings.Contains(bar.Args["classpath"], jargen.Output.String()) {
956 t.Errorf("bar classpath %v does not contain %q", bar.Args["classpath"], jargen.Output.String())
957 }
958
959 if !strings.Contains(baz.Args["classpath"], jargen.Output.String()) {
960 t.Errorf("baz classpath %v does not contain %q", baz.Args["classpath"], jargen.Output.String())
961 }
962
963 if len(barCombined.Inputs) != 2 ||
964 barCombined.Inputs[0].String() != bar.Output.String() ||
965 barCombined.Inputs[1].String() != jargen.Output.String() {
966 t.Errorf("bar combined jar inputs %v is not [%q, %q]",
967 barCombined.Inputs.Strings(), bar.Output.String(), jargen.Output.String())
968 }
969}
970
Nan Zhang27e284d2018-02-09 21:03:53 +0000971func TestExcludeFileGroupInSrcs(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700972 ctx, _ := testJava(t, `
Nan Zhang27e284d2018-02-09 21:03:53 +0000973 java_library {
974 name: "foo",
975 srcs: ["a.java", ":foo-srcs"],
976 exclude_srcs: ["a.java", ":foo-excludes"],
977 }
978
979 filegroup {
980 name: "foo-srcs",
981 srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"],
982 }
983
984 filegroup {
985 name: "foo-excludes",
986 srcs: ["java-fg/a.java", "java-fg/b.java"],
987 }
988 `)
989
990 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
991
992 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" {
993 t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs)
994 }
995}
Jiyong Parkc678ad32018-04-10 13:07:10 +0900996
Paul Duffin52d398a2019-06-11 12:31:14 +0100997func TestJavaLibrary(t *testing.T) {
Colin Cross98be1bb2019-12-13 20:41:13 -0800998 config := testConfig(nil, "", map[string][]byte{
Paul Duffin52d398a2019-06-11 12:31:14 +0100999 "libcore/Android.bp": []byte(`
1000 java_library {
1001 name: "core",
1002 sdk_version: "none",
1003 system_modules: "none",
1004 }`),
1005 })
Colin Cross98be1bb2019-12-13 20:41:13 -08001006 ctx := testContext()
Paul Duffin52d398a2019-06-11 12:31:14 +01001007 run(t, ctx, config)
1008}
1009
Jiyong Parkc678ad32018-04-10 13:07:10 +09001010func TestJavaSdkLibrary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001011 ctx, _ := testJava(t, `
Paul Duffin884363e2019-12-19 10:21:09 +00001012 droiddoc_exported_dir {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001013 name: "droiddoc-templates-sdk",
1014 path: ".",
1015 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001016 java_sdk_library {
1017 name: "foo",
1018 srcs: ["a.java", "b.java"],
1019 api_packages: ["foo"],
1020 }
1021 java_sdk_library {
1022 name: "bar",
1023 srcs: ["a.java", "b.java"],
1024 api_packages: ["bar"],
1025 }
1026 java_library {
1027 name: "baz",
1028 srcs: ["c.java"],
1029 libs: ["foo", "bar"],
1030 sdk_version: "system_current",
1031 }
Jiyong Park1be96912018-05-28 18:02:19 +09001032 java_library {
1033 name: "qux",
1034 srcs: ["c.java"],
1035 libs: ["baz"],
1036 sdk_version: "system_current",
1037 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001038 `)
1039
1040 // check the existence of the internal modules
1041 ctx.ModuleForTests("foo", "android_common")
1042 ctx.ModuleForTests("foo"+sdkStubsLibrarySuffix, "android_common")
1043 ctx.ModuleForTests("foo"+sdkStubsLibrarySuffix+sdkSystemApiSuffix, "android_common")
Jiyong Park58c518b2018-05-12 22:29:12 +09001044 ctx.ModuleForTests("foo"+sdkStubsLibrarySuffix+sdkTestApiSuffix, "android_common")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001045 ctx.ModuleForTests("foo"+sdkDocsSuffix, "android_common")
1046 ctx.ModuleForTests("foo"+sdkDocsSuffix+sdkSystemApiSuffix, "android_common")
Jiyong Park58c518b2018-05-12 22:29:12 +09001047 ctx.ModuleForTests("foo"+sdkDocsSuffix+sdkTestApiSuffix, "android_common")
Colin Cross7113d202019-11-20 16:39:12 -08001048 ctx.ModuleForTests("foo"+sdkXmlFileSuffix, "android_arm64_armv8-a")
Jiyong Park58c518b2018-05-12 22:29:12 +09001049 ctx.ModuleForTests("foo.api.public.28", "")
1050 ctx.ModuleForTests("foo.api.system.28", "")
1051 ctx.ModuleForTests("foo.api.test.28", "")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001052
1053 bazJavac := ctx.ModuleForTests("baz", "android_common").Rule("javac")
1054 // tests if baz is actually linked to the stubs lib
1055 if !strings.Contains(bazJavac.Args["classpath"], "foo.stubs.system.jar") {
1056 t.Errorf("baz javac classpath %v does not contain %q", bazJavac.Args["classpath"],
1057 "foo.stubs.system.jar")
1058 }
1059 // ... and not to the impl lib
Sundong Ahn054b19a2018-10-19 13:46:09 +09001060 if strings.Contains(bazJavac.Args["classpath"], "foo.jar") {
Jiyong Parkc678ad32018-04-10 13:07:10 +09001061 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
Sundong Ahn054b19a2018-10-19 13:46:09 +09001062 "foo.jar")
Jiyong Parkc678ad32018-04-10 13:07:10 +09001063 }
1064 // test if baz is not linked to the system variant of foo
1065 if strings.Contains(bazJavac.Args["classpath"], "foo.stubs.jar") {
1066 t.Errorf("baz javac classpath %v should not contain %q", bazJavac.Args["classpath"],
1067 "foo.stubs.jar")
1068 }
Jiyong Park1be96912018-05-28 18:02:19 +09001069
1070 // test if baz has exported SDK lib names foo and bar to qux
1071 qux := ctx.ModuleForTests("qux", "android_common")
1072 if quxLib, ok := qux.Module().(*Library); ok {
1073 sdkLibs := quxLib.ExportedSdkLibs()
1074 if len(sdkLibs) != 2 || !android.InList("foo", sdkLibs) || !android.InList("bar", sdkLibs) {
1075 t.Errorf("qux should export \"foo\" and \"bar\" but exports %v", sdkLibs)
1076 }
1077 }
Jiyong Parkc678ad32018-04-10 13:07:10 +09001078}
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001079
1080var compilerFlagsTestCases = []struct {
1081 in string
1082 out bool
1083}{
1084 {
1085 in: "a",
1086 out: false,
1087 },
1088 {
1089 in: "-a",
1090 out: true,
1091 },
1092 {
1093 in: "-no-jdk",
1094 out: false,
1095 },
1096 {
1097 in: "-no-stdlib",
1098 out: false,
1099 },
1100 {
1101 in: "-kotlin-home",
1102 out: false,
1103 },
1104 {
1105 in: "-kotlin-home /some/path",
1106 out: false,
1107 },
1108 {
1109 in: "-include-runtime",
1110 out: false,
1111 },
1112 {
1113 in: "-Xintellij-plugin-root",
1114 out: false,
1115 },
1116}
1117
1118type mockContext struct {
1119 android.ModuleContext
1120 result bool
1121}
1122
1123func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) {
1124 // CheckBadCompilerFlags calls this function when the flag should be rejected
1125 ctx.result = false
1126}
1127
1128func TestCompilerFlags(t *testing.T) {
1129 for _, testCase := range compilerFlagsTestCases {
1130 ctx := &mockContext{result: true}
1131 CheckKotlincFlags(ctx, []string{testCase.in})
1132 if ctx.result != testCase.out {
1133 t.Errorf("incorrect output:")
1134 t.Errorf(" input: %#v", testCase.in)
1135 t.Errorf(" expected: %#v", testCase.out)
1136 t.Errorf(" got: %#v", ctx.result)
1137 }
1138 }
1139}
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001140
1141// TODO(jungjw): Consider making this more robust by ignoring path order.
1142func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) {
1143 variables := ctx.ModuleForTests(moduleName, "android_common").Module().VariablesForTests()
1144 flags := strings.Split(variables["javacFlags"], " ")
1145 got := ""
1146 for _, flag := range flags {
1147 keyEnd := strings.Index(flag, "=")
1148 if keyEnd > -1 && flag[:keyEnd] == "--patch-module" {
1149 got = flag[keyEnd+1:]
1150 break
1151 }
1152 }
1153 if expected != got {
1154 t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got)
1155 }
1156}
1157
1158func TestPatchModule(t *testing.T) {
Pete Gillin0c2143e2019-05-02 15:32:11 +01001159 t.Run("Java language level 8", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01001160 // Test with legacy javac -source 1.8 -target 1.8
Pete Gillinbdf5d712019-10-21 14:29:58 +01001161 bp := `
1162 java_library {
1163 name: "foo",
1164 srcs: ["a.java"],
1165 java_version: "1.8",
1166 }
1167
1168 java_library {
1169 name: "bar",
1170 srcs: ["b.java"],
1171 sdk_version: "none",
1172 system_modules: "none",
1173 patch_module: "java.base",
1174 java_version: "1.8",
1175 }
1176
1177 java_library {
1178 name: "baz",
1179 srcs: ["c.java"],
1180 patch_module: "java.base",
1181 java_version: "1.8",
1182 }
1183 `
1184 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001185
1186 checkPatchModuleFlag(t, ctx, "foo", "")
1187 checkPatchModuleFlag(t, ctx, "bar", "")
1188 checkPatchModuleFlag(t, ctx, "baz", "")
1189 })
1190
Pete Gillin0c2143e2019-05-02 15:32:11 +01001191 t.Run("Java language level 9", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01001192 // Test with default javac -source 9 -target 9
Pete Gillinbdf5d712019-10-21 14:29:58 +01001193 bp := `
1194 java_library {
1195 name: "foo",
1196 srcs: ["a.java"],
1197 }
1198
1199 java_library {
1200 name: "bar",
1201 srcs: ["b.java"],
1202 sdk_version: "none",
1203 system_modules: "none",
1204 patch_module: "java.base",
1205 }
1206
1207 java_library {
1208 name: "baz",
1209 srcs: ["c.java"],
1210 patch_module: "java.base",
1211 }
1212 `
Pete Gillin1b3370f2019-10-01 13:57:31 +01001213 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001214
1215 checkPatchModuleFlag(t, ctx, "foo", "")
1216 expected := "java.base=.:" + buildDir
1217 checkPatchModuleFlag(t, ctx, "bar", expected)
Jiyong Park231d0562019-12-18 17:28:17 +09001218 expected = "java.base=" + strings.Join([]string{".", buildDir, moduleToPath("ext"), moduleToPath("framework")}, ":")
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001219 checkPatchModuleFlag(t, ctx, "baz", expected)
1220 })
1221}