blob: 6b8b735f715811db918d357eefde5bde42a3340f [file] [log] [blame]
Colin Cross72bb3632017-07-13 16:23:21 -07001// Copyright 2017 Google Inc. All rights reserved.
2//
3// Licensed under the Apache License, Version 2.0 (the "License");
4// you may not use this file except in compliance with the License.
5// You may obtain a copy of the License at
6//
7// http://www.apache.org/licenses/LICENSE-2.0
8//
9// Unless required by applicable law or agreed to in writing, software
10// distributed under the License is distributed on an "AS IS" BASIS,
11// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12// See the License for the specific language governing permissions and
13// limitations under the License.
14
15package java
16
17import (
Paul Duffin1a393322020-11-18 16:36:47 +000018 "fmt"
Colin Cross72bb3632017-07-13 16:23:21 -070019 "os"
20 "path/filepath"
Colin Crossc0806172019-06-14 18:51:47 -070021 "reflect"
Colin Crossf8d9c492021-01-26 11:01:43 -080022 "runtime"
Nan Zhang61eaedb2017-11-02 13:28:15 -070023 "strconv"
Colin Cross72bb3632017-07-13 16:23:21 -070024 "strings"
25 "testing"
Colin Cross86a60ae2018-05-29 14:44:55 -070026
Jeongik Cha28df2572019-11-11 10:46:36 +090027 "github.com/google/blueprint/proptools"
28
Colin Crossa4f08812018-10-02 22:03:40 -070029 "android/soong/android"
30 "android/soong/cc"
Colin Crossc28bb0b2019-02-25 14:20:47 -080031 "android/soong/dexpreopt"
Colin Cross1661aff2021-03-12 17:56:51 -080032 "android/soong/genrule"
Colin Cross72bb3632017-07-13 16:23:21 -070033)
34
Paul Duffin70d3bee2021-03-21 11:26:05 +000035// Legacy preparer used for running tests within the java package.
36//
37// This includes everything that was needed to run any test in the java package prior to the
38// introduction of the test fixtures. Tests that are being converted to use fixtures directly
39// rather than through the testJava...() methods should avoid using this and instead use the
40// various preparers directly, using android.GroupFixturePreparers(...) to group them when
41// necessary.
42//
43// deprecated
44var prepareForJavaTest = android.GroupFixturePreparers(
Paul Duffin95bdab42021-03-08 21:48:46 +000045 genrule.PrepareForTestWithGenRuleBuildComponents,
46 // Get the CC build components but not default modules.
47 cc.PrepareForTestWithCcBuildComponents,
48 // Include all the default java modules.
Jiakai Zhangb95998b2023-05-11 16:39:27 +010049 PrepareForTestWithDexpreopt,
Paul Duffin42da69d2021-03-22 13:41:36 +000050 PrepareForTestWithOverlayBuildComponents,
Paul Duffin95bdab42021-03-08 21:48:46 +000051 android.FixtureRegisterWithContext(func(ctx android.RegistrationContext) {
Paul Duffin95bdab42021-03-08 21:48:46 +000052 ctx.RegisterPreSingletonType("sdk_versions", sdkPreSingletonFactory)
53 }),
Paul Duffin95bdab42021-03-08 21:48:46 +000054)
55
Colin Cross72bb3632017-07-13 16:23:21 -070056func TestMain(m *testing.M) {
Paul Duffind6339af2021-03-22 18:05:04 +000057 os.Exit(m.Run())
Colin Cross527012a2017-11-30 22:56:16 -080058}
59
Paul Duffin95bdab42021-03-08 21:48:46 +000060// testJavaError is a legacy way of running tests of java modules that expect errors.
61//
62// See testJava for an explanation as to how to stop using this deprecated method.
63//
64// deprecated
Jeongik Cha2cc570d2019-10-29 15:44:45 +090065func testJavaError(t *testing.T, pattern string, bp string) (*android.TestContext, android.Config) {
Jeongik Cha538c0d02019-07-11 15:54:27 +090066 t.Helper()
Paul Duffin71ae5942021-03-22 15:36:52 +000067 result := android.GroupFixturePreparers(
Paul Duffin9fc9f532021-03-23 15:41:11 +000068 prepareForJavaTest, dexpreopt.PrepareForTestByEnablingDexpreopt).
Paul Duffin6bac49c2021-03-12 21:28:15 +000069 ExtendWithErrorHandler(android.FixtureExpectsAtLeastOneErrorMatchingPattern(pattern)).
70 RunTestWithBp(t, bp)
71 return result.TestContext, result.Config
Jeongik Cha2cc570d2019-10-29 15:44:45 +090072}
73
Paul Duffin71ae5942021-03-22 15:36:52 +000074// testJavaWithFS runs tests using the prepareForJavaTest
Paul Duffin95bdab42021-03-08 21:48:46 +000075//
76// See testJava for an explanation as to how to stop using this deprecated method.
77//
78// deprecated
79func testJavaWithFS(t *testing.T, bp string, fs android.MockFS) (*android.TestContext, android.Config) {
Colin Cross238c1f32020-06-07 16:58:18 -070080 t.Helper()
Paul Duffin71ae5942021-03-22 15:36:52 +000081 result := android.GroupFixturePreparers(
82 prepareForJavaTest, fs.AddToFixture()).RunTestWithBp(t, bp)
Paul Duffin95bdab42021-03-08 21:48:46 +000083 return result.TestContext, result.Config
Colin Cross238c1f32020-06-07 16:58:18 -070084}
85
Paul Duffin71ae5942021-03-22 15:36:52 +000086// testJava runs tests using the prepareForJavaTest
Paul Duffin95bdab42021-03-08 21:48:46 +000087//
Paul Duffin71ae5942021-03-22 15:36:52 +000088// Do not add any new usages of this, instead use the prepareForJavaTest directly as it makes it
Paul Duffin95bdab42021-03-08 21:48:46 +000089// much easier to customize the test behavior.
90//
91// If it is necessary to customize the behavior of an existing test that uses this then please first
Paul Duffin71ae5942021-03-22 15:36:52 +000092// convert the test to using prepareForJavaTest first and then in a following change add the
Paul Duffin95bdab42021-03-08 21:48:46 +000093// appropriate fixture preparers. Keeping the conversion change separate makes it easy to verify
94// that it did not change the test behavior unexpectedly.
95//
96// deprecated
Jaewoong Jungf9a04432019-07-17 11:15:09 -070097func testJava(t *testing.T, bp string) (*android.TestContext, android.Config) {
Colin Cross6b4a32d2017-12-05 13:42:45 -080098 t.Helper()
Paul Duffin71ae5942021-03-22 15:36:52 +000099 result := prepareForJavaTest.RunTestWithBp(t, bp)
Paul Duffin95bdab42021-03-08 21:48:46 +0000100 return result.TestContext, result.Config
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900101}
102
Paul Duffin95bdab42021-03-08 21:48:46 +0000103// defaultModuleToPath constructs a path to the turbine generate jar for a default test module that
104// is defined in PrepareForIntegrationTestWithJava
105func defaultModuleToPath(name string) string {
Paul Duffin76101fa2021-03-13 09:55:25 +0000106 switch {
107 case name == `""`:
108 return name
109 case strings.HasSuffix(name, ".jar"):
110 return name
111 default:
Paul Duffin414ea5e2021-03-22 17:31:52 +0000112 return filepath.Join("out", "soong", ".intermediates", defaultJavaDir, name, "android_common", "turbine-combined", name+".jar")
Paul Duffin76101fa2021-03-13 09:55:25 +0000113 }
Paul Duffin95bdab42021-03-08 21:48:46 +0000114}
115
Paul Duffin76e5c8a2021-03-20 14:19:46 +0000116// Test that the PrepareForTestWithJavaDefaultModules provides all the files that it uses by
117// running it in a fixture that requires all source files to exist.
118func TestPrepareForTestWithJavaDefaultModules(t *testing.T) {
119 android.GroupFixturePreparers(
120 PrepareForTestWithJavaDefaultModules,
121 android.PrepareForTestDisallowNonExistentPaths,
122 ).RunTest(t)
123}
124
Jeongik Chae403e9e2019-12-07 00:16:24 +0900125func TestJavaLinkType(t *testing.T) {
126 testJava(t, `
127 java_library {
128 name: "foo",
129 srcs: ["a.java"],
130 libs: ["bar"],
131 static_libs: ["baz"],
132 }
133
134 java_library {
135 name: "bar",
136 sdk_version: "current",
137 srcs: ["b.java"],
138 }
139
140 java_library {
141 name: "baz",
142 sdk_version: "system_current",
143 srcs: ["c.java"],
144 }
145 `)
146
Steven Moreland00298982020-11-17 21:44:36 +0000147 testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
Jeongik Chae403e9e2019-12-07 00:16:24 +0900148 java_library {
149 name: "foo",
150 srcs: ["a.java"],
151 libs: ["bar"],
152 sdk_version: "current",
153 static_libs: ["baz"],
154 }
155
156 java_library {
157 name: "bar",
158 sdk_version: "current",
159 srcs: ["b.java"],
160 }
161
162 java_library {
163 name: "baz",
164 sdk_version: "system_current",
165 srcs: ["c.java"],
166 }
167 `)
168
169 testJava(t, `
170 java_library {
171 name: "foo",
172 srcs: ["a.java"],
173 libs: ["bar"],
174 sdk_version: "system_current",
175 static_libs: ["baz"],
176 }
177
178 java_library {
179 name: "bar",
180 sdk_version: "current",
181 srcs: ["b.java"],
182 }
183
184 java_library {
185 name: "baz",
186 sdk_version: "system_current",
187 srcs: ["c.java"],
188 }
189 `)
190
Steven Moreland00298982020-11-17 21:44:36 +0000191 testJavaError(t, "consider adjusting sdk_version: OR platform_apis:", `
Jeongik Chae403e9e2019-12-07 00:16:24 +0900192 java_library {
193 name: "foo",
194 srcs: ["a.java"],
195 libs: ["bar"],
196 sdk_version: "system_current",
197 static_libs: ["baz"],
198 }
199
200 java_library {
201 name: "bar",
202 sdk_version: "current",
203 srcs: ["b.java"],
204 }
205
206 java_library {
207 name: "baz",
208 srcs: ["c.java"],
209 }
210 `)
211}
212
Colin Cross72bb3632017-07-13 16:23:21 -0700213func TestSimple(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700214 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700215 java_library {
216 name: "foo",
217 srcs: ["a.java"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700218 libs: ["bar"],
219 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700220 }
221
222 java_library {
223 name: "bar",
224 srcs: ["b.java"],
225 }
226
227 java_library {
228 name: "baz",
229 srcs: ["c.java"],
230 }
Colin Crossd5934c82017-10-02 13:55:26 -0700231 `)
Colin Cross72bb3632017-07-13 16:23:21 -0700232
Paul Duffina71a67a2021-03-29 00:42:57 +0100233 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700234 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross72bb3632017-07-13 16:23:21 -0700235
236 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
237 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
238 }
239
Colin Cross1ee23172017-10-18 14:44:18 -0700240 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Paul Duffin414ea5e2021-03-22 17:31:52 +0000241 barTurbine := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
242 bazTurbine := filepath.Join("out", "soong", ".intermediates", "baz", "android_common", "turbine-combined", "baz.jar")
Colin Cross0a6e0072017-08-30 14:24:55 -0700243
Paul Duffin22b77cd2021-03-12 19:15:01 +0000244 android.AssertStringDoesContain(t, "foo classpath", javac.Args["classpath"], barTurbine)
Colin Cross72bb3632017-07-13 16:23:21 -0700245
Paul Duffin22b77cd2021-03-12 19:15:01 +0000246 android.AssertStringDoesContain(t, "foo classpath", javac.Args["classpath"], bazTurbine)
Colin Cross0a6e0072017-08-30 14:24:55 -0700247
248 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
249 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross72bb3632017-07-13 16:23:21 -0700250 }
251}
252
Artur Satayev9cf46692019-11-26 18:08:34 +0000253func TestExportedPlugins(t *testing.T) {
254 type Result struct {
Colin Crossc9fe10f2020-11-19 18:06:03 -0800255 library string
256 processors string
257 disableTurbine bool
Artur Satayev9cf46692019-11-26 18:08:34 +0000258 }
259 var tests = []struct {
260 name string
261 extra string
262 results []Result
263 }{
264 {
265 name: "Exported plugin is not a direct plugin",
266 extra: `java_library { name: "exports", srcs: ["a.java"], exported_plugins: ["plugin"] }`,
267 results: []Result{{library: "exports", processors: "-proc:none"}},
268 },
269 {
270 name: "Exports plugin to dependee",
271 extra: `
272 java_library{name: "exports", exported_plugins: ["plugin"]}
273 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
274 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
275 `,
276 results: []Result{
277 {library: "foo", processors: "-processor com.android.TestPlugin"},
278 {library: "bar", processors: "-processor com.android.TestPlugin"},
279 },
280 },
281 {
282 name: "Exports plugin to android_library",
283 extra: `
284 java_library{name: "exports", exported_plugins: ["plugin"]}
285 android_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
286 android_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
287 `,
288 results: []Result{
289 {library: "foo", processors: "-processor com.android.TestPlugin"},
290 {library: "bar", processors: "-processor com.android.TestPlugin"},
291 },
292 },
293 {
294 name: "Exports plugin is not propagated via transitive deps",
295 extra: `
296 java_library{name: "exports", exported_plugins: ["plugin"]}
297 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
298 java_library{name: "bar", srcs: ["a.java"], static_libs: ["foo"]}
299 `,
300 results: []Result{
301 {library: "foo", processors: "-processor com.android.TestPlugin"},
302 {library: "bar", processors: "-proc:none"},
303 },
304 },
305 {
306 name: "Exports plugin appends to plugins",
307 extra: `
308 java_plugin{name: "plugin2", processor_class: "com.android.TestPlugin2"}
309 java_library{name: "exports", exported_plugins: ["plugin"]}
310 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"], plugins: ["plugin2"]}
311 `,
312 results: []Result{
313 {library: "foo", processors: "-processor com.android.TestPlugin,com.android.TestPlugin2"},
314 },
315 },
Colin Crossc9fe10f2020-11-19 18:06:03 -0800316 {
317 name: "Exports plugin to with generates_api to dependee",
318 extra: `
319 java_library{name: "exports", exported_plugins: ["plugin_generates_api"]}
320 java_library{name: "foo", srcs: ["a.java"], libs: ["exports"]}
321 java_library{name: "bar", srcs: ["a.java"], static_libs: ["exports"]}
322 `,
323 results: []Result{
324 {library: "foo", processors: "-processor com.android.TestPlugin", disableTurbine: true},
325 {library: "bar", processors: "-processor com.android.TestPlugin", disableTurbine: true},
326 },
327 },
Artur Satayev9cf46692019-11-26 18:08:34 +0000328 }
329
330 for _, test := range tests {
331 t.Run(test.name, func(t *testing.T) {
332 ctx, _ := testJava(t, `
333 java_plugin {
334 name: "plugin",
335 processor_class: "com.android.TestPlugin",
336 }
Colin Crossc9fe10f2020-11-19 18:06:03 -0800337 java_plugin {
338 name: "plugin_generates_api",
339 generates_api: true,
340 processor_class: "com.android.TestPlugin",
341 }
Artur Satayev9cf46692019-11-26 18:08:34 +0000342 `+test.extra)
343
344 for _, want := range test.results {
345 javac := ctx.ModuleForTests(want.library, "android_common").Rule("javac")
346 if javac.Args["processor"] != want.processors {
347 t.Errorf("For library %v, expected %v, found %v", want.library, want.processors, javac.Args["processor"])
348 }
Colin Crossc9fe10f2020-11-19 18:06:03 -0800349 turbine := ctx.ModuleForTests(want.library, "android_common").MaybeRule("turbine")
350 disableTurbine := turbine.BuildParams.Rule == nil
351 if disableTurbine != want.disableTurbine {
352 t.Errorf("For library %v, expected disableTurbine %v, found %v", want.library, want.disableTurbine, disableTurbine)
353 }
Artur Satayev9cf46692019-11-26 18:08:34 +0000354 }
355 })
356 }
357}
358
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900359func TestSdkVersionByPartition(t *testing.T) {
360 testJavaError(t, "sdk_version must have a value when the module is located at vendor or product", `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900361 java_library {
362 name: "foo",
363 srcs: ["a.java"],
364 vendor: true,
365 }
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900366 `)
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900367
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900368 testJava(t, `
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900369 java_library {
370 name: "bar",
371 srcs: ["b.java"],
372 }
373 `)
374
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900375 for _, enforce := range []bool{true, false} {
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900376 bp := `
377 java_library {
378 name: "foo",
379 srcs: ["a.java"],
380 product_specific: true,
381 }
382 `
Colin Cross98be1bb2019-12-13 20:41:13 -0800383
Paul Duffin414ea5e2021-03-22 17:31:52 +0000384 errorHandler := android.FixtureExpectsNoErrors
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900385 if enforce {
Paul Duffin414ea5e2021-03-22 17:31:52 +0000386 errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern("sdk_version must have a value when the module is located at vendor or product")
Jeongik Cha2cc570d2019-10-29 15:44:45 +0900387 }
Paul Duffin414ea5e2021-03-22 17:31:52 +0000388
389 android.GroupFixturePreparers(
390 PrepareForTestWithJavaDefaultModules,
391 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
392 variables.EnforceProductPartitionInterface = proptools.BoolPtr(enforce)
393 }),
394 ).
395 ExtendWithErrorHandler(errorHandler).
396 RunTestWithBp(t, bp)
Jeongik Cha6bd33c12019-06-25 16:26:18 +0900397 }
398}
399
Colin Crossd5934c82017-10-02 13:55:26 -0700400func TestArchSpecific(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700401 ctx, _ := testJava(t, `
Colin Crossd5934c82017-10-02 13:55:26 -0700402 java_library {
403 name: "foo",
404 srcs: ["a.java"],
405 target: {
406 android: {
407 srcs: ["b.java"],
408 },
409 },
410 }
411 `)
412
413 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
414 if len(javac.Inputs) != 2 || javac.Inputs[0].String() != "a.java" || javac.Inputs[1].String() != "b.java" {
415 t.Errorf(`foo inputs %v != ["a.java", "b.java"]`, javac.Inputs)
416 }
417}
418
Colin Cross6b4a32d2017-12-05 13:42:45 -0800419func TestBinary(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700420 ctx, _ := testJava(t, `
Colin Cross6b4a32d2017-12-05 13:42:45 -0800421 java_library_host {
422 name: "foo",
423 srcs: ["a.java"],
424 }
425
426 java_binary_host {
427 name: "bar",
428 srcs: ["b.java"],
429 static_libs: ["foo"],
Colin Cross89226d92020-10-09 19:00:54 -0700430 jni_libs: ["libjni"],
431 }
432
433 cc_library_shared {
434 name: "libjni",
435 host_supported: true,
436 device_supported: false,
437 stl: "none",
Colin Cross6b4a32d2017-12-05 13:42:45 -0800438 }
439 `)
440
Colin Cross0c66bc62021-07-20 09:47:41 -0700441 buildOS := ctx.Config().BuildOS.String()
Colin Cross6b4a32d2017-12-05 13:42:45 -0800442
443 bar := ctx.ModuleForTests("bar", buildOS+"_common")
444 barJar := bar.Output("bar.jar").Output.String()
445 barWrapper := ctx.ModuleForTests("bar", buildOS+"_x86_64")
446 barWrapperDeps := barWrapper.Output("bar").Implicits.Strings()
447
Colin Cross89226d92020-10-09 19:00:54 -0700448 libjni := ctx.ModuleForTests("libjni", buildOS+"_x86_64_shared")
449 libjniSO := libjni.Rule("Cp").Output.String()
450
Colin Cross6b4a32d2017-12-05 13:42:45 -0800451 // Test that the install binary wrapper depends on the installed jar file
Colin Crossc179ea62020-10-09 10:54:15 -0700452 if g, w := barWrapperDeps, barJar; !android.InList(w, g) {
453 t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g)
Colin Cross6b4a32d2017-12-05 13:42:45 -0800454 }
Colin Cross89226d92020-10-09 19:00:54 -0700455
456 // Test that the install binary wrapper depends on the installed JNI libraries
457 if g, w := barWrapperDeps, libjniSO; !android.InList(w, g) {
458 t.Errorf("expected binary wrapper implicits to contain %q, got %q", w, g)
Colin Cross6b4a32d2017-12-05 13:42:45 -0800459 }
Alex Humesky2070e322020-06-09 20:23:08 -0400460}
Colin Cross6b4a32d2017-12-05 13:42:45 -0800461
Colin Crossf8d9c492021-01-26 11:01:43 -0800462func TestTest(t *testing.T) {
463 ctx, _ := testJava(t, `
464 java_test_host {
465 name: "foo",
466 srcs: ["a.java"],
467 jni_libs: ["libjni"],
468 }
469
470 cc_library_shared {
471 name: "libjni",
472 host_supported: true,
473 device_supported: false,
474 stl: "none",
475 }
476 `)
477
Colin Cross0c66bc62021-07-20 09:47:41 -0700478 buildOS := ctx.Config().BuildOS.String()
Colin Crossf8d9c492021-01-26 11:01:43 -0800479
480 foo := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost)
481
482 expected := "lib64/libjni.so"
483 if runtime.GOOS == "darwin" {
484 expected = "lib64/libjni.dylib"
485 }
486
487 fooTestData := foo.data
488 if len(fooTestData) != 1 || fooTestData[0].Rel() != expected {
489 t.Errorf(`expected foo test data relative path [%q], got %q`,
490 expected, fooTestData.Strings())
491 }
492}
493
Alex Humesky2070e322020-06-09 20:23:08 -0400494func TestHostBinaryNoJavaDebugInfoOverride(t *testing.T) {
495 bp := `
496 java_library {
497 name: "target_library",
498 srcs: ["a.java"],
499 }
500
501 java_binary_host {
502 name: "host_binary",
503 srcs: ["b.java"],
504 }
505 `
Alex Humesky2070e322020-06-09 20:23:08 -0400506
Paul Duffin414ea5e2021-03-22 17:31:52 +0000507 result := android.GroupFixturePreparers(
508 PrepareForTestWithJavaDefaultModules,
509 android.FixtureModifyProductVariables(func(variables android.FixtureProductVariables) {
510 variables.MinimizeJavaDebugInfo = proptools.BoolPtr(true)
511 }),
512 ).RunTestWithBp(t, bp)
Alex Humesky2070e322020-06-09 20:23:08 -0400513
Liz Kammer7941b302020-07-28 13:27:34 -0700514 // first, check that the -g flag is added to target modules
Paul Duffin414ea5e2021-03-22 17:31:52 +0000515 targetLibrary := result.ModuleForTests("target_library", "android_common")
Alex Humesky2070e322020-06-09 20:23:08 -0400516 targetJavaFlags := targetLibrary.Module().VariablesForTests()["javacFlags"]
517 if !strings.Contains(targetJavaFlags, "-g:source,lines") {
518 t.Errorf("target library javac flags %v should contain "+
519 "-g:source,lines override with MinimizeJavaDebugInfo", targetJavaFlags)
520 }
521
522 // check that -g is not overridden for host modules
Colin Cross0c66bc62021-07-20 09:47:41 -0700523 buildOS := result.Config.BuildOS.String()
Paul Duffin414ea5e2021-03-22 17:31:52 +0000524 hostBinary := result.ModuleForTests("host_binary", buildOS+"_common")
Alex Humesky2070e322020-06-09 20:23:08 -0400525 hostJavaFlags := hostBinary.Module().VariablesForTests()["javacFlags"]
526 if strings.Contains(hostJavaFlags, "-g:source,lines") {
527 t.Errorf("java_binary_host javac flags %v should not have "+
528 "-g:source,lines override with MinimizeJavaDebugInfo", hostJavaFlags)
529 }
Colin Cross6b4a32d2017-12-05 13:42:45 -0800530}
531
Colin Cross72bb3632017-07-13 16:23:21 -0700532func TestPrebuilts(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700533 ctx, _ := testJava(t, `
Colin Cross72bb3632017-07-13 16:23:21 -0700534 java_library {
535 name: "foo",
Paul Duffin91547182019-11-12 19:39:36 +0000536 srcs: ["a.java", ":stubs-source"],
Paul Duffinfcfd7912020-01-31 17:54:30 +0000537 libs: ["bar", "sdklib"],
Colin Crosse8dc34a2017-07-19 11:22:16 -0700538 static_libs: ["baz"],
Colin Cross72bb3632017-07-13 16:23:21 -0700539 }
540
Colin Cross74d73e22017-08-02 11:05:49 -0700541 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700542 name: "bar",
Colin Cross74d73e22017-08-02 11:05:49 -0700543 jars: ["a.jar"],
Colin Cross72bb3632017-07-13 16:23:21 -0700544 }
545
Colin Cross74d73e22017-08-02 11:05:49 -0700546 java_import {
Colin Cross72bb3632017-07-13 16:23:21 -0700547 name: "baz",
Colin Cross74d73e22017-08-02 11:05:49 -0700548 jars: ["b.jar"],
Liz Kammerd6c31d22020-08-05 15:40:41 -0700549 sdk_version: "current",
550 compile_dex: true,
Colin Cross72bb3632017-07-13 16:23:21 -0700551 }
Colin Cross42be7612019-02-21 18:12:14 -0800552
553 dex_import {
554 name: "qux",
555 jars: ["b.jar"],
556 }
Colin Cross79c7c262019-04-17 11:11:46 -0700557
558 java_sdk_library_import {
Paul Duffin56d44902020-01-31 13:36:25 +0000559 name: "sdklib",
560 public: {
561 jars: ["c.jar"],
562 },
563 }
564
Paul Duffin91547182019-11-12 19:39:36 +0000565 prebuilt_stubs_sources {
566 name: "stubs-source",
Paul Duffin9b478b02019-12-10 13:41:51 +0000567 srcs: ["stubs/sources"],
Paul Duffin91547182019-11-12 19:39:36 +0000568 }
Paul Duffin1b82e6a2019-12-03 18:06:47 +0000569
570 java_test_import {
571 name: "test",
572 jars: ["a.jar"],
573 test_suites: ["cts"],
574 test_config: "AndroidTest.xml",
575 }
Colin Cross72bb3632017-07-13 16:23:21 -0700576 `)
577
Paul Duffin9b478b02019-12-10 13:41:51 +0000578 fooModule := ctx.ModuleForTests("foo", "android_common")
579 javac := fooModule.Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700580 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Liz Kammerd6c31d22020-08-05 15:40:41 -0700581 barModule := ctx.ModuleForTests("bar", "android_common")
582 barJar := barModule.Rule("combineJar").Output
583 bazModule := ctx.ModuleForTests("baz", "android_common")
584 bazJar := bazModule.Rule("combineJar").Output
Colin Cross79c7c262019-04-17 11:11:46 -0700585 sdklibStubsJar := ctx.ModuleForTests("sdklib.stubs", "android_common").Rule("combineJar").Output
Colin Cross72bb3632017-07-13 16:23:21 -0700586
Paul Duffin9b478b02019-12-10 13:41:51 +0000587 fooLibrary := fooModule.Module().(*Library)
Chaohui Wangdcbe33c2022-10-11 11:13:30 +0800588 assertDeepEquals(t, "foo unique sources incorrect",
589 []string{"a.java"}, fooLibrary.uniqueSrcFiles.Strings())
Paul Duffin91547182019-11-12 19:39:36 +0000590
Paul Duffin9b478b02019-12-10 13:41:51 +0000591 assertDeepEquals(t, "foo java source jars incorrect",
592 []string{".intermediates/stubs-source/android_common/stubs-source-stubs.srcjar"},
593 android.NormalizePathsForTesting(fooLibrary.compiledSrcJars))
Paul Duffin91547182019-11-12 19:39:36 +0000594
Colin Cross37f6d792018-07-12 12:28:41 -0700595 if !strings.Contains(javac.Args["classpath"], barJar.String()) {
596 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700597 }
598
Liz Kammerd6c31d22020-08-05 15:40:41 -0700599 barDexJar := barModule.Module().(*Import).DexJarBuildPath()
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +0100600 if barDexJar.IsSet() {
601 t.Errorf("bar dex jar build path expected to be set, got %s", barDexJar)
Liz Kammerd6c31d22020-08-05 15:40:41 -0700602 }
603
Colin Cross79c7c262019-04-17 11:11:46 -0700604 if !strings.Contains(javac.Args["classpath"], sdklibStubsJar.String()) {
605 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], sdklibStubsJar.String())
606 }
607
Colin Cross37f6d792018-07-12 12:28:41 -0700608 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != bazJar.String() {
609 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, bazJar.String())
Colin Cross72bb3632017-07-13 16:23:21 -0700610 }
Colin Cross42be7612019-02-21 18:12:14 -0800611
Martin Stjernholm8be1e6d2021-09-15 03:34:04 +0100612 bazDexJar := bazModule.Module().(*Import).DexJarBuildPath().Path()
Paul Duffin414ea5e2021-03-22 17:31:52 +0000613 expectedDexJar := "out/soong/.intermediates/baz/android_common/dex/baz.jar"
614 android.AssertPathRelativeToTopEquals(t, "baz dex jar build path", expectedDexJar, bazDexJar)
Liz Kammerd6c31d22020-08-05 15:40:41 -0700615
Colin Cross42be7612019-02-21 18:12:14 -0800616 ctx.ModuleForTests("qux", "android_common").Rule("Cp")
Wei Li598f92d2023-01-04 17:12:24 -0800617
618 entries := android.AndroidMkEntriesForTest(t, ctx, fooModule.Module())[0]
619 android.AssertStringEquals(t, "unexpected LOCAL_SOONG_MODULE_TYPE", "java_library", entries.EntryMap["LOCAL_SOONG_MODULE_TYPE"][0])
620 entries = android.AndroidMkEntriesForTest(t, ctx, barModule.Module())[0]
621 android.AssertStringEquals(t, "unexpected LOCAL_SOONG_MODULE_TYPE", "java_import", entries.EntryMap["LOCAL_SOONG_MODULE_TYPE"][0])
622 entries = android.AndroidMkEntriesForTest(t, ctx, ctx.ModuleForTests("sdklib", "android_common").Module())[0]
623 android.AssertStringEquals(t, "unexpected LOCAL_SOONG_MODULE_TYPE", "java_sdk_library_import", entries.EntryMap["LOCAL_SOONG_MODULE_TYPE"][0])
Colin Cross72bb3632017-07-13 16:23:21 -0700624}
625
Paul Duffin9b478b02019-12-10 13:41:51 +0000626func assertDeepEquals(t *testing.T, message string, expected interface{}, actual interface{}) {
627 if !reflect.DeepEqual(expected, actual) {
628 t.Errorf("%s: expected %q, found %q", message, expected, actual)
629 }
630}
631
Paul Duffin1a393322020-11-18 16:36:47 +0000632func TestPrebuiltStubsSources(t *testing.T) {
633 test := func(t *testing.T, sourcesPath string, expectedInputs []string) {
634 ctx, _ := testJavaWithFS(t, fmt.Sprintf(`
635prebuilt_stubs_sources {
636 name: "stubs-source",
637 srcs: ["%s"],
638}`, sourcesPath), map[string][]byte{
639 "stubs/sources/pkg/A.java": nil,
640 "stubs/sources/pkg/B.java": nil,
641 })
642
643 zipSrc := ctx.ModuleForTests("stubs-source", "android_common").Rule("zip_src")
644 if expected, actual := expectedInputs, zipSrc.Inputs.Strings(); !reflect.DeepEqual(expected, actual) {
645 t.Errorf("mismatch of inputs to soong_zip: expected %q, actual %q", expected, actual)
646 }
647 }
648
649 t.Run("empty/missing directory", func(t *testing.T) {
Colin Crossce3a51d2021-03-19 16:22:12 -0700650 test(t, "empty-directory", nil)
Paul Duffin1a393322020-11-18 16:36:47 +0000651 })
652
653 t.Run("non-empty set of sources", func(t *testing.T) {
654 test(t, "stubs/sources", []string{
655 "stubs/sources/pkg/A.java",
656 "stubs/sources/pkg/B.java",
657 })
658 })
659}
660
Colin Cross89536d42017-07-07 14:35:50 -0700661func TestDefaults(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700662 ctx, _ := testJava(t, `
Colin Cross89536d42017-07-07 14:35:50 -0700663 java_defaults {
664 name: "defaults",
665 srcs: ["a.java"],
666 libs: ["bar"],
667 static_libs: ["baz"],
Sasha Smundak2057f822019-04-16 17:16:58 -0700668 optimize: {enabled: false},
Colin Cross89536d42017-07-07 14:35:50 -0700669 }
670
671 java_library {
672 name: "foo",
673 defaults: ["defaults"],
674 }
675
676 java_library {
677 name: "bar",
678 srcs: ["b.java"],
679 }
680
681 java_library {
682 name: "baz",
683 srcs: ["c.java"],
684 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700685
686 android_test {
687 name: "atestOptimize",
688 defaults: ["defaults"],
689 optimize: {enabled: true},
690 }
691
692 android_test {
693 name: "atestNoOptimize",
694 defaults: ["defaults"],
695 }
696
697 android_test {
698 name: "atestDefault",
699 srcs: ["a.java"],
700 }
Colin Cross89536d42017-07-07 14:35:50 -0700701 `)
702
Paul Duffina71a67a2021-03-29 00:42:57 +0100703 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
Nan Zhanged19fc32017-10-19 13:06:22 -0700704 combineJar := ctx.ModuleForTests("foo", "android_common").Description("for javac")
Colin Cross89536d42017-07-07 14:35:50 -0700705
706 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "a.java" {
707 t.Errorf(`foo inputs %v != ["a.java"]`, javac.Inputs)
708 }
709
Paul Duffin414ea5e2021-03-22 17:31:52 +0000710 barTurbine := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine-combined", "bar.jar")
Nan Zhanged19fc32017-10-19 13:06:22 -0700711 if !strings.Contains(javac.Args["classpath"], barTurbine) {
712 t.Errorf("foo classpath %v does not contain %q", javac.Args["classpath"], barTurbine)
Colin Cross89536d42017-07-07 14:35:50 -0700713 }
714
Colin Cross1ee23172017-10-18 14:44:18 -0700715 baz := ctx.ModuleForTests("baz", "android_common").Rule("javac").Output.String()
Colin Cross0a6e0072017-08-30 14:24:55 -0700716 if len(combineJar.Inputs) != 2 || combineJar.Inputs[1].String() != baz {
717 t.Errorf("foo combineJar inputs %v does not contain %q", combineJar.Inputs, baz)
Colin Cross89536d42017-07-07 14:35:50 -0700718 }
Sasha Smundak2057f822019-04-16 17:16:58 -0700719
720 atestOptimize := ctx.ModuleForTests("atestOptimize", "android_common").MaybeRule("r8")
721 if atestOptimize.Output == nil {
722 t.Errorf("atestOptimize should optimize APK")
723 }
724
725 atestNoOptimize := ctx.ModuleForTests("atestNoOptimize", "android_common").MaybeRule("d8")
726 if atestNoOptimize.Output == nil {
727 t.Errorf("atestNoOptimize should not optimize APK")
728 }
729
Jared Duke63a3da92022-06-02 19:11:14 +0000730 atestDefault := ctx.ModuleForTests("atestDefault", "android_common").MaybeRule("d8")
Sasha Smundak2057f822019-04-16 17:16:58 -0700731 if atestDefault.Output == nil {
Jared Duke63a3da92022-06-02 19:11:14 +0000732 t.Errorf("atestDefault should not optimize APK")
Sasha Smundak2057f822019-04-16 17:16:58 -0700733 }
Colin Cross89536d42017-07-07 14:35:50 -0700734}
735
Colin Cross0f37af02017-09-27 17:42:05 -0700736func TestResources(t *testing.T) {
737 var table = []struct {
738 name string
739 prop string
740 extra string
741 args string
742 }{
743 {
Colin Crossaf9c55b2017-10-03 14:50:08 -0700744 // Test that a module with java_resource_dirs includes the files
Colin Cross0f37af02017-09-27 17:42:05 -0700745 name: "resource dirs",
Colin Cross824bee32017-11-22 17:27:51 -0800746 prop: `java_resource_dirs: ["java-res"]`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700747 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700748 },
749 {
750 // Test that a module with java_resources includes the files
751 name: "resource files",
Colin Cross0ead1d72018-04-10 13:07:42 -0700752 prop: `java_resources: ["java-res/a/a", "java-res/b/b"]`,
753 args: "-C . -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700754 },
755 {
756 // Test that a module with a filegroup in java_resources includes the files with the
757 // path prefix
758 name: "resource filegroup",
759 prop: `java_resources: [":foo-res"]`,
760 extra: `
761 filegroup {
762 name: "foo-res",
Colin Cross824bee32017-11-22 17:27:51 -0800763 path: "java-res",
Colin Cross0ead1d72018-04-10 13:07:42 -0700764 srcs: ["java-res/a/a", "java-res/b/b"],
Colin Cross0f37af02017-09-27 17:42:05 -0700765 }`,
Colin Cross0ead1d72018-04-10 13:07:42 -0700766 args: "-C java-res -f java-res/a/a -f java-res/b/b",
Colin Cross0f37af02017-09-27 17:42:05 -0700767 },
768 {
Colin Cross0ead1d72018-04-10 13:07:42 -0700769 // Test that a module with wildcards in java_resource_dirs has the correct path prefixes
770 name: "wildcard dirs",
771 prop: `java_resource_dirs: ["java-res/*"]`,
772 args: "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b",
773 },
774 {
775 // Test that a module exclude_java_resource_dirs excludes the files
776 name: "wildcard dirs",
777 prop: `java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"]`,
778 args: "-C java-res/a -f java-res/a/a",
779 },
Colin Crosscedd4762018-09-13 11:26:19 -0700780 {
781 // Test wildcards in java_resources
782 name: "wildcard files",
783 prop: `java_resources: ["java-res/**/*"]`,
784 args: "-C . -f java-res/a/a -f java-res/b/b",
785 },
786 {
787 // Test exclude_java_resources with java_resources
788 name: "wildcard files with exclude",
789 prop: `java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"]`,
790 args: "-C . -f java-res/a/a",
791 },
792 {
793 // Test exclude_java_resources with java_resource_dirs
794 name: "resource dirs with exclude files",
795 prop: `java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"]`,
796 args: "-C java-res -f java-res/a/a",
797 },
798 {
799 // Test exclude_java_resource_dirs with java_resource_dirs
800 name: "resource dirs with exclude files",
801 prop: `java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"]`,
802 args: "-C java-res -f java-res/a/a -f java-res/b/b",
803 },
Colin Cross0f37af02017-09-27 17:42:05 -0700804 }
805
806 for _, test := range table {
807 t.Run(test.name, func(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700808 ctx, _ := testJavaWithFS(t, `
Colin Cross0f37af02017-09-27 17:42:05 -0700809 java_library {
810 name: "foo",
811 srcs: [
812 "a.java",
813 "b.java",
814 "c.java",
815 ],
816 `+test.prop+`,
817 }
Colin Cross238c1f32020-06-07 16:58:18 -0700818 `+test.extra,
819 map[string][]byte{
820 "java-res/a/a": nil,
821 "java-res/b/b": nil,
822 "java-res2/a": nil,
823 },
824 )
Colin Cross0f37af02017-09-27 17:42:05 -0700825
Colin Cross331a1212018-08-15 20:40:52 -0700826 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
Colin Cross1ee23172017-10-18 14:44:18 -0700827 fooRes := ctx.ModuleForTests("foo", "android_common").Output("res/foo.jar")
Colin Cross0f37af02017-09-27 17:42:05 -0700828
829 if !inList(fooRes.Output.String(), foo.Inputs.Strings()) {
830 t.Errorf("foo combined jars %v does not contain %q",
831 foo.Inputs.Strings(), fooRes.Output.String())
832 }
833
Colin Crossaf9c55b2017-10-03 14:50:08 -0700834 if fooRes.Args["jarArgs"] != test.args {
835 t.Errorf("foo resource jar args %q is not %q",
Colin Cross0f37af02017-09-27 17:42:05 -0700836 fooRes.Args["jarArgs"], test.args)
837 }
838 })
839 }
840}
841
Colin Cross0c4ce212019-05-03 15:28:19 -0700842func TestIncludeSrcs(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700843 ctx, _ := testJavaWithFS(t, `
Colin Cross0c4ce212019-05-03 15:28:19 -0700844 java_library {
845 name: "foo",
846 srcs: [
847 "a.java",
848 "b.java",
849 "c.java",
850 ],
851 include_srcs: true,
852 }
853
854 java_library {
855 name: "bar",
856 srcs: [
857 "a.java",
858 "b.java",
859 "c.java",
860 ],
861 java_resource_dirs: ["java-res"],
862 include_srcs: true,
863 }
Colin Cross238c1f32020-06-07 16:58:18 -0700864 `, map[string][]byte{
865 "java-res/a/a": nil,
866 "java-res/b/b": nil,
867 "java-res2/a": nil,
868 })
Colin Cross0c4ce212019-05-03 15:28:19 -0700869
870 // Test a library with include_srcs: true
871 foo := ctx.ModuleForTests("foo", "android_common").Output("withres/foo.jar")
872 fooSrcJar := ctx.ModuleForTests("foo", "android_common").Output("foo.srcjar")
873
874 if g, w := fooSrcJar.Output.String(), foo.Inputs.Strings(); !inList(g, w) {
875 t.Errorf("foo combined jars %v does not contain %q", w, g)
876 }
877
878 if g, w := fooSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
879 t.Errorf("foo source jar args %q is not %q", w, g)
880 }
881
882 // Test a library with include_srcs: true and resources
883 bar := ctx.ModuleForTests("bar", "android_common").Output("withres/bar.jar")
884 barResCombined := ctx.ModuleForTests("bar", "android_common").Output("res-combined/bar.jar")
885 barRes := ctx.ModuleForTests("bar", "android_common").Output("res/bar.jar")
886 barSrcJar := ctx.ModuleForTests("bar", "android_common").Output("bar.srcjar")
887
888 if g, w := barSrcJar.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
889 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
890 }
891
892 if g, w := barRes.Output.String(), barResCombined.Inputs.Strings(); !inList(g, w) {
893 t.Errorf("bar combined resource jars %v does not contain %q", w, g)
894 }
895
896 if g, w := barResCombined.Output.String(), bar.Inputs.Strings(); !inList(g, w) {
897 t.Errorf("bar combined jars %v does not contain %q", w, g)
898 }
899
900 if g, w := barSrcJar.Args["jarArgs"], "-C . -f a.java -f b.java -f c.java"; g != w {
901 t.Errorf("bar source jar args %q is not %q", w, g)
902 }
903
904 if g, w := barRes.Args["jarArgs"], "-C java-res -f java-res/a/a -f java-res/b/b"; g != w {
905 t.Errorf("bar resource jar args %q is not %q", w, g)
906 }
907}
908
Colin Cross54190b32017-10-09 15:34:10 -0700909func TestGeneratedSources(t *testing.T) {
Colin Cross238c1f32020-06-07 16:58:18 -0700910 ctx, _ := testJavaWithFS(t, `
Colin Cross54190b32017-10-09 15:34:10 -0700911 java_library {
912 name: "foo",
913 srcs: [
914 "a*.java",
915 ":gen",
916 "b*.java",
917 ],
918 }
919
920 genrule {
921 name: "gen",
Colin Cross824bee32017-11-22 17:27:51 -0800922 tool_files: ["java-res/a"],
Colin Cross54190b32017-10-09 15:34:10 -0700923 out: ["gen.java"],
924 }
Colin Cross238c1f32020-06-07 16:58:18 -0700925 `, map[string][]byte{
926 "a.java": nil,
927 "b.java": nil,
928 })
Colin Cross54190b32017-10-09 15:34:10 -0700929
930 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
931 genrule := ctx.ModuleForTests("gen", "").Rule("generator")
932
Colin Cross15e86d92017-10-20 15:07:08 -0700933 if filepath.Base(genrule.Output.String()) != "gen.java" {
934 t.Fatalf(`gen output file %v is not ".../gen.java"`, genrule.Output.String())
Colin Cross54190b32017-10-09 15:34:10 -0700935 }
936
937 if len(javac.Inputs) != 3 ||
938 javac.Inputs[0].String() != "a.java" ||
Colin Cross15e86d92017-10-20 15:07:08 -0700939 javac.Inputs[1].String() != genrule.Output.String() ||
Colin Cross54190b32017-10-09 15:34:10 -0700940 javac.Inputs[2].String() != "b.java" {
941 t.Errorf(`foo inputs %v != ["a.java", ".../gen.java", "b.java"]`, javac.Inputs)
942 }
943}
944
Nan Zhang61eaedb2017-11-02 13:28:15 -0700945func TestTurbine(t *testing.T) {
Paul Duffin71ae5942021-03-22 15:36:52 +0000946 result := android.GroupFixturePreparers(
947 prepareForJavaTest, FixtureWithPrebuiltApis(map[string][]string{"14": {"foo"}})).
Paul Duffin3d9f2682021-03-13 09:47:16 +0000948 RunTestWithBp(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -0700949 java_library {
950 name: "foo",
951 srcs: ["a.java"],
Jiyong Park2d492942018-03-05 17:44:10 +0900952 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -0700953 }
954
955 java_library {
956 name: "bar",
Colin Cross9bc43432017-12-15 20:20:39 -0800957 srcs: ["b.java"],
Nan Zhang61eaedb2017-11-02 13:28:15 -0700958 static_libs: ["foo"],
Jiyong Park2d492942018-03-05 17:44:10 +0900959 sdk_version: "14",
Nan Zhang61eaedb2017-11-02 13:28:15 -0700960 }
961
962 java_library {
963 name: "baz",
964 srcs: ["c.java"],
965 libs: ["bar"],
966 sdk_version: "14",
967 }
968 `)
969
Paul Duffina71a67a2021-03-29 00:42:57 +0100970 fooTurbine := result.ModuleForTests("foo", "android_common").Rule("turbine")
971 barTurbine := result.ModuleForTests("bar", "android_common").Rule("turbine")
972 barJavac := result.ModuleForTests("bar", "android_common").Rule("javac")
973 barTurbineCombined := result.ModuleForTests("bar", "android_common").Description("for turbine")
974 bazJavac := result.ModuleForTests("baz", "android_common").Rule("javac")
Nan Zhang61eaedb2017-11-02 13:28:15 -0700975
Paul Duffin414ea5e2021-03-22 17:31:52 +0000976 android.AssertPathsRelativeToTopEquals(t, "foo inputs", []string{"a.java"}, fooTurbine.Inputs)
Nan Zhang61eaedb2017-11-02 13:28:15 -0700977
Paul Duffin414ea5e2021-03-22 17:31:52 +0000978 fooHeaderJar := filepath.Join("out", "soong", ".intermediates", "foo", "android_common", "turbine-combined", "foo.jar")
979 barTurbineJar := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine", "bar.jar")
Colin Crossf61766e2022-03-16 18:06:48 -0700980 android.AssertStringDoesContain(t, "bar turbine classpath", barTurbine.Args["turbineFlags"], fooHeaderJar)
Paul Duffin3d9f2682021-03-13 09:47:16 +0000981 android.AssertStringDoesContain(t, "bar javac classpath", barJavac.Args["classpath"], fooHeaderJar)
Paul Duffin414ea5e2021-03-22 17:31:52 +0000982 android.AssertPathsRelativeToTopEquals(t, "bar turbine combineJar", []string{barTurbineJar, fooHeaderJar}, barTurbineCombined.Inputs)
Paul Duffin3d9f2682021-03-13 09:47:16 +0000983 android.AssertStringDoesContain(t, "baz javac classpath", bazJavac.Args["classpath"], "prebuilts/sdk/14/public/android.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -0700984}
985
986func TestSharding(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -0700987 ctx, _ := testJava(t, `
Nan Zhang61eaedb2017-11-02 13:28:15 -0700988 java_library {
989 name: "bar",
990 srcs: ["a.java","b.java","c.java"],
991 javac_shard_size: 1
992 }
993 `)
994
Colin Cross3d56ed52021-11-18 22:23:12 -0800995 barHeaderJar := filepath.Join("out", "soong", ".intermediates", "bar", "android_common", "turbine", "bar.jar")
Nan Zhang61eaedb2017-11-02 13:28:15 -0700996 for i := 0; i < 3; i++ {
Paul Duffina71a67a2021-03-29 00:42:57 +0100997 barJavac := ctx.ModuleForTests("bar", "android_common").Description("javac" + strconv.Itoa(i))
Colin Cross3d56ed52021-11-18 22:23:12 -0800998 if !strings.HasPrefix(barJavac.Args["classpath"], "-classpath "+barHeaderJar+":") {
999 t.Errorf("bar javac classpath %v does start with %q", barJavac.Args["classpath"], barHeaderJar)
Nan Zhang61eaedb2017-11-02 13:28:15 -07001000 }
1001 }
1002}
1003
Nan Zhang27e284d2018-02-09 21:03:53 +00001004func TestExcludeFileGroupInSrcs(t *testing.T) {
Jaewoong Jungf9a04432019-07-17 11:15:09 -07001005 ctx, _ := testJava(t, `
Nan Zhang27e284d2018-02-09 21:03:53 +00001006 java_library {
1007 name: "foo",
1008 srcs: ["a.java", ":foo-srcs"],
1009 exclude_srcs: ["a.java", ":foo-excludes"],
1010 }
1011
1012 filegroup {
1013 name: "foo-srcs",
1014 srcs: ["java-fg/a.java", "java-fg/b.java", "java-fg/c.java"],
1015 }
1016
1017 filegroup {
1018 name: "foo-excludes",
1019 srcs: ["java-fg/a.java", "java-fg/b.java"],
1020 }
1021 `)
1022
1023 javac := ctx.ModuleForTests("foo", "android_common").Rule("javac")
1024
1025 if len(javac.Inputs) != 1 || javac.Inputs[0].String() != "java-fg/c.java" {
1026 t.Errorf(`foo inputs %v != ["java-fg/c.java"]`, javac.Inputs)
1027 }
1028}
Jiyong Parkc678ad32018-04-10 13:07:10 +09001029
Paul Duffin52d398a2019-06-11 12:31:14 +01001030func TestJavaLibrary(t *testing.T) {
Paul Duffin414ea5e2021-03-22 17:31:52 +00001031 testJavaWithFS(t, "", map[string][]byte{
Paul Duffin52d398a2019-06-11 12:31:14 +01001032 "libcore/Android.bp": []byte(`
1033 java_library {
1034 name: "core",
1035 sdk_version: "none",
1036 system_modules: "none",
Paul Duffinaa55f742020-10-06 17:20:13 +01001037 }
1038
1039 filegroup {
1040 name: "core-jar",
1041 srcs: [":core{.jar}"],
1042 }
Paul Duffin414ea5e2021-03-22 17:31:52 +00001043 `),
Paul Duffinaa55f742020-10-06 17:20:13 +01001044 })
Paul Duffinaa55f742020-10-06 17:20:13 +01001045}
1046
1047func TestJavaImport(t *testing.T) {
Paul Duffin414ea5e2021-03-22 17:31:52 +00001048 testJavaWithFS(t, "", map[string][]byte{
Paul Duffinaa55f742020-10-06 17:20:13 +01001049 "libcore/Android.bp": []byte(`
1050 java_import {
1051 name: "core",
1052 sdk_version: "none",
1053 }
1054
1055 filegroup {
1056 name: "core-jar",
1057 srcs: [":core{.jar}"],
1058 }
Paul Duffin414ea5e2021-03-22 17:31:52 +00001059 `),
Paul Duffin52d398a2019-06-11 12:31:14 +01001060 })
Paul Duffin52d398a2019-06-11 12:31:14 +01001061}
1062
Zoran Jovanovic8736ce22018-08-21 17:10:29 +02001063var compilerFlagsTestCases = []struct {
1064 in string
1065 out bool
1066}{
1067 {
1068 in: "a",
1069 out: false,
1070 },
1071 {
1072 in: "-a",
1073 out: true,
1074 },
1075 {
1076 in: "-no-jdk",
1077 out: false,
1078 },
1079 {
1080 in: "-no-stdlib",
1081 out: false,
1082 },
1083 {
1084 in: "-kotlin-home",
1085 out: false,
1086 },
1087 {
1088 in: "-kotlin-home /some/path",
1089 out: false,
1090 },
1091 {
1092 in: "-include-runtime",
1093 out: false,
1094 },
1095 {
1096 in: "-Xintellij-plugin-root",
1097 out: false,
1098 },
1099}
1100
1101type mockContext struct {
1102 android.ModuleContext
1103 result bool
1104}
1105
1106func (ctx *mockContext) PropertyErrorf(property, format string, args ...interface{}) {
1107 // CheckBadCompilerFlags calls this function when the flag should be rejected
1108 ctx.result = false
1109}
1110
1111func TestCompilerFlags(t *testing.T) {
1112 for _, testCase := range compilerFlagsTestCases {
1113 ctx := &mockContext{result: true}
1114 CheckKotlincFlags(ctx, []string{testCase.in})
1115 if ctx.result != testCase.out {
1116 t.Errorf("incorrect output:")
1117 t.Errorf(" input: %#v", testCase.in)
1118 t.Errorf(" expected: %#v", testCase.out)
1119 t.Errorf(" got: %#v", ctx.result)
1120 }
1121 }
1122}
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001123
1124// TODO(jungjw): Consider making this more robust by ignoring path order.
1125func checkPatchModuleFlag(t *testing.T, ctx *android.TestContext, moduleName string, expected string) {
Paul Duffin414ea5e2021-03-22 17:31:52 +00001126 variables := ctx.ModuleForTests(moduleName, "android_common").VariablesForTestsRelativeToTop()
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001127 flags := strings.Split(variables["javacFlags"], " ")
1128 got := ""
1129 for _, flag := range flags {
1130 keyEnd := strings.Index(flag, "=")
1131 if keyEnd > -1 && flag[:keyEnd] == "--patch-module" {
1132 got = flag[keyEnd+1:]
1133 break
1134 }
1135 }
Lukacs T. Berki9f6c24a2021-08-26 15:07:24 +02001136 if expected != android.StringPathRelativeToTop(ctx.Config().SoongOutDir(), got) {
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001137 t.Errorf("Unexpected patch-module flag for module %q - expected %q, but got %q", moduleName, expected, got)
1138 }
1139}
1140
1141func TestPatchModule(t *testing.T) {
Pete Gillin0c2143e2019-05-02 15:32:11 +01001142 t.Run("Java language level 8", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01001143 // Test with legacy javac -source 1.8 -target 1.8
Pete Gillinbdf5d712019-10-21 14:29:58 +01001144 bp := `
1145 java_library {
1146 name: "foo",
1147 srcs: ["a.java"],
1148 java_version: "1.8",
1149 }
1150
1151 java_library {
1152 name: "bar",
1153 srcs: ["b.java"],
1154 sdk_version: "none",
1155 system_modules: "none",
1156 patch_module: "java.base",
1157 java_version: "1.8",
1158 }
1159
1160 java_library {
1161 name: "baz",
1162 srcs: ["c.java"],
1163 patch_module: "java.base",
1164 java_version: "1.8",
1165 }
1166 `
1167 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001168
1169 checkPatchModuleFlag(t, ctx, "foo", "")
1170 checkPatchModuleFlag(t, ctx, "bar", "")
1171 checkPatchModuleFlag(t, ctx, "baz", "")
1172 })
1173
Pete Gillin0c2143e2019-05-02 15:32:11 +01001174 t.Run("Java language level 9", func(t *testing.T) {
Pete Gillin1b3370f2019-10-01 13:57:31 +01001175 // Test with default javac -source 9 -target 9
Pete Gillinbdf5d712019-10-21 14:29:58 +01001176 bp := `
1177 java_library {
1178 name: "foo",
1179 srcs: ["a.java"],
1180 }
1181
1182 java_library {
1183 name: "bar",
1184 srcs: ["b.java"],
1185 sdk_version: "none",
1186 system_modules: "none",
1187 patch_module: "java.base",
1188 }
1189
1190 java_library {
1191 name: "baz",
Jingwen Chen5136a6e2020-10-30 01:01:35 -04001192 srcs: [
1193 "c.java",
1194 // Tests for b/150878007
1195 "dir/d.java",
1196 "dir2/e.java",
1197 "dir2/f.java",
1198 "nested/dir/g.java"
1199 ],
Pete Gillinbdf5d712019-10-21 14:29:58 +01001200 patch_module: "java.base",
1201 }
1202 `
Pete Gillin1b3370f2019-10-01 13:57:31 +01001203 ctx, _ := testJava(t, bp)
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001204
1205 checkPatchModuleFlag(t, ctx, "foo", "")
Paul Duffin414ea5e2021-03-22 17:31:52 +00001206 expected := "java.base=.:out/soong"
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001207 checkPatchModuleFlag(t, ctx, "bar", expected)
Jingwen Chen5136a6e2020-10-30 01:01:35 -04001208 expected = "java.base=" + strings.Join([]string{
Paul Duffin414ea5e2021-03-22 17:31:52 +00001209 ".", "out/soong", "dir", "dir2", "nested", defaultModuleToPath("ext"), defaultModuleToPath("framework")}, ":")
Jaewoong Jung38e4fb22018-12-12 09:01:34 -08001210 checkPatchModuleFlag(t, ctx, "baz", expected)
1211 })
1212}
Paul Duffina7b9f422020-01-10 17:12:18 +00001213
Paul Duffin83a2d962019-11-19 19:44:10 +00001214func TestJavaLibraryWithSystemModules(t *testing.T) {
1215 ctx, _ := testJava(t, `
1216 java_library {
1217 name: "lib-with-source-system-modules",
1218 srcs: [
1219 "a.java",
1220 ],
1221 sdk_version: "none",
1222 system_modules: "source-system-modules",
1223 }
1224
1225 java_library {
1226 name: "source-jar",
1227 srcs: [
1228 "a.java",
1229 ],
1230 }
1231
1232 java_system_modules {
1233 name: "source-system-modules",
1234 libs: ["source-jar"],
1235 }
1236
1237 java_library {
1238 name: "lib-with-prebuilt-system-modules",
1239 srcs: [
1240 "a.java",
1241 ],
1242 sdk_version: "none",
1243 system_modules: "prebuilt-system-modules",
1244 }
1245
1246 java_import {
1247 name: "prebuilt-jar",
1248 jars: ["a.jar"],
1249 }
1250
1251 java_system_modules_import {
1252 name: "prebuilt-system-modules",
1253 libs: ["prebuilt-jar"],
1254 }
1255 `)
1256
1257 checkBootClasspathForSystemModule(t, ctx, "lib-with-source-system-modules", "/source-jar.jar")
1258
1259 checkBootClasspathForSystemModule(t, ctx, "lib-with-prebuilt-system-modules", "/prebuilt-jar.jar")
1260}
1261
1262func checkBootClasspathForSystemModule(t *testing.T, ctx *android.TestContext, moduleName string, expectedSuffix string) {
1263 javacRule := ctx.ModuleForTests(moduleName, "android_common").Rule("javac")
1264 bootClasspath := javacRule.Args["bootClasspath"]
1265 if strings.HasPrefix(bootClasspath, "--system ") && strings.HasSuffix(bootClasspath, expectedSuffix) {
1266 t.Errorf("bootclasspath of %q must start with --system and end with %q, but was %#v.", moduleName, expectedSuffix, bootClasspath)
1267 }
1268}
Jiyong Park19604de2020-03-24 16:44:11 +09001269
1270func TestAidlExportIncludeDirsFromImports(t *testing.T) {
1271 ctx, _ := testJava(t, `
1272 java_library {
1273 name: "foo",
1274 srcs: ["aidl/foo/IFoo.aidl"],
1275 libs: ["bar"],
1276 }
1277
1278 java_import {
1279 name: "bar",
1280 jars: ["a.jar"],
1281 aidl: {
1282 export_include_dirs: ["aidl/bar"],
1283 },
1284 }
1285 `)
1286
1287 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
1288 expectedAidlFlag := "-Iaidl/bar"
1289 if !strings.Contains(aidlCommand, expectedAidlFlag) {
1290 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
1291 }
1292}
Liz Kammerdd849a82020-06-12 16:38:45 -07001293
Vinh Tran16fe8e12022-08-16 16:45:44 -04001294func TestAidlIncludeDirFromConvertedFileGroupWithPathPropInMixedBuilds(t *testing.T) {
Liz Kammer748209c2022-10-24 10:43:27 -04001295 // TODO(b/247782695), TODO(b/242847534) Fix mixed builds for filegroups
1296 t.Skip("Re-enable once filegroups are corrected for mixed builds")
Vinh Tran16fe8e12022-08-16 16:45:44 -04001297 bp := `
1298 filegroup {
1299 name: "foo_aidl",
1300 srcs: ["aidl/foo/IFoo.aidl"],
1301 path: "aidl/foo",
1302 bazel_module: { label: "//:foo_aidl" },
1303 }
1304 java_library {
1305 name: "foo",
1306 srcs: [":foo_aidl"],
1307 }
1308`
1309
1310 outBaseDir := "out/bazel/output"
1311 result := android.GroupFixturePreparers(
1312 prepareForJavaTest,
1313 android.PrepareForTestWithFilegroup,
1314 android.FixtureModifyConfig(func(config android.Config) {
1315 config.BazelContext = android.MockBazelContext{
1316 OutputBaseDir: outBaseDir,
1317 LabelToOutputFiles: map[string][]string{
1318 "//:foo_aidl": []string{"aidl/foo/IFoo.aidl"},
1319 },
1320 }
1321 }),
1322 ).RunTestWithBp(t, bp)
1323
1324 aidlCommand := result.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
1325 expectedAidlFlag := "-I" + outBaseDir + "/execroot/__main__/aidl/foo"
1326 if !strings.Contains(aidlCommand, expectedAidlFlag) {
1327 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
1328 }
1329}
1330
Jooyung Hane197d8b2021-01-05 10:33:16 +09001331func TestAidlFlagsArePassedToTheAidlCompiler(t *testing.T) {
1332 ctx, _ := testJava(t, `
1333 java_library {
1334 name: "foo",
1335 srcs: ["aidl/foo/IFoo.aidl"],
1336 aidl: { flags: ["-Werror"], },
1337 }
1338 `)
1339
1340 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
1341 expectedAidlFlag := "-Werror"
1342 if !strings.Contains(aidlCommand, expectedAidlFlag) {
1343 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
1344 }
1345}
1346
Jooyung Han07f70c02021-11-06 07:08:45 +09001347func TestAidlFlagsWithMinSdkVersion(t *testing.T) {
1348 fixture := android.GroupFixturePreparers(
1349 prepareForJavaTest, FixtureWithPrebuiltApis(map[string][]string{"14": {"foo"}}))
1350
1351 for _, tc := range []struct {
1352 name string
1353 sdkVersion string
1354 expected string
1355 }{
1356 {"default is current", "", "current"},
1357 {"use sdk_version", `sdk_version: "14"`, "14"},
1358 {"system_current", `sdk_version: "system_current"`, "current"},
1359 } {
1360 t.Run(tc.name, func(t *testing.T) {
1361 ctx := fixture.RunTestWithBp(t, `
1362 java_library {
1363 name: "foo",
1364 srcs: ["aidl/foo/IFoo.aidl"],
1365 `+tc.sdkVersion+`
1366 }
1367 `)
1368 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
1369 expectedAidlFlag := "--min_sdk_version=" + tc.expected
1370 if !strings.Contains(aidlCommand, expectedAidlFlag) {
1371 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
1372 }
1373 })
1374 }
1375}
1376
Spandan Das757b6662022-11-17 04:29:59 +00001377func TestAidlFlagsMinSdkVersionDroidstubs(t *testing.T) {
1378 bpTemplate := `
1379 droidstubs {
1380 name: "foo-stubs",
1381 srcs: ["foo.aidl"],
1382 %s
1383 system_modules: "none",
1384 }
1385 `
1386 testCases := []struct {
1387 desc string
1388 sdkVersionBp string
1389 minSdkVersionExpected string
1390 }{
1391 {
1392 desc: "sdk_version not set, module compiles against private platform APIs",
1393 sdkVersionBp: ``,
1394 minSdkVersionExpected: "10000",
1395 },
1396 {
1397 desc: "sdk_version set to none, module does not build against an SDK",
1398 sdkVersionBp: `sdk_version: "none",`,
1399 minSdkVersionExpected: "10000",
1400 },
1401 }
1402 for _, tc := range testCases {
1403 ctx := prepareForJavaTest.RunTestWithBp(t, fmt.Sprintf(bpTemplate, tc.sdkVersionBp))
1404 aidlCmd := ctx.ModuleForTests("foo-stubs", "android_common").Rule("aidl").RuleParams.Command
1405 expected := "--min_sdk_version=" + tc.minSdkVersionExpected
1406 android.AssertStringDoesContain(t, "aidl command conatins incorrect min_sdk_version for testCse: "+tc.desc, aidlCmd, expected)
1407 }
1408}
1409
Thiébaud Weksteende8417c2022-02-10 15:41:46 +11001410func TestAidlEnforcePermissions(t *testing.T) {
1411 ctx, _ := testJava(t, `
1412 java_library {
1413 name: "foo",
1414 srcs: ["aidl/foo/IFoo.aidl"],
1415 aidl: { enforce_permissions: true },
1416 }
1417 `)
1418
1419 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
1420 expectedAidlFlag := "-Wmissing-permission-annotation -Werror"
1421 if !strings.Contains(aidlCommand, expectedAidlFlag) {
1422 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
1423 }
1424}
1425
1426func TestAidlEnforcePermissionsException(t *testing.T) {
1427 ctx, _ := testJava(t, `
1428 java_library {
1429 name: "foo",
1430 srcs: ["aidl/foo/IFoo.aidl", "aidl/foo/IFoo2.aidl"],
1431 aidl: { enforce_permissions: true, enforce_permissions_exceptions: ["aidl/foo/IFoo2.aidl"] },
1432 }
1433 `)
1434
1435 aidlCommand := ctx.ModuleForTests("foo", "android_common").Rule("aidl").RuleParams.Command
1436 expectedAidlFlag := "$$FLAGS -Wmissing-permission-annotation -Werror aidl/foo/IFoo.aidl"
1437 if !strings.Contains(aidlCommand, expectedAidlFlag) {
1438 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
1439 }
1440 expectedAidlFlag = "$$FLAGS aidl/foo/IFoo2.aidl"
1441 if !strings.Contains(aidlCommand, expectedAidlFlag) {
1442 t.Errorf("aidl command %q does not contain %q", aidlCommand, expectedAidlFlag)
1443 }
1444}
1445
Liz Kammerdd849a82020-06-12 16:38:45 -07001446func TestDataNativeBinaries(t *testing.T) {
Cole Faust5c503d12023-01-24 11:48:08 -08001447 ctx := android.GroupFixturePreparers(
1448 prepareForJavaTest,
1449 android.PrepareForTestWithAllowMissingDependencies).RunTestWithBp(t, `
Liz Kammerdd849a82020-06-12 16:38:45 -07001450 java_test_host {
1451 name: "foo",
1452 srcs: ["a.java"],
1453 data_native_bins: ["bin"]
1454 }
1455
Cole Faust5c503d12023-01-24 11:48:08 -08001456 cc_binary_host {
Liz Kammerdd849a82020-06-12 16:38:45 -07001457 name: "bin",
Cole Faust5c503d12023-01-24 11:48:08 -08001458 srcs: ["bin.cpp"],
Liz Kammerdd849a82020-06-12 16:38:45 -07001459 }
Cole Faust5c503d12023-01-24 11:48:08 -08001460 `).TestContext
Liz Kammerdd849a82020-06-12 16:38:45 -07001461
Colin Cross0c66bc62021-07-20 09:47:41 -07001462 buildOS := ctx.Config().BuildOS.String()
Liz Kammerdd849a82020-06-12 16:38:45 -07001463
1464 test := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost)
Colin Crossaa255532020-07-03 13:18:24 -07001465 entries := android.AndroidMkEntriesForTest(t, ctx, test)[0]
Cole Faust5c503d12023-01-24 11:48:08 -08001466 expected := []string{"out/soong/.intermediates/bin/" + buildOS + "_x86_64/bin:bin"}
Liz Kammerdd849a82020-06-12 16:38:45 -07001467 actual := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"]
Paul Duffin414ea5e2021-03-22 17:31:52 +00001468 android.AssertStringPathsRelativeToTopEquals(t, "LOCAL_COMPATIBILITY_SUPPORT_FILES", ctx.Config(), expected, actual)
Liz Kammerdd849a82020-06-12 16:38:45 -07001469}
Yuexi Ma627263f2021-03-04 13:47:56 -08001470
1471func TestDefaultInstallable(t *testing.T) {
1472 ctx, _ := testJava(t, `
1473 java_test_host {
1474 name: "foo"
1475 }
1476 `)
1477
Colin Cross0c66bc62021-07-20 09:47:41 -07001478 buildOS := ctx.Config().BuildOS.String()
Yuexi Ma627263f2021-03-04 13:47:56 -08001479 module := ctx.ModuleForTests("foo", buildOS+"_common").Module().(*TestHost)
1480 assertDeepEquals(t, "Default installable value should be true.", proptools.BoolPtr(true),
1481 module.properties.Installable)
1482}
Cole Faust75fffb12021-06-13 15:23:16 -07001483
1484func TestErrorproneEnabled(t *testing.T) {
1485 ctx, _ := testJava(t, `
1486 java_library {
1487 name: "foo",
1488 srcs: ["a.java"],
1489 errorprone: {
1490 enabled: true,
1491 },
1492 }
1493 `)
1494
1495 javac := ctx.ModuleForTests("foo", "android_common").Description("javac")
1496
1497 // Test that the errorprone plugins are passed to javac
1498 expectedSubstring := "-Xplugin:ErrorProne"
1499 if !strings.Contains(javac.Args["javacFlags"], expectedSubstring) {
Cole Faust2b1536e2021-06-18 12:25:54 -07001500 t.Errorf("expected javacFlags to contain %q, got %q", expectedSubstring, javac.Args["javacFlags"])
Cole Faust75fffb12021-06-13 15:23:16 -07001501 }
1502
1503 // Modules with errorprone { enabled: true } will include errorprone checks
1504 // in the main javac build rule. Only when RUN_ERROR_PRONE is true will
1505 // the explicit errorprone build rule be created.
1506 errorprone := ctx.ModuleForTests("foo", "android_common").MaybeDescription("errorprone")
1507 if errorprone.RuleParams.Description != "" {
1508 t.Errorf("expected errorprone build rule to not exist, but it did")
1509 }
1510}
Cole Faust2b1536e2021-06-18 12:25:54 -07001511
1512func TestErrorproneDisabled(t *testing.T) {
1513 bp := `
1514 java_library {
1515 name: "foo",
1516 srcs: ["a.java"],
1517 errorprone: {
1518 enabled: false,
1519 },
1520 }
1521 `
1522 ctx := android.GroupFixturePreparers(
1523 PrepareForTestWithJavaDefaultModules,
1524 android.FixtureMergeEnv(map[string]string{
1525 "RUN_ERROR_PRONE": "true",
1526 }),
1527 ).RunTestWithBp(t, bp)
1528
1529 javac := ctx.ModuleForTests("foo", "android_common").Description("javac")
1530
1531 // Test that the errorprone plugins are not passed to javac, like they would
1532 // be if enabled was true.
1533 expectedSubstring := "-Xplugin:ErrorProne"
1534 if strings.Contains(javac.Args["javacFlags"], expectedSubstring) {
1535 t.Errorf("expected javacFlags to not contain %q, got %q", expectedSubstring, javac.Args["javacFlags"])
1536 }
1537
1538 // Check that no errorprone build rule is created, like there would be
1539 // if enabled was unset and RUN_ERROR_PRONE was true.
1540 errorprone := ctx.ModuleForTests("foo", "android_common").MaybeDescription("errorprone")
1541 if errorprone.RuleParams.Description != "" {
1542 t.Errorf("expected errorprone build rule to not exist, but it did")
1543 }
1544}
1545
1546func TestErrorproneEnabledOnlyByEnvironmentVariable(t *testing.T) {
1547 bp := `
1548 java_library {
1549 name: "foo",
1550 srcs: ["a.java"],
1551 }
1552 `
1553 ctx := android.GroupFixturePreparers(
1554 PrepareForTestWithJavaDefaultModules,
1555 android.FixtureMergeEnv(map[string]string{
1556 "RUN_ERROR_PRONE": "true",
1557 }),
1558 ).RunTestWithBp(t, bp)
1559
1560 javac := ctx.ModuleForTests("foo", "android_common").Description("javac")
1561 errorprone := ctx.ModuleForTests("foo", "android_common").Description("errorprone")
1562
1563 // Check that the errorprone plugins are not passed to javac, because they
1564 // will instead be passed to the separate errorprone compilation
1565 expectedSubstring := "-Xplugin:ErrorProne"
1566 if strings.Contains(javac.Args["javacFlags"], expectedSubstring) {
1567 t.Errorf("expected javacFlags to not contain %q, got %q", expectedSubstring, javac.Args["javacFlags"])
1568 }
1569
1570 // Check that the errorprone plugin is enabled
1571 if !strings.Contains(errorprone.Args["javacFlags"], expectedSubstring) {
1572 t.Errorf("expected errorprone to contain %q, got %q", expectedSubstring, javac.Args["javacFlags"])
1573 }
1574}
Sam Delmericob3342ce2022-01-20 21:10:28 +00001575
1576func TestDataDeviceBinsBuildsDeviceBinary(t *testing.T) {
Sam Delmericocc271e22022-06-01 15:45:02 +00001577 testCases := []struct {
1578 dataDeviceBinType string
1579 depCompileMultilib string
1580 variants []string
1581 expectedError string
1582 }{
1583 {
1584 dataDeviceBinType: "first",
1585 depCompileMultilib: "first",
1586 variants: []string{"android_arm64_armv8-a"},
1587 },
1588 {
1589 dataDeviceBinType: "first",
1590 depCompileMultilib: "both",
1591 variants: []string{"android_arm64_armv8-a"},
1592 },
1593 {
1594 // this is true because our testing framework is set up with
1595 // Targets ~ [<64bit target>, <32bit target>], where 64bit is "first"
1596 dataDeviceBinType: "first",
1597 depCompileMultilib: "32",
1598 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1599 },
1600 {
1601 dataDeviceBinType: "first",
1602 depCompileMultilib: "64",
1603 variants: []string{"android_arm64_armv8-a"},
1604 },
1605 {
1606 dataDeviceBinType: "both",
1607 depCompileMultilib: "both",
1608 variants: []string{
1609 "android_arm_armv7-a-neon",
1610 "android_arm64_armv8-a",
1611 },
1612 },
1613 {
1614 dataDeviceBinType: "both",
1615 depCompileMultilib: "32",
1616 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1617 },
1618 {
1619 dataDeviceBinType: "both",
1620 depCompileMultilib: "64",
1621 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1622 },
1623 {
1624 dataDeviceBinType: "both",
1625 depCompileMultilib: "first",
1626 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1627 },
1628 {
1629 dataDeviceBinType: "32",
1630 depCompileMultilib: "32",
1631 variants: []string{"android_arm_armv7-a-neon"},
1632 },
1633 {
1634 dataDeviceBinType: "32",
1635 depCompileMultilib: "first",
1636 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1637 },
1638 {
1639 dataDeviceBinType: "32",
1640 depCompileMultilib: "both",
1641 variants: []string{"android_arm_armv7-a-neon"},
1642 },
1643 {
1644 dataDeviceBinType: "32",
1645 depCompileMultilib: "64",
1646 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1647 },
1648 {
1649 dataDeviceBinType: "64",
1650 depCompileMultilib: "64",
1651 variants: []string{"android_arm64_armv8-a"},
1652 },
1653 {
1654 dataDeviceBinType: "64",
1655 depCompileMultilib: "both",
1656 variants: []string{"android_arm64_armv8-a"},
1657 },
1658 {
1659 dataDeviceBinType: "64",
1660 depCompileMultilib: "first",
1661 variants: []string{"android_arm64_armv8-a"},
1662 },
1663 {
1664 dataDeviceBinType: "64",
1665 depCompileMultilib: "32",
1666 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1667 },
1668 {
1669 dataDeviceBinType: "prefer32",
1670 depCompileMultilib: "32",
1671 variants: []string{"android_arm_armv7-a-neon"},
1672 },
1673 {
1674 dataDeviceBinType: "prefer32",
1675 depCompileMultilib: "both",
1676 variants: []string{"android_arm_armv7-a-neon"},
1677 },
1678 {
1679 dataDeviceBinType: "prefer32",
1680 depCompileMultilib: "first",
1681 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1682 },
1683 {
1684 dataDeviceBinType: "prefer32",
1685 depCompileMultilib: "64",
1686 expectedError: `Android.bp:2:3: dependency "bar" of "foo" missing variant`,
1687 },
Sam Delmericob3342ce2022-01-20 21:10:28 +00001688 }
Sam Delmericob3342ce2022-01-20 21:10:28 +00001689
Sam Delmericocc271e22022-06-01 15:45:02 +00001690 bpTemplate := `
Sam Delmericob3342ce2022-01-20 21:10:28 +00001691 java_test_host {
1692 name: "foo",
1693 srcs: ["test.java"],
Sam Delmericocc271e22022-06-01 15:45:02 +00001694 data_device_bins_%s: ["bar"],
Sam Delmericob3342ce2022-01-20 21:10:28 +00001695 }
1696
1697 cc_binary {
1698 name: "bar",
Sam Delmericocc271e22022-06-01 15:45:02 +00001699 compile_multilib: "%s",
Sam Delmericob3342ce2022-01-20 21:10:28 +00001700 }
1701 `
1702
Sam Delmericocc271e22022-06-01 15:45:02 +00001703 for _, tc := range testCases {
1704 bp := fmt.Sprintf(bpTemplate, tc.dataDeviceBinType, tc.depCompileMultilib)
Sam Delmericob3342ce2022-01-20 21:10:28 +00001705
Sam Delmericocc271e22022-06-01 15:45:02 +00001706 errorHandler := android.FixtureExpectsNoErrors
1707 if tc.expectedError != "" {
1708 errorHandler = android.FixtureExpectsAtLeastOneErrorMatchingPattern(tc.expectedError)
1709 }
Sam Delmericob3342ce2022-01-20 21:10:28 +00001710
Sam Delmericocc271e22022-06-01 15:45:02 +00001711 testName := fmt.Sprintf(`data_device_bins_%s with compile_multilib:"%s"`, tc.dataDeviceBinType, tc.depCompileMultilib)
1712 t.Run(testName, func(t *testing.T) {
1713 ctx := android.GroupFixturePreparers(PrepareForIntegrationTestWithJava).
1714 ExtendWithErrorHandler(errorHandler).
1715 RunTestWithBp(t, bp)
1716 if tc.expectedError != "" {
1717 return
1718 }
1719
1720 buildOS := ctx.Config.BuildOS.String()
1721 fooVariant := ctx.ModuleForTests("foo", buildOS+"_common")
1722 fooMod := fooVariant.Module().(*TestHost)
1723 entries := android.AndroidMkEntriesForTest(t, ctx.TestContext, fooMod)[0]
1724
1725 expectedAutogenConfig := `<option name="push-file" key="bar" value="/data/local/tests/unrestricted/foo/bar" />`
1726 autogen := fooVariant.Rule("autogen")
1727 if !strings.Contains(autogen.Args["extraConfigs"], expectedAutogenConfig) {
1728 t.Errorf("foo extraConfigs %v does not contain %q", autogen.Args["extraConfigs"], expectedAutogenConfig)
1729 }
1730
1731 expectedData := []string{}
1732 for _, variant := range tc.variants {
1733 barVariant := ctx.ModuleForTests("bar", variant)
1734 relocated := barVariant.Output("bar")
1735 expectedInput := fmt.Sprintf("out/soong/.intermediates/bar/%s/unstripped/bar", variant)
1736 android.AssertPathRelativeToTopEquals(t, "relocation input", expectedInput, relocated.Input)
1737
1738 expectedData = append(expectedData, fmt.Sprintf("out/soong/.intermediates/bar/%s/bar:bar", variant))
1739 }
1740
1741 actualData := entries.EntryMap["LOCAL_COMPATIBILITY_SUPPORT_FILES"]
1742 android.AssertStringPathsRelativeToTopEquals(t, "LOCAL_TEST_DATA", ctx.Config, expectedData, actualData)
1743 })
Sam Delmericob3342ce2022-01-20 21:10:28 +00001744 }
1745}
Sam Delmerico277795c2022-02-25 17:04:37 +00001746
1747func TestImportMixedBuild(t *testing.T) {
1748 bp := `
1749 java_import {
1750 name: "baz",
1751 jars: [
1752 "test1.jar",
1753 "test2.jar",
1754 ],
1755 bazel_module: { label: "//foo/bar:baz" },
1756 }
1757 `
1758
1759 ctx := android.GroupFixturePreparers(
1760 prepareForJavaTest,
1761 android.FixtureModifyConfig(func(config android.Config) {
1762 config.BazelContext = android.MockBazelContext{
1763 OutputBaseDir: "outputbase",
1764 LabelToOutputFiles: map[string][]string{
1765 "//foo/bar:baz": []string{"test1.jar", "test2.jar"},
1766 },
1767 }
1768 }),
1769 ).RunTestWithBp(t, bp)
1770
1771 bazMod := ctx.ModuleForTests("baz", "android_common").Module()
1772 producer := bazMod.(android.OutputFileProducer)
1773 expectedOutputFiles := []string{".intermediates/baz/android_common/bazelCombined/baz.jar"}
1774
1775 outputFiles, err := producer.OutputFiles("")
1776 if err != nil {
1777 t.Errorf("Unexpected error getting java_import outputfiles %s", err)
1778 }
1779 actualOutputFiles := android.NormalizePathsForTesting(outputFiles)
1780 android.AssertDeepEquals(t, "Output files are produced", expectedOutputFiles, actualOutputFiles)
1781
1782 javaInfoProvider := ctx.ModuleProvider(bazMod, JavaInfoProvider)
1783 javaInfo, ok := javaInfoProvider.(JavaInfo)
1784 if !ok {
1785 t.Error("could not get JavaInfo from java_import module")
1786 }
1787 android.AssertDeepEquals(t, "Header JARs are produced", expectedOutputFiles, android.NormalizePathsForTesting(javaInfo.HeaderJars))
1788 android.AssertDeepEquals(t, "Implementation/Resources JARs are produced", expectedOutputFiles, android.NormalizePathsForTesting(javaInfo.ImplementationAndResourcesJars))
1789 android.AssertDeepEquals(t, "Implementation JARs are produced", expectedOutputFiles, android.NormalizePathsForTesting(javaInfo.ImplementationJars))
1790}
Sam Delmerico2351eac2022-05-24 17:10:02 +00001791
1792func TestGenAidlIncludeFlagsForMixedBuilds(t *testing.T) {
1793 bazelOutputBaseDir := filepath.Join("out", "bazel")
1794 result := android.GroupFixturePreparers(
1795 PrepareForIntegrationTestWithJava,
1796 android.FixtureModifyConfig(func(config android.Config) {
1797 config.BazelContext = android.MockBazelContext{
1798 OutputBaseDir: bazelOutputBaseDir,
1799 }
1800 }),
1801 ).RunTest(t)
1802
1803 ctx := &android.TestPathContext{TestResult: result}
1804
1805 srcDirectory := filepath.Join("frameworks", "base")
1806 srcDirectoryAlreadyIncluded := filepath.Join("frameworks", "base", "core", "java")
1807 bazelSrcDirectory := android.PathForBazelOut(ctx, srcDirectory)
1808 bazelSrcDirectoryAlreadyIncluded := android.PathForBazelOut(ctx, srcDirectoryAlreadyIncluded)
1809 srcs := android.Paths{
1810 android.PathForTestingWithRel(bazelSrcDirectory.String(), "bazelAidl.aidl"),
1811 android.PathForTestingWithRel(bazelSrcDirectory.String(), "bazelAidl2.aidl"),
1812 android.PathForTestingWithRel(bazelSrcDirectoryAlreadyIncluded.String(), "bazelAidlExclude.aidl"),
1813 android.PathForTestingWithRel(bazelSrcDirectoryAlreadyIncluded.String(), "bazelAidl2Exclude.aidl"),
1814 }
1815 dirsAlreadyIncluded := android.Paths{
1816 android.PathForTesting(srcDirectoryAlreadyIncluded),
1817 }
1818
1819 expectedFlags := " -Iout/bazel/execroot/__main__/frameworks/base"
1820 flags := genAidlIncludeFlags(ctx, srcs, dirsAlreadyIncluded)
1821 if flags != expectedFlags {
1822 t.Errorf("expected flags to be %q; was %q", expectedFlags, flags)
1823 }
1824}
Zi Wangca65b402022-10-10 13:45:06 -07001825
1826func TestDeviceBinaryWrapperGeneration(t *testing.T) {
1827 // Scenario 1: java_binary has main_class property in its bp
1828 ctx, _ := testJava(t, `
1829 java_binary {
1830 name: "foo",
1831 srcs: ["foo.java"],
1832 main_class: "foo.bar.jb",
1833 }
1834 `)
1835 wrapperPath := fmt.Sprint(ctx.ModuleForTests("foo", "android_arm64_armv8-a").AllOutputs())
1836 if !strings.Contains(wrapperPath, "foo.sh") {
1837 t.Errorf("wrapper file foo.sh is not generated")
1838 }
1839
1840 // Scenario 2: java_binary has neither wrapper nor main_class, its build
1841 // is expected to be failed.
1842 testJavaError(t, "main_class property is required for device binary if no default wrapper is assigned", `
1843 java_binary {
1844 name: "foo",
1845 srcs: ["foo.java"],
1846 }`)
1847}
Jihoon Kang0ac87c22022-11-15 19:06:14 +00001848
Jihoon Kang3198f3c2023-01-26 08:08:52 +00001849func TestJavaApiContributionEmptyApiFile(t *testing.T) {
1850 testJavaError(t,
1851 "Error: foo has an empty api file.",
1852 `java_api_contribution {
1853 name: "foo",
1854 }
1855 java_api_library {
1856 name: "bar",
1857 api_surface: "public",
1858 api_contributions: ["foo"],
1859 }
1860 `)
1861}
1862
Jihoon Kang0ac87c22022-11-15 19:06:14 +00001863func TestJavaApiLibraryAndProviderLink(t *testing.T) {
1864 provider_bp_a := `
1865 java_api_contribution {
1866 name: "foo1",
Jihoon Kang84473f52023-08-11 22:36:33 +00001867 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00001868 api_surface: "public",
Jihoon Kang0ac87c22022-11-15 19:06:14 +00001869 }
1870 `
1871 provider_bp_b := `java_api_contribution {
1872 name: "foo2",
Jihoon Kang84473f52023-08-11 22:36:33 +00001873 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00001874 api_surface: "public",
Jihoon Kang0ac87c22022-11-15 19:06:14 +00001875 }
1876 `
1877 ctx, _ := testJavaWithFS(t, `
1878 java_api_library {
1879 name: "bar1",
1880 api_surface: "public",
Jihoon Kang60d4a092022-11-17 23:47:43 +00001881 api_contributions: ["foo1"],
Jihoon Kang0ac87c22022-11-15 19:06:14 +00001882 }
1883
1884 java_api_library {
1885 name: "bar2",
1886 api_surface: "system",
Jihoon Kang60d4a092022-11-17 23:47:43 +00001887 api_contributions: ["foo1", "foo2"],
Jihoon Kang0ac87c22022-11-15 19:06:14 +00001888 }
1889 `,
1890 map[string][]byte{
1891 "a/Android.bp": []byte(provider_bp_a),
1892 "b/Android.bp": []byte(provider_bp_b),
1893 })
1894
1895 testcases := []struct {
1896 moduleName string
1897 sourceTextFileDirs []string
1898 }{
1899 {
1900 moduleName: "bar1",
Jihoon Kang84473f52023-08-11 22:36:33 +00001901 sourceTextFileDirs: []string{"a/current.txt"},
Jihoon Kang0ac87c22022-11-15 19:06:14 +00001902 },
1903 {
1904 moduleName: "bar2",
Jihoon Kang6be0f002023-09-20 23:03:01 +00001905 sourceTextFileDirs: []string{"a/current.txt", "b/current.txt"},
Jihoon Kang0ac87c22022-11-15 19:06:14 +00001906 },
1907 }
1908 for _, c := range testcases {
1909 m := ctx.ModuleForTests(c.moduleName, "android_common")
1910 manifest := m.Output("metalava.sbox.textproto")
1911 sboxProto := android.RuleBuilderSboxProtoForTests(t, manifest)
1912 manifestCommand := sboxProto.Commands[0].GetCommand()
1913 sourceFilesFlag := "--source-files " + strings.Join(c.sourceTextFileDirs, " ")
1914 android.AssertStringDoesContain(t, "source text files not present", manifestCommand, sourceFilesFlag)
1915 }
1916}
1917
Jihoon Kang1c51f502023-01-09 23:42:40 +00001918func TestJavaApiLibraryAndDefaultsLink(t *testing.T) {
Jihoon Kang362aa9d2023-01-20 19:44:07 +00001919 provider_bp_a := `
1920 java_api_contribution {
Jihoon Kang1c51f502023-01-09 23:42:40 +00001921 name: "foo1",
Jihoon Kang84473f52023-08-11 22:36:33 +00001922 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00001923 api_surface: "public",
Jihoon Kang1c51f502023-01-09 23:42:40 +00001924 }
1925 `
Jihoon Kang362aa9d2023-01-20 19:44:07 +00001926 provider_bp_b := `
1927 java_api_contribution {
Jihoon Kang1c51f502023-01-09 23:42:40 +00001928 name: "foo2",
Jihoon Kang84473f52023-08-11 22:36:33 +00001929 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00001930 api_surface: "public",
Jihoon Kang1c51f502023-01-09 23:42:40 +00001931 }
1932 `
Jihoon Kang362aa9d2023-01-20 19:44:07 +00001933 provider_bp_c := `
1934 java_api_contribution {
Jihoon Kang1c51f502023-01-09 23:42:40 +00001935 name: "foo3",
Jihoon Kang8fe19822023-09-14 06:27:36 +00001936 api_file: "system-current.txt",
1937 api_surface: "system",
Jihoon Kang1c51f502023-01-09 23:42:40 +00001938 }
1939 `
Jihoon Kang362aa9d2023-01-20 19:44:07 +00001940 provider_bp_d := `
1941 java_api_contribution {
Jihoon Kang1c51f502023-01-09 23:42:40 +00001942 name: "foo4",
Jihoon Kang8fe19822023-09-14 06:27:36 +00001943 api_file: "system-current.txt",
1944 api_surface: "system",
Jihoon Kang1c51f502023-01-09 23:42:40 +00001945 }
1946 `
1947 ctx, _ := testJavaWithFS(t, `
1948 java_defaults {
1949 name: "baz1",
1950 api_surface: "public",
1951 api_contributions: ["foo1", "foo2"],
1952 }
1953
1954 java_defaults {
1955 name: "baz2",
1956 api_surface: "system",
1957 api_contributions: ["foo3"],
1958 }
1959
1960 java_api_library {
1961 name: "bar1",
1962 api_surface: "public",
1963 api_contributions: ["foo1"],
1964 }
1965
1966 java_api_library {
1967 name: "bar2",
1968 api_surface: "public",
1969 defaults:["baz1"],
1970 }
1971
1972 java_api_library {
1973 name: "bar3",
1974 api_surface: "system",
1975 defaults:["baz1", "baz2"],
1976 api_contributions: ["foo4"],
Jihoon Kang1c51f502023-01-09 23:42:40 +00001977 }
1978 `,
1979 map[string][]byte{
1980 "a/Android.bp": []byte(provider_bp_a),
1981 "b/Android.bp": []byte(provider_bp_b),
1982 "c/Android.bp": []byte(provider_bp_c),
1983 "d/Android.bp": []byte(provider_bp_d),
1984 })
1985
1986 testcases := []struct {
1987 moduleName string
1988 sourceTextFileDirs []string
1989 }{
1990 {
1991 moduleName: "bar1",
Jihoon Kang84473f52023-08-11 22:36:33 +00001992 sourceTextFileDirs: []string{"a/current.txt"},
Jihoon Kang1c51f502023-01-09 23:42:40 +00001993 },
1994 {
1995 moduleName: "bar2",
Jihoon Kang84473f52023-08-11 22:36:33 +00001996 sourceTextFileDirs: []string{"a/current.txt", "b/current.txt"},
Jihoon Kang1c51f502023-01-09 23:42:40 +00001997 },
1998 {
Jihoon Kang8fe19822023-09-14 06:27:36 +00001999 moduleName: "bar3",
2000 // API text files need to be sorted from the narrower api scope to the wider api scope
Jihoon Kang6be0f002023-09-20 23:03:01 +00002001 sourceTextFileDirs: []string{"a/current.txt", "b/current.txt", "c/system-current.txt", "d/system-current.txt"},
Jihoon Kang1c51f502023-01-09 23:42:40 +00002002 },
2003 }
2004 for _, c := range testcases {
2005 m := ctx.ModuleForTests(c.moduleName, "android_common")
2006 manifest := m.Output("metalava.sbox.textproto")
2007 sboxProto := android.RuleBuilderSboxProtoForTests(t, manifest)
2008 manifestCommand := sboxProto.Commands[0].GetCommand()
2009 sourceFilesFlag := "--source-files " + strings.Join(c.sourceTextFileDirs, " ")
2010 android.AssertStringDoesContain(t, "source text files not present", manifestCommand, sourceFilesFlag)
2011 }
2012}
2013
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002014func TestJavaApiLibraryJarGeneration(t *testing.T) {
2015 provider_bp_a := `
2016 java_api_contribution {
2017 name: "foo1",
Jihoon Kang84473f52023-08-11 22:36:33 +00002018 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002019 api_surface: "public",
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002020 }
2021 `
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002022 provider_bp_b := `
2023 java_api_contribution {
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002024 name: "foo2",
Jihoon Kang84473f52023-08-11 22:36:33 +00002025 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002026 api_surface: "public",
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002027 }
2028 `
2029 ctx, _ := testJavaWithFS(t, `
2030 java_api_library {
2031 name: "bar1",
2032 api_surface: "public",
Jihoon Kang60d4a092022-11-17 23:47:43 +00002033 api_contributions: ["foo1"],
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002034 }
2035
2036 java_api_library {
2037 name: "bar2",
2038 api_surface: "system",
Jihoon Kang60d4a092022-11-17 23:47:43 +00002039 api_contributions: ["foo1", "foo2"],
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002040 }
2041 `,
2042 map[string][]byte{
2043 "a/Android.bp": []byte(provider_bp_a),
2044 "b/Android.bp": []byte(provider_bp_b),
2045 })
2046
2047 testcases := []struct {
2048 moduleName string
2049 outputJarName string
2050 }{
2051 {
2052 moduleName: "bar1",
Jihoon Kang25857f52023-03-01 00:27:32 +00002053 outputJarName: "bar1/bar1.jar",
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002054 },
2055 {
2056 moduleName: "bar2",
Jihoon Kang25857f52023-03-01 00:27:32 +00002057 outputJarName: "bar2/bar2.jar",
Jihoon Kang0ac87c22022-11-15 19:06:14 +00002058 },
2059 }
2060 for _, c := range testcases {
2061 m := ctx.ModuleForTests(c.moduleName, "android_common")
2062 outputs := fmt.Sprint(m.AllOutputs())
2063 if !strings.Contains(outputs, c.outputJarName) {
2064 t.Errorf("Module output does not contain expected jar %s", c.outputJarName)
2065 }
2066 }
2067}
Cole Faust21680542022-12-07 18:18:37 -08002068
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002069func TestJavaApiLibraryLibsLink(t *testing.T) {
2070 provider_bp_a := `
2071 java_api_contribution {
2072 name: "foo1",
Jihoon Kang84473f52023-08-11 22:36:33 +00002073 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002074 api_surface: "public",
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002075 }
2076 `
2077 provider_bp_b := `
2078 java_api_contribution {
2079 name: "foo2",
Jihoon Kang84473f52023-08-11 22:36:33 +00002080 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002081 api_surface: "public",
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002082 }
2083 `
2084 lib_bp_a := `
2085 java_library {
2086 name: "lib1",
2087 srcs: ["Lib.java"],
2088 }
2089 `
2090 lib_bp_b := `
2091 java_library {
2092 name: "lib2",
2093 srcs: ["Lib.java"],
2094 }
2095 `
2096
2097 ctx, _ := testJavaWithFS(t, `
2098 java_api_library {
2099 name: "bar1",
2100 api_surface: "public",
2101 api_contributions: ["foo1"],
2102 libs: ["lib1"],
2103 }
2104
2105 java_api_library {
2106 name: "bar2",
2107 api_surface: "system",
2108 api_contributions: ["foo1", "foo2"],
2109 libs: ["lib1", "lib2", "bar1"],
2110 }
2111 `,
2112 map[string][]byte{
2113 "a/Android.bp": []byte(provider_bp_a),
2114 "b/Android.bp": []byte(provider_bp_b),
2115 "c/Android.bp": []byte(lib_bp_a),
2116 "c/Lib.java": {},
2117 "d/Android.bp": []byte(lib_bp_b),
2118 "d/Lib.java": {},
2119 })
2120
2121 testcases := []struct {
2122 moduleName string
2123 classPathJarNames []string
2124 }{
2125 {
2126 moduleName: "bar1",
2127 classPathJarNames: []string{"lib1.jar"},
2128 },
2129 {
2130 moduleName: "bar2",
Jihoon Kang25857f52023-03-01 00:27:32 +00002131 classPathJarNames: []string{"lib1.jar", "lib2.jar", "bar1/bar1.jar"},
Jihoon Kang362aa9d2023-01-20 19:44:07 +00002132 },
2133 }
2134 for _, c := range testcases {
2135 m := ctx.ModuleForTests(c.moduleName, "android_common")
2136 javacRules := m.Rule("javac")
2137 classPathArgs := javacRules.Args["classpath"]
2138 for _, jarName := range c.classPathJarNames {
2139 if !strings.Contains(classPathArgs, jarName) {
2140 t.Errorf("Module output does not contain expected jar %s", jarName)
2141 }
2142 }
2143 }
2144}
2145
Jihoon Kange30fff02023-02-14 20:18:20 +00002146func TestJavaApiLibraryStaticLibsLink(t *testing.T) {
2147 provider_bp_a := `
2148 java_api_contribution {
2149 name: "foo1",
Jihoon Kang84473f52023-08-11 22:36:33 +00002150 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002151 api_surface: "public",
Jihoon Kange30fff02023-02-14 20:18:20 +00002152 }
2153 `
2154 provider_bp_b := `
2155 java_api_contribution {
2156 name: "foo2",
Jihoon Kang84473f52023-08-11 22:36:33 +00002157 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002158 api_surface: "public",
Jihoon Kange30fff02023-02-14 20:18:20 +00002159 }
2160 `
2161 lib_bp_a := `
2162 java_library {
2163 name: "lib1",
2164 srcs: ["Lib.java"],
2165 }
2166 `
2167 lib_bp_b := `
2168 java_library {
2169 name: "lib2",
2170 srcs: ["Lib.java"],
2171 }
2172 `
2173
2174 ctx, _ := testJavaWithFS(t, `
2175 java_api_library {
2176 name: "bar1",
2177 api_surface: "public",
2178 api_contributions: ["foo1"],
2179 static_libs: ["lib1"],
2180 }
2181
2182 java_api_library {
2183 name: "bar2",
2184 api_surface: "system",
2185 api_contributions: ["foo1", "foo2"],
2186 static_libs: ["lib1", "lib2", "bar1"],
2187 }
2188 `,
2189 map[string][]byte{
2190 "a/Android.bp": []byte(provider_bp_a),
2191 "b/Android.bp": []byte(provider_bp_b),
2192 "c/Android.bp": []byte(lib_bp_a),
2193 "c/Lib.java": {},
2194 "d/Android.bp": []byte(lib_bp_b),
2195 "d/Lib.java": {},
2196 })
2197
2198 testcases := []struct {
2199 moduleName string
2200 staticLibJarNames []string
2201 }{
2202 {
2203 moduleName: "bar1",
2204 staticLibJarNames: []string{"lib1.jar"},
2205 },
2206 {
2207 moduleName: "bar2",
Jihoon Kang25857f52023-03-01 00:27:32 +00002208 staticLibJarNames: []string{"lib1.jar", "lib2.jar", "bar1/bar1.jar"},
Jihoon Kange30fff02023-02-14 20:18:20 +00002209 },
2210 }
2211 for _, c := range testcases {
2212 m := ctx.ModuleForTests(c.moduleName, "android_common")
2213 mergeZipsCommand := m.Rule("merge_zips").RuleParams.Command
2214 for _, jarName := range c.staticLibJarNames {
2215 if !strings.Contains(mergeZipsCommand, jarName) {
2216 t.Errorf("merge_zips command does not contain expected jar %s", jarName)
2217 }
2218 }
2219 }
2220}
2221
Jihoon Kangca198c22023-06-22 23:13:51 +00002222func TestJavaApiLibraryFullApiSurfaceStub(t *testing.T) {
Jihoon Kang01e522c2023-03-14 01:09:34 +00002223 provider_bp_a := `
2224 java_api_contribution {
2225 name: "foo1",
Jihoon Kang84473f52023-08-11 22:36:33 +00002226 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002227 api_surface: "public",
Jihoon Kang01e522c2023-03-14 01:09:34 +00002228 }
2229 `
2230 provider_bp_b := `
2231 java_api_contribution {
2232 name: "foo2",
Jihoon Kang84473f52023-08-11 22:36:33 +00002233 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002234 api_surface: "public",
Jihoon Kang01e522c2023-03-14 01:09:34 +00002235 }
2236 `
2237 lib_bp_a := `
2238 java_api_library {
2239 name: "lib1",
2240 api_surface: "public",
2241 api_contributions: ["foo1", "foo2"],
2242 }
2243 `
2244
2245 ctx, _ := testJavaWithFS(t, `
2246 java_api_library {
2247 name: "bar1",
2248 api_surface: "public",
2249 api_contributions: ["foo1"],
Jihoon Kangca198c22023-06-22 23:13:51 +00002250 full_api_surface_stub: "lib1",
Jihoon Kang01e522c2023-03-14 01:09:34 +00002251 }
2252 `,
2253 map[string][]byte{
2254 "a/Android.bp": []byte(provider_bp_a),
2255 "b/Android.bp": []byte(provider_bp_b),
2256 "c/Android.bp": []byte(lib_bp_a),
2257 })
2258
2259 m := ctx.ModuleForTests("bar1", "android_common")
2260 manifest := m.Output("metalava.sbox.textproto")
2261 sboxProto := android.RuleBuilderSboxProtoForTests(t, manifest)
2262 manifestCommand := sboxProto.Commands[0].GetCommand()
Jihoon Kangca198c22023-06-22 23:13:51 +00002263 android.AssertStringDoesContain(t, "Command expected to contain full_api_surface_stub output jar", manifestCommand, "lib1.jar")
Jihoon Kang01e522c2023-03-14 01:09:34 +00002264}
2265
Anton Hansson0e73f9e2023-09-20 13:39:57 +00002266func TestTransitiveSrcFiles(t *testing.T) {
2267 ctx, _ := testJava(t, `
2268 java_library {
2269 name: "a",
2270 srcs: ["a.java"],
2271 }
2272 java_library {
2273 name: "b",
2274 srcs: ["b.java"],
2275 }
2276 java_library {
2277 name: "c",
2278 srcs: ["c.java"],
2279 libs: ["a"],
2280 static_libs: ["b"],
2281 }
2282 `)
2283 c := ctx.ModuleForTests("c", "android_common").Module()
2284 transitiveSrcFiles := android.Paths(ctx.ModuleProvider(c, JavaInfoProvider).(JavaInfo).TransitiveSrcFiles.ToList())
2285 android.AssertArrayString(t, "unexpected jar deps", []string{"b.java", "c.java"}, transitiveSrcFiles.Strings())
2286}
2287
Cole Faust21680542022-12-07 18:18:37 -08002288func TestTradefedOptions(t *testing.T) {
2289 result := PrepareForTestWithJavaBuildComponents.RunTestWithBp(t, `
2290java_test_host {
2291 name: "foo",
2292 test_options: {
2293 tradefed_options: [
2294 {
2295 name: "exclude-path",
2296 value: "org/apache"
2297 }
2298 ]
2299 }
2300}
2301`)
2302
2303 buildOS := result.Config.BuildOS.String()
2304 args := result.ModuleForTests("foo", buildOS+"_common").
2305 Output("out/soong/.intermediates/foo/" + buildOS + "_common/foo.config").Args
2306 expected := proptools.NinjaAndShellEscape("<option name=\"exclude-path\" value=\"org/apache\" />")
2307 if args["extraConfigs"] != expected {
2308 t.Errorf("Expected args[\"extraConfigs\"] to equal %q, was %q", expected, args["extraConfigs"])
2309 }
2310}
Dan Shiec731432023-05-26 04:21:44 +00002311
2312func TestTestRunnerOptions(t *testing.T) {
2313 result := PrepareForTestWithJavaBuildComponents.RunTestWithBp(t, `
2314java_test_host {
2315 name: "foo",
2316 test_options: {
2317 test_runner_options: [
2318 {
2319 name: "test-timeout",
2320 value: "10m"
2321 }
2322 ]
2323 }
2324}
2325`)
2326
2327 buildOS := result.Config.BuildOS.String()
2328 args := result.ModuleForTests("foo", buildOS+"_common").
2329 Output("out/soong/.intermediates/foo/" + buildOS + "_common/foo.config").Args
2330 expected := proptools.NinjaAndShellEscape("<option name=\"test-timeout\" value=\"10m\" />\\n ")
2331 if args["extraTestRunnerConfigs"] != expected {
2332 t.Errorf("Expected args[\"extraTestRunnerConfigs\"] to equal %q, was %q", expected, args["extraTestRunnerConfigs"])
2333 }
2334}
Jihoon Kang381c2fa2023-06-01 22:17:32 +00002335
2336func TestJavaExcludeStaticLib(t *testing.T) {
2337 ctx, _ := testJava(t, `
2338 java_library {
2339 name: "bar",
2340 }
2341 java_library {
2342 name: "foo",
2343 }
2344 java_library {
2345 name: "baz",
2346 static_libs: [
2347 "foo",
2348 "bar",
2349 ],
2350 exclude_static_libs: [
2351 "bar",
2352 ],
2353 }
2354 `)
2355
2356 // "bar" not included as dependency of "baz"
2357 CheckModuleDependencies(t, ctx, "baz", "android_common", []string{
2358 `core-lambda-stubs`,
2359 `ext`,
2360 `foo`,
2361 `framework`,
2362 `stable-core-platform-api-stubs-system-modules`,
2363 `stable.core.platform.api.stubs`,
2364 })
2365}
Jihoon Kang1bfb6f22023-07-01 00:13:47 +00002366
2367func TestJavaLibraryWithResourcesStem(t *testing.T) {
2368 ctx, _ := testJavaWithFS(t, `
2369 java_library {
2370 name: "foo",
2371 java_resource_dirs: ["test-jar"],
2372 stem: "test",
2373 }
2374 `,
2375 map[string][]byte{
2376 "test-jar/test/resource.txt": nil,
2377 })
2378
2379 m := ctx.ModuleForTests("foo", "android_common")
2380 outputs := fmt.Sprint(m.AllOutputs())
2381 if !strings.Contains(outputs, "test.jar") {
2382 t.Errorf("Module output does not contain expected jar %s", "test.jar")
2383 }
2384}
Mark Whitea15790a2023-08-22 21:28:11 +00002385
2386func TestHeadersOnly(t *testing.T) {
2387 ctx, _ := testJava(t, `
2388 java_library {
2389 name: "foo",
2390 srcs: ["a.java"],
2391 headers_only: true,
2392 }
2393 `)
2394
2395 turbine := ctx.ModuleForTests("foo", "android_common").Rule("turbine")
2396 if len(turbine.Inputs) != 1 || turbine.Inputs[0].String() != "a.java" {
2397 t.Errorf(`foo inputs %v != ["a.java"]`, turbine.Inputs)
2398 }
2399
2400 javac := ctx.ModuleForTests("foo", "android_common").MaybeRule("javac")
2401 android.AssertDeepEquals(t, "javac rule", nil, javac.Rule)
2402}
Jihoon Kangfdf32362023-09-12 00:36:43 +00002403
2404func TestJavaApiContributionImport(t *testing.T) {
2405 ctx, _ := testJava(t, `
2406 java_api_library {
2407 name: "foo",
2408 api_contributions: ["bar"],
2409 }
2410 java_api_contribution_import {
2411 name: "bar",
2412 api_file: "current.txt",
Jihoon Kang8fe19822023-09-14 06:27:36 +00002413 api_surface: "public",
Jihoon Kangfdf32362023-09-12 00:36:43 +00002414 }
2415 `)
2416 m := ctx.ModuleForTests("foo", "android_common")
2417 manifest := m.Output("metalava.sbox.textproto")
2418 sboxProto := android.RuleBuilderSboxProtoForTests(t, manifest)
2419 manifestCommand := sboxProto.Commands[0].GetCommand()
2420 sourceFilesFlag := "--source-files current.txt"
2421 android.AssertStringDoesContain(t, "source text files not present", manifestCommand, sourceFilesFlag)
2422}
Jihoon Kanga96a7b12023-09-20 23:43:32 +00002423
2424func TestJavaApiLibraryApiFilesSorting(t *testing.T) {
2425 ctx, _ := testJava(t, `
2426 java_api_library {
2427 name: "foo",
2428 api_contributions: [
2429 "system-server-api-stubs-docs-non-updatable.api.contribution",
2430 "test-api-stubs-docs-non-updatable.api.contribution",
2431 "system-api-stubs-docs-non-updatable.api.contribution",
2432 "module-lib-api-stubs-docs-non-updatable.api.contribution",
2433 "api-stubs-docs-non-updatable.api.contribution",
2434 ],
2435 }
2436 `)
2437 m := ctx.ModuleForTests("foo", "android_common")
2438 manifest := m.Output("metalava.sbox.textproto")
2439 sboxProto := android.RuleBuilderSboxProtoForTests(t, manifest)
2440 manifestCommand := sboxProto.Commands[0].GetCommand()
2441
2442 // Api files are sorted from the narrowest api scope to the widest api scope.
2443 // test api and module lib api surface do not have subset/superset relationship,
2444 // but they will never be passed as inputs at the same time.
2445 sourceFilesFlag := "--source-files default/java/api/current.txt " +
2446 "default/java/api/system-current.txt default/java/api/test-current.txt " +
2447 "default/java/api/module-lib-current.txt default/java/api/system-server-current.txt"
2448 android.AssertStringDoesContain(t, "source text files not in api scope order", manifestCommand, sourceFilesFlag)
2449}
Jihoon Kang4ec24872023-10-05 17:26:09 +00002450
2451func TestSdkLibraryProvidesSystemModulesToApiLibrary(t *testing.T) {
2452 result := android.GroupFixturePreparers(
2453 prepareForJavaTest,
2454 PrepareForTestWithJavaSdkLibraryFiles,
2455 FixtureWithLastReleaseApis("foo"),
2456 android.FixtureModifyConfig(func(config android.Config) {
2457 config.SetApiLibraries([]string{"foo"})
2458 }),
2459 android.FixtureMergeMockFs(
2460 map[string][]byte{
2461 "A.java": nil,
2462 },
2463 ),
2464 ).RunTestWithBp(t, `
2465 java_library {
2466 name: "bar",
2467 srcs: ["a.java"],
2468 }
2469 java_system_modules {
2470 name: "baz",
2471 libs: ["bar"],
2472 }
2473 java_sdk_library {
2474 name: "foo",
2475 srcs: ["A.java"],
2476 system_modules: "baz",
2477 }
2478 `)
2479 m := result.ModuleForTests(apiScopePublic.apiLibraryModuleName("foo"), "android_common")
2480 manifest := m.Output("metalava.sbox.textproto")
2481 sboxProto := android.RuleBuilderSboxProtoForTests(t, manifest)
2482 manifestCommand := sboxProto.Commands[0].GetCommand()
2483 classPathFlag := "--classpath __SBOX_SANDBOX_DIR__/out/.intermediates/bar/android_common/turbine-combined/bar.jar"
2484 android.AssertStringDoesContain(t, "command expected to contain classpath flag", manifestCommand, classPathFlag)
2485}