Mårten Kongstad | f242ec8 | 2024-04-16 17:12:26 +0200 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2024 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | package com.android.checkflaggedapis |
| 17 | |
Mårten Kongstad | 387ff6c | 2024-04-16 12:42:14 +0200 | [diff] [blame] | 18 | import android.aconfig.Aconfig |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 19 | import android.aconfig.Aconfig.flag_state.DISABLED |
| 20 | import android.aconfig.Aconfig.flag_state.ENABLED |
Mårten Kongstad | 387ff6c | 2024-04-16 12:42:14 +0200 | [diff] [blame] | 21 | import java.io.ByteArrayInputStream |
| 22 | import java.io.ByteArrayOutputStream |
Mårten Kongstad | 9238a3a | 2024-04-16 13:19:50 +0200 | [diff] [blame] | 23 | import java.io.InputStream |
Mårten Kongstad | 20de405 | 2024-04-16 11:33:56 +0200 | [diff] [blame] | 24 | import org.junit.Assert.assertEquals |
Mårten Kongstad | f242ec8 | 2024-04-16 17:12:26 +0200 | [diff] [blame] | 25 | import org.junit.Test |
| 26 | import org.junit.runner.RunWith |
Mårten Kongstad | 7cc2174 | 2024-04-18 10:23:20 +0200 | [diff] [blame] | 27 | import org.junit.runners.JUnit4 |
Mårten Kongstad | f242ec8 | 2024-04-16 17:12:26 +0200 | [diff] [blame] | 28 | |
Mårten Kongstad | 20de405 | 2024-04-16 11:33:56 +0200 | [diff] [blame] | 29 | private val API_SIGNATURE = |
| 30 | """ |
| 31 | // Signature format: 2.0 |
| 32 | package android { |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 33 | @FlaggedApi("android.flag.foo") public final class Clazz { |
Mårten Kongstad | 40da970 | 2024-04-27 01:42:51 +0200 | [diff] [blame] | 34 | ctor @FlaggedApi("android.flag.foo") public Clazz(); |
Mårten Kongstad | 20de405 | 2024-04-16 11:33:56 +0200 | [diff] [blame] | 35 | field @FlaggedApi("android.flag.foo") public static final int FOO = 1; // 0x1 |
Mårten Kongstad | 40da970 | 2024-04-27 01:42:51 +0200 | [diff] [blame] | 36 | method @FlaggedApi("android.flag.foo") public int getErrorCode(); |
Mårten Kongstad | b4a14bf | 2024-04-28 00:21:11 +0200 | [diff] [blame] | 37 | method @FlaggedApi("android.flag.foo") public boolean setData(int, int[][], @NonNull android.util.Utility<T, U>); |
| 38 | method @FlaggedApi("android.flag.foo") public boolean setVariableData(int, android.util.Atom...); |
| 39 | method @FlaggedApi("android.flag.foo") public boolean innerClassArg(android.Clazz.Builder); |
Mårten Kongstad | 20de405 | 2024-04-16 11:33:56 +0200 | [diff] [blame] | 40 | } |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 41 | @FlaggedApi("android.flag.bar") public static class Clazz.Builder { |
| 42 | } |
Mårten Kongstad | 20de405 | 2024-04-16 11:33:56 +0200 | [diff] [blame] | 43 | } |
| 44 | """ |
| 45 | .trim() |
| 46 | |
Mårten Kongstad | b673d3b | 2024-04-16 18:34:20 +0200 | [diff] [blame] | 47 | private val API_VERSIONS = |
| 48 | """ |
| 49 | <?xml version="1.0" encoding="utf-8"?> |
| 50 | <api version="3"> |
| 51 | <class name="android/Clazz" since="1"> |
Mårten Kongstad | c3f05a6 | 2024-05-06 21:42:15 +0200 | [diff] [blame] | 52 | <extends name="java/lang/Object"/> |
Mårten Kongstad | b673d3b | 2024-04-16 18:34:20 +0200 | [diff] [blame] | 53 | <method name="<init>()V"/> |
| 54 | <field name="FOO"/> |
Mårten Kongstad | 40da970 | 2024-04-27 01:42:51 +0200 | [diff] [blame] | 55 | <method name="getErrorCode()I"/> |
Mårten Kongstad | b4a14bf | 2024-04-28 00:21:11 +0200 | [diff] [blame] | 56 | <method name="setData(I[[ILandroid/util/Utility;)Z"/> |
| 57 | <method name="setVariableData(I[Landroid/util/Atom;)Z"/> |
| 58 | <method name="innerClassArg(Landroid/Clazz${"$"}Builder;)"/> |
Mårten Kongstad | b673d3b | 2024-04-16 18:34:20 +0200 | [diff] [blame] | 59 | </class> |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 60 | <class name="android/Clazz${"$"}Builder" since="2"> |
Mårten Kongstad | c3f05a6 | 2024-05-06 21:42:15 +0200 | [diff] [blame] | 61 | <extends name="java/lang/Object"/> |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 62 | </class> |
Mårten Kongstad | b673d3b | 2024-04-16 18:34:20 +0200 | [diff] [blame] | 63 | </api> |
| 64 | """ |
| 65 | .trim() |
| 66 | |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 67 | private fun generateFlagsProto( |
| 68 | fooState: Aconfig.flag_state, |
| 69 | barState: Aconfig.flag_state |
| 70 | ): InputStream { |
| 71 | val fooFlag = |
Mårten Kongstad | 9238a3a | 2024-04-16 13:19:50 +0200 | [diff] [blame] | 72 | Aconfig.parsed_flag |
| 73 | .newBuilder() |
| 74 | .setPackage("android.flag") |
| 75 | .setName("foo") |
| 76 | .setState(fooState) |
| 77 | .setPermission(Aconfig.flag_permission.READ_ONLY) |
| 78 | .build() |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 79 | val barFlag = |
| 80 | Aconfig.parsed_flag |
| 81 | .newBuilder() |
| 82 | .setPackage("android.flag") |
| 83 | .setName("bar") |
| 84 | .setState(barState) |
| 85 | .setPermission(Aconfig.flag_permission.READ_ONLY) |
| 86 | .build() |
| 87 | val flags = |
| 88 | Aconfig.parsed_flags.newBuilder().addParsedFlag(fooFlag).addParsedFlag(barFlag).build() |
Mårten Kongstad | 9238a3a | 2024-04-16 13:19:50 +0200 | [diff] [blame] | 89 | val binaryProto = ByteArrayOutputStream() |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 90 | flags.writeTo(binaryProto) |
Mårten Kongstad | 9238a3a | 2024-04-16 13:19:50 +0200 | [diff] [blame] | 91 | return ByteArrayInputStream(binaryProto.toByteArray()) |
| 92 | } |
| 93 | |
Mårten Kongstad | 7cc2174 | 2024-04-18 10:23:20 +0200 | [diff] [blame] | 94 | @RunWith(JUnit4::class) |
| 95 | class CheckFlaggedApisTest { |
Mårten Kongstad | 20de405 | 2024-04-16 11:33:56 +0200 | [diff] [blame] | 96 | @Test |
| 97 | fun testParseApiSignature() { |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 98 | val expected = |
| 99 | setOf( |
Mårten Kongstad | c3f05a6 | 2024-05-06 21:42:15 +0200 | [diff] [blame] | 100 | Pair( |
| 101 | Symbol.createClass("android/Clazz", "java/lang/Object", setOf()), |
| 102 | Flag("android.flag.foo")), |
Mårten Kongstad | a1fe371 | 2024-05-06 13:46:21 +0200 | [diff] [blame] | 103 | Pair(Symbol.createMethod("android/Clazz", "Clazz()"), Flag("android.flag.foo")), |
| 104 | Pair(Symbol.createField("android/Clazz", "FOO"), Flag("android.flag.foo")), |
| 105 | Pair(Symbol.createMethod("android/Clazz", "getErrorCode()"), Flag("android.flag.foo")), |
Mårten Kongstad | b4a14bf | 2024-04-28 00:21:11 +0200 | [diff] [blame] | 106 | Pair( |
Mårten Kongstad | a1fe371 | 2024-05-06 13:46:21 +0200 | [diff] [blame] | 107 | Symbol.createMethod("android/Clazz", "setData(I[[ILandroid/util/Utility;)"), |
Mårten Kongstad | b4a14bf | 2024-04-28 00:21:11 +0200 | [diff] [blame] | 108 | Flag("android.flag.foo")), |
| 109 | Pair( |
Mårten Kongstad | a1fe371 | 2024-05-06 13:46:21 +0200 | [diff] [blame] | 110 | Symbol.createMethod("android/Clazz", "setVariableData(I[Landroid/util/Atom;)"), |
Mårten Kongstad | b4a14bf | 2024-04-28 00:21:11 +0200 | [diff] [blame] | 111 | Flag("android.flag.foo")), |
| 112 | Pair( |
Mårten Kongstad | a1fe371 | 2024-05-06 13:46:21 +0200 | [diff] [blame] | 113 | Symbol.createMethod("android/Clazz", "innerClassArg(Landroid/Clazz/Builder;)"), |
Mårten Kongstad | b4a14bf | 2024-04-28 00:21:11 +0200 | [diff] [blame] | 114 | Flag("android.flag.foo")), |
Mårten Kongstad | c3f05a6 | 2024-05-06 21:42:15 +0200 | [diff] [blame] | 115 | Pair( |
| 116 | Symbol.createClass("android/Clazz/Builder", "java/lang/Object", setOf()), |
| 117 | Flag("android.flag.bar")), |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 118 | ) |
Mårten Kongstad | 20de405 | 2024-04-16 11:33:56 +0200 | [diff] [blame] | 119 | val actual = parseApiSignature("in-memory", API_SIGNATURE.byteInputStream()) |
| 120 | assertEquals(expected, actual) |
| 121 | } |
Mårten Kongstad | 387ff6c | 2024-04-16 12:42:14 +0200 | [diff] [blame] | 122 | |
| 123 | @Test |
| 124 | fun testParseFlagValues() { |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 125 | val expected: Map<Flag, Boolean> = |
| 126 | mapOf(Flag("android.flag.foo") to true, Flag("android.flag.bar") to true) |
| 127 | val actual = parseFlagValues(generateFlagsProto(ENABLED, ENABLED)) |
Mårten Kongstad | 387ff6c | 2024-04-16 12:42:14 +0200 | [diff] [blame] | 128 | assertEquals(expected, actual) |
| 129 | } |
Mårten Kongstad | b673d3b | 2024-04-16 18:34:20 +0200 | [diff] [blame] | 130 | |
| 131 | @Test |
| 132 | fun testParseApiVersions() { |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 133 | val expected: Set<Symbol> = |
| 134 | setOf( |
Mårten Kongstad | c3f05a6 | 2024-05-06 21:42:15 +0200 | [diff] [blame] | 135 | Symbol.createClass("android/Clazz", "java/lang/Object", setOf()), |
Mårten Kongstad | a1fe371 | 2024-05-06 13:46:21 +0200 | [diff] [blame] | 136 | Symbol.createMethod("android/Clazz", "Clazz()"), |
| 137 | Symbol.createField("android/Clazz", "FOO"), |
| 138 | Symbol.createMethod("android/Clazz", "getErrorCode()"), |
| 139 | Symbol.createMethod("android/Clazz", "setData(I[[ILandroid/util/Utility;)"), |
| 140 | Symbol.createMethod("android/Clazz", "setVariableData(I[Landroid/util/Atom;)"), |
| 141 | Symbol.createMethod("android/Clazz", "innerClassArg(Landroid/Clazz/Builder;)"), |
Mårten Kongstad | c3f05a6 | 2024-05-06 21:42:15 +0200 | [diff] [blame] | 142 | Symbol.createClass("android/Clazz/Builder", "java/lang/Object", setOf()), |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 143 | ) |
Mårten Kongstad | b673d3b | 2024-04-16 18:34:20 +0200 | [diff] [blame] | 144 | val actual = parseApiVersions(API_VERSIONS.byteInputStream()) |
| 145 | assertEquals(expected, actual) |
| 146 | } |
Mårten Kongstad | 9238a3a | 2024-04-16 13:19:50 +0200 | [diff] [blame] | 147 | |
| 148 | @Test |
Mårten Kongstad | 02525a8 | 2024-05-06 10:28:02 +0200 | [diff] [blame] | 149 | fun testParseApiVersionsNestedClasses() { |
| 150 | val apiVersions = |
| 151 | """ |
| 152 | <?xml version="1.0" encoding="utf-8"?> |
| 153 | <api version="3"> |
| 154 | <class name="android/Clazz${'$'}Foo${'$'}Bar" since="1"> |
Mårten Kongstad | c3f05a6 | 2024-05-06 21:42:15 +0200 | [diff] [blame] | 155 | <extends name="java/lang/Object"/> |
Mårten Kongstad | 02525a8 | 2024-05-06 10:28:02 +0200 | [diff] [blame] | 156 | <method name="<init>()V"/> |
| 157 | </class> |
| 158 | </api> |
| 159 | """ |
| 160 | .trim() |
| 161 | val expected: Set<Symbol> = |
| 162 | setOf( |
Mårten Kongstad | c3f05a6 | 2024-05-06 21:42:15 +0200 | [diff] [blame] | 163 | Symbol.createClass("android/Clazz/Foo/Bar", "java/lang/Object", setOf()), |
Mårten Kongstad | a1fe371 | 2024-05-06 13:46:21 +0200 | [diff] [blame] | 164 | Symbol.createMethod("android/Clazz/Foo/Bar", "Bar()"), |
Mårten Kongstad | 02525a8 | 2024-05-06 10:28:02 +0200 | [diff] [blame] | 165 | ) |
| 166 | val actual = parseApiVersions(apiVersions.byteInputStream()) |
| 167 | assertEquals(expected, actual) |
| 168 | } |
| 169 | |
| 170 | @Test |
Mårten Kongstad | 9238a3a | 2024-04-16 13:19:50 +0200 | [diff] [blame] | 171 | fun testFindErrorsNoErrors() { |
| 172 | val expected = setOf<ApiError>() |
| 173 | val actual = |
| 174 | findErrors( |
| 175 | parseApiSignature("in-memory", API_SIGNATURE.byteInputStream()), |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 176 | parseFlagValues(generateFlagsProto(ENABLED, ENABLED)), |
Mårten Kongstad | 9238a3a | 2024-04-16 13:19:50 +0200 | [diff] [blame] | 177 | parseApiVersions(API_VERSIONS.byteInputStream())) |
| 178 | assertEquals(expected, actual) |
| 179 | } |
| 180 | |
| 181 | @Test |
Mårten Kongstad | d2c7076 | 2024-05-06 14:58:18 +0200 | [diff] [blame] | 182 | fun testFindErrorsVerifyImplements() { |
| 183 | val apiSignature = |
| 184 | """ |
| 185 | // Signature format: 2.0 |
| 186 | package android { |
| 187 | @FlaggedApi("android.flag.foo") public final class Clazz implements android.Interface { |
| 188 | method @FlaggedApi("android.flag.foo") public boolean foo(); |
| 189 | method @FlaggedApi("android.flag.foo") public boolean bar(); |
| 190 | } |
| 191 | public interface Interface { |
| 192 | method public boolean bar(); |
| 193 | } |
| 194 | } |
| 195 | """ |
| 196 | .trim() |
| 197 | |
| 198 | val apiVersions = |
| 199 | """ |
| 200 | <?xml version="1.0" encoding="utf-8"?> |
| 201 | <api version="3"> |
| 202 | <class name="android/Clazz" since="1"> |
Mårten Kongstad | c3f05a6 | 2024-05-06 21:42:15 +0200 | [diff] [blame] | 203 | <extends name="java/lang/Object"/> |
Mårten Kongstad | d2c7076 | 2024-05-06 14:58:18 +0200 | [diff] [blame] | 204 | <implements name="android/Interface"/> |
| 205 | <method name="foo()Z"/> |
| 206 | </class> |
| 207 | <class name="android/Interface" since="1"> |
| 208 | <method name="bar()Z"/> |
| 209 | </class> |
| 210 | </api> |
| 211 | """ |
| 212 | .trim() |
| 213 | |
| 214 | val expected = setOf<ApiError>() |
| 215 | val actual = |
| 216 | findErrors( |
| 217 | parseApiSignature("in-memory", apiSignature.byteInputStream()), |
| 218 | parseFlagValues(generateFlagsProto(ENABLED, ENABLED)), |
| 219 | parseApiVersions(apiVersions.byteInputStream())) |
| 220 | assertEquals(expected, actual) |
| 221 | } |
| 222 | |
| 223 | @Test |
Mårten Kongstad | e812039 | 2024-05-06 21:32:34 +0200 | [diff] [blame^] | 224 | fun testFindErrorsVerifySuperclass() { |
| 225 | val apiSignature = |
| 226 | """ |
| 227 | // Signature format: 2.0 |
| 228 | package android { |
| 229 | @FlaggedApi("android.flag.foo") public final class C extends android.B { |
| 230 | method @FlaggedApi("android.flag.foo") public boolean c(); |
| 231 | method @FlaggedApi("android.flag.foo") public boolean b(); |
| 232 | method @FlaggedApi("android.flag.foo") public boolean a(); |
| 233 | } |
| 234 | public final class B extends android.A { |
| 235 | method public boolean b(); |
| 236 | } |
| 237 | public final class A { |
| 238 | method public boolean a(); |
| 239 | } |
| 240 | } |
| 241 | """ |
| 242 | .trim() |
| 243 | |
| 244 | val apiVersions = |
| 245 | """ |
| 246 | <?xml version="1.0" encoding="utf-8"?> |
| 247 | <api version="3"> |
| 248 | <class name="android/C" since="1"> |
| 249 | <extends name="android/B"/> |
| 250 | <method name="c()Z"/> |
| 251 | </class> |
| 252 | <class name="android/B" since="1"> |
| 253 | <extends name="android/A"/> |
| 254 | <method name="b()Z"/> |
| 255 | </class> |
| 256 | <class name="android/A" since="1"> |
| 257 | <method name="a()Z"/> |
| 258 | </class> |
| 259 | </api> |
| 260 | """ |
| 261 | .trim() |
| 262 | |
| 263 | val expected = setOf<ApiError>() |
| 264 | val actual = |
| 265 | findErrors( |
| 266 | parseApiSignature("in-memory", apiSignature.byteInputStream()), |
| 267 | parseFlagValues(generateFlagsProto(ENABLED, ENABLED)), |
| 268 | parseApiVersions(apiVersions.byteInputStream())) |
| 269 | assertEquals(expected, actual) |
| 270 | } |
| 271 | |
| 272 | @Test |
Mårten Kongstad | 9238a3a | 2024-04-16 13:19:50 +0200 | [diff] [blame] | 273 | fun testFindErrorsDisabledFlaggedApiIsPresent() { |
| 274 | val expected = |
| 275 | setOf<ApiError>( |
Mårten Kongstad | 40da970 | 2024-04-27 01:42:51 +0200 | [diff] [blame] | 276 | DisabledFlaggedApiIsPresentError( |
Mårten Kongstad | c3f05a6 | 2024-05-06 21:42:15 +0200 | [diff] [blame] | 277 | Symbol.createClass("android/Clazz", "java/lang/Object", setOf()), |
| 278 | Flag("android.flag.foo")), |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 279 | DisabledFlaggedApiIsPresentError( |
Mårten Kongstad | a1fe371 | 2024-05-06 13:46:21 +0200 | [diff] [blame] | 280 | Symbol.createMethod("android/Clazz", "Clazz()"), Flag("android.flag.foo")), |
Mårten Kongstad | 40da970 | 2024-04-27 01:42:51 +0200 | [diff] [blame] | 281 | DisabledFlaggedApiIsPresentError( |
Mårten Kongstad | a1fe371 | 2024-05-06 13:46:21 +0200 | [diff] [blame] | 282 | Symbol.createField("android/Clazz", "FOO"), Flag("android.flag.foo")), |
| 283 | DisabledFlaggedApiIsPresentError( |
| 284 | Symbol.createMethod("android/Clazz", "getErrorCode()"), Flag("android.flag.foo")), |
| 285 | DisabledFlaggedApiIsPresentError( |
| 286 | Symbol.createMethod("android/Clazz", "setData(I[[ILandroid/util/Utility;)"), |
Mårten Kongstad | b4a14bf | 2024-04-28 00:21:11 +0200 | [diff] [blame] | 287 | Flag("android.flag.foo")), |
| 288 | DisabledFlaggedApiIsPresentError( |
Mårten Kongstad | a1fe371 | 2024-05-06 13:46:21 +0200 | [diff] [blame] | 289 | Symbol.createMethod("android/Clazz", "setVariableData(I[Landroid/util/Atom;)"), |
Mårten Kongstad | b4a14bf | 2024-04-28 00:21:11 +0200 | [diff] [blame] | 290 | Flag("android.flag.foo")), |
| 291 | DisabledFlaggedApiIsPresentError( |
Mårten Kongstad | a1fe371 | 2024-05-06 13:46:21 +0200 | [diff] [blame] | 292 | Symbol.createMethod("android/Clazz", "innerClassArg(Landroid/Clazz/Builder;)"), |
Mårten Kongstad | b4a14bf | 2024-04-28 00:21:11 +0200 | [diff] [blame] | 293 | Flag("android.flag.foo")), |
| 294 | DisabledFlaggedApiIsPresentError( |
Mårten Kongstad | c3f05a6 | 2024-05-06 21:42:15 +0200 | [diff] [blame] | 295 | Symbol.createClass("android/Clazz/Builder", "java/lang/Object", setOf()), |
| 296 | Flag("android.flag.bar")), |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 297 | ) |
Mårten Kongstad | 9238a3a | 2024-04-16 13:19:50 +0200 | [diff] [blame] | 298 | val actual = |
| 299 | findErrors( |
| 300 | parseApiSignature("in-memory", API_SIGNATURE.byteInputStream()), |
Mårten Kongstad | 18ff19a | 2024-04-26 05:48:57 +0200 | [diff] [blame] | 301 | parseFlagValues(generateFlagsProto(DISABLED, DISABLED)), |
Mårten Kongstad | 9238a3a | 2024-04-16 13:19:50 +0200 | [diff] [blame] | 302 | parseApiVersions(API_VERSIONS.byteInputStream())) |
| 303 | assertEquals(expected, actual) |
| 304 | } |
Mårten Kongstad | f242ec8 | 2024-04-16 17:12:26 +0200 | [diff] [blame] | 305 | } |