Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2023 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 17 | use anyhow::{bail, ensure, Context, Result}; |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 18 | use clap::ValueEnum; |
Mårten Kongstad | a102909 | 2023-05-08 11:51:59 +0200 | [diff] [blame] | 19 | use protobuf::Message; |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 20 | use std::io::Read; |
Mårten Kongstad | d42eeeb | 2023-05-12 10:01:00 +0200 | [diff] [blame] | 21 | use std::path::PathBuf; |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 22 | |
Dennis Shen | 1dc9ad4 | 2023-05-12 00:21:55 +0000 | [diff] [blame] | 23 | use crate::codegen_cpp::generate_cpp_code; |
Mårten Kongstad | d42eeeb | 2023-05-12 10:01:00 +0200 | [diff] [blame] | 24 | use crate::codegen_java::generate_java_code; |
Mårten Kongstad | f73b963 | 2023-05-24 15:43:47 +0200 | [diff] [blame] | 25 | use crate::codegen_rust::generate_rust_code; |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 26 | use crate::protos::{ |
| 27 | ProtoFlagPermission, ProtoFlagState, ProtoParsedFlag, ProtoParsedFlags, ProtoTracepoint, |
| 28 | }; |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 29 | |
| 30 | pub struct Input { |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 31 | pub source: String, |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 32 | pub reader: Box<dyn Read>, |
| 33 | } |
| 34 | |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 35 | impl Input { |
| 36 | fn try_parse_flags(&mut self) -> Result<ProtoParsedFlags> { |
| 37 | let mut buffer = Vec::new(); |
Mårten Kongstad | cd414d4c | 2023-07-27 14:25:33 +0200 | [diff] [blame] | 38 | self.reader |
| 39 | .read_to_end(&mut buffer) |
| 40 | .with_context(|| format!("failed to read {}", self.source))?; |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 41 | crate::protos::parsed_flags::try_from_binary_proto(&buffer) |
Mårten Kongstad | cd414d4c | 2023-07-27 14:25:33 +0200 | [diff] [blame] | 42 | .with_context(|| self.error_context()) |
| 43 | } |
| 44 | |
| 45 | fn error_context(&self) -> String { |
| 46 | format!("failed to parse {}", self.source) |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 47 | } |
| 48 | } |
| 49 | |
Mårten Kongstad | d42eeeb | 2023-05-12 10:01:00 +0200 | [diff] [blame] | 50 | pub struct OutputFile { |
| 51 | pub path: PathBuf, // relative to some root directory only main knows about |
| 52 | pub contents: Vec<u8>, |
| 53 | } |
| 54 | |
Zhi Dou | 24a0b6a | 2023-08-10 21:39:59 +0000 | [diff] [blame] | 55 | pub const DEFAULT_FLAG_STATE: ProtoFlagState = ProtoFlagState::DISABLED; |
| 56 | pub const DEFAULT_FLAG_PERMISSION: ProtoFlagPermission = ProtoFlagPermission::READ_WRITE; |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 57 | |
Zhi Dou | 24a0b6a | 2023-08-10 21:39:59 +0000 | [diff] [blame] | 58 | pub fn parse_flags( |
| 59 | package: &str, |
Oriol Prieto Gasco | 7afc7e7 | 2023-11-22 13:26:02 +0000 | [diff] [blame^] | 60 | container: Option<&str>, |
Zhi Dou | 24a0b6a | 2023-08-10 21:39:59 +0000 | [diff] [blame] | 61 | declarations: Vec<Input>, |
| 62 | values: Vec<Input>, |
| 63 | default_permission: ProtoFlagPermission, |
| 64 | ) -> Result<Vec<u8>> { |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 65 | let mut parsed_flags = ProtoParsedFlags::new(); |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 66 | |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 67 | for mut input in declarations { |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 68 | let mut contents = String::new(); |
Mårten Kongstad | cd414d4c | 2023-07-27 14:25:33 +0200 | [diff] [blame] | 69 | input |
| 70 | .reader |
| 71 | .read_to_string(&mut contents) |
| 72 | .with_context(|| format!("failed to read {}", input.source))?; |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 73 | |
| 74 | let flag_declarations = crate::protos::flag_declarations::try_from_text_proto(&contents) |
Mårten Kongstad | cd414d4c | 2023-07-27 14:25:33 +0200 | [diff] [blame] | 75 | .with_context(|| input.error_context())?; |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame] | 76 | ensure!( |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 77 | package == flag_declarations.package(), |
Mårten Kongstad | cd414d4c | 2023-07-27 14:25:33 +0200 | [diff] [blame] | 78 | "failed to parse {}: expected package {}, got {}", |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame] | 79 | input.source, |
Mårten Kongstad | 9fb5896 | 2023-05-31 13:02:13 +0200 | [diff] [blame] | 80 | package, |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 81 | flag_declarations.package() |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame] | 82 | ); |
Oriol Prieto Gasco | 7afc7e7 | 2023-11-22 13:26:02 +0000 | [diff] [blame^] | 83 | if let Some(c) = container { |
| 84 | ensure!( |
| 85 | c == flag_declarations.container(), |
| 86 | "failed to parse {}: expected container {}, got {}", |
| 87 | input.source, |
| 88 | c, |
| 89 | flag_declarations.container() |
| 90 | ); |
| 91 | } |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 92 | for mut flag_declaration in flag_declarations.flag.into_iter() { |
| 93 | crate::protos::flag_declaration::verify_fields(&flag_declaration) |
Mårten Kongstad | cd414d4c | 2023-07-27 14:25:33 +0200 | [diff] [blame] | 94 | .with_context(|| input.error_context())?; |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 95 | |
| 96 | // create ParsedFlag using FlagDeclaration and default values |
| 97 | let mut parsed_flag = ProtoParsedFlag::new(); |
Oriol Prieto Gasco | 7afc7e7 | 2023-11-22 13:26:02 +0000 | [diff] [blame^] | 98 | if let Some(c) = container { |
| 99 | parsed_flag.set_container(c.to_string()); |
| 100 | } |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 101 | parsed_flag.set_package(package.to_string()); |
| 102 | parsed_flag.set_name(flag_declaration.take_name()); |
| 103 | parsed_flag.set_namespace(flag_declaration.take_namespace()); |
| 104 | parsed_flag.set_description(flag_declaration.take_description()); |
Mårten Kongstad | 1b8636b | 2023-06-22 10:12:24 +0200 | [diff] [blame] | 105 | parsed_flag.bug.append(&mut flag_declaration.bug); |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 106 | parsed_flag.set_state(DEFAULT_FLAG_STATE); |
Zhi Dou | 71f1b35 | 2023-08-21 22:49:46 +0000 | [diff] [blame] | 107 | let flag_permission = if flag_declaration.is_fixed_read_only() { |
| 108 | ProtoFlagPermission::READ_ONLY |
| 109 | } else { |
| 110 | default_permission |
| 111 | }; |
| 112 | parsed_flag.set_permission(flag_permission); |
| 113 | parsed_flag.set_is_fixed_read_only(flag_declaration.is_fixed_read_only()); |
Oriol Prieto Gasco | 0b9d289 | 2023-11-20 16:23:51 +0000 | [diff] [blame] | 114 | parsed_flag.set_is_exported(flag_declaration.is_exported()); |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 115 | let mut tracepoint = ProtoTracepoint::new(); |
| 116 | tracepoint.set_source(input.source.clone()); |
| 117 | tracepoint.set_state(DEFAULT_FLAG_STATE); |
Zhi Dou | 71f1b35 | 2023-08-21 22:49:46 +0000 | [diff] [blame] | 118 | tracepoint.set_permission(flag_permission); |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 119 | parsed_flag.trace.push(tracepoint); |
| 120 | |
| 121 | // verify ParsedFlag looks reasonable |
| 122 | crate::protos::parsed_flag::verify_fields(&parsed_flag)?; |
| 123 | |
| 124 | // verify ParsedFlag can be added |
| 125 | ensure!( |
| 126 | parsed_flags.parsed_flag.iter().all(|other| other.name() != parsed_flag.name()), |
| 127 | "failed to declare flag {} from {}: flag already declared", |
| 128 | parsed_flag.name(), |
| 129 | input.source |
| 130 | ); |
| 131 | |
| 132 | // add ParsedFlag to ParsedFlags |
| 133 | parsed_flags.parsed_flag.push(parsed_flag); |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 134 | } |
| 135 | } |
| 136 | |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 137 | for mut input in values { |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 138 | let mut contents = String::new(); |
Mårten Kongstad | cd414d4c | 2023-07-27 14:25:33 +0200 | [diff] [blame] | 139 | input |
| 140 | .reader |
| 141 | .read_to_string(&mut contents) |
| 142 | .with_context(|| format!("failed to read {}", input.source))?; |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 143 | let flag_values = crate::protos::flag_values::try_from_text_proto(&contents) |
Mårten Kongstad | cd414d4c | 2023-07-27 14:25:33 +0200 | [diff] [blame] | 144 | .with_context(|| input.error_context())?; |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 145 | for flag_value in flag_values.flag_value.into_iter() { |
| 146 | crate::protos::flag_value::verify_fields(&flag_value) |
Mårten Kongstad | cd414d4c | 2023-07-27 14:25:33 +0200 | [diff] [blame] | 147 | .with_context(|| input.error_context())?; |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 148 | |
Dennis Shen | 3cfbcf5 | 2023-07-17 14:57:23 +0000 | [diff] [blame] | 149 | let Some(parsed_flag) = parsed_flags |
| 150 | .parsed_flag |
| 151 | .iter_mut() |
| 152 | .find(|pf| pf.package() == flag_value.package() && pf.name() == flag_value.name()) |
| 153 | else { |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 154 | // (silently) skip unknown flags |
| 155 | continue; |
| 156 | }; |
| 157 | |
Zhi Dou | 71f1b35 | 2023-08-21 22:49:46 +0000 | [diff] [blame] | 158 | ensure!( |
| 159 | !parsed_flag.is_fixed_read_only() |
| 160 | || flag_value.permission() == ProtoFlagPermission::READ_ONLY, |
| 161 | "failed to set permission of flag {}, since this flag is fixed read only flag", |
| 162 | flag_value.name() |
| 163 | ); |
| 164 | |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 165 | parsed_flag.set_state(flag_value.state()); |
| 166 | parsed_flag.set_permission(flag_value.permission()); |
| 167 | let mut tracepoint = ProtoTracepoint::new(); |
| 168 | tracepoint.set_source(input.source.clone()); |
| 169 | tracepoint.set_state(flag_value.state()); |
| 170 | tracepoint.set_permission(flag_value.permission()); |
| 171 | parsed_flag.trace.push(tracepoint); |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 172 | } |
| 173 | } |
| 174 | |
Zhi Dou | 92cf0ec | 2023-07-19 19:29:22 +0000 | [diff] [blame] | 175 | // Create a sorted parsed_flags |
| 176 | crate::protos::parsed_flags::sort_parsed_flags(&mut parsed_flags); |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 177 | crate::protos::parsed_flags::verify_fields(&parsed_flags)?; |
Mårten Kongstad | f02734e | 2023-06-02 11:34:24 +0200 | [diff] [blame] | 178 | let mut output = Vec::new(); |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 179 | parsed_flags.write_to_vec(&mut output)?; |
| 180 | Ok(output) |
| 181 | } |
| 182 | |
Zhi Dou | 8ba6aa7 | 2023-06-26 21:03:40 +0000 | [diff] [blame] | 183 | #[derive(Copy, Clone, Debug, PartialEq, Eq, ValueEnum)] |
| 184 | pub enum CodegenMode { |
| 185 | Production, |
| 186 | Test, |
Ted Bauer | 4a6af78 | 2023-11-29 15:44:24 +0000 | [diff] [blame] | 187 | Exported, |
Zhi Dou | 8ba6aa7 | 2023-06-26 21:03:40 +0000 | [diff] [blame] | 188 | } |
| 189 | |
| 190 | pub fn create_java_lib(mut input: Input, codegen_mode: CodegenMode) -> Result<Vec<OutputFile>> { |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 191 | let parsed_flags = input.try_parse_flags()?; |
| 192 | let Some(package) = find_unique_package(&parsed_flags) else { |
| 193 | bail!("no parsed flags, or the parsed flags use different packages"); |
| 194 | }; |
Zhi Dou | 8ba6aa7 | 2023-06-26 21:03:40 +0000 | [diff] [blame] | 195 | generate_java_code(package, parsed_flags.parsed_flag.iter(), codegen_mode) |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 196 | } |
| 197 | |
Dennis Shen | 8d544f7 | 2023-06-29 00:45:42 +0000 | [diff] [blame] | 198 | pub fn create_cpp_lib(mut input: Input, codegen_mode: CodegenMode) -> Result<Vec<OutputFile>> { |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 199 | let parsed_flags = input.try_parse_flags()?; |
| 200 | let Some(package) = find_unique_package(&parsed_flags) else { |
| 201 | bail!("no parsed flags, or the parsed flags use different packages"); |
| 202 | }; |
Dennis Shen | 8d544f7 | 2023-06-29 00:45:42 +0000 | [diff] [blame] | 203 | generate_cpp_code(package, parsed_flags.parsed_flag.iter(), codegen_mode) |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 204 | } |
| 205 | |
Dennis Shen | 3cfbcf5 | 2023-07-17 14:57:23 +0000 | [diff] [blame] | 206 | pub fn create_rust_lib(mut input: Input, codegen_mode: CodegenMode) -> Result<OutputFile> { |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 207 | let parsed_flags = input.try_parse_flags()?; |
| 208 | let Some(package) = find_unique_package(&parsed_flags) else { |
| 209 | bail!("no parsed flags, or the parsed flags use different packages"); |
| 210 | }; |
Dennis Shen | 3cfbcf5 | 2023-07-17 14:57:23 +0000 | [diff] [blame] | 211 | generate_rust_code(package, parsed_flags.parsed_flag.iter(), codegen_mode) |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 212 | } |
| 213 | |
| 214 | pub fn create_device_config_defaults(mut input: Input) -> Result<Vec<u8>> { |
| 215 | let parsed_flags = input.try_parse_flags()?; |
| 216 | let mut output = Vec::new(); |
| 217 | for parsed_flag in parsed_flags |
| 218 | .parsed_flag |
| 219 | .into_iter() |
| 220 | .filter(|pf| pf.permission() == ProtoFlagPermission::READ_WRITE) |
Mårten Kongstad | f02734e | 2023-06-02 11:34:24 +0200 | [diff] [blame] | 221 | { |
| 222 | let line = format!( |
Mårten Kongstad | 202102f | 2023-06-08 11:22:44 +0200 | [diff] [blame] | 223 | "{}:{}.{}={}\n", |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 224 | parsed_flag.namespace(), |
| 225 | parsed_flag.package(), |
| 226 | parsed_flag.name(), |
| 227 | match parsed_flag.state() { |
| 228 | ProtoFlagState::ENABLED => "enabled", |
| 229 | ProtoFlagState::DISABLED => "disabled", |
Mårten Kongstad | f02734e | 2023-06-02 11:34:24 +0200 | [diff] [blame] | 230 | } |
| 231 | ); |
| 232 | output.extend_from_slice(line.as_bytes()); |
| 233 | } |
| 234 | Ok(output) |
| 235 | } |
| 236 | |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 237 | pub fn create_device_config_sysprops(mut input: Input) -> Result<Vec<u8>> { |
| 238 | let parsed_flags = input.try_parse_flags()?; |
Mårten Kongstad | c31a6ff | 2023-06-02 11:54:36 +0200 | [diff] [blame] | 239 | let mut output = Vec::new(); |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 240 | for parsed_flag in parsed_flags |
| 241 | .parsed_flag |
| 242 | .into_iter() |
| 243 | .filter(|pf| pf.permission() == ProtoFlagPermission::READ_WRITE) |
Mårten Kongstad | c31a6ff | 2023-06-02 11:54:36 +0200 | [diff] [blame] | 244 | { |
| 245 | let line = format!( |
| 246 | "persist.device_config.{}.{}={}\n", |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 247 | parsed_flag.package(), |
| 248 | parsed_flag.name(), |
| 249 | match parsed_flag.state() { |
| 250 | ProtoFlagState::ENABLED => "true", |
| 251 | ProtoFlagState::DISABLED => "false", |
Mårten Kongstad | c31a6ff | 2023-06-02 11:54:36 +0200 | [diff] [blame] | 252 | } |
| 253 | ); |
| 254 | output.extend_from_slice(line.as_bytes()); |
| 255 | } |
| 256 | Ok(output) |
| 257 | } |
| 258 | |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 259 | #[derive(Copy, Clone, Debug, PartialEq, Eq, ValueEnum)] |
Mårten Kongstad | ba94e6a | 2023-05-16 11:00:16 +0200 | [diff] [blame] | 260 | pub enum DumpFormat { |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 261 | Text, |
Mårten Kongstad | ea49814 | 2023-07-20 11:07:35 +0200 | [diff] [blame] | 262 | Verbose, |
Mårten Kongstad | a102909 | 2023-05-08 11:51:59 +0200 | [diff] [blame] | 263 | Protobuf, |
Mårten Kongstad | 3228b29 | 2023-06-26 10:17:42 +0200 | [diff] [blame] | 264 | Textproto, |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 265 | } |
| 266 | |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 267 | pub fn dump_parsed_flags(mut input: Vec<Input>, format: DumpFormat) -> Result<Vec<u8>> { |
| 268 | let individually_parsed_flags: Result<Vec<ProtoParsedFlags>> = |
| 269 | input.iter_mut().map(|i| i.try_parse_flags()).collect(); |
| 270 | let parsed_flags: ProtoParsedFlags = |
| 271 | crate::protos::parsed_flags::merge(individually_parsed_flags?)?; |
| 272 | |
Mårten Kongstad | af67703 | 2023-05-17 16:18:25 +0200 | [diff] [blame] | 273 | let mut output = Vec::new(); |
Mårten Kongstad | f02734e | 2023-06-02 11:34:24 +0200 | [diff] [blame] | 274 | match format { |
| 275 | DumpFormat::Text => { |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 276 | for parsed_flag in parsed_flags.parsed_flag.into_iter() { |
Mårten Kongstad | f02734e | 2023-06-02 11:34:24 +0200 | [diff] [blame] | 277 | let line = format!( |
Oriol Prieto Gasco | 7afc7e7 | 2023-11-22 13:26:02 +0000 | [diff] [blame^] | 278 | "{}.{} [{}]: {:?} + {:?}\n", |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 279 | parsed_flag.package(), |
| 280 | parsed_flag.name(), |
Oriol Prieto Gasco | 7afc7e7 | 2023-11-22 13:26:02 +0000 | [diff] [blame^] | 281 | parsed_flag.container(), |
Mårten Kongstad | 3fa2f07 | 2023-07-20 09:35:05 +0200 | [diff] [blame] | 282 | parsed_flag.permission(), |
| 283 | parsed_flag.state() |
Mårten Kongstad | f02734e | 2023-06-02 11:34:24 +0200 | [diff] [blame] | 284 | ); |
| 285 | output.extend_from_slice(line.as_bytes()); |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 286 | } |
Mårten Kongstad | f02734e | 2023-06-02 11:34:24 +0200 | [diff] [blame] | 287 | } |
Mårten Kongstad | ea49814 | 2023-07-20 11:07:35 +0200 | [diff] [blame] | 288 | DumpFormat::Verbose => { |
| 289 | for parsed_flag in parsed_flags.parsed_flag.into_iter() { |
| 290 | let sources: Vec<_> = |
| 291 | parsed_flag.trace.iter().map(|tracepoint| tracepoint.source()).collect(); |
| 292 | let line = format!( |
Oriol Prieto Gasco | 7afc7e7 | 2023-11-22 13:26:02 +0000 | [diff] [blame^] | 293 | "{}.{} [{}]: {:?} + {:?} ({})\n", |
Mårten Kongstad | ea49814 | 2023-07-20 11:07:35 +0200 | [diff] [blame] | 294 | parsed_flag.package(), |
| 295 | parsed_flag.name(), |
Oriol Prieto Gasco | 7afc7e7 | 2023-11-22 13:26:02 +0000 | [diff] [blame^] | 296 | parsed_flag.container(), |
Mårten Kongstad | ea49814 | 2023-07-20 11:07:35 +0200 | [diff] [blame] | 297 | parsed_flag.permission(), |
| 298 | parsed_flag.state(), |
| 299 | sources.join(", ") |
| 300 | ); |
| 301 | output.extend_from_slice(line.as_bytes()); |
| 302 | } |
| 303 | } |
Mårten Kongstad | f02734e | 2023-06-02 11:34:24 +0200 | [diff] [blame] | 304 | DumpFormat::Protobuf => { |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 305 | parsed_flags.write_to_vec(&mut output)?; |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 306 | } |
Mårten Kongstad | 3228b29 | 2023-06-26 10:17:42 +0200 | [diff] [blame] | 307 | DumpFormat::Textproto => { |
| 308 | let s = protobuf::text_format::print_to_string_pretty(&parsed_flags); |
| 309 | output.extend_from_slice(s.as_bytes()); |
| 310 | } |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 311 | } |
Mårten Kongstad | af67703 | 2023-05-17 16:18:25 +0200 | [diff] [blame] | 312 | Ok(output) |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 313 | } |
| 314 | |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 315 | fn find_unique_package(parsed_flags: &ProtoParsedFlags) -> Option<&str> { |
| 316 | let Some(package) = parsed_flags.parsed_flag.first().map(|pf| pf.package()) else { |
| 317 | return None; |
| 318 | }; |
| 319 | if parsed_flags.parsed_flag.iter().any(|pf| pf.package() != package) { |
| 320 | return None; |
| 321 | } |
| 322 | Some(package) |
Mårten Kongstad | f02734e | 2023-06-02 11:34:24 +0200 | [diff] [blame] | 323 | } |
| 324 | |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 325 | #[cfg(test)] |
| 326 | mod tests { |
| 327 | use super::*; |
Mårten Kongstad | a102909 | 2023-05-08 11:51:59 +0200 | [diff] [blame] | 328 | |
| 329 | #[test] |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 330 | fn test_parse_flags() { |
| 331 | let parsed_flags = crate::test::parse_test_flags(); // calls parse_flags |
| 332 | crate::protos::parsed_flags::verify_fields(&parsed_flags).unwrap(); |
| 333 | |
| 334 | let enabled_ro = |
| 335 | parsed_flags.parsed_flag.iter().find(|pf| pf.name() == "enabled_ro").unwrap(); |
| 336 | assert!(crate::protos::parsed_flag::verify_fields(enabled_ro).is_ok()); |
| 337 | assert_eq!("com.android.aconfig.test", enabled_ro.package()); |
| 338 | assert_eq!("enabled_ro", enabled_ro.name()); |
| 339 | assert_eq!("This flag is ENABLED + READ_ONLY", enabled_ro.description()); |
| 340 | assert_eq!(ProtoFlagState::ENABLED, enabled_ro.state()); |
| 341 | assert_eq!(ProtoFlagPermission::READ_ONLY, enabled_ro.permission()); |
| 342 | assert_eq!(3, enabled_ro.trace.len()); |
Zhi Dou | 71f1b35 | 2023-08-21 22:49:46 +0000 | [diff] [blame] | 343 | assert!(!enabled_ro.is_fixed_read_only()); |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 344 | assert_eq!("tests/test.aconfig", enabled_ro.trace[0].source()); |
| 345 | assert_eq!(ProtoFlagState::DISABLED, enabled_ro.trace[0].state()); |
| 346 | assert_eq!(ProtoFlagPermission::READ_WRITE, enabled_ro.trace[0].permission()); |
| 347 | assert_eq!("tests/first.values", enabled_ro.trace[1].source()); |
| 348 | assert_eq!(ProtoFlagState::DISABLED, enabled_ro.trace[1].state()); |
| 349 | assert_eq!(ProtoFlagPermission::READ_WRITE, enabled_ro.trace[1].permission()); |
| 350 | assert_eq!("tests/second.values", enabled_ro.trace[2].source()); |
| 351 | assert_eq!(ProtoFlagState::ENABLED, enabled_ro.trace[2].state()); |
| 352 | assert_eq!(ProtoFlagPermission::READ_ONLY, enabled_ro.trace[2].permission()); |
| 353 | |
Ted Bauer | 4a6af78 | 2023-11-29 15:44:24 +0000 | [diff] [blame] | 354 | assert_eq!(7, parsed_flags.parsed_flag.len()); |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 355 | for pf in parsed_flags.parsed_flag.iter() { |
Zhi Dou | 71f1b35 | 2023-08-21 22:49:46 +0000 | [diff] [blame] | 356 | if pf.name() == "enabled_fixed_ro" { |
| 357 | continue; |
| 358 | } |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 359 | let first = pf.trace.first().unwrap(); |
| 360 | assert_eq!(DEFAULT_FLAG_STATE, first.state()); |
| 361 | assert_eq!(DEFAULT_FLAG_PERMISSION, first.permission()); |
| 362 | |
| 363 | let last = pf.trace.last().unwrap(); |
| 364 | assert_eq!(pf.state(), last.state()); |
| 365 | assert_eq!(pf.permission(), last.permission()); |
| 366 | } |
Zhi Dou | 71f1b35 | 2023-08-21 22:49:46 +0000 | [diff] [blame] | 367 | |
| 368 | let enabled_fixed_ro = |
| 369 | parsed_flags.parsed_flag.iter().find(|pf| pf.name() == "enabled_fixed_ro").unwrap(); |
| 370 | assert!(enabled_fixed_ro.is_fixed_read_only()); |
| 371 | assert_eq!(ProtoFlagState::ENABLED, enabled_fixed_ro.state()); |
| 372 | assert_eq!(ProtoFlagPermission::READ_ONLY, enabled_fixed_ro.permission()); |
| 373 | assert_eq!(2, enabled_fixed_ro.trace.len()); |
| 374 | assert_eq!(ProtoFlagPermission::READ_ONLY, enabled_fixed_ro.trace[0].permission()); |
| 375 | assert_eq!(ProtoFlagPermission::READ_ONLY, enabled_fixed_ro.trace[1].permission()); |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 376 | } |
Mårten Kongstad | a102909 | 2023-05-08 11:51:59 +0200 | [diff] [blame] | 377 | |
| 378 | #[test] |
Zhi Dou | 24a0b6a | 2023-08-10 21:39:59 +0000 | [diff] [blame] | 379 | fn test_parse_flags_setting_default() { |
| 380 | let first_flag = r#" |
| 381 | package: "com.first" |
| 382 | flag { |
| 383 | name: "first" |
| 384 | namespace: "first_ns" |
| 385 | description: "This is the description of the first flag." |
| 386 | bug: "123" |
| 387 | } |
| 388 | "#; |
| 389 | let declaration = |
| 390 | vec![Input { source: "momery".to_string(), reader: Box::new(first_flag.as_bytes()) }]; |
| 391 | let value: Vec<Input> = vec![]; |
| 392 | |
| 393 | let flags_bytes = crate::commands::parse_flags( |
| 394 | "com.first", |
Oriol Prieto Gasco | 7afc7e7 | 2023-11-22 13:26:02 +0000 | [diff] [blame^] | 395 | None, |
Zhi Dou | 24a0b6a | 2023-08-10 21:39:59 +0000 | [diff] [blame] | 396 | declaration, |
| 397 | value, |
| 398 | ProtoFlagPermission::READ_ONLY, |
| 399 | ) |
| 400 | .unwrap(); |
| 401 | let parsed_flags = |
| 402 | crate::protos::parsed_flags::try_from_binary_proto(&flags_bytes).unwrap(); |
| 403 | assert_eq!(1, parsed_flags.parsed_flag.len()); |
| 404 | let parsed_flag = parsed_flags.parsed_flag.first().unwrap(); |
| 405 | assert_eq!(ProtoFlagState::DISABLED, parsed_flag.state()); |
| 406 | assert_eq!(ProtoFlagPermission::READ_ONLY, parsed_flag.permission()); |
| 407 | } |
| 408 | |
| 409 | #[test] |
Oriol Prieto Gasco | 7afc7e7 | 2023-11-22 13:26:02 +0000 | [diff] [blame^] | 410 | fn test_parse_flags_package_mismatch_between_declaration_and_command_line() { |
| 411 | let first_flag = r#" |
| 412 | package: "com.declaration.package" |
| 413 | container: "first.container" |
| 414 | flag { |
| 415 | name: "first" |
| 416 | namespace: "first_ns" |
| 417 | description: "This is the description of the first flag." |
| 418 | bug: "123" |
| 419 | } |
| 420 | "#; |
| 421 | let declaration = |
| 422 | vec![Input { source: "memory".to_string(), reader: Box::new(first_flag.as_bytes()) }]; |
| 423 | |
| 424 | let value: Vec<Input> = vec![]; |
| 425 | |
| 426 | let error = crate::commands::parse_flags( |
| 427 | "com.argument.package", |
| 428 | Some("first.container"), |
| 429 | declaration, |
| 430 | value, |
| 431 | ProtoFlagPermission::READ_WRITE, |
| 432 | ) |
| 433 | .unwrap_err(); |
| 434 | assert_eq!( |
| 435 | format!("{:?}", error), |
| 436 | "failed to parse memory: expected package com.argument.package, got com.declaration.package" |
| 437 | ); |
| 438 | } |
| 439 | |
| 440 | #[test] |
| 441 | fn test_parse_flags_container_mismatch_between_declaration_and_command_line() { |
| 442 | let first_flag = r#" |
| 443 | package: "com.first" |
| 444 | container: "declaration.container" |
| 445 | flag { |
| 446 | name: "first" |
| 447 | namespace: "first_ns" |
| 448 | description: "This is the description of the first flag." |
| 449 | bug: "123" |
| 450 | } |
| 451 | "#; |
| 452 | let declaration = |
| 453 | vec![Input { source: "memory".to_string(), reader: Box::new(first_flag.as_bytes()) }]; |
| 454 | |
| 455 | let value: Vec<Input> = vec![]; |
| 456 | |
| 457 | let error = crate::commands::parse_flags( |
| 458 | "com.first", |
| 459 | Some("argument.container"), |
| 460 | declaration, |
| 461 | value, |
| 462 | ProtoFlagPermission::READ_WRITE, |
| 463 | ) |
| 464 | .unwrap_err(); |
| 465 | assert_eq!( |
| 466 | format!("{:?}", error), |
| 467 | "failed to parse memory: expected container argument.container, got declaration.container" |
| 468 | ); |
| 469 | } |
| 470 | |
| 471 | #[test] |
Zhi Dou | 71f1b35 | 2023-08-21 22:49:46 +0000 | [diff] [blame] | 472 | fn test_parse_flags_override_fixed_read_only() { |
| 473 | let first_flag = r#" |
| 474 | package: "com.first" |
Oriol Prieto Gasco | 7afc7e7 | 2023-11-22 13:26:02 +0000 | [diff] [blame^] | 475 | container: "com.first.container" |
Zhi Dou | 71f1b35 | 2023-08-21 22:49:46 +0000 | [diff] [blame] | 476 | flag { |
| 477 | name: "first" |
| 478 | namespace: "first_ns" |
| 479 | description: "This is the description of the first flag." |
| 480 | bug: "123" |
| 481 | is_fixed_read_only: true |
| 482 | } |
| 483 | "#; |
| 484 | let declaration = |
| 485 | vec![Input { source: "memory".to_string(), reader: Box::new(first_flag.as_bytes()) }]; |
| 486 | |
| 487 | let first_flag_value = r#" |
| 488 | flag_value { |
| 489 | package: "com.first" |
| 490 | name: "first" |
| 491 | state: DISABLED |
| 492 | permission: READ_WRITE |
| 493 | } |
| 494 | "#; |
| 495 | let value = vec![Input { |
| 496 | source: "memory".to_string(), |
| 497 | reader: Box::new(first_flag_value.as_bytes()), |
| 498 | }]; |
| 499 | let error = crate::commands::parse_flags( |
| 500 | "com.first", |
Oriol Prieto Gasco | 7afc7e7 | 2023-11-22 13:26:02 +0000 | [diff] [blame^] | 501 | Some("com.first.container"), |
Zhi Dou | 71f1b35 | 2023-08-21 22:49:46 +0000 | [diff] [blame] | 502 | declaration, |
| 503 | value, |
| 504 | ProtoFlagPermission::READ_WRITE, |
| 505 | ) |
| 506 | .unwrap_err(); |
| 507 | assert_eq!( |
| 508 | format!("{:?}", error), |
| 509 | "failed to set permission of flag first, since this flag is fixed read only flag" |
| 510 | ); |
| 511 | } |
| 512 | |
| 513 | #[test] |
Mårten Kongstad | f02734e | 2023-06-02 11:34:24 +0200 | [diff] [blame] | 514 | fn test_create_device_config_defaults() { |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 515 | let input = parse_test_flags_as_input(); |
| 516 | let bytes = create_device_config_defaults(input).unwrap(); |
Mårten Kongstad | f02734e | 2023-06-02 11:34:24 +0200 | [diff] [blame] | 517 | let text = std::str::from_utf8(&bytes).unwrap(); |
Ted Bauer | 4a6af78 | 2023-11-29 15:44:24 +0000 | [diff] [blame] | 518 | assert_eq!("aconfig_test:com.android.aconfig.test.disabled_rw=disabled\naconfig_test:com.android.aconfig.test.disabled_rw_exported=disabled\nother_namespace:com.android.aconfig.test.disabled_rw_in_other_namespace=disabled\naconfig_test:com.android.aconfig.test.enabled_rw=enabled\n", text); |
Mårten Kongstad | f02734e | 2023-06-02 11:34:24 +0200 | [diff] [blame] | 519 | } |
| 520 | |
| 521 | #[test] |
Mårten Kongstad | c31a6ff | 2023-06-02 11:54:36 +0200 | [diff] [blame] | 522 | fn test_create_device_config_sysprops() { |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 523 | let input = parse_test_flags_as_input(); |
| 524 | let bytes = create_device_config_sysprops(input).unwrap(); |
Mårten Kongstad | c31a6ff | 2023-06-02 11:54:36 +0200 | [diff] [blame] | 525 | let text = std::str::from_utf8(&bytes).unwrap(); |
Ted Bauer | 4a6af78 | 2023-11-29 15:44:24 +0000 | [diff] [blame] | 526 | assert_eq!("persist.device_config.com.android.aconfig.test.disabled_rw=false\npersist.device_config.com.android.aconfig.test.disabled_rw_exported=false\npersist.device_config.com.android.aconfig.test.disabled_rw_in_other_namespace=false\npersist.device_config.com.android.aconfig.test.enabled_rw=true\n", text); |
Mårten Kongstad | c31a6ff | 2023-06-02 11:54:36 +0200 | [diff] [blame] | 527 | } |
| 528 | |
| 529 | #[test] |
Mårten Kongstad | a102909 | 2023-05-08 11:51:59 +0200 | [diff] [blame] | 530 | fn test_dump_text_format() { |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 531 | let input = parse_test_flags_as_input(); |
| 532 | let bytes = dump_parsed_flags(vec![input], DumpFormat::Text).unwrap(); |
Mårten Kongstad | a102909 | 2023-05-08 11:51:59 +0200 | [diff] [blame] | 533 | let text = std::str::from_utf8(&bytes).unwrap(); |
Oriol Prieto Gasco | 7afc7e7 | 2023-11-22 13:26:02 +0000 | [diff] [blame^] | 534 | assert!( |
| 535 | text.contains("com.android.aconfig.test.disabled_ro [system]: READ_ONLY + DISABLED") |
| 536 | ); |
Mårten Kongstad | a102909 | 2023-05-08 11:51:59 +0200 | [diff] [blame] | 537 | } |
| 538 | |
Mårten Kongstad | 1b8636b | 2023-06-22 10:12:24 +0200 | [diff] [blame] | 539 | #[test] |
| 540 | fn test_dump_protobuf_format() { |
Mårten Kongstad | 3228b29 | 2023-06-26 10:17:42 +0200 | [diff] [blame] | 541 | let expected = protobuf::text_format::parse_from_str::<ProtoParsedFlags>( |
| 542 | crate::test::TEST_FLAGS_TEXTPROTO, |
| 543 | ) |
| 544 | .unwrap() |
| 545 | .write_to_bytes() |
| 546 | .unwrap(); |
Mårten Kongstad | 1b8636b | 2023-06-22 10:12:24 +0200 | [diff] [blame] | 547 | |
| 548 | let input = parse_test_flags_as_input(); |
| 549 | let actual = dump_parsed_flags(vec![input], DumpFormat::Protobuf).unwrap(); |
| 550 | |
| 551 | assert_eq!(expected, actual); |
| 552 | } |
| 553 | |
Mårten Kongstad | 3228b29 | 2023-06-26 10:17:42 +0200 | [diff] [blame] | 554 | #[test] |
| 555 | fn test_dump_textproto_format() { |
| 556 | let input = parse_test_flags_as_input(); |
| 557 | let bytes = dump_parsed_flags(vec![input], DumpFormat::Textproto).unwrap(); |
| 558 | let text = std::str::from_utf8(&bytes).unwrap(); |
| 559 | assert_eq!(crate::test::TEST_FLAGS_TEXTPROTO.trim(), text.trim()); |
| 560 | } |
| 561 | |
Mårten Kongstad | 403658f | 2023-06-14 09:51:56 +0200 | [diff] [blame] | 562 | fn parse_test_flags_as_input() -> Input { |
| 563 | let parsed_flags = crate::test::parse_test_flags(); |
| 564 | let binary_proto = parsed_flags.write_to_bytes().unwrap(); |
| 565 | let cursor = std::io::Cursor::new(binary_proto); |
| 566 | let reader = Box::new(cursor); |
| 567 | Input { source: "test.data".to_string(), reader } |
Mårten Kongstad | af67703 | 2023-05-17 16:18:25 +0200 | [diff] [blame] | 568 | } |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 569 | } |