Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2023 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
Mårten Kongstad | e66b89f | 2023-05-15 10:29:25 +0200 | [diff] [blame] | 17 | use anyhow::{bail, ensure, Result}; |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 18 | use serde::{Deserialize, Serialize}; |
| 19 | use std::io::{Read, Write}; |
| 20 | |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 21 | use crate::aconfig::{FlagDeclaration, FlagState, FlagValue, Permission}; |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 22 | use crate::commands::Source; |
| 23 | |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 24 | const DEFAULT_FLAG_STATE: FlagState = FlagState::Disabled; |
| 25 | const DEFAULT_FLAG_PERMISSION: Permission = Permission::ReadWrite; |
| 26 | |
Mårten Kongstad | 416330b | 2023-05-05 11:10:01 +0200 | [diff] [blame] | 27 | #[derive(Serialize, Deserialize, Debug)] |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame] | 28 | pub struct Tracepoint { |
Mårten Kongstad | 76adff2 | 2023-05-08 10:57:24 +0200 | [diff] [blame] | 29 | pub source: Source, |
| 30 | pub state: FlagState, |
| 31 | pub permission: Permission, |
| 32 | } |
| 33 | |
| 34 | #[derive(Serialize, Deserialize, Debug)] |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 35 | pub struct Item { |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame] | 36 | // TODO: duplicating the Cache.namespace as Item.namespace makes the internal representation |
| 37 | // closer to the proto message `parsed_flag`; hopefully this will enable us to replace the Item |
| 38 | // struct and use a newtype instead once aconfig has matured. Until then, namespace should |
| 39 | // really be a Cow<String>. |
| 40 | pub namespace: String, |
| 41 | pub name: String, |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 42 | pub description: String, |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 43 | pub state: FlagState, |
Mårten Kongstad | 416330b | 2023-05-05 11:10:01 +0200 | [diff] [blame] | 44 | pub permission: Permission, |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame] | 45 | pub trace: Vec<Tracepoint>, |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 46 | } |
| 47 | |
Mårten Kongstad | 416330b | 2023-05-05 11:10:01 +0200 | [diff] [blame] | 48 | #[derive(Serialize, Deserialize, Debug)] |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 49 | pub struct Cache { |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame] | 50 | namespace: String, |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 51 | items: Vec<Item>, |
| 52 | } |
| 53 | |
| 54 | impl Cache { |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 55 | pub fn new(namespace: String) -> Cache { |
| 56 | Cache { namespace, items: vec![] } |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 57 | } |
| 58 | |
| 59 | pub fn read_from_reader(reader: impl Read) -> Result<Cache> { |
| 60 | serde_json::from_reader(reader).map_err(|e| e.into()) |
| 61 | } |
| 62 | |
| 63 | pub fn write_to_writer(&self, writer: impl Write) -> Result<()> { |
| 64 | serde_json::to_writer(writer, self).map_err(|e| e.into()) |
| 65 | } |
| 66 | |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 67 | pub fn add_flag_declaration( |
| 68 | &mut self, |
| 69 | source: Source, |
| 70 | declaration: FlagDeclaration, |
| 71 | ) -> Result<()> { |
Mårten Kongstad | e66b89f | 2023-05-15 10:29:25 +0200 | [diff] [blame] | 72 | ensure!( |
| 73 | self.items.iter().all(|item| item.name != declaration.name), |
| 74 | "failed to declare flag {} from {}: flag already declared", |
| 75 | declaration.name, |
| 76 | source |
| 77 | ); |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 78 | self.items.push(Item { |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame] | 79 | namespace: self.namespace.clone(), |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 80 | name: declaration.name.clone(), |
| 81 | description: declaration.description, |
| 82 | state: DEFAULT_FLAG_STATE, |
| 83 | permission: DEFAULT_FLAG_PERMISSION, |
| 84 | trace: vec![Tracepoint { |
| 85 | source, |
| 86 | state: DEFAULT_FLAG_STATE, |
| 87 | permission: DEFAULT_FLAG_PERMISSION, |
| 88 | }], |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 89 | }); |
| 90 | Ok(()) |
| 91 | } |
| 92 | |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 93 | pub fn add_flag_value(&mut self, source: Source, value: FlagValue) -> Result<()> { |
| 94 | ensure!( |
| 95 | value.namespace == self.namespace, |
| 96 | "failed to set values for flag {}/{} from {}: expected namespace {}", |
| 97 | value.namespace, |
| 98 | value.name, |
| 99 | source, |
| 100 | self.namespace |
| 101 | ); |
| 102 | let Some(existing_item) = self.items.iter_mut().find(|item| item.name == value.name) else { |
| 103 | bail!("failed to set values for flag {}/{} from {}: flag not declared", value.namespace, value.name, source); |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 104 | }; |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 105 | existing_item.state = value.state; |
| 106 | existing_item.permission = value.permission; |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame] | 107 | existing_item.trace.push(Tracepoint { |
Mårten Kongstad | 76adff2 | 2023-05-08 10:57:24 +0200 | [diff] [blame] | 108 | source, |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 109 | state: value.state, |
| 110 | permission: value.permission, |
Mårten Kongstad | 76adff2 | 2023-05-08 10:57:24 +0200 | [diff] [blame] | 111 | }); |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 112 | Ok(()) |
| 113 | } |
| 114 | |
| 115 | pub fn iter(&self) -> impl Iterator<Item = &Item> { |
| 116 | self.items.iter() |
| 117 | } |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 118 | |
Mårten Kongstad | a102909 | 2023-05-08 11:51:59 +0200 | [diff] [blame] | 119 | pub fn into_iter(self) -> impl Iterator<Item = Item> { |
| 120 | self.items.into_iter() |
| 121 | } |
| 122 | } |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 123 | |
| 124 | #[cfg(test)] |
| 125 | mod tests { |
| 126 | use super::*; |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 127 | use crate::aconfig::{FlagState, Permission}; |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 128 | |
| 129 | #[test] |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 130 | fn test_add_flag_declaration() { |
| 131 | let mut cache = Cache::new("ns".to_string()); |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 132 | cache |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 133 | .add_flag_declaration( |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 134 | Source::File("first.txt".to_string()), |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 135 | FlagDeclaration { name: "foo".to_string(), description: "desc".to_string() }, |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 136 | ) |
| 137 | .unwrap(); |
| 138 | let error = cache |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 139 | .add_flag_declaration( |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 140 | Source::File("second.txt".to_string()), |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 141 | FlagDeclaration { name: "foo".to_string(), description: "desc".to_string() }, |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 142 | ) |
| 143 | .unwrap_err(); |
| 144 | assert_eq!( |
| 145 | &format!("{:?}", error), |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 146 | "failed to declare flag foo from second.txt: flag already declared" |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 147 | ); |
| 148 | } |
| 149 | |
| 150 | #[test] |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 151 | fn test_add_flag_value() { |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame] | 152 | fn check(cache: &Cache, name: &str, expected: (FlagState, Permission)) -> bool { |
| 153 | let item = cache.iter().find(|&item| item.name == name).unwrap(); |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 154 | item.state == expected.0 && item.permission == expected.1 |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 155 | } |
| 156 | |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 157 | let mut cache = Cache::new("ns".to_string()); |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 158 | let error = cache |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 159 | .add_flag_value( |
Mårten Kongstad | 416330b | 2023-05-05 11:10:01 +0200 | [diff] [blame] | 160 | Source::Memory, |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 161 | FlagValue { |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame] | 162 | namespace: "ns".to_string(), |
| 163 | name: "foo".to_string(), |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 164 | state: FlagState::Enabled, |
| 165 | permission: Permission::ReadOnly, |
| 166 | }, |
Mårten Kongstad | 416330b | 2023-05-05 11:10:01 +0200 | [diff] [blame] | 167 | ) |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 168 | .unwrap_err(); |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 169 | assert_eq!( |
| 170 | &format!("{:?}", error), |
| 171 | "failed to set values for flag ns/foo from <memory>: flag not declared" |
| 172 | ); |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 173 | |
| 174 | cache |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 175 | .add_flag_declaration( |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 176 | Source::File("first.txt".to_string()), |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 177 | FlagDeclaration { name: "foo".to_string(), description: "desc".to_string() }, |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 178 | ) |
| 179 | .unwrap(); |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 180 | assert!(check(&cache, "foo", (DEFAULT_FLAG_STATE, DEFAULT_FLAG_PERMISSION))); |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 181 | |
| 182 | cache |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 183 | .add_flag_value( |
Mårten Kongstad | 416330b | 2023-05-05 11:10:01 +0200 | [diff] [blame] | 184 | Source::Memory, |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 185 | FlagValue { |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame] | 186 | namespace: "ns".to_string(), |
| 187 | name: "foo".to_string(), |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 188 | state: FlagState::Disabled, |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 189 | permission: Permission::ReadOnly, |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 190 | }, |
Mårten Kongstad | 416330b | 2023-05-05 11:10:01 +0200 | [diff] [blame] | 191 | ) |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 192 | .unwrap(); |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 193 | assert!(check(&cache, "foo", (FlagState::Disabled, Permission::ReadOnly))); |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 194 | |
| 195 | cache |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 196 | .add_flag_value( |
Mårten Kongstad | 416330b | 2023-05-05 11:10:01 +0200 | [diff] [blame] | 197 | Source::Memory, |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 198 | FlagValue { |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame] | 199 | namespace: "ns".to_string(), |
| 200 | name: "foo".to_string(), |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 201 | state: FlagState::Enabled, |
| 202 | permission: Permission::ReadWrite, |
| 203 | }, |
Mårten Kongstad | 416330b | 2023-05-05 11:10:01 +0200 | [diff] [blame] | 204 | ) |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 205 | .unwrap(); |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 206 | assert!(check(&cache, "foo", (FlagState::Enabled, Permission::ReadWrite))); |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame] | 207 | |
| 208 | // different namespace -> no-op |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 209 | let error = cache |
| 210 | .add_flag_value( |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame] | 211 | Source::Memory, |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 212 | FlagValue { |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame] | 213 | namespace: "some-other-namespace".to_string(), |
| 214 | name: "foo".to_string(), |
| 215 | state: FlagState::Enabled, |
| 216 | permission: Permission::ReadOnly, |
| 217 | }, |
| 218 | ) |
Mårten Kongstad | fa23d29 | 2023-05-11 14:47:02 +0200 | [diff] [blame] | 219 | .unwrap_err(); |
| 220 | assert_eq!(&format!("{:?}", error), "failed to set values for flag some-other-namespace/foo from <memory>: expected namespace ns"); |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame] | 221 | assert!(check(&cache, "foo", (FlagState::Enabled, Permission::ReadWrite))); |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 222 | } |
| 223 | } |