Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 1 | /* |
| 2 | * Copyright (C) 2023 The Android Open Source Project |
| 3 | * |
| 4 | * Licensed under the Apache License, Version 2.0 (the "License"); |
| 5 | * you may not use this file except in compliance with the License. |
| 6 | * You may obtain a copy of the License at |
| 7 | * |
| 8 | * http://www.apache.org/licenses/LICENSE-2.0 |
| 9 | * |
| 10 | * Unless required by applicable law or agreed to in writing, software |
| 11 | * distributed under the License is distributed on an "AS IS" BASIS, |
| 12 | * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 13 | * See the License for the specific language governing permissions and |
| 14 | * limitations under the License. |
| 15 | */ |
| 16 | |
| 17 | use anyhow::{anyhow, Result}; |
| 18 | use serde::{Deserialize, Serialize}; |
| 19 | use std::io::{Read, Write}; |
| 20 | |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 21 | use crate::aconfig::{Flag, FlagState, Override, Permission}; |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 22 | use crate::commands::Source; |
| 23 | |
Mårten Kongstad | 416330b | 2023-05-05 11:10:01 +0200 | [diff] [blame] | 24 | #[derive(Serialize, Deserialize, Debug)] |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame^] | 25 | pub struct Tracepoint { |
Mårten Kongstad | 76adff2 | 2023-05-08 10:57:24 +0200 | [diff] [blame] | 26 | pub source: Source, |
| 27 | pub state: FlagState, |
| 28 | pub permission: Permission, |
| 29 | } |
| 30 | |
| 31 | #[derive(Serialize, Deserialize, Debug)] |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 32 | pub struct Item { |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame^] | 33 | // TODO: duplicating the Cache.namespace as Item.namespace makes the internal representation |
| 34 | // closer to the proto message `parsed_flag`; hopefully this will enable us to replace the Item |
| 35 | // struct and use a newtype instead once aconfig has matured. Until then, namespace should |
| 36 | // really be a Cow<String>. |
| 37 | pub namespace: String, |
| 38 | pub name: String, |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 39 | pub description: String, |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 40 | pub state: FlagState, |
Mårten Kongstad | 416330b | 2023-05-05 11:10:01 +0200 | [diff] [blame] | 41 | pub permission: Permission, |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame^] | 42 | pub trace: Vec<Tracepoint>, |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 43 | } |
| 44 | |
Mårten Kongstad | 416330b | 2023-05-05 11:10:01 +0200 | [diff] [blame] | 45 | #[derive(Serialize, Deserialize, Debug)] |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 46 | pub struct Cache { |
Mårten Kongstad | 09c28d1 | 2023-05-04 13:29:26 +0200 | [diff] [blame] | 47 | build_id: u32, |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame^] | 48 | namespace: String, |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 49 | items: Vec<Item>, |
| 50 | } |
| 51 | |
| 52 | impl Cache { |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame^] | 53 | pub fn new(build_id: u32, namespace: String) -> Cache { |
| 54 | Cache { build_id, namespace, items: vec![] } |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 55 | } |
| 56 | |
| 57 | pub fn read_from_reader(reader: impl Read) -> Result<Cache> { |
| 58 | serde_json::from_reader(reader).map_err(|e| e.into()) |
| 59 | } |
| 60 | |
| 61 | pub fn write_to_writer(&self, writer: impl Write) -> Result<()> { |
| 62 | serde_json::to_writer(writer, self).map_err(|e| e.into()) |
| 63 | } |
| 64 | |
| 65 | pub fn add_flag(&mut self, source: Source, flag: Flag) -> Result<()> { |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame^] | 66 | if self.items.iter().any(|item| item.name == flag.name) { |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 67 | return Err(anyhow!( |
Mårten Kongstad | 09c28d1 | 2023-05-04 13:29:26 +0200 | [diff] [blame] | 68 | "failed to add flag {} from {}: flag already defined", |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame^] | 69 | flag.name, |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 70 | source, |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 71 | )); |
| 72 | } |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 73 | let (state, permission) = flag.resolve(self.build_id); |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 74 | self.items.push(Item { |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame^] | 75 | namespace: self.namespace.clone(), |
| 76 | name: flag.name.clone(), |
Mårten Kongstad | 09c28d1 | 2023-05-04 13:29:26 +0200 | [diff] [blame] | 77 | description: flag.description, |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 78 | state, |
Mårten Kongstad | 416330b | 2023-05-05 11:10:01 +0200 | [diff] [blame] | 79 | permission, |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame^] | 80 | trace: vec![Tracepoint { source, state, permission }], |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 81 | }); |
| 82 | Ok(()) |
| 83 | } |
| 84 | |
| 85 | pub fn add_override(&mut self, source: Source, override_: Override) -> Result<()> { |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame^] | 86 | if override_.namespace != self.namespace { |
| 87 | // TODO: print warning? |
| 88 | return Ok(()); |
| 89 | } |
| 90 | let Some(existing_item) = self.items.iter_mut().find(|item| item.name == override_.name) else { |
| 91 | return Err(anyhow!("failed to override flag {}: unknown flag", override_.name)); |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 92 | }; |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 93 | existing_item.state = override_.state; |
Mårten Kongstad | 416330b | 2023-05-05 11:10:01 +0200 | [diff] [blame] | 94 | existing_item.permission = override_.permission; |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame^] | 95 | existing_item.trace.push(Tracepoint { |
Mårten Kongstad | 76adff2 | 2023-05-08 10:57:24 +0200 | [diff] [blame] | 96 | source, |
| 97 | state: override_.state, |
| 98 | permission: override_.permission, |
| 99 | }); |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 100 | Ok(()) |
| 101 | } |
| 102 | |
| 103 | pub fn iter(&self) -> impl Iterator<Item = &Item> { |
| 104 | self.items.iter() |
| 105 | } |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 106 | |
Mårten Kongstad | a102909 | 2023-05-08 11:51:59 +0200 | [diff] [blame] | 107 | pub fn into_iter(self) -> impl Iterator<Item = Item> { |
| 108 | self.items.into_iter() |
| 109 | } |
| 110 | } |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 111 | |
| 112 | #[cfg(test)] |
| 113 | mod tests { |
| 114 | use super::*; |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 115 | use crate::aconfig::{FlagState, Permission, Value}; |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 116 | |
| 117 | #[test] |
| 118 | fn test_add_flag() { |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame^] | 119 | let mut cache = Cache::new(1, "ns".to_string()); |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 120 | cache |
| 121 | .add_flag( |
| 122 | Source::File("first.txt".to_string()), |
Mårten Kongstad | 09c28d1 | 2023-05-04 13:29:26 +0200 | [diff] [blame] | 123 | Flag { |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame^] | 124 | name: "foo".to_string(), |
Mårten Kongstad | 09c28d1 | 2023-05-04 13:29:26 +0200 | [diff] [blame] | 125 | description: "desc".to_string(), |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 126 | values: vec![Value::default(FlagState::Enabled, Permission::ReadOnly)], |
Mårten Kongstad | 09c28d1 | 2023-05-04 13:29:26 +0200 | [diff] [blame] | 127 | }, |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 128 | ) |
| 129 | .unwrap(); |
| 130 | let error = cache |
| 131 | .add_flag( |
| 132 | Source::File("second.txt".to_string()), |
Mårten Kongstad | 09c28d1 | 2023-05-04 13:29:26 +0200 | [diff] [blame] | 133 | Flag { |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame^] | 134 | name: "foo".to_string(), |
Mårten Kongstad | 09c28d1 | 2023-05-04 13:29:26 +0200 | [diff] [blame] | 135 | description: "desc".to_string(), |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 136 | values: vec![Value::default(FlagState::Disabled, Permission::ReadOnly)], |
Mårten Kongstad | 09c28d1 | 2023-05-04 13:29:26 +0200 | [diff] [blame] | 137 | }, |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 138 | ) |
| 139 | .unwrap_err(); |
| 140 | assert_eq!( |
| 141 | &format!("{:?}", error), |
Mårten Kongstad | 09c28d1 | 2023-05-04 13:29:26 +0200 | [diff] [blame] | 142 | "failed to add flag foo from second.txt: flag already defined" |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 143 | ); |
| 144 | } |
| 145 | |
| 146 | #[test] |
| 147 | fn test_add_override() { |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame^] | 148 | fn check(cache: &Cache, name: &str, expected: (FlagState, Permission)) -> bool { |
| 149 | let item = cache.iter().find(|&item| item.name == name).unwrap(); |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 150 | item.state == expected.0 && item.permission == expected.1 |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 151 | } |
| 152 | |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame^] | 153 | let mut cache = Cache::new(1, "ns".to_string()); |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 154 | let error = cache |
Mårten Kongstad | 416330b | 2023-05-05 11:10:01 +0200 | [diff] [blame] | 155 | .add_override( |
| 156 | Source::Memory, |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 157 | Override { |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame^] | 158 | namespace: "ns".to_string(), |
| 159 | name: "foo".to_string(), |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 160 | state: FlagState::Enabled, |
| 161 | permission: Permission::ReadOnly, |
| 162 | }, |
Mårten Kongstad | 416330b | 2023-05-05 11:10:01 +0200 | [diff] [blame] | 163 | ) |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 164 | .unwrap_err(); |
| 165 | assert_eq!(&format!("{:?}", error), "failed to override flag foo: unknown flag"); |
| 166 | |
| 167 | cache |
| 168 | .add_flag( |
| 169 | Source::File("first.txt".to_string()), |
Mårten Kongstad | 09c28d1 | 2023-05-04 13:29:26 +0200 | [diff] [blame] | 170 | Flag { |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame^] | 171 | name: "foo".to_string(), |
Mårten Kongstad | 09c28d1 | 2023-05-04 13:29:26 +0200 | [diff] [blame] | 172 | description: "desc".to_string(), |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 173 | values: vec![Value::default(FlagState::Enabled, Permission::ReadOnly)], |
Mårten Kongstad | 09c28d1 | 2023-05-04 13:29:26 +0200 | [diff] [blame] | 174 | }, |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 175 | ) |
| 176 | .unwrap(); |
Mårten Kongstad | 416330b | 2023-05-05 11:10:01 +0200 | [diff] [blame] | 177 | dbg!(&cache); |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 178 | assert!(check(&cache, "foo", (FlagState::Enabled, Permission::ReadOnly))); |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 179 | |
| 180 | cache |
Mårten Kongstad | 416330b | 2023-05-05 11:10:01 +0200 | [diff] [blame] | 181 | .add_override( |
| 182 | Source::Memory, |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 183 | Override { |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame^] | 184 | namespace: "ns".to_string(), |
| 185 | name: "foo".to_string(), |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 186 | state: FlagState::Disabled, |
| 187 | permission: Permission::ReadWrite, |
| 188 | }, |
Mårten Kongstad | 416330b | 2023-05-05 11:10:01 +0200 | [diff] [blame] | 189 | ) |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 190 | .unwrap(); |
Mårten Kongstad | 416330b | 2023-05-05 11:10:01 +0200 | [diff] [blame] | 191 | dbg!(&cache); |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 192 | assert!(check(&cache, "foo", (FlagState::Disabled, Permission::ReadWrite))); |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 193 | |
| 194 | cache |
Mårten Kongstad | 416330b | 2023-05-05 11:10:01 +0200 | [diff] [blame] | 195 | .add_override( |
| 196 | Source::Memory, |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 197 | Override { |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame^] | 198 | namespace: "ns".to_string(), |
| 199 | name: "foo".to_string(), |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 200 | state: FlagState::Enabled, |
| 201 | permission: Permission::ReadWrite, |
| 202 | }, |
Mårten Kongstad | 416330b | 2023-05-05 11:10:01 +0200 | [diff] [blame] | 203 | ) |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 204 | .unwrap(); |
Mårten Kongstad | c68c4ea | 2023-05-05 16:20:09 +0200 | [diff] [blame] | 205 | assert!(check(&cache, "foo", (FlagState::Enabled, Permission::ReadWrite))); |
Mårten Kongstad | 3095078 | 2023-05-09 13:31:29 +0200 | [diff] [blame^] | 206 | |
| 207 | // different namespace -> no-op |
| 208 | cache |
| 209 | .add_override( |
| 210 | Source::Memory, |
| 211 | Override { |
| 212 | namespace: "some-other-namespace".to_string(), |
| 213 | name: "foo".to_string(), |
| 214 | state: FlagState::Enabled, |
| 215 | permission: Permission::ReadOnly, |
| 216 | }, |
| 217 | ) |
| 218 | .unwrap(); |
| 219 | assert!(check(&cache, "foo", (FlagState::Enabled, Permission::ReadWrite))); |
Mårten Kongstad | 4d2b4b0 | 2023-04-27 16:05:58 +0200 | [diff] [blame] | 220 | } |
| 221 | } |