Clarify that the has_min_version() is ILP32-only.
It always returns true on LP64, so call it is_lp64_or_has_min_version() instead.
Change-Id: Icd11e34117be6a134c1b2854276a75d105356f90
diff --git a/linker/linker_soinfo.h b/linker/linker_soinfo.h
index 3416221..be002f0 100644
--- a/linker/linker_soinfo.h
+++ b/linker/linker_soinfo.h
@@ -294,8 +294,7 @@
bool can_unload() const;
bool is_gnu_hash() const;
- // TODO: rename this to make it clearer it's always true for LP64.
- bool inline has_min_version(uint32_t min_version __unused) const {
+ inline bool is_lp64_or_has_min_version(uint32_t min_version __unused) const {
#if defined(__LP64__)
return true;
#else
@@ -304,7 +303,7 @@
}
const ElfW(Versym)* get_versym_table() const {
- return has_min_version(2) ? versym_ : nullptr;
+ return is_lp64_or_has_min_version(2) ? versym_ : nullptr;
}
bool is_linked() const;
@@ -341,7 +340,7 @@
android_namespace_list_t& get_secondary_namespaces();
soinfo_tls* get_tls() const {
- return has_min_version(5) ? tls_.get() : nullptr;
+ return is_lp64_or_has_min_version(5) ? tls_.get() : nullptr;
}
void set_mapped_by_caller(bool reserved_map);