Gitiles
Code Review Sign In
gerrit.omnirom.org / android_system_vold / 04e04701901381f5ae966f6c217a0284cc0790cb
commit04e04701901381f5ae966f6c217a0284cc0790cb[log] [tgz]
authorPeter Collingbourne <pcc@google.com>Fri Nov 01 14:14:45 2024 -0700
committerPeter Collingbourne <pcc@google.com>Fri Nov 01 15:44:29 2024 -0700
treee6ec7272d276344f8d392d2d7f54519eceeccd53
parenta5be02dd48980d65fb1b83eb068e36da3a6906a8 [diff]
Fix uses-after-free

The code was previously taking the address of the device_name
string and passing it to execve (via an argument vector passed to
logwrap_fork_execvp) after device_name goes out of scope. Moreover,
the code for adding the length argument pushed the address of a
temporary to the vector. Fix it by having the code create a vector of
std::string for the arguments and only creating the vector of const
char * before calling logwrap_fork_execvp.

Bug: 376533537
Change-Id: Ic066cd9a1d3be5a1a7e6ad997f81166c039bbcaf
1 file changed
tree: e6ec7272d276344f8d392d2d7f54519eceeccd53
  1. bench/
  2. binder/
  3. fs/
  4. model/
  5. tests/
  6. .clang-format ⇨ ../../build/soong/scripts/system-clang-format
  7. Android.bp
  8. AppFuseUtil.cpp
  9. AppFuseUtil.h
  10. Benchmark.cpp
  11. Benchmark.h
  12. BenchmarkGen.h
  13. Checkpoint.cpp
  14. Checkpoint.h
  15. CleanSpec.mk
  16. cryptfs.cpp
  17. cryptfs.h
  18. CryptoType.cpp
  19. CryptoType.h
  20. EncryptInplace.cpp
  21. EncryptInplace.h
  22. FileDeviceUtils.cpp
  23. FileDeviceUtils.h
  24. FsCrypt.cpp
  25. FsCrypt.h
  26. IdleMaint.cpp
  27. IdleMaint.h
  28. KeyBuffer.cpp
  29. KeyBuffer.h
  30. KeyStorage.cpp
  31. KeyStorage.h
  32. Keystore.cpp
  33. Keystore.h
  34. KeyUtil.cpp
  35. KeyUtil.h
  36. Loop.cpp
  37. Loop.h
  38. main.cpp
  39. MetadataCrypt.cpp
  40. MetadataCrypt.h
  41. MoveStorage.cpp
  42. MoveStorage.h
  43. NetlinkHandler.cpp
  44. NetlinkHandler.h
  45. NetlinkManager.cpp
  46. NetlinkManager.h
  47. OWNERS
  48. PREUPLOAD.cfg
  49. Process.cpp
  50. Process.h
  51. secdiscard.cpp
  52. sehandle.h
  53. TEST_MAPPING
  54. Utils.cpp
  55. Utils.h
  56. vdc.cpp
  57. vold.rc
  58. vold_prepare_subdirs.cpp
  59. VoldNativeService.cpp
  60. VoldNativeService.h
  61. VoldNativeServiceValidation.cpp
  62. VoldNativeServiceValidation.h
  63. VoldUtil.cpp
  64. VoldUtil.h
  65. VolumeManager.cpp
  66. VolumeManager.h