commit 41514c19db4efb1e5d5d10c10d8d8e17030a113e
author Daichi Hirono <hirono@google.com> Fri Dec 02 17:00:35 2016 +0900
committer Daichi Hirono <hirono@google.com> Thu Jan 19 06:21:08 2017 +0900
tree ea3a66f7a9fc0993c23dcb3262fb726608a094c7
parent 7ec25c715f835c741d51a7ec0fd7b28220543364

Fix UID check in vold.

The CL fixes UID check in vold.
Previously appfuse was mounted in application's namespace. For new
public version, we mount appfuse in the system process then passes
opened files to applications.

Bug: 29970149
Test: CTS
Change-Id: Icec2e626d31d978c514eb7d1954bb59ad9556c43

CommandListener.cpp

diff --git a/CommandListener.cpp b/CommandListener.cpp
index b548a91..a312af2 100644
--- a/CommandListener.cpp
+++ b/CommandListener.cpp
@@ -703,8 +703,9 @@
             PLOG(ERROR) << "Failed to stat /proc/" << pid;
             return -errno;
         }
-        if (sb.st_uid != uid) {
-            LOG(ERROR) << "Mismatch UID expected=" << uid << ", actual=" << sb.st_uid;
+        if (sb.st_uid != AID_SYSTEM) {
+            LOG(ERROR) << "Only system can mount appfuse. UID expected=" << AID_SYSTEM
+                    << ", actual=" << sb.st_uid;
             return -EPERM;
         }
     }