| Alex Deymo | 40d86b2 | 2015-09-03 22:27:10 -0700 | [diff] [blame] | 1 | // | 
|  | 2 | // Copyright (C) 2015 The Android Open Source Project | 
|  | 3 | // | 
|  | 4 | // Licensed under the Apache License, Version 2.0 (the "License"); | 
|  | 5 | // you may not use this file except in compliance with the License. | 
|  | 6 | // You may obtain a copy of the License at | 
|  | 7 | // | 
|  | 8 | //      http://www.apache.org/licenses/LICENSE-2.0 | 
|  | 9 | // | 
|  | 10 | // Unless required by applicable law or agreed to in writing, software | 
|  | 11 | // distributed under the License is distributed on an "AS IS" BASIS, | 
|  | 12 | // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | 
|  | 13 | // See the License for the specific language governing permissions and | 
|  | 14 | // limitations under the License. | 
|  | 15 | // | 
|  | 16 |  | 
| Alex Deymo | 1b03f9f | 2015-12-09 00:38:36 -0800 | [diff] [blame] | 17 | #include "update_engine/hardware_android.h" | 
| Alex Deymo | 40d86b2 | 2015-09-03 22:27:10 -0700 | [diff] [blame] | 18 |  | 
| Alex Deymo | fb905d9 | 2016-06-03 19:26:58 -0700 | [diff] [blame] | 19 | #include <sys/types.h> | 
| Yifan Hong | fd6640f | 2020-08-27 19:13:17 -0700 | [diff] [blame] | 20 | #include <sys/utsname.h> | 
| Alex Deymo | fb905d9 | 2016-06-03 19:26:58 -0700 | [diff] [blame] | 21 |  | 
| Tom Cherry | fadd03c | 2017-10-10 14:45:09 -0700 | [diff] [blame] | 22 | #include <memory> | 
| Kelvin Zhang | d719103 | 2020-08-11 10:48:16 -0400 | [diff] [blame] | 23 | #include <string> | 
|  | 24 | #include <string_view> | 
| Alex Deymo | fb905d9 | 2016-06-03 19:26:58 -0700 | [diff] [blame] | 25 |  | 
| Kelvin Zhang | d719103 | 2020-08-11 10:48:16 -0400 | [diff] [blame] | 26 | #include <android-base/parseint.h> | 
| Tom Cherry | fadd03c | 2017-10-10 14:45:09 -0700 | [diff] [blame] | 27 | #include <android-base/properties.h> | 
| Alex Deymo | dd132f3 | 2015-09-14 19:12:07 -0700 | [diff] [blame] | 28 | #include <base/files/file_util.h> | 
| Tao Bao | 304680c | 2018-03-31 10:36:52 -0700 | [diff] [blame] | 29 | #include <bootloader_message/bootloader_message.h> | 
| Yifan Hong | fd6640f | 2020-08-27 19:13:17 -0700 | [diff] [blame] | 30 | #include <kver/kernel_release.h> | 
|  | 31 | #include <kver/utils.h> | 
| Alex Deymo | 40d86b2 | 2015-09-03 22:27:10 -0700 | [diff] [blame] | 32 |  | 
| Yifan Hong | 8702933 | 2020-09-01 17:20:08 -0700 | [diff] [blame] | 33 | #include "update_engine/common/error_code_utils.h" | 
| Alex Deymo | 39910dc | 2015-11-09 17:04:30 -0800 | [diff] [blame] | 34 | #include "update_engine/common/hardware.h" | 
| Sen Jiang | 9c12346 | 2015-11-19 13:16:23 -0800 | [diff] [blame] | 35 | #include "update_engine/common/platform_constants.h" | 
| Kelvin Zhang | d719103 | 2020-08-11 10:48:16 -0400 | [diff] [blame] | 36 | #include "update_engine/common/utils.h" | 
| Alex Deymo | 40d86b2 | 2015-09-03 22:27:10 -0700 | [diff] [blame] | 37 |  | 
| Tom Cherry | fadd03c | 2017-10-10 14:45:09 -0700 | [diff] [blame] | 38 | using android::base::GetBoolProperty; | 
|  | 39 | using android::base::GetIntProperty; | 
|  | 40 | using android::base::GetProperty; | 
| Yifan Hong | fd6640f | 2020-08-27 19:13:17 -0700 | [diff] [blame] | 41 | using android::kver::IsKernelUpdateValid; | 
|  | 42 | using android::kver::KernelRelease; | 
| Alex Deymo | 40d86b2 | 2015-09-03 22:27:10 -0700 | [diff] [blame] | 43 | using std::string; | 
|  | 44 |  | 
|  | 45 | namespace chromeos_update_engine { | 
|  | 46 |  | 
| Alex Deymo | fb905d9 | 2016-06-03 19:26:58 -0700 | [diff] [blame] | 47 | namespace { | 
|  | 48 |  | 
| Alex Deymo | ebf6e12 | 2017-03-10 16:12:01 -0800 | [diff] [blame] | 49 | // Android properties that identify the hardware and potentially non-updatable | 
|  | 50 | // parts of the bootloader (such as the bootloader version and the baseband | 
|  | 51 | // version). | 
|  | 52 | const char kPropBootBootloader[] = "ro.boot.bootloader"; | 
|  | 53 | const char kPropBootBaseband[] = "ro.boot.baseband"; | 
|  | 54 | const char kPropProductManufacturer[] = "ro.product.manufacturer"; | 
|  | 55 | const char kPropBootHardwareSKU[] = "ro.boot.hardware.sku"; | 
|  | 56 | const char kPropBootRevision[] = "ro.boot.revision"; | 
| Sen Jiang | 5011df6 | 2017-06-28 17:13:19 -0700 | [diff] [blame] | 57 | const char kPropBuildDateUTC[] = "ro.build.date.utc"; | 
| Alex Deymo | ebf6e12 | 2017-03-10 16:12:01 -0800 | [diff] [blame] | 58 |  | 
| Yifan Hong | fd6640f | 2020-08-27 19:13:17 -0700 | [diff] [blame] | 59 | string GetPartitionBuildDate(const string& partition_name) { | 
|  | 60 | return android::base::GetProperty("ro." + partition_name + ".build.date.utc", | 
|  | 61 | ""); | 
|  | 62 | } | 
|  | 63 |  | 
| Alex Deymo | fb905d9 | 2016-06-03 19:26:58 -0700 | [diff] [blame] | 64 | }  // namespace | 
|  | 65 |  | 
| Alex Deymo | 40d86b2 | 2015-09-03 22:27:10 -0700 | [diff] [blame] | 66 | namespace hardware { | 
|  | 67 |  | 
|  | 68 | // Factory defined in hardware.h. | 
|  | 69 | std::unique_ptr<HardwareInterface> CreateHardware() { | 
| Ben Chan | ab5a0af | 2017-10-12 14:57:50 -0700 | [diff] [blame] | 70 | return std::make_unique<HardwareAndroid>(); | 
| Alex Deymo | 40d86b2 | 2015-09-03 22:27:10 -0700 | [diff] [blame] | 71 | } | 
|  | 72 |  | 
|  | 73 | }  // namespace hardware | 
|  | 74 |  | 
| Alex Deymo | 1c4e84a | 2015-09-22 16:58:10 -0700 | [diff] [blame] | 75 | // In Android there are normally three kinds of builds: eng, userdebug and user. | 
|  | 76 | // These builds target respectively a developer build, a debuggable version of | 
|  | 77 | // the final product and the pristine final product the end user will run. | 
|  | 78 | // Apart from the ro.build.type property name, they differ in the following | 
|  | 79 | // properties that characterize the builds: | 
|  | 80 | // * eng builds: ro.secure=0 and ro.debuggable=1 | 
|  | 81 | // * userdebug builds: ro.secure=1 and ro.debuggable=1 | 
|  | 82 | // * user builds: ro.secure=1 and ro.debuggable=0 | 
|  | 83 | // | 
|  | 84 | // See IsOfficialBuild() and IsNormalMode() for the meaning of these options in | 
|  | 85 | // Android. | 
|  | 86 |  | 
| Alex Deymo | 40d86b2 | 2015-09-03 22:27:10 -0700 | [diff] [blame] | 87 | bool HardwareAndroid::IsOfficialBuild() const { | 
| Alex Deymo | 1c4e84a | 2015-09-22 16:58:10 -0700 | [diff] [blame] | 88 | // We run an official build iff ro.secure == 1, because we expect the build to | 
|  | 89 | // behave like the end user product and check for updates. Note that while | 
|  | 90 | // developers are able to build "official builds" by just running "make user", | 
|  | 91 | // that will only result in a more restrictive environment. The important part | 
|  | 92 | // is that we don't produce and push "non-official" builds to the end user. | 
|  | 93 | // | 
|  | 94 | // In case of a non-bool value, we take the most restrictive option and | 
|  | 95 | // assume we are in an official-build. | 
| Tom Cherry | fadd03c | 2017-10-10 14:45:09 -0700 | [diff] [blame] | 96 | return GetBoolProperty("ro.secure", true); | 
| Alex Deymo | 40d86b2 | 2015-09-03 22:27:10 -0700 | [diff] [blame] | 97 | } | 
|  | 98 |  | 
|  | 99 | bool HardwareAndroid::IsNormalBootMode() const { | 
| Alex Deymo | 1c4e84a | 2015-09-22 16:58:10 -0700 | [diff] [blame] | 100 | // We are running in "dev-mode" iff ro.debuggable == 1. In dev-mode the | 
|  | 101 | // update_engine will allow extra developers options, such as providing a | 
|  | 102 | // different update URL. In case of error, we assume the build is in | 
|  | 103 | // normal-mode. | 
| Tom Cherry | fadd03c | 2017-10-10 14:45:09 -0700 | [diff] [blame] | 104 | return !GetBoolProperty("ro.debuggable", false); | 
| Alex Deymo | 40d86b2 | 2015-09-03 22:27:10 -0700 | [diff] [blame] | 105 | } | 
|  | 106 |  | 
| Sen Jiang | e67bb5b | 2016-06-20 15:53:56 -0700 | [diff] [blame] | 107 | bool HardwareAndroid::AreDevFeaturesEnabled() const { | 
|  | 108 | return !IsNormalBootMode(); | 
|  | 109 | } | 
|  | 110 |  | 
| Alex Deymo | 46a9aae | 2016-05-04 20:20:11 -0700 | [diff] [blame] | 111 | bool HardwareAndroid::IsOOBEEnabled() const { | 
|  | 112 | // No OOBE flow blocking updates for Android-based boards. | 
|  | 113 | return false; | 
|  | 114 | } | 
|  | 115 |  | 
| Alex Deymo | 40d86b2 | 2015-09-03 22:27:10 -0700 | [diff] [blame] | 116 | bool HardwareAndroid::IsOOBEComplete(base::Time* out_time_of_oobe) const { | 
| Alex Deymo | 46a9aae | 2016-05-04 20:20:11 -0700 | [diff] [blame] | 117 | LOG(WARNING) << "OOBE is not enabled but IsOOBEComplete() called."; | 
| Alex Deymo | 4d2990d | 2015-09-15 12:11:26 -0700 | [diff] [blame] | 118 | if (out_time_of_oobe) | 
|  | 119 | *out_time_of_oobe = base::Time(); | 
| Alex Deymo | 40d86b2 | 2015-09-03 22:27:10 -0700 | [diff] [blame] | 120 | return true; | 
|  | 121 | } | 
|  | 122 |  | 
|  | 123 | string HardwareAndroid::GetHardwareClass() const { | 
| Tom Cherry | fadd03c | 2017-10-10 14:45:09 -0700 | [diff] [blame] | 124 | auto manufacturer = GetProperty(kPropProductManufacturer, ""); | 
|  | 125 | auto sku = GetProperty(kPropBootHardwareSKU, ""); | 
|  | 126 | auto revision = GetProperty(kPropBootRevision, ""); | 
| Alex Deymo | ebf6e12 | 2017-03-10 16:12:01 -0800 | [diff] [blame] | 127 |  | 
| Tom Cherry | fadd03c | 2017-10-10 14:45:09 -0700 | [diff] [blame] | 128 | return manufacturer + ":" + sku + ":" + revision; | 
| Alex Deymo | 40d86b2 | 2015-09-03 22:27:10 -0700 | [diff] [blame] | 129 | } | 
|  | 130 |  | 
|  | 131 | string HardwareAndroid::GetFirmwareVersion() const { | 
| Tom Cherry | fadd03c | 2017-10-10 14:45:09 -0700 | [diff] [blame] | 132 | return GetProperty(kPropBootBootloader, ""); | 
| Alex Deymo | 40d86b2 | 2015-09-03 22:27:10 -0700 | [diff] [blame] | 133 | } | 
|  | 134 |  | 
|  | 135 | string HardwareAndroid::GetECVersion() const { | 
| Tom Cherry | fadd03c | 2017-10-10 14:45:09 -0700 | [diff] [blame] | 136 | return GetProperty(kPropBootBaseband, ""); | 
| Alex Deymo | 40d86b2 | 2015-09-03 22:27:10 -0700 | [diff] [blame] | 137 | } | 
|  | 138 |  | 
| Matt Ziegelbaum | aa8e1a4 | 2019-05-09 21:41:58 -0400 | [diff] [blame] | 139 | string HardwareAndroid::GetDeviceRequisition() const { | 
|  | 140 | LOG(WARNING) << "STUB: Getting requisition is not supported."; | 
|  | 141 | return ""; | 
|  | 142 | } | 
|  | 143 |  | 
| Zentaro Kavanagh | baacb98 | 2018-02-20 17:48:39 -0800 | [diff] [blame] | 144 | int HardwareAndroid::GetMinKernelKeyVersion() const { | 
|  | 145 | LOG(WARNING) << "STUB: No Kernel key version is available."; | 
|  | 146 | return -1; | 
|  | 147 | } | 
|  | 148 |  | 
| Marton Hunyady | 99ced78 | 2018-05-08 12:59:50 +0200 | [diff] [blame] | 149 | int HardwareAndroid::GetMinFirmwareKeyVersion() const { | 
|  | 150 | LOG(WARNING) << "STUB: No Firmware key version is available."; | 
|  | 151 | return -1; | 
|  | 152 | } | 
|  | 153 |  | 
| Zentaro Kavanagh | 8f6f243 | 2018-05-16 13:48:12 -0700 | [diff] [blame] | 154 | int HardwareAndroid::GetMaxFirmwareKeyRollforward() const { | 
|  | 155 | LOG(WARNING) << "STUB: Getting firmware_max_rollforward is not supported."; | 
|  | 156 | return -1; | 
|  | 157 | } | 
|  | 158 |  | 
|  | 159 | bool HardwareAndroid::SetMaxFirmwareKeyRollforward( | 
|  | 160 | int firmware_max_rollforward) { | 
|  | 161 | LOG(WARNING) << "STUB: Setting firmware_max_rollforward is not supported."; | 
|  | 162 | return false; | 
|  | 163 | } | 
|  | 164 |  | 
| Zentaro Kavanagh | 5d95615 | 2018-05-15 09:40:33 -0700 | [diff] [blame] | 165 | bool HardwareAndroid::SetMaxKernelKeyRollforward(int kernel_max_rollforward) { | 
|  | 166 | LOG(WARNING) << "STUB: Setting kernel_max_rollforward is not supported."; | 
| Zentaro Kavanagh | baacb98 | 2018-02-20 17:48:39 -0800 | [diff] [blame] | 167 | return false; | 
|  | 168 | } | 
|  | 169 |  | 
| Alex Deymo | 40d86b2 | 2015-09-03 22:27:10 -0700 | [diff] [blame] | 170 | int HardwareAndroid::GetPowerwashCount() const { | 
|  | 171 | LOG(WARNING) << "STUB: Assuming no factory reset was performed."; | 
|  | 172 | return 0; | 
|  | 173 | } | 
|  | 174 |  | 
| Zentaro Kavanagh | 28def4f | 2019-01-15 17:15:01 -0800 | [diff] [blame] | 175 | bool HardwareAndroid::SchedulePowerwash(bool save_rollback_data) { | 
| Alex Deymo | fb905d9 | 2016-06-03 19:26:58 -0700 | [diff] [blame] | 176 | LOG(INFO) << "Scheduling a powerwash to BCB."; | 
| Zentaro Kavanagh | 28def4f | 2019-01-15 17:15:01 -0800 | [diff] [blame] | 177 | LOG_IF(WARNING, save_rollback_data) << "save_rollback_data was true but " | 
|  | 178 | << "isn't supported."; | 
| Sen Jiang | d944faa | 2018-08-22 18:46:39 -0700 | [diff] [blame] | 179 | string err; | 
|  | 180 | if (!update_bootloader_message({"--wipe_data", "--reason=wipe_data_from_ota"}, | 
|  | 181 | &err)) { | 
|  | 182 | LOG(ERROR) << "Failed to update bootloader message: " << err; | 
|  | 183 | return false; | 
|  | 184 | } | 
|  | 185 | return true; | 
| Alex Deymo | fb905d9 | 2016-06-03 19:26:58 -0700 | [diff] [blame] | 186 | } | 
|  | 187 |  | 
|  | 188 | bool HardwareAndroid::CancelPowerwash() { | 
| Sen Jiang | d944faa | 2018-08-22 18:46:39 -0700 | [diff] [blame] | 189 | string err; | 
|  | 190 | if (!clear_bootloader_message(&err)) { | 
|  | 191 | LOG(ERROR) << "Failed to clear bootloader message: " << err; | 
|  | 192 | return false; | 
|  | 193 | } | 
|  | 194 | return true; | 
| Alex Deymo | fb905d9 | 2016-06-03 19:26:58 -0700 | [diff] [blame] | 195 | } | 
|  | 196 |  | 
| Alex Deymo | dd132f3 | 2015-09-14 19:12:07 -0700 | [diff] [blame] | 197 | bool HardwareAndroid::GetNonVolatileDirectory(base::FilePath* path) const { | 
| Sen Jiang | 9c12346 | 2015-11-19 13:16:23 -0800 | [diff] [blame] | 198 | base::FilePath local_path(constants::kNonVolatileDirectory); | 
| Kelvin Zhang | d282252 | 2020-07-07 17:20:58 -0400 | [diff] [blame] | 199 | if (!base::DirectoryExists(local_path)) { | 
| Alex Deymo | dd132f3 | 2015-09-14 19:12:07 -0700 | [diff] [blame] | 200 | LOG(ERROR) << "Non-volatile directory not found: " << local_path.value(); | 
|  | 201 | return false; | 
|  | 202 | } | 
|  | 203 | *path = local_path; | 
|  | 204 | return true; | 
|  | 205 | } | 
|  | 206 |  | 
|  | 207 | bool HardwareAndroid::GetPowerwashSafeDirectory(base::FilePath* path) const { | 
|  | 208 | // On Android, we don't have a directory persisted across powerwash. | 
|  | 209 | return false; | 
|  | 210 | } | 
|  | 211 |  | 
| Sen Jiang | 5011df6 | 2017-06-28 17:13:19 -0700 | [diff] [blame] | 212 | int64_t HardwareAndroid::GetBuildTimestamp() const { | 
| Tom Cherry | fadd03c | 2017-10-10 14:45:09 -0700 | [diff] [blame] | 213 | return GetIntProperty<int64_t>(kPropBuildDateUTC, 0); | 
| Sen Jiang | 5011df6 | 2017-06-28 17:13:19 -0700 | [diff] [blame] | 214 | } | 
|  | 215 |  | 
| Tianjie Xu | 4ad3af6 | 2019-10-30 11:59:45 -0700 | [diff] [blame] | 216 | // Returns true if the device runs an userdebug build, and explicitly allows OTA | 
|  | 217 | // downgrade. | 
|  | 218 | bool HardwareAndroid::AllowDowngrade() const { | 
|  | 219 | return GetBoolProperty("ro.ota.allow_downgrade", false) && | 
|  | 220 | GetBoolProperty("ro.debuggable", false); | 
|  | 221 | } | 
|  | 222 |  | 
| Amin Hassani | 1677e81 | 2017-06-21 13:36:36 -0700 | [diff] [blame] | 223 | bool HardwareAndroid::GetFirstActiveOmahaPingSent() const { | 
|  | 224 | LOG(WARNING) << "STUB: Assuming first active omaha was never set."; | 
|  | 225 | return false; | 
|  | 226 | } | 
|  | 227 |  | 
| Amin Hassani | 80f4d4c | 2018-05-16 13:34:00 -0700 | [diff] [blame] | 228 | bool HardwareAndroid::SetFirstActiveOmahaPingSent() { | 
|  | 229 | LOG(WARNING) << "STUB: Assuming first active omaha is set."; | 
|  | 230 | // We will set it true, so its failure doesn't cause escalation. | 
|  | 231 | return true; | 
| Amin Hassani | 1677e81 | 2017-06-21 13:36:36 -0700 | [diff] [blame] | 232 | } | 
|  | 233 |  | 
| Tianjie Xu | d6aa91f | 2019-11-14 11:55:10 -0800 | [diff] [blame] | 234 | void HardwareAndroid::SetWarmReset(bool warm_reset) { | 
|  | 235 | constexpr char warm_reset_prop[] = "ota.warm_reset"; | 
|  | 236 | if (!android::base::SetProperty(warm_reset_prop, warm_reset ? "1" : "0")) { | 
|  | 237 | LOG(WARNING) << "Failed to set prop " << warm_reset_prop; | 
|  | 238 | } | 
|  | 239 | } | 
|  | 240 |  | 
| Yifan Hong | fd6640f | 2020-08-27 19:13:17 -0700 | [diff] [blame] | 241 | string HardwareAndroid::GetVersionForLogging( | 
|  | 242 | const string& partition_name) const { | 
|  | 243 | if (partition_name == "boot") { | 
|  | 244 | struct utsname buf; | 
|  | 245 | if (uname(&buf) != 0) { | 
|  | 246 | PLOG(ERROR) << "Unable to call uname()"; | 
|  | 247 | return ""; | 
|  | 248 | } | 
|  | 249 | auto kernel_release = | 
|  | 250 | KernelRelease::Parse(buf.release, true /* allow_suffix */); | 
|  | 251 | return kernel_release.has_value() ? kernel_release->string() : ""; | 
|  | 252 | } | 
|  | 253 | return GetPartitionBuildDate(partition_name); | 
| Kelvin Zhang | d719103 | 2020-08-11 10:48:16 -0400 | [diff] [blame] | 254 | } | 
|  | 255 |  | 
| Yifan Hong | 8702933 | 2020-09-01 17:20:08 -0700 | [diff] [blame] | 256 | ErrorCode HardwareAndroid::IsPartitionUpdateValid( | 
| Yifan Hong | fd6640f | 2020-08-27 19:13:17 -0700 | [diff] [blame] | 257 | const string& partition_name, const string& new_version) const { | 
|  | 258 | if (partition_name == "boot") { | 
|  | 259 | struct utsname buf; | 
|  | 260 | if (uname(&buf) != 0) { | 
|  | 261 | PLOG(ERROR) << "Unable to call uname()"; | 
|  | 262 | return ErrorCode::kError; | 
|  | 263 | } | 
|  | 264 | return IsKernelUpdateValid(buf.release, new_version); | 
|  | 265 | } | 
|  | 266 |  | 
|  | 267 | const auto old_version = GetPartitionBuildDate(partition_name); | 
| Kelvin Zhang | d719103 | 2020-08-11 10:48:16 -0400 | [diff] [blame] | 268 | // TODO(zhangkelvin)  for some partitions, missing a current timestamp should | 
|  | 269 | // be an error, e.g. system, vendor, product etc. | 
| Yifan Hong | 8702933 | 2020-09-01 17:20:08 -0700 | [diff] [blame] | 270 | auto error_code = utils::IsTimestampNewer(old_version, new_version); | 
|  | 271 | if (error_code != ErrorCode::kSuccess) { | 
|  | 272 | LOG(ERROR) << "Timestamp check failed with " | 
|  | 273 | << utils::ErrorCodeToString(error_code) | 
|  | 274 | << " Partition timestamp: " << old_version | 
| Kelvin Zhang | d719103 | 2020-08-11 10:48:16 -0400 | [diff] [blame] | 275 | << " Update timestamp: " << new_version; | 
|  | 276 | } | 
| Yifan Hong | 8702933 | 2020-09-01 17:20:08 -0700 | [diff] [blame] | 277 | return error_code; | 
| Kelvin Zhang | d719103 | 2020-08-11 10:48:16 -0400 | [diff] [blame] | 278 | } | 
|  | 279 |  | 
| Yifan Hong | fd6640f | 2020-08-27 19:13:17 -0700 | [diff] [blame] | 280 | ErrorCode HardwareAndroid::IsKernelUpdateValid(const string& old_release, | 
|  | 281 | const string& new_release) { | 
|  | 282 | // Check that the package either contain an empty version (indicating that the | 
|  | 283 | // new build does not use GKI), or a valid GKI kernel release. | 
|  | 284 | std::optional<KernelRelease> new_kernel_release; | 
|  | 285 | if (new_release.empty()) { | 
|  | 286 | LOG(INFO) << "New build does not contain GKI."; | 
|  | 287 | } else { | 
|  | 288 | new_kernel_release = | 
|  | 289 | KernelRelease::Parse(new_release, true /* allow_suffix */); | 
|  | 290 | if (!new_kernel_release.has_value()) { | 
|  | 291 | LOG(ERROR) << "New kernel release is not valid GKI kernel release: " | 
|  | 292 | << new_release; | 
|  | 293 | return ErrorCode::kDownloadManifestParseError; | 
|  | 294 | } | 
|  | 295 | } | 
|  | 296 |  | 
|  | 297 | auto old_kernel_release = | 
|  | 298 | KernelRelease::Parse(old_release, true /* allow_suffix */); | 
|  | 299 | return android::kver::IsKernelUpdateValid(old_kernel_release, | 
|  | 300 | new_kernel_release) | 
|  | 301 | ? ErrorCode::kSuccess | 
|  | 302 | : ErrorCode::kPayloadTimestampError; | 
|  | 303 | } | 
|  | 304 |  | 
| Alex Deymo | 40d86b2 | 2015-09-03 22:27:10 -0700 | [diff] [blame] | 305 | }  // namespace chromeos_update_engine |