update_engine: Send UMA stats about kernel key versions
Adding the following UMA stats:
- UpdateEngine.KernelKey.MinVersion: Minimum kernel key version
already set in the TPM.
- UpdateEngine.KernelKey.MaxRollforwardVersion: Maximum kernel key
rollforward version set by update_engine.
- UpdateEngine.KernelKey.MaxRollforwardSetSuccess: Whether setting
the maximum kernely key rollforward version succeeded.
Chromium CL of the new histograms: crrev.com/c/1078750
BUG=chromium:843622
TEST='cros_run_unit_tests --board=caroline --packages update_engine'
Change-Id: I14192b5ff9c07f8a003e0589450202f488cccc01
Reviewed-on: https://chromium-review.googlesource.com/1078968
Commit-Ready: Zentaro Kavanagh <zentaro@chromium.org>
Tested-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
diff --git a/omaha_request_action.cc b/omaha_request_action.cc
index 72a7d84..03288ff 100644
--- a/omaha_request_action.cc
+++ b/omaha_request_action.cc
@@ -1856,7 +1856,8 @@
}
void OmahaRequestAction::SetMaxKernelKeyVersionForRollback() const {
- bool max_rollforward_set = false;
+ int max_kernel_rollforward;
+ int min_kernel_version = system_state_->hardware()->GetMinKernelKeyVersion();
if (IsRollbackEnabled()) {
// If rollback is enabled, set the max kernel key version to the current
// kernel key version. This has the effect of freezing kernel key roll
@@ -1868,12 +1869,9 @@
// the kernel key version from max_rollback_versions in the past. At that
// point the max kernel key version will be set to that value, creating a
// sliding window of versions that can be rolled back to.
- int min_kernel_version =
- system_state_->hardware()->GetMinKernelKeyVersion();
LOG(INFO) << "Rollback is enabled. Setting kernel_max_rollforward to "
<< min_kernel_version;
- max_rollforward_set = system_state_->hardware()->SetMaxKernelKeyRollforward(
- min_kernel_version);
+ max_kernel_rollforward = min_kernel_version;
} else {
// For devices that are not rollback enabled (ie. consumer devices), the
// max kernel key version is set to 0xfffffffe, which is logically
@@ -1881,13 +1879,18 @@
// versions roll forward each time they are incremented.
LOG(INFO) << "Rollback is disabled. Setting kernel_max_rollforward to "
<< kRollforwardInfinity;
- max_rollforward_set = system_state_->hardware()->SetMaxKernelKeyRollforward(
- kRollforwardInfinity);
+ max_kernel_rollforward = kRollforwardInfinity;
}
+ bool max_rollforward_set =
+ system_state_->hardware()->SetMaxKernelKeyRollforward(
+ max_kernel_rollforward);
if (!max_rollforward_set) {
LOG(ERROR) << "Failed to set kernel_max_rollforward";
}
+ // Report metrics
+ system_state_->metrics_reporter()->ReportKeyVersionMetrics(
+ min_kernel_version, max_kernel_rollforward, max_rollforward_set);
}
} // namespace chromeos_update_engine