commit ecc7f793ede87ef5789c554801e0533deda8acc0
author Gilad Arnold <garnold@chromium.org> Wed Apr 09 12:56:13 2014 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Sat Apr 19 03:36:12 2014 +0000
tree f3f65959c4cc9edf3ff6e370e23a0f1cb0937d97
parent df3dd2438aef108ac66dc42a4eabae8c79ee88a3

PM: RealShillProvider should properly cache the connection type.

This exposes (in unit test) and fixes a bug where the RealShillProvider
neglected to update the cached value of the connection type, although it
was marking this value as valid and used it in subsequent calls.

BUG=None
TEST=Unit test added; fails before, passes after.

Change-Id: Ifbb206adcc82706a786ba1828220bb015badbfbc
Reviewed-on: https://chromium-review.googlesource.com/193872
Reviewed-by: Gilad Arnold <garnold@chromium.org>
Tested-by: Gilad Arnold <garnold@chromium.org>
Reviewed-by: Alex Deymo <deymo@chromium.org>
Commit-Queue: Gilad Arnold <garnold@chromium.org>

policy_manager/variable.h

diff --git a/policy_manager/variable.h b/policy_manager/variable.h
index 2ef0fe1..4507280 100644
--- a/policy_manager/variable.h
+++ b/policy_manager/variable.h
@@ -173,6 +173,7 @@
   FRIEND_TEST(PmRealShillProviderTest, ReadBaseValues);
   FRIEND_TEST(PmRealShillProviderTest, ReadChangedValuesConnectedViaVpn);
   FRIEND_TEST(PmRealShillProviderTest, ReadChangedValuesConnectedTwoSignals);
+  FRIEND_TEST(PmRealShillProviderTest, ConnectionTypeCached);
   FRIEND_TEST(PmRealShillProviderTest, NoInitConnStatusReadBaseValues);
   friend class PmRealTimeProviderTest;
   FRIEND_TEST(PmRealTimeProviderTest, CurrDateValid);