commit e47a2a18104280d79ef8c348ea20c0790df4511e
author Kelvin Zhang <zhangkelvin@google.com> Thu Jan 04 05:36:22 2024 +0000
committer Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> Thu Jan 04 05:36:22 2024 +0000
tree 60899dd48adcfe2541a9e175c5bc8e3c02bf9cae
parent a2ebb243c1cb139633a9477d9a1b10d4ed09ed45
parent d2a298df4129a23a9b47ada5c198131cdfbee7df

Reduce frequency of sync() in update_engine logging am: d2a298df41

Original change: https://android-review.googlesource.com/c/platform/system/update_engine/+/2895963

Change-Id: I1b5ecee4e40d8d1e8254da0d01c13f17deab179e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>

aosp/logging_android.cc

diff --git a/aosp/logging_android.cc b/aosp/logging_android.cc
index 5940f78..1a0fa9a 100644
--- a/aosp/logging_android.cc
+++ b/aosp/logging_android.cc
@@ -124,7 +124,7 @@
   explicit FileLogger(const string& path) {
     fd_.reset(TEMP_FAILURE_RETRY(
         open(path.c_str(),
-             O_WRONLY | O_CREAT | O_TRUNC | O_CLOEXEC | O_NOFOLLOW | O_SYNC,
+             O_WRONLY | O_CREAT | O_TRUNC | O_CLOEXEC | O_NOFOLLOW,
              0644)));
     if (fd_ == -1) {
       // Use ALOGE that logs to logd before __android_log_set_logger.
@@ -155,6 +155,7 @@
     WriteToFd(GetPrefix(log_message));
     WriteToFd(message_str);
     WriteToFd("\n");
+    fsync(fd_);
   }
 
  private: