commit e410e0ff57c820e7d5f5bf6abcea56fe6951111b
author Don Garrett <dgarrett@google.com> Thu Nov 10 15:39:01 2011 -0800
committer Don Garrett <dgarrett@chromium.org> Fri Nov 11 13:22:08 2011 -0800
tree 4817e4a17c879df0bdab8849abba9a6ecdd63d03
parent 5445e162009b2b8a0b1a796bf6b2f5d6f867827a

Switch FileWriter::Write to boolean result code.

FileWriter::Write returned either the number of bytes written, or a negative
error code. No clients were doing anything with the result other than checking
for success or failure, and many clients were considering any non-zero result
success.

So, I changed the API to return less information, but just the information the
clients needed. Success or failure.

BUG=chromium-os:8521
TEST=Unittests

Change-Id: I51513d6aa7b704dc27fb90d5fae4dc7118a3f86c
Reviewed-on: https://gerrit.chromium.org/gerrit/11532
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Commit-Ready: Don Garrett <dgarrett@chromium.org>

file_writer_unittest.cc

diff --git a/file_writer_unittest.cc b/file_writer_unittest.cc
index 6e494ec..1b7b1e6 100644
--- a/file_writer_unittest.cc
+++ b/file_writer_unittest.cc
@@ -22,10 +22,10 @@
 TEST(FileWriterTest, SimpleTest) {
   DirectFileWriter file_writer;
   const string path("/tmp/FileWriterTest");
-  ASSERT_EQ(0, file_writer.Open(path.c_str(),
+  EXPECT_EQ(0, file_writer.Open(path.c_str(),
                                 O_CREAT | O_LARGEFILE | O_TRUNC | O_WRONLY,
                                 0644));
-  ASSERT_EQ(4, file_writer.Write("test", 4));
+  EXPECT_TRUE(file_writer.Write("test", 4));
   vector<char> actual_data;
   EXPECT_TRUE(utils::ReadFile(path, &actual_data));
 
@@ -47,7 +47,7 @@
   EXPECT_EQ(0, file_writer.Open(path.c_str(),
                                 O_CREAT | O_LARGEFILE | O_TRUNC | O_RDONLY,
                                 0644));
-  EXPECT_EQ(-EBADF, file_writer.Write("x", 1));
+  EXPECT_FALSE(file_writer.Write("x", 1));
   EXPECT_EQ(0, file_writer.Close());
 }