Switch FileWriter::Write to boolean result code.
FileWriter::Write returned either the number of bytes written, or a negative
error code. No clients were doing anything with the result other than checking
for success or failure, and many clients were considering any non-zero result
success.
So, I changed the API to return less information, but just the information the
clients needed. Success or failure.
BUG=chromium-os:8521
TEST=Unittests
Change-Id: I51513d6aa7b704dc27fb90d5fae4dc7118a3f86c
Reviewed-on: https://gerrit.chromium.org/gerrit/11532
Reviewed-by: Andrew de los Reyes <adlr@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Commit-Ready: Don Garrett <dgarrett@chromium.org>
diff --git a/download_action_unittest.cc b/download_action_unittest.cc
index bf12326..799d8af 100644
--- a/download_action_unittest.cc
+++ b/download_action_unittest.cc
@@ -81,9 +81,9 @@
TestDirectFileWriter() : fail_write_(0), current_write_(0) {}
void set_fail_write(int fail_write) { fail_write_ = fail_write; }
- virtual ssize_t Write(const void* bytes, size_t count) {
+ virtual bool Write(const void* bytes, size_t count) {
if (++current_write_ == fail_write_) {
- return -EINVAL;
+ return false;
}
return DirectFileWriter::Write(bytes, count);
}