commit e35bb48874997ac24f405d04467b5dbdc58be2f5
author Gilad Arnold <garnold@chromium.org> Tue Feb 11 13:14:37 2014 -0800
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Wed Feb 12 02:05:12 2014 +0000
tree 211699f49396433994693514e5e257f8cff38de6
parent 639aa36fc7e27ba400402cd7a32b091f555783a6

PM: Small fixes to RealRandomProvider unit tests.

Switched to using a scoped_ptr to hold the test object pointer; this
frees us from needing to deallocate it on TearDown().

BUG=None
TEST=Unit tests.

Change-Id: Ic23838d028791f5887f3ed4a5b05abb0f0349c12
Reviewed-on: https://chromium-review.googlesource.com/185943
Tested-by: Gilad Arnold <garnold@chromium.org>
Reviewed-by: Alex Deymo <deymo@chromium.org>
Commit-Queue: Gilad Arnold <garnold@chromium.org>

policy_manager/real_random_provider_unittest.cc

diff --git a/policy_manager/real_random_provider_unittest.cc b/policy_manager/real_random_provider_unittest.cc
index d5ac888..6e3499f 100644
--- a/policy_manager/real_random_provider_unittest.cc
+++ b/policy_manager/real_random_provider_unittest.cc
@@ -19,20 +19,15 @@
     default_timeout_ = TimeDelta::FromSeconds(1);
 
     // The provider initializes correctly.
-    random_ = new RealRandomProvider();
-    ASSERT_TRUE(random_ != NULL);
+    random_.reset(new RealRandomProvider());
+    PMTEST_ASSERT_NOT_NULL(random_.get());
     ASSERT_TRUE(random_->Init());
 
-    (random_->seed());
-  }
-
-  virtual void TearDown() {
-    delete random_;
-    random_ = NULL;
+    random_->seed();
   }
 
   TimeDelta default_timeout_;
-  RealRandomProvider* random_;
+  scoped_ptr<RealRandomProvider> random_;
 };
 
 TEST_F(PmRealRandomProviderTest, InitFinalize) {