commit d2779df63aaad8b65fc5d4badee7dbc9bed7f2b6
author Alex Vakulenko <avakulenko@chromium.org> Mon Jun 16 13:19:00 2014 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Wed Jun 18 01:39:59 2014 +0000
tree e34a511ee4068d8d9cd46a992a4e147f3afbd351
parent b683327ed3f50ef89324069fc87ee076b65bee46

update_engine: fixed warnings from cpplint

Fixed all the cpplint warnings in update engine.

BUG=None
TEST=Unit tests still pass.

Change-Id: I285ae858eec8abe0b26ff203b99a42a200ceb71c
Reviewed-on: https://chromium-review.googlesource.com/204027
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>

subprocess_unittest.cc

diff --git a/subprocess_unittest.cc b/subprocess_unittest.cc
index efda13b..f625519 100644
--- a/subprocess_unittest.cc
+++ b/subprocess_unittest.cc
@@ -66,7 +66,7 @@
   Subprocess::Get().Exec(cmd, CallbackEcho, data);
   return FALSE;
 }
-}  // namespace {}
+}  // namespace
 
 TEST(SubprocessTest, SimpleTest) {
   GMainLoop *loop = g_main_loop_new(g_main_context_default(), FALSE);
@@ -154,7 +154,8 @@
       const char* listening_port_str =
           line + strlen(kServerListeningMsgPrefix);
       char* end_ptr;
-      long raw_port = strtol(listening_port_str, &end_ptr, 10);
+      long raw_port = strtol(listening_port_str,  // NOLINT(runtime/int)
+                             &end_ptr, 10);
       CHECK(!*end_ptr || *end_ptr == '\n');
       local_server_port = static_cast<in_port_t>(raw_port);
       break;
@@ -173,7 +174,7 @@
   Subprocess::Get().CancelExec(tag);
   return FALSE;
 }
-}  // namespace {}
+}  // namespace
 
 gboolean ExitWhenDone(gpointer data) {
   CancelTestData* cancel_test_data = reinterpret_cast<CancelTestData*>(data);