commit cf175a098081f3f0e9ca52d997a7ce1585c14c2d
author Gilad Arnold <garnold@chromium.org> Thu Jul 10 16:48:47 2014 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Fri Jul 11 18:54:57 2014 +0000
tree 2d3dc5048c3a578c3cabf1839d58b3a8d78b3060
parent a1eabcdc93d118146639139257c2f5ccc3ffb061

Fix cpplint errors.

The only non-obvious change here is the switch from dynamic_cast to
static_cast in three cases of down-casting in UpdateAttempter.
dynamic_cast is banned by style, nor does it add any safety in this
particular case (subsequent code dereferences the result right away
without checking whether it's null).

BUG=None
TEST=None

Change-Id: I9d49b46362feaf9c6fa13b2715ebe9fe50308a9a
Reviewed-on: https://chromium-review.googlesource.com/207470
Tested-by: Gilad Arnold <garnold@chromium.org>
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>
Commit-Queue: Gilad Arnold <garnold@chromium.org>

update_manager/fake_updater_provider.h

diff --git a/update_manager/fake_updater_provider.h b/update_manager/fake_updater_provider.h
index 0105801..52b64a0 100644
--- a/update_manager/fake_updater_provider.h
+++ b/update_manager/fake_updater_provider.h
@@ -67,24 +67,33 @@
   }
 
  private:
-  FakeVariable<base::Time> var_updater_started_time_{
-      "updater_started_time", kVariableModePoll};
-  FakeVariable<base::Time> var_last_checked_time_{
-      "last_checked_time", kVariableModePoll};
-  FakeVariable<base::Time> var_update_completed_time_{
-      "update_completed_time", kVariableModePoll};
-  FakeVariable<double> var_progress_{"progress", kVariableModePoll};
-  FakeVariable<Stage> var_stage_{"stage", kVariableModePoll};
-  FakeVariable<std::string> var_new_version_{"new_version", kVariableModePoll};
-  FakeVariable<int64_t> var_payload_size_{"payload_size", kVariableModePoll};
-  FakeVariable<std::string> var_curr_channel_{
-      "curr_channel", kVariableModePoll};
-  FakeVariable<std::string> var_new_channel_{"new_channel", kVariableModePoll};
-  FakeVariable<bool> var_p2p_enabled_{"p2p_enabled", kVariableModePoll};
-  FakeVariable<bool> var_cellular_enabled_{
-      "cellular_enabled", kVariableModePoll};
-  FakeVariable<unsigned int> var_consecutive_failed_update_checks_{
-      "consecutive_failed_update_checks", kVariableModePoll};
+  FakeVariable<base::Time>
+      var_updater_started_time_{  // NOLINT(whitespace/braces)
+    "updater_started_time", kVariableModePoll};
+  FakeVariable<base::Time> var_last_checked_time_{  // NOLINT(whitespace/braces)
+    "last_checked_time", kVariableModePoll};
+  FakeVariable<base::Time>
+      var_update_completed_time_{  // NOLINT(whitespace/braces)
+    "update_completed_time", kVariableModePoll};
+  FakeVariable<double> var_progress_{  // NOLINT(whitespace/braces)
+    "progress", kVariableModePoll};
+  FakeVariable<Stage> var_stage_{  // NOLINT(whitespace/braces)
+    "stage", kVariableModePoll};
+  FakeVariable<std::string> var_new_version_{  // NOLINT(whitespace/braces)
+    "new_version", kVariableModePoll};
+  FakeVariable<int64_t> var_payload_size_{  // NOLINT(whitespace/braces)
+    "payload_size", kVariableModePoll};
+  FakeVariable<std::string> var_curr_channel_{  // NOLINT(whitespace/braces)
+    "curr_channel", kVariableModePoll};
+  FakeVariable<std::string> var_new_channel_{  // NOLINT(whitespace/braces)
+    "new_channel", kVariableModePoll};
+  FakeVariable<bool> var_p2p_enabled_{  // NOLINT(whitespace/braces)
+    "p2p_enabled", kVariableModePoll};
+  FakeVariable<bool> var_cellular_enabled_{  // NOLINT(whitespace/braces)
+    "cellular_enabled", kVariableModePoll};
+  FakeVariable<unsigned int>
+      var_consecutive_failed_update_checks_{  // NOLINT(whitespace/braces)
+    "consecutive_failed_update_checks", kVariableModePoll};
 
   DISALLOW_COPY_AND_ASSIGN(FakeUpdaterProvider);
 };

update_manager/real_updater_provider.cc

diff --git a/update_manager/real_updater_provider.cc b/update_manager/real_updater_provider.cc
index 7863019..6445972 100644
--- a/update_manager/real_updater_provider.cc
+++ b/update_manager/real_updater_provider.cc
@@ -141,8 +141,10 @@
   {update_engine::kUpdateStatusVerifying, Stage::kVerifying},
   {update_engine::kUpdateStatusFinalizing, Stage::kFinalizing},
   {update_engine::kUpdateStatusUpdatedNeedReboot, Stage::kUpdatedNeedReboot},
-  {update_engine::kUpdateStatusReportingErrorEvent,
-   Stage::kReportingErrorEvent},
+  {  // NOLINT(whitespace/braces)
+    update_engine::kUpdateStatusReportingErrorEvent,
+    Stage::kReportingErrorEvent
+  },
   {update_engine::kUpdateStatusAttemptingRollback, Stage::kAttemptingRollback},
 };
 
@@ -310,8 +312,8 @@
 };
 
 // A variable returning the number of consecutive failed update checks.
-class ConsecutiveFailedUpdateChecksVariable :
-    public UpdaterVariableBase<unsigned int> {
+class ConsecutiveFailedUpdateChecksVariable
+    : public UpdaterVariableBase<unsigned int> {
  public:
   using UpdaterVariableBase<unsigned int>::UpdaterVariableBase;