PolicyManager: New DevicePolicy provider.
This provider gives access to the members of the DevicePolicy
protobuf using the libpolicy to access it. The libpolicy doesn't
provide a way to get a notification when the policy was updated, but
that could be fixed on the future monitoring the file on disk. This
patch attempts to refresh the device policy every hour and updates
all the variables accordingly.
The variables exposed by this provider are only those used by the
update_engine code currently. If new variables need to be exposed
this can easily extended.
To achieve this, a new generic Variable class is introduce, named
AsyncCopyVariable, that allows you to Set or Unset the current value
of the variable and notify the subscribed observers while doing that.
BUG=chromium:358326
TEST=Unit tests added and pass.
Change-Id: Ieee6c9b33160f7dfe40c033db685a79d8fd57fe7
Reviewed-on: https://chromium-review.googlesource.com/194179
Reviewed-by: Alex Deymo <deymo@chromium.org>
Tested-by: Alex Deymo <deymo@chromium.org>
Commit-Queue: Alex Deymo <deymo@chromium.org>
diff --git a/policy_manager/variable.h b/policy_manager/variable.h
index bf610c1..ae2b99e 100644
--- a/policy_manager/variable.h
+++ b/policy_manager/variable.h
@@ -57,6 +57,8 @@
LOG(WARNING) << "Variable " << name_ << " deleted with "
<< observer_list_.size() << " observers.";
}
+ DCHECK(observer_list_.empty()) << "Don't destroy the variable without "
+ "removing the observers.";
}
// Returns the variable name as a string.
@@ -172,6 +174,9 @@
// directly from the variable.
friend class EvaluationContext;
+ friend class PmRealDevicePolicyProviderTest;
+ FRIEND_TEST(PmRealDevicePolicyProviderTest,
+ NonExistentDevicePolicyEmptyVariables);
friend class PmRealRandomProviderTest;
FRIEND_TEST(PmRealRandomProviderTest, GetRandomValues);
friend class PmRealShillProviderTest;