commit bfeeb2e85b7881ec16badb0e104c600639102ce2
author Alex Deymo <deymo@chromium.org> Thu Jun 11 20:15:07 2015 -0700
committer ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Fri Jun 12 19:36:32 2015 +0000
tree 9bee306392c7bf6f6c9a9fa6398919611abc4511
parent 218b45f38da5290a76f2f3621b59bb684e80a47c

update_engine: Fix temp file leak in unittest.

This patch removes temp files when the test ends using the
ScopedPathUnlinker.

BUG=None
TEST=Ran unittest; ls /tmp doesn't show these files.

Change-Id: I41d0db07b5f1f08f816a116c5ece5accb9030291
Reviewed-on: https://chromium-review.googlesource.com/277088
Reviewed-by: Gilad Arnold <garnold@chromium.org>
Commit-Queue: Alex Deymo <deymo@chromium.org>
Tested-by: Alex Deymo <deymo@chromium.org>

payload_generator/delta_diff_generator_unittest.cc

diff --git a/payload_generator/delta_diff_generator_unittest.cc b/payload_generator/delta_diff_generator_unittest.cc
index baf308f..187da7a 100644
--- a/payload_generator/delta_diff_generator_unittest.cc
+++ b/payload_generator/delta_diff_generator_unittest.cc
@@ -88,6 +88,7 @@
   string part_path;
   EXPECT_TRUE(utils::MakeTempFile(
       "SplitReplaceOrReplaceBzTest_part.XXXXXX", &part_path, nullptr));
+  ScopedPathUnlinker part_path_unlinker(part_path);
   const size_t part_size = part_num_blocks * kBlockSize;
   chromeos::Blob part_data;
   if (compressible) {
@@ -139,6 +140,7 @@
   string data_path;
   EXPECT_TRUE(utils::MakeTempFile(
       "SplitReplaceOrReplaceBzTest_data.XXXXXX", &data_path, nullptr));
+  ScopedPathUnlinker data_path_unlinker(data_path);
   int data_fd = open(data_path.c_str(), O_RDWR, 000);
   EXPECT_GE(data_fd, 0);
   ScopedFdCloser data_fd_closer(&data_fd);
@@ -240,6 +242,7 @@
   string part_path;
   EXPECT_TRUE(utils::MakeTempFile(
       "MergeReplaceOrReplaceBzTest_part.XXXXXX", &part_path, nullptr));
+  ScopedPathUnlinker part_path_unlinker(part_path);
   const size_t part_size = part_num_blocks * kBlockSize;
   chromeos::Blob part_data;
   if (compressible) {
@@ -307,6 +310,7 @@
   string data_path;
   EXPECT_TRUE(utils::MakeTempFile(
       "MergeReplaceOrReplaceBzTest_data.XXXXXX", &data_path, nullptr));
+  ScopedPathUnlinker data_path_unlinker(data_path);
   int data_fd = open(data_path.c_str(), O_RDWR, 000);
   EXPECT_GE(data_fd, 0);
   ScopedFdCloser data_fd_closer(&data_fd);
@@ -740,6 +744,7 @@
   string orig_blobs;
   EXPECT_TRUE(utils::MakeTempFile("ReorderBlobsTest.orig.XXXXXX", &orig_blobs,
                                   nullptr));
+  ScopedPathUnlinker orig_blobs_unlinker(orig_blobs);
 
   string orig_data = "abcd";
   EXPECT_TRUE(
@@ -748,6 +753,7 @@
   string new_blobs;
   EXPECT_TRUE(
       utils::MakeTempFile("ReorderBlobsTest.new.XXXXXX", &new_blobs, nullptr));
+  ScopedPathUnlinker new_blobs_unlinker(new_blobs);
 
   DeltaArchiveManifest manifest;
   DeltaArchiveManifest_InstallOperation* op =
@@ -770,9 +776,6 @@
   EXPECT_EQ(3, manifest.install_operations(0).data_length());
   EXPECT_EQ(3, manifest.install_operations(1).data_offset());
   EXPECT_EQ(1, manifest.install_operations(1).data_length());
-
-  unlink(orig_blobs.c_str());
-  unlink(new_blobs.c_str());
 }
 
 TEST_F(DeltaDiffGeneratorTest, IsNoopOperationTest) {