commit b108b608030bed6677cb86589a9df02a7df181c1
author Alex Deymo <deymo@google.com> Tue Mar 29 17:23:33 2016 -0700
committer Alex Deymo <deymo@google.com> Mon Apr 11 15:42:21 2016 -0700
tree 607a5d39f763854b071f62a8fb069e0378540358
parent e67041c5858816c903efe2cea4a422bc4bed01a3

Subprocess: Close all unused file descriptors.

This patch extends Subprocess::ExecFlags() method with a list of
file descriptors that should be kept open on the child process and
mapped to a pipe() in the parent. The remaining file descriptors
will be closed.

Bug: 27880754
TEST=Added unittests for this functionality.

(cherry picked from commit e384bb2e403b0f0f666e89d5f6acfaec41120cc5)

Change-Id: I06fe529c58e179315e5a740d03c43c3b2d852526

p2p_manager.cc

diff --git a/p2p_manager.cc b/p2p_manager.cc
index 734918d..127e5ff 100644
--- a/p2p_manager.cc
+++ b/p2p_manager.cc
@@ -396,7 +396,7 @@
 
     // We expect to run just "p2p-client" and find it in the path.
     child_pid_ = Subprocess::Get().ExecFlags(
-        cmd, Subprocess::kSearchPath,
+        cmd, Subprocess::kSearchPath, {},
         Bind(&LookupData::OnLookupDone, base::Unretained(this)));
 
     if (!child_pid_) {