commit ad92373f42fdf5cdf65774376ee176b9da92ff3b
author Alex Deymo <deymo@chromium.org> Thu Aug 29 16:13:49 2013 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Tue Sep 03 23:37:41 2013 +0000
tree 60036acb66e98081c01d44d5a8cd171061650811
parent 36dc2f34ebb67ff2c58e9798bf021d6ffa5bbf5b

Replace bool by gboolean on DBus generated calls.

The code generated for use with dbus-glib expects the boolean "b"
arguments to receive a gboolean variable and not a bool. This is
problem for both gboolean* and gboolean arguments because
sizeof(gboolean) is typically 4 while sizeof(bool) is 1. This can
led to uninitialized memory or segmentation faults.

BUG=None
TEST=update_engine_client calls still work.

Change-Id: I4036d63c875859fd73f2ff5a1585494ebe4d3603
Reviewed-on: https://chromium-review.googlesource.com/167526
Reviewed-by: David Zeuthen <zeuthen@chromium.org>
Tested-by: Alex Deymo <deymo@chromium.org>
Commit-Queue: Alex Deymo <deymo@chromium.org>

dbus_service.cc

diff --git a/dbus_service.cc b/dbus_service.cc
index 65023e9..97ce226 100644
--- a/dbus_service.cc
+++ b/dbus_service.cc
@@ -108,7 +108,7 @@
 }
 
 gboolean update_engine_service_attempt_rollback(UpdateEngineService* self,
-                                                bool powerwash,
+                                                gboolean powerwash,
                                                 GError **error) {
   LOG(INFO) << "Attempting rollback to non-active partitions.";
   return self->system_state_->update_attempter()->Rollback(powerwash, NULL);
@@ -157,7 +157,7 @@
 
 gboolean update_engine_service_set_channel(UpdateEngineService* self,
                                            gchar* target_channel,
-                                           bool is_powerwash_allowed,
+                                           gboolean is_powerwash_allowed,
                                            GError **error) {
   if (!target_channel)
     return FALSE;
@@ -195,7 +195,7 @@
 }
 
 gboolean update_engine_service_get_channel(UpdateEngineService* self,
-                                           bool get_current_channel,
+                                           gboolean get_current_channel,
                                            gchar** channel,
                                            GError **error) {
   chromeos_update_engine::OmahaRequestParams* rp =
@@ -258,7 +258,7 @@
 
 gboolean update_engine_service_set_update_over_cellular_permission(
     UpdateEngineService* self,
-    bool allowed,
+    gboolean allowed,
     GError **error) {
   set<string> allowed_types;
   const policy::DevicePolicy* device_policy =
@@ -303,7 +303,7 @@
 
 gboolean update_engine_service_get_update_over_cellular_permission(
     UpdateEngineService* self,
-    bool* allowed,
+    gboolean* allowed,
     GError **/*error*/) {
   chromeos_update_engine::ConnectionManager* cm =
       self->system_state_->connection_manager();