Move MarkBootSuccessful to BootControlInterface.
Updating the boot flags to mark the current boot as successful is
platform-specific and part of the BootControlInterface's job. This
patch moves this to a new async method in this interface.
Bug: 24077637
Test: FEATURES=test emerge-link update_engine; cros flash in Chrome OS; tested on a dragonboard.
Change-Id: I23c3ed915dd8d2588a90d84b212bb04977957975
diff --git a/update_attempter.h b/update_attempter.h
index 12da537..06a3dac 100644
--- a/update_attempter.h
+++ b/update_attempter.h
@@ -124,8 +124,8 @@
// attempt goes through this method.
void UpdateBootFlags();
- // Subprocess::Exec callback.
- void CompleteUpdateBootFlags(int return_code, const std::string& output);
+ // Called when the boot flags have been updated.
+ void CompleteUpdateBootFlags(bool success);
UpdateStatus status() const { return status_; }
@@ -473,10 +473,6 @@
// True if UpdateBootFlags is running.
bool update_boot_flags_running_ = false;
- // Whether we should skip the async call to "setgoodkernel" command. Used in
- // unittests.
- bool skip_set_good_kernel_ = false;
-
// True if the action processor needs to be started by the boot flag updater.
bool start_action_processor_ = false;