update_engine: Remove --install and --dlc_module_ids flags
--install flag was added to install DLCs, but now dlcservice can
actually send D-Bus signal to update_engine for installing DLCs and we
already have a dlcservice_util binary that can help with that. So remove
these two flags so no one else start using them. These flags are not
actively being used anywhere.
BUG=none
TEST=precq
Change-Id: Ifa76c45336581e0dc97a27d6d577692a74853c94
Reviewed-on: https://chromium-review.googlesource.com/1528929
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-by: Xiaochu Liu <xiaochu@chromium.org>
diff --git a/update_engine_client.cc b/update_engine_client.cc
index 7446041..d1b2267 100644
--- a/update_engine_client.cc
+++ b/update_engine_client.cc
@@ -321,8 +321,6 @@
"Show the previous OS version used before the update reboot.");
DEFINE_bool(last_attempt_error, false, "Show the last attempt error.");
DEFINE_bool(eol_status, false, "Show the current end-of-life status.");
- DEFINE_bool(install, false, "Requests an install.");
- DEFINE_string(dlc_module_ids, "", "colon-separated list of DLC IDs.");
// Boilerplate init commands.
base::CommandLine::Init(argc_, argv_);
@@ -507,30 +505,6 @@
}
}
- if (FLAGS_install) {
- // Parse DLC module IDs.
- vector<string> dlc_module_ids;
- if (!FLAGS_dlc_module_ids.empty()) {
- dlc_module_ids = base::SplitString(FLAGS_dlc_module_ids,
- ":",
- base::TRIM_WHITESPACE,
- base::SPLIT_WANT_ALL);
- }
- if (dlc_module_ids.empty()) {
- LOG(ERROR) << "dlc_module_ids is empty:" << FLAGS_dlc_module_ids;
- return 1;
- }
- if (!client_->AttemptInstall(FLAGS_omaha_url, dlc_module_ids)) {
- LOG(ERROR) << "AttemptInstall failed.";
- return 1;
- }
- return 0;
- } else if (!FLAGS_dlc_module_ids.empty()) {
- LOG(ERROR) << "dlc_module_ids is not empty while install is not set:"
- << FLAGS_dlc_module_ids;
- return 1;
- }
-
// Initiate an update check, if necessary.
if (do_update_request) {
LOG_IF(WARNING, FLAGS_reboot) << "-reboot flag ignored.";
@@ -539,7 +513,7 @@
app_version = "ForcedUpdate";
LOG(INFO) << "Forcing an update by setting app_version to ForcedUpdate.";
}
- LOG(INFO) << "Initiating update check and install.";
+ LOG(INFO) << "Initiating update check.";
if (!client_->AttemptUpdate(
app_version, FLAGS_omaha_url, FLAGS_interactive)) {
LOG(ERROR) << "Error checking for update.";