commit a178e5e6efc0849e286b9275d3b052ada6b1a43f
author Yunlian Jiang <yunlian@google.com> Fri Apr 05 14:41:56 2013 -0700
committer ChromeBot <chrome-bot@google.com> Tue Apr 09 12:13:16 2013 -0700
tree f62654a00be9fa101cadee850136bc7fd0dc9232
parent 7f2ec75d94ede532d487999a30357d8682581496

Fix the confict of declaration and definition between struct and class

This fixes the error when compiling with clang syntax checking
The error message was:
/update_engine/test_utils.h:188:1: error: 'ObjectFeederAction'
defined as a struct template here but previously declared as a
class template [-Werror,-Wmismatched-tags]

BUG=chromium:218781
TEST=USE="chrome_internal" CXXFLAGS="-clang -print-cmdline"
     CFLAGS="-clang -print-cmdline" emerge-x86-alex update_engine

Change-Id: Ieac9981c84c4e5779cbf876650f21a5d1b2acd72
Reviewed-on: https://gerrit.chromium.org/gerrit/47476
Reviewed-by: Jay Srinivasan <jaysri@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Commit-Queue: Yunlian Jiang <yunlian@chromium.org>

action_pipe_unittest.cc

diff --git a/action_pipe_unittest.cc b/action_pipe_unittest.cc
index b0a96b7..0f777fb 100644
--- a/action_pipe_unittest.cc
+++ b/action_pipe_unittest.cc
@@ -23,7 +23,8 @@
 };
 
 // This is a simple Action class for testing.
-struct ActionPipeTestAction : public Action<ActionPipeTestAction> {
+class ActionPipeTestAction : public Action<ActionPipeTestAction> {
+ public:
   typedef string InputObjectType;
   typedef string OutputObjectType;
   ActionPipe<string>* in_pipe() { return in_pipe_.get(); }

action_processor_unittest.cc

diff --git a/action_processor_unittest.cc b/action_processor_unittest.cc
index 7f39149..20a79af 100644
--- a/action_processor_unittest.cc
+++ b/action_processor_unittest.cc
@@ -23,7 +23,8 @@
 };
 
 // This is a simple Action class for testing.
-struct ActionProcessorTestAction : public Action<ActionProcessorTestAction> {
+class ActionProcessorTestAction : public Action<ActionProcessorTestAction> {
+ public:
   typedef string InputObjectType;
   typedef string OutputObjectType;
   ActionPipe<string>* in_pipe() { return in_pipe_.get(); }

action_unittest.cc

diff --git a/action_unittest.cc b/action_unittest.cc
index 8bb94ca..af0e130 100644
--- a/action_unittest.cc
+++ b/action_unittest.cc
@@ -23,7 +23,8 @@
 };
 
 // This is a simple Action class for testing.
-struct ActionTestAction : public Action<ActionTestAction> {
+class ActionTestAction : public Action<ActionTestAction> {
+ public:
   typedef string InputObjectType;
   typedef string OutputObjectType;
   ActionPipe<string>* in_pipe() { return in_pipe_.get(); }

omaha_request_action.h

diff --git a/omaha_request_action.h b/omaha_request_action.h
index a75139e..528ce19 100644
--- a/omaha_request_action.h
+++ b/omaha_request_action.h
@@ -71,7 +71,7 @@
 
 class NoneType;
 class OmahaRequestAction;
-struct OmahaRequestParams;
+class OmahaRequestParams;
 class PrefsInterface;
 
 template<>

test_utils.h

diff --git a/test_utils.h b/test_utils.h
index 8305c14..30f1f89 100644
--- a/test_utils.h
+++ b/test_utils.h
@@ -185,7 +185,7 @@
 // This is a simple Action class for testing. It feeds an object into
 // another action.
 template<typename T>
-struct ObjectFeederAction : public Action<ObjectFeederAction<T> > {
+class ObjectFeederAction : public Action<ObjectFeederAction<T> > {
  public:
   typedef NoneType InputObjectType;
   typedef T OutputObjectType;
@@ -219,7 +219,7 @@
 // This is a simple Action class for testing. It receives an object from
 // another action.
 template<typename T>
-struct ObjectCollectorAction : public Action<ObjectCollectorAction<T> > {
+class ObjectCollectorAction : public Action<ObjectCollectorAction<T> > {
  public:
   typedef T InputObjectType;
   typedef NoneType OutputObjectType;