commit 89b9a2d738d37fb5352cd9bb3cfe960cc0cdb954
author Amin Hassani <ahassani@chromium.org> Fri Apr 20 16:01:45 2018 -0700
committer chrome-bot <chrome-bot@chromium.org> Wed Apr 25 14:40:55 2018 -0700
tree 052b89994b724b1ee827284596050a81a3612933
parent 6479359a91e0082646a520a846fa606beca3ba21

update_engine_client: Change bit-wise OR to logical OR for flags

bitwise OR doesn't really make sense on input boolean flags even though it will
work. It should be logical OR.

BUG=none
TEST=unittests
TEST=update_engine_client --update

Change-Id: If343302cf795ef7e576791dbeeed557f24f5df98
Reviewed-on: https://chromium-review.googlesource.com/1022973
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>

update_engine_client.cc

diff --git a/update_engine_client.cc b/update_engine_client.cc
index bb19632..c41916d 100644
--- a/update_engine_client.cc
+++ b/update_engine_client.cc
@@ -458,8 +458,8 @@
       LOG(INFO) << "Target Channel (pending update): " << target_channel;
   }
 
-  bool do_update_request = FLAGS_check_for_update | FLAGS_update |
-                           !FLAGS_app_version.empty() |
+  bool do_update_request = FLAGS_check_for_update || FLAGS_update ||
+                           !FLAGS_app_version.empty() ||
                            !FLAGS_omaha_url.empty();
   if (FLAGS_update) FLAGS_follow = true;