commit 88b591f24cb3f94f982d7024c2e8ed25c2cc26a2
author Alex Vakulenko <avakulenko@chromium.org> Thu Aug 28 16:48:57 2014 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Mon Sep 01 11:05:16 2014 +0000
tree d49741d0b0926c4c387e9d618b990ae89e6d2f8e
parent f3e2801f18bae14e41099e007de7c9a019735556

update_engine: Replace NULL with nullptr

Replaced the usage of NULL with nullptr. This also makes it possible to
use standard gtest macros to compare pointers in Update Manager's unit tests.
So, there is no need in custom UMTEST_... macros which are replaced with the
gtest macros (see change in update_engine/update_manager/umtest_utils.h):

UMTEST_ASSERT_NULL(p)      => ASSERT_EQ(nullptr, p)
UMTEST_ASSERT_NOT_NULL(p)  => ASSERT_NE(nullptr, p)
UMTEST_EXPECT_NULL(p)      => EXPECT_EQ(nullptr, p)
UMTEST_EXPECT_NOT_NULL(p)  => EXPECT_NE(nullptr, p)

BUG=None
TEST=FEATURES=test emerge-link update_engine
     USE="clang asan" FEATURES=test emerge-link update_engine

Change-Id: I77a42a1e9ce992bb2f9f263db5cf75fe6110a4ec
Reviewed-on: https://chromium-review.googlesource.com/215136
Tested-by: Alex Vakulenko <avakulenko@chromium.org>
Reviewed-by: Alex Deymo <deymo@chromium.org>
Commit-Queue: Alex Vakulenko <avakulenko@chromium.org>

download_action_unittest.cc

diff --git a/download_action_unittest.cc b/download_action_unittest.cc
index e061782..97dd0f3 100644
--- a/download_action_unittest.cc
+++ b/download_action_unittest.cc
@@ -48,7 +48,7 @@
 class DownloadActionTestProcessorDelegate : public ActionProcessorDelegate {
  public:
   explicit DownloadActionTestProcessorDelegate(ErrorCode expected_code)
-      : loop_(NULL),
+      : loop_(nullptr),
         processing_done_called_(false),
         expected_code_(expected_code) {}
   virtual ~DownloadActionTestProcessorDelegate() {
@@ -156,9 +156,9 @@
   PrefsMock prefs;
   MockHttpFetcher* http_fetcher = new MockHttpFetcher(&data[0],
                                                       data.size(),
-                                                      NULL);
+                                                      nullptr);
   // takes ownership of passed in HttpFetcher
-  DownloadAction download_action(&prefs, NULL, http_fetcher);
+  DownloadAction download_action(&prefs, nullptr, http_fetcher);
   download_action.SetTestFileWriter(&writer);
   BondActions(&feeder_action, &download_action);
   DownloadActionDelegateMock download_delegate;
@@ -269,10 +269,10 @@
                              temp_file.GetPath(), "", "");
     feeder_action.set_obj(install_plan);
     PrefsMock prefs;
-    DownloadAction download_action(&prefs, NULL,
+    DownloadAction download_action(&prefs, nullptr,
                                    new MockHttpFetcher(&data[0],
                                                        data.size(),
-                                                       NULL));
+                                                       nullptr));
     download_action.SetTestFileWriter(&writer);
     DownloadActionDelegateMock download_delegate;
     if (use_download_delegate) {
@@ -380,8 +380,8 @@
   ObjectFeederAction<InstallPlan> feeder_action;
   feeder_action.set_obj(install_plan);
   PrefsMock prefs;
-  DownloadAction download_action(&prefs, NULL,
-                                 new MockHttpFetcher("x", 1, NULL));
+  DownloadAction download_action(&prefs, nullptr,
+                                 new MockHttpFetcher("x", 1, nullptr));
   download_action.SetTestFileWriter(&writer);
 
   DownloadActionTestAction test_action;
@@ -415,8 +415,8 @@
   ObjectFeederAction<InstallPlan> feeder_action;
   feeder_action.set_obj(install_plan);
   PrefsMock prefs;
-  DownloadAction download_action(&prefs, NULL,
-                                 new MockHttpFetcher("x", 1, NULL));
+  DownloadAction download_action(&prefs, nullptr,
+                                 new MockHttpFetcher("x", 1, nullptr));
   download_action.SetTestFileWriter(&writer);
 
   BondActions(&feeder_action, &download_action);
@@ -440,7 +440,7 @@
 class P2PDownloadActionTest : public testing::Test {
  protected:
   P2PDownloadActionTest()
-    : loop_(NULL),
+    : loop_(nullptr),
       start_at_offset_(0) {}
 
   virtual ~P2PDownloadActionTest() {}
@@ -452,7 +452,7 @@
 
   // Derived from testing::Test.
   virtual void TearDown() {
-    if (loop_ != NULL)
+    if (loop_ != nullptr)
       g_main_loop_unref(loop_);
   }
 
@@ -467,7 +467,7 @@
 
     // Setup p2p.
     FakeP2PManagerConfiguration *test_conf = new FakeP2PManagerConfiguration();
-    p2p_manager_.reset(P2PManager::Construct(test_conf, NULL, "cros_au", 3));
+    p2p_manager_.reset(P2PManager::Construct(test_conf, nullptr, "cros_au", 3));
     fake_system_state_.set_p2p_manager(p2p_manager_.get());
   }
 
@@ -495,7 +495,7 @@
     PrefsMock prefs;
     http_fetcher_ = new MockHttpFetcher(data_.c_str(),
                                         data_.length(),
-                                        NULL);
+                                        nullptr);
     // Note that DownloadAction takes ownership of the passed in HttpFetcher.
     download_action_.reset(new DownloadAction(&prefs, &fake_system_state_,
                                               http_fetcher_));