commit 6e5ab5c011a214aa345ecbba3d910c2ffaec3c83
author Gilad Arnold <garnold@chromium.org> Mon Jun 23 15:13:56 2014 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Tue Jul 15 18:41:22 2014 +0000
tree 6255e01b7a59c327dba6da9240105ff35b86dd3b
parent f9f85d6680164064648ce3ed1d31589e1f1b7a29

UM: Dump the EvaluationContext when evaluation of a policy fails.

This gives the log reader a complete picture of the state of variables
at the time when a policy evaluation has failed.

We slightly revise the JSON output of EvaluationContext::DumpContext()
to remove trailing whitespaces (newline, etc).

BUG=chromium:387937
TEST=Observed context dumping during unit testing.

Change-Id: I33712a896225f3be97bc313468f89f9cd724673b
Reviewed-on: https://chromium-review.googlesource.com/205896
Reviewed-by: Gilad Arnold <garnold@chromium.org>
Tested-by: Gilad Arnold <garnold@chromium.org>
Commit-Queue: Gilad Arnold <garnold@chromium.org>

update_manager/evaluation_context_unittest.cc

diff --git a/update_manager/evaluation_context_unittest.cc b/update_manager/evaluation_context_unittest.cc
index ab07a12..eafb219 100644
--- a/update_manager/evaluation_context_unittest.cc
+++ b/update_manager/evaluation_context_unittest.cc
@@ -400,7 +400,7 @@
             "      \"fake_int\": \"42\",\n"
             "      \"fake_poll\": \"Hello \\\"world\\\"!\"\n"
             "   }\n"
-            "}\n",
+            "}",
             eval_ctx_->DumpContext());
 }