commit 684219dc29acb0111d09aaf2d466cf837b043d9e
author Gilad Arnold <garnold@chromium.org> Mon Jul 07 14:54:57 2014 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Wed Jul 09 20:29:39 2014 +0000
tree 6542e6728f7b4fe1205da67e52fb82bb4cb71afc
parent e74c60ff392ad598c364d3895a994e7b3a5cd9be

UpdateManager: rename UpdateCurrentConnectionAllowed into UpdateDownloadAllowed.

The signifies the *functional* nature of this policy request, instead of
dwelling on the low-level information it is evaluating.

BUG=chromium:389677
TEST=Unit tests.

Change-Id: I684ea13d4e89554b6a4d596666c18e2dbd609991
Reviewed-on: https://chromium-review.googlesource.com/206903
Tested-by: Gilad Arnold <garnold@chromium.org>
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>
Commit-Queue: Gilad Arnold <garnold@chromium.org>

update_manager/chromeos_policy_unittest.cc

diff --git a/update_manager/chromeos_policy_unittest.cc b/update_manager/chromeos_policy_unittest.cc
index 6c6eeff..0d19720 100644
--- a/update_manager/chromeos_policy_unittest.cc
+++ b/update_manager/chromeos_policy_unittest.cc
@@ -47,7 +47,7 @@
     fake_state_.updater_provider()->var_last_checked_time()->reset(
         new Time(fake_clock_.GetWallclockTime()));
     fake_state_.updater_provider()->var_consecutive_failed_update_checks()->
-        reset(new unsigned int(0));
+        reset(new unsigned int(0));  // NOLINT(readability/casting)
 
     fake_state_.random_provider()->var_seed()->reset(
         new uint64_t(4));  // chosen by fair dice roll.
@@ -160,7 +160,7 @@
   Time next_update_check;
 
   fake_state_.updater_provider()->var_consecutive_failed_update_checks()->
-      reset(new unsigned int(100));
+      reset(new unsigned int(100));  // NOLINT(readability/casting)
   ExpectPolicyStatus(EvalStatus::kSucceeded,
                      &ChromeOSPolicy::NextUpdateCheckTime, &next_update_check);
 
@@ -700,7 +700,7 @@
   EXPECT_EQ(0, result.download_url_num_failures);
 }
 
-TEST_F(UmChromeOSPolicyTest, UpdateCurrentConnectionAllowedEthernetDefault) {
+TEST_F(UmChromeOSPolicyTest, UpdateDownloadAllowedEthernetDefault) {
   // Ethernet is always allowed.
 
   fake_state_.shill_provider()->var_conn_type()->
@@ -708,11 +708,11 @@
 
   bool result;
   ExpectPolicyStatus(EvalStatus::kSucceeded,
-                     &Policy::UpdateCurrentConnectionAllowed, &result);
+                     &Policy::UpdateDownloadAllowed, &result);
   EXPECT_TRUE(result);
 }
 
-TEST_F(UmChromeOSPolicyTest, UpdateCurrentConnectionAllowedWifiDefault) {
+TEST_F(UmChromeOSPolicyTest, UpdateDownloadAllowedWifiDefault) {
   // Wifi is allowed if not tethered.
 
   fake_state_.shill_provider()->var_conn_type()->
@@ -720,7 +720,7 @@
 
   bool result;
   ExpectPolicyStatus(EvalStatus::kSucceeded,
-                     &Policy::UpdateCurrentConnectionAllowed, &result);
+                     &Policy::UpdateDownloadAllowed, &result);
   EXPECT_TRUE(result);
 }
 
@@ -735,12 +735,12 @@
 
   bool result;
   ExpectPolicyStatus(EvalStatus::kSucceeded,
-                     &Policy::UpdateCurrentConnectionAllowed, &result);
+                     &Policy::UpdateDownloadAllowed, &result);
   EXPECT_FALSE(result);
 }
 
 TEST_F(UmChromeOSPolicyTest,
-       UpdateCurrentConnectionAllowedWifiTetheredPolicyOverride) {
+       UpdateDownloadAllowedWifiTetheredPolicyOverride) {
   // Tethered wifi can be allowed by policy.
 
   fake_state_.shill_provider()->var_conn_type()->
@@ -755,11 +755,11 @@
 
   bool result;
   ExpectPolicyStatus(EvalStatus::kSucceeded,
-                     &Policy::UpdateCurrentConnectionAllowed, &result);
+                     &Policy::UpdateDownloadAllowed, &result);
   EXPECT_TRUE(result);
 }
 
-TEST_F(UmChromeOSPolicyTest, UpdateCurrentConnectionAllowedWimaxDefault) {
+TEST_F(UmChromeOSPolicyTest, UpdateDownloadAllowedWimaxDefault) {
   // Wimax is always allowed.
 
   fake_state_.shill_provider()->var_conn_type()->
@@ -767,7 +767,7 @@
 
   bool result;
   ExpectPolicyStatus(EvalStatus::kSucceeded,
-                     &Policy::UpdateCurrentConnectionAllowed, &result);
+                     &Policy::UpdateDownloadAllowed, &result);
   EXPECT_TRUE(result);
 }
 
@@ -780,7 +780,7 @@
 
   bool result;
   ExpectPolicyStatus(EvalStatus::kSucceeded,
-                     &Policy::UpdateCurrentConnectionAllowed, &result);
+                     &Policy::UpdateDownloadAllowed, &result);
   EXPECT_FALSE(result);
 }
 
@@ -798,7 +798,7 @@
 
   bool result;
   ExpectPolicyStatus(EvalStatus::kSucceeded,
-                     &Policy::UpdateCurrentConnectionAllowed, &result);
+                     &Policy::UpdateDownloadAllowed, &result);
   EXPECT_FALSE(result);
 }
 
@@ -810,12 +810,12 @@
 
   bool result;
   ExpectPolicyStatus(EvalStatus::kSucceeded,
-                     &Policy::UpdateCurrentConnectionAllowed, &result);
+                     &Policy::UpdateDownloadAllowed, &result);
   EXPECT_FALSE(result);
 }
 
 TEST_F(UmChromeOSPolicyTest,
-       UpdateCurrentConnectionAllowedCellularPolicyOverride) {
+       UpdateDownloadAllowedCellularPolicyOverride) {
   // Update over cellular can be enabled by policy.
 
   fake_state_.shill_provider()->var_conn_type()->
@@ -828,12 +828,12 @@
 
   bool result;
   ExpectPolicyStatus(EvalStatus::kSucceeded,
-                     &Policy::UpdateCurrentConnectionAllowed, &result);
+                     &Policy::UpdateDownloadAllowed, &result);
   EXPECT_TRUE(result);
 }
 
 TEST_F(UmChromeOSPolicyTest,
-       UpdateCurrentConnectionAllowedCellularUserOverride) {
+       UpdateDownloadAllowedCellularUserOverride) {
   // Update over cellular can be enabled by user settings, but only if policy
   // is present and does not determine allowed connections.
 
@@ -846,7 +846,7 @@
 
   bool result;
   ExpectPolicyStatus(EvalStatus::kSucceeded,
-                     &Policy::UpdateCurrentConnectionAllowed, &result);
+                     &Policy::UpdateDownloadAllowed, &result);
   EXPECT_TRUE(result);
 }