commit 680d022b08b1368ddbea970a75ebff7c642f2621
author Alex Deymo <deymo@chromium.org> Thu Apr 24 21:00:08 2014 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Sat Apr 26 02:46:14 2014 +0000
tree cbd2145701df39e64784351bbe15ea5127357177
parent 77a7fa79240edfab54ca25b3851e1d3b23a3329b

PolicyManager: Remove unnecessary Init() methods.

The PolicyManager::Init() method always return true as it can't
really fail. This patch removes it and simplifies the interface
on the FakePolicyManager to make it easier to use it on Policy
unit testing exposing the FakeState there.

BUG=chromium:358269
TEST=Build and unittests.

Change-Id: Ib27dd41a483b10f164810e18585a8e4b4cb92f5a
Reviewed-on: https://chromium-review.googlesource.com/196968
Tested-by: Alex Deymo <deymo@chromium.org>
Reviewed-by: Gilad Arnold <garnold@chromium.org>
Commit-Queue: Alex Deymo <deymo@chromium.org>

real_system_state.h

diff --git a/real_system_state.h b/real_system_state.h
index 32d972b..aac7efc 100644
--- a/real_system_state.h
+++ b/real_system_state.h
@@ -90,7 +90,7 @@
 
   virtual inline chromeos_policy_manager::PolicyManager* policy_manager()
       override {
-    return &policy_manager_;
+    return policy_manager_.get();
   }
 
   virtual inline bool system_rebooted() override {
@@ -142,7 +142,7 @@
 
   scoped_ptr<P2PManager> p2p_manager_;
 
-  chromeos_policy_manager::PolicyManager policy_manager_;
+  scoped_ptr<chromeos_policy_manager::PolicyManager> policy_manager_;
 
   policy::PolicyProvider policy_provider_;