commit 610277efc6f7e5239158dfa4bb3b1021804326e0
author Alex Deymo <deymo@chromium.org> Tue Nov 11 21:18:11 2014 -0800
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Thu Nov 13 00:30:08 2014 +0000
tree e1e66c8331bbb9ca4208f99cf9e644d9618470e3
parent aab50e31f0b80ed53a9b8d5dbabcf943974bd32c

update_engine: Add override when possible.

Google Style Guide requires to include the "override" keyword
when overriding a method on a derived class, so the compiler will
catch errors if the method is not overriding a member of the base
class.

This patch introduces the "override" keyword when possible.

BUG=None
TEST=FEATURES=test emerge-link update_engine

Change-Id: Ie83d115c5730f3b35b3d95859a54bc1a48e0be7b
Reviewed-on: https://chromium-review.googlesource.com/228928
Tested-by: Alex Deymo <deymo@chromium.org>
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>
Commit-Queue: Alex Deymo <deymo@chromium.org>

omaha_response_handler_action.h

diff --git a/omaha_response_handler_action.h b/omaha_response_handler_action.h
index da9550d..c3e4a68 100644
--- a/omaha_response_handler_action.h
+++ b/omaha_response_handler_action.h
@@ -38,11 +38,11 @@
       InputObjectType;
   typedef ActionTraits<OmahaResponseHandlerAction>::OutputObjectType
       OutputObjectType;
-  void PerformAction();
+  void PerformAction() override;
 
   // This is a synchronous action, and thus TerminateProcessing() should
   // never be called
-  void TerminateProcessing() { CHECK(false); }
+  void TerminateProcessing() override { CHECK(false); }
 
   // For unit-testing
   void set_boot_device(const std::string& boot_device) {
@@ -54,7 +54,7 @@
 
   // Debugging/logging
   static std::string StaticType() { return "OmahaResponseHandlerAction"; }
-  std::string Type() const { return StaticType(); }
+  std::string Type() const override { return StaticType(); }
   void set_key_path(const std::string& path) { key_path_ = path; }
 
  private: