update_engine: Add override when possible.
Google Style Guide requires to include the "override" keyword
when overriding a method on a derived class, so the compiler will
catch errors if the method is not overriding a member of the base
class.
This patch introduces the "override" keyword when possible.
BUG=None
TEST=FEATURES=test emerge-link update_engine
Change-Id: Ie83d115c5730f3b35b3d95859a54bc1a48e0be7b
Reviewed-on: https://chromium-review.googlesource.com/228928
Tested-by: Alex Deymo <deymo@chromium.org>
Reviewed-by: Alex Vakulenko <avakulenko@chromium.org>
Commit-Queue: Alex Deymo <deymo@chromium.org>
diff --git a/download_action.h b/download_action.h
index 6f16e20..3cf7e6a 100644
--- a/download_action.h
+++ b/download_action.h
@@ -53,9 +53,9 @@
DownloadAction(PrefsInterface* prefs,
SystemState* system_state,
HttpFetcher* http_fetcher);
- virtual ~DownloadAction();
- void PerformAction();
- void TerminateProcessing();
+ ~DownloadAction() override;
+ void PerformAction() override;
+ void TerminateProcessing() override;
// Testing
void SetTestFileWriter(FileWriter* writer) {
@@ -66,14 +66,14 @@
// Debugging/logging
static std::string StaticType() { return "DownloadAction"; }
- std::string Type() const { return StaticType(); }
+ std::string Type() const override { return StaticType(); }
// HttpFetcherDelegate methods (see http_fetcher.h)
- virtual void ReceivedBytes(HttpFetcher *fetcher,
- const char* bytes, int length);
- virtual void SeekToOffset(off_t offset);
- virtual void TransferComplete(HttpFetcher *fetcher, bool successful);
- virtual void TransferTerminated(HttpFetcher *fetcher);
+ void ReceivedBytes(HttpFetcher *fetcher,
+ const char* bytes, int length) override;
+ void SeekToOffset(off_t offset) override;
+ void TransferComplete(HttpFetcher *fetcher, bool successful) override;
+ void TransferTerminated(HttpFetcher *fetcher) override;
DownloadActionDelegate* delegate() const { return delegate_; }
void set_delegate(DownloadActionDelegate* delegate) {