commit 5bb4c90b8bdf931426d1926b21b0316a86b4b4e4
author Gilad Arnold <garnold@chromium.org> Thu Apr 10 12:32:13 2014 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Tue Apr 15 03:49:33 2014 +0000
tree a2add7388db2df241f826b5d670601a20279c1cf
parent 1f84723f499b3b309efac11324ed4e6c937341b6

Rename MockSystemState into FakeSystemState.

This class is no longer a mock. The change also includes renaming the
appropriate files and the instances of this class.

BUG=chromium:358278
TEST=Unit tests.

Change-Id: Ifc20ead0d624eddf8827a6e6f39cd9b9207dcabf
Reviewed-on: https://chromium-review.googlesource.com/194088
Reviewed-by: Gilad Arnold <garnold@chromium.org>
Tested-by: Gilad Arnold <garnold@chromium.org>
Commit-Queue: David Zeuthen <zeuthen@chromium.org>

download_action_unittest.cc

diff --git a/download_action_unittest.cc b/download_action_unittest.cc
index b238c69..20b616e 100644
--- a/download_action_unittest.cc
+++ b/download_action_unittest.cc
@@ -16,10 +16,10 @@
 
 #include "update_engine/action_pipe.h"
 #include "update_engine/download_action.h"
-#include "update_engine/mock_http_fetcher.h"
-#include "update_engine/mock_system_state.h"
-#include "update_engine/omaha_hash_calculator.h"
 #include "update_engine/fake_p2p_manager_configuration.h"
+#include "update_engine/fake_system_state.h"
+#include "update_engine/mock_http_fetcher.h"
+#include "update_engine/omaha_hash_calculator.h"
 #include "update_engine/prefs_mock.h"
 #include "update_engine/test_utils.h"
 #include "update_engine/utils.h"
@@ -468,14 +468,14 @@
     // Setup p2p.
     FakeP2PManagerConfiguration *test_conf = new FakeP2PManagerConfiguration();
     p2p_manager_.reset(P2PManager::Construct(test_conf, NULL, "cros_au", 3));
-    mock_system_state_.set_p2p_manager(p2p_manager_.get());
+    fake_system_state_.set_p2p_manager(p2p_manager_.get());
   }
 
   // To be called by tests to perform the download. The
   // |use_p2p_to_share| parameter is used to indicate whether the
   // payload should be shared via p2p.
   void StartDownload(bool use_p2p_to_share) {
-    mock_system_state_.request_params()->set_use_p2p_for_sharing(
+    fake_system_state_.request_params()->set_use_p2p_for_sharing(
         use_p2p_to_share);
 
     ScopedTempFile output_temp_file;
@@ -497,7 +497,7 @@
                                         data_.length(),
                                         NULL);
     // Note that DownloadAction takes ownership of the passed in HttpFetcher.
-    download_action_.reset(new DownloadAction(&prefs, &mock_system_state_,
+    download_action_.reset(new DownloadAction(&prefs, &fake_system_state_,
                                               http_fetcher_));
     download_action_->SetTestFileWriter(&writer);
     BondActions(&feeder_action, download_action_.get());
@@ -527,7 +527,7 @@
   ActionProcessor processor_;
 
   // A fake system state.
-  MockSystemState mock_system_state_;
+  FakeSystemState fake_system_state_;
 
   // The data being downloaded.
   string data_;