commit 5a46a18f4bedb1c5ee4a77050716b6809a71a9e4
author George Burgess IV <gbiv@google.com> Thu Jul 27 23:26:03 2017 -0700
committer George Burgess IV <gbiv@google.com> Sun Jul 30 22:25:18 2017 -0700
tree 005c87b069076a76421fbdf7161e50d46e4004cb
parent 4155520522b40a5e5f9b098eb903213d65d1cee6

Remove useless open mode

Open modes are ignored if the user doesn't want the file to be crated:
http://man7.org/linux/man-pages/man2/open.2.html

Since it's somewhat misleading/potentially indicative of a missing
O_CREAT/O_TMPFILE, we plan to issue a warning on open calls with useless
mode bits in the near future. Since -Werror is used in this project
(thank you!), we need to either make the mode useful, or remove it.

Bug: 64132680
Test: mma. New warning no longer appears.
Change-Id: I2ef32732956e2ef7ee46af2f8575b3bc7c0c5655

hardware_android.cc

diff --git a/hardware_android.cc b/hardware_android.cc
index 91c3fbe..4c5473f 100644
--- a/hardware_android.cc
+++ b/hardware_android.cc
@@ -71,8 +71,7 @@
            std::min(message.size(), sizeof(boot.recovery) - 1));
   }
 
-  int fd =
-      HANDLE_EINTR(open(misc_device.value().c_str(), O_WRONLY | O_SYNC, 0600));
+  int fd = HANDLE_EINTR(open(misc_device.value().c_str(), O_WRONLY | O_SYNC));
   if (fd < 0) {
     PLOG(ERROR) << "Opening misc";
     return false;