update_engine: Make SystemState accessible from everywhere
SystemState is supposed to be a global context and is used lamost
everywhere. So instead of passing it to functions and keeping multiple
pointers to it, its better to do what we did in dlcservice and make it a
singleton class with a getter that can be get from everywhere.
BUG=b:171829801
TEST=unittests
Change-Id: I3b2de9394b7769b3911195ca52d61dbe49afd4dd
Reviewed-on: https://chromium-review.googlesource.com/c/aosp/platform/system/update_engine/+/2521792
Commit-Queue: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Jae Hoon Kim <kimjae@chromium.org>
diff --git a/cros/omaha_request_params.h b/cros/omaha_request_params.h
index fa452ce..fd4c2e2 100644
--- a/cros/omaha_request_params.h
+++ b/cros/omaha_request_params.h
@@ -37,8 +37,6 @@
namespace chromeos_update_engine {
-class SystemState;
-
// This class encapsulates the data Omaha gets for the request, along with
// essential state needed for the processing of the request/response. The
// strings in this struct should not be XML escaped.
@@ -47,9 +45,8 @@
// reflect its lifetime more appropriately.
class OmahaRequestParams {
public:
- explicit OmahaRequestParams(SystemState* system_state)
- : system_state_(system_state),
- os_platform_(constants::kOmahaPlatformName),
+ OmahaRequestParams()
+ : os_platform_(constants::kOmahaPlatformName),
os_version_(kOsVersion),
delta_okay_(true),
interactive_(false),
@@ -327,9 +324,6 @@
// Gets the machine type (e.g. "i686").
std::string GetMachineType() const;
- // Global system context.
- SystemState* system_state_;
-
// The system image properties.
ImageProperties image_props_;
MutableImageProperties mutable_image_props_;