update_engine: Make SystemState accessible from everywhere
SystemState is supposed to be a global context and is used lamost
everywhere. So instead of passing it to functions and keeping multiple
pointers to it, its better to do what we did in dlcservice and make it a
singleton class with a getter that can be get from everywhere.
BUG=b:171829801
TEST=unittests
Change-Id: I3b2de9394b7769b3911195ca52d61dbe49afd4dd
Reviewed-on: https://chromium-review.googlesource.com/c/aosp/platform/system/update_engine/+/2521792
Commit-Queue: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Jae Hoon Kim <kimjae@chromium.org>
diff --git a/cros/fake_system_state.h b/cros/fake_system_state.h
index 2f92b7c..b1d5952 100644
--- a/cros/fake_system_state.h
+++ b/cros/fake_system_state.h
@@ -42,7 +42,11 @@
// OOBE is completed even when there's no such marker file, etc.
class FakeSystemState : public SystemState {
public:
- FakeSystemState();
+ static void CreateInstance() { g_instance_.reset(new FakeSystemState()); }
+
+ static FakeSystemState* Get() {
+ return reinterpret_cast<FakeSystemState*>(g_instance_.get());
+ }
// Base class overrides. All getters return the current implementation of
// various members, either the default (fake/mock) or the one set to override
@@ -237,6 +241,9 @@
}
private:
+ // Don't allow for direct initialization of this class.
+ FakeSystemState();
+
// Default mock/fake implementations (owned).
FakeBootControl fake_boot_control_;
FakeClock fake_clock_;