commit 433d6c4f856ab20f09f239936d9fa3da51e1011c
author Kelvin Zhang <zhangkelvin@google.com> Wed Mar 31 22:26:59 2021 -0400
committer Treehugger Robot <treehugger-gerrit@google.com> Tue Apr 27 18:29:58 2021 +0000
tree 2049c325d91d51ceca864cd52b612b769da702a6
parent f708ddadd2be246dbdef831e7e87eeac50f7c6a2

Unmmap all partitions after postinstall

Previous code will only unmap if postinstall finishes
successfully, move call to Unmap() to top of cleanup function.

Test: th
Change-Id: Ibb8b5cd82dbed46da1ed32a3ec370f1acbb42890

payload_consumer/postinstall_runner_action.cc

diff --git a/payload_consumer/postinstall_runner_action.cc b/payload_consumer/postinstall_runner_action.cc
index 8f2d674..de7848b 100644
--- a/payload_consumer/postinstall_runner_action.cc
+++ b/payload_consumer/postinstall_runner_action.cc
@@ -383,6 +383,11 @@
     }
   }
 
+  auto dynamic_control = boot_control_->GetDynamicPartitionControl();
+  CHECK(dynamic_control);
+  dynamic_control->UnmapAllPartitions();
+  LOG(INFO) << "Unmapped all partitions.";
+
   ScopedActionCompleter completer(processor_, this);
   completer.set_code(error_code);
 
@@ -401,10 +406,6 @@
   if (HasOutputPipe()) {
     SetOutputObject(install_plan_);
   }
-  auto dynamic_control = boot_control_->GetDynamicPartitionControl();
-  CHECK(dynamic_control);
-  dynamic_control->UnmapAllPartitions();
-  LOG(INFO) << "Unmapped all partitions.";
 }
 
 void PostinstallRunnerAction::SuspendAction() {

payload_consumer/snapshot_extent_writer.h

diff --git a/payload_consumer/snapshot_extent_writer.h b/payload_consumer/snapshot_extent_writer.h
index c3c64cd..c3a948e 100644
--- a/payload_consumer/snapshot_extent_writer.h
+++ b/payload_consumer/snapshot_extent_writer.h
@@ -14,6 +14,9 @@
 // limitations under the License.
 //
 
+#ifndef UPDATE_ENGINE_SNAPSHOT_EXTENT_WRITER_H_
+#define UPDATE_ENGINE_SNAPSHOT_EXTENT_WRITER_H_
+
 #include <cstdint>
 #include <vector>
 
@@ -52,3 +55,5 @@
 };
 
 }  // namespace chromeos_update_engine
+
+#endif