commit 42132993563a200785df323460a886aae1af27ed
author Kyeongkab.Nam <Kyeongkab.Nam@sony.com> Thu Oct 03 18:04:02 2019 +0900
committer Tao Bao <tbao@google.com> Mon Oct 07 16:38:07 2019 +0000
tree 1a1c1469a839127d0ab8676dd41dcc53906d73c1
parent 6cf830b8913e741d7d3c7ed047b2cbdbb222034e

Use ParcelFileDescriptor over FileDescriptor

The java.io.FileDescriptor object has a poor definition of ownership,
which can result in obscure use-after-close bugs. Instead, APIs should
return or accept ParcelFileDescriptor instances.

Bug: 130209137
Test: manual
Change-Id: Iad17731f34109493fc62d0ba0941998ce3ecb98c

binder_bindings/android/os/IUpdateEngine.aidl

diff --git a/binder_bindings/android/os/IUpdateEngine.aidl b/binder_bindings/android/os/IUpdateEngine.aidl
index cde05be..1305079 100644
--- a/binder_bindings/android/os/IUpdateEngine.aidl
+++ b/binder_bindings/android/os/IUpdateEngine.aidl
@@ -17,6 +17,7 @@
 package android.os;
 
 import android.os.IUpdateEngineCallback;
+import android.os.ParcelFileDescriptor;
 
 /** @hide */
 interface IUpdateEngine {
@@ -26,7 +27,7 @@
                     in long payload_size,
                     in String[] headerKeyValuePairs);
   /** @hide */
-  void applyPayloadFd(in FileDescriptor fd,
+  void applyPayloadFd(in ParcelFileDescriptor pfd,
                       in long payload_offset,
                       in long payload_size,
                       in String[] headerKeyValuePairs);