commit 2dfd35d8e912a8cb1a06cb3c9e629bf58deefa87
author Jae Hoon Kim <kimjae@chromium.org> Tue Jun 02 10:53:13 2020 -0700
committer Commit Bot <commit-bot@chromium.org> Wed Jun 03 03:10:49 2020 +0000
tree 867a557eafeaea90818ff8554976fde411115f7f
parent e0176278ce4e1745e5ff669765f09320b0f02642

update_engine: Log when EOL date is set + retrieved

autoupdate_EOL autotests seems to fail and return a default EOL date
value of -9999. This logging helps pinpoint whether prefs are the
culprit.

BUG=chromium:1090283
TEST=FEATURES=test emerge-$B update_engine update_engine-client

Change-Id: If2feb4841d2642af89dac94e699a30a7ee2fb002
Reviewed-on: https://chromium-review.googlesource.com/c/aosp/platform/system/update_engine/+/2227031
Tested-by: Jae Hoon Kim <kimjae@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>
Auto-Submit: Jae Hoon Kim <kimjae@chromium.org>
Commit-Queue: Jae Hoon Kim <kimjae@chromium.org>

update_attempter.cc

diff --git a/update_attempter.cc b/update_attempter.cc
index 5256192..60c2c36 100644
--- a/update_attempter.cc
+++ b/update_attempter.cc
@@ -1505,7 +1505,9 @@
   out_status->is_install = is_install_;
 
   string str_eol_date;
-  system_state_->prefs()->GetString(kPrefsOmahaEolDate, &str_eol_date);
+  if (system_state_->prefs()->Exists(kPrefsOmahaEolDate) &&
+      !system_state_->prefs()->GetString(kPrefsOmahaEolDate, &str_eol_date))
+    LOG(ERROR) << "Failed to retrieve kPrefsOmahaEolDate pref.";
   out_status->eol_date = StringToEolDate(str_eol_date);
 
   // A powerwash will take place either if the install plan says it is required